[pull] amdgpu, amdkfd, radeon drm-next-6.11

2024-06-07 Thread Alex Deucher
amd/display: Fix DSC-re-computing drm/amd/display: MST DSC check for older devices Alex Deucher (31): drm/amdgpu/mes12: print MES opcodes rather than numbers drm/amdgpu/mes12: increase mes submission timeout drm/amdgpu/mes12: Use a separate fence per transaction drm/amd

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-06-07 Thread Alex Deucher
: Tue Mar 26 10:42:05 2024 -0600 > > drm/amd/display: Drop legacy code > > This commit removes code that are not used by display anymore. > > Acked-by: Hamza Mahfooz > Signed-off-by: Rodrigo Siqueira > Signed-off-by: Alex Deucher > > drivers/gpu/

[pull] amdgpu drm-fixes-6.10

2024-06-06 Thread Alex Deucher
Hi Dave, Sima, A couple of fixes for 6.10. The following changes since commit c3f38fa61af77b49866b006939479069cd451173: Linux 6.10-rc2 (2024-06-02 15:44:56 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.10-2024-06-06

Re: [PATCH] drm/amd/display: Simplify if conditions

2024-06-05 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jun 4, 2024 at 9:07 AM Thorsten Blum wrote: > > The if conditions !A || A && B can be simplified to !A || B. > > Fixes the following Coccinelle/coccicheck warnings reported by > excluded_middle.cocci: > > WARNING !A || A && B is equivalent to !A || B >

Re: [PATCH][next] drm/amd/display: Fix a handful of spelling mistakes

2024-05-31 Thread Alex Deucher
Applied. Thanks! Alex On Fri, May 31, 2024 at 11:37 AM Randy Dunlap wrote: > > > > On 5/31/24 2:32 AM, Colin Ian King wrote: > > There are a few spelling mistakes in dml2_printf messages. Fix them. > > > > Signed-off-by: Colin Ian King > > > Reviewed-by: Randy Dunlap > > Thanks. > > > --- >

[pull] amdgpu, amdkfd drm-fixes-6.10

2024-05-30 Thread Alex Deucher
- Simplify APU VRAM handling Alex Deucher (4): drm/amdgpu: Adjust logic in amdgpu_device_partner_bandwidth() drm/amdgpu: silence UBSAN warning Revert "drm/amdkfd: fix gfx_target_version for certain 11.0.3 de

Re: [PATCH] drm/radeon: Remove __counted_by from StateArray.states[]

2024-05-30 Thread Alex Deucher
Applied. Thanks! On Wed, May 29, 2024 at 5:54 PM Nathan Chancellor wrote: > > From: Bill Wendling > > Work for __counted_by on generic pointers in structures (not just > flexible array members) has started landing in Clang 19 (current tip of > tree). During the development of this feature, a

Re: [PATCH] drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 2:47 AM Wolfram Sang wrote: > > Hi Alex, > > On Thu, May 09, 2024 at 01:15:32PM -0400, Alex Deucher wrote: > > On Thu, May 9, 2024 at 8:02 AM Heiner Kallweit wrote: > > > > > > Support for I2C_CLASS_SPD is currently being removed f

Re: [PATCH 1/4] [RESEND] drm/amd/display: dynamically allocate dml2_configuration_options structures

2024-05-29 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, May 28, 2024 at 7:52 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > This structure is too large to fit on a stack, as shown by the > newly introduced warnings from a recent code change: > >

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 9:51 AM Jani Nikula wrote: > > On Wed, 29 May 2024, Alex Deucher wrote: > > On Tue, May 28, 2024 at 5:03 PM Mario Limonciello > > wrote: > >> > >> If the lid on a laptop is closed when eDP connectors are populated > >> then it

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Alex Deucher
ACPI > lid status and if it's closed disable any eDP connectors. > > Reported-by: Chris Bainbridge > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 > Signed-off-by: Mario Limonciello Reviewed-by: Alex Deucher Do you have drm-misc access or do you need someone to appl

Re: [PATCH 2/2] drivers/gpu: Fix misalignment in comment block

2024-05-28 Thread Alex Deucher
Applied. Thanks! Alex On Tue, May 28, 2024 at 10:47 AM Bruno Rocha Levi wrote: > > This patch fixes a warning from checkpatch by ensuring the trailing */ is > aligned with the rest of the *, improving readability. > > Co-developed-by: Lucas Antonio > Signed-off-by: Lucas Antonio >

Re: [PATCH] drm/client: Detect when ACPI lid is closed during initialization

2024-05-27 Thread Alex Deucher
ACPI > lid status and if it's closed disable any eDP connectors. > > Suggested-by: Alex Deucher > Reported-by: Chris Bainbridge > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 > Signed-off-by: Mario Limonciello > --- > drivers/gpu/drm/drm_client_modese

Re: [PATCH] drm/amd/display: clean up some inconsistent indenting

2024-05-24 Thread Alex Deucher
Applied. Thanks! On Thu, May 23, 2024 at 10:37 PM Jiapeng Chong wrote: > > No functional modification involved. > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:5200 > dc_power_down_on_boot() warn: inconsistent indenting. > > Reported-by: Abaci Robot > Closes:

Re: [PATCH 1/4] drm/amdgpu: fix -Wformat-truncation warning in amdgpu_gfx_kiq_init_ring()

2024-05-23 Thread Alex Deucher
~ > 333 | xcc_id, ring->me, ring->pipe, ring->queue); > | ~~ > > Silence the warning by checking the snprintf() return value. > Already fixed with this patch: https://patchw

[pull] amdgpu, amdkfd drm-fixes-6.10

2024-05-22 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.10. The following changes since commit 5a5a10d9db77939a22e1d65fc0a4ba6b5d8f4fce: drm/buddy: Fix the warn on's during force merge (2024-05-20 06:42:12 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-05-21 Thread Alex Deucher
Applied and pushed out: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8a0a7b98d4b6eeeab337ec25daa4bc0a5e710a15 Alex On Tue, May 21, 2024 at 12:12 PM Alex Deucher wrote: > > I've got it teed up. Is drm-misc-fixes the right branch since we are > in the merge window? > >

Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-05-21 Thread Alex Deucher
I've got it teed up. Is drm-misc-fixes the right branch since we are in the merge window? Alex On Tue, May 21, 2024 at 7:20 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting > for once, to make this easily

Re: Kernel 5.15.150 black screen with AMD Raven/Picasso GPU

2024-05-20 Thread Alex Deucher
TALL_MOD_PATH=/boot2 modules_install > >> # cp arch/x86/boot/bzImage /boot2/vmlinuz > >> # sync > >> ...QV on Acer laptop, black screen! > >> > >> # git bisect bad > >> 56b522f4668167096a50c39446d6263c96219f5f is the first bad commit

Re: [PATCH 3/3] drm/amd/display: remove unused struct 'dc_reg_sequence'

2024-05-20 Thread Alex Deucher
Applied the series. Thanks! Alex On Fri, May 17, 2024 at 8:12 PM wrote: > > From: "Dr. David Alan Gilbert" > > 'dc_reg_sequence' was added in > commit 44788bbc309b ("drm/amd/display: refactor reg_update") > > but isn't actually used. > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert >

Re: [PATCH -next] drm/amd/display: Update optc35_set_odm_combine doc to match kernel-doc spec

2024-05-20 Thread Alex Deucher
On Fri, May 17, 2024 at 4:42 AM Yang Li wrote: > > This patch updates the function documentation comment for > optc35_set_odm_combine to conform to the kernel-doc specification. > > Signed-off-by: Yang Li Thanks for the patch. Srini already fixed this last week. Alex > --- >

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 1:27 PM Tim Van Patten wrote: > > > Fair enough, but this is also the only gfx9 APU which defaults to > > noretry=1, all of the rest are dGPUs. I'd argue it should align with > > the other GFX9 APUs or they should all enable noretry=1. > > Do you mean we should remove all

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 2:35 AM Christian König wrote: > > Am 16.05.24 um 19:57 schrieb Tim Van Patten: > > From: Tim Van Patten > > > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > > 9.3.0: > > > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > >

Re: [git pull] drm urgent for 6.10-rc1

2024-05-17 Thread Alex Deucher
On Thu, May 16, 2024 at 2:02 PM Linus Torvalds wrote: > > On Wed, 15 May 2024 at 19:54, Dave Airlie wrote: > > > > Here is the buddy allocator fix I picked up from the list, please apply. > > So I removed my reverts, and am running a kernel that includes the > merge 972a2543e3dd ("Merge tag

Re: [RFC v2 0/2] Discussion around eviction improvements

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 3:41 AM Tvrtko Ursulin wrote: > > > On 16/05/2024 20:21, Alex Deucher wrote: > > On Thu, May 16, 2024 at 8:18 AM Tvrtko Ursulin wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Reduced re-spin of my previous series

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-16 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 16, 2024 at 3:46 PM Tim Van Patten wrote: > > From: Tim Van Patten > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > 9.3.0: > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > > This causes the device to hang when

Re: [RFC v2 0/2] Discussion around eviction improvements

2024-05-16 Thread Alex Deucher
On Thu, May 16, 2024 at 8:18 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Reduced re-spin of my previous series after Christian corrected a few > misconceptions that I had. So lets see if what remains makes sense or is still > misguided. > > To summarise, the series address the

Re: [git pull] drm urgent for 6.10-rc1

2024-05-16 Thread Alex Deucher
On Thu, May 16, 2024 at 2:02 PM Linus Torvalds wrote: > > On Wed, 15 May 2024 at 19:54, Dave Airlie wrote: > > > > Here is the buddy allocator fix I picked up from the list, please apply. > > So I removed my reverts, and am running a kernel that includes the > merge 972a2543e3dd ("Merge tag

Re: Issues with mid-command buffer preemption

2024-05-16 Thread Alex Deucher
On Thu, May 16, 2024 at 4:12 AM Gregory Carter wrote: > > This problem on this particular machine can be avoided by using the kernel > command line option amdgpu.mcbp=0 Something else must be going on. mcbp is disabled by default except for SR-IOV virtual functions. Alex

Re: [PATCH] drm/amdgpu: Remove duplicate amdgpu_umsch_mm.h header

2024-05-16 Thread Alex Deucher
Applied. Thanks! On Thu, May 16, 2024 at 4:47 AM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/amdgpu/amdgpu.h: amdgpu_umsch_mm.h is included more > than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9063 > Signed-off-by: Jiapeng Chong > --- >

Re: [git pull] drm for 6.10-rc1

2024-05-16 Thread Alex Deucher
On Thu, May 16, 2024 at 4:42 AM Jani Nikula wrote: > > On Wed, 15 May 2024, Linus Torvalds wrote: > > On Wed, 15 May 2024 at 16:17, Dave Airlie wrote: > >> AMDGPU, I915 and XE all have !COMPILE_TEST on their variants > > > > Hmm. It turns out that I didn't notice the AMDGPU one because my > >

Re: linux-next: build warning after merge of the amdgpu tree

2024-05-14 Thread Alex Deucher
fixed with this patch: https://patchwork.freedesktop.org/patch/593995/ Sorry, I forgot to CC you. Alex > > Thanks, > Pratap > > -Original Message- > From: Stephen Rothwell > Sent: Tuesday, May 14, 2024 3:14 AM > To: Alex Deucher > Cc: Deucher, Alexander ; Nirujogi,

Re: [PATCH v2] drm/amd/display: fix documentation warnings for mpc.h

2024-05-13 Thread Alex Deucher
On Sat, May 11, 2024 at 12:22 AM Stephen Rothwell wrote: > > Hi Marcelo, > > On Sat, 11 May 2024 13:37:17 +1000 Stephen Rothwell > wrote: > > > > Thanks for doing this. > > > > I haven't tested it, but just a couple of little things: > > > > On Fri, 10 May 2024 21:02:02 -0300 Marcelo Mendes

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-13 Thread Alex Deucher
On Mon, May 13, 2024 at 8:20 AM Jani Nikula wrote: > > On Fri, 10 May 2024, Alex Deucher wrote: > > On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote: > >> > >> I've sent this some moths ago, let's try again... > >> > >> BR, > >> Jan

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-10 Thread Alex Deucher
: MST DSC check for older devices Alex Deucher (1): drm/amdkfd: don't allow mapping the MMIO HDP page with large pages Lijo Lazar (1): Revert "drm/amdkfd: Add partition id field to location_id" Mario Limonciello (1): dm/amd/pm: Fix problems with reboot/shutdown for some

Re: [pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-10 Thread Alex Deucher
Never mind. I'll send a new PR now. Alex On Fri, May 10, 2024 at 10:01 AM Alex Deucher wrote: > > On Thu, May 9, 2024 at 11:22 PM Dave Airlie wrote: > > > > On Thu, 9 May 2024 at 09:00, Alex Deucher wrote: > > > > > > Hi Dave, Sima, > > > &

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-10 Thread Alex Deucher
o from display info > drm/radeon: remove radeon_connector_edid() and stop using > edid_blob_ptr > drm/amdgpu: remove amdgpu_connector_edid() and stop using > edid_blob_ptr > drm/edid: add a helper for EDID sysfs property show > drm/connector: update edid_blob

Re: [pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-10 Thread Alex Deucher
On Thu, May 9, 2024 at 11:22 PM Dave Airlie wrote: > > On Thu, 9 May 2024 at 09:00, Alex Deucher wrote: > > > > Hi Dave, Sima, > > > > Fixes for 6.9. > > > > The following changes since commit dd5a440a31fae6e459c0d627162825505361: > >

Re: [PATCH] drm/radeon: Delay Connector detecting when HPD singals is unstable

2024-05-09 Thread Alex Deucher
On Thu, May 9, 2024 at 4:58 AM oushixiong wrote: > > From: Shixiong Ou > > In some causes, HPD signals will jitter when plugging in > or unplugging HDMI. > > Rescheduling the hotplug work for a second when EDID may still be > readable but HDP is disconnected, and fixes this issue. > >

Re: [PATCH] drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2

2024-05-09 Thread Alex Deucher
> > Signed-off-by: Heiner Kallweit Reviewed-by: Alex Deucher and applied. Thanks! > --- > drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c > b/drivers/gpu/d

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-08 Thread Alex Deucher
Alex Deucher (1): drm/amdkfd: don't allow mapping the MMIO HDP page with large pages Lijo Lazar (2): Revert "drm/amdkfd: Add partition id field to location_id" drm/amd/amdxcp: Fix warnings Mario Limonciello (1): dm/amd/pm: Fix problems with reboot/shutdown fo

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Wed, May 8, 2024 at 4:12 PM Easwar Hariharan wrote: > > On 5/8/2024 7:53 AM, Alex Deucher wrote: > > On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan > > wrote: > >> > >> On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > >>> I2C v7, SMBus

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan wrote: > > On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > > with more appropriate terms. Inspired by and following on to Wolfram's > > series to fix drivers/i2c/[1],

Re: [PATCH 2/5] drm/amdgpu: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Alex Deucher
On Mon, Apr 8, 2024 at 3:06 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Replace the open coded drm_crtc_vblank_crtc() with the real > thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: amd-...@lists.freedes

Re: [PATCH] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-05-03 Thread Alex Deucher
On Fri, May 3, 2024 at 1:06 PM Tvrtko Ursulin wrote: > > > On 03/05/2024 16:58, Alex Deucher wrote: > > On Fri, May 3, 2024 at 11:33 AM Daniel Vetter wrote: > >> > >> On Fri, May 03, 2024 at 01:58:38PM +0100, Tvrtko Ursulin wrote: > >>&g

Re: [PATCH] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-05-03 Thread Alex Deucher
> > confusion in the future. > > > > > > > > While at it also clarify that the reserved sub-string 'memory' refers to > > > > the memory region component. > > > > > > > > Signed-off-by: Tvrtko Ursulin > > > > Cc: Alex D

Re: [PATCH] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-05-03 Thread Alex Deucher
ing shared). > >> > >> Document that drm-memory- and drm-total-memory- are aliases to prevent > >> any > >> confusion in the future. > >> > >> While at it also clarify that the reserved sub-string 'memory' refers to > >>

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-05-01 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. The following changes since commit e67572cd2204894179d89bd7b984072f19313b03: Linux 6.9-rc6 (2024-04-28 13:47:24 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.9-2024-05-01 for you to fetch

Re: [PATCH] drm/amd/display: Add MSF panel to DPCD 0x317 patch list

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 8, 2024 at 8:58 PM wrote: > > From: Tobias Jakobi > > This 8.4 inch panel is integrated in the Ayaneo Kun handheld > device. The panel resolution is 2560×1600, i.e. it has > portrait dimensions. > > Decoding the EDID shows: > Manufacturer: MSF > Model: 4099 >

Re: [PATCH] drm/amd/display: Remove duplicate dcn401/dcn401_clk_mgr.h header

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 24, 2024 at 11:42 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c: > dcn401/dcn401_clk_mgr.h is included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8885 >

Re: [PATCH] drm/amd/display: Remove duplicate spl/dc_spl_types.h header

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 24, 2024 at 9:52 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/inc/hw/transform.h: spl/dc_spl_types.h is > included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8884 > Signed-off-by: Jiapeng

Re: [PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Sun, Apr 28, 2024 at 9:32 PM Zhou, Bob wrote: > > [Public] > > Reviewed-by: Bob Zhou > > Regards, > Bob > > -Original Message- > From: Dan Carpenter > Sent: 2024年4月28日 20:57 > To: Zhou, Bob > Cc: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; David

[pull] amdgpu, amdkfd drm-next-6.10

2024-04-26 Thread Alex Deucher
fix - Enable SQ watchpoint for gfx10 Alex Deucher (5): drm/amdkfd: demote unsupported device messages to dev_info drm/amdgpu/mes11: print MES opcodes rather than numbers drm/amdgpu/sdma5.2: use legacy HDP flush

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-04-24 Thread Alex Deucher
of restore worker - SVM fix Alex Deucher (1): drm/amdgpu/sdma5.2: use legacy HDP flush for SDMA2/3 Felix Kuehling (3): drm/amdkfd: Fix eviction fence handling drm/amdgpu: Update BO eviction priorities drm/amdkfd: Fix

Re: [PATCH] drm/amdgpu: Fixup bad vram size on gmc v6 and v7

2024-04-23 Thread Alex Deucher
On Tue, Apr 23, 2024 at 10:30 PM Qiang Ma wrote: > > On Mon, 22 Apr 2024 16:47:36 +0200 > Christian König wrote: > > > Am 22.04.24 um 16:40 schrieb Alex Deucher: > > > On Mon, Apr 22, 2024 at 9:00 AM Christian König > > > wrote: > > >> Am 22.04.

Re: [PATCH] drm/amdgpu: Fixup bad vram size on gmc v6 and v7

2024-04-22 Thread Alex Deucher
On Mon, Apr 22, 2024 at 9:00 AM Christian König wrote: > > Am 22.04.24 um 14:33 schrieb Qiang Ma: > > On Mon, 22 Apr 2024 11:40:26 +0200 > > Christian König wrote: > > > >> Am 22.04.24 um 07:26 schrieb Qiang Ma: > >>> Some boards(like Oland PRO: 0x1002:0x6613) seem to have > >>> garbage in the

[pull] amdgpu, amdkfd, radeon drm-next-6.10

2024-04-19 Thread Alex Deucher
- DMABuf import handling fix radeon: - Silence UBSAN warnings related to flexible arrays Ahmad Rehman (1): drm/amdgpu: Skip the coredump collection on reset during driver reload Alex Deucher (4): drm/amdgpu/gfx11

Re: [PATCH] drm/amd/display: Remove duplicate dcn32/dcn32_clk_mgr.h header

2024-04-19 Thread Alex Deucher
Reviewed-by: Alex Deucher And applied. Thanks! Alex On Thu, Apr 18, 2024 at 10:37 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c: > dcn32/dcn32_clk_mgr.h is included more than once. > > Reported-by: Abaci Robot

Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-18 Thread Alex Deucher
you just picked a random patch and opened a CVE. Alex > > -邮件原件----- > 发件人: Alex Deucher [mailto:alexdeuc...@gmail.com] > 发送时间: 2024年4月18日 9:58 > 收件人: wangzhu > 抄送: Greg KH ; harry.wentl...@amd.com; > sunpeng...@amd.com; rodrigo.sique...@amd.com; alexander.deuc...@amd.co

Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-17 Thread Alex Deucher
rface with the HW through > > the GPINT mailbox resulting in a system hang. > > > > [How] > > Add dc_wake_and_execute_gpint() to wrap the wake, execute, sleep > > sequence. > > > > If the GPINT executes successfully then DMCUB will be put back into > > sl

[pull] amdgpu, amdkfd, radeon drm-fixes-6.9

2024-04-17 Thread Alex Deucher
ial UAF in VA IOCTL - Fix visible VRAM handling during faults amdkfd: - Fix memory leak in create_process failure radeon: - Silence UBSAN warnings from variable sized arrays ---- Alex Deucher (3): Revert "drm/amd/display: f

Re: [PATCH] drm/amdgpu: Add missing space to DRM_WARN() message

2024-04-15 Thread Alex Deucher
On Mon, Apr 15, 2024 at 4:40 AM Thorsten Blum wrote: > > s/,please/, please/ > > Signed-off-by: Thorsten Blum Reviewed-by: Alex Deucher And applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

[pull] amdgpu, amdkfd, radeon drm-next-6.10

2024-04-13 Thread Alex Deucher
- Properly clean up workqueue during module unload - Fix memory leak process create failure - Range check CP bad op exception targets to avoid reporting invalid exceptions to userspace radeon: - Misc code cleanups Alex Deucher (2

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-12 Thread Alex Deucher
On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: > > On Fri, 12 Apr 2024 10:28:52 -0400 > Leo Li wrote: > > > On 2024-04-12 04:03, Pekka Paalanen wrote: > > > On Thu, 11 Apr 2024 16:33:57 -0400 > > > Leo Li wrote: > > > > > ... > > > >> That begs the question of what can be nailed down

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-04-10 Thread Alex Deucher
13.0.10 fix - VCN partition fix - GFX11 fixes - DWB fixes - Plane handling fix - FAMS fix - DCN 3.1.6 fix - VSC SDP fixes - OLED panel fix - GFX 11.5 fix amdkfd: - GPU reset fixes Alex Deucher (1): drm/amdgpu: always force full

Re: [PATCH -next] drm/amd/display: delete the redundant initialization in dcn3_51_soc

2024-04-08 Thread Alex Deucher
Acked-by: Alex Deucher Applied. Thanks, Alex On Mon, Apr 8, 2024 at 3:45 AM Xiang Yang wrote: > > the dram_clock_change_latency_us in dcn3_51_soc is initialized twice, so > delete one of them. > > Signed-off-by: Xiang Yang > --- > drivers/gpu/drm/amd/display/dc/dml/dc

Re: [PATCH v2] drm/radeon/radeon_display: Decrease the size of allocated memory

2024-04-08 Thread Alex Deucher
On Mon, Apr 1, 2024 at 8:35 AM Christian König wrote: > > Am 30.03.24 um 17:34 schrieb Erick Archer: > > This is an effort to get rid of all multiplications from allocation > > functions in order to prevent integer overflows [1] [2]. > > > > In this case, the memory allocated to store

Re: [PATCH] drm/amdgpu: add IP's FW information to devcoredump

2024-03-27 Thread Alex Deucher
tr atom_context->date Either way, Reviewed-by: Alex Deucher > --- > .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 122 ++ > 1 file changed, 122 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c > b/drivers/gpu/drm/amd/amdgpu/

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-03-27 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. Mostly fixes for new IPs added in 6.9. The following changes since commit 4cece764965020c22cff7665b18a012006359095: Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v2] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 11:41 PM Qiang Ma wrote: > > On Thu, 14 Mar 2024 14:40:40 + > "Deucher, Alexander" wrote: > > > [Public] > > > > > -Original Message- > > > From: Qiang Ma > > > Sent: Wednesday, March 13, 2024 2:18 AM > > > To: Deucher, Alexander ; Koenig, > > > Christian ;

Re: [PATCH] drm/amdgpu: add support of bios dump in devcoredump

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri wrote: > > dump the bios binary in the devcoredump. > > Signed-off-by: Sunil Khatri > --- > .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++ > 1 file changed, 20 insertions(+) > > diff --git

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 10:01 AM Alex Deucher wrote: > > On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin > wrote: > > > > Hi Alex, > > > > On 3/26/2024 7:08 PM, Alex Deucher wrote: > > > On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-26 Thread Alex Deucher
On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin wrote: > > Hi Alex, > > On 3/26/2024 7:08 PM, Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam > > wrote: > >> Add clear page support in vram memory region. > >>

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-26 Thread Alex Deucher
On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: > > Add clear page support in vram memory region. > > v1(Christian): > - Dont handle clear page as TTM flag since when moving the BO back > in from GTT again we don't need that. > - Make a specialized version of

Re: [PATCH] drm/amdgpu: fix deadlock while reading mqd from debugfs

2024-03-24 Thread Alex Deucher
On Sat, Mar 23, 2024 at 4:47 PM Sharma, Shashank wrote: > > > On 23/03/2024 15:52, Johannes Weiner wrote: > > On Thu, Mar 14, 2024 at 01:09:57PM -0400, Johannes Weiner wrote: > >> Hello, > >> > >> On Fri, Mar 08, 2024 at 12:32:33PM +0100, Christian König wrote: > >>> Am 07.03.24 um 23:07 schrieb

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-03-21 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. Fairly big because it's about 3 weeks of fixes. The following changes since commit 119b225f01e4d3ce974cd3b4d982c76a380c796d: Merge tag 'amd-drm-next-6.9-2024-03-08-1' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2024-03-11 13:32:12 +1000) are

Re: [PATCH] drm/amdgpu: fix function implicit declaration error

2024-03-21 Thread Alex Deucher
Acked-by: Alex Deucher On Thu, Mar 21, 2024 at 2:14 PM Sunil Khatri wrote: > > when CONFIG_DEV_COREDUMP is not defined in that case > when amdgpu_coredump() is called it does not find it's > definition and the build fails. > > This happens as the header

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: > > Am 19.03.24 um 15:26 schrieb Alex Deucher: > > On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: > >> Refactor the code so debugfs and devcoredump can reuse > >> the common informat

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
een sysfs, debugfs > and devcoredump. > > Cc: Christian König > Cc: Alex Deucher > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_devinfo.c | 15

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
and devcoredump can reuse > >>> the common information and avoid unnecessary copy of it. > >>> > >>> created a new file which would be the right place to > >>> hold functions which will be used between sysfs, debugfs > >>> and devcoredump. >

Re: [PATCH] drm/sched: fix null-ptr-deref in init entity

2024-03-15 Thread Alex Deucher
05150] RIP: 0033:0x77b1a94f > > [ +0.003647] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 > > 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 > > <41> 89 c0 3d 00 f0 ff ff 77 1f 48 8b 44 24 18 64 48 2b 04 25 28 00 > > [ +0.019097]

Re: [PATCH] drm/amdgpu: add the hw_ip version of all IP's

2024-03-15 Thread Alex Deucher
On Fri, Mar 15, 2024 at 8:13 AM Sunil Khatri wrote: > > Add all the IP's version information on a SOC to the > devcoredump. > > Signed-off-by: Sunil Khatri This looks great. Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 12:16 PM Khatri, Sunil wrote: > > > On 3/14/2024 8:12 PM, Alex Deucher wrote: > > On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote: > >> > >> On 3/14/2024 1:58 AM, Alex Deucher wrote: > >>> On Tue, Mar 12, 2024 at 8:41 AM

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote: > > > On 3/14/2024 1:58 AM, Alex Deucher wrote: > > On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: > >> Add all the IP's information on a SOC to the > >> devcoredump. > >> > >> Signed-of

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-14 Thread Alex Deucher
On Thu, Mar 14, 2024 at 2:10 AM Sharma, Shashank wrote: > > > On 14/03/2024 06:58, Khatri, Sunil wrote: > > > > On 3/14/2024 2:06 AM, Alex Deucher wrote: > >> On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri > >> wrote: > >>> Add firmware version i

Re: [PATCH AUTOSEL 5.15 3/5] drm/amdgpu: Enable gpu reset for S3 abort cases on Raven series

2024-03-13 Thread Alex Deucher
ges involved were also > backported, this should probably not be applied to older kernel > branches. I'm speculating it may be related to the removal of AMD IOMMUv2. > We should get confirmation from Prike, but I think he tested this on older kernels as well. Alex > Regards, >Felix > &

Re: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's

2024-03-13 Thread Alex Deucher
On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri wrote: > > Add firmware version information of each > IP and each instance where applicable. > Is there a way we can share some common code with devcoredump, debugfs, and the info IOCTL? All three places need to query this information and the same

Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

2024-03-13 Thread Alex Deucher
On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote: > > Add all the IP's information on a SOC to the > devcoredump. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git

Re: [PATCH v2 13/16] drm/ttm: make ttm_pool.h self-contained

2024-03-08 Thread Alex Deucher
re.kernel.org/oe-kbuild-all/202403072259.eec2vf1x-...@intel.com/ > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > include/drm/ttm/ttm_pool.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/drm/ttm/ttm_pool.h b/include/drm/ttm/ttm_poo

Re: [PATCH v2 10/16] drm/ttm: make ttm_caching.h self-contained

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote: > > Include for pgprot_t. > > Cc: Christian Koenig > Cc: Huang Rui > Acked-by: Thomas Zimmermann > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > include/drm/ttm/ttm_caching.h | 2 ++ >

Re: [PATCH v2 02/16] drm: add missing header guards to drm_crtc_helper_internal.h

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote: > > Including the file twice can lead to errors. > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_crtc_helper_internal.h | 5 + > 1 file changed, 5 insertions(+) > > d

Re: [PATCH v2 03/16] drm/encoder: improve drm_encoder_slave.h kernel-doc

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:08 AM Jani Nikula wrote: > > Document structs drm_encoder_slave_funcs, drm_encoder_slave, and > drm_i2c_encoder_driver. > > v2: Actually document the structs instead of just silencing kernel-doc > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deuch

Re: [PATCH v2 01/16] drm: add missing header guards to drm_crtc_internal.h

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:03 AM Jani Nikula wrote: > > Including the file twice can lead to errors. > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_crtc_internal.h | 5 + > 1 file changed, 5 insertions(+) > > d

[pull] amdgpu, amdkfd drm-next-6.9

2024-03-08 Thread Alex Deucher
update - NBIF 6.3.1 support - VPE 6.1.1 support amdkfd: - Misc fixes and cleanups - GFX10.1 trap fixes Alex Deucher (2): drm/amd/display: handle range offsets in VRR ranges drm/amdgpu: add VPE 6.1.1 discovery support

Re: [PATCH 2/2] drm/amdgpu: add vm fault information to devcoredump

2024-03-07 Thread Alex Deucher
On Thu, Mar 7, 2024 at 3:42 PM Khatri, Sunil wrote: > > > On 3/8/2024 12:44 AM, Alex Deucher wrote: > > On Thu, Mar 7, 2024 at 12:00 PM Sunil Khatri wrote: > >> Add page fault information to the devcoredump. > >> > >> Output of devcoredump: > >&g

Re: [PATCH 2/2] drm/amdgpu: add vm fault information to devcoredump

2024-03-07 Thread Alex Deucher
On Thu, Mar 7, 2024 at 12:00 PM Sunil Khatri wrote: > > Add page fault information to the devcoredump. > > Output of devcoredump: > AMDGPU Device Coredump > version: 1 > kernel: 6.7.0-amd-staging-drm-next > module: amdgpu > time: 29.725011811 > process_name: soft_recovery_p PID: 1720 >

Re: [PATCH 04/22] drm/amdgpu: make amd_asic_type.h self-contained

2024-03-07 Thread Alex Deucher
On Wed, Mar 6, 2024 at 1:43 PM Jani Nikula wrote: > > Include for u8. > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher Do you want me to pick this up? Otherwise, feel free to take it via whatever tree makes sense. Alex > --- > include/drm/amd_asic_type.h | 3 +++ &g

[pull] amdgpu drm-fixes-6.8

2024-03-07 Thread Alex Deucher
) amd-drm-fixes-6.8-2024-03-07: amdgpu: - SMU14 fix - Fix possible NULL pointer - VRR fix - pwm fix Alex Deucher (1): drm/amd/display: handle range offsets in VRR ranges Li Ma (1): drm/amd/swsmu: modify the gfx activity

Re: [PATCH] Removed redundant @ symbol to fix kernel-doc warnings in -next repo

2024-03-06 Thread Alex Deucher
Fixed up patch title prefix and applied. Thanks! Alex On Tue, Mar 5, 2024 at 10:48 PM R SUNDAR wrote: > > For linux-next repository. > > ./drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured > comments found > ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:132: warning:

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:42 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:59 PM, Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: > >> > >> On 3/6/2024 9:45 PM, Alex Deucher wrote: > >>> On Wed, Mar 6, 2024 at 11:06 AM Kha

  1   2   3   4   5   6   7   8   9   10   >