.
This had been discussed here.
[1]
https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel_names==2018-09-13_html=true
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_framebuffer.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
Add selftests for the following newly added functions:
- drm_format_info_block_width
- drm_format_info_block_height
- drm_format_info_min_pitch
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/selftests/Makefile| 3 +-
.../gpu/drm/selftests/drm_modeset_selftests.h | 3
From: Brian Starkey
AFBC is a flexible, proprietary, lossless compression protocol and
format, with a number of defined DRM format modifiers. To facilitate
consistency and compatibility between different AFBC producers and
consumers, document the expectations for usage of the AFBC DRM format
The idea is to split test implementations in different compilation
units, but have one single place where we define the list of tests,
in this case(drm_modeset_selftests.h).
Signed-off-by: Alexandru Gheorghe
---
...er_selftests.h => drm_modeset_selftests.h} | 0
.../drm/selftests/t
==2018-09-13_html=true
[4]
https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel_names==2018-09-14_html=true
Alexandru Gheorghe (7):
drm: fourcc: Convert drm_format_info kerneldoc to in-line member
documentation
drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info
Enable the following formats
- DRM_FORMAT_X0L0: DP650
- DRM_FORMAT_X0L2: DP550, DP650
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_hw.c | 14 +++---
drivers/gpu/drm/arm/malidp_planes.c | 23 +--
2 files changed, 32 insertions(+), 5 deletions
Mali-DP implements a number of tiled yuv formats which are not
currently described in drm_fourcc.h.
This adds those definitions and describes their memory layout by
using the newly added char_per_block, block_w, block_h.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_fourcc.c | 12
From: Brian Starkey
As we look to enable AFBC using DRM format modifiers, we run into
problems which we've historically handled via vendor-private details
(i.e. gralloc, on Android).
AFBC (as an encoding) is fully flexible, and for example YUV data can
be encoded into 1, 2 or 3 encoded
for computing the minimum required pitch.
- Improve/cleanup documentation
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_fb_cma_helper.c | 21 ++-
drivers/gpu/drm/drm_fb_helper.c | 6 ++
drivers/gpu/drm/drm_fourcc.c | 62
drivers
In-line member documentation seems to be desired way of documenting
structure members.
This change had been suggested by Daniel Vetter here:
https://lists.freedesktop.org/archives/dri-devel/2018-October/192176.html
Signed-off-by: Alexandru Gheorghe
---
include/drm/drm_fourcc.h | 30
test-drm-helper.ko can't be rmmod-ed because it doesn't have a
module_exit, that could be very inconvenient especially in the
development stage where we usually want to re-run the tests without
any rebooting.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/selftests/test-drm-helper.c | 5
Enable the following formats
- DRM_FORMAT_X0L0: DP650
- DRM_FORMAT_X0L2: DP550, DP650
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_hw.c | 14 +++---
drivers/gpu/drm/arm/malidp_planes.c | 23 +--
2 files changed, 32 insertions(+), 5 deletions
.
This had been discussed here.
[1]
https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel_names==2018-09-13_html=true
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_framebuffer.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
-log/?channel=dri-devel_names==2018-09-14_html=true
Alexandru Gheorghe (7):
drm: fourcc: Convert drm_format_info kerneldoc to in-line member
documentation
drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info
drm/fourcc: Add fourcc for Mali linear tiled formats
drm
From: Brian Starkey
AFBC is a flexible, proprietary, lossless compression protocol and
format, with a number of defined DRM format modifiers. To facilitate
consistency and compatibility between different AFBC producers and
consumers, document the expectations for usage of the AFBC DRM format
for computing the minimum required pitch.
- Improve/cleanup documentation
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_fb_cma_helper.c | 21 ++-
drivers/gpu/drm/drm_fb_helper.c | 6 ++
drivers/gpu/drm/drm_fourcc.c | 62
drivers
Add selftests for the following newly added functions:
- drm_format_info_block_width
- drm_format_info_block_height
- drm_format_info_min_pitch
Signed-off-by: Alexandru Gheorghe
---
.../gpu/drm/selftests/drm_helper_selftests.h | 3 +
drivers/gpu/drm/selftests/test-drm-helper.c | 277
From: Brian Starkey
As we look to enable AFBC using DRM format modifiers, we run into
problems which we've historically handled via vendor-private details
(i.e. gralloc, on Android).
AFBC (as an encoding) is fully flexible, and for example YUV data can
be encoded into 1, 2 or 3 encoded
In-line member documentation seems to be desired way of documenting
structure members.
This change had been suggested by Daniel Vetter here:
https://lists.freedesktop.org/archives/dri-devel/2018-October/192176.html
Signed-off-by: Alexandru Gheorghe
---
include/drm/drm_fourcc.h | 30
Mali-DP implements a number of tiled yuv formats which are not
currently described in drm_fourcc.h.
This adds those definitions and describes their memory layout by
using the newly added char_per_block, block_w, block_h.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_fourcc.c | 12
if possible.
Changes since v1:
- For imported buffers use the already populated
drm_gem_cma_object.sgt instead of calling
driver.gem_prime_get_sg_table, which works just for buffers
allocated through the gem_cma API.
Signed-off-by: Jamie Fox
Signed-off-by: Alexandru Gheorghe
[rebased and re
, suggestested by Daniel Vetter.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_blend.c | 22 ++
include/uapi/drm/drm_mode.h | 3 ++-
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c
index 402b62d3f072
by
the move of drm_atomic_crtc_set_property in drm_atomic_uapi.c.
Signed-off-by: Alexandru Gheorghe
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_atomic_helper.c | 8 +++-
drivers/gpu/drm/drm_atomic_uapi.c | 12 +++-
drivers/gpu/drm/drm_fb_helper.c | 1 -
3 files changed
, suggested by Maarten Lankhorst.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_atomic.c| 12 +++-
drivers/gpu/drm/drm_atomic_helper.c | 8 +++-
drivers/gpu/drm/drm_fb_helper.c | 1 -
3 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm
if coefficients need to be reprogrammed, but that never happens
because the save state has color_mgmt_changed set to 0.
Fix that by setting color_mgmt_changed to true if the crtc duplicated
state differs from the reset state.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_atomic_helper.c | 7
write them the first time NV12 is programmed,
suggested by Brian Starkey, here [1]
[1] https://lists.freedesktop.org/archives/dri-devel/2018-August/186819.html
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_hw.c | 25 +++--
drivers/gpu/drm/arm/malidp_hw.h
/subsampling. Anyway, I think it's best to just
put an warning in there and handle it when someone tries to add
support for them.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_atomic.c | 8 +++
drivers/gpu/drm/drm_fb_cma_helper.c | 11 -
drivers/gpu/drm
Enable the following formats
- DRM_FORMAT_XYUV
- DRM_FORMAT_XVYU2101010
- DRM_FORMAT_X0L0
- DRM_FORMAT_X0L2
- DRM_FORMAT_P010
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_hw.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm
Two new fields had been added to drm_format_info struct, tile_w and
tile_h, this need to be set to 1 for all non-tiled formats.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/i915/intel_display.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu
-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_fourcc.c | 352 +++
include/drm/drm_fourcc.h | 4 +
2 files changed, 281 insertions(+), 75 deletions(-)
diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
index 18bb960e9943..f55cd93ba2d0 100644
Malidp implements a number of yuv buffer formats which are not
currently described in drm_fourcc.h.
This adds those definitions and describes their memory layout.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_fourcc.c | 7 +++
include/uapi/drm/drm_fourcc.h | 27
/2018-July/184597.html
[2] https://lists.freedesktop.org/archives/dri-devel/2018-August/186465.html
[3] https://lists.freedesktop.org/archives/dri-devel/2018-August/186057.html
Alexandru Gheorghe (5):
drm/fourcc: Add new fourcc for malidp uncompressed formats
drm/fourcc: Add tile width
, probably we need to think of a way for userspace to
be able to program that, but for now I think this is better than not
working at all or not advertising NV12 as a supported format for
memwrite.
Reviewed-by: Liviu Dudau
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_hw.c | 25
if possible.
Signed-off-by: Jamie Fox
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_drv.h| 9 ++
drivers/gpu/drm/arm/malidp_hw.c | 17 +-
drivers/gpu/drm/arm/malidp_hw.h | 1 +
drivers/gpu/drm/arm/malidp_planes.c | 233
drivers/gpu/drm/arm
DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear
to me, so try to clarify that with a bit of ascii graphics.
Signed-off-by: Alexandru Gheorghe
---
include/uapi/drm/drm_mode.h | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/include/uapi/drm
to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/vc4/vc4_plane.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b
A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc.) to their default values.
Use that instead of duplicating the logic.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/exynos
to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.
Acked-by: Maxime Ripard
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers
to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.
Acked-by: Boris Brezillon
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
-by: Alexandru Gheorghe
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 4a0f0f41afa1..61824e360619 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b
A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc.) to their default values.
Use that instead of duplicating the logic.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/imx/ipuv3
A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc) to their default values.
Use that instead of duplicating the logic.
Reviewed-by: Harry Wentland
Signed-off-by: Alexandru Gheorghe
default value.
Tested with mali-dp the other drivers are just built-tested.
Alexandru Gheorghe (10):
drm/atomic: Add __drm_atomic_helper_plane_reset
drm/amd/display: Use __drm_atomic_helper_plane_reset instead of
copying the logic
drm: mali-dp: Use __drm_atomic_helper_plane_reset
-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_planes.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_planes.c
b/drivers/gpu/drm/arm/malidp_planes.c
index 29409a65d864..49c37f6dd63e 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.
Reviewed-by: Laurent Pinchart
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/rcar-du/rcar_du_plane.c | 6 ++
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 5 +
2
are the same as the defaults from core.
Change since v1:
- Make it consistent with the other helpers and require that both
plane and state not be NULL, suggested by Boris Brezillon and
Philipp Zabel.
Reviewed-by: Laurent Pinchart
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm
are the same as the defaults from core.
Change since v1:
- Make it consistent with the other helpers and require that both
plane and state not be NULL, suggested by Boris Brezillon and
Philipp Zabel.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_atomic_helper.c | 31
-by: Alexandru Gheorghe
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 4a0f0f41afa1..61824e360619 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b
A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc.) to their default values.
Use that instead of duplicating the logic.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/exynos
to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.
Acked-by: Boris Brezillon
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc) to their default values.
Use that instead of duplicating the logic.
Reviewed-by: Harry Wentland
Signed-off-by: Alexandru Gheorghe
-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_planes.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_planes.c
b/drivers/gpu/drm/arm/malidp_planes.c
index 29409a65d864..49c37f6dd63e 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/vc4/vc4_plane.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b
to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sun4i
to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 +---
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 4 +---
2 files changed, 2 insertions(+), 6
A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc.) to their default values.
Use that instead of duplicating the logic.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/imx/ipuv3
built-tested.
Alexandru Gheorghe (10):
drm/atomic: Add __drm_atomic_helper_plane_reset
drm/amd/display: Use __drm_atomic_helper_plane_reset instead of
copying the logic
drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying
the logic
drm: atmel-hlcdc: Use
Some drivers can't use drm_gem_fb_create, so instead of copying the
logic that does the framebuffer allocation allow them to use core
drm_gem_fb_alloc.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 3 ++-
include/drm/drm_gem_framebuffer_helper.h | 5
Malidp implements a number of yuv buffer formats which are not
currently described in drm_fourcc.h.
This adds those definitions and describes their memory layout.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_fourcc.c | 7 +++
include/uapi/drm/drm_fourcc.h | 27
: drm_fb_cma_get_gem_addr doesn't properly retrieves
start address, so I added the right formula for DRM_FORMAT_X0L0 and
DRM_FORMAT_X0L2 inside the driver.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_drv.c| 65 -
drivers/gpu/drm/arm/malidp_hw.c | 7
min_size and avoid
duplicating the code from drm_gem_fb_create_with_funcs.
If you have an opinion about how this should be handled feel free to
suggest it.
Alexandru Gheorghe (3):
drm/fourcc: Add malidp yuv formats
drm: Make drm_gem_fb_alloc available for drivers to use
drm: mali-dp
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 466336b34fff..1e0fb3c79b50 100644
--- a/drivers/gpu/drm/vmwgfx
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/imx/ipuv3-plane.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c
b/drivers/gpu/drm/imx/ipuv3-plane.c
index 203f247d4854..1bd4de03ce9e 100644
--- a/drivers/gpu/drm/imx/ipuv3
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c
b/drivers/gpu/drm/sun4i/sun4i_layer.c
index 750ad24de1d7..78f77af8805a 100644
--- a/drivers/gpu/drm/sun4i
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/vc4/vc4_plane.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
index 9d7a36f148cf..688ad9bb0f08 100644
--- a/drivers/gpu/drm/vc4/vc4_plane.c
+++ b
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 +---
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
index
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c
b/drivers/gpu/drm/exynos/exynos_drm_plane.c
index eb9915da7dec..681328fbe7de 100644
--- a/drivers/gpu
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_planes.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_planes.c
b/drivers/gpu/drm/arm/malidp_planes.c
index 29409a65d864..49c37f6dd63e 100644
--- a/drivers/gpu/drm/arm
are the same as the defaults from core.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_atomic_helper.c | 32 +
include/drm/drm_atomic_helper.h | 2 ++
2 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
drivers are just built-tested.
Alexandru Gheorghe (10):
drm/atomic: Add __drm_atomic_helper_plane_reset
drm/amd/display: Use __drm_atomic_helper_plane_reset instead of
copying the logic
drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying
the logic
drm: atmel-hlcdc
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index ca017c1dd4da
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
index 04440064b9b7..9330a076e15a 100644
which together with
drm_vblank_get have some magic that prevents calling drm_vblank_enable
when crtc is off.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm
Set possible_clones field to report that the writeback connector and
the one driving the display could be enabled at the same time.
Signed-off-by: Alexandru Gheorghe
Changes since v2:
- Use proper style for multi-line comments.
---
drivers/gpu/drm/arm/malidp_drv.c | 11 +++
1 file
Set possible_clones field to report that the writeback connector and
the one driving the display could be enabled at the same time.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_drv.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/arm
During iteration process one of the proposed mechanism for not
breaking existing userspace was to report writeback connectors as
disconnected, however the final version used
DRM_CLIENT_CAP_WRITEBACK_CONNECTORS for that purpose.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm
of writeback connector
in drm_helper_probe_single_connector_modes, see [1].
https://lists.freedesktop.org/archives/dri-devel/2018-July/183144.html
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_mw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm
Set possible_clones field to report that the writeback connector and
the one driving the display could be enabled at the same time.
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/arm/malidp_drv.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/arm
Writeback connector is reported as disconnected, currently this causes
the setting of the edid property to null and then exit.
In order to properly get the modes for writeback we need to add an
exception when connector type is DRM_MODE_CONNECTOR_WRITEBACK.
Signed-off-by: Alexandru Gheorghe
drm_private_state has a back pointer to the drm_atomic_state,
however that was not initialized in drm_atomic_get_private_obj_state
after duplication, as it is the case for other drm atomic getters
Signed-off-by: Alexandru Gheorghe
---
drivers/gpu/drm/drm_atomic.c | 1 +
1 file changed, 1
] last_error_status : 0x00e23001
[SE] last_error_vblank : 201
Changes since v2:
- Add lock to protect the errors stats.
- Add possibility to reset the error stats by writing anything to the
debug file.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drivers/gpu/d
] last_error_status : 0x00e23001
[SE] last_error_vblank : 201
This a morphosis of the patch presented here [1], where the errors
where reported continuously via trace_printk.
[1] https://lists.freedesktop.org/archives/dri-devel/2018-February/167042.html
Signed-off-by: Alexandru Gheorghe <alexan
. Commit copy to the unsed crtc and get the result as a
writeback_comp.
5. Copy the writeback comp and commit(if needed) to the display. The
copying of the writeback comp is needed because the crtc might not be
on the same dri node so the buffers will have to be re-imported.
Signed-off-by: Alexandru
(state !=
DRM_MODE_CONNECTED). What's not handled here and should be handle is
what happens if connector changes state while flattening, but since
hotplug is not wired yet, it's not something we should worry about.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.
-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmdisplaycompositor.cpp | 203 +--
drmdisplaycompositor.h | 7 +-
2 files changed, 204 insertions(+), 6 deletions(-)
diff --git a/drmdisplaycompositor.cpp b/drmdisplaycompositor.cpp
Add a vsync worker that calls back into the DrmDisplayCompositor,
for now at every 60 vsyncs if the scene does not change we trigger
the flattening of the scene using the writeback connector.
Other, more complex and proper heuristics could be implemented later
on.
Signed-off-by: Alexandru
There is a lot of boilerplate for creating an initialized
drmdisplaycomposition. This patch gathers that in a separate method.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmdisplaycompositor.cpp | 23 +++
drmdisplaycompositor.h | 2
ApplyFrame holds the lock just when it swaps the value of
active_composition_, in a multithread context we could end up in a
situation where something is shown on the screen, but something else
is set in active_composition_. Fix it by holding the lock during
CommitFrame.
Signed-off-by: Alexandru
Add utility functions to copy the DrmHwcLayer and DrmCompositionPlanes
from another DrmDisplayComposition.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmdisplaycomposition.cpp | 29 +
drmdisplaycomposition.h | 3 +++
2 files c
Currently Prepareframebuffer uses the mode of the connected connector
to decide how big the buffer should be, however when using the
drmdisplaycompositor just for flattening, the mode had not been set
yet, so we need a way to pass the desired buffer sizes.
Signed-off-by: Alexandru Gheorghe
encoder connected to a
crtc but with two or more, like is the case when we attach a writeback
connector, we need to know if we already assigned the encoder to a
display.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmencoder.cpp | 14 ++
drmencoder.h
that's already presented on another display.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmresources.cpp | 62 ++--
drmresources.h | 3 +++
2 files changed, 63 insertions(+), 2 deletions(-)
diff
://lists.freedesktop.org/archives/dri-devel/2018-February/167703.html
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmconnector.cpp | 42 +-
drmconnector.h | 7 +++
2 files changed, 48 insertions(+), 1 deletion(-)
diff
When doing flattening of a composition on a different CRTC we need to be
able to clone a layer in order to import it and then pass it to another CRTC.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmhwcomposer.h | 1 +
hwcutils.cpp| 11 +++
2
drmModeEncoder has a field called possible_clones. It's a bit mask
which tells if the encoder could be simultaneously connected, to the
same CRTC, with the encoders specified in the possible_clones mask.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmencod
: /dev/dri/card%
Additionally, this will be used for finding an available writeback
connector that will be used for the flattening of the currently
displayed scene.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
Android.mk | 1 +
resourcemanager.cp
Use the newly added ResourceManager for creating and detecting all the
drm devices instead of assuming that there is only one device.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmhwctwo.cpp| 34 +-
drmhwctwo.h
code paths.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
vsyncworker.cpp | 1 +
worker.cpp | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/vsyncworker.cpp b/vsyncworker.cpp
index 3bfe4be..7c0c741 100644
--- a/vsyncworker.cpp
By setting nl_pid to 0, we let the kernel to assign a port for us.
In the current implementation there is no way we could create more
than one instance for drmeventlistener.
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
drmeventlistener.cpp | 2 +-
1 file chan
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com>
---
vsyncworker.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/vsyncworker.cpp b/vsyncworker.cpp
index 3ad16fe..3bfe4be 100644
--- a/vsyncworker.cpp
+++ b/vsyncworker.cpp
@@ -35,6 +35,7 @@ VSyncWorker::VSync
1 - 100 of 111 matches
Mail list logo
