Re: [PATCH 17/18] drm/arcpgu: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Alexey Brodkin
Hi Yangtao, > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Thanks for the improvement. Acked-by: Alexey Brodkin > --- > drivers/gpu/drm/tiny/arcpgu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --gi

Re: [PATCH v2 3/7] drm/arc: use new debugfs device-centered functions

2023-01-09 Thread Alexey Brodkin
(), > before drm_dev_register(). > > Reviewed-by: Daniel Vetter > Signed-off-by: Maíra Canal > --- >  drivers/gpu/drm/tiny/arcpgu.c | 24 +--- >  1 file changed, 5 insertions(+), 19 deletions(-) Thanks for taking care of ARC PGU driver and Acked-by: Alexey Brodkin

Re: [PATCH] drm/arc: disambiguate Synopsys ARC in Kconfig labels

2022-10-27 Thread Alexey Brodkin
ys ARC PGU controller. > >If M is selected the module will be called arcpgu. Acked-by: Alexey Brodkin

RE: [PATCH 53/59] drm/arc: Move to drm/tiny

2020-05-09 Thread Alexey Brodkin
Hi Daniel, > > Looking at this patch series, feels a bit like hand-rolling of bridge > > code, badly. We should get away from that. > > > > Once you have that I think the end result is tiny enough that it can > > stay, bridges intergrate quite well into simple display pipe drivers. > > > > > BTW

RE: [PATCH 53/59] drm/arc: Move to drm/tiny

2020-04-16 Thread Alexey Brodkin
Hi Daniel, > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, April 15, 2020 12:45 PM > To: Daniel Vetter > Cc: Intel Graphics Development ; Alexey > Brodkin > ; DRI Development ; > Daniel Vetter > > Subject: Re: [PATCH 53/59] drm/arc: M

RE: [PATCH v2 05/17] drm/arc: make arcgpu_debugfs_init() return 0.

2020-03-12 Thread Alexey Brodkin
Hi Wambui, > -Original Message- > From: Wambui Karuga > Sent: Tuesday, March 10, 2020 8:31 PM > To: airl...@linux.ie; dan...@ffwll.ch; Alexey Brodkin > Cc: dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; > gre...@linuxfoundation.org > Subject: [PA

RE: [PATCH] DRM: ARC: PGU: interlaced mode not supported

2020-03-12 Thread Alexey Brodkin
Hi Greg, > -Original Message- > From: Greg KH > Sent: Wednesday, March 11, 2020 8:22 PM > To: Eugeniy Paltsev > Cc: dri-devel@lists.freedesktop.org; Alexey Brodkin ; > linux-snps- > a...@lists.infradead.org; linux-ker...@vger.kernel.org; David Airlie >

[GIT PULL] drm/arc: Filter out interlaced mode

2020-03-12 Thread Alexey Brodkin
Hi David, Daniel! The following changes since commit e3c3b6e66da1caeb39a504b03ddcdd3693e45254: Merge tag 'exynos-drm-fixes-for-v5.6-rc5-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes (2020-03-12 11:02:52 +1000) are available in the Git repository at:

RE: [PATCH 06/21] drm/arc: make arcpgu_debugfs_init return void

2020-02-28 Thread Alexey Brodkin
Hi Wambui, > -Original Message- > From: Wambui Karuga > Sent: Thursday, February 27, 2020 7:02 PM > To: dan...@ffwll.ch; airl...@linux.ie; Alexey Brodkin > Cc: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; > dri-devel@lists.freedesktop.org > Subject:

RE: [PATCH v2 5/9] arc: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-09 Thread Alexey Brodkin
t" version for const-safety > and consistency among architectures. Thanks for this clean-up. Looks good to me, so ... Acked-by: Alexey Brodkin ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[GIT PULL REBASED] drm/arc: Yet another set of minor fixes

2019-12-17 Thread Alexey Brodkin
Hi David, Daniel! The following changes since commit d1eef1c619749b2a57e514a3fa67d9a516ffa919: Linux 5.5-rc2 (2019-12-15 15:16:08 -0800) are available in the Git repository at: g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.12.16 for you to fetch changes up to

RE: [GIT PULL] drm/arc: Yet another set of minor fixes

2019-12-14 Thread Alexey Brodkin
Hi Daniel, [snip] > > Thanks for the pointers > > > > > Or respin this one, but these small pulls have a habit of occasionally > > > getting lost :-/ > > > > Well I'd better re-spin this, see below. > > > > The following changes since commit acc61b8929365e63a3e8c8c8913177795aa45594: > > > >

RE: [GIT PULL] drm/arc: Yet another set of minor fixes

2019-12-14 Thread Alexey Brodkin
Hi Daniel, > -Original Message- > From: Daniel Vetter > Sent: Friday, December 13, 2019 1:22 PM > To: Alexey Brodkin > Cc: Daniel Vetter ; David Airlie ; arcml > a...@lists.infradead.org>; Eugeniy Paltsev ; > dri-devel@lists.freedesktop.org > Subject:

[GIT PULL] drm/arc: Yet another set of minor fixes

2019-11-28 Thread Alexey Brodkin
Hi David, Daniel! The following changes since commit 8082731830a0b95f7f7a63b78de67de446013c80: drm/vram: remove unused declaration (2019-11-27 07:51:49 +0100) are available in the Git repository at: g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 for you to fetch changes

RE: [GIT PULL] drm/arc: Yet another set of minor fixes

2019-11-28 Thread Alexey Brodkin
Hi Daniel, > -Original Message- > From: Daniel Vetter > Sent: Wednesday, November 27, 2019 1:07 PM > To: Alexey Brodkin > Cc: Daniel Vetter ; David Airlie ; arcml > a...@lists.infradead.org>; Eugeniy Paltsev ; > dri-devel@lists.freedesktop.org > Subject:

RE: [GIT PULL] drm/arc: Minor improvements

2019-11-28 Thread Alexey Brodkin
Hi all, As Jose suggested I'm adding "drm-misc" maintainers as that tree might be a better fit for ARC PGU patches. -Alexey > -Original Message- > From: linux-snps-arc On Behalf > Of Alexey Brodkin > Sent: Wednesday, November 27, 2019 10:25 AM > To: Daniel Ve

RE: [GIT PULL] drm/arc: Minor improvements

2019-11-27 Thread Alexey Brodkin
Hi Daniel, David! Any chance for this one to be processed sometime soon? It's been quite some time since July when I initially sent this pull-request. -Alexey > -Original Message- > From: linux-snps-arc On Behalf > Of Alexey Brodkin > Sent: Wednesday, November 13,

RE: [GIT PULL] drm/arc: Minor improvements

2019-11-14 Thread Alexey Brodkin
Hi Daniel, David, > -Original Message- > From: linux-snps-arc On Behalf > Of Alexey Brodkin > Sent: Thursday, July 18, 2019 12:09 AM > To: Daniel Vetter ; David Airlie > Cc: arcml ; > dri-devel@lists.freedesktop.org > Subject: [GIT PULL] drm/arc: Minor i

[GIT PULL] drm/arc: Minor improvements

2019-07-18 Thread Alexey Brodkin
Hi Dave, Daniel, The following changes since commit 7aaddd96d5febcf5b24357a326b3038d49a20532: drm/modes: Don't apply cmdline's rotation if it wasn't specified (2019-07-16 10:34:38 +0200) are available in the Git repository at: g...@github.com:abrodkin/linux.git

RE: [PATCH v4 5/8] drm/arcpgu: prepare for drmP.h removal from drm_modeset_helper.h

2019-01-14 Thread Alexey Brodkin
Hi Sam, > -Original Message- > From: Sam Ravnborg [mailto:sam.ravnb...@gmail.com] On Behalf Of Sam Ravnborg > Sent: Saturday, January 12, 2019 10:33 PM > To: Alex Deucher ; Alexey Brodkin > ; Andrzej > Hajda ; Benjamin Gaignard > ; Chen Feng > ; Christian

Re: [PATCH 3/9] drm: replace "drm_dev_unref" function with "drm_dev_put"

2018-11-17 Thread Alexey Brodkin
4 ++-- For ARCPGU Acked-by: Alexey Brodkin ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup()

2018-10-02 Thread Alexey Brodkin
Hi Noralf, On Mon, 2018-10-01 at 14:05 +0200, Noralf Trønnes wrote: > > Den 01.10.2018 09.56, skrev Alexey Brodkin: > > Hi Noralf, > > > > On Fri, 2018-09-28 at 12:42 +0200, Noralf Trønnes wrote: > > > Den 28.09.2018 09.34, skrev Alexey Brodkin: > > >

Re: [PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup()

2018-10-02 Thread Alexey Brodkin
Hi Noralf, On Fri, 2018-09-28 at 12:42 +0200, Noralf Trønnes wrote: > Den 28.09.2018 09.34, skrev Alexey Brodkin: > > Hi Noralf, > > > > On Sat, 2018-09-08 at 15:46 +0200, Noralf Trønnes wrote: > > > The CMA helper is already using the drm_fb_helper_generic_probe p

Re: [PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup()

2018-10-01 Thread Alexey Brodkin
his is done to highlight the fact that fbdev emulation is an > internal client that makes use of the driver, it is not part of the > driver as such. If fbdev setup fails, an error is printed, but the driver > succeeds probing. > > Cc: Alexey Brodkin > Signed-off-by: Noralf Trønn

Re: [RESEND PATCH] drm/arc: Replace drm_dev_unref with drm_dev_put

2018-09-27 Thread Alexey Brodkin
I'll pick it up to my tree. Acked-by: Alexey Brodkin ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()

2018-09-27 Thread Alexey Brodkin
gt; Also use the drm_fb_helper functions directly. > Remove unused function prototype arcpgu_fbdev_cma_init(). > > Cc: Alexey Brodkin > Signed-off-by: Noralf Trønnes Similarly to drm/fsl-dcu driver this one never made it upstream. I was under impression that entire series will be either a

Re: [PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup()

2018-09-11 Thread Alexey Brodkin
his is done to highlight the fact that fbdev emulation is an > internal client that makes use of the driver, it is not part of the > driver as such. If fbdev setup fails, an error is printed, but the driver > succeeds probing. > > Cc: Alexey Brodkin > Signed-off-by: Noralf Trønne

Re: [PATCH 08/21] udl-kms: avoid prefetch

2018-06-16 Thread Alexey Brodkin
Hi Mikulas, On Wed, 2018-06-06 at 11:46 -0400, Mikulas Patocka wrote: > > On Wed, 6 Jun 2018, Alexey Brodkin wrote: > > > Hi Mikulas, > > > > On Tue, 2018-06-05 at 11:30 -0400, Mikulas Patocka wrote: > > > > > > On Tue, 5 Jun 2018, Al

Re: [PATCH 08/21] udl-kms: avoid prefetch

2018-06-07 Thread Alexey Brodkin
Hi Mikulas, On Tue, 2018-06-05 at 11:30 -0400, Mikulas Patocka wrote: > > On Tue, 5 Jun 2018, Alexey Brodkin wrote: > > > Hi Mikulas, > > > > On Sun, 2018-06-03 at 16:41 +0200, Mikulas Patocka wrote: > > > Modern processors can detect line

Re: [PATCH 08/21] udl-kms: avoid prefetch

2018-06-06 Thread Alexey Brodkin
Hi Mikulas, On Sun, 2018-06-03 at 16:41 +0200, Mikulas Patocka wrote: > Modern processors can detect linear memory accesses and prefetch data > automatically, so there's no need to use prefetch. Not each and every CPU that's capable of running Linux has prefetch functionality :) Still

Re: [PATCH 00/21] USB DisplayLink patches

2018-06-06 Thread Alexey Brodkin
Hi Mikulas, On Sun, 2018-06-03 at 16:40 +0200, Mikulas Patocka wrote: > Hi > > Here I'm sending bug fixes and performance improvements for the USB > DisplayLink framebuffer and modesetting drivers for this merge window. For such a long series it would be very nice to post a link to your git

Re: [PATCH] drm: Print unadorned pointers

2018-04-19 Thread Alexey Brodkin
On Wed, 2018-04-18 at 11:29 +0200, Maarten Lankhorst wrote: > Op 18-04-18 om 11:24 schreef Alexey Brodkin: > > After commit ad67b74 ("printk: hash addresses printed with %p") > > pointers are being hashed when printed. However, this makes > > debug output completely

[PATCH] drm: Print unadorned pointers

2018-04-19 Thread Alexey Brodkin
pe f -name "*.c" -exec sed -r -i '/DRM_DEBUG|KERN_DEBUG|pr_debug/ s/%p\b/%px/g' {} + Signed-off-by: Alexey Brodkin <abrod...@synopsys.com> Cc: Borislav Petkov <b...@suse.de> Cc: Tobin C. Harding <m...@tobin.cc> Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Andr

Re: DRM_UDL and GPU under Xserver

2018-04-10 Thread Alexey Brodkin
Hi Daniel, On Mon, 2018-04-09 at 11:17 +0200, Daniel Vetter wrote: > On Mon, Apr 09, 2018 at 08:55:36AM +0000, Alexey Brodkin wrote: > > Hi Daniel, > > > > On Mon, 2018-04-09 at 10:31 +0200, Daniel Vetter wrote: > > > On Thu, Apr 05, 2018 at 06:39:41PM +, Al

Re: DRM_UDL and GPU under Xserver

2018-04-10 Thread Alexey Brodkin
Hi Daniel, On Mon, 2018-04-09 at 10:31 +0200, Daniel Vetter wrote: > On Thu, Apr 05, 2018 at 06:39:41PM +0000, Alexey Brodkin wrote: > > Hi Daniel, all, [snip] > > Ok it was quite some time ago so I forgot about that completely. > > I really made one trivial change

Re: [PATCH 1/7] drm/arc: Stop consulting plane->fb

2018-04-06 Thread Alexey Brodkin
is no > corresponding check in the enable path. Also since > arc_pgu_set_pxl_fmt() will anyway oops if there is no fb I'm going > to assuming that I can just remove the check entirely. There seems > to be a general shortage of .atomic_check() in this driver... > > Cc: Alexey Brodki

Re: DRM_UDL and GPU under Xserver

2018-04-05 Thread Alexey Brodkin
Hi Daniel, Lucas, On Thu, 2018-04-05 at 12:59 +0200, Daniel Vetter wrote: > On Thu, Apr 5, 2018 at 12:29 PM, Lucas Stach <l.st...@pengutronix.de> wrote: > > Am Donnerstag, den 05.04.2018, 11:32 +0200 schrieb Daniel Vetter: > > > On Thu, Apr 5, 2018 at 9:16 AM, Alexey Br

Re: DRM_UDL and GPU under Xserver

2018-04-05 Thread Alexey Brodkin
Hi Daniel, all, On Thu, 2018-04-05 at 15:44 +0200, Daniel Vetter wrote: > On Thu, Apr 05, 2018 at 11:10:03AM +0000, Alexey Brodkin wrote: > > Hi Daniel, Lucas, > > > > On Thu, 2018-04-05 at 12:59 +0200, Daniel Vetter wrote: > > > On Thu, Apr 5, 2018

Re: DRM_UDL and GPU under Xserver

2018-04-05 Thread Alexey Brodkin
Hi Daniel, On Thu, 2018-04-05 at 08:18 +0200, Daniel Vetter wrote: > On Wed, Apr 4, 2018 at 10:06 PM, Alexey Brodkin > <alexey.brod...@synopsys.com> wrote: > > Hello, > > > > We're trying to use DisplayLink USB2-to-HDMI adapter to render > > GPU-acce

DRM_UDL and GPU under Xserver

2018-04-05 Thread Alexey Brodkin
Hello, We're trying to use DisplayLink USB2-to-HDMI adapter to render GPU-accelerated graphics. Hardware setup is as simple as a devboard + DisplayLink adapter. Devboards we use for this experiment are: * Wandboard Quad (based on IMX6 SoC with Vivante GPU) or * HSDK (based on Synopsys ARC HS38

Re: [PATCH] drm/arcpgu: remove drm_encoder_slave

2018-01-31 Thread Alexey Brodkin
gt; > real estate. > > > > v2: Actually git add after compile testing ... > > > > v3: Clarify commit message and stop including drm_encoder_slave.h. > > > > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > Cc: Alexey Brodkin <abrod

Re: [PATCH] drm/arcpgu: remove drm_encoder_slave

2018-01-31 Thread Alexey Brodkin
Hi Daniel, On Tue, 2018-01-30 at 18:07 +0100, Daniel Vetter wrote: > On Tue, Jan 30, 2018 at 5:44 PM, Alexey Brodkin > <alexey.brod...@synopsys.com> wrote: > > Hi Daniel, > > > > On Tue, 2018-01-30 at 10:15 +0100, Daniel Vetter wrote: > > > On Wed, Jan 17,

Re: [PATCH 00/12] Cargo cult cleanup in atomic drivers

2018-01-19 Thread Alexey Brodkin
Hi Laurent, On Wed, 2018-01-17 at 23:55 +0200, Laurent Pinchart wrote: > Hello, > > This patch series removes a few cargo-cult constructs from a set of atomic > drivers. > > Patches 01/12 and 02/12 remove the unneeded .mode_set() and .mode_set_base() > CRTC handlers from the arc and atmel-hlcdc

Re: [PATCH] drm/arcpgu: remove drm_encoder_slave

2018-01-18 Thread Alexey Brodkin
Hi Daniel, On Wed, 2018-01-17 at 14:43 +0100, Daniel Vetter wrote: > drm_encoder_slave is the old way to write bridge drivers, for i2c > bridges only. It's deprecated, and definitely should not be used in > new drivers. > > What's even strange is that arcpgu doesn't even use any of this, it >

Re: UDL's fbdev doesn't work for user-space apps

2017-12-14 Thread Alexey Brodkin
Hi Noralf, On Tue, 2017-12-12 at 22:58 +0100, Noralf Trønnes wrote: > Den 04.12.2017 12.32, skrev Alexey Brodkin: > > Hello, > > > > I'm trying to use DisplayLink USB2.0-to-HDMI adapter as the one and only > > video output and I want to get Xserver working on top of

Re: UDL's fbdev doesn't work for user-space apps

2017-12-13 Thread Alexey Brodkin
Hi Pavel, On Sat, 2017-12-09 at 18:20 +0100, Pavel Machek wrote: > On Mon 2017-12-04 11:50:40, Jose Abreu wrote: > > > > Hi Alexey, > > > > On 04-12-2017 11:32, Alexey Brodkin wrote: > > > > > > My first [probably incorrect] assumpti

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-06 Thread Alexey Brodkin
Hi Jose, On Tue, 2017-12-05 at 10:39 +, Jose Abreu wrote: > Hi Alexey, > > On 04-12-2017 17:29, Alexey Brodkin wrote: > > > > > > Indeed, in case of kmscube etnaviv is a renderer while UDL > > outputs the picture on the screen. > > Thats nice :)

Re: etnaviv: PHYS_OFFSET usage

2017-12-06 Thread Alexey Brodkin
Hi Lucas, On Wed, 2017-11-15 at 18:56 +0100, Lucas Stach wrote: > Am Mittwoch, den 15.11.2017, 17:36 + schrieb Alexey Brodkin: [snip] > I'm not keen on having a private memory region for the GPU. Normally we > just use the shared system CMA memory region (and we will point the

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-06 Thread Alexey Brodkin
Hi Jose, On Tue, 2017-12-05 at 12:26 +, Jose Abreu wrote: > On 05-12-2017 11:53, Alexey Brodkin wrote: > > > > > > From my note above about udl_drm_gem_mmap() being only used in case of > > Xserver > > I barely may conclude anything. Given my lack of kno

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-05 Thread Alexey Brodkin
Hi Jose, On Mon, 2017-12-04 at 17:24 +, Jose Abreu wrote: > On 04-12-2017 16:00, Alexey Brodkin wrote: > > > > [30.763] (II) armada(0): etnaviv: Xv: using YUY2 format intermediate > > YUV target > > > > I'm wondering if this means that target format f

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-05 Thread Alexey Brodkin
Hi Jose, On Mon, 2017-12-04 at 14:02 +, Jose Abreu wrote: > On 04-12-2017 13:16, Alexey Brodkin wrote: > > > > Option  "kmsdev" "/dev/dri/card1" > > Which drm driver uses /dev/dri/card0? I'm seing drmOpen code and > if

UDL's fbdev doesn't work for user-space apps

2017-12-05 Thread Alexey Brodkin
Hello, I'm trying to use DisplayLink USB2.0-to-HDMI adapter as the one and only video output and I want to get Xserver working on top of that. I'm not very familiar with all the parts of Linux GPU/video stack (especially its user-space counterpart) so my assumptions might be wrong in that case

xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-05 Thread Alexey Brodkin
Hi Jose, On Mon, 2017-12-04 at 11:50 +, Jose Abreu wrote: > Hi Alexey, > > On 04-12-2017 11:32, Alexey Brodkin wrote: > > > > My first [probably incorrect] assumption is Xserver requires fbdev > > (/dev/fbX) > > and it cannot use DRI vid

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-05 Thread Alexey Brodkin
Hi Jose, On Mon, 2017-12-04 at 15:55 +, Jose Abreu wrote: > On 04-12-2017 14:53, Alexey Brodkin wrote: > > > > Full log you may find below. > > Sorry but I meant /var/log/Xorg.0.log file. Ooops... sorry... here is it. -Alexey # cat /var/log/Xorg.0.log  [30

Re: glxgears on Etnaviv: couldn't get an RGB, Double-buffered visual

2017-11-27 Thread Alexey Brodkin
Hi Lucas, On Fri, 2017-11-24 at 17:11 +0100, Lucas Stach wrote: > Hi Alexey, > > Am Freitag, den 24.11.2017, 16:02 + schrieb Alexey Brodkin: > > > > Hello, > > > > Being in the middle of bring-up of the new board with Vivante GPU (HSD

Re: glxgears on Etnaviv: couldn't get an RGB, Double-buffered visual

2017-11-27 Thread Alexey Brodkin
Hi Lucas, On Fri, 2017-11-24 at 17:38 +0100, Lucas Stach wrote: > Am Freitag, den 24.11.2017, 16:25 + schrieb Alexey Brodkin: > > > > Hi Lucas, > > > > On Fri, 2017-11-24 at 17:11 +0100, Lucas Stach wrote: > > > > > > Hi Alexey, > > >

Re: glxgears on Etnaviv: couldn't get an RGB, Double-buffered visual

2017-11-27 Thread Alexey Brodkin
Hi Lucas, On Fri, 2017-11-24 at 18:11 +0100, Lucas Stach wrote: > Am Freitag, den 24.11.2017, 16:49 + schrieb Alexey Brodkin: > [...] > > > > > > > > Yes, a "core" in Vivante speak is a GPU with one DMA frontend. A > > > single > >

glxgears on Etnaviv: couldn't get an RGB, Double-buffered visual

2017-11-27 Thread Alexey Brodkin
Hello, Being in the middle of bring-up of the new board with Vivante GPU (HSDK namely, see  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arc/plat-hsdk) I was looking at simple 3D test apps to see how Etnaviv works on the hardware. So far I was able to get kmscube

Re: [PATCH v2 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()

2017-11-22 Thread Alexey Brodkin
gt; Also use the drm_fb_helper functions directly. > Remove unused function prototype arcpgu_fbdev_cma_init(). > > Cc: Alexey Brodkin <abrod...@synopsys.com> > Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Alexey Brodkin <abrod...@synopsys.com> _

Re: [PATCH v2 00/22] drm/cma-helper: Remove drm_fbdev_cma* functions

2017-11-22 Thread Alexey Brodkin
Hi Noralf, On Tue, 2017-11-21 at 00:52 +0100, Noralf Trønnes wrote: > Den 17.11.2017 10.10, skrev Alexey Brodkin: > > > > Hi Noralf, > > > > On Thu, 2017-11-16 at 21:11 +0100, Noralf Trønnes wrote: > > > > > > Den 16.11.2017 09.14, skrev Shawn Guo

Re: [PATCH v2 00/22] drm/cma-helper: Remove drm_fbdev_cma* functions

2017-11-20 Thread Alexey Brodkin
Hi Noralf, On Thu, 2017-11-16 at 21:11 +0100, Noralf Trønnes wrote: > Den 16.11.2017 09.14, skrev Shawn Guo: > > > > On Wed, Nov 15, 2017 at 03:19:39PM +0100, Noralf Trønnes wrote: > > > > > > This patchset adds drm_fb_cma_fbdev_init/fini() functions that replaces > > >

Re: etnaviv: PHYS_OFFSET usage

2017-11-16 Thread Alexey Brodkin
Hi Lucas, On Wed, 2017-11-15 at 17:44 +0100, Lucas Stach wrote: > Hi Alexey, > > Am Mittwoch, den 15.11.2017, 16:24 + schrieb Alexey Brodkin: > > > > Hi Lucas, > > > > As we discussed on ELCE last month in Prague we have Vivante GPU > > buil

etnaviv: PHYS_OFFSET usage

2017-11-16 Thread Alexey Brodkin
Hi Lucas, As we discussed on ELCE last month in Prague we have Vivante GPU built-in our new ARC HSDK development board. And even though [thanks to your suggestions] I got Etnaviv driver working perfectly fine on our board I faced one quite a tricky situation [which I dirty worked-around for

Re: [PATCH v5 08/12] drm/arc: Use drm_gem_cma_print_info()

2017-11-08 Thread Alexey Brodkin
Hi Noralf, On Tue, 2017-11-07 at 20:13 +0100, Noralf Trønnes wrote: > There is a new core debugfs file that prints fb/gem info: > /dri//framebuffer > > Use drm_gem_cma_print_info() to provide info to that output instead > of using drm_fb_cma_debugfs_show(). > > Cc:

Re: [PATCH v4 07/11] drm/arc: Use drm_gem_cma_print_info()

2017-11-01 Thread Alexey Brodkin
Hi Noralf, On Mon, 2017-10-30 at 17:29 +0100, Noralf Trønnes wrote: > There is a new core debugfs file that prints fb/gem info: > /dri//framebuffer > > Use drm_gem_cma_print_info() to provide info to that output instead > of using drm_fb_cma_debugfs_show(). > > Cc: 

RE: [PATCH v3 04/22] drm/arc: Use drm_gem_fb_create()

2017-08-28 Thread Alexey Brodkin
bject: [PATCH v3 04/22] drm/arc: Use drm_gem_fb_create() > > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now, > so use the function directly. Acked-by: Alexey Brodkin <abrod...@synopsys.com> ___ dri-devel mailing list dri-devel

[PULL] Please pull ARCPGU changes

2017-08-02 Thread Alexey Brodkin
->mode_valid() callback (2017-08-03 00:11:02 +0300) ---- Alexey Brodkin (2):   drm/arcpgu: Opt in debugfs   arcpgu: Simplify driver name Jose Abreu (3):   drm: arcpgu: Fix mmap() callback   drm: arcpgu: Fix module unload   

Re: Please pull ARCPGU changes

2017-08-02 Thread Alexey Brodkin
Hi Alex, On Wed, 2017-08-02 at 14:24 -0400, Alex Deucher wrote: > On Wed, Aug 2, 2017 at 6:16 AM, Alexey Brodkin > <alexey.brod...@synopsys.com> wrote: > > > > Hi Daniel, > > > > On Wed, 2017-08-02 at 11:41 +0200, Daniel Vetter wrote: > > > &

Re: Please pull ARCPGU changes

2017-08-02 Thread Alexey Brodkin
Hi Daniel, On Wed, 2017-08-02 at 11:41 +0200, Daniel Vetter wrote: > On Mon, Jul 31, 2017 at 11:11:06AM +0000, Alexey Brodkin wrote: > > > > Hi Dave, > > > > Could you please pull a couple of minor fixes for ARCPGU. > > These changes are based on today's drm-m

Please pull ARCPGU changes

2017-07-31 Thread Alexey Brodkin
300) ---- Alexey Brodkin (2):   drm/arcpgu: Opt in debugfs   arcpgu: Simplify driver name Jose Abreu (3):   drm: arcpgu: Fix mmap() callback   drm: arcpgu: Fix module unload   drm: arcpgu: Allow some clock deviation in c

RE: [PATCH 03/41] drm/arc: Use .dumb_map_offset and .dumb_destroy defaults

2017-07-24 Thread Alexey Brodkin
..@hisilicon.com; yannick.fer...@st.com; Noralf Trønnes > <nor...@tronnes.org> > Subject: [PATCH 03/41] drm/arc: Use .dumb_map_offset and .dumb_destroy > defaults > > This driver can use the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset defaults, so no need to se

Re: [PATCH] drm: arcpgu: Allow some clock deviation in crtc->mode_valid() callback

2017-07-12 Thread Alexey Brodkin
ys.com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> Finally our problem with EDID-less monitor is fix

Re: [PATCH 2/8] drm: arcpgu: Remove CRTC .prepare() helper operation

2017-06-28 Thread Alexey Brodkin
;   .enable = arc_pgu_crtc_enable, >   .disable= arc_pgu_crtc_disable, > - .prepare= arc_pgu_crtc_disable, >   .atomic_begin = arc_pgu_crtc_atomic_begin, >  }; Acked-by: Alexey Brodkin <abrod...@synopsys.com> ___

Re: [PATCH 8/8] drm: Convert atomic drivers from CRTC .disable() to .atomic_disable()

2017-06-28 Thread Alexey Brodkin
gt; .disable() in new drivers. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > --- >  drivers/gpu/drm/arc/arcpgu_crtc.c   | 5 +++-- For arcpgu: Acked-by: Alexey Brodkin <abrod...@synopsys.com> __

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Alexey Brodkin
o be consistent > with .atomic_disable(), as the .enable() operation is used by atomic > helpers only. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > --- >  drivers/gpu/drm/arc/arcpgu_crtc.c   |  5 ++-- For arcpgu: Acked-by

Re: [PATCH 1/8] drm: arcpgu: Remove CRTC .commit() helper operation

2017-06-28 Thread Alexey Brodkin
.disable= arc_pgu_crtc_disable, >   .prepare= arc_pgu_crtc_disable, > - .commit = arc_pgu_crtc_enable, >   .atomic_begin = arc_pgu_crtc_atomic_begin, >  }; Acked-by: Alexey Brodkin <abrod...@synopsys.com> ___ dri-devel mail

Re: [PATCH 15/37] drm/arcgpu: Drop drm_vblank_cleanup

2017-05-24 Thread Alexey Brodkin
pretty sweet somewhere (and maybe getting rid of the load/unload > callbacks while at it). > > Cc: Alexey Brodkin <abrod...@synopsys.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > --- >  drivers/gpu/drm/arc/arcpgu_drv.c | 1 - >  1 file changed, 1 dele

Re: [PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback

2017-05-22 Thread Alexey Brodkin
t; a clock value in the commit() stage but unfortunatelly this clock > does not support all the needed ranges. > > Also, remove the atomic_check() callback as mode_valid() callback > will be called before. > > Signed-off-by: Jose Abreu <joab...@synopsys.com> > Cc: Ca

[PATCH] arcpgu: Simplify driver name

2017-04-22 Thread Alexey Brodkin
This very minor change is still useful because it aligns ARC PGU driver name with other DRM drivers and makes usage of that driver name a bit easier. For example in libdrm's test app we'll use "arcpgu" instead of a bit more ugly "drm-arcpgu". Signed-off-by: Alexey Brodkin &l

Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

2017-03-29 Thread Alexey Brodkin
Hi Liviu, Rob, On Fri, 2017-03-03 at 18:21 +, liviu.du...@arm.com wrote: > On Fri, Mar 03, 2017 at 05:48:19PM +0000, Alexey Brodkin wrote: > > > > Hi Liviu, > > > > On Fri, 2017-03-03 at 16:28 +, Liviu Dudau wrote: > > > > > > On Fri, Mar

[PATCH] drm/arcpgu: Get rid of "encoder-slave" property

2017-03-05 Thread Alexey Brodkin
We used to use "encoder-slave" property in PGU's Device Tree node to refer to the encoder, but since there's a way to find it with some code smarts we get rid of obviously extra complication in PGU node. Again inspired by ARM's HDLCD code. Signed-off-by: Alexey Brodkin <abrod...@syn

Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

2017-03-05 Thread Alexey Brodkin
Hi Liviu, On Fri, 2017-03-03 at 16:28 +, Liviu Dudau wrote: > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote: > > > > - /* find the encoder node and initialize it */ > > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slav

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-05 Thread Alexey Brodkin
Hi Daniel, On Thu, 2017-03-02 at 20:54 +0100, Daniel Vetter wrote: > On Thu, Mar 02, 2017 at 08:27:54PM +0300, Alexey Brodkin wrote: > > > > Since we cannot always generate exactly requested pixel clock > > there's not much sense in checking requested_clock == clk_round_rat

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-05 Thread Alexey Brodkin
Hi Jose, On Fri, 2017-03-03 at 18:05 +, Jose Abreu wrote: > Hi Alexey, > > > On 03-03-2017 13:27, Alexey Brodkin wrote: > > > > > > So if I understood you correct here what I really need is just to get rid > > of existing check, > > right

[PATCH] drm/arcpgu: Opt in debugfs

2017-03-05 Thread Alexey Brodkin
This change adopts debugfs usage for outputting useful data. As of today we print: * Mode and real HW clock values * Standard FB info Code is heavily borrowed from ARM's HDLCD thus adding Liviu in Cc. Signed-off-by: Alexey Brodkin <abrod...@synopsys.com> Cc: Liviu Dudau <liviu.du..

[PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-02 Thread Alexey Brodkin
still give it a try with the clock as close to requested one as PLL on the board may generate. So we just do a fixup to what current board may provide. Signed-off-by: Alexey Brodkin <abrod...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: David Airlie <airl...@linux.ie&

Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Alexey Brodkin
t; function hook.  So the drm_vblank_no_hw_counter assignment in the driver > code becomes redundant and can be removed now. > > Signed-off-by: Shawn Guo <shawn@linaro.org> > Cc: Alexey Brodkin <abrod...@synopsys.com> For ARC PGU part Acked-by: Alexey Brodkin <abrod...@synopsys.com>

[PATCH] drm: Make the connector .detect() callback optional

2016-11-30 Thread Alexey Brodkin
 Â Â Â Â Â Â Â Â Â Â Â Â Â |  7 > --- For ARC PGU Acked-by: Alexey Brodkin -Alexey

[PATCH 08/37] drm/arcpgu: Add local 'fb' variables

2016-11-23 Thread Alexey Brodkin
Hi Ville, On Fri, 2016-11-18 at 21:52 +0200, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > Add a local 'fb' variable to a few places to get rid of the > 'crtc->primary->fb' stuff. Looks neater and helps me with my ppor > coccinelle skills later. &g

[PATCH 08/37] drm/arcpgu: Add local 'fb' variables

2016-11-21 Thread Alexey Brodkin
Hi Ville, On Fri, 2016-11-18 at 21:52 +0200, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > Add a local 'fb' variable to a few places to get rid of the > 'crtc->primary->fb' stuff. Looks neater and helps me with my ppor > coccinelle skills later. &g

[PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

2016-11-10 Thread Alexey Brodkin
Hi Daniel, David, On Wed, 2016-11-02 at 12:23 +, Alexey Brodkin wrote: > Hi Daniel, David, > > On Mon, 2016-10-24 at 18:33 +0000, Alexey Brodkin wrote: > > > > Hi Daniel, > > > > > > > > > > > -Original Message- >

[PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

2016-11-02 Thread Alexey Brodkin
Hi Daniel, David, On Mon, 2016-10-24 at 18:33 +, Alexey Brodkin wrote: > Hi Daniel, > > > > > -Original Message- > > From: linux-snps-arc [mailto:linux-snps-arc-bounces at lists.infradead.org] > > On Behalf Of Alexey Brodkin > > Sent: 19 окÑ

[PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

2016-10-24 Thread Alexey Brodkin
Hi Daniel, > -Original Message- > From: linux-snps-arc [mailto:linux-snps-arc-bounces at lists.infradead.org] > On Behalf Of Alexey Brodkin > Sent: 19 октября 2016 г. 12:33 > To: dri-devel at lists.freedesktop.org; architt at codeaurora.org; > Eugeniy.Palts

[PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

2016-10-19 Thread Alexey Brodkin
Hi Archit, all, On Wed, 2016-10-19 at 14:43 +0530, Archit Taneja wrote: > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote: > > > > ARC PGU driver starts crashing on initialization after > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' > > This happenes because in

[PATCH] drm/arcpgu: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()

2016-07-19 Thread Alexey Brodkin
call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Good catch! Acked-by: Alexey Brodkin

[PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load()

2016-07-19 Thread Alexey Brodkin
Hi Wei Yongjun, On Tue, 2016-07-19 at 12:01 +, Wei Yongjun wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun Acked-by: Alexey Brodkin

[PATCH -next] drm/arc: Fix some sparse warnings

2016-07-19 Thread Alexey Brodkin
c/arcpgu_drv.c:134:48: warning: >   Using plain integer as NULL pointer > drivers/gpu/drm/arc/arcpgu_drv.c:155:5: warning: >   symbol 'arcpgu_unload' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Acked-by: Alexey Brodkin

of_reserved_mem_device_init_by_idx() returns -EINVAL if "memory-region" is missing

2016-06-17 Thread Alexey Brodkin
Hi Marek, On Fri, 2016-06-17 at 07:28 +0200, Marek Szyprowski wrote: > Hi Alexey > > > On 2016-06-16 18:47, Alexey Brodkin wrote: > > > > Hi Marek, > > > > We used to use of_reserved_mem_device_init() in such a context in GPU >

of_reserved_mem_device_init_by_idx() returns -EINVAL if "memory-region" is missing

2016-06-16 Thread Alexey Brodkin
Hi Marek, We used to use of_reserved_mem_device_init() in such a context in GPU drivers: >8--- /* Get the optional framebuffer memory resource */ ret = of_reserved_mem_device_init(drm->dev); if (ret && ret != -ENODEV)

[GIT PULL] drm/arcpgu: Make ARC PGU usable on sim platforms

2016-06-13 Thread Alexey Brodkin
5:18 +0200) -------- Alexey Brodkin (2):       ARCv2: [vdk] Enable ARC PGU on HS38 VDK       ARC: [nsimosci] Enable ARC PGU on nSIM OSCI virtual platforms Ruud Derwig (1):       drm/arcpgu: Make ARC PGU usable on simulation platforms  arch/arc/boot/dts/nsimosci.dts          

  1   2   3   >