Re: [lvc-project] [PATCH] drm/amd/pm: check return value of amdgpu_irq_add_id()

On 05.02.2024 15:25, Igor Artemiev wrote: > amdgpu_irq_ad_id() may fail and the irq handlers will not be registered. > This patch adds error code check. But what is about deallocation of already allocated memory? -- Alexey

Re: [PATCH v2] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var()

On 06.09.2022 22:54, Daniel Vetter wrote: > On Thu, Aug 11, 2022 at 11:59:00PM +0300, Alexey Khoroshilov wrote: >> For v2 I would suggest to update description to something like this: >> >> Make sure that virtual screen size is not less than physical screen o

Re: [ldv-project] [PATCH v2] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var()

For v2 I would suggest to update description to something like this: Make sure that virtual screen size is not less than physical screen one. and comment to: /* make sure that virtual resolution >= physical resolution */ -- Alexey On 11.08.2022 17:54, Geert Uytterhoeven wrote: > Hi

[PATCH] udlfb: fix NULL pointer dereference in dlfb_usb_probe()

If memory allocation for dlfb fails, error handling code unconditionally dereference NULL pointer. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Fixes: 68a958a915ca ("udlfb: handle unplug properly") --- drivers/video/fbdev/u

[PATCH] drm_aux-dev: fix error handling in drm_dp_aux_dev_init()

Alexey On 12.07.2016 14:11, Daniel Vetter wrote: > On Thu, Jun 30, 2016 at 12:52:15AM +0300, Alexey Khoroshilov wrote: >> If class_create() fails, there is no need for class_destroy(). >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed-off-by: Alexe

[PATCH] drm_aux-dev: fix error handling in drm_dp_aux_dev_init()

If class_create() fails, there is no need for class_destroy(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/gpu/drm/drm_dp_aux_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm

drm/gma500: Possible deadlock in gma_power_begin()

k. Thus it seems either some code is unneeded at all or we could have a deadlock from time to time. What do you think? Found by Linux Driver Verification project (linuxtesting.org). -- Alexey Khoroshilov Linux Verification Center, ISPRAS

[PATCH] drm/radeon: do not left queue acquired if timeout happens in kgd_hqd_destroy()

If timeout happens, kgd_hqd_destroy() just returns -ETIME leaving queue acquired. It may cause a deadlock, so the patch proposes to release queue before return. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/gpu/drm/radeon

[PATCH] drm/i915: avoid deadlock on failure paths in __intel_framebuffer_create()

Since a8bb6818270c __intel_framebuffer_create() is called with struct_mutex held, so it should use drm_gem_object_unreference() instead of drm_gem_object_unreference_unlocked(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/gpu/drm

[PATCH] drm/vmwgfx: avoid null pointer dereference at failure paths

vmw_takedown_otable_base() and vmw_mob_unbind() check for potential vmw_fifo_reserve() failure and print error message, but then immediately dereference NULL pointer. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/gpu/drm/vmwgfx

[PATCH] drm/edid: Fix potential memory leak in edid_load()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/gpu/drm/drm_edid_load.c |8 +--- 1 file changed, 5 insertions(+), 3

[PATCH] drm/edid: Fix potential memory leak in edid_load()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/gpu/drm/drm_edid_load.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git