Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Alice Ryhl
On Tue, Jul 23, 2024 at 3:41 PM Daniel Almeida wrote: > > Hi Alice, thanks for the review! > > > >> +fn alloc_mem(&mut self, size: usize) -> Option<*mut u8> { > >> +assert!(size % 8 == 0, "Allocation size must be 8-byte > >> aligned"); > >> +if isize::try_from(size

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Alice Ryhl
On Thu, Jul 11, 2024 at 12:52 AM Daniel Almeida wrote: > > Dump the state of the GPU. This feature is useful for debugging purposes. > --- > Hi everybody! > > For those looking for a branch instead, see [0]. > > I know this patch has (possibly many) issues. It is meant as a > discussion around the

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Alice Ryhl
On Mon, Jul 15, 2024 at 11:12 AM Steven Price wrote: > >>> + > >>> +pub(crate) const GPU_ID: GpuRegister = GpuRegister(0x0); > >>> +pub(crate) const fn gpu_arch_major(x: u64) -> GpuRegister { > >>> +GpuRegister((x) >> 28) > >>> +} > >>> +pub(crate) const fn gpu_arch_minor(x: u64) -> GpuRegiste

Re: [PATCH v4 4/4] drm/panic: Add a QR code panic screen

2024-07-22 Thread Alice Ryhl
coded as a binary segment (ie raw > ascii) and only a maximum of 2953 bytes of kmsg data will be > available in the QR code. > > You can also limit the QR code size with DRM_PANIC_SCREEN_QR_VERSION. > > Signed-off-by: Jocelyn Falempe Reviewed-by: Alice Ryhl Alice > v2: &g

Re: [PATCH v3 4/4] drm/panic: Add a QR code panic screen

2024-07-11 Thread Alice Ryhl
coded as a binary segment (ie raw > ascii) and only a maximum of 2953 bytes of kmsg data will be > available in the QR code. > > You can also limit the QR code size with DRM_PANIC_SCREEN_QR_VERSION. > > v2: > * Rewrite the rust comments with Markdown (Alice Ryhl) > * Mark drm

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Alice Ryhl
encoded as binary segment (ie raw > ascii) and only a maximum of 2953 bytes of kmsg data will be > available in the QR code. > > You can also limit the QR code size with DRM_PANIC_SCREEN_QR_VERSION. > > v2: > * Rewrite the rust comments with Markdown (Alice Ryhl) > * Mark drm

Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Alice Ryhl
On Thu, Jul 4, 2024 at 11:28 AM Greg KH wrote: > > On Thu, Jul 04, 2024 at 09:11:09AM +, Alice Ryhl wrote: > > As long as the above requirements are satisfied, calling > > `drm_panic_qr_generate` should never cause memory unsafety, so this is > > an appropriate lis

Re: [PATCH 0/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Alice Ryhl
On Wed, Jul 3, 2024 at 5:44 PM Jocelyn Falempe wrote: > > This series adds a new panic screen, with the kmsg data embedded in a QR-code. > > The main advantage of QR-code, is that you can copy/paste the debug data to a > bug report. > > The QR-code encoder is written in rust, and is very specific

Re: [PATCH 0/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Alice Ryhl
On Thu, Jul 4, 2024 at 7:03 AM Greg KH wrote: > > On Wed, Jul 03, 2024 at 05:33:57PM +0200, Jocelyn Falempe wrote: > > Jocelyn Falempe (4): > > drm/panic: Add integer scaling to blit() > > drm/rect: add drm_rect_overlap() > > drm/panic: simplify logo handling > > drm/panic: Add a qr_code p

Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Alice Ryhl
Jocelyn Falempe wrote: > This patch adds a new panic screen, with a QR code and the kmsg data > embedded. > If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be > compressed with zlib and encoded as a numerical segment, and appended > to the url as a url parameter. This allows to sav