Re: [Intel-gfx] [PATCH] [v2] drm/i915/display: Check GGTT to determine phys_base

Thank You for the patch. We noticed a break in the customer board with the latest GOP + this patch. Thank You Khaled On Wed, 2023-12-06 at 18:46 +, Paz Zcharya wrote: > There was an assumption that for iGPU there should be a 1:1 mapping > of GGTT to physical address pointing to the framebu

Re: [Intel-gfx] [PATCH] drm/i915/dp: Cable type identification for DP2.1

On Fri, 2023-06-09 at 11:35 +0300, Jani Nikula wrote: > On Fri, 09 Jun 2023, Animesh Manna wrote: > > For DP alt mode display driver get the information > > about cable speed and cable type through TCSS_DDI_STATUS > > register which will be updated by type-c platform driver. > > Accodingly Update

Re: [v2,1/2] drm/dp: Factor out a function to probe a DPCD address

On Fri, 2022-04-08 at 20:21 +0300, Imre Deak wrote: > Factor out from drm_dp_dpcd_read() a function to probe a DPCD address > with a 1-byte read access. This will be needed by the next patch > doing a > read from an LTTPR address, which must happen without the preceding > wake-up read in drm_dp_dpc

Re: [RFC PATCH 0/4] drm/dp: Use DP2.0 DPCD 248h updated register/field names for DP PHY CTS

On Thu, 2021-10-21 at 13:00 +0300, Jani Nikula wrote: > On Wed, 20 Oct 2021, Khaled Almahallawy > wrote: > > This series updates DPCD 248h register name and PHY test patterns > > names to follow DP 2.0 Specs. > > Also updates the DP PHY CTS codes of the affected drivers (i915, > > amd, msm) > > No

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

ch > is a big > reason we have these helpers), but I think we might be able to fix > some of the > issues you've mentioned by coming up with better workarounds. More > details below > > On Thu, 2021-02-11 at 06:56 +, Almahallawy, Khaled wrote: > > On Wed, 2021-02-1

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

On Wed, 2021-02-10 at 13:03 -0500, Lyude Paul wrote: > On Wed, 2021-02-10 at 00:33 -0800, Khaled Almahallawy wrote: > > The number of AUX retries specified in the DP specs is 7. > > Currently, to make > > Dell 4k monitors happier, the number of retries are 32. > > i915 also retries 5 times (intel_d

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

On Wed, 2021-02-10 at 09:55 +0100, Thomas Zimmermann wrote: > Hi > > Am 10.02.21 um 09:33 schrieb Khaled Almahallawy: > > The number of AUX retries specified in the DP specs is 7. > > Currently, to make Dell 4k monitors happier, the number of retries > > are 32. > > i915 also retries 5 times (inte

Re: [PATCH v2 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support

On Tue, 2020-08-18 at 14:29 -0700, Navare, Manasi wrote: > On Wed, Jul 22, 2020 at 05:36:27PM -0700, Khaled Almahallawy wrote: > > Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source > > tests. > > > > v2: uniform bit names TP4a/b/c (Manasi) > > > > Signed-off-by: Khaled Almahallawy >

Re: [PATCH 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3

On Mon, 2020-07-20 at 17:07 -0700, Manasi Navare wrote: > On Mon, Jul 20, 2020 at 04:41:25PM -0700, Khaled Almahallawy wrote: > > Add the missing CP2520 pattern 2 and 3 phy compliance patterns > > > > Signed-off-by: Khaled Almahallawy > > --- > > drivers/gpu/drm/drm_dp_helper.c | 2 +- > > inclu

Re: [PATCH 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support

On Mon, 2020-07-20 at 17:11 -0700, Manasi Navare wrote: > On Mon, Jul 20, 2020 at 04:41:26PM -0700, Khaled Almahallawy wrote: > > Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source > > tests. > > > > Signed-off-by: Khaled Almahallawy > > --- > > drivers/gpu/drm/i915/display/intel_dp.c

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP PHY compliance for JSL

On Thu, 2020-06-04 at 22:06 +0300, Ville Syrjälä wrote: > On Thu, Jun 04, 2020 at 10:33:48AM +0530, Vidya Srinivas wrote: > > Signed-off-by: Khaled Almahallawy > > Signed-off-by: Vidya Srinivas > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 40 > > ++--- > > 1