Re: [PATCH v3] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-12-03 Thread Alyssa Ross
r_unprepare_planes() for rolling back > * use correct state for end_fb_access > v2: > * fix test in drm_atomic_helper_cleanup_planes() > > Reported-by: Alyssa Ross > Closes: https://lore.kernel.org/dri-devel/87leazm0ya@alyssa.is/ > Suggested-by: Daniel Vetter > Fixes: 94d879eaf7f

Re: [PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-29 Thread Alyssa Ross
Thomas Zimmermann writes: > Hi > > Am 27.11.23 um 17:25 schrieb Alyssa Ross: >> Thomas Zimmermann writes: >> >>> Invoke drm_plane_helper_funcs.end_fb_access before >>> drm_atomic_helper_commit_hw_done(). The latter function hands over >>> owne

Re: [PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-27 Thread Alyssa Ross
14/0x20 > > For aborted commits, it is still ok to run end_fb_access as part of the > plane's cleanup. Add a test to drm_atomic_helper_cleanup_planes(). > > v2: > * fix test in drm_atomic_helper_cleanup_planes() > > Reported-by: Alyssa Ross > Closes: https://lore.kern

Re: [PATCH] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-26 Thread Alyssa Ross
14/0x20 > > For aborted commits, it is still ok to run end_fb_access as part of the > plane's cleanup. Add a test to drm_atomic_helper_cleanup_planes(). > > Reported-by: Alyssa Ross > Closes: https://lore.kernel.org/dri-devel/87leazm0ya@alyssa.is/ > Suggested-by: Daniel Vetter &g

Use after free with GEM shadow-buffered planes

2023-11-16 Thread Alyssa Ross
[Originally reported at https://gitlab.freedesktop.org/drm/misc/-/issues/33] The following happens in a cycle: • An atomic state is allocated • A plane state is allocated (drm_gem_duplicate_shadow_plane_state()) • Commit (drm_atomic_helper_commit(), possibly nonblocking / asynchronously) •