Hi Andrzej,
On Mon, Mar 06, 2023 at 05:32:04PM +0100, Andrzej Hajda wrote:
> Wakeref has dedicated type. Assumption it will be int
> compatible forever is incorrect.
>
> Signed-off-by: Andrzej Hajda
easy...
Reviewed-by: Andi Shyti
Andi
Hi Andrzej,
On Mon, Mar 06, 2023 at 05:32:02PM +0100, Andrzej Hajda wrote:
> From: Chris Wilson
>
> Extract the callstack tracking of intel_runtime_pm.c into its own
> utility so that that we can reuse it for other online debugging of
> scoped wakerefs.
>
> Signed-off-by: Chris Wilson
>
ee
> call.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Andi
Hi Andrzej,
This looks also good, just few questions.
On Mon, Mar 06, 2023 at 05:31:59PM +0100, Andrzej Hajda wrote:
> In case one wants to show stats via debugfs.
shall I say it? I'll say it... you can do better with the log
here. It's not a typo fix :)
> Signed-off-by: Andrzej Hajda
[...]
Hi Andrzej,
looks good, few comments below,
On Mon, Mar 06, 2023 at 05:31:58PM +0100, Andrzej Hajda wrote:
> To improve readability of ref_tracker printing following changes
> have been performed:
> - reports are printed per stack_handle - log is more compact,
> - added display name for
Hi Andrzej,
[...]
> diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
> index dc7b14aa3431e2..5e9f90bbf771b0 100644
> --- a/lib/ref_tracker.c
> +++ b/lib/ref_tracker.c
> @@ -14,6 +14,38 @@ struct ref_tracker {
> depot_stack_handle_tfree_stack_handle;
> };
>
> +void
compatibility with userspace users.
Add multiplexing functionality to the higher directories' files.
This enables the operations to be performed on all the GTs with
a single write. In the case of reads, the files provide an or'ed
value across all the tiles.
Signed-off-by: Andi Shyti
Cc: Maciej
: ├── drpc
: ├── engines
: ├── forcewake
├── frequency
└── rps_boost
Signed-off-by: Andi Shyti
Cc: Tvrtko Ursulin
Reviewed-by: Radhakrishna Sripada
---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c| 4
: ├── engines
: ├── forcewake
├── frequency
└── rps_boost
Signed-off-by: Andi Shyti
Cc: Tvrtko Ursulin
Reviewed-by: Radhakrishna Sripada
---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c| 4
atch 1.
Andi Shyti (2):
drm/i915/gt: Create per-gt debugfs files
drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c| 4 ++-
drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
this driver mmap callback so we can't have 0-refcnted
> object here.
>
> Cc: Matthew Auld
> Cc: Andi Shyti
> Signed-off-by: Nirmoy Das
fine with me!
Reviewed-by: Andi Shyti
Andi
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 ---
> 1 file changed, 4 ins
off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Thanks,
Andi
ry backed fb by setting i915->dsm.usable_size
> to zero.
>
> Cc: Matthew Auld
> Cc: Andi Shyti
> Cc: Daniele Ceraolo Spurio
> Cc: Lucas De Marchi
>
Can you please remove this blank line from the tag space?
> Signed-off-by: Nirmoy Das
> ---
> drivers/gpu/drm/i915/ge
Hi Andrzej,
On Wed, Mar 08, 2023 at 04:39:05PM +0100, Andrzej Hajda wrote:
> Since nop_clear_range is visible it can be used here.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Thanks,
Andi
Hi Andrzej,
On Wed, Mar 08, 2023 at 04:39:04PM +0100, Andrzej Hajda wrote:
> Since nop_clear_range is visible it can be used here.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Thanks,
Andi
Hi Andrzej,
On Wed, Mar 08, 2023 at 04:39:03PM +0100, Andrzej Hajda wrote:
> Function nop_clear_range can be used instead of local implementations.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Andi
that we have a reliable perpetuation of the
operation outcome.
Fixes: cf586021642d80 ("drm/i915/gt: Pipelined page migration")
Reported-by: Matthew Auld
Suggested-by: Chris Wilson
Signed-off-by: Andi Shyti
Cc: sta...@vger.kernel.org
Reviewed-by: Matthew Auld
---
drivers/gpu/d
where the lock is not released.
Signed-off-by: Andi Shyti
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/i915/i915_request.c | 14 +++---
drivers/gpu/drm/i915/i915_request.h | 1 +
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c
b
Make version of the request creation that doesn't hold any
lock.
Signed-off-by: Andi Shyti
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/i915/i915_request.c | 43 +++--
drivers/gpu/drm/i915/i915_request.h | 2 ++
2 files changed, 31 insertions(+), 14 deletions(-)
diff
We have:
- intel_context_timeline_lock()
- intel_context_timeline_unlock()
In the next patches we will also need:
- intel_context_timeline_is_locked()
Add it.
Signed-off-by: Andi Shyti
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/i915/gt/intel_context.h | 6 ++
1 file changed, 6
sue requests on the
kernel context, potentially filling the ring, but allow the higher
priority heartbeats and pulses to still be submitted without being
blocked by the less critical work.
Signed-off-by: Chris Wilson
Cc: Maciej Patelczyk
Cc: sta...@vger.kernel.org
Signed-off-by: Andi Sh
n of the said functions.
v2 -> v3
- Really lock the timeline before generating all the requests
until the last.
v1 -> v2
- Add patch 1 for ensuring exclusive locking of the timeline
- Reword git commit of patch 2.
Andi Shyti (4):
drm/i915/gt: Add intel_context_timeline_is_loc
c7 00 26 00 00 00 48
> c7 c0 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48>
> 3d 01 f0 ff ff 73 01 c3 48 8b 0d b5 7a 0d 00 f7 d8 64 89 01 48
> <4> [33.076957] RSP: 002b:7fffb1424cf8 EFLAGS: 0246 ORIG_RAX:
> 0010
> <4> [
na Sripada
Just one question... you reviewed twice Patch number 1. Did you
mean to review patch 1 and patch 2?
Thanks,
Andi
>
> > -Original Message-
> > From: dri-devel On Behalf Of Andi
> > Shyti
> > Sent: Wednesday, March 1, 2023 3:03 AM
>
equest retirement
> when timeline idles"), v5.5, not commit d8af05ff38ae ("drm/i915: Allow
> sharing the idle-barrier from other kernel requests"), v5.4,
> - reword commit description.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
> Fixe
On Fri, Mar 03, 2023 at 09:58:36AM +, Tvrtko Ursulin wrote:
>
> On 03/03/2023 03:21, Rodrigo Vivi wrote:
> > On Thu, Mar 02, 2023 at 03:53:37PM -0800, Rob Clark wrote:
> > > From: Rob Clark
> > >
> >
> > missing some wording here...
> >
> > > v2: rebase
> > >
> > > Signed-off-by: Rob
, v5.5, not commit d8af05ff38ae ("drm/i915: Allow
> sharing the idle-barrier from other kernel requests"), v5.4,
> - reword commit description.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
> Fixes: 311770173fac ("drm/i915/gt: Schedule request r
Hi Janusz,
On Sat, Feb 25, 2023 at 11:12:18PM +0100, Janusz Krzysztofik wrote:
> Users reported oopses on list corruptions when using i915 perf with a
> number of concurrently running graphics applications. Root cause analysis
> pointed at an issue in barrier processing code -- a race among perf
iew, I
will change the commit log according to your comment.
Thanks!
Andi
> > -Original Message-
> > From: dri-devel On Behalf Of Andi
> > Shyti
> > Sent: Wednesday, March 1, 2023 3:03 AM
> > To: intel-...@lists.freedesktop.org; dri-devel@lists.fre
compatibility with userspace users.
Add multiplexing functionality to the higher directories' files.
This enables the operations to be performed on all the tiles with
a single write. In the case of reads, the files provide an or'ed
value across all the tiles.
Signed-off-by: Andi Shyti
Cc: Maciej
: ├── drpc
: ├── engines
: ├── forcewake
├── frequency
└── rps_boost
Signed-off-by: Andi Shyti
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c| 4 +++-
drivers/gpu/drm/i915/gt/uc
among them in the read case.
Andi
Changelog
=
v1 -> v2
- add patch 2 for multiplexing
- improve commit log in patch 1.
Andi Shyti (2):
drm/i915/gt: Create per-tile debugfs files
drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
drivers/gpu/drm/i915
└── rps_boost
Signed-off-by: Andi Shyti
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c| 4 +++-
drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c| 5 -
drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
4 files changed, 11
Hi,
> > >> >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation
> > >> >> > lock") removes the drm_gem_shmem_get_pages_locked() and
> > >> >> > drm_gem_shmem_put_pages_locked().
> > >> >> >
> > >> >> > But then commit edaa0db9 ("drm/shmem-helper: Fix locking for
> > >> >> >
Hi,
> >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation
> >> > lock") removes the drm_gem_shmem_get_pages_locked() and
> >> > drm_gem_shmem_put_pages_locked().
> >> >
> >> > But then commit edaa0db9 ("drm/shmem-helper: Fix locking for
> >> > drm_gem_shmem_get_pages_sgt()")
Hi Dmitry,
On Tue, Feb 28, 2023 at 04:15:28PM +0300, Dmitry Osipenko wrote:
> Hi,
>
> On 2/28/23 15:50, Andi Shyti wrote:
> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation
> > lock") removes the drm_gem_shmem_get_pages_locked() and
>
s_sgt_locked
Remove the use of the *_locked() functions as it was intended in
the original patch.
Fixes: edaa0db9 ("drm/shmem-helper: Fix locking for
drm_gem_shmem_get_pages_sgt()")
Signed-off-by: Andi Shyti
Cc: Asahi Lina
Cc: Dmitry Osipenko
---
Hi,
I don't know if this is
that we have a reliable perpetuation of the
operation outcome.
Fixes: cf586021642d80 ("drm/i915/gt: Pipelined page migration")
Reported-by: Matthew Auld
Suggested-by: Chris Wilson
Signed-off-by: Andi Shyti
Cc: sta...@vger.kernel.org
Reviewed-by: Matthew Auld
---
drivers/gpu/d
=
v1 -> v2
- Add patch 1 for ensuring exclusive locking of the timeline
- Reword git commit of patch 2.
Andi Shyti (1):
drm/i915/gt: Make sure that errors are propagated through request
chains
Chris Wilson (1):
drm/i915: Throttle for ringspace prior to taking the timeline mutex
dr
iej Patelczyk
Cc: sta...@vger.kernel.org
Signed-off-by: Andi Shyti
---
Hi,
I'm not sure I need to add the Fixes tag here as this is more
preparatory for the next patch. Together, though, patch 1 and 2
make the fix with proper locking mechanism.
Andi
drivers/gpu/drm/i915/gt/intel_c
iej Patelczyk
Cc: sta...@vger.kernel.org
Signed-off-by: Andi Shyti
---
Hi,
I'm not sure I need to add the Fixes tag here as this is more
preparatory for the next patch. Together, though, patch 1 and 2
make the fix with proper locking mechanism.
Andi
drivers/gpu/drm/i915/gt/intel_c
that we have a reliable perpetuation of the
operation outcome.
Fixes: cf586021642d80 ("drm/i915/gt: Pipelined page migration")
Reported-by: Matthew Auld
Suggested-by: Chris Wilson
Signed-off-by: Andi Shyti
Cc: sta...@vger.kernel.org
Reviewed-by: Matthew Auld
---
drivers/gpu/d
=
v1 -> v2
- Add patch 1 for ensuring exclusive locking of the timeline
- Reword git commit of patch 2.
Andi Shyti (1):
drm/i915/gt: Make sure that errors are propagated through request
chains
Chris Wilson (1):
drm/i915: Throttle for ringspace prior to taking the timeline mutex
dr
Hi Andrzej,
On Wed, Jan 18, 2023 at 04:44:48PM +0100, Andrzej Hajda wrote:
> Recently introduced helper simplifies the code.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Thanks,
Andi
Hi Andrzej,
On Wed, Jan 18, 2023 at 04:44:50PM +0100, Andrzej Hajda wrote:
> Prefer core helper if available.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Thanks,
Andi
Hi Andrzej,
On Wed, Jan 18, 2023 at 04:44:49PM +0100, Andrzej Hajda wrote:
> Recently introduced helper simplifies the code.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Thanks,
Andi
Hi Andrzej,
On Wed, Jan 18, 2023 at 04:44:47PM +0100, Andrzej Hajda wrote:
> llist_del_all uses xchg, let's use __xchg here.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Thanks,
Andi
Hi Andrzej,
On Wed, Jan 18, 2023 at 04:44:46PM +0100, Andrzej Hajda wrote:
> In all architectures, except x86, arch_uretprobe_hijack_return_addr
> is just __xchg.
>
> Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Thanks,
Andi
; such cases.
>
> Signed-off-by: Andrzej Hajda
> Reviewed-by: Andy Shevchenko
Reviewed-by: Andi Shyti
Thanks,
Andi
Hi Andrzej,
On Wed, Jan 18, 2023 at 04:44:44PM +0100, Andrzej Hajda wrote:
> __xchg will be used for non-atomic xchg macro.
>
> Signed-off-by: Andrzej Hajda
> Reviewed-by: Arnd Bergmann
> Acked-by: Geert Uytterhoeven [m68k]
> Acked-by: Palmer Dabbelt [riscv]
Reviewed-by: A
: cf586021642d80 ("drm/i915/gt: Pipelined page migration")
Reported-by: Matthew Auld
Suggested-by: Chris Wilson
Signed-off-by: Andi Shyti
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 31 +
1 file changed, 21 insertions(+), 10 deletions(-)
2:53:49PM +0100, Nirmoy Das wrote:
> > Add a function for ratelimitted debug print.
> >
> > Cc: Maarten Lankhorst
> > Cc: Maxime Ripard
> > Cc: Thomas Zimmermann
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Reviewed-by: Matthew Auld
&g
Hi Pin-yen,
[...]
> +static int drm_dp_register_mode_switch(struct device *dev,
> +struct fwnode_handle *fwnode,
> +struct drm_dp_typec_switch_desc
> *switch_desc,
> +void *data,
s patch are valid only and uniquely during
> > boot. The common transactions with the punit during the driver's
> > normal operation are not affected.
> >
> > Signed-off-by: Aravind Iddamsetty
> > Co-developed-by: Chris Wilson
> > Signed-off-by: Chris Wilson
The changes in this patch are valid only and uniquely during
boot. The common transactions with the punit during the driver's
normal operation are not affected.
Signed-off-by: Aravind Iddamsetty
Co-developed-by: Chris Wilson
Signed-off-by: Chris Wilson
Signed-off-by: Andi Shyti
Cc: Rodrigo Vivi
Hi Niranjana,
On Tue, Jan 17, 2023 at 11:16:09PM -0800, Niranjana Vishwanathapura wrote:
> Support dump capture of persistent mappings upon user request.
>
> Capture of a mapping is requested with the VM_BIND ioctl and
> processed during the GPU error handling. They are synchronously
> unbound
ort requires this for page backed regions.
>
> v2: Remove redundant sg_mark_end() call
>
> Signed-off-by: Niranjana Vishwanathapura
Reviewed-by: Andi Shyti
Andi
good!
Reviewed-by: Andi Shyti
Andi
> ---
> Documentation/gpu/i915.rst | 78 --
> 1 file changed, 59 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst
> index 60ea21734902..01429a8f0d6c 100644
&
d
> Signed-off-by: Niranjana Vishwanathapura
Reviewed-by: Andi Shyti
Andi
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> b/drivers/gpu/drm/i915/gem/i91
pura
Reviewed-by: Andi Shyti
Andi
> ---
> .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 513 ++
> 1 file changed, 39 insertions(+), 474 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> b/drivers/gpu/drm/i915/gem/i915_gem_
could reduce the number of these
>* requests, and for any quirks of the PCODE firmware that delays
>* the request completion.
>*/
> drm_dbg_kms(>i915->drm,
> "PCODE timeout, retrying with preemption disabled\n");
> dr
d
> Signed-off-by: Niranjana Vishwanathapura
Reviewed-by: Andi Shyti
Andi
> ---
> drivers/gpu/drm/i915/i915_vma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> ind
Hi Niranjana,
On Tue, Jan 17, 2023 at 11:15:49PM -0800, Niranjana Vishwanathapura wrote:
> Expose i915_gem_object_max_page_size() function non-static
> which will be used by the vm_bind feature.
>
> Reviewed-by: Matthew Auld
> Signed-off-by: Niranjana Vishwanathapura
> S
viewed-by: Matthew Auld
> Signed-off-by: Niranjana Vishwanathapura
Reviewed-by: Andi Shyti
Andi
> ---
> drivers/gpu/drm/i915/i915_sw_fence.c | 28 +---
> drivers/gpu/drm/i915/i915_sw_fence.h | 23 +--
> 2 files changed, 38 inserti
Hi Rodrigo,
first of all, thanks for looking into this!
> > > > > > In the call flow invoked by intel_pcode_init(), I've added brief
> > > > > > comments
> > > > > > where further clarification is needed in this scenario, and a
> > > > > > description of
> > > > > > the suspicious scenario at
Hi Rodrigo,
> > > In the call flow invoked by intel_pcode_init(), I've added brief comments
> > > where further clarification is needed in this scenario, and a description
> > > of
> > > the suspicious scenario at the bottom.
> > >
> > >
Hi GG,
thanks for the deep analysis!
> Hi Andi,
> In the call flow invoked by intel_pcode_init(), I've added brief comments
> where further clarification is needed in this scenario, and a description of
> the suspicious scenario at the bottom.
>
>
Hi Gwan-gyeong,
thanks for the review and the thorough explanation.
On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote:
>
>
> On 1/11/23 5:36 PM, Andi Shyti wrote:
> > On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote:
> > > On Wed, 11 Jan
Hi Arnd,
On Tue, Jan 17, 2023 at 05:37:29PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The definition of intel_selftest_modify_policy() does not match the
> declaration, as gcc-13 points out:
>
> drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c:29:5: error:
> conflicting
d by the client, the
> > per-file vm_count may remain non-zero and the rbtree leaked.
> >
> > Call drm_vma_node_allow_once() instead to prevent that memory leak.
> >
> > Cc: Tvrtko Ursulin
> > Cc: Andi Shyti
>
> Fixes: 786555987207 ("drm/i915/gem: Store mm
need to keep track of each drm_vma_node_allow() to call subsequent
> drm_vma_node_revoke() to prevent memory leak.
>
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Thomas Zimmermann
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Tvrtko Ursulin
> Cc: Andi Shyti
8b4121e ("drm/i915/selftests: Grab the runtime pm in shrink_thp")
> Cc: Andi Shyti
> Reviewed-by: Matthew Auld
> Reviewed-by: Andrzej Hajda
> Signed-off-by: Chris Wilson
> Signed-off-by: Nirmoy Das
pushed in drm-intel-gt-next.
Thanks,
Andi
> ---
> drivers/gpu/drm/
~~~
>
> Change the type in the definition to match.
>
> Fixes: 617e87c05c72 ("drm/i915/selftest: Fix hangcheck self test for GuC
> submission")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Andi Shyti
Andi
> ---
> drivers/gpu/drm/i915/selftests/intel_schedu
8b4121e ("drm/i915/selftests: Grab the runtime pm in shrink_thp")
> Cc: Andi Shyti
> Reviewed-by: Matthew Auld
> Reviewed-by: Andrzej Hajda
> Signed-off-by: Chris Wilson
> Signed-off-by: Nirmoy Das
Reviewed-by: Andi Shyti
Thanks,
Andi
> ---
> drivers/gpu/drm/i915/gem/se
c: Matthew Auld
>
> Reviewed-by: Matthew Auld
> Signed-off-by: Nirmoy Das
Reviewed-by: Andi Shyti
Thanks,
Andi
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_
rlie
> Cc: Daniel Vetter
> Reviewed-by: Matthew Auld
> Signed-off-by: Nirmoy Das
Reviewed-by: Andi Shyti
Thanks,
Andi
> ---
> include/drm/drm_print.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
Hi Vinay,
On Mon, Jan 16, 2023 at 11:35:41AM -0800, Belgaumkar, Vinay wrote:
>
> On 1/16/2023 10:58 AM, Andi Shyti wrote:
> > Hi,
> >
> > On Thu, Jan 12, 2023 at 08:48:11PM -0800, Belgaumkar, Vinay wrote:
> > > On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote:
>
Hi Rodrigo,
On Wed, Jan 11, 2023 at 12:06:24PM -0500, Rodrigo Vivi wrote:
> On Wed, Jan 11, 2023 at 04:39:36PM +0100, Andi Shyti wrote:
> > Hi Rodrigo,
> >
> > On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote:
> > > On Wed, Jan 11, 2023 at 11:4
Hi,
On Thu, Jan 12, 2023 at 08:48:11PM -0800, Belgaumkar, Vinay wrote:
>
> On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote:
> > On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote:
> > > I think the ABI was changed by the patch mentioned in the commit
> > > (a8a4f0467d70).
> > The ABI was
Hi Nirmoy,
On Fri, Jan 13, 2023 at 01:00:53PM +0100, Nirmoy Das wrote:
> From: Chris Wilson
>
> Make sure that upon error after we have acquired the wakeref we do
> release it again.
>
> Fixes: 027c38b4121e ("drm/i915/selftests: Grab the runtime pm in shrink_thp")
> Reviewed-by: Matthew Auld
Hi Rodrigo,
On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote:
> On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote:
> > From: Aravind Iddamsetty
> >
> > During module load not all the punit transaction have completed
> > and we might
On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote:
> On Wed, 11 Jan 2023, Andi Shyti wrote:
> > From: Aravind Iddamsetty
> >
> > During module load not all the punit transaction have completed
> > and we might end up timing out, as shown by the following
&
ing transactions upon module load.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7814
Signed-off-by: Aravind Iddamsetty
Co-developed-by: Chris Wilson
Cc: Rodrigo Vivi
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/intel_pcode.c | 35 ++
1 file changed,
Hi John,
[...]
> +#define gt_WARN_ON(_gt, _condition) \
> + gt_WARN(_gt, _condition, "%s", "gt_WARN_ON(" __stringify(_condition)
> ")")
> +
> +#define gt_WARN_ON_ONCE(_gt, _condition) \
> + gt_WARN_ONCE(_gt, _condition, "%s", "gt_WARN_ONCE("
> __stringify(_condition) ")")
> +
>
e ctx ptr after this. And we
> need to ensure that adding the ctx to the xarray is the *last* thing
> that gem_context_register() does with the ctx pointer.
>
> Signed-off-by: Rob Clark
Reviewed-by: Andi Shyti
I also agree with Tvrtko that we should add Stable: and Fixes:.
One lit
On Fri, Dec 30, 2022 at 07:35:00PM +0100, Nirmoy Das wrote:
> Switch to %zu for printing size_t which will
> fix compilation warning for 32-bit build.
>
> Reported-by: kernel test robot
> Signed-off-by: Nirmoy Das
Reviewed-by: Andi Shyti
Andi
> ---
> dri
-off-by: Chris Wilson
Cc: Andrzej Hajda
Cc: Mika Kuoppala
Signed-off-by: Andi Shyti
---
.../gpu/drm/i915/gt/intel_ring_submission.c | 44 +--
drivers/gpu/drm/i915/i915_utils.h | 8
2 files changed, 38 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm
Hi GG,
> > > > > > > drivers/gpu/drm/i915/gt/intel_reset.c | 34
> > > > > > > ++-
> > > > > > > 1 file changed, 28 insertions(+), 6 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c
> > > > > > >
Hi Rodrigo,
On Tue, Dec 13, 2022 at 01:18:48PM +, Vivi, Rodrigo wrote:
> On Tue, 2022-12-13 at 00:08 +0100, Andi Shyti wrote:
> > Hi Rodrigo,
> >
> > On Mon, Dec 12, 2022 at 11:55:10AM -0500, Rodrigo Vivi wrote:
> > > On Mon, Dec 12, 2022 at 05:13:38PM +0100,
Hi Rodrigo,
On Mon, Dec 12, 2022 at 11:55:10AM -0500, Rodrigo Vivi wrote:
> On Mon, Dec 12, 2022 at 05:13:38PM +0100, Andi Shyti wrote:
> > From: Chris Wilson
> >
> > After applying an engine reset, on some platforms like Jasperlake, we
> > occasionally d
(it looks like
it reports a lite-restore to the hung context, instead of the expected
idle->active context switch).
Signed-off-by: Chris Wilson
Cc: sta...@vger.kernel.org
Cc: Mika Kuoppala
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/intel_reset.c | 34 ++-
1 f
Hi Tvrtko,
On Fri, Dec 02, 2022 at 10:20:11AM +, Tvrtko Ursulin wrote:
>
> On 01/12/2022 20:39, Andi Shyti wrote:
> > From: Chris Wilson
> >
> > Introduce the concept of padding the i915_vma with guard pages before
> > and after. The major consequence is that
Signed-off-by: Tejas Upadhyay
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Andi Shyti
---
Hi Tvrtko,
I removed your r-b in this version because I restored the original value
of the guard being aligned with the vma size alignment. Turns out that
CI failed with the latest version because the guard
Signed-off-by: Tejas Upadhyay
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Andi Shyti
---
Hi,
this the v5 changelog, the overall changelog is in the v4 cover letter:
v4 -> v5:
- remove again the GEM_BUG_ON()
- fix an oversight where the rounding was called without assigning the
va
Hi Tvrtko,
[...]
> > @@ -768,8 +773,17 @@ i915_vma_insert(struct i915_vma *vma, struct
> > i915_gem_ww_ctx *ww,
> > GEM_BUG_ON(!IS_ALIGNED(alignment, I915_GTT_MIN_ALIGNMENT));
> > GEM_BUG_ON(!is_power_of_2(alignment));
> > + guard = vma->guard; /* retain guard across rebinds */
> > +
we avoid adding scratch pages to the entire GGTT we
don't need this hack anymore.
Signed-off-by: Andi Shyti
Cc: Thomas Hellström
Cc: Chris Wilson
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 69 ++--
drivers/gpu/drm/i915/gt/intel_gtt.h | 24
-off-by: Tejas Upadhyay
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gem/i915_gem_domain.c | 13 +++
drivers/gpu/drm/i915/gt/intel_ggtt.c | 25 +-
2 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu
Signed-off-by: Tejas Upadhyay
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 14 ++---
drivers/gpu/drm/i915/i915_gem_gtt.h | 3 +-
drivers/gpu/drm/i915/i915_vma.c | 40 +++-
drivers/gpu/drm/i915
rapper.
The notable exceptions are the selftests that are testing exact
behaviour of i915_vma_pin/i915_vma_insert.
Signed-off-by: Chris Wilson
Signed-off-by: Tejas Upadhyay
Co-developed-by: Thomas Hellström
Signed-off-by: Thomas Hellström
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Andi
t(64, ...)" when asigning the value. We can safely use max
as we know beforehand that the comparison is between two u32
variables.
Signed-off-by: Chris Wilson
Signed-off-by: Andi Shyti
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/display/intel_fb_pin.c | 2 +-
drivers/gpu/drm/i915/gem/i915
601 - 700 of 1075 matches
Mail list logo
