Re: [PATCH 00/13] mmu_notifier kill invalidate_page callback v2

2017-09-02 Thread Andrea Arcangeli
date to new mmu_notifier semantic > xen/gntdev: update to new mmu_notifier semantic > KVM: update to new mmu_notifier semantic > mm/mmu_notifier: kill invalidate_page Reviewed-by: Andrea Arcangeli ___ dri-devel mailing list dri-devel@lists.fre

Re: [PATCH 2/5] i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker

2017-04-09 Thread Andrea Arcangeli
On Fri, Apr 07, 2017 at 04:30:11PM +0100, Chris Wilson wrote: > Not getting hangs is a good sign, but lockdep doesn't like it: > > [ 460.684901] WARNING: CPU: 1 PID: 172 at kernel/workqueue.c:2418 > check_flush_dependency+0x92/0x130 > [ 460.684924] workqueue: PF_MEMALLOC task 172(kworker/1:1H)

[PATCH 2/5] i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker

2017-04-07 Thread Andrea Arcangeli
ff-by: Andrea Arcangeli --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ drivers/gpu/drm/i915/i915_gem_shrinker.c | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 3982489..612fde3 100644 --- a/drivers/gpu/drm/i915/i915_

Re: [PATCH 5/5] i915: fence workqueue optimization

2017-04-07 Thread Andrea Arcangeli
On Fri, Apr 07, 2017 at 10:58:38AM +0100, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 01:23:47AM +0200, Andrea Arcangeli wrote: > > Insist to run llist_del_all() until the free_list is found empty, this > > may avoid having to schedule more workqueues. > > The work will

Re: [PATCH 2/5] i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker

2017-04-07 Thread Andrea Arcangeli
On Fri, Apr 07, 2017 at 11:02:11AM +0100, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 01:23:44AM +0200, Andrea Arcangeli wrote: > > Waiting a RCU grace period only guarantees the work gets queued, but > > until after the queued workqueue returns, there's no guarantee the >

[PATCH 4/5] i915: schedule while freeing the lists of gem objects

2017-04-06 Thread Andrea Arcangeli
Add cond_resched(). Signed-off-by: Andrea Arcangeli --- drivers/gpu/drm/i915/i915_gem.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 612fde3..c81baeb 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu

[PATCH 5/5] i915: fence workqueue optimization

2017-04-06 Thread Andrea Arcangeli
Insist to run llist_del_all() until the free_list is found empty, this may avoid having to schedule more workqueues. Signed-off-by: Andrea Arcangeli --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 1/5] i915: avoid kernel hang caused by synchronize rcu struct_mutex deadlock

2017-04-06 Thread Andrea Arcangeli
+0x40/0x40 ? ret_from_fork+0x23/0x30 Signed-off-by: Andrea Arcangeli --- drivers/gpu/drm/i915/i915_gem.c | 9 + drivers/gpu/drm/i915/i915_gem_shrinker.c | 14 ++ 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/driver

[PATCH 0/5] Re: [Intel-gfx] [BUG][REGRESSION] i915 gpu hangs under load

2017-04-06 Thread Andrea Arcangeli
be i915 when the system is low on memory. Andrea Arcangeli (5): i915: avoid kernel hang caused by synchronize rcu struct_mutex deadlock i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker i915: initialize the free_list of the fencing atomic_helper i915: schedul

[PATCH 3/5] i915: initialize the free_list of the fencing atomic_helper

2017-04-06 Thread Andrea Arcangeli
Just in case the llist model changes and NULL isn't valid initialization. Signed-off-by: Andrea Arcangeli --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index ed

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-09-08 Thread Andrea Arcangeli
On Thu, Sep 08, 2016 at 01:09:23PM +0200, Martin van Es wrote: > On donderdag 8 september 2016 13:18:41 CEST Ville Syrjälä wrote: > > On Thu, Sep 08, 2016 at 12:04:39PM +0200, Martin van Es wrote: > > > On dinsdag 6 september 2016 21:40:48 CEST Ville Syrjälä wrote: > > > > On Tue, Sep 06, 2016

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-29 Thread Andrea Arcangeli
On Mon, Aug 29, 2016 at 10:24:38AM +0300, Jani Nikula wrote: > If it's an Iybridge, there's no low vswing, and that explanation is > false. You can verify by trying i915.edp_vswing=1 or i915.edp_vswing=2 > on an unpatched kernel. CC'ed Martin who filed the bz, he can reproduce too https://bugzilla

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-29 Thread Andrea Arcangeli
On Mon, Aug 29, 2016 at 10:24:38AM +0300, Jani Nikula wrote: > If it's an Iybridge, there's no low vswing, and that explanation is > false. You can verify by trying i915.edp_vswing=1 or i915.edp_vswing=2 > on an unpatched kernel. What I should look for when trying those two settings? Will they suc

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-28 Thread Andrea Arcangeli
ommit aeddda06c1a704bb97c8a7bfe7a472120193bd56 Signed-off-by: Andrea Arcangeli --- drivers/gpu/drm/i915/intel_opregion.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c index adca262..ca17ab6 100644 --- a/drivers/gpu/drm

[PATCH 0/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-28 Thread Andrea Arcangeli
I was bitten by this bug all last week while running latest kernels on my laptop at KVMForum. I then found the bug was also reported here: https://bugzilla.kernel.org/show_bug.cgi?id=151731 Andrea Arcangeli (1): drm: i915: don't use OpRegion for XPS 13 IvyBridge drivers/gpu/drm

3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Andrea Arcangeli
On Mon, Nov 21, 2011 at 09:59:18PM -0800, Andrew Morton wrote: > grr, nothing in that patch's changelog indicates that it fixed a > regression nor that it fixed an infinite blockage of suspend. Well it's not a recent thing so I didn't flag it as a regression. It doesn't infinite block it, suspend

Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-22 Thread Andrea Arcangeli
On Mon, Nov 21, 2011 at 09:59:18PM -0800, Andrew Morton wrote: > grr, nothing in that patch's changelog indicates that it fixed a > regression nor that it fixed an infinite blockage of suspend. Well it's not a recent thing so I didn't flag it as a regression. It doesn't infinite block it, suspend