[PATCH] drm/edid: use for_each_displayid_db where applicable

2019-06-19 Thread Andres Rodriguez
Replace the duplicated versions of the while loop with the new macro. Signed-off-by: Andres Rodriguez Cc: Dave Airlie --- This patch depends on "drm/edid: parse CEA blocks embedded in DisplayID" I didn't send them together to avoid grouping the portion that was cc:stable and the

[PATCH] drm/edid: parse CEA blocks embedded in DisplayID

2019-06-19 Thread Andres Rodriguez
CTA header. No further changes are necessary due to payload parity. This change fixes audio support for the Valve Index HMD. Signed-off-by: Andres Rodriguez Cc: Dave Airlie Cc: Jani Nikula Cc: # v4.15 --- drivers/gpu/drm/drm_edid.c | 81 - include/drm

[PATCH v2] drm/edid: parse CEA blocks embedded in DisplayID

2019-06-13 Thread Andres Rodriguez
CTA header. No further changes are necessary due to payload parity. This change enables audio support for the Valve Index HMD. Signed-off-by: Andres Rodriguez --- v2: Review feedback from Jani. drivers/gpu/drm/drm_edid.c | 75 + include/drm/drm_displayid.h

[PATCH] drm/edid: parse CEA blocks embedded in DisplayID

2019-06-12 Thread Andres Rodriguez
CTA header. No further changes are necessary due to payload parity. This change enables audio support for the Valve Index HMD. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/drm_edid.c | 79 + include/drm/drm_displayid.h | 1 + 2 files changed, 72

[PATCH] drm: add non-desktop quirk for Valve HMDs

2019-05-02 Thread Andres Rodriguez
Add vendor/product pairs for the Valve Index HMDs. Signed-off-by: Andres Rodriguez Cc: Dave Airlie Cc: # v4.15 --- drivers/gpu/drm/drm_edid.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 2c22ea446075

Re: [PATCH libdrm] amdgpu: Add context priority override function.

2019-04-17 Thread Andres Rodriguez
alization required before this command can be executed on the master_fd. If so, this changed is: Reviewed-by: Andres Rodriguez + if (r) + return r; + + return 0; +} + drm_public int amdgpu_cs_query_reset_state(amdgpu_context_handl

[PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-16 Thread Andres Rodriguez
octls") Signed-off-by: Andres Rodriguez Cc: Daniel Vetter Cc: David Airlie Cc: Emil Velikov Cc: Alex Deucher Cc: Keith Packard Reviewed-by: Keith Packard Reviewed-by: Daniel Vetter --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ drive

Re: [PATCH] drm/amdgpu: cleanup firmware requests v2

2018-04-20 Thread Andres Rodriguez
Ping. On 2018-04-17 06:12 PM, Andres Rodriguez wrote: Add a new function amdgpu_ucode_request_firmware() that encapsulates a lot of the common behaviour we have around firmware requests. This is the first step in my quest to get rid of the following annoying messages when my polaris10 boots up

[PATCH] drm/amdgpu: cleanup firmware requests v2

2018-04-17 Thread Andres Rodriguez
() Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- Sorry for the quick V2, noticed some docs might help and that _validate() could be reduced in scope. Pasting my old message again just in case. Hey Christian, Wanted to go through a cleanup of the ucode loading in amdgpu to facilitat

[PATCH] drm/amdgpu: cleanup firmware requests

2018-04-17 Thread Andres Rodriguez
:01:00.0: Direct firmware load for amdgpu/polaris10_mec_2.bin failed with error -2 [0.558619] amdgpu :01:00.0: Direct firmware load for amdgpu/polaris10_mec2_2.bin failed with error -2 Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- Hey Christian, Wanted to go through a c

[PATCH libdrm 1/2] headers: Sync amdgpu_drm.h with drm-next

2017-10-20 Thread Andres Rodriguez
Generated using make headers_install from: airlied/drm-next 282dc83 Merge tag 'drm-intel-next-2017-10-12' ... Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- include/drm/amdgpu_drm.h | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff

[PATCH libdrm 2/2] amdgpu: implement context priority for amdgpu_cs_ctx_create2 v3

2017-10-20 Thread Andres Rodriguez
AMDGPU_CTX_PRIORITY_NORMAL. v2: corresponding changes for kernel patch v2 v3: Fixed 'make check' symbol error Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h| 17 +++-- amdgpu/amdgpu_cs.c | 17 + 3

Re: XDC 2017 feedback

2017-09-26 Thread Andres Rodriguez
Hi, A small piece of feedback from those of us watching remotely. It would be nice to have a simple to access index for the long livestream videos. I think the XDC 2017 wiki page would be a good place for this information. A brief example: Presentation Title | Presenter Name | Link with

Re: [PATCH] gpu: drm: amd: amdgpu: remove dead code

2017-05-09 Thread Andres Rodriguez
On 2017-05-09 08:53 AM, Alex Deucher wrote: On Mon, May 8, 2017 at 1:01 PM, Gustavo A. R. Silva wrote: Local variable use_doorbell is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID:

[PATCH] dma-buf: avoid scheduling on fence status query v2

2017-04-26 Thread Andres Rodriguez
by returning early if a zero timeout is specified. v2: move early return after enable_signaling Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- If I'm understanding correctly, I don't think we need to register the default wait callback. But if that isn't the case please let m

Re: [PATCH] dma-buf: avoid scheduling on fence status query

2017-04-26 Thread Andres Rodriguez
On 2017-04-26 06:13 AM, Christian König wrote: Am 26.04.2017 um 11:59 schrieb Dave Airlie: On 26 April 2017 at 17:20, Christian König wrote: NAK, I'm wondering how often I have to reject that change. We should probably add a comment here. Even with a zero timeout

Re: [PATCH] dma-buf: avoid scheduling on fence status query

2017-04-25 Thread Andres Rodriguez
CC a few extra lists I missed. Regards, Andres On 2017-04-25 09:36 PM, Andres Rodriguez wrote: When a timeout of zero is specified, the caller is only interested in the fence status. In the current implementation, dma_fence_default_wait will always call schedule_timeout() at least once

[PATCH] dma-buf: avoid scheduling on fence status query

2017-04-25 Thread Andres Rodriguez
by returning early if a zero timeout is specified. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- This heavily affects the performance of the Source2 engine running on radv. This patch improves dota2(radv) perf on a i7-6700k+RX480 system from 72fps->81fps. drivers/dma-buf/dm

Re: [PATCH] drm: Fix get_property logic fumble

2017-04-13 Thread Andres Rodriguez
if (out_resp->count_enum_blobs <= enum_count) + if (out_resp->count_enum_blobs < enum_count) continue; if (copy_to_user(_ptr[copied].value, Neither can I, glanced over it while looking why the bisect pointed at thi

gputool: a tool for debugging AMD GPUs

2017-01-11 Thread Andres Rodriguez
Hey Everyone, I started a small project called gputool to help me debug issues on AMD platforms. I think it may be useful to other driver devs, so I've made it available on github: https://github.com/lostgoat/gputool Mainly I wanted something that could read and decode registers, so that

[PATCH v2] amdgpu: fix asic initialization for virtualized environments

2016-06-11 Thread Andres Rodriguez
-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 +++- drivers/gpu/drm/amd/amdgpu/cik.c | 7 +++ drivers/gpu/drm/amd/amdgpu/vi.c| 15 +++ 4 files changed, 44 insertions

[PATCH] amdgpu: fix asic initialization for virtualized environments

2016-06-11 Thread Andres Rodriguez
-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 +++- drivers/gpu/drm/amd/amdgpu/cik.c | 7 +++ drivers/gpu/drm/amd/amdgpu/vi.c| 15 +++ 4 files changed, 44 insertions

[PATCH] amdgpu: fix asic initialization for virtualized environments

2016-06-10 Thread Andres Rodriguez
-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 +++- drivers/gpu/drm/amd/amdgpu/cik.c | 7 +++ drivers/gpu/drm/amd/amdgpu/vi.c| 15 +++ 4 files changed, 44 insertions