>
> I say keep it one line!
>
> Reviewed-by: Steven Rostedt (Google)
I believe Sakari strongly follows the 80 rule, which means...
> > Reviewed-by: Sakari Ailus
...chose either of these tags and be happy with :-)
--
With Best Regards,
Andy Shevchenko
red starting with drm/ since this is "closer to home".
>
> I hope this is a good summary of the previous attempts and a way we can
> move forward.
>
> Andrew Morton, Petr Mladek, Andy Shevchenko: if this is accepted, my
> proposal is to take first 2 patches either t
inline const char *enabledisable(bool v) { return v ? "enable" :
> "disable"; }
> +static inline const char *enableddisabled(bool v) { return v ? "enabled"
> : "disabled"; }
Looks not readable even if takes 80 characters. Please, keep original style.
I believe you wanted to have nice negative statistics from day 1, then you
may add more patches in the series to cleanup more users.
>
> #endif
> --
> 2.34.1
>
>
--
With Best Regards,
Andy Shevchenko
TLOG_YES));
> +yesno(cond->grant_log ==
> TOMOYO_GRANTLOG_YES));
> tomoyo_set_lf(head);
> return true;
> }
> diff --git a/security/tomoyo/common.h b/security/tomoyo/common.h
> index 85246b9df7ca..ca285f362705 100644
> --- a/security/tomoyo/common.h
> +++ b/security/tomoyo/common.h
> @@ -959,7 +959,6 @@ char *tomoyo_read_token(struct tomoyo_acl_param
> *param);
> char *tomoyo_realpath_from_path(const struct path *path);
> char *tomoyo_realpath_nofollow(const char *pathname);
> const char *tomoyo_get_exe(void);
> -const char *tomoyo_yesno(const unsigned int value);
> const struct tomoyo_path_info *tomoyo_compare_name_union
> (const struct tomoyo_path_info *name, const struct tomoyo_name_union
> *ptr);
> const struct tomoyo_path_info *tomoyo_get_domainname
> --
> 2.34.1
>
>
--
With Best Regards,
Andy Shevchenko
On Mon, Jan 17, 2022 at 02:15:48PM +0900, Esaki Tomohito wrote:
> On 2022/01/14 23:16, Andy Shevchenko wrote:
> > On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote:
> > > The LINEAR modifier is advertised as default if a driver doesn't
remove the mode_config.allow_fb_modifiers hook and always
> > advertise modifier support, unless
> > mode_config.cannot_support_modifiers is set
FWIW,
Reviewed-by: Andy Shevchenko
> [1]
> https://patchwork.kernel.org/project/linux-renesas-soc/patch/20190509054518.10781-1-e...@ige
On Fri, Jan 14, 2022 at 03:42:54PM +, Simon Ser wrote:
> On Friday, January 14th, 2022 at 16:17, Andy Shevchenko
> wrote:
>
> > On Fri, Jan 14, 2022 at 03:07:21PM +, Simon Ser wrote:
> > > On Friday, January 14th, 2022 at 15:16, Andy Shevchenko
> > >
On Fri, Jan 14, 2022 at 03:07:21PM +, Simon Ser wrote:
> On Friday, January 14th, 2022 at 15:16, Andy Shevchenko
> wrote:
>
> > Why not enum?
>
> There is no enum for DRM format modifiers.
I'm not sure how this prevents to use enum in the code instead of const u6
MOD_INVALID
+ Comma?
> + };
Why not enum?
--
With Best Regards,
Andy Shevchenko
acpi_dev_get_resources() does perform the NULL pointer check against
ACPI companion device which is given as function parameter. Thus,
there is no need to duplicate this check in the caller.
Signed-off-by: Andy Shevchenko
---
v2: used LIST_HEAD() (Ville), initialized lookup directly on stack
n plural form, the singular is a legacy one)
> + It will be used only if optional smbus-alert property is present.
--
With Best Regards,
Andy Shevchenko
On Thu, Dec 9, 2021 at 3:48 PM Akhil R wrote:
>
> Use i2c_timings struct and corresponding methods to get bus clock frequency
Thanks!
A couple of comments below, after addressing them, FWIW,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Akhil R
> ---
> drivers/i2c/busses/i
ctures where it might be possible to
have valid vIRQ 0, but this is not the case (at least I never heard of
a such) for GPIO controllers on such platforms. So, looking at the
above code I may tell that the '=' part is redundant.
--
With Best Regards,
Andy Shevchenko
On Tue, Nov 23, 2021 at 06:32:46PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 01:35:47PM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 10, 2021 at 05:39:33PM +0100, Thomas Zimmermann wrote:
> > > Am 10.11.21 um 17:34 schrieb Andy Shevchenko:
> > > > O
f (ACPI_HANDLE(i2c_dev->dev))
> + return 0;
Ditto.
P.S> Sorry if I missed something in the previous reviews.
--
With Best Regards,
Andy Shevchenko
On Mon, Nov 15, 2021 at 01:35:47PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 10, 2021 at 05:39:33PM +0100, Thomas Zimmermann wrote:
> > Am 10.11.21 um 17:34 schrieb Andy Shevchenko:
> > > On Wed, Nov 10, 2021 at 3:55 PM Thomas Zimmermann
> > > wrote:
> > >
101", .driver_data = (kernel_ulong_t)&tegra210_i2c_hw},
> + {.id = "NVDA0201", .driver_data = (kernel_ulong_t)&tegra186_i2c_hw},
> + {.id = "NVDA0301", .driver_data = (kernel_ulong_t)&tegra194_i2c_hw},
> + { },
No comma for the terminator entry.
> +};
--
With Best Regards,
Andy Shevchenko
On Mon, Nov 15, 2021 at 01:53:10PM +0200, Jani Nikula wrote:
> Took Andy's patch [1] and expanded on it a bit.
Thank you!
It's always good to have cleanups in the headers,
Acked-by: Andy Shevchenko
for your changes (including ones that you've done against my patch
On Mon, Nov 15, 2021 at 01:43:02PM +0200, Jani Nikula wrote:
> On Mon, 15 Nov 2021, Andy Shevchenko
> wrote:
> > On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote:
> >> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote:
> >>
On Wed, Nov 10, 2021 at 05:39:33PM +0100, Thomas Zimmermann wrote:
> Am 10.11.21 um 17:34 schrieb Andy Shevchenko:
> > On Wed, Nov 10, 2021 at 3:55 PM Thomas Zimmermann
> > wrote:
> > > Am 10.11.21 um 11:24 schrieb Andy Shevchenko:
...
> > > > +#include
On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote:
> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote:
> > We have already few similar implementation and a lot of code that can
> > benefit
> > of the yesno() helper. Consolidate yesno() helper
On Wed, Nov 10, 2021 at 3:55 PM Thomas Zimmermann wrote:
> Am 10.11.21 um 11:24 schrieb Andy Shevchenko:
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> >
> > Replace kerne
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko
---
include/drm/intel-gtt.h | 5 -
1 file changed, 4
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko
---
include/drm/drm_gem_ttm_helper.h | 2 +-
include/drm
rivers that
> rely on FB_DDC to have an appropriate I2C dependency as well.
No objections from me.
Acked-by: Andy Shevchenko
> Signed-off-by: Arnd Bergmann
> ---
> drivers/video/fbdev/Kconfig | 17 +
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> d
it return void instead which makes it easier to see in the callers
> that there is no error to handle.
>
> Also the return value of platform and spi remove callbacks is ignored
> anyway and not freeing resources in .remove() is a bad idea.
Acked-by: Andy Shevchenko
> S
c/mei/hdcp/mei_hdcp.c | 22 +-
> drivers/power/supply/ab8500_charger.c | 22 +-
> drivers/video/fbdev/omap2/omapfb/dss/dss.c| 20 +-
> include/drm/drm_of.h | 9 +-
> include/linux/component.h | 92 ++-
> sound/hda/hdac_component.c| 21 +-
> sound/soc/codecs/wcd938x.c| 20 +-
> 33 files changed, 780 insertions(+), 488 deletions(-)
>
>
> base-commit: e4e737bb5c170df6135a127739a9e6148ee3da82
> --
> https://chromeos.dev
>
>
--
With Best Regards,
Andy Shevchenko
(Rockchip
> RK3326) and it appears to work well. However, this change will affect
> all Rockchip SoCs that use this driver so I believe further testing
> is warranted. Please note that without this change I can confirm
> at least all PX30s with DSI panels will stop working with the 5.15
urn -EINVAL;
> + }
> +
> + rmem->ops = &rmem_swiotlb_ops;
> + pr_info("Reserved memory: created restricted DMA pool at %pa, size
> %ld MiB\n",
> + &rmem->base, (unsigned long)rmem->size / SZ_1M);
Oh là là, besides explicit casting that I believe can be avoided, %ld
!= unsigned long. Can you check the printk-formats.rst document?
> + return 0;
> +}
> +
> +RESERVEDMEM_OF_DECLARE(dma, "restricted-dma-pool", rmem_swiotlb_setup);
> #endif /* CONFIG_DMA_RESTRICTED_POOL */
--
With Best Regards,
Andy Shevchenko
info("query %d: \"%s\" %s\n", i, query, (modname) ?
> modname : "");
too many parentheses. Also may use
modname ?: ""
form (but not all maintainers are happy with it).
...
> + if (!bitmap) {
> + pr_err("set_dyndbg: no bits=>queries map\n");
> + return -EINVAL;
> + }
> + rc = kstrtoul(instr, 0, &inbits);
> + if (rc) {
> + pr_err("set_dyndbg: failed\n");
> + return rc;
> + }
> + vpr_info("set_dyndbg: input 0x%lx\n", inbits);
> +
> + for (i = 0; bitmap->prefix; i++, bitmap++) {
> + snprintf(query, FMT_QUERY_SIZE, "format '^%s' %cp",
> bitmap->prefix,
> +test_bit(i, &inbits) ? '+' : '-');
> +
> + matches = ddebug_exec_queries(query, KP_MOD_NAME);
> +
> + v2pr_info("bit-%d: %d matches on '%s'\n", i, matches, query);
> + totct += matches;
> + }
I'm wondering if there is a room to parse a bitmap as a bitmap.
...
> +int param_get_dyndbg(char *buffer, const struct kernel_param *kp)
> +{
> + return scnprintf(buffer, PAGE_SIZE, "%u\n",
> +*((unsigned int *)kp->arg));
One line?
> +}
--
With Best Regards,
Andy Shevchenko
missing.
No objections
Acked-by: Andy Shevchenko
> Cc: Andy Shevchenko
> Cc: Andrew Morton
> Cc: Nick Desaulniers
> Cc: Andy Lavr
> Cc: Nathan Chancellor
> Cc: Alexey Dobriyan
> Cc: Stephen Rothwell
> Cc: Bartosz Golaszewski
> Signed-off-by: Kees Cook
> ---
&g
kp->data;
So you need space after ')' ?
> + rc = kstrtoul(instr, 0, &inbits);
> + if (rc) {
> + pr_err("set_dyndbg: failed\n");
> + return -EINVAL;
Why not to return rc?
> + }
> + vpr_info("set_dyndbg: input 0x%lx\n", inbits);
> +
> + for (i = 0; !!bitmap[i].prefix; i++) {
Hmm... Why not simply
for (bitmap = ...; bitmap->prefix; bitmap++) {
?
> +
Redundant blank line.
> + sprintf(query, "format '^%s' %cp", bitmap[i].prefix,
> + test_bit(i, &inbits) ? '+' : '-');
snprintf() ?
> +
> + chgct = dynamic_debug_exec_queries(query, kp->mod->name);
> +
> + v2pr_info("bit-%d: %d changes by '%s'\n", i, chgct, query);
> + totct += chgct;
> + }
> + vpr_info("total changes: %d\n", totct);
> + return 0;
> +}
...
> + return scnprintf(buffer, PAGE_SIZE, "%u\n",
> + *((unsigned int *)kp->arg));
One line.
--
With Best Regards,
Andy Shevchenko
KERNEL_PARAM_FL_UNSAFE)
(above left for the above comment)
...
> +#define __module_param_call_wdata(prefix, name, ops, arg, perm, level,
> flags, data) \
Similar __module_param_call_with_data()
--
With Best Regards,
Andy Shevchenko
2:38 PM Greg Kroah-Hartman
wrote:
> On Thu, Aug 05, 2021 at 02:30:35PM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 5, 2021 at 2:18 PM Greg Kroah-Hartman
> > wrote:
> > > On Sun, Aug 01, 2021 at 02:40:40PM +0300, Andy Shevchenko wrote:
> > > > On Sun, Aug
On Thu, Aug 5, 2021 at 2:18 PM Greg Kroah-Hartman
wrote:
> On Sun, Aug 01, 2021 at 02:40:40PM +0300, Andy Shevchenko wrote:
> > On Sun, Aug 1, 2021 at 11:53 AM Len Baker wrote:
> > >
> > > strcpy() performs no bounds checking on the destination buffer. This
> > &
road map here.
I have the SPI panel (tiny) based on the ILI9341 and I'm using
actually mi0283qt driver. With yours we will have 3 (three!) drivers
for the same chip. I really do not want this. Without road map on the
prospective of these all drivers, NAK.
--
With Best Regards,
Andy Shevchenko
r to maintain it there.
> Changelog v1 -> v2
> - Add two new commits to clean the code.
> - Use the "%*ph" format specifier instead of strscpy() function (Geert
> Uytterhoeven)
>
> Changelog v2 -> v3
> - Change the initialization of the "j" variabl
On Sun, Jul 25, 2021 at 4:59 PM Len Baker wrote:
> On Sat, Jul 24, 2021 at 11:21:04PM +0300, Andy Shevchenko wrote:
> > On Sat, Jul 24, 2021 at 7:05 PM Len Baker wrote:
...
> > > - char msg[128];
> >
> > 128 / 4 = 32. So, this buffer is enough to debug
t_sequence[j] >= 0; j++);
Why is i + 1 initial for the j? You may rather access the 'i + 1 +
j'th element in the array...
...
> + par->init_sequence[i], j - i - 1,
...and get rid of the ' - i -1' part here.
--
With Best Regards,
Andy Shevchenko
j = i + 1;
> while (par->init_sequence[j] >= 0) {
> sprintf(str, "0x%02X ",
> par->init_sequence[j]);
--
With Best Regards,
Andy Shevchenko
On Sat, Jun 19, 2021 at 01:49:58PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 18, 2021 at 12:57:35PM -0700, Yury Norov wrote:
> > A couple of kernel functions call for_each_*_bit_from() with start
> > bit equal to 0. Replace them with for_each_*_bit().
> >
> > No fu
On Fri, Jun 18, 2021 at 12:57:33PM -0700, Yury Norov wrote:
> for_each_bit() macros depend on find_bit() machinery, and so the
> proper place for them is the find.h header.
Fine with me.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Yury Norov
> ---
> include/linu
n
> save few lines of I-cache by not using find_first_bit().
Any number available?
--
With Best Regards,
Andy Shevchenko
, &gpio_status, mask, LTC2992_GPIO_NR);
(Good to split sometimes :-)
--
With Best Regards,
Andy Shevchenko
++--
> drivers/spi/spi-ep93xx.c | 4 ++--
> drivers/video/fbdev/ep93xx-fb.c| 4 ++--
> sound/soc/cirrus/ep93xx-i2s.c | 12 ++--
> 7 files changed, 24 insertions(+), 24 deletions(-)
>
> --
> 2.32.0
>
>
--
With Best Regards,
Andy Shevchenko
ry being smart [1]. At least it works for me in
99% of the cases. Otherwise I add manually --cc or other related options.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
Feel free to modify (patches also are warmly welcome!).
--
With Best Regards,
Andy Shevchenko
from something which has its own domain
At the same time convert users tree-wide to use new headers, although
for the time being include new header back to kernel.h to avoid twisted
indirected includes for existing users.
Signed-off-by: Andy Shevchenko
Reviewed-by: Bjorn Andersson
Acked-by
device_for_each_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.
Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support")
Cc: Brian Masney
Cc: Dan Murphy
Signed-off-by: Andy Shevchenko
---
dri
On Wed, May 5, 2021 at 1:30 PM Hans de Goede wrote:
> On 5/5/21 12:02 PM, Andy Shevchenko wrote:
...
> But we do really need to document the behavior better here
> in the kdoc for fwnode_get_next_child_node() and
> device_get_next_child_node().
Totally agree!
> of_get_next_chi
On Wed, May 5, 2021 at 12:28 PM Hans de Goede wrote:
> On 5/5/21 11:17 AM, Andy Shevchenko wrote:
> > On Wed, May 5, 2021 at 12:07 PM Hans de Goede wrote:
> >> On 5/4/21 9:52 AM, Andy Shevchenko wrote:
> >>> On Monday, May 3, 2021, Hans de Goede >>&
On Wed, May 5, 2021 at 12:07 PM Hans de Goede wrote:
> On 5/4/21 9:52 AM, Andy Shevchenko wrote:
> > On Monday, May 3, 2021, Hans de Goede > <mailto:hdego...@redhat.com>> wrote:
...
> > + fwnode = device_get_next_child_node(kdev, fwnode);
&g
On Tue, May 4, 2021 at 2:53 PM Hans de Goede wrote:
> On 5/4/21 10:00 AM, Andy Shevchenko wrote:
> > On Monday, May 3, 2021, Hans de Goede > <mailto:hdego...@redhat.com>> wrote:
...
> > +struct drm_connector *drm_connector_find_by_fwnode(struct
index d20bfd7576ed..ae377354e48e 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -1267,6 +1267,14 @@ struct drm_connector {
> */
> struct list_head head;
>
> + /**
> +* @global_connector_list_entry:
> +*
> +* Connector entry in the global connector-list, used by
> +* drm_connector_find_by_fwnode().
> +*/
> + struct list_head global_connector_list_entry;
> +
> /** @base: base KMS object */
> struct drm_mode_object base;
>
> --
> 2.31.1
>
>
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 0261801af62c..d20bfd7576ed 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -1254,6 +1254,8 @@ struct drm_connector {
> struct device *kdev;
> /** @attr: sysf
970,6 +14970,7 @@ int intel_modeset_init_nogem(struct
> drm_i915_private *i915)
>
> drm_modeset_lock_all(dev);
> intel_modeset_setup_hw_state(dev, dev->mode_config.acquire_ctx);
> + intel_acpi_assign_connector_fwnodes(i915);
> drm_modeset_unlock_all(dev);
>
> for_each_intel_crtc(dev, crtc) {
> --
> 2.31.1
>
>
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Himax HX8347d has non-standard register to control orientation.
Add support for different orientation values.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fb_hx8347d.c | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
the hardware.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c
b/drivers/staging/fbtft/fb_agm1264k-fl.c
index b545c2ca80a4..207d578547cd 100644
--- a/drivers/staging/fbtf
Now, after a few fixes we may consider the conversion to
the GPIO descriptor API is done.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/fbtft/TODO b/drivers/staging/fbtft/TODO
index a9f4802bb6be
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Nishad Kamdar
Signed-off-by:
(Dan)
- new patch to support orientation on HX8347d
In v3:
- added staging prefix (Fabio)
- slightly amended commit message in the patch 1
- added Rb tag (Phil)
- dropped Fixes tag from the patch 2 (Greg)
Andy Shevchenko (5):
staging: fbtft: Rectify GPIO handling
staging: fbtft: Don't spam
sertion when using gpio
descriptor")
Fixes: dbc4f989c878 ("Staging: fbtft: Fix probing of gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Jan Sebastian Götte
Cc: Nishad Kamdar
Signed-off-by: Andy Shevchenko
Revi
On Mon, May 3, 2021 at 7:46 PM Greg Kroah-Hartman
wrote:
> On Wed, Apr 28, 2021 at 04:04:12PM +0300, Andy Shevchenko wrote:
> > Fixes: 92e3e884887c ("Staging: staging: fbtft: Fix GPIO handling")
> > Fixes: b918d1c27066 ("Staging: staging: fbtft: Fix reset
On Thu, Apr 29, 2021 at 05:42:44PM +0300, Dan Carpenter wrote:
> On Wed, Apr 28, 2021 at 04:04:14PM +0300, Andy Shevchenko wrote:
> > + if (IS_ERR(*gpiop))
> > + dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s
> > GPIO\n", name);
>
&
the hardware.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c
b/drivers/staging/fbtft/fb_agm1264k-fl.c
index b545c2ca80a4..207d578547cd 100644
--- a/drivers/staging/fbtf
fbtft: Fix reset assertion when using
gpio descriptor")
Fixes: dbc4f989c878 ("Staging: staging: fbtft: Fix probing of gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: staging: fbtft: Switch to the gpio descriptor
interface")
Cc: Jan Sebastian Götte
Cc: Nishad Kamdar
Signed-o
patch 1
- added Rb tag (Phil)
- dropped Fixes tag from the patch 2 (Greg)
Andy Shevchenko (4):
staging: fbtft: Rectify GPIO handling
staging: fbtft: Replace custom ->reset() with generic one
staging: fbtft: Don't spam logs when probe is deferred
staging: fbtft: Update TODO
dr
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 12
1 file changed, 4 insertions(+), 8 dele
Now, after a few fixes we may consider the conversion to
the GPIO descriptor API is done.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/fbtft/TODO b/drivers/staging/fbtft/TODO
index a9f4802bb6be
On Tue, Apr 27, 2021 at 2:09 PM Greg Kroah-Hartman
wrote:
> On Fri, Apr 16, 2021 at 05:20:41PM +0300, Andy Shevchenko wrote:
> > The custom ->reset() repeats the generic one, replace it.
> >
> > Note, in newer kernels the context of the function is a sleeping one,
> &g
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/hx8357d.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/mi0283qt.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/st7586.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/ili9225.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/st7735r.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/ili9486.c | 12
1 file changed, 4 insertions(+), 8
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/tiny/ili9341.c | 12
1 file changed, 4 insertions(+), 8
+Cc: Greg.
Greg, can you pick up this one?
The subsystem seems orphaned and I see your name in the git history for the
recent submissions against that driver.
Id is 20210409164140.17337-1-andriy.shevche...@linux.intel.com
On Fri, Apr 09, 2021 at 07:41:40PM +0300, Andy Shevchenko wrote:
> Af
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
> > the GPIO descriptor interface") broke GPIO handling completely
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
v2: no changes
drivers/staging/fbtft/fbtft-core.c | 12
1 file changed, 4 inser
the hardware.
Fixes: b2ebd4be6fa1 ("staging: fbtft: add fb_agm1264k-fl driver")
Signed-off-by: Andy Shevchenko
---
v2: new patch split from the bigger fix (Greg)
drivers/staging/fbtft/fb_agm1264k-fl.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/fb
sing gpio
descriptor")
Fixes: dbc4f989c878 ("Staging: fbtft: Fix probing of gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Jan Sebastian Götte
Cc: Phil Reid
Cc: Nishad Kamdar
Signed-off-by: Andy Shevchenko
---
v2: sh
Now, after a few fixes we may consider the conversion to
the GPIO descriptor API is done.
Signed-off-by: Andy Shevchenko
---
v2: new patch split from the bigger fix (Greg)
drivers/staging/fbtft/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/fbtft/TODO b/drivers
On Fri, Apr 16, 2021 at 04:37:48PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
&g
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote:
> > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to
> > the GPIO descriptor interface") broke GPIO handling completely
gpio descriptor")
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Jan Sebastian Götte
Cc: Phil Reid
Cc: Nishad Kamdar
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/TODO | 5 -
drivers/staging/fbtft/fb_agm126
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 12
1 file changed, 4 insertions(+), 8 dele
After the commit 72915994e028 ("video: ssd1307fb: Make use of device
properties") driver does not depend on OF, drop unneeded dependency.
Signed-off-by: Andy Shevchenko
---
drivers/video/fbdev/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/Kconfig b/dri
from something which has its own domain
At the same time convert users tree-wide to use new headers, although
for the time being include new header back to kernel.h to avoid twisted
indirected includes for existing users.
Signed-off-by: Andy Shevchenko
Reviewed-by: Bjorn Andersson
Acked-by
plane_visibility(plane_state), DRM_RECT_FP_ARG(&src),
DRM_RECT_ARG(&dst), rot_str);
This will show logical parts separately and clear view on what would be printed
when !fb. Also it uses seq_puts() without any needs for formatting.
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Feb 15, 2021 at 07:26:55PM +0200, Sakari Ailus wrote:
> On Mon, Feb 15, 2021 at 03:41:14PM +0200, Andy Shevchenko wrote:
> ...
> > > + seq_printf(m, "\t\tuapi: [FB:%d] ", fb ? fb->base.id : 0);
> > > + if (fb)
> > > + seq_printf(
On Mon, Feb 15, 2021 at 04:37:50PM +0200, Jani Nikula wrote:
> On Mon, 15 Feb 2021, Andy Shevchenko
> wrote:
> > We have already few similar implementation and a lot of code that can
> > benefit
> > of the yesno() helper. Consolidate yesno() helpers under string.h hood
On Mon, Feb 15, 2021 at 03:56:50PM +0200, Sakari Ailus wrote:
> On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote:
> > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
&
On Tue, Feb 2, 2021 at 3:52 AM Carlis wrote:
> On Mon, 1 Feb 2021 19:40:21 +0200
> Andy Shevchenko wrote:
>
> > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote:
> > > On Fri, 29 Jan 2021 16:26:12 +0200
> > > Andy Shevchenko wrote:
> > > > On Fri,
+Cc: Sakari and printk people
On Mon, Feb 15, 2021 at 4:28 PM Christian König
wrote:
> Am 15.02.21 um 15:21 schrieb Andy Shevchenko:
> > We have already few similar implementation and a lot of code that can
> > benefit
> > of the yesno() helper. Consolidate yesno() helper
We have already an implementation and a lot of code that can benefit
of the enableddisabled() helper. Move it under string.h hood.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_utils.h | 5 -
include/linux/string.h| 5 +
2 files changed, 5 insertions(+), 5
We have already an implementation and a lot of code that can benefit
of the onoff() helper. Move it under string.h hood.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_utils.h | 5 -
include/linux/string.h| 5 +
2 files changed, 5 insertions(+), 5 deletions
We have already few similar implementation and a lot of code that can benefit
of the yesno() helper. Consolidate yesno() helpers under string.h hood.
Signed-off-by: Andy Shevchenko
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c| 6 +-
drivers/gpu/drm/i915/i915_utils.h
On Mon, Feb 15, 2021 at 01:40:30PM +0200, Sakari Ailus wrote:
> Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
> large number of temporary variables at the same time.
What a nice clean up!
Reviewed-by: Andy Shevchenko
after addressing nit-picks below.
Side no
On Mon, Feb 15, 2021 at 01:40:29PM +0200, Sakari Ailus wrote:
> Now that we can print FourCC codes directly using printk, make use of the
> feature in V4L2 core.
Reviewed-by: Andy Shevchenko
See also below.
> Signed-off-by: Sakari Ailus
> ---
> drivers/media/v4l2-core/v4
l free to add
Reviewed-by: From: Andy Shevchenko
after considering addressing below nit-picks.
> Suggested-by: Mauro Carvalho Chehab
> Signed-off-by: Sakari Ailus
> Reviewed-by: Petr Mladek
> Reviewed-by: Sergey Senozhatsky
> ---
> Documentation/core-api/printk-formats
601 - 700 of 1013 matches
Mail list logo
