Hi,
At 2024-06-05 17:39:48, "Maxime Ripard" wrote:
>On Wed, Jun 05, 2024 at 11:28:41AM GMT, neil.armstr...@linaro.org wrote:
>> Hi,
>>
>> On 05/06/2024 11:25, Andy Yan wrote:
>> >
>> > Hi,
>> >
>> > At 2024-06-05 04
Hi,
At 2024-06-05 04:33:57, "Cristian Ciocaltea"
wrote:
>On 6/3/24 4:08 PM, neil.armstr...@linaro.org wrote:
>> Hi,
>>
>> On 03/06/2024 15:03, Heiko Stuebner wrote:
>>> Am Montag, 3. Juni 2024, 14:14:17 CEST schrieb Andy Yan:
>>>> Hi N
Hi Neil:
On 6/3/24 16:55, Neil Armstrong wrote:
Hi Christian,
On 01/06/2024 15:12, Cristian Ciocaltea wrote:
The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the
Synopsys DesignWare HDMI TX controller used in the previous SoCs.
It is HDMI 2.1 compliant and supports the following
Hi Heiko,
On 12/14/23 14:46, Andy Yan wrote:
Hi Heiko:
On 12/13/23 22:46, Heiko Stuebner wrote:
On Mon, 11 Dec 2023 19:55:47 +0800, Andy Yan wrote:
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
Hi Detlev，
At 2024-05-23 02:57:48, "Detlev Casanova" wrote:
>At the end of initialization, each VP clock needs to be reset before
>they can be used.
>
>Failing to do so can put the VOP in an undefined state where the
>generated HDMI signal is either lost or not matching the selected mode.
Hi Maxime,
At 2024-05-21 18:14:01, "Maxime Ripard" wrote:
>The new HDMI connector infrastructure allows to remove some boilerplate,
>especially to generate infoframes. Let's switch to it.
>
>Reviewed-by: Jernej Skrabec
>Acked-by: Sui Jingfeng
>Signed-off-by: Maxim
Hi Maxime，
At 2024-05-21 18:14:00, "Maxime Ripard" wrote:
>The new HDMI connector infrastructure allows to remove some boilerplate,
>especially to generate infoframes. Let's switch to it.
>
>Reviewed-by: Heiko Stuebner
>Acked-by: Heiko Stuebner
>Signed-off-by: Ma
Hi Maxime,
On 5/16/24 17:45, Maxime Ripard wrote:
Hi again,
On Sun, May 12, 2024 at 04:18:38PM +0800, Andy Yan wrote:
在 2024-05-07 21:17:33，"Maxime Ripard" 写道：
Now that we have all the infrastructure needed, we can add some code
that will, for a given connector state and mod
Hi Maxime，
在 2024-05-07 21:17:33，"Maxime Ripard" 写道：
>Now that we have all the infrastructure needed, we can add some code
>that will, for a given connector state and mode, compute the best output
>format and bpc.
>
>The algorithm is equivalent to the one already found in i915 and vc4.
>
>Cc:
Hi Maxime,
At 2024-05-07 21:17:45, "Maxime Ripard" wrote:
>The new HDMI connector infrastructure allows to remove some boilerplate,
>especially to generate infoframes. Let's switch to it.
>
>Reviewed-by: Heiko Stuebner
>Acked-by: Heiko Stuebner
>Signed-off-by: Maxime Ripard
>---
>
Hi Maxime,
On 5/6/24 15:59, Maxime Ripard wrote:
Hi Andy,
Thanks a lot for giving it a try
All the issues you raised in your review are fixed.
On Sat, Apr 27, 2024 at 06:44:54PM GMT, Andy Yan wrote:
And after this whole series applied on linux 6.9-rc4, the display on rk3036
kylin is lost
Hi Maxime,
On 5/6/24 15:59, Maxime Ripard wrote:
Hi Andy,
Thanks a lot for giving it a try
All the issues you raised in your review are fixed.
On Sat, Apr 27, 2024 at 06:44:54PM GMT, Andy Yan wrote:
And after this whole series applied on linux 6.9-rc4, the display on rk3036
kylin is lost
Hi Maxime,
On 4/23/24 18:45, Maxime Ripard wrote:
The new HDMI connector infrastructure allows to remove some boilerplate,
especially to generate infoframes. Let's switch to it.
Reviewed-by: Heiko Stuebner
Acked-by: Heiko Stuebner
Signed-off-by: Maxime Ripard
---
Hi Maxime,
On 4/23/24 18:45, Maxime Ripard wrote:
The new HDMI connector infrastructure allows to remove some boilerplate,
especially to generate infoframes. Let's switch to it.
Reviewed-by: Heiko Stuebner
Acked-by: Heiko Stuebner
Signed-off-by: Maxime Ripard
---
From: Andy Yan
The port mux bits of VP2 should be defined by RK3568_OVL_PORT_SET__PORT2_MUX,
this maybe a copy and paste error when this driver first introduced.
Hi Heiko:
Maybe thi is the problem you met when you porting the dsi2 driver.
I previously sent you this patch when you ask me
From: Andy Yan
The port mux of VP2 should be RK3568_OVL_PORT_SET__PORT2_MUX.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
.
This fixes yuv planes being unaligned vertically when down scaling to
1080 pixels from 2160.
Signed-off-by: Detlev Casanova
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Acked-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 22 +++-
1 file c
From: Andy Yan
drm_dp_helper.h is not used by lvds driver
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_lvds.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c
b/drivers/gpu/drm/rockchip/rockchip_lvds.c
index 77b76cff1adb
From: Andy Yan
The firmware in the rootfs will not be accessible until we
are in the SYSTEM_RUNNING state, so return EPROBE_DEFER until
that point.
This let the driver can load firmware when it is builtin.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/panthor/panthor_fw.c | 11 ++-
1
Hi Heiko,
Could you please to take a look at this patch?
On 3/4/24 18:40, Sascha Hauer wrote:
On Mon, Mar 04, 2024 at 06:09:52PM +0800, Andy Yan wrote:
From: Andy Yan
The Alpha blending for 30 bit RGB/BGR are not
functioning properly for rk3568/rk3588, so remove
it from the format list
From: Andy Yan
The Alpha blending for 30 bit RGB/BGR are not
functioning properly for rk3568/rk3588, so remove
it from the format list.
Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_vop2
From: Andy Yan
The Alpha blending for 30 bit RGB/BGR are not
functioning properly for rk3568/rk3588, so remove
it from the format list.
Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
Signed-off-by: Andy Yan
---
drivers/gpu/drm/rockchip/rockchip_vop2
Hi Ondrej:
On 2/18/24 23:17, Ondřej Jirman wrote:
Hi Andy,
On Sun, Feb 18, 2024 at 07:14:56PM +0800, Andy Yan wrote:
Hi,
On 2/18/24 02:39, Ondřej Jirman wrote:
From: Ondrej Jirman
On RK3399 one MIPI DSI device can be alternatively used with the ISP1,
to provide RX DPHY. When
Hi,
On 2/18/24 02:39, Ondřej Jirman wrote:
From: Ondrej Jirman
On RK3399 one MIPI DSI device can be alternatively used with the ISP1,
to provide RX DPHY. When this is the case (ISP1 is enabled in device
tree), probe success of DRM is tied to probe success of ISP1 connected
camera sensor. This
HI Boris：
在 2024-02-05 17:03:21，"Boris Brezillon" 写道：
>+Danilo for the panthor gpuvm-needs update.
>
>On Sun, 4 Feb 2024 09:14:44 +0800 (CST)
>"Andy Yan" wrote:
>
>> Hi Boris：
>> I saw this warning sometimes（Run on a armbain based bookworm）
Hi Boris：
在 2024-02-05 17:03:21，"Boris Brezillon" 写道：
>+Danilo for the panthor gpuvm-needs update.
>
>On Sun, 4 Feb 2024 09:14:44 +0800 (CST)
>"Andy Yan" wrote:
>
>> Hi Boris：
>> I saw this warning sometimes（Run on a armbain based bookworm）
Hi Boris:
在 2024-02-04 18:07:56，"Boris Brezillon" 写道：
>On Sun, 4 Feb 2024 09:14:44 +0800 (CST)
>"Andy Yan" wrote:
>
>> Hi Boris：
>> I saw this warning sometimes（Run on a armbain based bookworm），not sure is a
>> know issue or something else。
&
20:47 +0800 (CST)
>"Andy Yan" wrote:
>
>> Hi Boris：
>>
>> Thanks for you great work。
>>
>> One thing please take note：
>> commit (arm64: dts: rockchip: rk3588: Add GPU nodes) in [1] seems remove
>> the "disabled" status
>&g
Hi Boris：
Thanks for you great work。
One thing please take note：
commit (arm64: dts: rockchip: rk3588: Add GPU nodes) in [1] seems remove the
"disabled" status
of usb_host2_xhci, this may cause a boot issue on some boards that use
combphy2_psu phy for other functions.
Hi Cristian:
On 1/5/24 03:12, Cristian Ciocaltea wrote:
Hi Heiko,
On 1/4/24 17:58, Heiko Stübner wrote:
Hi Christian, Andy,
Am Donnerstag, 4. Januar 2024, 15:39:50 CET schrieb Cristian Ciocaltea:
Commit 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588")
introduced a variable which
Hi:
On 1/4/24 23:58, Heiko Stübner wrote:
Hi Christian, Andy,
Am Donnerstag, 4. Januar 2024, 15:39:50 CET schrieb Cristian Ciocaltea:
Commit 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588")
introduced a variable which ended up being unused. Remove it.
rockchip_drm_vop2.c:1688:23:
+ Mark
Hi Marek andy Mark:
On 12/15/23 16:33, Andy Yan wrote:
Hi Marek:
On 12/15/23 08:59, Andy Yan wrote:
Hi Marek:
Sorry for this issue.
I also tested this series on RK3568/6 before I send them out.
But I didn't find anyahing unusal, would you please share the
linux kernel defconfig
Hi Marek:
On 12/15/23 08:59, Andy Yan wrote:
Hi Marek:
Sorry for this issue.
I also tested this series on RK3568/6 before I send them out.
But I didn't find anyahing unusal, would you please share the
linux kernel defconfig you used for this test and it would be
greatly appreciated
, Marek Szyprowski wrote:
Dear All,
On 11.12.2023 12:57, Andy Yan wrote:
From: Andy Yan
This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c.
regcache_sync will try to reload the configuration in regcache to
hardware, but the registers of 4 Cluster windows and Esmart1/2/3
Hi Heiko:
On 12/13/23 22:46, Heiko Stuebner wrote:
On Mon, 11 Dec 2023 19:55:47 +0800, Andy Yan wrote:
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max
Hi Keith:
在 2023-12-13 09:40:31，"Keith Zhao" 写道：
>
>
>On 2023/12/11 20:13, Andy Yan wrote:
>> Hi Keith：
>>
>> 在 2023-12-11 18:24:35，"Keith Zhao" 写道：
>>>hi Maxime:
>>>hi Andy:
>>>
>>>On 2023/12/8 17:14, Maxime R
Hi Keith：
在 2023-12-11 18:24:35，"Keith Zhao" 写道：
>hi Maxime:
>hi Andy:
>
>On 2023/12/8 17:14, Maxime Ripard wrote:
>> Hi,
>>
>> On Fri, Dec 08, 2023 at 11:23:37AM +0800, Andy Yan wrote:
>>> 在 2023-12-08 11:00:31，"Keith Zhao" 写道：
&g
From: Andy Yan
As I am familiar with all the details of vop2 display
architecture, I can help review and test all related
changes in this subsystem, so add my email here to make
sure I get CC'd on rockchip drm changes.
Signed-off-by: Andy Yan
---
(no changes since v1)
MAINTAINERS | 1 +
1
From: Andy Yan
Add vop dt node for rk3588.
Signed-off-by: Andy Yan
---
Changes in v5:
- remove unused property
- move blank line below the status=disabled in vop dt node
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 83 +++
1 file changed, 83 insertions(+)
diff --git
From: Andy Yan
/sys/kernel/debug/dri/vop2/summary: dump vop display state
/sys/kernel/debug/dri/vop2/regs: dump whole vop registers
/sys/kernel/debug/dri/vop2/active_regs: only dump the registers of
activated modules
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since
From: Andy Yan
VOP2 has multiple independent video ports with different
feature, so rename VOP_FEATURE_OUTPUT_10BIT to
VOP2_VP_FEATURE_OUTPUT_10BIT for more clearly meaning.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line RGB/YUV support
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
From: Andy Yan
There are 2 HDMI, 2 DP, 2 eDP on rk3588, so add
corresponding endpoint definition for it.
Signed-off-by: Andy Yan
Acked-by: Krzysztof Kozlowski
---
(no changes since v3)
Changes in v3:
- change the subject as Krzysztof suggested, and add his ACK
Changes in v2:
- split form
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.
Signed-off-by: Andy Yan
Reviewed-by: Krzysztof Kozlowski
---
(no changes since v4)
Changes in v4:
- drop redundant description.
- use full stop at all
From: Andy Yan
Add VOP and VO GRF syscon compatibles for RK3588
Signed-off-by: Andy Yan
Acked-by: Rob Herring
---
(no changes since v1)
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc
From: Andy Yan
The vop2 need to reference more grf(system grf, vop grf, vo0/1 grf,etc)
in the upcoming rk3588.
So we rename the current system grf to sys_grf.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8
From: Andy Yan
We need to setup background delay cycle and prescan
delay cycle when a mode is enable to avoid trigger
POST_BUF_EMPTY irq on rk3588.
Note: RK356x has no such requirement.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 26
From: Andy Yan
Set overlay mode register according to the
output mode is yuv or rgb.
Signed-off-by: Andy Yan
---
(no changes since v3)
Changes in v3:
- put bool variable yuv_overlay next to other bool variable
- define macro for RK3568_OVL_CTRL__YUV_MODE
- just write RK3568_OVL_CTRL
From: Andy Yan
The write mask bit is used to make sure when writing
config done bit for one VP will not overwrite the other.
Unfortunately, the write mask bit is missing on
rk3566/8, that means when we write to these bits,
it will not take any effect.
We need this to make the vop work properly
From: Andy Yan
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue on rk3588 which cluster windows switch between afbc and linear
mode.
As the cluster windows of rk3568 only supports afbc format
so is therefore
From: Andy Yan
At first we thought the half_block_en bit in AFBCD_CTRL register
only work in afbc mode. But the fact is that it control the line
buffer in all mode(afbc/tile/linear), so we need configure it in
all case.
As the cluster windows of rk3568 only supports afbc format
so is therefore
From: Andy Yan
This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c.
regcache_sync will try to reload the configuration in regcache to
hardware, but the registers of 4 Cluster windows and Esmart1/2/3 on
the upcoming rk3588 can not be set successfully before internal PD
power on.
Also
From: Andy Yan
The output interface related definition can shared between
vop and vop2, move them to rockchip_drm_drv.h can avoid duplicated
definition.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line
Hi Heiko:
On 12/9/23 00:26, Heiko Stübner wrote:
Hi Andy,
Am Donnerstag, 7. Dezember 2023, 09:02:47 CET schrieb Andy Yan:
From: Andy Yan
Add vop dt node for rk3588.
Signed-off-by: Andy Yan
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 96
HI Krzysztof:
On 12/9/23 01:46, Krzysztof Kozlowski wrote:
On 07/12/2023 09:01, Andy Yan wrote:
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
Changes in v4:
- drop redundant
Hi Heiko:
On 12/9/23 00:29, Heiko Stübner wrote:
Am Donnerstag, 7. Dezember 2023, 09:02:35 CET schrieb Andy Yan:
From: Andy Yan
Add a Rockchip RK3588 compatible
Signed-off-by: Andy Yan
Reviewed-by: Heiko Stuebner
In the next iteration, please split this out into a separate patch
Hi Heiko:
On 12/9/23 00:07, Heiko Stübner wrote:
Hi Andy,
Am Donnerstag, 7. Dezember 2023, 08:59:06 CET schrieb Andy Yan:
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max
Hi Keith：
在 2023-12-08 11:00:31，"Keith Zhao" 写道：
>
>
>On 2023/12/8 8:37, Andy Yan wrote:
>> Hi Keth：
>>
>>
>>
>>
>>
>>
>> 在 2023-12-07 18:48:13，"Keith Zhao" 写道：
>>
Hi Keth：
在 2023-12-07 18:48:13，"Keith Zhao" 写道：
>
>
>On 2023/12/7 17:02, Andy Yan wrote:
>>
>>
>>
>>
>> Hi Keith：
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> A
Hi Keith：
At 2023-12-06 22:11:33, "Keith Zhao" wrote:
>
>
>On 2023/12/6 20:56, Maxime Ripard wrote:
>> On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote:
>>> >> +static const struct of_device_id starfive_hdmi_dt_ids[] = {
>>> >> +{ .compatible =
From: Andy Yan
As I am familiar with all the details of vop2 display
architecture, I can help review and test all related
changes in this subsystem, so add my email here to make
sure I get CC'd on rockchip drm changes.
Signed-off-by: Andy Yan
---
(no changes since v1)
MAINTAINERS | 1 +
1
From: Andy Yan
Add a Rockchip RK3588 compatible
Signed-off-by: Andy Yan
---
Changes in v4:
- Add const for rockchip,rk3588-iommu compatible
.../devicetree/bindings/iommu/rockchip,iommu.yaml | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/Documentation
From: Andy Yan
Add vop dt node for rk3588.
Signed-off-by: Andy Yan
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 96 +++
1 file changed, 96 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
b/arch/arm64/boot/dts/rockchip
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line RGB/YUV support
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
From: Andy Yan
/sys/kernel/debug/dri/vop2/summary: dump vop display state
/sys/kernel/debug/dri/vop2/regs: dump whole vop registers
/sys/kernel/debug/dri/vop2/active_regs: only dump the registers of
activated modules
Signed-off-by: Andy Yan
---
Changes in v4:
- check NULL pointer at right
From: Andy Yan
VOP2 has multiple independent video ports with different
feature, so rename VOP_FEATURE_OUTPUT_10BIT to
VOP2_VP_FEATURE_OUTPUT_10BIT for more clearly meaning.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
drivers/gpu
From: Andy Yan
There are 2 HDMI, 2 DP, 2 eDP on rk3588, so add
corresponding endpoint definition for it.
Signed-off-by: Andy Yan
Acked-by: Krzysztof Kozlowski
---
(no changes since v3)
Changes in v3:
- change the subject as Krzysztof suggested, and add his ACK
Changes in v2:
- split form
From: Andy Yan
Add VOP and VO GRF syscon compatibles for RK3588
Signed-off-by: Andy Yan
Acked-by: Rob Herring
---
(no changes since v1)
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
Changes in v4:
- drop redundant description.
- use full stop at all the description's end.
- address Krzysztof's review in v3
Changes
From: Andy Yan
The vop2 need to reference more grf(system grf, vop grf, vo0/1 grf,etc)
in the upcoming rk3588.
So we rename the current system grf to sys_grf.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8
From: Andy Yan
We need to setup background delay cycle and prescan
delay cycle when a mode is enable to avoid trigger
POST_BUF_EMPTY irq on rk3588.
Note: RK356x has no such requirement.
Signed-off-by: Andy Yan
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 26
From: Andy Yan
Set overlay mode register according to the
output mode is yuv or rgb.
Signed-off-by: Andy Yan
---
(no changes since v3)
Changes in v3:
- put bool variable yuv_overlay next to other bool variable
- define macro for RK3568_OVL_CTRL__YUV_MODE
- just write RK3568_OVL_CTRL
From: Andy Yan
The write mask bit is used to make sure when writing
config done bit for one VP will not overwrite the other.
Unfortunately, the write mask bit is missing on
rk3566/8, that means when we write to these bits,
it will not take any effect.
We need this to make the vop work properly
From: Andy Yan
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue on rk3588 which cluster windows switch between afbc and linear
mode.
As the cluster windows of rk3568 only supports afbc format
so is therefore
From: Andy Yan
At first we thought the half_block_en bit in AFBCD_CTRL register
only work in afbc mode. But the fact is that it control the line
buffer in all mode(afbc/tile/linear), so we need configure it in
all case.
As the cluster windows of rk3568 only supports afbc format
so is therefore
From: Andy Yan
The output interface related definition can shared between
vop and vop2, move them to rockchip_drm_drv.h can avoid duplicated
definition.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1
From: Andy Yan
This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c.
regcache_sync will try to reload the configuration in regcache to
hardware, but the registers of 4 Cluster windows and Esmart1/2/3 on
the upcoming rk3588 can not be set successfully before internal PD
power on.
Also
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line
Hi Sascha:
On 12/6/23 19:20, Sascha Hauer wrote:
On Wed, Dec 06, 2023 at 06:20:58PM +0800, Andy Yan wrote:
Hi Sascha:
+ unsigned int n = vop2->data->regs_dump_size;
'n' is used only once, it might be clearer just to use the value where
needed and drop the extra variable.
Hi Sascha:
On 12/5/23 17:15, Sascha Hauer wrote:
On Thu, Nov 30, 2023 at 08:24:49PM +0800, Andy Yan wrote:
From: Andy Yan
/sys/kernel/debug/dri/vop2/summary: dump vop display state
/sys/kernel/debug/dri/vop2/regs: dump whole vop registers
/sys/kernel/debug/dri/vop2/active_regs: only dump
Hi Sascha:
On 12/5/23 17:29, Sascha Hauer wrote:
On Thu, Nov 30, 2023 at 08:24:39PM +0800, Andy Yan wrote:
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV
Hi Krzysztof:
On 11/23/23 03:07, Krzysztof Kozlowski wrote:
On 22/11/2023 13:55, Andy Yan wrote:
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
Changes in v2:
- fix errors when
From: Andy Yan
Add vop dt node for rk3588.
Signed-off-by: Andy Yan
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 96 +++
1 file changed, 96 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
b/arch/arm64/boot/dts/rockchip
From: Andy Yan
Add a Rockchip RK3588 compatible
Signed-off-by: Andy Yan
---
(no changes since v1)
Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
b/Documentation
From: Andy Yan
/sys/kernel/debug/dri/vop2/summary: dump vop display state
/sys/kernel/debug/dri/vop2/regs: dump whole vop registers
/sys/kernel/debug/dri/vop2/active_regs: only dump the registers of
activated modules
Signed-off-by: Andy Yan
---
Changes in v3:
- put regs dump info
From: Andy Yan
VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line RGB/YUV support
Signed-off-by: Andy Yan
---
Changes in v3:
- add braces
From: Andy Yan
There are 2 HDMI, 2 DP, 2 eDP on rk3588, so add
corresponding endpoint definition for it.
Signed-off-by: Andy Yan
Acked-by: Krzysztof Kozlowski
---
Changes in v3:
- change the subject as Krzysztof suggested, and add his ACK
Changes in v2:
- split form vop driver patch
From: Andy Yan
The vop2 on rk3588 is similar to which on rk356x
but with 4 video ports and need to reference
more grf modules.
Signed-off-by: Andy Yan
---
Changes in v3:
- constrain properties in allOf:if:then
- some description updates
Changes in v2:
- fix errors when running 'make
From: Andy Yan
Add VOP and VO GRF syscon compatibles for RK3588
Signed-off-by: Andy Yan
Acked-by: Rob Herring
---
(no changes since v1)
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc
From: Andy Yan
The vop2 need to reference more grf(system grf, vop grf, vo0/1 grf,etc)
in the upcoming rk3588.
So we rename the current system grf to sys_grf.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8
From: Andy Yan
Set overlay mode register according to the
output mode is yuv or rgb.
Signed-off-by: Andy Yan
---
Changes in v3:
- put bool variable yuv_overlay next to other bool variable
- define macro for RK3568_OVL_CTRL__YUV_MODE
- just write RK3568_OVL_CTRL register once in function
From: Andy Yan
The write mask bit is used to make sure when writing
config done bit for one VP will not overwrite the other.
Unfortunately, the write mask bit is missing on
rk3566/8, that means when we write to these bits,
it will not take any effect.
We need this to make the vop work properly
From: Andy Yan
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue on rk3588 which cluster windows switch between afbc and linear
mode.
As the cluster windows of rk3568 only supports afbc format
so is therefore
From: Andy Yan
At first we thought the half_block_en bit in AFBCD_CTRL register
only work in afbc mode. But the fact is that it control the line
buffer in all mode(afbc/tile/linear), so we need configure it in
all case.
As the cluster windows of rk3568 only supports afbc format
so is therefore
From: Andy Yan
This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c.
regcache_sync will try to reload the configuration in regcache to
hardware, but the registers of 4 Cluster windows and Esmart1/2/3 on
the upcoming rk3588 can not be set successfully before internal PD
power on.
Also
From: Andy Yan
The output interface related definition can shared between
vop and vop2, move them to rockchip_drm_drv.h can avoid duplicated
definition.
Signed-off-by: Andy Yan
Reviewed-by: Sascha Hauer
---
(no changes since v1)
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1
From: Andy Yan
This patch sets aims at enable the VOP2 support on rk3588.
Main feature of VOP2 on rk3588:
Four video ports:
VP0 Max 4096x2160
VP1 Max 4096x2160
VP2 Max 4096x2160
VP3 Max 2048x1080
4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
4 4K Esmart windows with line
Hi Sascha:
On 11/29/23 20:59, Sascha Hauer wrote:
On Wed, Nov 29, 2023 at 07:01:37PM +0800, Andy Yan wrote:
Hi Sascha:
On 11/29/23 16:52, Sascha Hauer wrote:
On Mon, Nov 27, 2023 at 06:56:34PM +0800, Andy Yan wrote:
Hi Sascha:
thanks for you review.
On 11/27/23 18:13
Hi Sascha:
On 11/29/23 16:52, Sascha Hauer wrote:
On Mon, Nov 27, 2023 at 06:56:34PM +0800, Andy Yan wrote:
Hi Sascha:
thanks for you review.
On 11/27/23 18:13, Sascha Hauer wrote:
On Wed, Nov 22, 2023 at 08:56:01PM +0800, Andy Yan wrote:
From: Andy Yan [1]
/sys/kernel
1 - 100 of 435 matches
Mail list logo
