Re: [PATCH v15 07/11] drm/mediatek: Add retry to prevent misjudgment for sink devices

2022-07-27 Thread AngeloGioacchino Del Regno
if (!ret) + break; + } while (--max_retry); + + dev_info(mtk_dp->dev, "dp training clear retry times: %d\n", +MTK_DP_TRAIN_CLEAR_RETRY - max_retry); dev_dbg() here. ...after which, Reviewed-by: AngeloGioacchino Del Regno + + if (!max_retry)

Re: [PATCH v15 06/11] drm/mediatek: Add MT8195 External DisplayPort support

2022-07-27 Thread AngeloGioacchino Del Regno
Il 27/07/22 06:50, Bo-Chen Chen ha scritto: From: Guillaume Ranquet This patch adds External DisplayPort support to the mt8195 eDP driver. Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v15 05/11] drm/mediatek: Add MT8195 Embedded DisplayPort driver

2022-07-27 Thread AngeloGioacchino Del Regno
that can be used to control the phy properties. This driver is based on an initial version by Jitao shi Signed-off-by: Markus Schneider-Pargmann Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Tested-by: AngeloGioacchino Del Regno Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v15 04/11] video/hdmi: Add audio_infoframe packing for DP

2022-07-27 Thread AngeloGioacchino Del Regno
Schneider-Pargmann Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v15 03/11] drm/edid: Add cea_sad helpers for freq/length

2022-07-27 Thread AngeloGioacchino Del Regno
. Signed-off-by: Markus Schneider-Pargmann Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH, v2] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-07-27 Thread AngeloGioacchino Del Regno
Il 27/07/22 08:13, Mingjia Zhang ha scritto: In order to reduce decoder latency, enable VP9 inner racing mode. Send lat trans buffer information to core when trigger lat to work, need not to wait until lat decode done. Signed-off-by: mingjia zhang For MT8195: Tested-by: AngeloGioacchino Del

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-22 Thread AngeloGioacchino Del Regno
ator. Signed-off-by: Alice Chen Signed-off-by: ChiYuan Huang Reviewed-by: AngeloGioacchino Del Regno --- v6 - Remove the 'ko' from mt6370 led Kconfig description. - Add both authors for Alice and ChiYuan. - Use pdata to distinguish the code from mt6370/71 to mt6372. - Instead of 'state' de

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

2022-07-22 Thread AngeloGioacchino Del Regno
Il 22/07/22 12:24, ChiaEn Wu ha scritto: From: Alice Chen The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED

Re: [RESEND] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-07-22 Thread AngeloGioacchino Del Regno
0:34 +0200, AngeloGioacchino Del Regno wrote: Il 15/07/22 08:49, Mingjia Zhang ha scritto: In order to reduce decoder latency, enable VP9 inner racing mode. Send lat trans buffer information to core when trigger lat to work, need not to wait until lat decode done. Signed-off-by: mingjia zhang --- CT

Re: [PATCH v7, 2/4] drm/mediatek: Separate poweron/poweroff from enable/disable and define new funcs

2022-07-21 Thread AngeloGioacchino Del Regno
Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen Reviewed-by: CK Hu Hello Xinlei, CK, maintainers: This patch is breaking machines that are using a DSI->DisplayPort bridge (like the ANX7625 chip), but that's not the ma

[PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks

2022-07-21 Thread AngeloGioacchino Del Regno
diatek: Modify dsi funcs to atomic operations") Signed-off-by: AngeloGioacchino Del Regno --- Note: The commit that has been mentioned in the Fixes tag should *not* have my Reviewed-by tag, as the author changed it but erroneously retained the tag that I had released for an

Re: [PATCH v2] drm/panel-edp: Add panel entry for B120XAN01.0

2022-07-21 Thread AngeloGioacchino Del Regno
Il 20/07/22 21:11, Nícolas F. R. A. Prado ha scritto: Add panel identification entry for the AUO B120XAN01.0 (product ID: 0x1062) panel. Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 1/3] drm/panel-edp: Add panel entry for R140NWF5 RH

2022-07-20 Thread AngeloGioacchino Del Regno
s truly helpful! (especially for me being paranoid :-P) So, I agree to go with that one, for which: Reviewed-by: AngeloGioacchino Del Regno Nic, green light? Cheers, (and thanks again!) Angelo

Re: [PATCH 3/3] drm/panel-edp: Fix variable typo when saving hpd absent delay from DT

2022-07-20 Thread AngeloGioacchino Del Regno
probed by EDID") Signed-off-by: Nícolas F. R. A. Prado I think you should've sent this separately from the rest of the series, especially because of the questions etc. In any case, for this commit: Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] dt-bindings: display: mediatek: dpi: add power-domains property

2022-07-18 Thread AngeloGioacchino Del Regno
: Reviewed-by: AngeloGioacchino Del Regno ...but I'm not sure whether this one requires a Fixes tag (because, effectively, the DPI hardware *requires* that power domain to get up) - and if it does, which commit to reference: the first commit for this file is a TXT->schema conversion, but the

Re: [PATCH v5 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-07-18 Thread AngeloGioacchino Del Regno
Il 15/07/22 18:29, Daniel Thompson ha scritto: On Fri, Jul 15, 2022 at 02:38:45PM +0200, AngeloGioacchino Del Regno wrote: Il 15/07/22 13:26, ChiaEn Wu ha scritto: From: ChiaEn Wu MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual

Re: [PATCH v5 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

2022-07-16 Thread AngeloGioacchino Del Regno
iver, a backlight WLED driver, a display bias driver and a general LDO for portable devices. This commit add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC. Signed-off-by: ChiYuan Huang Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v5 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-07-16 Thread AngeloGioacchino Del Regno
Il 15/07/22 13:26, ChiaEn Wu ha scritto: From: ChiaEn Wu MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD

Re: [PATCH v5 09/13] iio: adc: mt6370: Add MediaTek MT6370 support

2022-07-16 Thread AngeloGioacchino Del Regno
; PD controller complies with the latest USB Type-C and PD standards. This adds support the MT6370 ADC driver for system monitoring, including charger current, voltage, and temperature. Signed-off-by: ChiaEn Wu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-16 Thread AngeloGioacchino Del Regno
Il 15/07/22 13:26, ChiaEn Wu ha scritto: From: ChiYuan Huang The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED

Re: [RESEND] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-07-15 Thread AngeloGioacchino Del Regno
Il 15/07/22 08:49, Mingjia Zhang ha scritto: In order to reduce decoder latency, enable VP9 inner racing mode. Send lat trans buffer information to core when trigger lat to work, need not to wait until lat decode done. Signed-off-by: mingjia zhang --- CTS/GTS test pass CTS/GTS passing is a

Re: [PATCH v14 09/10] drm/mediatek: DP audio support for MT8195

2022-07-14 Thread AngeloGioacchino Del Regno
Il 12/07/22 13:12, Bo-Chen Chen ha scritto: From: Guillaume Ranquet This patch adds audio support to the DP driver for MT8195 with up to 8 channels. Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen --- drivers/gpu/drm/mediatek/mtk_dp.c | 723 ++

Re: [PATCH v14 04/10] video/hdmi: Add audio_infoframe packing for DP

2022-07-14 Thread AngeloGioacchino Del Regno
Il 12/07/22 13:12, Bo-Chen Chen ha scritto: From: Markus Schneider-Pargmann Similar to HDMI, DP uses audio infoframes as well which are structured very similar to the HDMI ones. This patch adds a helper function to pack the HDMI audio infoframe for DP, called

Re: [PATCH v14 03/10] drm/edid: Add cea_sad helpers for freq/length

2022-07-14 Thread AngeloGioacchino Del Regno
Il 12/07/22 13:12, Bo-Chen Chen ha scritto: From: Guillaume Ranquet This patch adds two helper functions that extract the frequency and word length from a struct cea_sad. For these helper functions new defines are added that help translate the 'freq' and 'byte2' fields into real numbers.

Re: [PATCH] drm/mediatek: ensure bridge disable happends before suspend

2022-07-04 Thread AngeloGioacchino Del Regno
Il 29/06/22 21:05, Hsin-Yi Wang ha scritto: Make sure bridge_disable will be called before suspend by calling drm_mode_config_helper_suspend() in .prepare callback. Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno --- The issue is found if suspend

Re: [PATCH v13 10/10] drm/mediatek: fix no audio when resolution change

2022-07-01 Thread AngeloGioacchino Del Regno
suitable description would be: Use the cached audio configuration during a resolution switch to avoid loss of sound. (perhaps also explain why we're losing it and why using cached data is necessary). After which... Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v13 09/10] drm/mediatek: DP audio support for MT8195

2022-07-01 Thread AngeloGioacchino Del Regno
Il 01/07/22 08:28, Bo-Chen Chen ha scritto: From: Guillaume Ranquet This patch adds audio support to the DP driver for MT8195 with up to 8 channels. Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v13 06/10] drm/mediatek: Add MT8195 External DisplayPort support

2022-07-01 Thread AngeloGioacchino Del Regno
Il 01/07/22 08:28, Bo-Chen Chen ha scritto: From: Guillaume Ranquet This patch adds External DisplayPort support to the mt8195 eDP driver. Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen --- drivers/gpu/drm/mediatek/mtk_dp.c | 197 +-

Re: [PATCH v13 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

2022-07-01 Thread AngeloGioacchino Del Regno
that can be used to control the phy properties. This driver is based on an initial version by Jitao shi Signed-off-by: Markus Schneider-Pargmann Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/bridge: add it6505 driver read config from dt property

2022-06-27 Thread AngeloGioacchino Del Regno
Il 23/06/22 11:31, allen ha scritto: From: allen chen add read max-lane and max-pixel-clock from dt property Signed-off-by: Allen-kh Cheng Signed-off-by: Pin-yen Lin Hello Allen, as Sam also pointed out, please fix your S-o-b email: it has to match with the author one. Anyway, you're

Re: [PATCH v12 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

2022-06-27 Thread AngeloGioacchino Del Regno
Il 27/06/22 12:30, Rex-BC Chen ha scritto: On Mon, 2022-06-27 at 18:07 +0800, AngeloGioacchino Del Regno wrote: Il 27/06/22 10:03, Bo-Chen Chen ha scritto: From: Markus Schneider-Pargmann This patch adds a embedded displayport driver for the MediaTek mt8195 SoC. It supports the MT8195

Re: [PATCH v14 15/15] drm/mediatek: dpi: Only enable dpi after the bridge is enabled

2022-06-27 Thread AngeloGioacchino Del Regno
iatek: Add DPI sub driver") Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Tested-by: AngeloGioacchino Del Regno

Re: [PATCH v14 14/15] drm/mediatek: dpi: Add dp_intf support

2022-06-27 Thread AngeloGioacchino Del Regno
illaume Ranquet [Bo-Chen: Modify reviewers' comments.] Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v12 08/10] drm/mediatek: set monitor to DP_SET_POWER_D3 to avoid garbage

2022-06-27 Thread AngeloGioacchino Del Regno
Il 27/06/22 10:03, Bo-Chen Chen ha scritto: Set the monitor power state to DP_SET_POWER_D3 to avoid garbage. Signed-off-by: Jitao Shi Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v12 07/10] drm/mediatek: add hpd debounce

2022-06-27 Thread AngeloGioacchino Del Regno
B3 hub - Acer 2in1 HDMI dongle - Apple 3in1 HDMI dongle (A2119) - J5Create 3in1 HDMI dongle (JAC379) Tested-by: Rex-BC Chen Reviewed-by: Rex-BC Chen Signed-off-by: Jitao Shi Signed-off-by: Guillaume Ranquet Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v12 06/10] drm/mediatek: Add MT8195 External DisplayPort support

2022-06-27 Thread AngeloGioacchino Del Regno
Il 27/06/22 10:03, Bo-Chen Chen ha scritto: From: Guillaume Ranquet This patch adds External DisplayPort support to the mt8195 eDP driver. Signed-off-by: Guillaume Ranquet [Bo-Chen: Move some dp features here and modify for reviewers' comments.] Signed-off-by: Bo-Chen Chen ---

Re: [PATCH v12 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

2022-06-27 Thread AngeloGioacchino Del Regno
Il 27/06/22 10:03, Bo-Chen Chen ha scritto: From: Markus Schneider-Pargmann This patch adds a embedded displayport driver for the MediaTek mt8195 SoC. It supports the MT8195, the embedded DisplayPort units. It offers DisplayPort 1.4 with up to 4 lanes. The driver creates a child device for

Re: [PATCH] soc: mediatek: mutex: add suffix 0 to DDP_COMPONENT_DITHER for mt8395

2022-06-23 Thread AngeloGioacchino Del Regno
Il 23/06/22 02:33, Jason-JH Lin ha scritto: Hi Angelo, Yes, I missed that! So just forget about this patch and use yours. Thanks for your help :) No worries, it happens... Btw, you're welcome. Cheers! Regard, Jason-JH.Lin On Wed, 2022-06-22 at 15:31 +0200, AngeloGioacchino Del Regno

Re: [PATCH] soc: mediatek: mutex: add suffix 0 to DDP_COMPONENT_DITHER for mt8395

2022-06-22 Thread AngeloGioacchino Del Regno
Il 22/06/22 15:19, Jason-JH.Lin ha scritto: Add suffix 0 to DDP_COMPONENT_DITHER for mt8395. Fixes: 141311b856d8 ("soc: mediatek: mutex: add MT8365 support") Signed-off-by: Jason-JH.Lin Hello Jason-JH, you must've missed my commit, sent two days ago, which is doing the same:

Re: [PATCH v13 01/14] dt-bindings: mediatek,dpi: Add DP_INTF compatible

2022-06-21 Thread AngeloGioacchino Del Regno
-by: AngeloGioacchino Del Regno

Re: [PATCH v13 02/14] drm/mediatek: dpi: Add kernel document for struct mtk_dpi_conf

2022-06-21 Thread AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v13 03/14] drm/mediatek: dpi: Add support for quantization range

2022-06-21 Thread AngeloGioacchino Del Regno
-by: AngeloGioacchino Del Regno

Re: [PATCH v13 11/14] drm/mediatek: dpi: Add YUV422 output support

2022-06-21 Thread AngeloGioacchino Del Regno
change INT_MATRIX_SEL_MASK: that's GENMASK(4, 0). After that, Reviewed-by: AngeloGioacchino Del Regno #endif /* __MTK_DPI_REGS_H */

Re: [PATCH v13 12/14] drm/mediatek: dpi: add config to control setting of direct connection to pins

2022-06-21 Thread AngeloGioacchino Del Regno
P supports direct connection to pins or @support_direct_pin: IP has direct connection to DP pins or @support_direct_pin: IP connects directly to DP pins pick one, after which: Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v13 13/14] drm/mediatek: dpi: Add dp_intf support

2022-06-21 Thread AngeloGioacchino Del Regno
Il 21/06/22 13:37, Bo-Chen Chen ha scritto: From: Guillaume Ranquet Dpintf is the displayport interface hardware unit. This unit is similar to dpi and can reuse most of the code. This patch adds support for mt8195-dpintf to this dpi driver. Main differences are: - 4 pixels for one round for

Re: [PATCH, v2] media: mediatek: vcodec: Initialize decoder parameters after getting dec_capability

2022-06-20 Thread AngeloGioacchino Del Regno
by: Yunfei Dong Tested-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v4 0/7] usb: typec: Introduce typec-switch binding

2022-06-16 Thread AngeloGioacchino Del Regno
Gioacchino Del Regno Regards, Angelo

Re: [PATCH v2 7/7] drm/bridge: anx7625: Add typec_mux_set callback function

2022-06-15 Thread AngeloGioacchino Del Regno
Il 14/06/22 18:58, Prashant Malani ha scritto: On Tue, Jun 14, 2022 at 2:08 AM Pin-yen Lin wrote: Hi AngeloGioacchino, On Tue, Jun 14, 2022 at 4:15 PM AngeloGioacchino Del Regno wrote: Il 09/06/22 20:09, Prashant Malani ha scritto: From: Pin-Yen Lin Add the callback function when

Re: [PATCH v2 6/7] drm/bridge: anx7625: Register Type-C mode switches

2022-06-15 Thread AngeloGioacchino Del Regno
Il 14/06/22 18:57, Prashant Malani ha scritto: On Tue, Jun 14, 2022 at 1:18 AM AngeloGioacchino Del Regno wrote: Il 09/06/22 20:09, Prashant Malani ha scritto: When the DT node has "switches" available, register a Type-C mode-switch for each listed "switch". This allows t

Re: [PATCH v2 1/7] usb: typec: mux: Allow muxes to specify mode-switch

2022-06-14 Thread AngeloGioacchino Del Regno
a pointer to the mux switch associated with a Type C port, but don't want to specify a particular alt mode. Signed-off-by: Prashant Malani Reviewed-by: Heikki Krogerus Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 2/7] usb: typec: mux: Add CONFIG guards for functions

2022-06-14 Thread AngeloGioacchino Del Regno
Il 09/06/22 20:09, Prashant Malani ha scritto: There are some drivers that can use the Type C mux API, but don't have to. Introduce CONFIG guards for the mux functions so that drivers can include the header file and not run into compilation errors on systems which don't have CONFIG_TYPEC

Re: [PATCH v2 5/7] drm/bridge: anx7625: Register number of Type C switches

2022-06-14 Thread AngeloGioacchino Del Regno
Il 09/06/22 20:09, Prashant Malani ha scritto: Parse the "switches" node, if available, and count and store the number of Type-C switches within it. Since we currently don't do anything with this info, no functional changes are expected from this change. This patch sets a foundation for the

Re: [PATCH v2 6/7] drm/bridge: anx7625: Register Type-C mode switches

2022-06-14 Thread AngeloGioacchino Del Regno
Il 09/06/22 20:09, Prashant Malani ha scritto: When the DT node has "switches" available, register a Type-C mode-switch for each listed "switch". This allows the driver to receive state information about what operating mode a Type-C port and its connected peripherals are in, as well as status

Re: [PATCH v2 7/7] drm/bridge: anx7625: Add typec_mux_set callback function

2022-06-14 Thread AngeloGioacchino Del Regno
Il 09/06/22 20:09, Prashant Malani ha scritto: From: Pin-Yen Lin Add the callback function when the driver receives state changes of the Type-C port. The callback function configures the crosspoint switch of the anx7625 bridge chip, which can change the output pins of the signals according to

Re: [PATCH] drm/bridge: anx7625: Zero error variable when panel bridge not present

2022-06-14 Thread AngeloGioacchino Del Regno
625: switch to devm_drm_of_get_bridge") Signed-off-by: Nícolas F. R. A. Prado I would've preferred s/zero out/cleanup/g but it's also fine as you wrote it. Besides, good catch! Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 10/12] drm/mediatek: dpi: Add dpintf support

2022-06-13 Thread AngeloGioacchino Del Regno
Il 13/06/22 08:48, Bo-Chen Chen ha scritto: From: Guillaume Ranquet dpintf is the displayport interface hardware unit. This unit is similar to dpi and can reuse most of the code. This patch adds support for mt8195-dpintf to this dpi driver. Main differences are: - Some features/functional

Re: [PATCH v11 1/1] phy: phy-mtk-dp: Add driver for DP phy

2022-06-13 Thread AngeloGioacchino Del Regno
on (being managed elsewhere and strongly tied to the specific DP IP). Besides that, Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v3 8/8] drm/mediatek: Config orientation property if panel provides it

2022-06-06 Thread AngeloGioacchino Del Regno
-by: Hsin-Yi Wang Reviewed-by: Hans de Goede Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v10 02/21] dt-bindings: mediatek,dp: Add Display Port binding

2022-05-25 Thread AngeloGioacchino Del Regno
Il 23/05/22 12:47, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This controller is present on several mediatek hardware. Currently mt8195 and mt8395 have this controller without a functional difference, so only one compatible field is added. The controller can have two forms,

Re: [PATCH v10 19/21] drm/mediatek: Add mt8195 External DisplayPort support

2022-05-25 Thread AngeloGioacchino Del Regno
Il 23/05/22 12:47, Guillaume Ranquet ha scritto: This patch adds External DisplayPort support to the mt8195 eDP driver. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dp.c | 104 +++--- 1 file changed, 81 insertions(+), 23 deletions(-) Your

Re: [PATCH v10 14/21] drm/mediatek: dpi: Add dpintf support

2022-05-25 Thread AngeloGioacchino Del Regno
Il 23/05/22 12:47, Guillaume Ranquet ha scritto: dpintf is the displayport interface hardware unit. This unit is similar to dpi and can reuse most of the code. This patch adds support for mt8195-dpintf to this dpi driver. Main differences are: - Some features/functional components are not

Re: [PATCH v10 05/21] video/hdmi: Add audio_infoframe packing for DP

2022-05-25 Thread AngeloGioacchino Del Regno
Il 23/05/22 12:47, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann Similar to HDMI, DP uses audio infoframes as well which are structured very similar to the HDMI ones. This patch adds a helper function to pack the HDMI audio infoframe for DP, called

Re: [PATCH v10 04/21] drm/edid: Add cea_sad helpers for freq/length

2022-05-25 Thread AngeloGioacchino Del Regno
Il 23/05/22 12:47, Guillaume Ranquet ha scritto: This patch adds two helper functions that extract the frequency and word length from a struct cea_sad. For these helper functions new defines are added that help translate the 'freq' and 'byte2' fields into real numbers. Signed-off-by: Markus

Re: [PATCH v10 03/21] drm/edid: Convert cea_sad helper struct to kernelDoc

2022-05-25 Thread AngeloGioacchino Del Regno
Short Audio Descriptor ...but that's relative to personal liking and nothing else, it's also fine as it is, if you like it more as it is. The ball is yours :-P Regardless of any choice about changing the description or not: Reviewed-by: AngeloGioacchino Del Regno Cheers, Angelo + *

Re: [PATCH v10 01/21] dt-bindings: mediatek,dpi: Add DPINTF compatible

2022-05-25 Thread AngeloGioacchino Del Regno
Il 23/05/22 12:47, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann DPINTF is similar to DPI but does not have the exact same feature set or register layouts. DPINTF is the sink of the display pipeline that is connected to the DisplayPort controller and encoder unit. It takes the

Re: [PATCH v21 00/25] Add MediaTek SoC DRM (vdosys1) support for mt8195

2022-05-25 Thread AngeloGioacchino Del Regno
and that there's no regression on older ones, so on all patches you can add my: [Tested on MT6795, MT8173, MT8192, MT8195] Tested-by: AngeloGioacchino Del Regno BUT! This series won't apply cleanly anymore on next-20220525 (same for vdosys0, already pinged Jason about it) because of the commits

Re: [PATCH v20 0/8] Add Mediatek Soc DRM (vdosys0) support for mt8195

2022-05-25 Thread AngeloGioacchino Del Regno
Il 19/04/22 11:41, jason-jh.lin ha scritto: From: jason-jhlin Hello Jason, this series does not apply cleanly anymore on next-20220525, can you please rebase and resend? I hope that with a bit of coordination, we can get the entire display stack finally upstreamed in v5.19... it's been

Re: [PATCH , v4] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

2022-05-12 Thread AngeloGioacchino Del Regno
codec: vdec: support stateless API") Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v5, 4/5] drm/mediatek: keep dsi as LP00 before dcs cmds transfer

2022-05-11 Thread AngeloGioacchino Del Regno
mipi signal high in the mtk_output_dsi_enable function. The delay in lane_ready func is the reaction time of dsi_rx after pulling up the mipi signal. Fixes: 2dd8075d2185 ("drm/mediatek: mtk_dsi: Use the drm_panel_bridge API") Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

2022-05-09 Thread AngeloGioacchino Del Regno
Il 09/05/22 12:44, Krzysztof Kozlowski ha scritto: On 09/05/2022 10:54, Rex-BC Chen wrote: +soc { +#address-cells = <2>; +#size-cells = <2>; + +disp_ethdr@1c114000 { No underscores in node name. Generic node names, so display- controller? OK, we will change the

Re: [PATCH v20 06/25] soc: mediatek: add mtk_mmsys_update_bits API

2022-05-04 Thread AngeloGioacchino Del Regno
Il 04/05/22 11:14, Nancy.Lin ha scritto: Add mtk_mmsys_update_bits API. Simplify code for update mmsys reg. It is a preparation for adding support for mmsys config API. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v5 4/4] drm/mediatek: Add MT8186 DSI compatible for mtk_drm_drv.c

2022-05-04 Thread AngeloGioacchino Del Regno
Il 28/04/22 15:37, Rex-BC Chen ha scritto: The compatible "mediatek,mt8186-dsi" is used by MT8186 DSI, so add it to mtk_ddp_comp_dt_ids in mtk_drm_drv.c. Signed-off-by: Rex-BC Chen Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v19 06/25] soc: mediatek: add mtk_mmsys_write_reg API

2022-05-03 Thread AngeloGioacchino Del Regno
Il 03/05/22 12:23, Nancy.Lin ha scritto: Add mtk_mmsys_write_reg API. Simplify code for writing mmsys reg. It is a preparation for adding support for mmsys config API. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mtk-mmsys.c | 35 ++-- 1 file changed, 15

Re: [PATCH v19 09/25] soc: mediatek: mmsys: add mmsys for support 64 reset bits

2022-05-03 Thread AngeloGioacchino Del Regno
"get mmsys->data" code section for getting the num_resets in mmsys->data. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v19 04/25] soc: mediatek: add mtk-mmsys ethdr and mdp_rdma components

2022-05-03 Thread AngeloGioacchino Del Regno
Il 03/05/22 12:23, Nancy.Lin ha scritto: Add new mmsys component: ethdr_mixer and mdp_rdma. These components will use in mt8195 vdosys1. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v19 11/25] soc: mediatek: add mtk-mutex component - dp_intf1

2022-05-03 Thread AngeloGioacchino Del Regno
-by: AngeloGioacchino Del Regno

Re: [PATCH v4, 1/1] drm/mediatek: add lut diff flag for new gamma hardware support

2022-04-28 Thread AngeloGioacchino Del Regno
-by: AngeloGioacchino Del Regno

Re: [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-04-22 Thread AngeloGioacchino Del Regno
Il 22/04/22 10:52, cgel@gmail.com ha scritto: From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v19 08/10] soc: mediatek: add DDP_DOMPONENT_DITHER0 enum for mt8195 vdosys0

2022-04-15 Thread AngeloGioacchino Del Regno
enum until drm/mediatek also changed it. Signed-off-by: jason-jh.lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v19 09/10] drm/mediatek: add postfix 0 to DDP_COMPONENT_DITHER for mt8195 vdosys0

2022-04-15 Thread AngeloGioacchino Del Regno
ot; should be "suffix" instead :))) In any case: Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v19 10/10] soc: mediatek: remove DDP_DOMPONENT_DITHER enum

2022-04-15 Thread AngeloGioacchino Del Regno
enum that "from" is important, as you're not removing *an enum*, but *from an enum*. After that: Reviewed-by: AngeloGioacchino Del Regno Thanks! Angelo

Re: [PATCH v19 07/10] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

2022-04-15 Thread AngeloGioacchino Del Regno
Il 15/04/22 10:39, jason-jh.lin ha scritto: 1. Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. 2. Add get driver data function to identify which vdosys by io_start. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 +

Re: [PATCH v19 03/10] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2022-04-15 Thread AngeloGioacchino Del Regno
ture breakage for "reasons"), we shall comply with the kernel types, so, this has to be... const resource_size_t io_start; ...and this is the same for both this file and mtk_drm_drv.h, which you modify in patch 07/10. After fixing that: Reviewed-by: AngeloGioacchino Del Regno Cheers, Angelo

Re: [PATCH v6 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2022-04-14 Thread AngeloGioacchino Del Regno
Il 14/04/22 04:50, Nick Fan ha scritto: Add devicetree schema for Arm Mali Valhall GPU Define a compatible string for the Mali Valhall GPU for MediaTek's SoC platform. Signed-off-by: Nick Fan Hello Nick, Unfortunately, this binding is completely wrong. First of all, there's no

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-13 Thread AngeloGioacchino Del Regno
Il 13/04/22 09:03, allen-kh.cheng ha scritto: Hi Nicolas, On Tue, 2022-04-12 at 10:48 -0400, Nicolas Dufresne wrote: Le lundi 11 avril 2022 à 11:41 +0800, yunfei.d...@mediatek.com a écrit : Hi Nicolas, On Thu, 2022-03-31 at 16:48 -0400, Nicolas Dufresne wrote: Hi Yunfei, thanks for the

Re: [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-04-13 Thread AngeloGioacchino Del Regno
Il 12/04/22 11:46, Guillaume Ranquet ha scritto: On Mon, 28 Mar 2022 11:14, AngeloGioacchino Del Regno wrote: Il 28/03/22 00:39, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. It supports the mt8195

Re: [PATCH v4, 3/4] drm/mediatek: keep dsi as LP00 before dcs cmds transfer

2022-04-11 Thread AngeloGioacchino Del Regno
Il 11/04/22 04:31, xinlei@mediatek.com ha scritto: From: Jitao Shi To comply with the panel sequence, hold the mipi signal to LP00 before the dcs cmds transmission, and pull the mipi signal high from LP00 to LP11 until the start of the dcs cmds transmission. The normal panel timing is :

Re: [PATCH v4, 2/4] drm/mediatek: Separate poweron/poweroff from enable/disable and define new funcs

2022-04-11 Thread AngeloGioacchino Del Regno
diatek: mtk_dsi: Use the drm_panel_bridge API") Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v4, 1/4] drm/mediatek: Adjust the timing of mipi signal from LP00 to LP11

2022-04-11 Thread AngeloGioacchino Del Regno
2. Pull the MIPI signal high 3. Delay & Dsi_reset 4. dsi clk & lanes leave ulp mode and enter hs mode Fixes: 2dd8075d2185 ("drm/mediatek: mtk_dsi: Use the drm_panel_bridge API") Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/bridge: anx7625: Use irq flags from devicetree

2022-04-08 Thread AngeloGioacchino Del Regno
Il 08/04/22 03:33, Nícolas F. R. A. Prado ha scritto: Read the irq flags, like which edge to trigger on, from the devicetree and use those when registering the irq instead of hardcoding them. In case none was specified, fallback to falling edge trigger. Signed-off-by: Nícolas F. R. A. Prado

Re: [PATCH] drm/bridge: anx7625: Use uint8 for lane-swing arrays

2022-04-08 Thread AngeloGioacchino Del Regno
: add MIPI DPI input feature") Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192

2022-04-08 Thread AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado Lovely! Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 3/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8192

2022-04-06 Thread AngeloGioacchino Del Regno
Il 06/04/22 12:48, Rex-BC Chen ha scritto: On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote: Il 06/04/22 11:46, Rex-BC Chen ha scritto: The driver data for MT8192 is the same with MT8183. Therefore, we correct it. Signed-off-by: Rex-BC Chen Reviewed-by: AngeloGioacchino

Re: [PATCH 3/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8192

2022-04-06 Thread AngeloGioacchino Del Regno
Il 06/04/22 11:46, Rex-BC Chen ha scritto: The driver data for MT8192 is the same with MT8183. Therefore, we correct it. Signed-off-by: Rex-BC Chen Reviewed-by: AngeloGioacchino Del Regno ...though, from what I know, you should also move MT8195 down there!

Re: [PATCH 2/3] arm64: dts: mt8183: Correct disp_aal node compatible

2022-04-06 Thread AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183

2022-04-06 Thread AngeloGioacchino Del Regno
that things are clear for people with less expertise on MediaTek platforms. After that: Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

2022-04-05 Thread AngeloGioacchino Del Regno
("media: mtk-vcodec: vdec: support stateless API") Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] media: mediatek: vcodec: fix v4l2 compliance decoder cmd test fail

2022-04-01 Thread AngeloGioacchino Del Regno
Il 01/04/22 05:04, Yunfei Dong ha scritto: Will return -EINVAL using standard framework api when test stateless decoder with cmd VIDIOC_(TRY)DECODER_CMD. Using another return value to adjust v4l2 compliance test for user driver(GStreamer/Chrome) won't use decode cmd. Signed-off-by: Yunfei Dong

[PATCH v2] phy: mediatek: phy-mtk-mipi-dsi: Simplify with dev_err_probe()

2022-03-28 Thread AngeloGioacchino Del Regno
Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno --- v2: Sorry, v1 was only partial as I have accidentally sent the wrong patch file. Fixed for v2. drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 29 + 1

[PATCH] phy: mediatek: phy-mtk-mipi-dsi: Simplify with dev_err_probe()

2022-03-28 Thread AngeloGioacchino Del Regno
Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy

<    7   8   9   10   11   12   13   14   15   >