Re: [PATCH] drm/tests: Alloc drm_device on drm_exec tests

2023-07-28 Thread Arthur Grillo Queiroz Cabral
On 28/07/23 11:33, Maxime Ripard wrote: > Hi, > > On Thu, Jul 27, 2023 at 04:22:59PM -0300, Arthur Grillo wrote: >> The drm_exec tests where crashing[0] because of a null dereference. This >> is caused by a new access of the `driver` attribute of `struct >> drm_driver` on

Re: [PATCH] drm/tests: Remove CONFIG_DRM_FBDEV_EMULATION on .kunitconfig

2023-07-27 Thread Arthur Grillo Queiroz Cabral
On 27/07/23 05:33, Arnd Bergmann wrote: > On Thu, Jul 27, 2023, at 00:03, Arthur Grillo wrote: >> Using the `kunit_tool` with the command: >> >> tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests/ >> >> Lead to this error[0]. Fix it by expliciting removing the >>

Re: [PATCH] drm/tests: Remove CONFIG_DRM_FBDEV_EMULATION on .kunitconfig

2023-07-27 Thread Arthur Grillo Queiroz Cabral
On 27/07/23 13:07, Javier Martinez Canillas wrote: > "Arnd Bergmann" writes: > >> On Thu, Jul 27, 2023, at 00:03, Arthur Grillo wrote: >>> Using the `kunit_tool` with the command: >>> >>> tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests/ >>> >>> Lead to this error[0]. Fix

Re: [PATCH v4] drm/vkms: Add support to 1D gamma LUT

2023-07-03 Thread Arthur Grillo Queiroz Cabral
On 02/07/23 18:37, Maira Canal wrote: > On 6/27/23 05:12, Pekka Paalanen wrote: >> On Mon, 26 Jun 2023 14:35:25 -0300 >> Maira Canal wrote: >> >>> Hi Pekka, >>> >>> On 6/26/23 05:17, Pekka Paalanen wrote: On Sat, 24 Jun 2023 18:48:08 -0300 Maira Canal wrote: > Hi Arthur,

Re: [PATCH] drm/tests: Add test case for drm_rect_clip_scaled()

2023-06-21 Thread Arthur Grillo Queiroz Cabral
On 14/06/23 14:54, nelsonbogado99 wrote: > From: Nelson Bogado > > To evaluate the behavior of the drm_rect_clip_scaled() helper function > with misplaced rectangles and improve the robustness and quality of it. > > The new test was executed using the following command: > > $

Re: [PATCH v2] drm/vkms: Fix race-condition between the hrtimer and the atomic commit

2023-06-21 Thread Arthur Grillo Queiroz Cabral
On 23/05/23 09:32, Maíra Canal wrote: > Currently, it is possible for the composer to be set as enabled and then > as disabled without a proper call for the vkms_vblank_simulate(). This > is problematic, because the driver would skip one CRC output, causing CRC > tests to fail. Therefore, we

Re: [PATCH 0/3] drm/vkms: Minor Improvements

2023-05-16 Thread Arthur Grillo Queiroz Cabral
On 15/05/23 10:52, Maíra Canal wrote: > This series addresses some minor improvements to the writeback > functionality. The first patch intends to reduce the critical section > of a spinlock by removing assignments that don't need to be protected > by a lock. The second patch enables the

Re: [PATCH v3 1/2] drm: Add fixed-point helper to get rounded integer values

2023-05-12 Thread Arthur Grillo Queiroz Cabral
On 12/05/23 07:40, Maíra Canal wrote: > Create a new fixed-point helper to allow us to return the rounded value > of our fixed point value. > > [v2]: > * Create the function drm_fixp2int_round() (Melissa Wen). > [v3]: > * Use drm_fixp2int() instead of shifting manually (Arthur Grillo).

Re: [PATCH v2 2/2] drm/vkms: Fix RGB565 pixel conversion

2023-05-11 Thread Arthur Grillo Queiroz Cabral
On 07/05/23 17:28, Maíra Canal wrote: > Currently, the pixel conversion isn't rounding the fixed-point values > before assigning it to the RGB coefficients, which is causing the IGT > pixel-format tests to fail. So, use the drm_fixp2int_round() fixed-point > helper to round the values when

Re: [PATCH v2 1/2] drm: Add fixed-point helper to get rounded integer values

2023-05-11 Thread Arthur Grillo Queiroz Cabral
On 07/05/23 17:28, Maíra Canal wrote: > Create a new fixed-point helper to allow us to return the rounded value > of our fixed-point value. > > Signed-off-by: Maíra Canal > --- > > v1 -> v2: > https://lore.kernel.org/dri-devel/20230425153353.238844-1-mca...@igalia.com/T/ > > * New patch >

Re: [PATCH v2 1/2] drm/vkms: allow full alpha blending on all planes

2023-04-21 Thread Arthur Grillo Queiroz Cabral
On 20/04/23 20:22, Maíra Canal wrote: > Before commit bc0d7fdefec6 ("drm: vkms: Supports to the case where > primary plane doesn't match the CRTC"), the composition was executed on > top of the primary plane. Therefore, the primary plane was not able to > support the alpha channel. After commit

Re: [PATCH v4 3/5] drm/tests: Add test cases for drm_rect_calc_vscale()

2023-04-17 Thread Arthur Grillo Queiroz Cabral
On 17/04/23 13:19, Maíra Canal wrote: > On 4/6/23 08:53, Arthur Grillo wrote: >> Insert parameterized test for the drm_rect_calc_vscale() to ensure >> correctness and prevent future regressions. Besides the test for the >> usual case, tests the exceptions. >> >> It uses the same struct from

Re: [PATCH v3 1/6] drm/vkms: isolate pixel conversion functionality

2023-04-17 Thread Arthur Grillo Queiroz Cabral
On 17/04/23 09:10, Maíra Canal wrote: > Currently, the pixel conversion functions repeat the same loop to > iterate the rows. Instead of repeating the same code for each pixel > format, create a function to wrap the loop and isolate the pixel > conversion functionality. > > Suggested-by:

Re: [PATCH v2 1/7] drm/vkms: isolate pixel conversion functionality

2023-04-14 Thread Arthur Grillo Queiroz Cabral
On 14/04/23 10:51, Maíra Canal wrote: > Currently, the pixel conversion functions repeat the same loop to > iterate the rows. Instead of repeating the same code for each pixel > format, create a function to wrap the loop and isolate the pixel > conversion functionality. > > Suggested-by:

Re: [PATCH v2 1/5] drm/tests: Test drm_rect_intersect()

2023-04-03 Thread Arthur Grillo Queiroz Cabral
On 03/04/23 12:33, Maíra Canal wrote: > Hi Arthur, > > On 3/27/23 10:38, Arthur Grillo wrote: >> Insert test for the drm_rect_intersect() function, it also create a >> helper for comparing drm_rects more easily. >> >> Signed-off-by: Arthur Grillo >> --- >>

Re: [PATCH 1/5] drm/tests: Test drm_rect_intersect()

2023-03-22 Thread Arthur Grillo Queiroz Cabral
On 22/03/23 11:26, Ville Syrjälä wrote: > On Wed, Mar 22, 2023 at 11:06:57AM -0300, Arthur Grillo wrote: >> Insert test for the drm_rect_intersect() function, it also create a >> helper for comparing drm_rects more easily. >> >> Signed-off-by: Arthur Grillo >> --- >>

Re: [PATCH v3 1/2] drm/format-helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-14 Thread Arthur Grillo Queiroz Cabral
Hello Javier, On 14/03/23 16:08, Javier Martinez Canillas wrote: > Arthur Grillo writes: > > Hello Arthur, > >> Extend the existing test cases to test the conversion from XRGB to >> monochromatic. >> >> Signed-off-by: Arthur Grillo >> --- > > Patch looks good to me: > > Reviewed-by:

Re: [PATCH v2] drm/format-helper: Make conversion_buf_size() support sub-byte pixel fmts

2023-03-09 Thread Arthur Grillo Queiroz Cabral
Hi, On 07/03/23 18:50, Javier Martinez Canillas wrote: > There are DRM fourcc formats that have pixels smaller than a byte, but the > conversion_buf_size() function assumes that pixels are a multiple of bytes > and use the struct drm_format_info .cpp field to calculate the dst_pitch. > >

Re: [PATCH] drm/format_helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-08 Thread Arthur Grillo Queiroz Cabral
On 02/03/23 17:01, Arthur Grillo wrote: > Extend the existing test cases to test the conversion from XRGB to > monochromatic. > > Signed-off-by: Arthur Grillo > --- > .../gpu/drm/tests/drm_format_helper_test.c| 73 +++ > 1 file changed, 73 insertions(+) > > diff

Re: [PATCH] drm/format_helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-08 Thread Arthur Grillo Queiroz Cabral
On 07/03/23 18:55, Javier Martinez Canillas wrote: > Javier Martinez Canillas writes: > > [...] > >> >>> +static size_t conversion_buf_size_mono(unsigned int dst_pitch, const >>> struct drm_rect *clip) >>> +{ >>> + if (!dst_pitch) { >>> + unsigned int linepixels =