[Nouveau] [PATCH] nouveau: nv46: Change mc subdev oclass from nv44 to nv4c

2015-07-24 Thread Ben Skeggs
On 24 July 2015 at 12:39, Ilia Mirkin wrote: > On Thu, Jul 23, 2015 at 10:32 PM, Ben Skeggs wrote: >> On 24 July 2015 at 01:20, Hans de Goede wrote: >>> MSI interrupts appear to not work for nv46 based cards. Change the mc >>> subdev oclass for these cards from nv4

[Nouveau] [PATCH] nouveau: nv46: Change mc subdev oclass from nv44 to nv4c

2015-07-24 Thread Ben Skeggs
On 24 July 2015 at 01:20, Hans de Goede wrote: > MSI interrupts appear to not work for nv46 based cards. Change the mc > subdev oclass for these cards from nv44 to nv4c, the nv4c mc code is > identical to the nv44 mc code except that it does not use msi > (it does not define a msi_rearm

[Nouveau] [PATCH v2 0/6] Improve GK20A support, introduce GM20B, firmware paths

2015-06-25 Thread Ben Skeggs
On 23 June 2015 at 16:16, Alexandre Courbot wrote: > Second version of this patchset. Not many changes since first version - I hope > this means the changes are not too controversial. > > Changes since v1: > - Removed lookup for previous FW files in "nouveau/" > - Went back to using

[PATCH 1/6] gr: support for NVIDIA-provided firmwares

2015-06-19 Thread Ben Skeggs
On 19 June 2015 at 15:22, Alexandre Courbot wrote: > On Fri, Jun 19, 2015 at 1:40 PM, Ben Skeggs wrote: >> On 19 June 2015 at 00:47, Alexandre Courbot wrote: >>> NVIDIA will officially start providing signed firmwares through >>> linux-firmware. Change the GR firmw

[PATCH 1/6] gr: support for NVIDIA-provided firmwares

2015-06-19 Thread Ben Skeggs
On 19 June 2015 at 00:47, Alexandre Courbot wrote: > NVIDIA will officially start providing signed firmwares through > linux-firmware. Change the GR firmware lookup function to look them up > in addition to the extracted firmwares. I wonder if perhaps we should just replace the mechanism

[Nouveau] [PATCH] drm/nouveau: Do not leak client objects

2015-06-07 Thread Ben Skeggs
On 5 June 2015 at 21:35, Thierry Reding wrote: > On Thu, Oct 16, 2014 at 11:54:54AM +0200, Thierry Reding wrote: >> From: Thierry Reding >> >> The memory allocated for a nouveau_cli object in nouveau_cli_create() is >> never freed. Free the memory in nouveau_cli_destroy() to plug this leak. >>

[Nouveau] [PATCH v2 8/9] acpi: Add support for Apple Gmux _DMS

2015-05-29 Thread Ben Skeggs
On 28 May 2015 at 16:40, Pierre Moreau wrote: > Changes since v1: > * Factorise testing of the 3 different _DSMs presence with a single function Not overly important, but this part could be split out into an earlier commit, keeping this commit just for adding the gmux support? > * Check for gmux

[Nouveau] [PATCH v2] nouveau: add coherent BO attribute

2015-05-21 Thread Ben Skeggs
ernel driver to make sure the object remains coherent > even on architectures for which coherency is not guaranteed by the bus. > > Signed-off-by: Alexandre Courbot Reviewed-by: Ben Skeggs > --- > Changes since v1: > None, just added Martin so he can merge the patch. R-b and A

[PATCH 1/2] drm/nouveau: add staging module option

2015-05-21 Thread Ben Skeggs
On 21 May 2015 at 16:04, Alexandre Courbot wrote: > On Thu, May 21, 2015 at 2:55 PM, Ben Skeggs wrote: >> On 21 May 2015 at 15:49, Alexandre Courbot wrote: >>> On Thu, May 21, 2015 at 1:48 PM, Ben Skeggs wrote: >>>> On 20 May 2015 at 15:56, Alexandre Courbot wr

[PATCH 1/2] drm/nouveau: add staging module option

2015-05-21 Thread Ben Skeggs
On 21 May 2015 at 15:49, Alexandre Courbot wrote: > On Thu, May 21, 2015 at 1:48 PM, Ben Skeggs wrote: >> On 20 May 2015 at 15:56, Alexandre Courbot wrote: >>> Add a module option allowing to enable staging/unstable APIs. This will >>> allow us to experiment fr

[PATCH 1/2] drm/nouveau: add staging module option

2015-05-21 Thread Ben Skeggs
On 20 May 2015 at 15:56, Alexandre Courbot wrote: > Add a module option allowing to enable staging/unstable APIs. This will > allow us to experiment freely with experimental APIs for a while before > setting them in stone. > > Signed-off-by: Alexandre Courbot > --- > drm/nouveau/nouveau_drm.c

[Nouveau] [PATCH] ram/gf100-: error out if a ridiculous amount of vram is detected

2015-05-21 Thread Ben Skeggs
On 21 May 2015 at 06:01, Ilia Mirkin wrote: > Some newer chips have trouble coming up, and we get bad MMIO reads from > them, like 0xbadf100. This ends up translating into crazy amounts of > VRAM, which destroys all sorts of other logic down the line. Instead, > fail device init. Hrm, I'm not

[patch] drm/nouveau: indent an if statement

2015-01-31 Thread Ben Skeggs
On Fri, Jan 30, 2015 at 6:27 PM, Dan Carpenter wrote: > This if statement is correct but it wasn't indented, so it looked like > some code was missing. Thanks Dan, applied (along with a fix for the owner thing you mentioned). Ben. > > Signed-off-by: Dan Carpenter > > diff --git

[PATCH] gpu: drm: nouveau: nvif: device: Remove unused function

2015-01-12 Thread Ben Skeggs
On Sun, Jan 11, 2015 at 11:53 PM, Rickard Strandqvist wrote: Hey Rickard, > Remove the function nvif_device_new() that is not used anywhere. It's used, just not by the kernel. All the code under core/ and nvif/ is also built into a userspace library (not in the kernel tree, obviously) and used

[PATCH 2/3] omap: Do not BUG_ON(!spin_is_locked()) on UP

2014-12-23 Thread Ben Skeggs
On 23 Dec 2014 00:27, "Bruno Prémont" wrote: > > On Mon, 22 Dec 2014 08:46:48 -0500 Rob Clark wrote: > > On Sun, Dec 21, 2014 at 11:43 AM, Bruno Prémont wrote: > > > On !SMP systems spinlocks do not exist. Thus checking of they > > > are active will always fail. > > > > > > Use > > >

[PATCH] gpu: drm: nouveau: core: subdev: clock: base.c: Remove unused function

2014-12-20 Thread Ben Skeggs
- Original Message - > From: "Rickard Strandqvist" > To: "David Airlie" , "Ben Skeggs" > Cc: "Rickard Strandqvist" , > "Alexandre Courbot" , "Ilia > Mirkin" , dri-devel at lists.freedesktop.org, > linux-ke

[Nouveau] [PATCH v3 2/2] fb/nvaa: Enable non-isometric poller on NVAA/NVAC

2014-12-11 Thread Ben Skeggs
> \ > + (struct nouveau_object **)o) > + > int nv50_fb_ctor(struct nouveau_object *, struct nouveau_object *, > struct nouveau_oclass *, void *, u32, > struct nouveau_object **); > diff --git a/

[PATCH 2/2] drm/edid: fix Baseline_ELD_Len field in drm_edid_to_eld()

2014-11-11 Thread Ben Skeggs
DWords). >> >> Do not include the header size in Baseline_ELD_Len field. Fix all known >> users of eld[2]. >> >> While at it, switch to DIV_ROUND_UP instead of open coding it. >> >> Signed-off-by: Jani Nikula Acked-by: Ben Skeggs >> >> --- &g

[PATCH 1/8] drm/: Don't call drm_mmap

2014-09-24 Thread Ben Skeggs
Alex Deucher > Cc: "Christian K?nig" > Cc: David Herrmann > Cc: Rashika > Cc: Josh Triplett > Cc: Daniel Vetter > Cc: Fabian Frederick > Cc: Gerd Hoffmann > Cc: Ben Skeggs > Cc: Alexandre Courbot > Cc: Maarten Lankhorst > Cc: Christian Eng

[Nouveau] [PATCH] drm/nv84+: fix fence context seqno's

2014-09-23 Thread Ben Skeggs
l that may wait on the about-to-be-deleted channel to signal. >> >> I'm nothing if not optimistic about any hope of recovery from that. ;-) >> >> Reported-by: Ted Percival >> Signed-off-by: Maarten Lankhorst Acked-by: Ben Skeggs I'm still seeing issues with suspend

[Nouveau] [PATCH] drm: Fix duplicate definition of NV04_PFB_BOOT_0_*

2014-08-19 Thread Ben Skeggs
define NV04_PFB_DEBUG_0_PAGE_MODE 0x0001 > # define NV04_PFB_DEBUG_0_REFRESH_OFF 0x0010 > diff --git a/nvkm/subdev/fb/ramnv04.c b/nvkm/subdev/fb/ramnv04.c > index e781080..1972268 100644 > --- a/nvkm/subdev/fb/ramnv04.c > +++ b

drm/nv50-/disp: audit and version DAC_LOAD method

2014-08-13 Thread Ben Skeggs
- Original Message - > From: "Dan Carpenter" > To: bskeggs at redhat.com > Cc: dri-devel at lists.freedesktop.org > Sent: Wednesday, 13 August, 2014 9:29:16 PM > Subject: re: drm/nv50-/disp: audit and version DAC_LOAD method > > Hello Ben Skeggs, > &

[Nouveau] [PATCH v5] drm/nouveau: map pages using DMA API

2014-08-05 Thread Ben Skeggs
On Mon, Aug 4, 2014 at 5:32 PM, Daniel Vetter wrote: > On Thu, Jul 31, 2014 at 06:09:42PM +0900, Alexandre Courbot wrote: >> The DMA API is the recommended way to map pages no matter what the >> underlying bus is. Use the DMA functions for page mapping and remove >> currently existing wrappers.

[PATCH v2] drm/ttm: expose CPU address of DMA-allocated pages

2014-08-05 Thread Ben Skeggs
On Mon, Aug 4, 2014 at 7:28 PM, Alexandre Courbot wrote: > Pages allocated using the DMA API have a coherent memory mapping. Make > this mapping visible to drivers so they can decide to use it instead of > creating their own redundant one. I've picked this up in nouveau's linux-3.17 staging

[Nouveau] [PATCH v4 2/6] drm/nouveau: map pages using DMA API on platform devices

2014-07-11 Thread Ben Skeggs
On Fri, Jul 11, 2014 at 12:35 PM, Alexandre Courbot wrote: > On 07/10/2014 09:58 PM, Daniel Vetter wrote: >> >> On Tue, Jul 08, 2014 at 05:25:57PM +0900, Alexandre Courbot wrote: >>> >>> page_to_phys() is not the correct way to obtain the DMA address of a >>> buffer on a non-PCI system. Use the

[PATCH 0/3] drm/gk20a: support for reclocking

2014-07-11 Thread Ben Skeggs
On Fri, Jul 11, 2014 at 11:49 AM, Alexandre Courbot wrote: > On 07/10/2014 06:43 PM, Peter De Schrijver wrote: >> >> On Thu, Jul 10, 2014 at 09:34:34AM +0200, Alexandre Courbot wrote: >>> >>> This series adds support for reclocking on GK20A. The first two patches >>> touch >>> the clock

[Nouveau] [PATCH 0/3] drm/gk20a: support for reclocking

2014-07-11 Thread Ben Skeggs
On Thu, Jul 10, 2014 at 5:34 PM, Alexandre Courbot wrote: > This series adds support for reclocking on GK20A. The first two patches touch > the clock subsystem to allow GK20A to operate, by making the presence of the > thermal and voltage devices optional, and allowing pstates to be provided >

[Nouveau] [PATCH] drm: default scaling to NONE for external connectors

2014-07-04 Thread Ben Skeggs
On Fri, Jul 4, 2014 at 5:27 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > Based on a recent discussion in #radeon, and also my own observation that the > 'full' scaling causes no end of confusion among users. > > See https://bugs.freedesktop.org/show_bug.cgi?id=80868 for some

[PATCH v2] drm/gk20a: add BAR instance

2014-06-29 Thread Ben Skeggs
On Sat, Jun 28, 2014 at 11:41 AM, Ken Adams wrote: > > On 6/27/14 8:56 PM, "Ben Skeggs" wrote: > >>On Sat, Jun 28, 2014 at 4:51 AM, Ken Adams wrote: >>> quick note re: tegra and gpu bars... >>> >>> to this point we've explicitly avoi

[PATCH v2] drm/gk20a: add BAR instance

2014-06-28 Thread Ben Skeggs
On Sat, Jun 28, 2014 at 4:51 AM, Ken Adams wrote: > quick note re: tegra and gpu bars... > > to this point we've explicitly avoided providing user-mode mappings due to > power management issues, etc. > looks to me like this would allow such mappings. is that the case? are > there any paths

unparseable, undocumented /sys/class/drm/.../pstate

2014-06-24 Thread Ben Skeggs
On Tue, Jun 24, 2014 at 6:26 AM, Greg KH wrote: > On Mon, Jun 23, 2014 at 04:18:39PM -0400, Ilia Mirkin wrote: >> On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek wrote: >> > Hi! >> > >> >> >> >> > I guess better interface would be something like >> >> >> >> > >> >> >> >> > pstate/07/core_clock_min

[PATCH] drm/nouveau: avoid memory leak

2014-06-18 Thread Ben Skeggs
- Original Message - > From: "Heinrich Schuchardt" > To: "David Airlie" > Cc: "Ben Skeggs" , dri-devel at lists.freedesktop.org, > linux-kernel at vger.kernel.org, "Heinrich > Schuchardt" > Sent: Thursday, 19 June, 2014 5:

[REGRESSION] drm/g94/i2c: add aux channel interrupt driver

2014-06-18 Thread Ben Skeggs
On Wed, Jun 18, 2014 at 12:38 AM, Maarten Lankhorst wrote: > Hey, > > This patch causes a regression on my display-less nvd7. > Commenting out the aux, aux_stat and aux_mask members in nvd0_i2c_oclass > fixes boot, and makes things work normally again. > Hey Maarten, Yeah that probably makes

[PATCH] drm/nouveau: fix oops in display destructor with headless cards

2014-06-18 Thread Ben Skeggs
On Tue, Jun 17, 2014 at 11:01 PM, Maarten Lankhorst wrote: > If init doesn't run then disp->outp might not be initialized, resulting in an > oops. This can't actually happen (in the very least, it's not supposed to)... What makes you think it can? > > Signed-off-by: Maarten Lankhorst > --- >

[Nouveau] [PATCH 1/2] drm/nouveau: Fix overlap while zeroing zcull regions

2014-06-13 Thread Ben Skeggs
On Fri, Jun 13, 2014 at 10:34 AM, Pierre Moreau wrote: > The specified stride was not correct, resulting in erases overlapping and part > of the zcull regions being not erased at all. Hey Pierre, Thanks, I've merged both patches. > > Signed-off-by: Pierre Moreau > --- >

[PATCH resend 1/4] nouveau: Don't check acpi_video_backlight_support() before registering backlight

2014-05-23 Thread Ben Skeggs
ult of video.use_native_backlight=1 will cause >> regressions. >> >> Note this effectively reverts commit 5bead799 >> >> Also see: https://bugzilla.redhat.com/show_bug.cgi?id=1093171 >> >> Signed-off-by: Hans de Goede > > It would be good to have an ACK from the

[Nouveau] [PATCH] clk: allow config option to enable reclocking

2014-05-17 Thread Ben Skeggs
On Sat, May 17, 2014 at 2:06 PM, Ilia Mirkin wrote: > On Fri, May 16, 2014 at 11:54 PM, Ben Skeggs wrote: >> On 17 May 2014 13:39, "Ilia Mirkin" wrote: >>> >>> On Fri, May 16, 2014 at 11:17 PM, Ben Skeggs wrote: >>> > On 17 May 2014 02:43, &qu

[Nouveau] [PATCH] clk: allow config option to enable reclocking

2014-05-17 Thread Ben Skeggs
On 17 May 2014 13:39, "Ilia Mirkin" wrote: > > On Fri, May 16, 2014 at 11:17 PM, Ben Skeggs wrote: > > On 17 May 2014 02:43, "Ilia Mirkin" wrote: > >> > >> Adds a NvReclock boolean option to allow the user to enable (or disable) > >>

[Nouveau] [PATCH] clk: allow config option to enable reclocking

2014-05-17 Thread Ben Skeggs
On 17 May 2014 02:43, "Ilia Mirkin" wrote: > > Adds a NvReclock boolean option to allow the user to enable (or disable) > reclocking. All chipsets default to off, except NVAA/NVAC, which are > reportedly complete. Hey Ilia, I think I've expressed my thoughts on this previously via IRC, but let

[Nouveau] [PATCH] drm/gk20a/fb: fix NULL dereference

2014-05-10 Thread Ben Skeggs
On Fri, May 9, 2014 at 5:57 PM, Alexandre Courbot wrote: > gk20a_ram_put() can be called with a NULL nouveau_mem in case of error. > Handle that case the way is it done in other RAM drivers. Got it, thanks! > > Signed-off-by: Alexandre Courbot > --- >

DPCD/AUX locking

2014-05-07 Thread Ben Skeggs
On Wed, May 7, 2014 at 9:20 AM, Dave Airlie wrote: > So now I've been playing with MST I think get the feeling I might need > some explicit locking on the AUX channel, I think at the moment the > mode_config mutex implicitly defends the aux channel as the only real > paths into it are > > a) from

[Nouveau] [PATCH v4 0/9] drm/nouveau: support for GK20A, cont'd

2014-05-06 Thread Ben Skeggs
On Fri, May 2, 2014 at 7:32 PM, Alexandre Courbot wrote: > Latest patches for GK20A, taking comments received for v3 into account. > > Changes since v3: > - use only pfn_to_page() and page_to_pfn() in GK20A's FB. These functions > are present on every arch and the physical address to page

[PATCH v3 0/9] drm/nouveau: support for GK20A, cont'd

2014-05-01 Thread Ben Skeggs
On Fri, Apr 25, 2014 at 5:19 PM, Alexandre Courbot wrote: > Changes since v2: > - Enabled software class > - Removed unneeded changes to nouveau_accel_init() > - Replaced use of architecture-private pfn_to_dma() and dma_to_pfn() with > the portable page_to_phys()/phys_to_page() page_to_phys()

[Nouveau] [PATCH v3 6/9] drm/nouveau/graph: enable when using external firmware

2014-05-01 Thread Ben Skeggs
On Thu, May 1, 2014 at 2:53 PM, Alexandre Courbot wrote: > On Mon, Apr 28, 2014 at 11:10 AM, Ben Skeggs wrote: >> On Fri, Apr 25, 2014 at 5:19 PM, Alexandre Courbot >> wrote: >>> nvc0_graph_ctor() would only let the graphics engine be enabled if its >>> ocl

[Nouveau] [PATCH v3 6/9] drm/nouveau/graph: enable when using external firmware

2014-04-29 Thread Ben Skeggs
On Mon, Apr 28, 2014 at 4:57 PM, Thierry Reding wrote: > On Mon, Apr 28, 2014 at 12:10:27PM +1000, Ben Skeggs wrote: >> On Fri, Apr 25, 2014 at 5:19 PM, Alexandre Courbot >> wrote: >> > nvc0_graph_ctor() would only let the graphics engine be enabled if its >> &

[Nouveau] [PATCH v3 6/9] drm/nouveau/graph: enable when using external firmware

2014-04-28 Thread Ben Skeggs
On Fri, Apr 25, 2014 at 5:19 PM, Alexandre Courbot wrote: > nvc0_graph_ctor() would only let the graphics engine be enabled if its > oclass has a proper microcode linked to it. This prevents GR from being > enabled at all on chips that rely exclusively on external firmware, even > though such a

[Nouveau] [PATCH v2 09/10] drm/nouveau: support GK20A in nouveau_accel_init()

2014-04-22 Thread Ben Skeggs
On Tue, Apr 22, 2014 at 4:07 AM, Ilia Mirkin wrote: > On Mon, Apr 21, 2014 at 2:02 AM, Alexandre Courbot > wrote: >> Skip the creation of a software channel for GK20A as software methods >> are not yet supported. > > How is GK20A different from a nvc0+ card that lacks PDISPLAY (like all > the

[PATCH v2 07/10] drm/nouveau/graph: pad firmware code at load time

2014-04-22 Thread Ben Skeggs
On Tue, Apr 22, 2014 at 4:03 AM, Ilia Mirkin wrote: > On Mon, Apr 21, 2014 at 2:02 AM, Alexandre Courbot > wrote: >> Pad the microcode to a multiple of 0x40 bytes, otherwise firmware will > > bytes or u32's? From the code, I'm guessing the latter. (Similar > concern about comment in the code.)

[PATCH] drm/nouveau/clk: fix possible NULL pointer dereference

2014-04-15 Thread Ben Skeggs
- Original Message - > From: "Daeseok Youn" > To: airlied at linux.ie > Cc: bskeggs at redhat.com, dri-devel at lists.freedesktop.org, linux-kernel > at vger.kernel.org > Sent: Tuesday, 15 April, 2014 11:56:49 AM > Subject: [PATCH] drm/nouveau/clk: fix possible NULL pointer dereference >

[PATCH 02/12] drm/nouveau/timer: skip calibration on GK20A

2014-04-14 Thread Ben Skeggs
On Fri, Apr 11, 2014 at 5:34 PM, Alexandre Courbot wrote: > On 04/11/2014 04:31 PM, Ben Skeggs wrote: >> >> On Fri, Apr 11, 2014 at 12:46 PM, Alexandre Courbot >> wrote: >>> >>> On Wed, Mar 26, 2014 at 1:19 PM, Ben Skeggs wrote: >>>> &

[PATCH] drm/nouveau/bios: fix bug introduced in 457e77b2

2014-04-11 Thread Ben Skeggs
t; Signed-off-by: Andreas Noever Signed-off-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/core/subdev/bios/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c > b/drivers/gpu/drm/nouveau/core/subdev/b

[PATCH 02/12] drm/nouveau/timer: skip calibration on GK20A

2014-04-11 Thread Ben Skeggs
On Fri, Apr 11, 2014 at 12:46 PM, Alexandre Courbot wrote: > On Wed, Mar 26, 2014 at 1:19 PM, Ben Skeggs wrote: >> On Tue, Mar 25, 2014 at 7:54 AM, Thierry Reding >> wrote: >>> On Mon, Mar 24, 2014 at 05:42:24PM +0900, Alexandre Courbot wrote: >>>>

[Nouveau] [PATCH 11/12] drm/nouveau: support GK20A in nouveau_accel_init()

2014-04-03 Thread Ben Skeggs
On Thu, Apr 3, 2014 at 12:23 AM, Ilia Mirkin wrote: > On Wed, Apr 2, 2014 at 10:14 AM, Alexandre Courbot > wrote: > + /* Need to figure out how to handle sw for gk20a */ > + if (device->chipset == 0xea) > + goto skip_sw_init; The commit message makes it

[PATCH 10/12] drm/nouveau/graph: add GK20A support

2014-04-03 Thread Ben Skeggs
On Thu, Apr 3, 2014 at 12:03 AM, Alexandre Courbot wrote: > On Wed, Mar 26, 2014 at 1:24 PM, Ben Skeggs wrote: >> On Mon, Mar 24, 2014 at 6:42 PM, Alexandre Courbot >> wrote: >>> Add a GR device for GK20A based on NVE4, with the correct classes >>> defini

[PATCH] acpi: allow non-optimus setups to load vbios from acpi

2014-03-27 Thread Ben Skeggs
On Thu, Mar 27, 2014 at 9:37 AM, Ilia Mirkin wrote: > There appear to be a crop of new hardware where the vbios is not > available from PROM/PRAMIN, but there is a valid _ROM method in ACPI. > The data read from PCIROM almost invariably contains invalid > instructions (still has the x86 opcodes),

[Nouveau] [PATCH] nouveau: safen up nouveau_device list usage against concurrent access

2014-03-26 Thread Ben Skeggs
On Thu, Mar 13, 2014 at 12:05 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin Already said on IRC, but for posterity: Reviewed-by: Ben Skeggs > --- > nouveau/nouveau.c | 29 - > nouveau/private.h | 3 ++- > 2 files changed, 30 insertions(

[Nouveau] [PATCH 12/12] drm/nouveau: support for probing GK20A

2014-03-26 Thread Ben Skeggs
On Mon, Mar 24, 2014 at 6:42 PM, Alexandre Courbot wrote: > Set the correct subdev/engine classes when GK20A (0xea) is probed. > > Signed-off-by: Alexandre Courbot > --- > drivers/gpu/drm/nouveau/core/engine/device/nve0.c | 20 > 1 file changed, 20 insertions(+) > > diff

[PATCH 11/12] drm/nouveau: support GK20A in nouveau_accel_init()

2014-03-26 Thread Ben Skeggs
On Tue, Mar 25, 2014 at 9:10 AM, Thierry Reding wrote: > On Mon, Mar 24, 2014 at 05:42:33PM +0900, Alexandre Courbot wrote: >> GK20A does not embed a dedicated COPY engine and thus cannot allocate >> the copy channel that nouveau_accel_init() attempts to create. It also >> lacks any display

[PATCH 10/12] drm/nouveau/graph: add GK20A support

2014-03-26 Thread Ben Skeggs
On Mon, Mar 24, 2014 at 6:42 PM, Alexandre Courbot wrote: > Add a GR device for GK20A based on NVE4, with the correct classes > definitions (GK20A's 3D class is 0xa297). > > Most of the NVE4 code can be used on GK20A, so make relevant bits of > NVE4 available to other chips as well. This will

[Nouveau] [PATCH 09/12] drm/nouveau/graph: pad firmware code at load time

2014-03-26 Thread Ben Skeggs
On Mon, Mar 24, 2014 at 6:42 PM, Alexandre Courbot wrote: > Pad the microcode to a multiple of 0x40, otherwise firmware will fail to > run from non-prepadded firmware files. > > Signed-off-by: Alexandre Courbot > --- > drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c | 4 > 1 file

[PATCH 08/12] drm/nouveau/graph: enable when using external firmware

2014-03-26 Thread Ben Skeggs
On Tue, Mar 25, 2014 at 8:58 AM, Thierry Reding wrote: > On Mon, Mar 24, 2014 at 05:42:30PM +0900, Alexandre Courbot wrote: > [...] >> diff --git a/drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c >> b/drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c >> index 6ef8bf181b2d..f997a18f5760 100644 >>

[Nouveau] [PATCH 03/12] drm/nouveau/bar: only ioremap BAR3 if it exists

2014-03-26 Thread Ben Skeggs
On Tue, Mar 25, 2014 at 8:13 AM, Thierry Reding wrote: > On Mon, Mar 24, 2014 at 05:42:25PM +0900, Alexandre Courbot wrote: >> Some chips that use system memory exclusively (e.g. GK20A) do not >> expose 2 BAR regions. For them only BAR1 exists, and it should be used >> for USERD mapping. Do not

[PATCH 02/12] drm/nouveau/timer: skip calibration on GK20A

2014-03-26 Thread Ben Skeggs
On Tue, Mar 25, 2014 at 7:54 AM, Thierry Reding wrote: > On Mon, Mar 24, 2014 at 05:42:24PM +0900, Alexandre Courbot wrote: >> GK20A's timer is directly attached to the system timer and cannot be >> calibrated. Skip the calibration phase on that chip since the >> corresponding registers do not

[Nouveau] [PATCH] drm/nouveau/fb: use correct ram oclass for nv1a hardware

2014-02-14 Thread Ben Skeggs
On Wed, Feb 12, 2014 at 11:41 AM, Emil Velikov wrote: > commit 8613e7314ac254fdd67ed46192f021d76141e4c9 > Author: Ben Skeggs > Date: Mon Oct 21 08:50:25 2013 +1000 > > drm/nouveau/fb: remove ram oclass argument from base fb constructor > > Introduced a unfortunate reg

[PATCH 1/2] drm/nouveau: replace ffsll with __ffs64

2014-02-10 Thread Ben Skeggs
On Mon, Feb 10, 2014 at 6:51 AM, Ilia Mirkin wrote: > The ffsll function is a lot slower than the __ffs64 built-in which > compiles to a single instruction on 64-bit. It's also nice to avoid > custom versions of standard functions. Note that __ffs == ffs - 1. > > Signed-off-by: Ilia Mirkin

[Nouveau] [PATCH] drm/nv50/gr: add missing nv_error parameter priv

2014-02-10 Thread Ben Skeggs
On Sun, Feb 9, 2014 at 1:35 PM, Ilia Mirkin wrote: > Commit ea7dce901 ("drm/nv50/gr: print mpc trap name when it's not an mp > trap") added an nv_error call that was missing the priv parameter. This > causes GPFs if the error is ever hit. > > Signed-off-by: Ilia Mirkin Merged, thanks :) > --- >

[PATCH] nouveau/drm/fifo: fix ENG_RUNLIST register address

2014-02-10 Thread Ben Skeggs
On Fri, Feb 7, 2014 at 11:22 PM, Alexandre Courbot wrote: > Address of the ENG_RUNLIST register should be 0x002284 + (engine * 8), > not 0x002284 + (engine * 4). > > Signed-off-by: Alexandre Courbot > --- > Stumbled upon this one and I'm quite certain the offset was not correct. > This is

[patch] drm/nouveau/hwmon: remove some redundant checks

2014-02-07 Thread Ben Skeggs
- Original Message - > From: "Dan Carpenter" > To: "David Airlie" > Cc: "Ben Skeggs" , "Martin Peres" labri.fr>, "Ilia Mirkin" , > "Dave Airlie" , dri-devel at lists.freedesktop.org, > kernel-janitors at v

[PATCH] drm/nouveau/hwmon: replace strict_strtol() with kstrtol()

2014-02-07 Thread Ben Skeggs
- Original Message - > From: "Jingoo Han" > To: "Ben Skeggs" > Cc: dri-devel at lists.freedesktop.org, "David Airlie" , > "Jingoo Han" > Sent: Wednesday, 5 February, 2014 12:02:59 PM > Subject: [PATCH] drm/nouveau/hw

[RFC 10/16] drm/nouveau/timer: skip calibration on GK20A

2014-02-04 Thread Ben Skeggs
On Sat, Feb 1, 2014 at 1:16 PM, Alexandre Courbot wrote: > GK20A's timer is directly attached to the system timer and cannot be > calibrated. Skip the calibration phase on that chip since the > corresponding registers do not exist. Just a curiosity: What timer resolution does the HW initialise

[RFC 07/16] drm/nouveau/bar/nvc0: support chips without BAR3

2014-02-04 Thread Ben Skeggs
On Sat, Feb 1, 2014 at 1:16 PM, Alexandre Courbot wrote: > Adapt the NVC0 BAR driver to make it able to support chips that do not > expose a BAR3. When this happens, BAR1 is then used for USERD mapping > and the BAR alloc() functions is disabled, making GPU objects unable > to rely on BAR for

[RFC 00/16] drm/nouveau: initial support for GK20A (Tegra K1)

2014-02-04 Thread Ben Skeggs
On Sat, Feb 1, 2014 at 1:16 PM, Alexandre Courbot wrote: > Hello everyone, Hey Alex, The series looks pretty good to me. I'll reply to the relevant patches with any minor nit-picks on top of what's already been said by others. Thank you, and welcome to Nouveau :) Ben. > > GK20A is the

[RFC 00/16] drm/nouveau: initial support for GK20A (Tegra K1)

2014-02-03 Thread Ben Skeggs
On Mon, Feb 3, 2014 at 1:14 PM, Ilia Mirkin wrote: > On Sun, Feb 2, 2014 at 9:44 PM, Alexandre Courbot > wrote: >> One beginner question: is it appropriate to send kernel patches to the >> nouveau list in addition to dri-devel? The moderation messages I receive >> make me think that this list

[Nouveau] [Fwd: [PATCH] Fix null dereference oopses for nv40 cards] kernel 3.13.0-rc8

2014-01-14 Thread Ben Skeggs
On Tue, Jan 14, 2014 at 3:07 PM, Ben Skeggs wrote: > On Tue, Jan 14, 2014 at 1:22 PM, Bob Gleitsmann > wrote: >> I should have mentioned that this applies to Linus' 3.13.0-rc7 and rc8 >> git. Maybe it's obvious. > Hey Bob, > > Thanks for reporting this. Can you try

[Nouveau] [Fwd: [PATCH] Fix null dereference oopses for nv40 cards] kernel 3.13.0-rc8

2014-01-14 Thread Ben Skeggs
On Tue, Jan 14, 2014 at 1:22 PM, Bob Gleitsmann wrote: > I should have mentioned that this applies to Linus' 3.13.0-rc7 and rc8 > git. Maybe it's obvious. Hey Bob, Thanks for reporting this. Can you try the attached patch instead and report if it helps you? Ben. > > Sorry about that. > > Bob

[PATCH] drm/nouveau/bios: fix offset calculation for BMPv1 bioses

2014-01-07 Thread Ben Skeggs
- Original Message - > From: "Ilia Mirkin" > To: "Ben Skeggs" > Cc: dri-devel at lists.freedesktop.org, "Ilia Mirkin" alum.mit.edu> > Sent: Wednesday, 8 January, 2014 3:33:59 AM > Subject: [PATCH] drm/nouveau/bios: fix offset calculati

Fixing nouveau for >4k PAGE_SIZE

2013-12-11 Thread Ben Skeggs
On Fri, Nov 29, 2013 at 4:01 PM, Benjamin Herrenschmidt wrote: > On Thu, 2013-08-29 at 16:49 +1000, Ben Skeggs wrote: > >> > Additionally the current code is broken in that the upper layer in >> > vm/base.c doesn't increment "pte" by the right amount. >>

drm/nvd0/disp: initial crtc object implementation

2013-11-26 Thread Ben Skeggs
- Original Message - > From: "Dan Carpenter" > To: bskeggs at redhat.com > Cc: dri-devel at lists.freedesktop.org > Sent: Wednesday, 27 November, 2013 7:30:27 AM > Subject: re: drm/nvd0/disp: initial crtc object implementation > > Hello Ben Skeggs, > &

drm/nouveau/pwr: initial implementation

2013-11-12 Thread Ben Skeggs
- Original Message - > From: "Dan Carpenter" > To: bskeggs at redhat.com > Cc: dri-devel at lists.freedesktop.org > Sent: Tuesday, 12 November, 2013 7:54:33 PM > Subject: re: drm/nouveau/pwr: initial implementation > > Hello Ben Skeggs, Hey, > > The

Re: [PATCH] drm: nouveau: fix nvbe leakage

2013-10-07 Thread Ben Skeggs
- Original Message - From: Geyslan G. Bem geys...@gmail.com To: airl...@linux.ie, bske...@redhat.com, dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org, kernel...@googlegroups.com, Geyslan G. Bem geys...@gmail.com Sent: Tuesday, 8 October, 2013 8:14:26 AM Subject:

Re: [PATCH] drm: nouveau: fix nvbe leakage

2013-10-07 Thread Ben Skeggs
- Original Message - From: Geyslan Gregório Bem geys...@gmail.com To: Felipe Pena felipe...@gmail.com Cc: Ben Skeggs bske...@redhat.com, airl...@linux.ie, dri-devel@lists.freedesktop.org, linux-ker...@vger.kernel.org, kernel-br kernel...@googlegroups.com Sent: Tuesday, 8 October

Re: [patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()

2013-09-27 Thread Ben Skeggs
On Sat, Sep 28, 2013 at 6:17 AM, Dan Carpenter dan.carpen...@oracle.com wrote: The test here should be = ARRAY_SIZE() instead of ARRAY_SIZE(). Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Maarten Lankhorst maarten.lankho...@canonical.com --- Somehow this wasn't applied

Re: [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-09-25 Thread Ben Skeggs
On Thu, Sep 26, 2013 at 12:41 AM, Pasi Kärkkäinen pa...@iki.fi wrote: Hello, On Wed, Sep 04, 2013 at 08:59:13AM +0200, Maarten Lankhorst wrote: Op 04-09-13 05:41, Ben Skeggs schreef: On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 22-08-13 02

Re: [PATCH 6/7] drm/nouveau: embed gem object in nouveau_bo

2013-09-23 Thread Ben Skeggs
to avoid gem-internal dependencies. Note that the implementation follows the previous style. However, we no longer can check for bo-gem != NULL to test for a valid gem object. This wasn't done before, so we should be safe now. Cc: Ben Skeggs skeg...@gmail.com Cc: Maarten Lankhorst maarten.lankho

Re: [PATCH 11/20] drm: Remove clock_index from struct drm_display_mode

2013-09-19 Thread Ben Skeggs
On Fri, Sep 20, 2013 at 2:40 AM, Damien Lespiau damien.lesp...@intel.com wrote: This field was only accessed by the nouveau driver, but never set. So concluded we can rid of this one. Cc: Ben Skeggs bske...@redhat.com Signed-off-by: Damien Lespiau damien.lesp...@intel.com Acked-by: Ben Skeggs

[PATCH] drm/ttm: fix the tt_populated check in ttm_tt_destroy()

2013-09-17 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com After a vmalloc failure in ttm_dma_tt_alloc_page_directory(), ttm_dma_tt_init() will call ttm_tt_destroy() to cleanup, and end up inside the driver's unpopulate() hook when populate() has never yet been called. On nouveau, the first issue to be hit because

Re: [PATCH] drm/nouveau: do not move buffers when not needed

2013-09-10 Thread Ben Skeggs
On Wed, Sep 4, 2013 at 11:25 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 04-09-13 03:24, Ben Skeggs schreef: On Mon, Jul 15, 2013 at 6:39 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 15-07-13 08:05, Ben Skeggs schreef: On Fri, Jul 12, 2013 at 10:45 PM

Re: [PATCH] drm/nouveau: force alignment to 0x1000 for gpu objects

2013-09-09 Thread Ben Skeggs
On Wed, Sep 4, 2013 at 9:59 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 04-09-13 05:34, Ben Skeggs schreef: On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: There are a lot of places that allocate multiples of 1000, but do not set

Re: [PATCH 2/2] modetest: allow setting a scaling factor when showing plane

2013-09-09 Thread Ben Skeggs
On Tue, Sep 10, 2013 at 12:08 PM, Rob Clark robdcl...@gmail.com wrote: On Sat, Sep 7, 2013 at 9:36 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Reviewed-by: Rob Clark robdcl...@gmail.com Reviewed-and-tested-by: Ben Skeggs bske...@redhat.com

Re: [PATCH] nouveau: fix reclocking on nv40

2013-09-08 Thread Ben Skeggs
On Sun, Sep 8, 2013 at 9:25 PM, Pali Rohár pali.ro...@gmail.com wrote: On Wednesday 21 August 2013 02:24:01 Ben Skeggs wrote: On Mon, Aug 19, 2013 at 4:59 PM, Pali Rohár pali.ro...@gmail.com wrote: On Friday 16 August 2013 14:57:07 Pali Rohár wrote: In commit

Re: [PATCH] drm/nv10/plane: add plane support for nv10-nv40

2013-09-08 Thread Ben Skeggs
On Sun, Sep 8, 2013 at 10:33 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This has received light testing on NV18 and NV34 cards, using the modetest tool. Userspace support to use this for xv is not yet ready. I decided against creating a

Re: [PATCH] drm/nv84-: write fence value on exit, and restore value on init.

2013-09-08 Thread Ben Skeggs
On Wed, Sep 4, 2013 at 10:37 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 04-09-13 05:21, Ben Skeggs schreef: On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: This increases the chance slightly that recovery from lockup can happen

Re: [PATCH] drm/nouveau/i2c: pass the function pointers in at creation time

2013-09-03 Thread Ben Skeggs
On Sat, Aug 24, 2013 at 3:03 AM, Ilia Mirkin imir...@alum.mit.edu wrote: i2c_bit_add_bus can call the pre_xfer function, which expects the func pointer to be set. Pass in func to the port creation logic so that it is set before i2c_bit_add_bus. Merged, thanks! Ben. See

Re: [PATCH] drm/nouveau: do not move buffers when not needed

2013-09-03 Thread Ben Skeggs
On Mon, Jul 15, 2013 at 6:39 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 15-07-13 08:05, Ben Skeggs schreef: On Fri, Jul 12, 2013 at 10:45 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I have no idea what this bogus restriction on placement is, but it breaks

Re: [PATCH 6/6] drm/nouveau: use MSI interrupts

2013-09-03 Thread Ben Skeggs
On Fri, Aug 30, 2013 at 5:11 PM, Lucas Stach d...@lynxeye.de wrote: Am Freitag, den 30.08.2013, 15:36 +1000 schrieb Ben Skeggs: On Fri, Aug 30, 2013 at 12:01 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Aug 29, 2013 at 9:58 PM, Ben Skeggs skeg...@gmail.com wrote: On Fri, Aug 30, 2013

Re: [PATCH] drm/nv84-: write fence value on exit, and restore value on init.

2013-09-03 Thread Ben Skeggs
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: This increases the chance slightly that recovery from lockup can happen succesfully. I'd *really* love to see proof of this. When channels die, all outstanding fences are marked as signalled. This should

Re: [PATCH] drm/nv50-: make dma-objects read-only where appropriate

2013-09-03 Thread Ben Skeggs
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I don't see why the display engine would need write access to the entirety of vram, when read-only access is enough. Meh, this really doesn't matter... We're doing the same setup as nvidia do here, and I

Re: [PATCH] drm/nouveau: fix command submission to use vmalloc for big allocations

2013-09-03 Thread Ben Skeggs
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I was getting a order 4 allocation failure from kmalloc when testing some game after a few days uptime with some suspend/resumes. For big allocations vmalloc should be used instead. I've picked up this

Re: [PATCH] drm/nouveau: force alignment to 0x1000 for gpu objects

2013-09-03 Thread Ben Skeggs
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: There are a lot of places that allocate multiples of 1000, but do not set alignment correctly and still require this alignment implicitly or explicitly. This is wrong. Where are the places you think you

Re: [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-09-03 Thread Ben Skeggs
On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 22-08-13 02:10, Ilia Mirkin schreef: The code expects non-VRAM mem nodes to have a pages list. If that's not set, it will do a null deref down the line. Warn on that condition and return an error.

<    1   2   3   4   5   6   7   >