Re: [PATCH v6 7/7] drm/vkms Add hotplug support via configfs to VKMS.

2023-09-20 Thread Brandon Ross Pollack
Sorry, these tests are actually running in the chromeOS infrastructure environment! A similar test can be written in IGT (and I think is in the other chain that Marius published) On Thu, Sep 21, 2023 at 3:03 AM Helen Koike wrote: > > Hello! > > Thanks for the patch. > > On 29/08/2023 02:30,

Re: [PATCH v5 4/7] drm/vkms: Add ConfigFS scaffolding to VKMS

2023-08-28 Thread Brandon Ross Pollack
silly mistake, I should have been more cautious. Thank you for pickup up my slack On Mon, Aug 28, 2023 at 11:10 PM Marius Vlad wrote: > > Hi Brandon, > > See some minor missing rmdirs for connector_other and encoder_other. > > On Mon, Aug 28, 2023 at 08:17:06AM +, Brandon Pollack wrote: > >

Re: [PATCH v2 6/6] drm/vkms: Add a module param to enable/disable the default device

2023-08-18 Thread Brandon Ross Pollack
On 6/26/23 03:04, Maira Canal wrote: Hi Jim, On 6/23/23 19:23, Jim Shargo wrote: In many testing circumstances, we will want to just create a new device and test against that. If we create a default device, it can be annoying to have to manually select the new device instead of choosing the

Re: [PATCH v2 2/6] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-08-18 Thread Brandon Ross Pollack
Silly addition but I need to apologize for mispelling somone's name in my reply. Maira, please accept my sincere apology. On 8/18/23 12:36, Brandon Pollack wrote: Thanks for taking the time, everyone! Sorry it took so long, we had some internal shuffling etc going on and I was building out

Re: [PATCH v2 5/6] drm/vkms: Support enabling ConfigFS devices

2023-08-17 Thread Brandon Ross Pollack
On 8/15/23 23:01, Marius Vlad wrote: Hi, See below some minor comments: On Fri, Jun 23, 2023 at 06:23:47PM -0400, Jim Shargo wrote: VKMS now supports creating and using virtual devices! In addition to the enabling logic, this commit also prevents users from adding new objects once a card

Re: [PATCH v2 0/6] Adds support for ConfigFS to VKMS!

2023-08-07 Thread Brandon Ross Pollack
Some of these comments have been sitting for a while.  Would it be ok if yi...@chromium.org and myself picked these up and did an iteration so we could also get https://patchwork.kernel.org/project/dri-devel/patch/20230711013148.3155572-1-br...@chromium.org/ submitted?  These will enable a lot

Re: [PATCH] Documentation: vkms: clarify devres managed refernce cleanup

2023-05-07 Thread Brandon Ross Pollack
Seems it might be best just to have you do this, Daniel. Thanks for the review :) On Fri, Apr 28, 2023 at 11:53 AM Brandon Ross Pollack wrote: > On Thu, Apr 27, 2023 at 7:02 PM Daniel Vetter wrote: > > > > On Tue, Apr 25, 2023 at 08:02:40AM +, Brandon Pollack wro

Re: [PATCH v3 0/3] drm/vkms: Add support for multiple pipes

2023-05-07 Thread Brandon Ross Pollack
ack-and-forth design iterations). With those three, > the param you're adding should be easy to put on top. I can try to get > those out sooner for review. > > What do you think? > > > On Thu, Apr 27, 2023 at 10:51 PM Brandon Ross Pollack > wrote: > > > > I'm a

Re: [PATCH] Documentation: vkms: clarify devres managed refernce cleanup

2023-04-27 Thread Brandon Ross Pollack
On Thu, Apr 27, 2023 at 7:02 PM Daniel Vetter wrote: > > On Tue, Apr 25, 2023 at 08:02:40AM +, Brandon Pollack wrote: > > added documentation to drm_dev_unregister clarifying that devres managed > > devices allocated with devm_drm_dev_alloc do not require calls to > > drm_dev_put. > > > >

Re: [PATCH v3 0/3] drm/vkms: Add support for multiple pipes

2023-04-27 Thread Brandon Ross Pollack
ghts on the matter on how should we go about it? > > On 4/26/23 05:06, Brandon Ross Pollack wrote: > > We're doing/planning on doing similar or related work here at chromium. > > > > https://patchwork.kernel.org/project/dri-devel/list/?series=662676=both >

Re: [PATCH v3 0/3] drm/vkms: Add support for multiple pipes

2023-04-25 Thread Brandon Ross Pollack
We're doing/planning on doing similar or related work here at chromium. https://patchwork.kernel.org/project/dri-devel/list/?series=662676=both Here's the stuff we have now (we're currently rebasing and touching it up, myself and @Yi Xie will be taking over this work. Our plans are to add