assignment for CMD DSI panels.
Fixes: d13f638c9b88 ("drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set")
Signed-off-by: Dmitry Baryshkov
Hi Dmitry,
This fixes the regular DRM irq errors for me!
Tested-by: Caleb Connolly # sm8250 OnePlus 8
---
drivers/gpu/drm/msm/disp/dpu1/dpu_e
On 03/05/2024 22:59, Dmitry Baryshkov wrote:
On Fri, May 03, 2024 at 11:18:52AM +0200, Luca Weiss wrote:
On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote:
On Sat, 30 Mar 2024 at 18:49, Marijn Suijten
wrote:
On 2024-03-30 05:52:29, Dmitry Baryshkov wrote:
In case of CMD DSI
On 04/03/2024 21:41, Caleb Connolly wrote:
>
>
> On 09/02/2024 00:16, Richard Acayan wrote:
>> The S6E3FA7 display controller is enabled in every Pixel 3a (non-XL)
>> variant. Add the driver for it, generated by
>> linux-mdss-dsi-panel-driver-generator.
>>
&g
"Failed to get reset-gpios\n");
> +
> + ctx->dsi = dsi;
> + mipi_dsi_set_drvdata(dsi, ctx);
> +
> + dsi->lanes = 4;
> + dsi->format = MIPI_DSI_FMT_RGB888;
> + dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST |
This flag is
On 10/10/2023 23:53, Piotr Masłowski wrote:
> On Tue Oct 10, 2023 at 10:36 PM CEST, Caleb Connolly wrote:
>
>>> So why am I writing all of this? Well, the problem I see is that any
>>> shape-based approach will likely suffer from both accuracy and
>>> com
On 10/10/2023 21:01, Piotr Masłowski wrote:
> Hi Caleb,
>
> Thanks for posting this. I've been meaning to chime in on the discussion
> about notches and co. for months now, so this makes a perfect opportunity
> to finally do so.
>
> On Mon Oct 9, 2023 at 7:32 PM CEST,
On 10/10/2023 17:52, Rob Herring wrote:
> On Mon, Oct 09, 2023 at 06:32:50PM +0100, Caleb Connolly wrote:
>> Some display panels found in modern phones and laptops feature
>> non-standard display shapes with features like rounded corners, notches
>> (sections of the dis
y affects how usable this edge of the screen is).
[1]:
https://lore.kernel.org/dri-devel/f8747f99-0695-5be0-841f-4f72ba5d5...@connolly.tech/
[2]: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/87
[3]: https://gitlab.gnome.org/World/Phosh/gmobile
Signed-off-by: Caleb Connolly
---
Some f
On 13/07/2023 17:52, Amit Pundir wrote:
> Adding a reserved memory region for the framebuffer memory
> (the splash memory region set up by the bootloader).
>
> Signed-off-by: Amit Pundir
Reviewed-by: Caleb Connolly
> ---
> v5: Re-sending with updated dt-bindings pa
The commit 007ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE")
breaks panels which send DSI commands in their .unprepare callbacks.
Migrate to using .disable for that for some SDM845 panels.
Co-developed-by: Joel Selvaraj
Signed-off-by: Joel Selvaraj
Signed-off-by: Caleb Connolly
MODE_HELPERS. In addition it
> uses devm_gpiod_get() and related functions from GPIOLIB.
>
> Fixes: 5933baa36e26 ("drm/panel/samsung-sofef00: Add panel for OnePlus 6/T
> devices")
> Signed-off-by: Marijn Suijten
Reviewed-by: Caleb Connolly
> ---
> drivers/gpu/dr
t brightness instead of doing special processing
> of the brightness values.
>
> Signed-off-by: Richard Acayan
Awesome! Thanks for this series, glad to know this isn't a weird panel
quirk aha.
This works fine on the OnePlus 6 (the user of this panel), so for both
patches:
Test
Hi,
This patch has caused a regression on 6.1-rc for some devices that use
DSI panels. The new behaviour results in the DSI controller being
switched off before the panel unprepare hook is called. As a result,
panel drivers which call mipi_dsi_dcs_write() or similar in
unprepare() fail.
On 17/10/2022 09:59, Marijn Suijten wrote:
> On 2022-10-13 09:02:44, Abhinav Kumar wrote:
>> On 10/13/2022 2:36 AM, Marijn Suijten wrote:
>>> On 2022-10-12 16:03:06, Abhinav Kumar wrote:
[..]
But I would like to hold back this change till Vinod clarifies because
Vinod had
On 24/09/2022 21:36, Nia Espera wrote:
> Removes functionality from sofef00 panel driver which allowed it to
> drive the s6e3fc2x01 panel
>
> Signed-off-by: Nia Espera
Reviewed-by: Caleb Connolly
> ---
> drivers/gpu/drm/panel/Kconfig | 6 +++---
>
oper support for this panel in it's
own driver rather than the somewhat hacky solution I submitted originally.
There is just one note below, but otherwise:
Reviewed-by: Caleb Connolly
> ---
> MAINTAINERS | 5 +
> drivers/gpu/drm/panel/Kconfig |
GPI DMA on the PocoPhone F1 and Pixel 3!
>
> Signed-off-by: Robin Reckmann Reviewed-by: Caleb
> Connolly
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c
> b/drivers/i
On 18/07/2022 23:13, Dmitry Baryshkov wrote:
> On 19/07/2022 00:30, Caleb Connolly wrote:
>> From: Amit Pundir
>>
>> This adds an initial dts for the Blueline (Pixel 3). Supported
>> functionality includes display, Debug UART, UFS, USB-C (peripheral), W
From: Sumit Semwal
LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel.
Signed-off-by: Vinod Koul
Signed-off-by: Sumit Semwal
[caleb: convert to yaml]
Signed-off-by: Caleb Connolly
---
.../bindings/display/panel/lg,43408.yaml | 41 +++
.../display/panel/panel-simple-dsi.yaml
. The
disable/unprepare functions only put the panel to sleep mode and
disable the backlight.
Signed-off-by: Sumit Semwal
[vinod: Add DSC support]
Signed-off-by: Vinod Koul
[caleb: cleanup and support turning off the panel]
Signed-off-by: Caleb Connolly
---
MAINTAINERS
Document the bindings for the Pixel 3
Based on
https://lore.kernel.org/all/20220521164550.91115-7-krzysztof.kozlow...@linaro.org/
Signed-off-by: Caleb Connolly
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree
to fail
The touchscreen uses some HEFTY downstream driver, hopefully
we'll come up with an upstreamable solution for it soon and
make this a bit more usable.
Amit Pundir (1):
arm64: dts: qcom: add sdm845-google-blueline (Pixel 3)
Caleb Connolly (1):
Documentation: dt-bindings: arm: qcom: add
emory for modem/wifi]
Signed-off-by: Caleb Connolly
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/sdm845-google-blueline.dts | 652 ++
2 files changed, 653 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts
diff --g
to fail
The touchscreen uses some HEFTY downstream driver, hopefully
we'll come up with an upstreamable solution for it soon and
make this a bit more usable.
Amit Pundir (1):
arm64: dts: qcom: add sdm845-google-blueline (Pixel 3)
Caleb Connolly (1):
Documentation: dt-bindings: arm: qcom: add
Document the bindings for the Pixel 3
Based on
https://lore.kernel.org/all/20220521164550.91115-7-krzysztof.kozlow...@linaro.org/
Signed-off-by: Caleb Connolly
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree
From: Alexander Martinz
Add initial support for the SHIFT SHIFT6mq (axolotl) based on
the sdm845-mtp DT.
Currently supported features:
* Buttons (power, volume)
* Bluetooth, DSPs and modem
* Display and GPU
* Touch
* UART
* USB peripheral mode
* WLAN
Co-developed-by: Caleb Connolly
Signed-off
Add SHIFT vendor prefix, SHIFT make various devices such as the SHIF6mq
phone.
Signed-off-by: Caleb Connolly
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation
Add support for another variant of the rm69299 panel. This panel is
1080x2160 and is found in the shift-axolotl (SHIFT6mq).
Signed-off-by: Caleb Connolly
---
.../gpu/drm/panel/panel-visionox-rm69299.c| 281 ++
1 file changed, 221 insertions(+), 60 deletions(-)
diff --git
Document a new compatible string for the second panel variant.
Signed-off-by: Caleb Connolly
---
.../devicetree/bindings/display/panel/visionox,rm69299.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/Documentation/devicetree/bindings/display/panel/visionox,rm69299
-by: Caleb Connolly
---
drivers/input/touchscreen/Kconfig | 9 +
drivers/input/touchscreen/Makefile| 1 +
drivers/input/touchscreen/focaltech_fts.c | 870 ++
3 files changed, 880 insertions(+)
create mode 100644 drivers/input/touchscreen/focaltech_fts.c
diff
Add devicetree bindings for the Focaltech FTS touchscreen drivers.
Signed-off-by: Caleb Connolly
---
.../input/touchscreen/focaltech,fts.yaml | 78 +++
1 file changed, 78 insertions(+)
create mode 100644
Documentation/devicetree/bindings/input/touchscreen/focaltech
:
* Display / GPU / touch
* WIFI
* Modem (sms and mobile data are supported with ModemManager)
- Caleb
Alexander Martinz (1):
arm64: dts: qcom: sdm845: add device tree for SHIFT6mq
Caleb Connolly (5):
dt-bindings: input: touchscreen: add bindings for focaltech,fts
input: touchscreen: add
on a630,
but that can wait for 5.16.
Tested-by: Caleb Connolly
thanks
-john
--
Kind Regards,
Caleb (they/them)
On 28/09/2021 00:04, Rob Clark wrote:
From: Rob Clark
Add a short delay before clamping to idle frequency on active->idle
transition. It takes ~0.5ms to increase the freq again on the next
idle->active transition, so this helps avoid extra freq transitions
on workloads that bounce between
Hi,
On 30/09/2021 20:49, Amit Pundir wrote:
On Thu, 30 Sept 2021 at 04:50, Rob Clark wrote:
On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote:
On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote:
On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote:
On Fri, Sep 10, 2021 at 3:12 AM Maxime
On 10/09/2021 18:18, Rob Clark wrote:
On Tue, Sep 7, 2021 at 7:20 PM Bjorn Andersson
wrote:
On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote:
On 8/9/2021 9:48 PM, Caleb Connolly wrote:
On 09/08/2021 17:12, Rob Clark wrote:
On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen
wrote
On 08/09/2021 03:21, Bjorn Andersson wrote:
On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote:
On 8/9/2021 9:48 PM, Caleb Connolly wrote:
On 09/08/2021 17:12, Rob Clark wrote:
On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen
wrote:
[..]
I am a bit confused. We don't define a power
On 09/08/2021 18:58, Rob Clark wrote:
On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen wrote:
On 8/9/2021 9:48 PM, Caleb Connolly wrote:
On 09/08/2021 17:12, Rob Clark wrote:
On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen
wrote:
On 8/8/2021 10:22 PM, Rob Clark wrote:
On Sun, Aug 8
On 09/08/2021 17:12, Rob Clark wrote:
On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote:
On 8/8/2021 10:22 PM, Rob Clark wrote:
On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote:
On 07/08/2021 21:04, Rob Clark wrote:
On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly
wrote:
Hi
On 07/08/2021 21:04, Rob Clark wrote:
On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly
wrote:
Hi Rob, Akhil,
On 29/07/2021 21:53, Rob Clark wrote:
On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly
wrote:
On 29/07/2021 21:24, Rob Clark wrote:
On Thu, Jul 29, 2021 at 1:06 PM Caleb
Hi Rob, Akhil,
On 29/07/2021 21:53, Rob Clark wrote:
On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly
wrote:
On 29/07/2021 21:24, Rob Clark wrote:
On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly
wrote:
Hi Rob,
I've done some more testing! It looks like before that patch ("dr
On 29/07/2021 21:24, Rob Clark wrote:
On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly
wrote:
Hi Rob,
I've done some more testing! It looks like before that patch ("drm/msm: Devfreq
tuning") the GPU would never get above
the second frequency in the OPP table (342MHz)
o previous
devfreq behavior on a630 until the issue is understood.
Reported-by: Caleb Connolly
Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +++
drivers/gpu/drm/msm/msm_gpu.h | 2 ++
drivers/gpu/drm/m
Hi Rob,
This series causes a fatal crash on my Oneplus 6, the device goes to
Qualcomm crashdump mode shortly after reaching UI with the following errors:
https://paste.ubuntu.com/p/HvjmzZYtgw/
I did a git bisect and the patch ("drm/msm: Devfreq tuning") seems to be
the cause of the crash,
the same problem...
BR,
-R
On Wed, Jul 28, 2021 at 5:35 PM Caleb Connolly
wrote:
Hi Rob,
This series causes a fatal crash on my Oneplus 6, the device goes to
Qualcomm crashdump mode shortly after reaching UI with the following errors:
https://paste.ubuntu.com/p/HvjmzZYtgw/
I did a g
Hi Bjorn,
On 20/07/2021 17:03, Bjorn Andersson wrote:
> On Tue 20 Jul 10:33 CDT 2021, Caleb Connolly wrote:
>
>> The OnePlus 6T panel fails to initialise if it has been reset,
>> workaround this by allowing panels to not specify a reset GPIO.
>>
>>
Add the correct patch to the ipa firmware now that custom paths are
supported.
Signed-off-by: Caleb Connolly
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
b/arch/arm64/boot/dts
-off-by: Caleb Connolly
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index eb6b1d15293d..e81f5cc9f26d 100644
t GPIO handling")
https://lore.kernel.org/linux-arm-msm/20210502014146.85642-3-ca...@connolly.tech/
Caleb Connolly (5):
arm64: dts: qcom: sdm845-oneplus: fix reserved-mem
dts: arm64: sdm845-oneplus-common: enable debug UART
drm/panel/samsung-sofef00: make gpio optional
arm64: dts:
Don't specify the reset GPIO for the OnePlus 6T, the panel in the 6T
will refuse to initialise if it has been reset so use this as a
workaround.
Signed-off-by: Caleb Connolly
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 +---
arch/arm64/boot/dts/qcom/sdm845-oneplus
The OnePlus 6T panel fails to initialise if it has been reset,
workaround this by allowing panels to not specify a reset GPIO.
Signed-off-by: Caleb Connolly
---
drivers/gpu/drm/panel/panel-samsung-sofef00.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
Fix the upper guard and the "removed_region", this fixes the random
crashes which used to occur in memory intensive loads. I'm not sure WHY
the upper guard being 0x2000 instead of 0x1000 doesn't fix this, but it
HAS to be 0x1000.
Signed-off-by: Caleb Connolly
Fixes: e60fd5ac1f68 (&
On 28/04/2021 8:21 am, Simon Ser wrote:
>> A solution to make this configuration generic and exposed by the kernel
>> would standardise this across Linux
> Having a KMS property for this makes sense to me.
>
> Chatting with Jani on IRC, it doesn't seem like there's any EDID or
> DisplayID block
Resetting the panel on fajita causes it to never come back, we aren't
quite sure why this is so for now lets remove reset handling as it is
effectively broken. It is also not needed on enchilada.
Signed-off-by: Caleb Connolly
---
drivers/gpu/drm/panel/panel-samsung-sofef00.c | 26
With many more non-desktop form factor devices landing in the kernel,
we're starting to run up against some limitations. Notably devices with
display notches, cutouts and rounded corners.
Given that the DRI subsystem already deals with physical display
properties like panel orientation which
The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180
platforms. As SDM845 now has interconnects hooked up we should always
try and parse them.
Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu
runtime resume")
Signed-off-by: Caleb Connolly
--
Add compatibles for the samsung,sofef00 and samsung,s6e3fc2x01 panels
used in the OnePlus 6 & 6T respectively.
Signed-off-by: Caleb Connolly
---
.../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 4
1 file changed, 4 insertions(+)
diff --git
a/Documentation/device
Signed-off-by: Caleb Connolly
---
Changes since v1:
* Rename driver to samsung-sofef00 rather than be device
specific.
* Make use of drm_panel backlight, simplifying the driver.
* Make reset function do a full reset, instead of simply taking the
panel out of reset.
* Removed get_brightness
On 2020-10-09 15:05, Rob Herring wrote:
> On Wed, Oct 07, 2020 at 05:49:14PM +0000, Caleb Connolly wrote:
>> Document the OnePlus 6/T common panel driver, example from
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>>
>> Signed-off-by: Caleb Connolly
>>
as
> evolved since the driver was started.
> But despite the number of comments below it is all trivial and the
> driver looks good in general.
>
> I look forward to see the next revision.
>
> Sam
>
> On Wed, Oct 07, 2020 at 05:49:08PM +, Caleb Connolly wrote:
>
Document the OnePlus 6/T common panel driver, example from
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
Signed-off-by: Caleb Connolly
---
.../display/panel/panel-oneplus6.yaml | 73 +++
1 file changed, 73 insertions(+)
create mode 100644
Documentation/devicetree
that is specific to the devices.
The panels are: samsung,sofef00
and samsung,s6e3fc2x01
Signed-off-by: Caleb Connolly
---
drivers/gpu/drm/panel/Kconfig | 12 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-oneplus6.c | 418
that is specific to the devices.
The panels are: samsung,sofef00
and samsung,s6e3fc2x01
Signed-off-by: Caleb Connolly
---
drivers/gpu/drm/panel/Kconfig | 12 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-oneplus6.c | 418
Document the OnePlus 6/T common panel driver, example from
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
Signed-off-by: Caleb Connolly
---
.../display/panel/panel-oneplus6.yaml | 73 +++
1 file changed, 73 insertions(+)
create mode 100644
Documentation/devicetree
On 2020-09-01 17:46, Rob Clark wrote:
> From: Rob Clark
>
> NOTE: I have re-ordered the series, and propose that we could merge this
>series in the following order:
>
> 1) 01-11 - merge via drm / msm-next
> 2) 12-15 - merge via iommu, no dependency on msm-next pull req
>
65 matches
Mail list logo
