Re: [PATCH] xf86drm: add drmOpenByFB

2020-05-28 Thread Chih-Wei Huang
Simon Ser 於 2020年5月25日 週一 上午3:25寫道: > On Sunday, May 24, 2020 8:53 PM, Daniel Vetter wrote: > > On Sat, May 23, 2020 at 5:44 PM Mauro Rossi issor.or...@gmail.com wrote: > > > > > OpenByFB is introduced to overcome GPU driver loading order issue > > > on a device with multiple GPUs, e.g. Intel iGP

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-06-23 Thread Chih-Wei Huang
gt; issue. [1] > > > > >>>> > > > > >>>> However with libdrm module we have both liblog and libcutils shared > > > > >>>> dependencies > > > > >>>> > > > > >>>> [1] > >

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-21 Thread Chih-Wei Huang
2018-09-20 7:18 GMT+08:00 Lucas De Marchi : > On Wed, Sep 19, 2018 at 03:47:48PM +0800, Chih-Wei Huang wrote: >> 2018-09-14 2:23 GMT+08:00 Lucas De Marchi : >> > +Chris >> >> >> >> That's because drm_gralloc use the IS_GEN9 macro >> >&g

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-19 Thread Chih-Wei Huang
2018-09-14 2:23 GMT+08:00 Lucas De Marchi : > +Chris >> >> That's because drm_gralloc use the IS_GEN9 macro >> (and other IS_GEN{n} macros) directly. >> >> Since IS_GEN{n} are public APIs, I don't see > > > IS_GEN() is *not* public API and should not be. It's an internal macro. > > DESTDIR=/tmp/ins

Re: [PATCH libdrm] intel: annotate the intel genx helpers as private

2018-09-13 Thread Chih-Wei Huang
Note this patch breaks drm_gralloc: FAILED: out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/libgralloc_drm_intermediates/LINKED/libgralloc_drm.so /bin/bash -c "prebuilts/clang/host/linux-x86/clang-4053586/bin/clang++ -nostdlib -Wl,-soname,libgralloc_drm.so -Wl,--gc-sections -shared out/target/

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-04-02 Thread Chih-Wei Huang
2018-03-28 23:22 GMT+08:00 Rob Herring : > On Wed, Mar 28, 2018 at 10:19 AM, Rob Herring wrote: >> On Sat, Mar 17, 2018 at 2:33 PM, Stefan Schake wrote: >>> Hey John, >>> >>> On Fri, Mar 16, 2018 at 10:48 PM, John Stultz >>> wrote: In trying to integrate the new gralloc_handle.h with the >

Re: [PATCH libdrm] android: make libdrm*.so available to the vendor partition

2017-12-10 Thread Chih-Wei Huang
It seems the patch is necessary in Android 8.1, otherwise we got the errors: bootable/recovery/minui/Android.mk: error: libminui (STATIC_LIBRARIES android-x86_64) missing libdrm_platform (STATIC_LIBRARIES android-x86_64) You can set ALLOW_MISSING_DEPENDENCIES=true in your environment if this is in

Re: [PATCH hwc] Android: add CleanSpec.mk

2017-11-05 Thread Chih-Wei Huang
2017-11-03 20:35 GMT+08:00 Rob Herring : > On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang > wrote: >> The file contains rules that are executed on incremental builds. >> Since commit 4f7dc9b6 the library was moved to /vendor so >> the old file must be removed. >&

[PATCH hwc] Android: add CleanSpec.mk

2017-11-02 Thread Chih-Wei Huang
The file contains rules that are executed on incremental builds. Since commit 4f7dc9b6 the library was moved to /vendor so the old file must be removed. Signed-off-by: Chih-Wei Huang --- CleanSpec.mk | 1 + 1 file changed, 1 insertion(+) create mode 100644 CleanSpec.mk diff --git a

[PATCH libdrm] Android: update CleanSpec.mk

2017-11-02 Thread Chih-Wei Huang
The libraries are moved to /vendor since commit 011fd913. Clean all old files for incremental builds. Fixes: 011fd913 (Android: move libraries to /vendor) Signed-off-by: Chih-Wei Huang --- CleanSpec.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CleanSpec.mk b/CleanSpec.mk index

Re: [RFC PATCH hwc] drm_hwcomposer: provide a common gralloc handle definition

2017-10-24 Thread Chih-Wei Huang
2017-10-25 7:40 GMT+08:00 Rob Herring : > EGL, gralloc, and HWC must all have a common definition of fd's and int's > in native_handle_t to share the fd and width, height, format, etc. > of a dmabuf. > > Move the definition into HWC so we aren't dependent on a specific gralloc > implementation and

Re: [PATCH] drm_hwcomposer: remove unnecessary external includes

2017-10-24 Thread Chih-Wei Huang
t; external/drm_gralloc \ > - external/libdrm \ > - external/libdrm/include/drm \ > - system/core/include/utils \ > - system/core/libsync \ > - system/core/libsync/include \ > + system/core/libsync > > LOCAL_SRC_FILES := \ >

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-29 Thread Chih-Wei Huang
2017-09-29 16:44 GMT+08:00 Robert Foss : > On Fri, 2017-09-29 at 13:49 +0800, Chih-Wei Huang wrote: >> 2017-09-29 5:29 GMT+08:00 Rob Herring : >> > Perhaps just leave the current state as a separate branch. >> >> Did you mean we maintain the branch in our repo? &g

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-28 Thread Chih-Wei Huang
2017-09-29 5:29 GMT+08:00 Rob Herring : > On Thu, Sep 28, 2017 at 11:43 AM, Chih-Wei Huang > wrote: >> 2017-09-27 19:58 GMT+08:00 Robert Foss : >>> From: Sean Paul >>> >>> Since HWC2 doesn't require the use of threads to implement correct >&

Re: drm_hwcomposer moving to fd.o

2017-09-28 Thread Chih-Wei Huang
2017-09-28 15:08 GMT+08:00 Daniel Vetter : > On Thu, Sep 28, 2017 at 8:49 AM, Chih-Wei Huang > wrote: >> 2017-09-26 13:26 GMT+08:00 Daniel Vetter : >>> On Mon, Sep 25, 2017 at 09:06:55AM +0200, Tomeu Vizoso wrote: >>>> On 09/25/2017 04:44 AM, Chih-Wei Huang wr

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-28 Thread Chih-Wei Huang
2017-09-27 19:58 GMT+08:00 Robert Foss : > From: Sean Paul > > Since HWC2 doesn't require the use of threads to implement correct > synchronization, remove some of these threads. May I ask to avoid HWC2 only implementation? The main reason is not all GPUs support drm_hwcompser (as discussed in an

Re: drm_hwcomposer moving to fd.o

2017-09-27 Thread Chih-Wei Huang
2017-09-26 13:26 GMT+08:00 Daniel Vetter : > On Mon, Sep 25, 2017 at 09:06:55AM +0200, Tomeu Vizoso wrote: >> On 09/25/2017 04:44 AM, Chih-Wei Huang wrote: >> > Hey Robert, thank you for the reply. >> > >> > 2017-09-22 23:43 GMT+08:00 Robert Foss : >> &g

Re: drm_hwcomposer moving to fd.o

2017-09-24 Thread Chih-Wei Huang
Hey Robert, thank you for the reply. 2017-09-22 23:43 GMT+08:00 Robert Foss : > Hey Chih-Wei, > On Fri, 2017-09-22 at 10:40 +0800, Chih-Wei Huang wrote: >> Great news! >> Thanks a lot to make it happen. >> >> I hope I am wrong. >> From my understanding mos

Re: drm_hwcomposer moving to fd.o

2017-09-21 Thread Chih-Wei Huang
Great news! Thanks a lot to make it happen. I hope I am wrong. From my understanding most x86 GPUs still cannot work with drm_hwcomposer since they lack of atomic mode-setting API support required by drm_hwcomposer. Hope this could be addressed soon since drm_hwcomposer becomes a standard project

Re: [PATCH libdrm v2 2/2] android: amdgpu: fix build break

2017-08-23 Thread Chih-Wei Huang
2017-08-21 20:18 GMT+08:00 Emil Velikov : > On 17 August 2017 at 04:31, Chih-Wei Huang wrote: >> Ping. Is there any other concern to merge the fix? >> > My earlier suggestion was to use the respective Android build system > variable, instead of hardcoding the actual path

Re: [PATCH libdrm v2 2/2] android: amdgpu: fix build break

2017-08-16 Thread Chih-Wei Huang
Ping. Is there any other concern to merge the fix? 2017-07-27 16:20 GMT+08:00 Chih-Wei Huang : > Define two macros to avoid building errors. > > Fixes: 7e6bf88cac (amdgpu: move asic id table to a separate file) > > Signed-off-by: Chih-Wei Huang > --- > amdgpu/Android.mk

Re: [PATCH] android: amdgpu: move asic id table to a separate file

2017-07-27 Thread Chih-Wei Huang
> 2017-07-26 17:27 GMT+02:00 Emil Velikov : >> On 25 July 2017 at 08:28, Chih-Wei Huang wrote: >>> Hi Mauro, >>> Please note AMDGPU_ASIC_ID_TABLE >>> should be a path in the target device (i.e., Android). >>> So using $(LIBDRM_TOP) is incorrect. >

[PATCH libdrm v2 2/2] android: amdgpu: fix build break

2017-07-27 Thread Chih-Wei Huang
Define two macros to avoid building errors. Fixes: 7e6bf88cac (amdgpu: move asic id table to a separate file) Signed-off-by: Chih-Wei Huang --- amdgpu/Android.mk | 6 ++ 1 file changed, 6 insertions(+) diff --git a/amdgpu/Android.mk b/amdgpu/Android.mk index bf0611b..88d3765 100644 --- a

[PATCH libdrm v2 1/2] android: add rules to build amdgpu.ids

2017-07-27 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- data/Android.mk | 9 + 1 file changed, 9 insertions(+) create mode 100644 data/Android.mk diff --git a/data/Android.mk b/data/Android.mk new file mode 100644 index 000..3c1fd7c --- /dev/null +++ b/data/Android.mk @@ -0,0 +1,9 @@ +LOCAL_PATH

Re: [PATCH] android: amdgpu: move asic id table to a separate file

2017-07-25 Thread Chih-Wei Huang
2017-07-22 17:01 GMT+08:00 Mauro Rossi : > Changes in Android.mk makefile to avoid building errors in mesa > due to missing LOCAL_CFLAGS variable definition for > AMDGPU_ASIC_ID_TABLE and ASIC_ID_TABLE_NUM_ENTRIES > > Fixes: 7e6bf88cac ("amdgpu: move asic id table to a separate file") > --- > amdg

[PATCH 1/2] android: add rules to build amdgpu.ids

2017-07-19 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- data/Android.mk | 9 + 1 file changed, 9 insertions(+) create mode 100644 data/Android.mk diff --git a/data/Android.mk b/data/Android.mk new file mode 100644 index 000..3c1fd7c --- /dev/null +++ b/data/Android.mk @@ -0,0 +1,9 @@ +LOCAL_PATH

[PATCH 2/2] android: amdgpu: fix build break

2017-07-19 Thread Chih-Wei Huang
Define two macros to avoid building errors. Fixes: 7e6bf88cac (amdgpu: move asic id table to a separate file) Signed-off-by: Chih-Wei Huang --- amdgpu/Android.mk | 6 ++ 1 file changed, 6 insertions(+) diff --git a/amdgpu/Android.mk b/amdgpu/Android.mk index bf0611b..955bd53 100644 --- a

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-19 Thread Chih-Wei Huang
Sorry for reply late. 2017-07-05 19:05 GMT+08:00 Emil Velikov : > On 5 July 2017 at 11:44, Chih-Wei Huang wrote: >> >> Yep. The first problem to prepare the patch is, >> where to install amdgpu.ids on Android? >> Is /system/etc/amdgpu.ids OK? >> > Personall

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-05 Thread Chih-Wei Huang
2017-07-05 17:35 GMT+08:00 Emil Velikov : > On 4 July 2017 at 07:40, Chih-Wei Huang wrote: >> >> Unfortunately this patch breaks Android build >> since the two macros are not defined. >> >> Anyone is working on a fix? >> If not, I'll try to provide on

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-03 Thread Chih-Wei Huang
2017-06-12 17:50 GMT+08:00 Michel Dänzer : > From: Xiaojie Yuan > > v2: fix an off by one error and leading white spaces > v3: use thread safe strtok_r(); initialize len before calling getline(); > change printf() to drmMsg(); add initial amdgpu.ids > v4: integrate some recent internal changes

Re: [PATCH libdrm] xf86drm: fix compile error for declare i in for loop

2017-05-17 Thread Chih-Wei Huang
2017-05-18 0:10 GMT+08:00 Emil Velikov : > On 17 May 2017 at 14:58, Yu, Qiang wrote: >> Hi Emil, >> >> I didn't modify the code. I'm using Ubuntu 14.04 gcc 4.8.4, the configure >> pass but >> fail when compile. >> >> I think my gcc support c99 but needs adding "-std=c99" to enable it, and the >>

[PATCH] intel: fix a conversion format mismatch

2017-03-08 Thread Chih-Wei Huang
To avoid the warning: external/libdrm/intel/intel_bufmgr.c:362:20: warning: more '%' conversions than data arguments [-Wformat] fprintf(stderr, "%s: Mappable aperture size hardcoded to 64MiB\n"); ~^ Change-Id: I6c1b0a9e3004aacde0d64662de1144cadff30132 --- intel/

VirtIO-GPU 3D OpenGL Hardware Acceleration for VMs

2016-03-24 Thread Chih-Wei Huang
2016-02-15 10:34 GMT+08:00 Saket Sinha : > > It seems upstream Linux/Gallium3D/Mesa/Qemu/KVM has recently gained > virtualized support for 3D/OpenGL hardware acceleration in VMs, > allowing using the GPU of the host in VMs. > > As per my understanding the following components are needed - > > - Lin

Atomic mode-setting drivers

2016-03-07 Thread Chih-Wei Huang
2016-03-05 0:32 GMT+08:00 Daniel Vetter : > Adding relevant mailing lists and people. Please don't send private > mails to maintainers ;-) Thank you for the reply and pointing it. > On Fri, Mar 4, 2016 at 1:47 PM, Chih-Wei Huang > wrote: >> Hi Daniel, >> This is th

[PATCH] android: add virgl to be a valid driver

2016-02-26 Thread Chih-Wei Huang
To avoid the warning: external/libdrm/libkms/Android.mk:17: invalid GPU drivers: virgl Signed-off-by: Chih-Wei Huang --- libkms/Android.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libkms/Android.mk b/libkms/Android.mk index 4f5e3d2..a406782 100644 --- a/libkms/Android.mk +++ b

DRM support in Android

2016-01-15 Thread Chih-Wei Huang
2016-01-09 16:37 GMT+08:00 vijay kumar : > Thanks Greg .You Helped me a lot. > > On Thu, Jan 7, 2016 at 10:52 PM, Greg Hackmann > wrote: >> >> On Tue, Jan 5, 2016 at 12:06 AM, vijay kumar wrote: >>> >>> Hii all, >>> I want to know some information regarding DRI and DRM >>> support

[PATCH libdrm] intel: add the missing header

2015-12-01 Thread Chih-Wei Huang
Any concern to merge such a simple fix?? 2015-10-30 11:49 GMT+08:00 Chih-Wei Huang : > It defines the prototype of ffs that fixes the building error > on Android 6.0 64-bit image. > > Signed-off-by: Chih-Wei Huang > --- > intel/intel_bufmgr_fake.c | 1 + > 1 file

[PATCH libdrm] intel: add the missing header

2015-10-30 Thread Chih-Wei Huang
It defines the prototype of ffs that fixes the building error on Android 6.0 64-bit image. Signed-off-by: Chih-Wei Huang --- intel/intel_bufmgr_fake.c | 1 + 1 file changed, 1 insertion(+) diff --git a/intel/intel_bufmgr_fake.c b/intel/intel_bufmgr_fake.c index 551e05d..7f4c7b9 100644 --- a

[PATCH libdrm] Add missing includes

2015-04-27 Thread Chih-Wei Huang
2015-04-24 0:56 GMT+08:00 Emil Velikov : > On 22/04/15 16:19, Greg Hackmann wrote: >> On Tue, Apr 21, 2015 at 11:31 AM, Emil Velikov >> wrote: >>> >>> I'm not sure why I haven't hit this while building with Android-x86's >>> bionic, although it's the right thing to do. >> >> Maybe a difference in

[PATCH] android: remove unnecessary TARGET_OUT_HEADERS variable

2015-03-31 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- tests/modetest/Android.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/modetest/Android.mk b/tests/modetest/Android.mk index aee3564..0fdfe68 100644 --- a/tests/modetest/Android.mk +++ b/tests/modetest/Android.mk @@ -7,8 +7,6 @@ LOCAL_SRC_FILES

[PATCH libdrm 0/5] Yet another round of Android build cleanups

2015-03-20 Thread Chih-Wei Huang
Is there any gating item to prevent these patches (5+2) from being merged? 2015-03-19 10:56 GMT+08:00 Chih-Wei Huang : > 2015-03-19 10:06 GMT+08:00 Emil Velikov : >> On 18/03/15 16:38, Chih-Wei Huang wrote: >>> 2015-03-18 9:37 GMT+08:00 Emil Velikov : >>>> > On

[PATCH libdrm 0/5] Yet another round of Android build cleanups

2015-03-19 Thread Chih-Wei Huang
2015-03-19 10:06 GMT+08:00 Emil Velikov : > On 18/03/15 16:38, Chih-Wei Huang wrote: >> 2015-03-18 9:37 GMT+08:00 Emil Velikov : >>> > On 18 March 2015 at 01:19, Chih-Wei Huang >>> > wrote: >>>> >> >>>> >> I would suggest to

[PATCH libdrm 0/5] Yet another round of Android build cleanups

2015-03-19 Thread Chih-Wei Huang
2015-03-18 9:37 GMT+08:00 Emil Velikov : > On 18 March 2015 at 01:19, Chih-Wei Huang wrote: >> >> I would suggest to remove all the use of LIBDRM_TOP. >> Do you want me to submit a patch? > Hmm I'm not sure that things will work correctly if we directly > subst

[PATCH libdrm 3/5] android: remove ${srcdir} from the includes

2015-03-18 Thread Chih-Wei Huang
2015年3月18日 上午7:30 於 "Emil Velikov" 寫道: > > Already implicitly handled by the compiler. Actually it's not handled by the compiler, but by the Android build system. It automatically adds $(LOCAL_PATH), $(intermediate), ... to the include paths. > Signed-off-by: Emil Velikov >

[PATCH libdrm 0/5] Yet another round of Android build cleanups

2015-03-18 Thread Chih-Wei Huang
2015-03-18 7:30 GMT+08:00 Emil Velikov : > > As pointed out by Chih-Wei, Android's LOCAL_COPY_HEADERS{,_TO} has been > depreciated for quite some time. > > Although it was a convenient way of getting things done (no more > hard-coding the location of drm) it seems that there is another more > appro