Re: [Linux-stm32] [PATCH 09/12] arm64: dts: st: add lvds support on stm32mp255

2025-07-25 Thread Clement LE GOFFIC
On 7/25/25 13:08, Clement LE GOFFIC wrote: Hi Raphael, On 7/25/25 12:04, Raphael Gallais-Pou wrote: The LVDS is used on STM32MP2 as a display interface. Add the LVDS node. Signed-off-by: Raphael Gallais-Pou ---   arch/arm64/boot/dts/st/stm32mp255.dtsi | 12   1 file changed, 12

Re: [Linux-stm32] [PATCH 09/12] arm64: dts: st: add lvds support on stm32mp255

2025-07-25 Thread Clement LE GOFFIC
Hi Raphael, On 7/25/25 12:04, Raphael Gallais-Pou wrote: The LVDS is used on STM32MP2 as a display interface. Add the LVDS node. Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp255.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/d

Re: [PATCH v3 3/3] i2c: stm32f7: support i2c_*_dma_safe_msg_buf APIs

2025-07-03 Thread Clement LE GOFFIC
Hi Andy, On 7/2/25 19:15, Andi Shyti wrote: Hi Clement, On Mon, Jun 30, 2025 at 02:55:15PM +0200, Clément Le Goffic wrote: Use the i2c-core-base APIs to allocate a DMA safe buffer when needed. same here, I don't understand anything... you could have written "do some coding" and it would have

Re: [PATCH v3 2/3] i2c: stm32f7: unmap DMA mapped buffer

2025-07-03 Thread Clement LE GOFFIC
Hi Andi, On 7/2/25 19:08, Andi Shyti wrote: Hi Clement, On Mon, Jun 30, 2025 at 02:55:14PM +0200, Clément Le Goffic wrote: Fix an issue where the mapped DMA buffer was not unmapped. "Fix an issue..." is too generic. Can you be more specific? Where was it mapped? Where was it left unmapped?

Re: [PATCH v3 1/3] i2c: stm32: fix the device used for the DMA map

2025-07-03 Thread Clement LE GOFFIC
Hi Andy, On 7/2/25 18:57, Andi Shyti wrote: Hi Clement, ... @@ -118,7 +118,7 @@ int stm32_i2c_prep_dma_xfer(struct device *dev, struct stm32_i2c_dma *dma, dma->dma_len = len; chan_dev = dma->chan_using->device->dev; - dma->dma_buf = dma_map_single(chan_dev, buf, dma->dma_l

Re: [PATCH 2/3] i2c: stm32f7: unmap DMA mapped buffer

2025-06-27 Thread Clement LE GOFFIC
On 6/26/25 11:03, Alain Volmat wrote: Hi Clément, thanks for the patch. On Mon, Jun 16, 2025 at 10:53:55AM +0200, Clément Le Goffic wrote: Fix an issue where the mapped DMA buffer was not unmapped. Fixes: 7ecc8cfde553 ("i2c: i2c-stm32f7: Add DMA support") Signed-off-by: Clément Le Goffic ---

Re: [PATCH 1/3] i2c: stm32: fix the device used for the DMA map

2025-06-27 Thread Clement LE GOFFIC
On 6/26/25 10:43, Alain Volmat wrote: Hi Clément, Oups, I was too fast. there might be another place to correct in the driver, dma_unmap_single within the error handling of the function stm32_i2c_prep_dma_xfer. err: dma_unmap_single(chan_dev, dma->dma_buf, dma->dma_len,