Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-17 Thread Daniel Latypov
On Fri, May 17, 2024 at 1:14 PM Andy Shevchenko wrote: > > [devarsht: Rebase to 6.9 and change license to GPL] > > I'm not sure that you may change license. It needs the author's confirmation. Checking, this is referring to the MODULE_LICENSE, which used to be MODULE_LICENSE("GPL v2"); and is

Re: [PATCH 2/9] lib/cmdline: Fix an invalid format specifier in an assertion msg

2024-02-22 Thread Daniel Latypov
o deal with? > in test 18 at -5 out of bound or > in test 18 at 18446744073709551611 out of bound Sure, I can eventually figure out what both messages mean, but it's a immediately obvious from the first that there's a a) real error: something is wrong at index 5 b) test code error: there's a

Re: [PATCH 1/9] kunit: test: Log the correct filter string in executor_test

2024-02-21 Thread Daniel Latypov
ng attributes") > Signed-off-by: David Gow Reviewed-by: Daniel Latypov > --- > lib/kunit/executor_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kunit/executor_test.c b/lib/kunit/executor_test.c > index 22d4ee86dbed..3f7f967e3688 100644

Re: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-07 Thread Daniel Latypov
On Fri, Nov 4, 2022 at 12:20 PM Daniel Latypov wrote: > rm...@google.com was working on them and should hopefully be able to > send them out real soon. > You should get CC'd on those. > > I think the follow-up work is just crafting an example parser input > file and iterating u

Re: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-07 Thread Daniel Latypov
On Mon, Nov 7, 2022 at 10:38 AM Michał Winiarski wrote: > > On Thu, Nov 03, 2022 at 04:23:02PM +0100, Mauro Carvalho Chehab wrote: > > Hi, > > > > I'm facing a couple of issues when testing KUnit with the i915 driver. > > > > The DRM subsystem and the i915 driver has, for a long time, his own > >

Re: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-04 Thread Daniel Latypov
On Fri, Nov 4, 2022 at 12:50 AM Mauro Carvalho Chehab wrote: > > On Thu, 3 Nov 2022 15:43:26 -0700 > Daniel Latypov wrote: > > > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab > > wrote: > > > > > > Hi, > > > > > > I'm facin

Re: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Daniel Latypov
On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab wrote: > > Hi, > > I'm facing a couple of issues when testing KUnit with the i915 driver. > > The DRM subsystem and the i915 driver has, for a long time, his own > way to do unit tests, which seems to be added before KUnit. > > I'm now checking

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Daniel Latypov
On Tue, Nov 1, 2022, 6:53 AM Mauro Carvalho Chehab wrote: > > Ah, the selection is in kunit.ko itself. kunit.filter_glob, set from > > kunit.py with > > > > positional arguments: > > filter_glob Filter which KUnit test suites/tests run at > > boot-time, e.g. list* or list*.*del_test

Re: [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-09-19 Thread Daniel Latypov
On Mon, Sep 19, 2022 at 1:43 PM Isabella Basso wrote: > >> +* "(K)TAP version XX" should be the first line on all (sub)tests > >> as per > >> +* > >> https://www.kernel.org/doc/html/latest/dev-tools/ktap.html#version-lines > >> +* but actually isn't, as it currently