On Wed, Oct 16, 2019 at 6:14 PM Russell King - ARM Linux admin
wrote:
>
> On Wed, Oct 16, 2019 at 03:39:15PM +0200, Hans Verkuil wrote:
> > From: Dariusz Marcinkiewicz
> >
> > Use the new cec_notifier_conn_(un)register() functions to
> > (un)register the n
Hi Russel.
On Wed, Oct 16, 2019 at 6:22 PM Russell King - ARM Linux admin
wrote:
>
...
> > --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> > @@ -1337,6 +1337,8 @@ static int tda998x_connector_init(struct tda998x_priv
> > *priv,
> >
Hi.
On Wed, Aug 28, 2019 at 10:39 AM Sylwester Nawrocki
wrote:
>
> nit: I think err_rpm_disable or err_pm_runtime_disable could be better
> label names.
>
Submitted v7.1 which replaces err_runtime_disable with err_rpm_disable.
Thank you.
ore
deregistering the notifier,
- use cec_notifier_phys_addr_invalidate instead of setting
invalid address on a notifier.
Signed-off-by: Dariusz Marcinkiewicz
Tested-by: Hans Verkuil
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 31
1 file chan
Hi.
Should this patch also have an explicit From tag?
On Fri, Aug 23, 2019 at 2:21 PM Hans Verkuil wrote:
>
> Document the new CEC_ADAP_G_CONNECTOR_INFO ioctl and the new
> CEC_CAP_CONNECTOR_INFO capability.
>
> Signed-off-by: Dariusz Marcinkiewicz
> Co-developed-by: Hans Ve
On Sun, Aug 25, 2019 at 3:12 PM Hans Verkuil wrote:
>
> You dropped a 'if (!notifier)' before the return!
>
> After adding back this 'if' it worked fine on my BeagleBone Black board,
> so after fixing this you can add my:
>
> Tested-by: Hans Verkuil
>
Submitted v7.2. Thank you for testing!
barrier to make sure that the notifier
becomes visible to the irq thread once it is
fully constructed.
Signed-off-by: Dariusz Marcinkiewicz
Tested-by: Hans Verkuil
---
drivers/gpu/drm/i2c/tda998x_drv.c | 37 ++-
1 file changed, 26 insertions(+), 11
On Mon, Aug 19, 2019 at 11:38 AM Hans Verkuil wrote:
>
> Hi all,
>
Hi Hans.
> The patches in this series can be applied independently from each other.
>
> If you maintain one of these drivers and you want to merge it for v5.4
> yourself, then please do so and let me know. If you prefer I commit
visible to the irq thread once it is
fully constructed.
Signed-off-by: Dariusz Marcinkiewicz
---
drivers/gpu/drm/i2c/tda998x_drv.c | 36 +--
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c
e sure IRQ
threads see the notifier once it is created (replacing the
WRITE_ONCE I put in v1). The best thing to do here, I believe,
would be not to have any synchronization and make sure that an IRQ
only gets enabled after the notifier is created.
Dariusz Marcinkiewicz (9):
Pass the connector info to the CEC adapter. This makes it possible
to associate the CEC adapter with the corresponding drm connector.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
drivers/gpu
Hello.
On Tue, Aug 13, 2019 at 1:20 PM Russell King - ARM Linux admin
wrote:
>
> This also doesn't make sense: tda998x_destroy() is the opposite of
> tda998x_create(). However, tda998x_connector_destroy() is the
> opposite of tda998x_connector_create().
>
> By moving the CEC creation code into
Hi.
On Tue, Aug 13, 2019 at 1:38 PM Hans Verkuil wrote:
>
> Russell's review caused me to take another look at this series, and it made
> wonder if cec_notifier_conn_unregister() shouldn't be called from
> bridge_detach?
>
I've sent out v7 of the series where unregistration is done from bridge
cec_notifier_phys_addr_invalidate instead of setting
invalid address on a notifier.
Signed-off-by: Dariusz Marcinkiewicz
Tested-by: Hans Verkuil
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 31
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm
Use the new cec_notifier_conn_(un)register() functions to
(un)register the notifier for the HDMI connector, and fill in
the cec_connector_info.
Changes since v4:
- only create a CEC notifier for HDMI connectors
Signed-off-by: Dariusz Marcinkiewicz
Tested-by: Hans Verkuil
---
drivers
that the notifier
becomes visible to the irq thread once it is fully
constructed.
Signed-off-by: Dariusz Marcinkiewicz
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 45 +++
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/bridge
| CEC_CAP_TRANSMIT |
CEC_CAP_RC | CEC_CAP_PASSTHROUGH with CEC_CAP_DEFAULTS.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git
Use the new cec_notifier_cec_adap_(un)register() functions to
(un)register the notifier for the CEC adapter.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/gpu/drm/i2c/tda9950.c | 12 ++--
1 file changed, 6 insertions(+), 6
it is
fully constructed.
Signed-off-by: Dariusz Marcinkiewicz
---
drivers/gpu/drm/i2c/tda998x_drv.c | 36 +--
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c/tda998x_drv.c
index 61e042918a7fc
Use the new cec_notifier_conn_(un)register() functions to
(un)register the notifier for the HDMI connector, and fill
in the cec_connector_info.
Changes since v2:
Don't invalidate physical address before unregistering the
notifier.
Signed-off-by: Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to
(un)register the notifier for the HDMI connector, and fill in
the cec_connector_info.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 13
cec_notifier_phys_addr_invalidate instead of setting
invalid address on a notifier.
Signed-off-by: Dariusz Marcinkiewicz
Tested-by: Hans Verkuil
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 31
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm
,
- use cec_notifier_phys_addr_invalidate to invalidate physical
address.
Changes since v1:
Add memory barrier to make sure that the notifier
becomes visible to the irq thread once it is fully
constructed.
Signed-off-by: Dariusz Marcinkiewicz
Tested-by: Hans
Use the new cec_notifier_conn_(un)register() functions to
(un)register the notifier for the HDMI connector, and fill in
the cec_connector_info.
Changes since v4:
- only create a CEC notifier for HDMI connectors
Signed-off-by: Dariusz Marcinkiewicz
Tested-by: Hans Verkuil
---
drivers
Use the new cec_notifier_conn_(un)register() functions to
(un)register the notifier for the HDMI connector, and fill
in the cec_connector_info.
Changes since v2:
Don't invalidate physical address before unregistering the
notifier.
Signed-off-by: Dariusz Marcinkiewicz
cec_notifier_conn_unregister.
Changes since v1:
Add memory barrier to make sure that the notifier
becomes visible to the irq thread once it is
fully constructed.
Signed-off-by: Dariusz Marcinkiewicz
Tested-by: Hans Verkuil
---
drivers/gpu/drm/i2c/tda998x_drv.c | 33
o have any synchronization and make sure that an IRQ
only gets enabled after the notifier is created.
Dariusz Marcinkiewicz (8):
drm/i915/intel_hdmi: use cec_notifier_conn_(un)register
dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
tda9950: use cec_notifier_cec_adap_(un)register
dr
| CEC_CAP_TRANSMIT |
CEC_CAP_RC | CEC_CAP_PASSTHROUGH with CEC_CAP_DEFAULTS.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git
Use the new cec_notifier_cec_adap_(un)register() functions to
(un)register the notifier for the CEC adapter.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/gpu/drm/i2c/tda9950.c | 12 ++--
1 file changed, 6 insertions(+), 6
Use the new cec_notifier_conn_(un)register() functions to
(un)register the notifier for the HDMI connector, and fill in
the cec_connector_info.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 13
Hi again.
On Tue, Jun 25, 2019 at 4:45 PM Hans Verkuil wrote:
>
> + mutex_lock(>lock);
> + if (copy_to_user(parg, >conn_info, sizeof(adap->conn_info)))
> + ret = -EFAULT;
> + mutex_unlock(>lock);
> + return ret;
> +}
Shouldn't the lock be released before
Hi.
This looks good except one comment about the ioctl.
On Mon, Jun 24, 2019 at 6:03 PM Hans Verkuil wrote:
>
...
> +static long cec_adap_g_connector_info(struct cec_adapter *adap,
> + struct cec_log_addrs __user *parg)
> +{
> + if (!(adap->capabilities
Hello.
Some small comments/questions.
On Mon, Jun 24, 2019 at 6:03 PM Hans Verkuil wrote:
>
...
> @@ -22,9 +22,11 @@ struct cec_notifier {
> struct list_head head;
> struct kref kref;
> struct device *hdmi_dev;
> + struct cec_connector_info conn_info;
>
Hi Hans.
Patches 1 and 2 look good to me. There is one comment here that I
forgot to update as the code evolved.
On Mon, Jun 24, 2019 at 6:03 PM Hans Verkuil wrote:
...
> +/**
> + * struct cec_event_connector - tells if and which connector is associated
> + * with the CEC adapter.
> + *
Hello, pretty late here but I have a small comment.
> From: Hans Verkuil
> This adds support for the DisplayPort CEC-Tunneling-over-AUX
> feature that is part of the DisplayPort 1.3 standard.
> +int drm_dp_cec_configure_adapter(struct drm_dp_aux *aux, const char
35 matches
Mail list logo