On 22/02/2022 15:51, Balasubramani Vivekanandan wrote:
drm_memcpy_from_wc() performs fast copy from WC memory type using
non-temporal instructions. Now there are two similar implementations of
this function. One exists in drm_cache.c as drm_memcpy_from_wc() and
another implementation in
Patches: 1, 2, 3, 5, 6, 11 are Acked-by: Nirmoy Das
Patches: 5,6 are Reviewed-by: Nirmoy Das
Sorry for partial reviews, I still need to go through more i915 code.
Regards,
Nirmoy
On 10/02/2022 13:12, Matthew Auld wrote:
Starting from DG2 we will have resizable BAR support for device
On 07/02/2022 10:37, Ramalingam C wrote:
While evicting the local memory data on flat-ccs capable platform we
need to evict the ccs data associated to the data. For this, we are
adding extra pages ((size / 256) >> PAGE_SIZE) into the ttm_tt.
To achieve this we are adding a new param into the
Thanks for the clarification, Ram!
On 07/02/2022 14:53, Ramalingam C wrote:
On 2022-02-07 at 12:41:59 +0100, Christian König wrote:
Am 07.02.22 um 10:37 schrieb Ramalingam C:
On flat-ccs capable platform we need to evict and resore the ccs data
along with the corresponding main memory.
This
Acked-by: Nirmoy Das
On 10/28/2021 3:26 PM, Christian König wrote:
Don't touch the exclusive fence manually here, but rather use the
general dma_resv function. We did that for better hw reset handling but
this doesn't necessary work correctly.
Signed-off-by: Christian König
---
LGTM, Acked-by: Nirmoy Das for the series.
On 10/25/2021 10:05 AM, Christian König wrote:
Instead of hand rolling the logic.
Signed-off-by: Christian König
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 31 ++-
1 file changed, 11 insertions(+), 20 deletions(-)
diff
On 10/17/2021 10:03 PM, Lukas Wunner wrote:
On Wed, Oct 13, 2021 at 08:36:01PM +0200, Nirmoy Das wrote:
Debugfs APIs returns encoded error on failure so use
debugfs_lookup() instead of checking for NULL.
The commit message no longer matches up with the patch itself
(debugfs_lookup() isn't
Ah there are three typos :/
s/deference/dereference for this one and for the 2nd patch as well.
Regards,
Nirmoy
On 10/13/2021 8:35 PM, Nirmoy Das wrote:
Debugfs APIs returns encoded error on failure instead of NULL
and for drm primary/minor debugfs directories, we save the
returned value in
Hi Zhi,
Please discard this patch, review
https://patchwork.freedesktop.org/patch/458554/?series=95690=1 instead.
minor->debugfs_root wont be NULl as we save debugfs_create_dir()'s return value
in that.
Regards,
Nirmoy
On 10/12/2021 11:59 AM, Wang, Zhi A wrote:
On 10/8/21 9:17 AM,
On 10/12/2021 8:48 AM, Lukas Wunner wrote:
On Mon, Oct 11, 2021 at 10:24:29PM +0200, Lukas Wunner wrote:
On Mon, Oct 11, 2021 at 09:06:07PM +0200, Nirmoy Das wrote:
Debugfs APIs returns encoded error on failure so use
debugfs_lookup() instead of checking for NULL.
[...]
---
On 10/12/2021 9:09 AM, Christian König wrote:
Am 11.10.21 um 21:06 schrieb Nirmoy Das:
For debugfs directory, it is recommended to save the result
and pass over to next debugfs API for creating debugfs
files/directories. Error conditions are handled by debugfs APIs.
CC: Christian Koenig
CC:
On 10/11/2021 4:19 PM, Christian König wrote:
Am 08.10.21 um 17:11 schrieb Greg KH:
On Fri, Oct 08, 2021 at 04:22:06PM +0200, Christian König wrote:
Hi guys,
thanks Nirmoy for forwarding this, there is seriously something
wrong with
the AMD mail servers.
On 10/8/2021 1:07 PM, Greg KH
[AMD Official Use Only]
Trying with Christian's Gmail, as he still didn't receive previous emails.
From: Das, Nirmoy
Sent: Friday, October 8, 2021 2:17 PM
To: Koenig, Christian
Cc: dri-devel@lists.freedesktop.org ;
intel-...@lists.freedesktop.org ; Maarten
[AMD Official Use Only]
Thanks, Greg and Jani. So I have to do the exact opposite.
We do have some NULL dentry check in the drm code. I will remove those instead.
Regards,
Nirmoy
From: Greg KH
Sent: Friday, October 8, 2021 1:07 PM
To: Jani Nikula
Cc: Das
: Koenig, Christian
Sent: Friday, October 8, 2021 12:23 PM
To: Das, Nirmoy ; dri-devel@lists.freedesktop.org
Cc: intel-...@lists.freedesktop.org ; Deucher,
Alexander ; Pan, Xinhui
Subject: Re: [PATCH 3/5] drm/radeon: check dri root before debugfs init
Am 08.10.21 um 11:17 schrieb Nirmoy Das
PM, Christian König wrote:
Am 05.10.21 um 15:49 schrieb Das, Nirmoy:
On 10/5/2021 3:22 PM, Christian König wrote:
Am 05.10.21 um 15:11 schrieb Nirmoy Das:
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel param. We
shouldn't
see
Happy to help, Christian :)
Nirmoy
On 7/6/2021 5:33 PM, Christian Zigotzky wrote:
Hi Nirmoy,
This patch works! Thanks a lot! We tested it on an A-EON AmigaOne
X5000/20 today.
Screenshot:
Hi Christian,
This issue looks similar to the one Mikel Rychliski fixed recently :
https://patchwork.freedesktop.org/patch/440791. Let us know if this helps.
Regards,
Nirmoy
On 7/3/2021 9:30 AM, Christian Zigotzky wrote:
Hi All,
Xorg doesn't work anymore after the latest DRM updates.
LGTM
Acked-by: Nirmoy Das
On 6/29/2021 3:58 PM, Thomas Zimmermann wrote:
Print the name of the DRM driver when taking over fbdev devices. Makes
the output to dmesg more consistent. Note that the driver name is only
used for printing a string to the kernel log. No UAPI is affected by this
Hi Christian,
Could you please pick this up for drm-misc-next or fixes ?
Regards,
Nirmoy
On 6/29/2021 1:44 PM, Nirmoy Das wrote:
Return early for non-TTM_PL_TT BOs so that we don't pass
wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes
ttm_resource argument to be TTM_PL_TT
On 6/29/2021 1:06 PM, Christian König wrote:
Am 29.06.21 um 09:36 schrieb Nirmoy Das:
Be more defensive and raise error on wrong mem_type
argument in amdgpu_gtt_mgr_has_gart_addr().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +-
1 file changed, 5
On 6/29/2021 1:05 PM, Christian König wrote:
Am 29.06.21 um 09:36 schrieb Nirmoy Das:
Return early for non-TTM_PL_TT BOs so that we don't pass
wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes
ttm_resource argument to be TTM_PL_TT type BO's.
v2: merge if-conditions
Tried on vmwgfx and amdgpu, everything looks fine. I would have love to
do a kfdtest as
I think kfdtest does bo movement tests but it seems kfdtest regressing
even before this series. Trying to debug that.
The series is Acked-by: Nirmoy Das
On 6/22/2021 6:23 PM, Andrey Grodzovsky wrote:
On 6/9/2021 8:38 AM, Christian König wrote:
Am 08.06.21 um 20:13 schrieb Nirmoy Das:
Use ttm_bo_move_null() instead of ttm_bo_assign_mem().
Signed-off-by: Nirmoy Das
Reviewed-by: Christian König
Looks like I've forgot to push that one. *sigh* I'm getting old.
Nah, you have too many
Please ignore this, I wanted to send
https://patchwork.kernel.org/project/dri-devel/patch/20210503190013.91732-1-nirmoy@amd.com/
after rebase.
On 6/8/2021 8:01 PM, Nirmoy Das wrote:
ttm_bo_assign_mem() expects bo->resource to be free.
Fixes: bfa3357ef9abc ("drm/ttm: allocate resource
On 6/8/2021 7:28 PM, Christian König wrote:
Am 08.06.21 um 17:09 schrieb Nirmoy Das:
ttm_bo_assign_mem() expects bo->resource to be free.
Fixes: bfa3357ef9abc ("drm/ttm: allocate resource object instead of
embedding it v2")
Signed-off-by: Nirmoy Das
---
On 6/8/2021 11:42 AM, Christian König wrote:
Am 08.06.21 um 11:40 schrieb Das, Nirmoy:
On 6/8/2021 11:38 AM, Das, Nirmoy wrote:
On 6/8/2021 9:21 AM, Christian König wrote:
Am 08.06.21 um 09:17 schrieb Thomas Hellström (Intel):
[SNIP]
Do you have the log to double check
On 6/8/2021 11:38 AM, Das, Nirmoy wrote:
On 6/8/2021 9:21 AM, Christian König wrote:
Am 08.06.21 um 09:17 schrieb Thomas Hellström (Intel):
[SNIP]
Do you have the log to double check?
Unfortunately not, but IIRC it was directly from vmw_move().
Nirmoy do you still have your vmwgfx
On 6/8/2021 9:21 AM, Christian König wrote:
Am 08.06.21 um 09:17 schrieb Thomas Hellström (Intel):
[SNIP]
Do you have the log to double check?
Unfortunately not, but IIRC it was directly from vmw_move().
Nirmoy do you still have your vmwgfx test environment?
Yes!
Thanks,
Reviewed-by: Nirmoy Das
On 6/7/2021 7:11 PM, Christian König wrote:
The resource is not allocated yet, so no chance that this will work.
Use the placement instead.
Signed-off-by: Christian König
---
drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Hi Christian and Lang,
I can't apply it cleanly because of
https://patchwork.freedesktop.org/patch/436305/. This series needs a rebase.
Regards,
Nirmoy
On 6/7/2021 4:42 PM, Das, Nirmoy wrote:
On 6/7/2021 3:01 PM, Christian König wrote:
Hi Nirmoy,
can you give that patch set a testing
On 6/7/2021 3:01 PM, Christian König wrote:
Hi Nirmoy,
can you give that patch set a testing round and an review?
Sure! I will get back asap.
The memory stress test with low VRAM on APUs should be sufficient and
you should have that setup still around.
Thanks in advance,
Christian.
On 5/28/2021 4:36 PM, Christian König wrote:
Am 20.04.21 um 12:50 schrieb Nirmoy Das:
Releasing pinned BOs is illegal now.
UVD 6 was missing from:
commit 2f40801dc553 ("drm/amdgpu: make sure we unpin the UVD BO")
Signed-off-by: Nirmoy Das
Reviewed-by: Christian König
Maybe add a
On 5/2/2020 10:00 AM, Chris Wilson wrote:
Quoting Nirmoy (2020-04-30 11:30:43)
On 4/30/20 12:15 PM, Chris Wilson wrote:
Quoting Nirmoy Das (2020-04-30 10:58:39)
+void insert_hole_addr(struct rb_root *root, struct drm_mm_node *node)
^ static
Ah I forgot!
(sparse [make C=1] or make W=1
101 - 134 of 134 matches
Mail list logo
