[PATCH 03/11] nouveau: fix disp disabling with GSP

2023-12-21 Thread Dave Airlie
This func ptr here is normally static allocation, but gsp r535 uses a dynamic pointer, so we need to handle that better. This fixes a crash with GSP when you use config=disp=0 to avoid disp problems. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/engine/disp/base.c | 6 -- 1

[PATCH 02/11] nouveau/gsp: drop some acpi related debug

2023-12-21 Thread Dave Airlie
These were leftover debug, if we need to bring them back do so for debugging later. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c | 7 --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 9 - 2 files changed, 16 deletions(-) diff --git a/drivers

[PATCH 01/11] nouveau/gsp: add three notifier callbacks that we see in normal operation (v2)

2023-12-21 Thread Dave Airlie
Add NULL callbacks for some things GSP calls that we don't handle, but know about so we avoid the logging. v2: Timur suggested allowing null fn. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

nouveau GSP fixes

2023-12-21 Thread Dave Airlie
This is a collection of nouveau debug prints, memory leak, a very annoying race condition causing system hangs with prime scenarios, and a fix from Lyude to get the panel on my laptop working. I'd like to get these into 6.7, Dave.

[git pull] drm fixes for 6.7-rc6

2023-12-14 Thread Dave Airlie
drm/amdgpu: warn when there are still mappings when a BO is destroyed v2 Dave Airlie (4): Merge tag 'mediatek-drm-fixes-20231211' of https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux into drm-fixes Merge tag 'drm-intel-fixes-2023-12-13' of git://anongit.freedesktop.org

Re: [PATCH] drm/nouveau: Fixup gk20a instobj hierarchy

2023-12-14 Thread Dave Airlie
On Thu, 14 Dec 2023 at 19:26, Jon Hunter wrote: > > > > On 08/12/2023 10:46, Thierry Reding wrote: > > From: Thierry Reding > > > > Commit 12c9b05da918 ("drm/nouveau/imem: support allocations not > > preserved across suspend") uses container_of() to cast from struct > > nvkm_memory to struct

[git pull] drm fixes for 6.7-rc5

2023-12-07 Thread Dave Airlie
(1): drm/amd/display: Use channel_width = 2 for vram table 3.0 Arnd Bergmann (1): drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS Dave Airlie (6): nouveau/tu102: flush all pdbs on vmm flush Merge tag 'drm-intel-fixes-2023-12-01-1' of git://anongit.freedesktop.org/drm

Re: [Bug 218221] Nouveau GSP fail on command cli:0xc1d0000

2023-12-05 Thread Dave Airlie
Yes I'd file that against mesa, I don't think we are quite there with zink support yet, trying to push on it a bit. On Tue, 5 Dec 2023 at 21:42, wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=218221 > > --- Comment #3 from marc barbier (mmarc...@gmail.com) --- > (In reply to airlied from

[PATCH] nouveau/gsp: drop some acpi related debug

2023-12-04 Thread Dave Airlie
These were leftover debug, if we need to bring them back do so for debugging later. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau

Re: [Bug 218221] New: Nouveau GSP fail on command cli:0xc1d0000

2023-12-04 Thread Dave Airlie
Can't remember my bz, but all those errors are fine, I've sent patches to clean them up so we don't report them in dmesg anymore. On Tue, 5 Dec 2023 at 01:12, wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=218221 > > Bug ID: 218221 >Summary: Nouveau GSP fail on

[PATCH] nouveau/gsp: drop the gsp failure message to a debug.

2023-12-04 Thread Dave Airlie
From: Dave Airlie These can happen in normal operations esp with auxch transactions. Gets rid of nouveau :01:00.0: gsp: cli:0xc1d2 obj:0x0073 ctrl cmd:0x00731341 failed: 0x in logs. Cc: Lyude Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c

[PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation (v2)

2023-12-04 Thread Dave Airlie
Add NULL callbacks for some things GSP calls that we don't handle, but know about so we avoid the logging. v2: Timur suggested allowing null fn. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

Re: [Nouveau] [PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation

2023-12-04 Thread Dave Airlie
On Tue, 5 Dec 2023 at 09:07, Timur Tabi wrote: > > On Tue, 2023-12-05 at 08:55 +1000, Dave Airlie wrote: > > +static int > > +r535_gsp_msg_ucode_libos_print(void *priv, u32 fn, void *repv, u32 repc) > > +{ > > + /* work out what we should do

[PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation

2023-12-04 Thread Dave Airlie
These seem to get called, but it doesn't look like we have to care too much at this point. Signed-off-by: Dave Airlie --- .../gpu/drm/nouveau/nvkm/subdev/gsp/r535.c| 24 ++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp

[git pull] drm fixes for 6.7-rc4

2023-11-30 Thread Dave Airlie
/r535: remove a stray unlock in r535_gsp_rpc_send() Dave Airlie (4): nouveau: find the smallest page allocation to cover a buffer alloc. Merge tag 'drm-intel-fixes-2023-11-30' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes Merge tag 'drm-misc-fixes-2023-11-29' of git

[PATCH] nouveau/tu102: flush all pdbs on vmm flush

2023-11-29 Thread Dave Airlie
From: Dave Airlie This is a hackaround a bug exposed with the GSP code, I'm not sure what it happening exactly, but it appears some of our flushes don't result in proper tlb invalidation for out BAR2 and we get a BAR2 fault from GSP and it all dies. Signed-off-by: Dave Airlie --- drivers/gpu

Re: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-11-28 Thread Dave Airlie
On Tue, 28 Nov 2023 at 23:07, Christian König wrote: > > Am 28.11.23 um 13:50 schrieb Weixi Zhu: > > The problem: > > > > Accelerator driver developers are forced to reinvent external MM subsystems > > case by case, because Linux core MM only considers host memory resources. > > These reinvented

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-27 Thread Dave Airlie
On Tue, 28 Nov 2023 at 06:48, Timur Tabi wrote: > > On Tue, Oct 31, 2023 at 12:20 AM Dave Airlie wrote: > > rpc->size = sizeof(*rpc); > > - rpc->numEntries = 1; > > - rpc->entries[0].nameOffset = offsetof(typeof(*rpc), entries[1]); >

[git pull] drm fixes for 6.7-rc3

2023-11-23 Thread Dave Airlie
Carpenter (1): drm/msm: remove unnecessary NULL check Dave Airlie (4): nouveau/gsp: allocate enough space for all channel ids. Merge tag 'drm-msm-fixes-2023-11-21' of https://gitlab.freedesktop.org/drm/msm into drm-fixes Merge tag 'drm-misc-fixes-2023-11-23' of git

Re: [GIT PULL] exynos-drm-fixes

2023-11-23 Thread Dave Airlie
On Tue, 21 Nov 2023 at 09:00, Inki Dae wrote: > > Hi Dave and Daniel, > >Two fixups - fixing a potential error pointer dereference and wrong >error checking. Hi Inki, This fails to build on arm32, and it seems one of the fixes is wrong [airlied@dreadlord drm-fixes]$ make ARCH=arm

Re: [PATCH drm-misc-next 2/2] drm/nouveau: enable dynamic job-flow control

2023-11-21 Thread Dave Airlie
On Tue, 14 Nov 2023 at 10:27, Danilo Krummrich wrote: > > Make use of the scheduler's credit limit and scheduler job's credit > count to account for the actual size of a job, such that we fill up the > ring efficiently. For the two: Reviewed-by: Dave Airlie > > Signed-off-by

Re: [PATCH drm-misc-next] drm/nouveau: use GPUVM common infrastructure

2023-11-21 Thread Dave Airlie
urrent brute force approach of iterating all mappings > in order to lock and validate the GPUVM's GEM objects. Hence, make us of > it. > > Signed-off-by: Danilo Krummrich Reviewed-by: Dave Airlie > --- > Originally, this patch was part of [1]. However, while applying the serie

Re: [PATCH] nouveau/gsp: fix getting max channel id for GSP

2023-11-21 Thread Dave Airlie
Self NAK, this isn't sufficient to fix events. On Mon, 20 Nov 2023 at 12:07, Dave Airlie wrote: > > From: Dave Airlie > > The fence code uses the total number of channel ids to allocate a > bunch of memory for fencing. This is probably not the best way to > do this, but it's

[PATCH] nouveau/gsp: allocate enough space for all channel ids.

2023-11-21 Thread Dave Airlie
From: Dave Airlie This probably isn't the ideal fix, but we ended up using chids sparsely, and lots of things rely on indexing into the full range, so just allocate the full range up front. The GSP code fixes 8 channels into a userd page, but we end up using a single userd page per channel so

[PATCH] nouveau/gsp: fix getting max channel id for GSP

2023-11-19 Thread Dave Airlie
From: Dave Airlie The fence code uses the total number of channel ids to allocate a bunch of memory for fencing. This is probably not the best way to do this, but it's hard to fix right now. The GSP code realises it can fit 8 channels into a USERD page, so it claims it can support 256 channels

Re: Radeon regression in 6.6 kernel

2023-11-18 Thread Dave Airlie
> > On 12.11.23 01:46, Phillip Susi wrote: > > I had been testing some things on a post 6.6-rc5 kernel for a week or > > two and then when I pulled to a post 6.6 release kernel, I found that > > system suspend was broken. It seems that the radeon driver failed to > > suspend, leaving the display

Re: [Nouveau] [PATCH] nouveau: don't fail driver load if no display hw present.

2023-11-15 Thread Dave Airlie
On Wed, 15 Nov 2023 at 05:54, Danilo Krummrich wrote: > > On 11/5/23 21:37, Dave Airlie wrote: > > From: Dave Airlie > > > > If we get back ENODEV don't fail load. > > Maybe worth to note why this is OK in this case, might not be obvious > to future readers of t

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-07 Thread Dave Airlie
On Wed, 8 Nov 2023 at 04:51, Timur Tabi wrote: > > On Tue, 2023-10-31 at 15:18 +1000, Dave Airlie wrote: > > + strings = (char *)>entries[NV_GSP_REG_NUM_ENTRIES]; > > > I get a UBSAN index-out-of-bounds error on boot at this line. > > [ 17.765746] nouveau 0

[PATCH] nouveau: use an rwlock for the event lock.

2023-11-06 Thread Dave Airlie
From: Dave Airlie This allows it to break the following circular locking dependency. Aug 10 07:01:29 dg1test kernel: == Aug 10 07:01:29 dg1test kernel: WARNING: possible circular locking dependency detected Aug 10 07:01:29 dg1test kernel

[git pull] drm next + fixes for 6.7-rc1

2023-11-06 Thread Dave Airlie
Selvam (1): drm/amdgpu: Fix the vram base start address Candice Li (1): drm/amdgpu: Drop deferred error in uncorrectable error check Dave Airlie (3): Merge tag 'shmob-drm-atomic-dt-tag2' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers into drm-next

[PATCH] nouveau: don't fail driver load if no display hw present.

2023-11-05 Thread Dave Airlie
From: Dave Airlie If we get back ENODEV don't fail load. Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM") Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/270 Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_display.c | 5 + 1 file

Re: [PATCH] drm/nouveau/gr/gf100-: unlock mutex failing to create golden context

2023-11-02 Thread Dave Airlie
On Fri, 3 Nov 2023 at 12:41, Danilo Krummrich wrote: > > Do not return from gf100_gr_chan_new() with fecs mutex held when failing > to create the golden context image. Reviewed-by: Dave Airlie > > Cc: # v6.2+ > Fixes: ca081fff6ecc ("drm/nouveau/gr/gf100-: generat

[git pull] drm nouveau support for GSP firmware - optional

2023-11-02 Thread Dave Airlie
drm/nouveau/ofa/r535: initial support Dave Airlie (5): nouveau: fix r535 build on 32-bit arm. nouveau/disp: fix post-gsp build on 32-bit arm. nouveau/gsp: move to 535.113.01 nouveau/gsp: fix message signature. nouveau/gsp: add some basic registry entries

Re: [PATCH drm-misc-next v8 12/12] drm/nouveau: use GPUVM common infrastructure

2023-11-01 Thread Dave Airlie
urrent brute force approach of iterating all mappings > in order to lock and validate the GPUVM's GEM objects. Hence, make us of > it. > > Signed-off-by: Danilo Krummrich Reviewed-by: Dave Airlie Dave.

Re: [PATCH drm-misc-next v8 04/12] drm/nouveau: make use of drm_gpuvm_range_valid()

2023-11-01 Thread Dave Airlie
On Thu, 2 Nov 2023 at 09:31, Danilo Krummrich wrote: > > Use drm_gpuvm_range_valid() in order to validate userspace requests. > > Signed-off-by: Danilo Krummrich Reviewed-by: Dave Airlie

Re: [PATCH drm-misc-next v8 08/12] drm/nouveau: separately allocate struct nouveau_uvmm

2023-11-01 Thread Dave Airlie
uvmm_ioctl_vm_init() and perform some minor cleanups. > > Signed-off-by: Danilo Krummrich Reviewed-by: Dave Airlie

Re: [PATCH 2/3] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-11-01 Thread Dave Airlie
> > Well, to make it clear once more: Signaling a dma_fence from the > destructor of a reference counted object is very problematic! This will > be rejected no matter if you do that in C or in Rust. > > What we can do is to make it safe in the sense that you don't access > freed up memory by using

Re: [PATCH] drm/qxl: prevent memory leak

2023-10-31 Thread Dave Airlie
eads after qxl resume, > it will cause memory leak. > > Signed-off-by: Zongmin Zhou Sorry for nobody picking up on this, qxl isn't really well staffed, Reviewed-by: Dave Airlie Could one of the misc maintainers pick this up? Dave.

Re: [PATCH] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-31 Thread Dave Airlie
On Wed, 1 Nov 2023 at 11:46, Luben Tuikov wrote: > > On 2023-10-31 09:33, Danilo Krummrich wrote: > > > > On 10/26/23 19:25, Luben Tuikov wrote: > >> On 2023-10-26 12:39, Danilo Krummrich wrote: > >>> On 10/23/23 05:22, Luben Tuikov wrote: > The GPU scheduler has now a variable number of

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-10-31 Thread Dave Airlie
On Wed, 1 Nov 2023 at 01:53, Timur Tabi wrote: > > On Tue, Oct 31, 2023 at 12:20 AM Dave Airlie wrote: > > +#define NV_GSP_REG_NUM_ENTRIES 2 > > + > > +static const struct nv_gsp_registry_entries > > r535_registry_entries[NV_GSP_REG_NUM_ENTRIES] = { > >

Re: Build broken in drm-tip

2023-10-30 Thread Dave Airlie
On Tue, 31 Oct 2023 at 15:23, Dave Airlie wrote: > > On Tue, 31 Oct 2023 at 15:09, Borah, Chaitanya Kumar > wrote: > > > > Hello Mario, > > > > This is Chaitanya from the Linux graphics team in Intel. > > > > We are seeing a build issue in drm-tip[1]

Re: Build broken in drm-tip

2023-10-30 Thread Dave Airlie
On Tue, 31 Oct 2023 at 15:09, Borah, Chaitanya Kumar wrote: > > Hello Mario, > > This is Chaitanya from the Linux graphics team in Intel. > > We are seeing a build issue in drm-tip[1] Sorry that was a mismerge from me, let me go fix it for summon someone else. Dave.

[PATCH 2/3] nouveau/gsp: fix message signature.

2023-10-30 Thread Dave Airlie
From: Dave Airlie This original one was backwards, compared to traces from nvidia driver. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers

[PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-10-30 Thread Dave Airlie
From: Dave Airlie The nvidia driver sets these two basic registry entries always, so copy it. Signed-off-by: Dave Airlie --- .../gpu/drm/nouveau/nvkm/subdev/gsp/r535.c| 45 ++- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm

[PATCH 1/3] nouveau/gsp: move to 535.113.01

2023-10-30 Thread Dave Airlie
From: Dave Airlie This moves the initial effort to the latest 535 firmware. The gsp msg structs have changed, and the message passing also. The wpr also seems to have some struct changes. This version of the firmware will be what we are stuck on for a while, until we can refactor the driver

nouveau/gsp: move to latest fw and small fixes

2023-10-30 Thread Dave Airlie
This moves Ben's work to the latest GSP stable firmware 535.113.01. We will be stuck on this for a while. There is also a fix for a message signature, and additions of two registry entries, which seem to help recover from crashes. Dave.

[PATCH 1/2] nouveau: fix r535 build on 32-bit arm.

2023-10-29 Thread Dave Airlie
From: Dave Airlie This needs the proper division macros. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/r535.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/r535.c b/drivers/gpu/drm/nouveau/nvkm/engine

[PATCH 2/2] nouveau/disp: fix post-gsp build on 32-bit arm.

2023-10-29 Thread Dave Airlie
From: Dave Airlie This converts a bunch of divides into the proper macros. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers

[git pull] drm fixes for 6.6 final

2023-10-27 Thread Dave Airlie
duplicate BOs again drm/amdkfd: reserve a fence slot while locking the BO Dave Airlie (3): Merge tag 'drm-misc-fixes-2023-10-26' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'drm-intel-fixes-2023-10-26' of git://anongit.freedesktop.org/drm/drm-intel into drm

pull for vmemdup-user-array into drm-next

2023-10-23 Thread Dave Airlie
topic/vmemdup-user-array-2023-10-24-1: vmemdup-user-array API and changes with it. This is just a process PR to merge the topic branch into drm-next, this contains some core kernel and drm changes. Signed-off-by: Dave Airlie The following changes since commit

[git pull] drm fixes for 6.6-rc7

2023-10-19 Thread Dave Airlie
: - Fix possible NULL-ptr deref in cleanup mediatek: - Correctly free sg_table in gem prime vmap Chen-Yu Tsai (1): drm/mediatek: Correctly free sg_table in gem prime vmap Dave Airlie (4): Merge tag 'amd-drm-fixes-6.6

[git pull] drm fixes for 6.6-rc6

2023-10-12 Thread Dave Airlie
missing NULL check Dan Carpenter (1): drm/msm/dsi: fix irq_of_parse_and_map() error checking Daniel Miess (1): drm/amd/display: Don't set dpms_off for seamless boot Dave Airlie (3): Merge tag 'drm-misc-fixes-2023-10-12' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-10-12 Thread Dave Airlie
On Wed, 11 Oct 2023 at 17:07, Christian König wrote: > > Am 10.10.23 um 22:23 schrieb Dave Airlie: > >> I think we're then optimizing for different scenarios. Our compute > >> driver will use mostly external objects only, and if shared, I don't > >> forsee them

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-10-10 Thread Dave Airlie
> I think we're then optimizing for different scenarios. Our compute > driver will use mostly external objects only, and if shared, I don't > forsee them bound to many VMs. What saves us currently here is that in > compute mode we only really traverse the extobj list after a preempt > fence wait,

[git pull] drm fixes for 6.6-rc5

2023-10-05 Thread Dave Airlie
on each GT Danilo Krummrich (3): drm/nouveau: chan: use struct nvif_mclass drm/nouveau: chan: use channel class definitions drm/nouveau: exec: report max pushs through getparam Dave Airlie (3): Merge tag 'drm-intel-fixes-2023-10-05' of git://anongit.freedesktop.org/drm/drm

[git pull] drm fixes for 6.6-rc4

2023-09-28 Thread Dave Airlie
Danilo Krummrich (1): MAINTAINERS: update nouveau maintainers Dave Airlie (2): Merge tag 'drm-misc-fixes-2023-09-28' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'drm-intel-fixes-2023-09-28' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes

Re: [PATCH 3/3] drm/nouveau: exec: report max pushs through getparam

2023-09-27 Thread Dave Airlie
> > There's a bunch of nouveau kernel details I don't know here but the > interface looks good and I prefer it to a #define in the header. > > Acked-by: Faith Ekstrand For the series Reviewed-by: Dave Airlie we should probably land this in drm-misc-fixes, since it would be

Re: [PATCH] drm/gpuvm: doc: fix filename references

2023-09-26 Thread Dave Airlie
> Hence, fix up those filenames. Acked-by: Dave Airlie > > Fixes: f72c2db47080 ("drm/gpuvm: rename struct drm_gpuva_manager to struct > drm_gpuvm") > Reported-by: Stephen Rothwell > Closes: > https://lore.kernel.org/dri-devel/20230926150725.4cca5..

Re: [PATCH drm-misc-next v4 3/8] drm/nouveau: uvmm: rename 'umgr' to 'base'

2023-09-24 Thread Dave Airlie
On Thu, 21 Sept 2023 at 00:44, Danilo Krummrich wrote: > > Rename struct drm_gpuvm within struct nouveau_uvmm from 'umgr' to base. > > Signed-off-by: Danilo Krummrich Reviewed-by: Dave Airlie > --- > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- > drivers/gpu/drm/n

Re: [PATCH drm-misc-next v4 2/8] drm/gpuvm: allow building as module

2023-09-24 Thread Dave Airlie
ewed-by: Christian König > Signed-off-by: Danilo Krummrich Reviewed-by: Dave Airlie > --- > drivers/gpu/drm/Kconfig | 7 +++ > drivers/gpu/drm/Makefile| 2 +- > drivers/gpu/drm/drm_gpuvm.c | 3 +++ > drivers/gpu/drm/nouveau/Kconfig | 1 + >

Re: [PATCH drm-misc-next v4 1/8] drm/gpuvm: rename struct drm_gpuva_manager to struct drm_gpuvm

2023-09-24 Thread Dave Airlie
rse, but from the handling I > suggest to have this patch separately pushed to drm-misc-next. > > Feel free to add my Acked-by for pushing this. > Acked-by: Dave Airlie > Regards, > Christian. > > > --- > > drivers/gpu/drm/Makefile

Re: [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-09-24 Thread Dave Airlie
> +struct drm_pvr_dev_query_gpu_info { > + /** > +* @gpu_id: GPU identifier. > +* > +* For all currently supported GPUs this is the BVNC encoded as a > 64-bit > +* value as follows: > +* > +*++++---+ > +

drm fixes for 6.6-rc3 (resend with one more patch)

2023-09-22 Thread Dave Airlie
: Prevent error pointer dereference Danilo Krummrich (2): drm/nouveau: fence: fix type cast warning in nouveau_fence_emit() drm/nouveau: sched: fix leaking memory of timedout job Dave Airlie (4): nouveau/u_memcpya: use vmemdup_user Merge tag 'drm-misc-fixes-2023-09-21

[git pull] drm fixes for 6.6-rc3

2023-09-22 Thread Dave Airlie
(2): drm/nouveau: fence: fix type cast warning in nouveau_fence_emit() drm/nouveau: sched: fix leaking memory of timedout job Dave Airlie (4): nouveau/u_memcpya: use vmemdup_user Merge tag 'drm-misc-fixes-2023-09-21' of git://anongit.freedesktop.org/drm/drm-misc into drm

Re: [PATCH] drm/nouveau: sched: fix leaking memory of timedout job

2023-09-18 Thread Dave Airlie
own the channel. Reviewed-by: Dave Airlie > > Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI") > Signed-off-by: Danilo Krummrich > --- > drivers/gpu/drm/nouveau/nouveau_exec.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_sched.c | 12 +--- >

Re: [Nouveau] [PATCH] drm/nouveau: fence: fix type cast warning in nouveau_fence_emit()

2023-09-18 Thread Dave Airlie
; @@ got struct nouveau_channel [noderef] __rcu *channel Reviewed-by: Dave Airlie > > We're just about to emit the fence, there is nothing to protect against > yet, hence it is safe to just cast __rcu away. > > Reported-by: kernel test robot > Closes: > https://lore.kern

Re: [Nouveau] Stepping away.

2023-09-18 Thread Dave Airlie
> > As you may have gathered from the MAINTAINERS patch I just sent out, I > have resigned from my position at Red Hat, and will be stepping back > from nouveau development. > > This is a personal decision that I've been mulling over for a number > of years now, and I feel that with GSP-RM greatly

[git pull] drm fixes for 6.6-rc2

2023-09-14 Thread Dave Airlie
Merge tag 'drm-misc-fixes-2023-09-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Dave Airlie (3): Merge tag 'amd-drm-fixes-6.6-2023-09-13' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes Merge tag 'drm-intel-fixes-2023-09-14' of git://anongit.freedeskt

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-13 Thread Dave Airlie
On Wed, 13 Sept 2023 at 17:03, Boris Brezillon wrote: > > On Tue, 12 Sep 2023 18:20:32 +0200 > Thomas Hellström wrote: > > > > +/** > > > + * get_next_vm_bo_from_list() - get the next vm_bo element > > > + * @__gpuvm: The GPU VM > > > + * @__list_name: The name of the list we're iterating on > >

Re: [PATCH v2 0/5] Introduce new wrappers to copy user-arrays

2023-09-11 Thread Dave Airlie
On Tue, 12 Sept 2023 at 11:27, Kees Cook wrote: > > On September 8, 2023 12:59:39 PM PDT, Philipp Stanner > wrote: > >Hi! > > > >David Airlie suggested that we could implement new wrappers around > >(v)memdup_user() for duplicating user arrays. > > > >This small patch series first implements

[git pull] drm fixes for 6.6-rc1

2023-09-07 Thread Dave Airlie
state after emit Dave Airlie (3): Merge tag 'drm-misc-next-fixes-2023-09-01' of git://anongit.freedesktop.org/drm/drm-misc into drm-next Merge tag 'drm-intel-next-fixes-2023-08-31' of git://anongit.freedesktop.org/drm/drm-intel into drm-next Merge tag 'amd-drm-fixes-6.6-2023-09-06

[git pull] drm CI integration

2023-08-30 Thread Dave Airlie
Hey Linus, This is a PR to add drm-ci support files to the upstream tree. This is a bunch of ci integration for the freedesktop gitlab instance where we currently do upstream userspace testing on diverse sets of GPU hardware. From my perspective I think it's an experiment worth going with and

Re: [PATCH drm-misc-next] drm/nouveau: fence: fix undefined fence state after emit

2023-08-29 Thread Dave Airlie
ing up allocation end emit wasn't a good idea in the first place. > Hence, limit it to the places where we actually need to pre-allocate. > > Fixes: 7f2a0b50b2b2 ("drm/nouveau: fence: separate fence alloc and emit") > Signed-off-by: Danilo Krummrich nice find, Reviewed-by: D

[git pull] drm fixes for 6.5 final

2023-08-24 Thread Dave Airlie
: Fix the DP DSC Receiver cap size Anshuman Gupta (1): drm/i915/dgfx: Enable d3cold at s2idle Dave Airlie (2): Merge tag 'drm-misc-fixes-2023-08-24' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'drm-intel-fixes-2023-08-24' of git://anongit.freedesktop.org

Re: [PATCH drm-misc-next] drm/gpuva_mgr: remove unused prev pointer in __drm_gpuva_sm_map()

2023-08-23 Thread Dave Airlie
o keep track of GPUs VA mappings") > Signed-off-by: Danilo Krummrich Reviewed-by: Dave Airlie > --- > drivers/gpu/drm/drm_gpuva_mgr.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gpuva_mgr.c b/drivers/gpu/drm/drm_

Re: [PATCH drm-misc-next] drm/nouveau: uvmm: fix unset region pointer on remap

2023-08-20 Thread Dave Airlie
Reviewed-by: Dave Airlie On Mon, 21 Aug 2023 at 08:29, Danilo Krummrich wrote: > > Transfer the region pointer of a uvma to the new uvma(s) on re-map to > prevent potential shader faults when the re-mapped uvma(s) are unmapped. > > Signed-off-by: Danilo Krummrich > ---

Re: Implement svm without BO concept in xe driver

2023-08-20 Thread Dave Airlie
On Thu, 17 Aug 2023 at 12:13, Zeng, Oak wrote: > > > -Original Message- > > From: Dave Airlie > > Sent: August 16, 2023 6:52 PM > > To: Felix Kuehling > > Cc: Zeng, Oak ; Christian König > > ; Thomas Hellström > > ; Brost, Ma

[git pull] drm fixes for 6.5-rc7

2023-08-17 Thread Dave Airlie
quot; Asad Kamal (1): drm/amd/pm: Update pci link width for smu v13.0.6 Dan Carpenter (1): accel/qaic: Clean up integer overflow checking in map_user_pages() Dave Airlie (3): Merge tag 'drm-intel-fixes-2023-08-17' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes

Re: Implement svm without BO concept in xe driver

2023-08-16 Thread Dave Airlie
On Thu, 17 Aug 2023 at 08:15, Felix Kuehling wrote: > > On 2023-08-16 13:30, Zeng, Oak wrote: > > I spoke with Thomas. We discussed two approaches: > > > > 1) make ttm_resource a central place for vram management functions such as > > eviction, cgroup memory accounting. Both the BO-based driver

Re: [PULL for v6.6] drm-misc-next

2023-08-15 Thread Dave Airlie
> > Otherwise, there should be something like a drm-ci tree, from which you > > can fetch the changes directly. > > I asked for a pull request so that I could also merge it to msm-next > so that I can do CI this cycle. (Unlike the earlier out-of-tree > version of the drm/ci yml, this version

[git pull] drm fixes for 6.4-rc6

2023-08-11 Thread Dave Airlie
ann (1): drm/nouveau: remove unused tu102_gr_load() function Boris Brezillon (1): drm/shmem-helper: Reset vma->vm_ops before calling dma_buf_mmap() Daniel Stone (1): drm/rockchip: Don't spam logs in atomic check Dave Airlie (2): Merge tag 'drm-misc-fixes-2023-08-1

[PATCH] nouveau: find the smallest page allocation to cover a buffer alloc.

2023-08-10 Thread Dave Airlie
From: Dave Airlie With the new uapi we don't have the comp flags on the allocation, so we shouldn't be using the first size that works, we should be iterating until we get the correct one. This reduces allocations from 2MB to 64k in lots of places. Fixes dEQP

[PATCH] nouveau/u_memcpya: use vmemdup_user

2023-08-10 Thread Dave Airlie
From: Dave Airlie I think there are limit checks in places for most things but the new api wants to not have them. Add a limit check and use the vmemdup_user helper instead. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_drv.h | 19 +-- 1 file changed, 5

[PATCH] nouveau/u_memcpya: use kvmalloc_array.

2023-08-10 Thread Dave Airlie
From: Dave Airlie I think there are limit checks in places for most things but the new api wants to not have them. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_drv.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h

Re: [PATCH drm-misc-next 0/5] Nouveau VM_BIND uAPI Fixes

2023-08-07 Thread Dave Airlie
For the series: Reviewed-by: Dave Airlie On Tue, 8 Aug 2023 at 02:32, Danilo Krummrich wrote: > > The patch series provides a few fixes for the recently merged VM_BIND uAPI > mostly addressing a couple of warnings. > > It also contains one patch to slightly reduce the m

[git pull] drm fixes for 6.5-rc5

2023-08-03 Thread Dave Airlie
drm/i915/gt: Rename flags with bit_group_X according to the datasheet drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control and in the CS drm/i915/gt: Support aux invalidation on all engines Dave Airlie (2): Merge tag 'drm-misc-fixes-2023-08-03' of ssh

Re: [PATCH drm-misc-next v9 00/11] Nouveau VM_BIND UAPI & DRM GPUVA Manager (merged)

2023-08-03 Thread Dave Airlie
about things you wrote 10 years ago. Otherwise for the series: Reviewed-by: Dave Airlie Dave.

[PATCH] drm/nouveau: fixup the uapi header file.

2023-08-03 Thread Dave Airlie
From: Dave Airlie nouveau > 10 years ago had a plan for new multiplexer inside a multiplexer API using nvif. It never fully reached fruition, fast forward 10 years, and the new vulkan driver is avoiding libdrm and calling ioctls, and these 3 ioctls, getparam, channel alloc + free don't s

[PATCH] drm/nouveau: fixup the uapi header file.

2023-07-31 Thread Dave Airlie
From: Dave Airlie nouveau > 10 years ago had a plan for new multiplexer inside a multiplexer API using nvif. It never fully reached fruition, fast forward 10 years, and the new vulkan driver is avoiding libdrm and calling ioctls, and these 3 ioctls, getparam, channel alloc + free don't s

[git pull] drm fixes for 6.5-rc4

2023-07-27 Thread Dave Airlie
in dm_handle_mst_sideband_msg_ready_event() Dave Airlie (4): Merge tag 'drm-misc-fixes-2023-07-27' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'drm-intel-fixes-2023-07-27' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes Merge tag 'amd-drm-fixes

Re: [PATCH drm-misc-next v8 11/12] drm/nouveau: implement new VM_BIND uAPI

2023-07-23 Thread Dave Airlie
On Sun, 23 Jul 2023 at 01:12, Faith Ekstrand wrote: > > On Wed, Jul 19, 2023 at 7:15 PM Danilo Krummrich wrote: >> >> This commit provides the implementation for the new uapi motivated by the >> Vulkan API. It allows user mode drivers (UMDs) to: >> >> 1) Initialize a GPU virtual address (VA)

[git pull] drm fixes for 6.5-rc3

2023-07-20 Thread Dave Airlie
Miess (1): drm/amd/display: Prevent vtotal from being set to 0 Dave Airlie (3): Merge tag 'drm-misc-fixes-2023-07-20' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Merge tag 'drm-intel-fixes-2023-07-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes

[git pull] drm fixes for 6.5-rc2

2023-07-13 Thread Dave Airlie
(1): dma-buf: fix an error pointer vs NULL bug Dave Airlie (3): Merge tag 'drm-misc-fixes-2023-07-13' of ssh://git.freedesktop.org/git/drm/drm-misc into drm-fixes Merge tag 'drm-intel-fixes-2023-07-13' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes Merge tag 'amd-

Re: [PATCH] drm/nouveau/acr: Abort loading ACR if no firmware was found

2023-07-12 Thread Dave Airlie
m/subdev/acr/base.c > > @@ -224,7 +224,7 @@ nvkm_acr_oneinit(struct nvkm_subdev *subdev) > > u64 falcons; > > int ret, i; > > > > - if (list_empty(>hsfw)) { > > + if (list_empty(>hsfw) || !acr->func->wpr_layout) { > > Now t

[git pull] drm fixes for 6.5-rc1

2023-07-06 Thread Dave Airlie
"drm/amd/display: Move DCN314 DOMAIN power control to DMCUB" Partially revert "drm/amd/display: Fix possible underflow for displays with large vblank" Dave Airlie (5): Merge tag 'drm-misc-next-fixes-2023-06-29' of git://anongit.freedesktop.org/drm/drm-misc into drm-

Re: [PATCH] drm/vmwgfx: Fix shader stage validation

2023-07-04 Thread Dave Airlie
What tree has/is this landing via, not seeing it upstream yet. Dave. On Sat, 17 Jun 2023 at 20:25, Martin Krastev (VMware) wrote: > > From: Martin Krastev > > > Looks good! > > > Reviewed-by: Martin Krastev > > > Regards, > > Martin > > > On 16.06.23 г. 22:09 ч., Zack Rusin wrote: > > From:

[PATCH 1/2] docs: module: start adding some docs for MODULE_ macros.

2023-07-03 Thread Dave Airlie
From: Dave Airlie In order to add a new macro, Luis suggested converting some docs for the new ones. This tries to keep exisiting module_init, module_exit where they are, and adds the new docs to the module section. Cc: linux-...@vger.kernel.org Cc: Jonathan Corbet Cc: Luis Chamberlain Cc

[PATCH 2/2] modules/firmware: add a new option to denote a firmware group to choose one.

2023-07-03 Thread Dave Airlie
From: Dave Airlie This adds two tags that will go into the module info. The first denotes a group of firmwares, when that tag is present all MODULE_FIRMWARE lines between the tags will be ignored by new versions of dracut. The second makes an explicitly ordered group of firmwares to search

modules: firmware groups attempt two

2023-07-03 Thread Dave Airlie
This is a second attempt at firmware grouping so we can have dracut only pull one firmware into the initramfs instead of a bunch of legacy ones. v1 got derailed when it was pointed out that ordering isn't consistent in modinfo with C to sections, so that plan no longer was feasible. This was the

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-26 Thread Dave Airlie
> > As pointed out by Christian, this would optimize the "get all mappings > > backed by a specific BO from a given VM" use case. > > > > The question for me is, do other drivers than amdgpu commonly need this? > > I have no idea. > > > > > And what does amdgpu need this for? Maybe amdgpu does

<    1   2   3   4   5   6   7   8   9   10   >