Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
[1]
Signed-off-by: Devarsh Thakkar
---
V9->V13: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1] :
Link: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 [1]
Signed-off-by: Devarsh Thakkar
Acked-by: Andy
-off-by: Daniel Latypov
Reviewed-by: David Gow
Reviewed-by: Andy Shevchenko
[devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to
GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v11:
* Add Reviewed-by tag
Changes since v10:
* Include headers per IWYU principle
Add documentation for rounding, scaling, absolute value and 32-bit division
related macros and functions exported by math.h header file.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Andy Shevchenko
---
V13: No change
V12: Add Reviewed-by
V11: Fix title for math function header
V10: Patch
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
Acked-by: Andy
ttps://lore.kernel.org/all/20240215134641.3381478-1-devar...@ti.com/
V4: https://lore.kernel.org/all/20240205114239.924697-1-devar...@ti.com/
V3: https://lore.kernel.org/all/20230816152210.4080779-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latyp
Hi Sebastian
Thanks for the update.
On 06/06/24 17:14, Sebastian Fricke wrote:
> Hey,
>
> On 04.06.2024 16:23, Devarsh Thakkar wrote:
>> If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up
>> (V4L2_SEL_FLAG_GE) are specified by the user, then round t
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
[1]
Signed-off-by: Devarsh Thakkar
---
V12: No change
V11: No change
V10: No change
V9: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed,
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1] :
Link: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 [1]
Signed-off-by: Devarsh Thakkar
Acked-by: Andy
-off-by: Daniel Latypov
Reviewed-by: David Gow
Reviewed-by: Andy Shevchenko
[devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to
GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v11:
* Add Reviewed-by tag
Changes since v10:
* Include headers per IWYU principle
Add documentation for rounding, scaling, absolute value and 32-bit division
related macros and functions exported by math.h header file.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Andy Shevchenko
---
V12: Add Reviewed-by
V11: Fix title for math function header
V10: Patch introduced
V1->
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
Acked-by: Andy
: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latypov (1):
lib: add basic KUnit test for lib/math
Devarsh Thakkar (12):
media: dt-bindings: Add Imagination E5010 JPEG Encoder
media: imagination: Add E5010 JPEG Encoder driver
media: v4l2-jpeg: Ex
On 01/06/24 00:01, Randy Dunlap wrote:
> Hi,
>
> On 5/31/24 10:12 AM, Devarsh Thakkar wrote:
>> Add documentation for rounding, scaling, absolute value and difference,
>> 32-bit division related macros and functions exported by math.h header
>> file.
>>
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
Signed-off-by: Devarsh Thakkar
---
V11: No change
V10: No change
V9: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+)
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1].
[1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876
Signed-off-by: Devarsh Thakkar
---
V1->V11 (No cha
-off-by: Daniel Latypov
Reviewed-by: David Gow
[devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to
GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v10:
* Include headers per IWYU principle and add module description
Changes since v9:
* Added Kconfig dependency
Add documentation for rounding, scaling, absolute value and difference,
32-bit division related macros and functions exported by math.h header
file.
Signed-off-by: Devarsh Thakkar
---
V11: Fix title for math function header
V10: Patch introduced
V1->V9 (No change)
---
Documentation/core-
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
---
NOTE: This patch
-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latypov (1):
lib: add basic KUnit test for lib/math
Devarsh Thakkar (10):
media: dt-bindings: Add Imagination E5010 JPEG Encoder
media: imagination: Add E5010 JPEG Encoder driver
media: v4l2-jpeg: Expor
Hi Randy,
Thanks for the review.
On 31/05/24 04:14, Randy Dunlap wrote:
>
>
> On 5/30/24 10:17 AM, Devarsh Thakkar wrote:
>> Add documentation for rounding, scaling, absolute value and difference,
>> 32-bit division related macros and functions exported by math.h header
On 31/05/24 00:51, Andy Shevchenko wrote:
> On Thu, May 30, 2024 at 10:47:40PM +0530, Devarsh Thakkar wrote:
>> Add documentation for rounding, scaling, absolute value and difference,
>> 32-bit division related macros and functions exported by math.h header
>> file.
>
On 31/05/24 00:53, Andy Shevchenko wrote:
> On Thu, May 30, 2024 at 10:48:10PM +0530, Devarsh Thakkar wrote:
>> From: Daniel Latypov
>>
>> Add basic test coverage for files that don't require any config options:
>> * part of math.h (what seem to be the most commo
Hi Andy,
Thanks for the review.
On 31/05/24 00:49, Andy Shevchenko wrote:
> On Thu, May 30, 2024 at 10:42:25PM +0530, Devarsh Thakkar wrote:
>> Add below rounding related macros:
>>
>> round_closest_up(x, y) : Rounds x to closest multiple of y where y is a
>> po
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
Signed-off-by: Devarsh Thakkar
---
V10: No change
V9: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1].
[1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876
Signed-off-by: Devarsh Thakkar
---
V1->V10 (No cha
-off-by: Daniel Latypov
Reviewed-by: David Gow
[devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to
GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v9:
* Added Kconfig dependency for KUNIT
Changes since v8:
* Remove unrequired header file linux/kernel.h
Changes
Add documentation for rounding, scaling, absolute value and difference,
32-bit division related macros and functions exported by math.h header
file.
Signed-off-by: Devarsh Thakkar
---
V1->V9 (No change)
V10: Patch introduced
---
Documentation/core-api/kernel-api.rst | 6 ++
1 file chan
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
---
NOTE: This patch
ar...@ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latypov (1):
lib: add basic KUnit test for lib/math
Devarsh Thakkar (10):
media: dt-bindings: Add Imagination E5010 JPEG Encoder
media: imagination: Add E5010 JPEG Encoder driver
media: v4l2-jpeg: Exp
Hi Javier, Maxime, Daniel,
Sorry for the delay. Please find response inline.
On 16/05/24 18:21, Daniel Vetter wrote:
> On Wed, May 15, 2024 at 04:45:09PM +0200, Javier Martinez Canillas wrote:
>> Devarsh Thakkar writes:
[..]
>>
>> If I understand you correctly, for now t
On 28/05/24 02:08, Andy Shevchenko wrote:
> On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote:
>> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote:
>
> ...
>
>>> +MODULE_LICENSE("GPL");
>>
>> modpost
Hi Andy,
Thanks for the review.
On 28/05/24 02:07, Andy Shevchenko wrote:
[..]
>> +#include
>> +#include
>> +#include
>
> + math.h (where abs()/DIV_ROUND_*()/etc come from?)
> I believe I mentioned that.
>
I did compile and test this, so math.h was indirectly getting included via
some
Hi Andy,
Thanks for the review.
On 28/05/24 02:02, Andy Shevchenko wrote:
> On Sun, May 26, 2024 at 11:38:56PM +0530, Devarsh Thakkar wrote:
...
>> +/**
>> + * round_closest_up - round closest to be multiple of specified value
>> (which is
>> + *
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
Signed-off-by: Devarsh Thakkar
---
V9: No change
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1].
[1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876
Signed-off-by: Devarsh Thakkar
---
V1->V9 (No cha
-off-by: Daniel Latypov
Reviewed-by: David Gow
[devarsht: Rebase to 6.9, remove kernel.h and change license to GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v8:
* Remove unrequired header file linux/kernel.h
Changes since v7:
* Rebase to linux-next, change license to GPL as suggested
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
---
NOTE: This patch
114239.924697-1-devar...@ti.com/
V3: https://lore.kernel.org/all/20230816152210.4080779-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latypov (1):
lib: add basic KUnit test for lib/math
Devarsh Thakkar (9):
media: dt-bindings: Add Imagination E5
On 20/05/24 17:52, Andy Shevchenko wrote:
> On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote:
>> On 18/05/24 01:44, Andy Shevchenko wrote:
>>> On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote:
>
> [..]
>
[..]
> Yes, and on
Hi Andy, Daniel,
On 18/05/24 01:44, Andy Shevchenko wrote:
> On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote:
[..]
>
>> [devarsht: Rebase to 6.9 and change license to GPL]
>
> I'm not sure that you may change license. It needs the author's confirmation.
Use generic macro round_closest_up() for rounding closest to specified
value instead of using local macro round_closest().
There is no change from functionality point of view as round_closest_up()
is functionally same as the previously used local macro round_closest().
Signed-off-by: Devarsh
ection.rst
Signed-off-by: Devarsh Thakkar
---
V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platfor
Add tests for round_closest_up/down and roundclosest macros which round
to nearest multiple of specified argument. These are tested with kunit
tool as shared here [1].
[1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876
Signed-off-by: Devarsh Thakkar
---
V1->V8 (No cha
-off-by: Daniel Latypov
Reviewed-by: David Gow
[devarsht: Rebase to 6.9 and change license to GPL]
Signed-off-by: Devarsh Thakkar
---
Changes since v6:
* Rebase to linux-next, change license to GPL as suggested by checkpatch.
Changes since v5:
* add in test cases for roundup/rounddown
* address
* round_closest_up(15, 4) = 16
* round_closest_up(14, 4) = 16
* round_closest_down(17, 4) = 16
* round_closest_down(15, 4) = 16
* round_closest_down(14, 4) = 12
* roundclosest(21, 5) = 20
* roundclosest(19, 5) = 20
* roundclosest(17, 5) = 15
Signed-off-by: Devarsh Thakkar
---
NOTE: This patch
rnel.org/all/20240205114239.924697-1-devar...@ti.com/
V3: https://lore.kernel.org/all/20230816152210.4080779-1-devar...@ti.com/
V2: https://lore.kernel.org/all/20230727112546.2201995-1-devar...@ti.com/
Daniel Latypov (1):
lib: add basic KUnit test for lib/math
Devarsh Thakkar (9):
media: dt-
Hi Nicolas,
Thanks for the review.
On 15/05/24 01:52, Nicolas Dufresne wrote:
> Le samedi 11 mai 2024 à 22:38 +0530, Devarsh Thakkar a écrit :
>> Hi Andy,
>>
>> Thanks for the quick review.
>> On 10/05/24 20:40, Andy Shevchenko wrote:
>>> On Fri, May 10, 2024
Hi Andy,
On 13/05/24 17:55, Andy Shevchenko wrote:
> On Mon, May 13, 2024 at 04:55:58PM +0530, Devarsh Thakkar wrote:
>> On 13/05/24 14:29, Andy Shevchenko wrote:
>>> On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote:
>>>> On 10/05/24 20:45, Jani Niku
Hi Andy,
On 13/05/24 14:29, Andy Shevchenko wrote:
> On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote:
>> On 10/05/24 20:45, Jani Nikula wrote:
>
> [...]
>
>>> Moreover, I think the naming of round_up() and round_down() should have
>>>
Hi Andy,
Thanks for the quick review.
On 10/05/24 20:33, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 12:10:10AM +0530, Devarsh Thakkar wrote:
>> Use generic macro round_closest_up for rounding to nearest multiple instead
>
> round_closest_up()
>
> We refer to
Hi Jani,
Thanks for the quick review.
On 10/05/24 20:45, Jani Nikula wrote:
[...]
> Moreover, I think the naming of round_up() and round_down() should have
> reflected the fact that they operate on powers of 2. It's unfortunate
> that the difference to roundup() and rounddown() is just the
Hi Andy,
Thanks for the quick review.
On 10/05/24 20:31, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 12:09:52AM +0530, Devarsh Thakkar wrote:
>> Add macros to round to nearest specified power of 2.
>
> This is not what they are doing. For the above we already have macros def
Hi Andy,
Thanks for the quick review.
On 10/05/24 20:40, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote:
>> If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up
>> (V4L2_SEL_FLAG_GE) are specified by the user, then r
Use generic macro round_closest_up for rounding to nearest multiple instead
of using local function.
Signed-off-by: Devarsh Thakkar
---
V1->V6 (No change, patch introduced in V7)
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --
values (high and low) are possible to raise the probability of
cropping rectangle falling inside the bound region.
Signed-off-by: Devarsh Thakkar
---
V1->V6 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+)
-by: Devarsh Thakkar
---
V1->V6 (No change, patch introduced in V7)
---
include/linux/math.h | 36
1 file changed, 36 insertions(+)
diff --git a/include/linux/math.h b/include/linux/math.h
index dd4152711de7..82ee3265c910 100644
--- a/include/linux/math.h
++
5: https://lore.kernel.org/all/20240215134641.3381478-1-devar...@ti.com/
V6: https://lore.kernel.org/all/20240228141140.3530612-1-devar...@ti.com/
Devarsh Thakkar (8):
media: dt-bindings: Add Imagination E5010 JPEG Encoder
media: imagination: Add E5010 JPEG Encoder driver
media: v4l2-jpeg: Export refe
values (high and low) are possible to raise the probability of
cropping rectangle falling inside the bound region.
Signed-off-by: Devarsh Thakkar
---
V1->V6 (No change, patch introduced in V7)
---
drivers/media/platform/imagination/e5010-jpeg-enc.c | 8
1 file changed, 4 insertions(+)
-by: Devarsh Thakkar
---
V1->V6 (No change, patch introduced in V7)
---
include/linux/math.h | 36
1 file changed, 36 insertions(+)
diff --git a/include/linux/math.h b/include/linux/math.h
index dd4152711de7..82ee3265c910 100644
--- a/include/linux/math.h
++
Use generic macro round_closest_up for rounding to nearest multiple instead
of using local function.
Signed-off-by: Devarsh Thakkar
---
V1->V6 (No change, patch introduced in V7)
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --
Hi Maxime,
On 14/03/24 20:04, Maxime Ripard wrote:
> Hi,
>
> On Wed, Feb 14, 2024 at 09:17:12PM +0530, Devarsh Thakkar wrote:
>> On 13/02/24 19:34, Maxime Ripard wrote:
>>> On Thu, Feb 08, 2024 at 06:26:17PM +0530, Devarsh Thakkar wrote:
>>>> On 26/01/24
This adds common1 register space for AM62x SoC which is using TI's Keystone
display hardware and supporting it as described in
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
Fixes: 8ccc1073c7bb ("arm64: dts: ti: k3-am62-main: Add node for DSS")
Signed-off-by: Devar
t-schema yaml
binding")
Signed-off-by: Devarsh Thakkar
Reviewed-by: Aradhya Bhatia
Acked-by: Conor Dooley
---
V2: Add Acked-by tag
V3: Add Fixes tag
V4: Add Reviewed-by and AM62A TRM link
V5: No change
---
.../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 7 +--
1 file change
This adds common1 register space for AM65x SoC which is using TI's Keystone
display hardware and supporting it as described in
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node")
Signed-off-by: Devarsh Thakkar
This adds DSS common1 region for respective SoCs supporting it.
Changelog:
V2 : Remove do-not-merge tag and add am62a dss common1 reion
V3 : Add Fixes tag to each commit
V4 : Add Reviewed-by tag and AM62A SoC TRM Link
V5 : Split dts patch to separate patches for each SoC
Devarsh Thakkar (4
Signed-off-by: Devarsh Thakkar
---
V1->V4 :
- No change (this was part of "arm64: dts: ti: Add common1 register
space for AM62x, AM62A & AM65x SoCs )
V5 :
- Split this as a separate patch from "arm64: dts: ti: Add common1
register space for AM62x, AM62A & AM65x
dd dt-schema yaml
binding")
Signed-off-by: Devarsh Thakkar
Reviewed-by: Aradhya Bhatia
Acked-by: Conor Dooley
---
V2: Add Acked-by tag
V3: Add Fixes tag
V4: Add Reviewed-by and AM62A TRM link
---
.../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 7 +--
1 file changed, 5 i
This adds DSS common1 region for respective SoCs supporting it.
Changelog:
V2 : Remove do-not-merge tag and add am62a dss common1 reion
V3 : Add Fixes tag to each commit
V4 : Add Reviewed-by tag and AM62A SoC TRM Link
Devarsh Thakkar (2):
dt-bindings: display: ti,am65x-dss: Add support
ystem (DSS)")
Fixes: 8ccc1073c7bb ("arm64: dts: ti: k3-am62-main: Add node for DSS")
Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node")
Signed-off-by: Devarsh Thakkar
Reviewed-by: Aradhya Bhatia
---
V2: Add common1 region for AM62A SoC too
V3: Add Fixes tag
V4: A
This adds DSS common1 region for respective SoCs supporting it.
Changelog:
V2 : Remove do-not-merge tag and add am62a dss common1 reion
V3 : Add Fixes tag to each commit
Devarsh Thakkar (2):
dt-bindings: display: ti,am65x-dss: Add support for common1 region
arm64: dts: ti: Add common1
s://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)
AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)
Fixes: 2d8730f1021f ("dt-bindings: display: ti,am65x-dss: Add dt-schema yaml
binding")
Signed-off-by: Devarsh Thakkar
Acked-by: Conor Dooley
--
ystem (DSS)")
Fixes: 8ccc1073c7bb ("arm64: dts: ti: k3-am62-main: Add node for DSS")
Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node")
Signed-off-by: Devarsh Thakkar
---
V2: Add common1 region for AM62A SoC too
V3: Add Fixes tag
---
arch/arm64/boot/dts/ti/k3-am62-ma
Hi Maxime,
Thanks for the quick reply.
On 13/02/24 19:34, Maxime Ripard wrote:
> Hi Devarsh,
>
> On Thu, Feb 08, 2024 at 06:26:17PM +0530, Devarsh Thakkar wrote:
>> Hi Maxime,
>>
>> Thanks a lot for checking on this.
>>
>> On 26/01/24 17:45, Maxime Rip
This adds common1 register space for AM62x, AM62A and AM65x SoC's which are
using TI's Keystone display hardware and supporting it as described in
Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
Signed-off-by: Devarsh Thakkar
---
V2: Add common1 region for AM62A SoC too
---
arch
This adds DSS common1 region for respective SoCs supporting it.
Devarsh Thakkar (2):
dt-bindings: display: ti,am65x-dss: Add support for common1 region
arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x
SoCs
.../devicetree/bindings/display/ti/ti,am65x-dss.yaml
s://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)
AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)
AM62A TRM:
https://www.ti.com/lit/pdf/spruj16 (Section 14.9.9.1 DSS Registers)
Signed-off-by: Devarsh Thakkar
Acked-by: Conor Dooley
---
V2: Add Ac
Hi Tomi, Vignesh,
On 14/02/24 14:53, Tomi Valkeinen wrote:
> On 14/02/2024 11:10, Tomi Valkeinen wrote:
>> Hi,
>>
>> On 15/01/2024 14:57, Devarsh Thakkar wrote:
>>> TI keystone display subsystem present in AM65 and other SoCs such as AM62
>>> support two
Hi Maxime,
Thanks a lot for checking on this.
On 26/01/24 17:45, Maxime Ripard wrote:
> Hi,
>
> Thanks a lot for working on that.
>
> On Tue, Jan 16, 2024 at 07:11:41PM +0530, Devarsh Thakkar wrote:
>> Display subsystem present in TI Keystone family of devices supports
Hi Tomi,
Thanks for the review.
On 23/01/24 13:59, Tomi Valkeinen wrote:
> Hi,
>
> On 16/01/2024 15:41, Devarsh Thakkar wrote:
>> This overlay needs to be used with display sharing supported device
>> manager firmware only.
>>
>> Remote core running this fir
Hi Rob,
Thanks for the review.
On 19/01/24 19:25, Rob Herring wrote:
> On Thu, Jan 18, 2024 at 7:59 AM Devarsh Thakkar wrote:
>>
>> Hi Rob,
>>
>> Thanks for the quick review.
>>
>> On 18/01/24 01:43, Rob Herring wrote:
>>> On Tue, Jan 16,
Hi Rob,
Thanks for the quick review.
On 18/01/24 01:43, Rob Herring wrote:
> On Tue, Jan 16, 2024 at 07:11:40PM +0530, Devarsh Thakkar wrote:
>> Add support for using TI Keystone DSS hardware present in display
>> sharing mode.
>>
>> TI Keystone DSS hardware support
shared mode overlay file so that Linux does not re-use the same
while allocating memory.
Also add a label for reserved memory region in base device-tree file so
that it can be referred back in overlay file.
Signed-off-by: Devarsh Thakkar
---
arch/arm64/boot/dts/ti/Makefile | 1 +
.
access.
Signed-off-by: Devarsh Thakkar
---
.../bindings/display/ti/ti,am65x-dss.yaml | 82 +++
1 file changed, 82 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
index
and programmed using
traditional CRTC helpers and rest of video ports and associated resources
are removed from feature list accordingly.
Signed-off-by: Devarsh Thakkar
---
drivers/gpu/drm/tidss/tidss_crtc.c | 120 -
drivers/gpu/drm/tidss/tidss_dispc.c | 254
details)
[3] :
https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/tree/ti-dm/am62pxx/dss_display_share.wkup-r5f0_0.release.strip.out?h=ti-linux-firmware-next
Devarsh Thakkar (3):
dt-bindings: display: ti,am65x-dss: Add support for display sharing
mode
drm/tidss: Add support
Hi Conor,
Thanks for the review.
On 15/01/24 21:44, Conor Dooley wrote:
> On Mon, Jan 15, 2024 at 06:27:16PM +0530, Devarsh Thakkar wrote:
>> This adds common1 register space for AM62x and AM65x SoC's which are using
>> TI's Keystone display hardware and supporting
Hi Conor,
Thanks for the review.
On 15/01/24 21:47, Conor Dooley wrote:
> On Mon, Jan 15, 2024 at 06:27:15PM +0530, Devarsh Thakkar wrote:
>> TI keystone display subsystem present in AM65 and other SoCs such as AM62
>
> Do all 3 SoCs supported by this binding (am625 am6
region in device-tree bindings seem to be a
miss as ideally bindings should enumerate all supported register spaces
as done in
Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml which
also uses TI Keystone display subsystem albeit with some more features.
Devarsh Thakkar (2):
dt
:
https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)
AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)
Signed-off-by: Devarsh Thakkar
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 5 +++--
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++--
2 files changed
s://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)
AM65x TRM:
https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)
Signed-off-by: Devarsh Thakkar
---
.../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 7 +--
1 file changed, 5 insertions(+), 2 deletions(
Hi Maxime,
On 12/10/23 18:10, Maxime Ripard wrote:
> Hi,
>
> On Thu, Oct 12, 2023 at 05:10:06PM +0530, Devarsh Thakkar wrote:
>> On 09/10/23 13:20, Devarsh Thakkar wrote:
>>> Some SoC's such as AM62P have dedicated power domains
>>> for OLDI which need
On 09/10/23 13:20, Devarsh Thakkar wrote:
Some SoC's such as AM62P have dedicated power domains
for OLDI which need to be powered on separetely along
with display controller.
So during driver probe, power up all attached PM domains
enumerated in devicetree node for DSS.
This also prepares
Hi Maxime,
On 09/10/23 16:40, Devarsh Thakkar wrote:
Hi Maxime,
Thanks for the review.
On 09/10/23 14:53, Maxime Ripard wrote:
Hi Devarsh,
On Mon, Oct 09, 2023 at 01:20:18PM +0530, Devarsh Thakkar wrote:
Some SoC's such as AM62P have dedicated power domains
for OLDI which need
Hi Maxime,
Thanks for the review.
On 09/10/23 14:53, Maxime Ripard wrote:
> Hi Devarsh,
>
> On Mon, Oct 09, 2023 at 01:20:18PM +0530, Devarsh Thakkar wrote:
>> Some SoC's such as AM62P have dedicated power domains
>> for OLDI which need to be powered on separetely
1 - 100 of 116 matches
Mail list logo
