Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-01 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 04:12:22PM +0300, Cristian Ciocaltea wrote: > The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the > Synopsys DesignWare HDMI TX controller used in the previous SoCs. > > It is HDMI 2.1 compliant and supports the following features, among > others: > > *

Re: [PATCH v2 1/4] dt-bindings: display: panel: Add KD101NE3-40TI support

2024-06-01 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 04:45:25PM +0800, Zhaoxiong Lv wrote: > Create a new dt-scheam for the kd101ne3-40ti. > The bias IC of this kindisplay-kd101ne3 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver. > >

Re: [PATCH v2 4/4] drm/panel: starry: add new panel driver

2024-06-01 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 04:45:28PM +0800, Zhaoxiong Lv wrote: > This Starry panel has the same timing as the Kingdisplay panel, > so add starry configuration in the Kingdisplay driver. Do these two panels share the same driver IC? Programming sequences do not seem common, so it might be better to

Re: [PATCH v2 2/4] drm/panel: kd101ne3: add new panel driver

2024-06-01 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 04:45:26PM +0800, Zhaoxiong Lv wrote: > The bias IC of this kindisplay-kd101ne3 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver, > only 3.3v and reset are needed. > > Signed-off-by: Zhaoxiong

[PATCH v4 7/9] drm/msm/hdmi: get rid of hdmi_mode

2024-05-31 Thread Dmitry Baryshkov
Use connector->display_info.is_hdmi instead of manually using drm_detect_hdmi_monitor(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 2 +- drivers/gpu/drm/msm/hdmi/hdmi.h| 2 -- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 11 --- 3 files chan

[PATCH v4 6/9] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-05-31 Thread Dmitry Baryshkov
Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig| 2 + drivers/gpu/drm/msm/hdmi/hdmi.c| 44 ++--- drivers/gpu/drm/msm/hdmi

[PATCH v4 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-05-31 Thread Dmitry Baryshkov
The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Turn it into the atomic_enable callback as suggested by the documentation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 33 ++--- 1

[PATCH v4 0/9] drm/msm: make use of the HDMI connector infrastructure

2024-05-31 Thread Dmitry Baryshkov
, I'll finish MSM HDMI bridge conversion (reworking the Audio Infoframe code). Other bridges can follow the same approach (we have lt9611 / lt9611uxc / adv7511 on Qualcomm hardware). [1] https://patchwork.freedesktop.org/series/122421/ Signed-off-by: Dmitry Baryshkov --- Changes in v4: - Reworked

[PATCH v4 9/9] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2024-05-31 Thread Dmitry Baryshkov
requirements. The msm-4.4 kernel uses GENERIC0 to send HDR InfoFrame which we do not at this point anyway. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 93 ++ 1 file changed, 93 insertions(+) diff --git a/drivers/gpu/drm/msm/hdmi

[PATCH v4 8/9] drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition

2024-05-31 Thread Dmitry Baryshkov
The GENERIC0_UPDATE field is a single bit. Redefine it as boolean to simplify its usage in the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/registers/display

[PATCH v4 2/9] drm/bridge-connector: switch to using drmm allocations

2024-05-31 Thread Dmitry Baryshkov
Turn drm_bridge_connector to using drmm_kzalloc() and drmm_connector_init() and drop the custom destroy function. The drm_connector_unregister() and fwnode_handle_put() are already handled by the drm_connector_cleanup() and so are safe to be dropped. Acked-by: Maxime Ripard Signed-off-by: Dmitry

[PATCH v4 4/9] drm/msm/hdmi: switch to atomic bridge callbacks

2024-05-31 Thread Dmitry Baryshkov
Change MSM HDMI bridge to use atomic_* callbacks in preparation to enablign the HDMI connector support. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v4 3/9] drm/bridge-connector: implement glue code for HDMI connector

2024-05-31 Thread Dmitry Baryshkov
implementation. Note, to simplify implementation, there can be only one bridge in a chain that sets DRM_BRIDGE_OP_HDMI. Setting more than one is considered an error. This limitation can be lifted later, if the need arises. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge_connector.c | 96

[PATCH v4 1/9] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-05-31 Thread Dmitry Baryshkov
Allow passing NULL as audio infoframe as a way to disable Audio Infoframe generation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/display

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-05-31 Thread Dmitry Baryshkov
; --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v4 05/13] drm/msm/dpu: move scaling limitations out of the hw_catalog

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 12:20:24PM -0700, Abhinav Kumar wrote: > > > On 5/31/2024 1:16 AM, Dmitry Baryshkov wrote: > > On Fri, 31 May 2024 at 04:02, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 3/13/2024 5:02 PM, Dmitry

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 10:18:07AM -0600, Jeffrey Hugo wrote: > On 5/30/2024 5:12 PM, Dmitry Baryshkov wrote: > > There are two ways to describe an eDP panel in device tree. The > > recommended way is to add a device on the AUX bus, ideally using the > > edp-panel compa

Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 09:57:54AM +0800, Baolu Lu wrote: > On 5/30/24 3:58 PM, Dmitry Baryshkov wrote: > > On Thu, 30 May 2024 at 04:59, Baolu Lu wrote: > > > On 5/29/24 4:21 PM, Dmitry Baryshkov wrote: > > > > On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Bao

Re: [PATCH] docs: document python version used for compilation

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 09:33:12AM +0200, Geert Uytterhoeven wrote: > Hi Thierry, > > On Thu, May 30, 2024 at 7:07 PM Thierry Reding > wrote: > > Alternatively, maybe Kconfig could be taught about build dependencies? > > git grep "depends on \$(" -- "*Kconf*" > I'd rather not do that. The

Re: [PATCH v4 05/13] drm/msm/dpu: move scaling limitations out of the hw_catalog

2024-05-31 Thread Dmitry Baryshkov
On Fri, 31 May 2024 at 04:02, Abhinav Kumar wrote: > > > > On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > > Max upscale / downscale factors are constant between platforms. In > > preparation to adding support for virtual planes and allocating SSPP > > blocks on d

Re: [PATCH v4 1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-30 Thread Dmitry Baryshkov
/gpu/drm/bridge/sii902x.c | 32 +++- > 1 file changed, 23 insertions(+), 9 deletions(-) > Reviewed-by: Dmitry Baryshkov Chris, you might be interested in testing this series. -- With best wishes Dmitry

Re: [PATCH v2 8/9] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2024-05-30 Thread Dmitry Baryshkov
On Thu, May 30, 2024 at 03:06:20PM +0530, Aradhya Bhatia wrote: > Move the bridge pre_enable call before crtc enable, and the bridge > post_disable call after the crtc disable. > > The sequence of enable after this patch will look like: > > bridge[n]_pre_enable > ... >

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-30 Thread Dmitry Baryshkov
On Fri, 31 May 2024 at 02:24, Doug Anderson wrote: > > Hi, > > On Thu, May 30, 2024 at 4:13 PM Dmitry Baryshkov > wrote: > > > > There are two ways to describe an eDP panel in device tree. The > > recommended way is to add a device on the AUX bus, ideally u

Re: [PATCH v2 7/9] drm/bridge: cdns-dsi: Support atomic bridge APIs

2024-05-30 Thread Dmitry Baryshkov
rmat negotiation hook. > > Signed-off-by: Aradhya Bhatia > --- > .../gpu/drm/bridge/cadence/cdns-dsi-core.c| 70 --- > 1 file changed, 62 insertions(+), 8 deletions(-) Reviewed-by: Dmitry Baryshkov Minor nit below. > > @@ -915,13 +920,62 @@ sta

[PATCH v3 3/3] drm/panel-edp: drop several legacy panels

2024-05-30 Thread Dmitry Baryshkov
he AUX bus. Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-edp.c | 173 ++ 1 file changed, 7 insertions(+), 166 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-e

[PATCH v3 2/3] dt-bindings: display: panel-simple: drop several eDP panels

2024-05-30 Thread Dmitry Baryshkov
Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/panel/panel-simple.yaml| 10 -- 1 file changed, 10 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindin

[PATCH v3 1/3] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-30 Thread Dmitry Baryshkov
e retained for backwards compatibility. Suggested-by: Doug Anderson Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-edp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/p

[PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-30 Thread Dmitry Baryshkov
never used by the devices supported by the upstream kernel and are a subject to possible removal: - lg,lp097qx1-spa1 - samsung,lsn122dl01-c01 - sharp,ld-d5116z01b I'm considering dropping them later, unless there is a good reason not to do so. Signed-off-by: Dmitry Baryshkov --- Changes in v3

Re: [PATCH v2 1/3] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-30 Thread Dmitry Baryshkov
On Thu, May 30, 2024 at 07:33:59AM -0700, Doug Anderson wrote: > Hi, > > On Tue, May 28, 2024 at 4:52 PM Dmitry Baryshkov > wrote: > > > > Add a fat warning against adding new panel compatibles to the panel-edp > > driver. All new users of the eDP panels are suppos

Re: [PATCH v2 1/9] drm/bridge: cdns-dsi: Fix OF node pointer

2024-05-30 Thread Dmitry Baryshkov
On Thu, May 30, 2024 at 03:06:13PM +0530, Aradhya Bhatia wrote: > Fix the OF node pointer passed to the of_drm_find_bridge() call to find > the next bridge in the display chain. Please describe why, not what. In other words, please describe why you have to pass np, no device's of_node. > >

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-30 Thread Dmitry Baryshkov
On Thu, 30 May 2024 at 15:45, Jani Nikula wrote: > > On Mon, 20 May 2024, Doug Anderson wrote: > > Hi, > > > > On Sun, May 19, 2024 at 2:01 AM Dmitry Baryshkov > > wrote: > >> > >> On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: &

Re: [PATCH v3 5/7] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-05-30 Thread Dmitry Baryshkov
On Thu, May 30, 2024 at 11:16:08AM +0200, Maxime Ripard wrote: > Hi, > > On Thu, May 30, 2024 at 02:12:28AM GMT, Dmitry Baryshkov wrote: > > Setup the HDMI connector on the MSM HDMI outputs. Make use of > > atomic_check hook and of the provided Infoframe infrastructure

Re: [PATCH v3 3/7] drm/bridge-connector: implement glue code for HDMI connector

2024-05-30 Thread Dmitry Baryshkov
On Thu, May 30, 2024 at 11:01:26AM +0200, Maxime Ripard wrote: > Hi, > > On Thu, May 30, 2024 at 02:12:26AM GMT, Dmitry Baryshkov wrote: > > In order to let bridge chains implement HDMI connector infrastructure, > > add necessary glue code to the drm_brid

Re: [PATCH v3 1/7] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-05-30 Thread Dmitry Baryshkov
On Thu, May 30, 2024 at 10:49:26AM +0200, Maxime Ripard wrote: > Hi, > > On Thu, May 30, 2024 at 02:12:24AM GMT, Dmitry Baryshkov wrote: > > Allow passing NULL as audio infoframe as a way to disable Audio > > Infoframe generation. > > > > Signed-off-by: Dmitry Ba

Re: [PATCH] drm: renesas: shmobile: Add drm_panic support

2024-05-30 Thread Dmitry Baryshkov
On Thu, 30 May 2024 at 11:16, Jocelyn Falempe wrote: > > > > On 29/05/2024 15:33, Laurent Pinchart wrote: > > On Wed, May 29, 2024 at 04:28:44PM +0300, Dmitry Baryshkov wrote: > >> On Wed, May 29, 2024 at 12:55:06PM +0300, Laurent Pinchart wrote: > >>> O

Re: [PATCH] drm: bridge: adv7511: Accept audio sample widths of 32 bits via I2S

2024-05-30 Thread Dmitry Baryshkov
On Thu, May 30, 2024 at 09:17:03AM +0200, Ricard Wanderlof wrote: > > On Tue, 28 May 2024, Dmitry Baryshkov wrote: > > > On Tue, May 28, 2024 at 12:04:49PM +0200, Ricard Wanderlof wrote: > > > > > > Even though data is truncated to 24 bits, the I2S interf

Re: [PATCH v2] Revert "drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set"

2024-05-30 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 04:44:59PM -0700, Abhinav Kumar wrote: > > > On 5/24/2024 1:22 PM, Dmitry Baryshkov wrote: > > On Fri, May 24, 2024 at 12:58:53PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 5/22/2024 3:24 AM, Dmitry Baryshkov wrote: &g

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-30 Thread Dmitry Baryshkov
On Thu, 30 May 2024 at 07:41, Limonciello, Mario wrote: > > > >> Also a direct acpi_lid_open() call seems a bit iffy. But I guess if > >> someone needs this to work on non-ACPI system they get to figure out > >> how to abstract it better. acpi_lid_open() does seem to return != 0 > >> when ACPI is

Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-30 Thread Dmitry Baryshkov
On Thu, 30 May 2024 at 04:59, Baolu Lu wrote: > > On 5/29/24 4:21 PM, Dmitry Baryshkov wrote: > > On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Baolu wrote: > >> The domain allocated in msm_iommu_new() is for the @dev. Replace > >> iommu_domain_alloc() with iommu

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-29 Thread Dmitry Baryshkov
On Thu, 30 May 2024 at 00:57, Abhinav Kumar wrote: > > > > On 5/23/2024 2:58 AM, Dmitry Baryshkov wrote: > > On Thu, 23 May 2024 at 02:57, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 5/22/2024 1:05 PM, Dmitry Baryshkov wrote: >

Re: [PATCH 0/7] drm/msm/dpu: handle non-default TE source pins

2024-05-29 Thread Dmitry Baryshkov
On Thu, 30 May 2024 at 01:11, Abhinav Kumar wrote: > > > > On 5/22/2024 12:59 PM, Dmitry Baryshkov wrote: > > On Wed, 22 May 2024 at 21:39, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 5/20/2024 5:12 AM, Dmitry Baryshkov wro

[PATCH v3 1/7] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-05-29 Thread Dmitry Baryshkov
Allow passing NULL as audio infoframe as a way to disable Audio Infoframe generation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/display

[PATCH v3 6/7] drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition

2024-05-29 Thread Dmitry Baryshkov
The GENERIC0_UPDATE field is a single bit. Redefine it as boolean to simplify its usage in the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/registers/display

[PATCH v3 7/7] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2024-05-29 Thread Dmitry Baryshkov
requirements. The msm-4.4 kernel uses GENERIC0 to send HDR InfoFrame which we do not at this point anyway. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 93 ++ 1 file changed, 93 insertions(+) diff --git a/drivers/gpu/drm/msm/hdmi

[PATCH v3 2/7] drm/bridge-connector: switch to using drmm allocations

2024-05-29 Thread Dmitry Baryshkov
Turn drm_bridge_connector to using drmm_kzalloc() and drmm_connector_init() and drop the custom destroy function. The drm_connector_unregister() and fwnode_handle_put() are already handled by the drm_connector_cleanup() and so are safe to be dropped. Signed-off-by: Dmitry Baryshkov --- drivers

[PATCH v3 3/7] drm/bridge-connector: implement glue code for HDMI connector

2024-05-29 Thread Dmitry Baryshkov
implementation. Note, to simplify implementation, there can be only one bridge in a chain that sets DRM_BRIDGE_OP_HDMI. Setting more than one is considered an error. This limitation can be lifted later, if the need arises. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge_connector.c | 101

[PATCH v3 4/7] drm/msm/hdmi: switch to atomic bridge callbacks

2024-05-29 Thread Dmitry Baryshkov
Change MSM HDMI bridge to use atomic_* callbacks in preparation to enablign the HDMI connector support. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi

[PATCH v3 5/7] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-05-29 Thread Dmitry Baryshkov
Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig| 2 + drivers/gpu/drm/msm/hdmi/hdmi.c| 44 ++--- drivers/gpu/drm/msm/hdmi

[PATCH v3 0/7] drm/msm: make use of the HDMI connector infrastructure

2024-05-29 Thread Dmitry Baryshkov
: freedr...@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Dmitry Baryshkov Changes in v3: - Rebased on top of the merged HDMI connector patchset. - Changed drm_bridge_connector to use drmm_connector_init() (Maxime) - Added a check that write_infoframe callback is present

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 06:39:21PM +0300, Ville Syrjälä wrote: > On Wed, May 29, 2024 at 09:45:55AM -0500, Mario Limonciello wrote: > > On 5/29/2024 09:14, Ville Syrjälä wrote: > > > On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: > > >> If the lid on a laptop is closed when eDP

Re: [PATCH] drm: renesas: shmobile: Add drm_panic support

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 12:55:06PM +0300, Laurent Pinchart wrote: > On Wed, May 29, 2024 at 12:25:56PM +0300, Dmitry Baryshkov wrote: > > On Wed, May 29, 2024 at 12:10:18PM +0300, Laurent Pinchart wrote: > > > Hi Dmitry, > > > > > > On Wed, May 29, 2024 at 11:2

Re: [PATCH] drm: renesas: shmobile: Add drm_panic support

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 12:10:18PM +0300, Laurent Pinchart wrote: > Hi Dmitry, > > On Wed, May 29, 2024 at 11:27:02AM +0300, Dmitry Baryshkov wrote: > > On Wed, May 29, 2024 at 04:03:20AM +0300, Laurent Pinchart wrote: > > > On Mon, May 27, 2024 at 03:34:48PM +0200,

Re: (subset) [PATCH v4 0/3] drm/panel: two fixes for lg-sw43408

2024-05-29 Thread Dmitry Baryshkov
On Tue, 28 May 2024 22:39:17 +0300, Dmitry Baryshkov wrote: > Fix two issues with the panel-lg-sw43408 driver reported by the kernel > test robot. > > Applied to drm-misc-fixes, thanks! [1/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

Re: [PATCH] drm/sun4i: Fix compilation error

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 10:14:55AM +0200, Maxime Ripard wrote: > On Tue, 28 May 2024 17:10:56 +0200, Maxime Ripard wrote: > > Commit ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") > > introduced a dependency that got renamed in a previous version, but > > wasn't properly updated in

Re: [PATCH] drm: renesas: shmobile: Add drm_panic support

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 04:03:20AM +0300, Laurent Pinchart wrote: > Hi Geert, > > Thank you for the patch. > > On Mon, May 27, 2024 at 03:34:48PM +0200, Geert Uytterhoeven wrote: > > Add support for the drm_panic module, which displays a message on > > the screen when a kernel panic occurs. > >

Re: [PATCH] drm/display: Fix HDMI state helper dependency

2024-05-29 Thread Dmitry Baryshkov
> Closes: > https://lore.kernel.org/oe-kbuild-all/202405291221.a0nstxhe-...@intel.com/ > Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state") > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/display/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Baolu wrote: > The domain allocated in msm_iommu_new() is for the @dev. Replace > iommu_domain_alloc() with iommu_paging_domain_alloc() to make it explicit. > > Update msm_iommu_new() to always return ERR_PTR in failure cases instead > of NULL. Please

Re: [PATCH v3 4/6] drm/ci: uprev IGT

2024-05-29 Thread Dmitry Baryshkov
issue. Also > disable building xe driver tests for non-intel platforms. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Vignesh Raman > --- > > v2: > - Split IGT uprev to seperate patch. > > v3: > - No changes. > > --- > drivers/gpu/drm/ci/buil

Re: [PATCH v3 6/6] drm/ci: update xfails for the new testlist

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 08:10:49AM +0530, Vignesh Raman wrote: > Now the testlist is used from IGT build, so update > xfails with the new testlist. > > Set the timeout of all i915 jobs to 1h30m since some jobs > takes more than 1 hour to complete. > > Reviewed-by: Dmitry

Re: [PATCH v3 3/6] drm/ci: generate testlist from build

2024-05-29 Thread Dmitry Baryshkov
> 3 files changed, 40 insertions(+), 2765 deletions(-) > delete mode 100644 drivers/gpu/drm/ci/testlist.txt > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3 2/6] drm/ci: add farm variable

2024-05-29 Thread Dmitry Baryshkov
> and update the device type for missing jobs. > > Signed-off-by: Vignesh Raman > --- > > v3: > - New commit to add farm variable and update device type variable. > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3 1/6] drm/ci: uprev mesa version

2024-05-29 Thread Dmitry Baryshkov
m/ci/image-tags.yml | 2 +- > drivers/gpu/drm/ci/lava-submit.sh | 4 +-- > 6 files changed, 42 insertions(+), 28 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2 resend 1/8] gpu: drm: use for_each_endpoint_of_node()

2024-05-28 Thread Dmitry Baryshkov
changed, 1 insertion(+), 2 deletions(-) > Acked-by: Dmitry Baryshkov -- With best wishes Dmitry

[PATCH v2 2/3] dt-bindings: display: panel-simple: drop several eDP panels

2024-05-28 Thread Dmitry Baryshkov
Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/panel/panel-simple.yaml| 10 -- 1 file changed, 10 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.

[PATCH v2 3/3] drm/panel-edp: drop several legacy panels

2024-05-28 Thread Dmitry Baryshkov
he AUX bus. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-edp.c | 173 ++ 1 file changed, 7 insertions(+), 166 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 95b25ec67168..120780e5d

[PATCH v2 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-28 Thread Dmitry Baryshkov
never used by the devices supported by the upstream kernel and are a subject to possible removal: - lg,lp097qx1-spa1 - samsung,lsn122dl01-c01 - sharp,ld-d5116z01b I'm considering dropping them later, unless there is a good reason not to do so. Signed-off-by: Dmitry Baryshkov --- Changes in v2

[PATCH v2 1/3] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-28 Thread Dmitry Baryshkov
e retained for backwards compatibility. Suggested-by: Doug Anderson Reviewed-by: Neil Armstrong Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-edp.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu

[PATCH v4 2/3] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-28 Thread Dmitry Baryshkov
t;) Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-lg-sw43408.c b/drivers/gpu/drm/panel/panel-lg-sw43408.c index 115f4702d59f..2b3a73696dce 100644 --- a/drivers/gpu/drm/pane

[PATCH v4 3/3] drm/display: split DSC helpers from DP helpers

2024-05-28 Thread Dmitry Baryshkov
symbol. Reviewed-by: Jessica Zhang Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + drivers/gpu/drm/display/Kconfig| 6 ++ drivers/gpu/drm/display/Makefile | 3 ++- drivers/gpu/drm/i915/Kconfig | 1 + drivers/gpu/drm/msm/Kconfig| 1 + drivers/gpu

[PATCH v4 0/3] drm/panel: two fixes for lg-sw43408

2024-05-28 Thread Dmitry Baryshkov
Fix two issues with the panel-lg-sw43408 driver reported by the kernel test robot. Signed-off-by: Dmitry Baryshkov --- Changes in v4: - Reoder patches so that fixes come first, to be able to land them to drm-misc-fixes - Link to v3: https://lore.kernel.org/r/20240522-panel-sw43408-fix-v3-0

[PATCH v4 1/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-28 Thread Dmitry Baryshkov
("drm: panel: Add LG sw43408 panel driver") Reviewed-by: Neil Armstrong Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 982324ef5a41..2ae0eb063

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Dmitry Baryshkov
On Tue, 28 May 2024 at 18:00, Maxime Ripard wrote: > > On Tue, May 28, 2024 at 04:50:10PM GMT, Dmitry Baryshkov wrote: > > On Tue, May 28, 2024 at 11:17:56AM +0200, Maxime Ripard wrote: > > > On Tue, May 28, 2024 at 10:05:50AM GMT, Arnaud Vrac wrote: > > > > O

Re: [PATCH] drm: bridge: adv7511: Accept audio sample widths of 32 bits via I2S

2024-05-28 Thread Dmitry Baryshkov
-i2s-audio.c . > > Signed-off-by: Ricard Wanderlof > --- > drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: Dmitry Baryshkov What about: Fixes: ae053fa234f4 ("drm: bridge: adv7511: Support I2S I

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Dmitry Baryshkov
On Tue, May 28, 2024 at 11:17:56AM +0200, Maxime Ripard wrote: > On Tue, May 28, 2024 at 10:05:50AM GMT, Arnaud Vrac wrote: > > On 28/05/2024 09:43, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, May 27, 2024 at 06:03:56PM GMT, Marc Gonzalez wrote: > > > > From: Arnaud Vrac > > > > > > > >

Re: [PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-28 Thread Dmitry Baryshkov
On Tue, May 28, 2024 at 05:59:13PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2024年5月28日周二 08:48写道: > > > > On Mon, May 27, 2024 at 10:21:48PM +0800, Jun Nie wrote: > > > data is valid for only half the active window if widebus > > > is enabled &

Re: [PATCH v2] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-27 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 06:06:05PM +0200, Marc Gonzalez wrote: > From: Arnaud Vrac > > The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting > DVI 1.0 and HDMI 1.4b and 2.0b output signals. > > Since it's an I2C-programmable bridge, it could have a proper driver, > but the

Re: [PATCH v15 17/29] drm/doc: Remove unused Broadcast RGB Property

2024-05-27 Thread Dmitry Baryshkov
> At the time though, gma500 had an "audio" property used right next to > Broadcast RGB that did have the "off", "auto" and "on" values in the > same order. > > As such, it was probably a copy/paste or scripting error back then, and > there'

Re: [PATCH v15 15/29] drm/connector: hdmi: Compute bpc and format automatically

2024-05-27 Thread Dmitry Baryshkov
y found in i915 and vc4. > > Cc: Ville Syrjälä > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/display/drm_hdmi_state_helper.c| 217 > - > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 25 ++- > 2 files changed, 230 insertions(+),

Re: [PATCH v15 10/29] drm/tests: Add HDMI TDMS character rate tests

2024-05-27 Thread Dmitry Baryshkov
-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_connector_test.c | 300 > + > 1 file changed, 300 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v15 09/29] drm/display: hdmi: Add HDMI compute clock helper

2024-05-27 Thread Dmitry Baryshkov
rate taking all parameters into > account. > > Reviewed-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/display/drm_hdmi_helper.c | 61 > +++ > include/drm/display/drm_hdmi_helper.h | 4 ++ > 2 files changed

Re: [PATCH v2 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-05-27 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 05:40:03PM +0200, Philipp Zabel wrote: > Hi Dmitry, > > On Mi, 2024-04-17 at 00:58 +0300, Dmitry Baryshkov wrote: > > On Sun, Mar 31, 2024 at 11:28:57PM +0300, Dmitry Baryshkov wrote: > > > The IPUv3 DRM i.MX driver contains several codepaths for d

Re: [PATCH v5 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC

2024-05-27 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 10:21:49PM +0800, Jun Nie wrote: > Enable compression bit in cfg2 register for DSC in the DSI case > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 4 > 1 file changed, 4 insertions(+) > Reviewed

Re: [PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-27 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 10:21:48PM +0800, Jun Nie wrote: > data is valid for only half the active window if widebus > is enabled > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git

Re: [PATCH v5 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-05-27 Thread Dmitry Baryshkov
msm/disp/dpu1/dpu_encoder.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 8 > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 18 ++ > 3 files changed, 27 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 17/28] drm/connector: hdmi: Add Broadcast RGB property

2024-05-27 Thread Dmitry Baryshkov
On Mon, 27 May 2024 at 16:30, Maxime Ripard wrote: > > Hi, > > On Mon, May 27, 2024 at 12:43:18PM GMT, Dmitry Baryshkov wrote: > > On Mon, May 27, 2024 at 11:02:13AM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > Thanks again for that thorough rev

Re: [PATCH v14 17/28] drm/connector: hdmi: Add Broadcast RGB property

2024-05-27 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 11:02:13AM +0200, Maxime Ripard wrote: > Hi, > > Thanks again for that thorough review :) > > On Thu, May 23, 2024 at 01:22:56PM GMT, Dmitry Baryshkov wrote: > > On Tue, May 21, 2024 at 12:13:50PM +0200, Maxime Ripard wrote: > > > The i915

Re: [PATCH v6 02/10] drm/bridge: Set firmware node of drm_bridge instances automatically

2024-05-26 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 04:21:07AM +0800, Sui Jingfeng wrote: > Normally, the drm_bridge::of_node won't be used by bridge driver instances > themselves. Rather, it is mainly used by other modules to find associated > drm bridge drvier. Therefore, adding a drm bridge to the global bridge list > and

Re: [PATCH v2 1/3] drm/loongson: Add a helper for creating child devices

2024-05-26 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 03:58:24AM +0800, Sui Jingfeng wrote: > In some display subsystems, the functionality of a PCIe device may too > complex to be managed by a single driver. A split of the functionality > into child devices can helpful to achieve better modularity. > > Another benefit is

Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays

2024-05-24 Thread Dmitry Baryshkov
d writeback blocks to the sm8250 DPU > catalog") > > Reviewed-by: Abhinav Kumar > > (pls ignore the line breaks in the fixes line, I will fix it while applying) With the Fixes tags in place: Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2] Revert "drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set"

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 12:58:53PM -0700, Abhinav Kumar wrote: > > > On 5/22/2024 3:24 AM, Dmitry Baryshkov wrote: > > In the DPU driver blank IRQ handling is called from a vblank worker and > > can happen outside of the irq_enable / irq_disable pair. Using the > > w

Re: [PATCH v4 1/5] drm/msm/dpu: fix video mode DSC for DSI

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 09:18:21PM +0800, Jun Nie wrote: > From: Jonathan Marek > > Add necessary DPU timing and control changes for DSC to work with DSI > video mode. > > Signed-off-by: Jonathan Marek > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2

Re: [PATCH v3 1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 05:54:02PM +0530, Jayesh Choudhary wrote: > Hello Dmitry, > > On 24/05/24 15:11, Dmitry Baryshkov wrote: > > On Fri, May 24, 2024 at 03:05:08PM +0530, Jayesh Choudhary wrote: > > > Currently, mode_valid hook returns all mode as valid and

Re: [PATCH] drm: bridge: cdns-mhdp8546: Add mode_valid hook for the drm_bridge_funcs

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 12:43:48PM +0530, Jayesh Choudhary wrote: > With the support for the 'DRM_BRIDGE_ATTACH_NO_CONNECTOR' case, > the connector_helper funcs are not initialized if the encoder has this > flag in its bridge_attach call. Till now we had mode_valid hook only in > the

Re: [PATCH v3 1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 03:05:08PM +0530, Jayesh Choudhary wrote: > Currently, mode_valid hook returns all mode as valid and it is > defined only in drm_connector_helper_funcs. With the introduction of > 'DRM_BRIDGE_ATTACH_NO_CONNECTOR', connector is not initialized in > bridge_attach call for

Re: [PATCH v2 1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 01:03:04PM +0530, Jayesh Choudhary wrote: > Currently, mode_valid hook returns all mode as valid and it is > defined only in drm_connector_helper_funcs. With the introduction of > 'DRM_BRIDGE_ATTACH_NO_CONNECTOR', connector is not initialized in > bridge_attach call for

Re: [PATCH RFC] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-23 Thread Dmitry Baryshkov
On Thu, May 23, 2024 at 08:36:39AM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 22, 2024 at 3:07 PM Dmitry Baryshkov > wrote: > > > > Add a fat warning against adding new panel compatibles to the panel-edp > > driver. All new users of the eDP panels are suppos

Re: [PATCH v14 23/28] drm/connector: hdmi: Create Infoframe DebugFS entries

2024-05-23 Thread Dmitry Baryshkov
t; drivers/gpu/drm/drm_debugfs.c | 152 > ++ > 1 file changed, 152 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 22/28] drm/tests: Add infoframes test

2024-05-23 Thread Dmitry Baryshkov
drivers/gpu/drm/tests/drm_connector_test.c | 219 > + > 1 file changed, 219 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 21/28] drm/connector: hdmi: Add Infoframes generation

2024-05-23 Thread Dmitry Baryshkov
helper.h| 7 + > include/drm/drm_connector.h| 111 ++- > 6 files changed, 480 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 20/28] drm/tests: Add RGB Quantization tests

2024-05-23 Thread Dmitry Baryshkov
rks as expected. > > Reviewed-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 355 > + > 1 file changed, 355 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

  1   2   3   4   5   6   7   8   9   10   >