I will be leaving Imagination Technologies on 2023-12-15 and will no
longer be working on this driver.
Signed-off-by: Donald Robson
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d4b46b3db022..0eba015ac5f1 100644
--- a/MAINTAINERS
+++ b
e address is never an error pointer so this will always return 0.
Remove the ampersand.
Reported-by: Dan Carpenter
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imagination/pvr_vm.c
b/driver
ease);
Here the pvr_vm_context_release() will call:
pvr_mmu_context_destroy(vm_ctx->mmu_ctx);
Refactor to an unwind style.
Reported-by: Dan Carpenter
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_vm.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions
Thanks Alex!
Reviewed-by: Donald Robson
On Fri, 2023-12-08 at 18:08 +0100, Alex Bee wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an attachment ***
>
> When conditionally checking for he
it is fully resolved.
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_hwrt.c | 27 +-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/imagination/pvr_hwrt.c
b/drivers/gpu/drm/imagination/pvr_hwrt.c
index c4213c18489e
s
code in other places as well. This loop is slightly off as well. It
should decrement pfn on the first iteration.
Fix by making the loop limit variables signed. Also fix missing
predecrement by modifying to while loop.
Reported-by: Dan Carpenter
Signed-off-by: Donald Robson
---
drivers/g
Thanks for the bug report!
Donald
On Thu, 2023-12-07 at 10:23 +, Steven Price wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an attachment ***
>
> On 07/12/2023 08:56, Boris Brezillon wrote:
> > On
Apologies, I didn't reply all last time.
Thanks Danilo!
Reviewed-by: Donald Robson
On Wed, 2023-11-29 at 23:07 +0100, Danilo Krummrich wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an atta
rnel.org/oe-kbuild-all/202311302054.mvypxfce-...@intel.com/
Fixes: cb56cd610866 ("drm/imagination: Add firmware trace to debugfs")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_fw_trace.c | 44 --
1 file changed, 44 deletions(-)
diff --git a
Just to clarify, there is no [PATCH 2/2]. I made the patch from the wrong
branch
and didn't notice format-patch had picked up another commit.
Thanks,
Donald
On Mon, 2023-12-04 at 13:36 +, Donald Robson wrote:
> *** NOTE: This is an internal email from Imagination Technolog
.@intel.com/
Fixes: c98cc92ab6ce ("drm/imagination: Add firmware trace to debugfs")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_fw_trace.c | 44 --
1 file changed, 44 deletions(-)
diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c
b
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311242159.hh8mwiam-...@intel.com/
Fixes: 3c96dd170efe ("drm/imagination: Add GEM and VM related code")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_vm.c | 2 +-
1 file changed, 1 inser
rrect header.
Reported-by: Arnd Bergmann
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311250226.da2yiskp-...@intel.com/
Fixes: bb52a8dc84f2 ("drm/imagination: Implement firmware infrastructure and
META FW support")
Signed-off-by: Donald Robson
---
drive
the function for now.
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311242159.hh8mwiam-...@intel.com/
Fixes: 3c96dd170efe ("drm/imagination: Add GEM and VM related code")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_vm.c | 6
| static
1 warning generated.
Make it static.
Reported-by: Arnd Bergmann
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311250632.givex7mu-...@intel.com/
Fixes: c98dab7a5f5f ("drm/imagination: Implement job submission and scheduling")
drm/imagination: Add GPU ID parsing and firmware loading")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_device_info.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imagination/pvr_device_info.c
b/drivers/gpu/drm/imagination/pvr_device_info.c
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311242159.hh8mwiam-...@intel.com/
Fixes: 3c96dd170efe ("drm/imagination: Add GEM and VM related code")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_vm.c | 6 --
1 file changed, 6
Reported-by: Arnd Bergmann
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311242159.hh8mwiam-...@intel.com/
Fixes: 3c96dd170efe ("drm/imagination: Add GEM and VM related code")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_vm.c
Reported-by: Arnd Bergmann
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311250632.givex7mu-...@intel.com/
Fixes: c98dab7a5f5f ("drm/imagination: Implement job submission and scheduling")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/i
Reported-by: Arnd Bergmann
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311250226.da2yiskp-...@intel.com/
Fixes: bb52a8dc84f2 ("drm/imagination: Implement firmware infrastructure and
META FW support")
Signed-off-by: Donald Robson
---
drive
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311241752.3ilyyfca-...@intel.com/
Fixes: 1ff76f7a5b45 ("drm/imagination: Add GPU ID parsing and firmware loading")
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_device_info.c | 3 +
On Wed, 2023-11-29 at 13:16 +0100, Arnd Bergmann wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an attachment ***
>
> On Wed, Nov 29, 2023, at 13:07, Donald Robson wrote:
> > Hello Arn
On Wed, 2023-11-29 at 13:04 +0100, Arnd Bergmann wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an attachment ***
>
> On Wed, Nov 29, 2023, at 13:01, Donald Robson wrote:
> > Hello Arn
Hello Arnd,
Thanks for this. However, I fixed these in a patch a few minutes before you
sent
yours. I'm not sure what normally happens in these circumstances, but as my
patch has
the kernel robot tags and a few additional fixes, I think we should probably
use that
one.
Thanks,
Donald
On
Hello Arnd,
Thanks for the patch. I'm slightly concerned that we've not seen this warning
when
building here. I guess we need to check our CI settings...
Reviewed-by: Donald Robson
On Wed, 2023-11-29 at 12:33 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The array size ca
://lore.kernel.org/oe-kbuild-all/202311250226.da2yiskp-...@intel.com/
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/pvr_device.c | 2 +-
drivers/gpu/drm/imagination/pvr_device_info.c | 3 ++-
drivers/gpu/drm/imagination/pvr_fw_meta.c | 1 +
drivers/gpu/drm/imagination
Some reported by Stephen Rothwell. The rest were found by running the
kernel-doc build script.
Some indentation fixes.
Reported-by: Stephen Rothwell
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202311241526.y2wzeuau-...@intel.com/
Signed-off-by: Donald Robson
:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an attachment ***
>
>
>
> > Am 22.11.2023 um 20:34 schrieb Maxime Ripard :
> >
> > Hi,
> >
> > On Wed, Nov 22,
Hi Danilo,
Apologies - I guess I should have submitted a patch to handle zero fences in
your
locking functions with the final patch series.
On Sat, 2023-11-25 at 00:36 +0100, Danilo Krummrich wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies.
Thanks Danilo. It's obvious now you've pointed it out!
Reviewed-by: Donald Robson
On Sat, 2023-11-25 at 00:36 +0100, Danilo Krummrich wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an atta
Thanks Danilo.
Reviewed-by: Donald Robson
On Sat, 2023-11-25 at 00:36 +0100, Danilo Krummrich wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an attachment ***
>
Hi Danilo,
Thanks for reviewing this file again and thanks for clarifying the use of these
functions.
Reviewed-by: Donald Robson
On Sat, 2023-11-25 at 00:36 +0100, Danilo Krummrich wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think
Hi Geert,
On Mon, 2023-11-27 at 09:39 +0100, Geert Uytterhoeven wrote:
> Hi Donald,
>
> On Wed, Nov 22, 2023 at 5:36 PM Donald Robson
> wrote:
> > From: Sarah Walker
> >
> > Add the device tree binding documentation for the IMG AXE GPU used in
> >
Hi Stephen,
Thanks for the report. I've fixed these locally, along with a few other doc
issues
I found. I'll get the patch out as soon as I can.
Thanks,
Donald
On Fri, 2023-11-24 at 13:25 +1100, Stephen Rothwell wrote:
> *** CAUTION: This email originates from a source not known to
From: Sarah Walker
Add documentation for the UAPI.
Changes since v5:
- Remove obsolete VM documentation
Co-developed-by: Matt Coster
Signed-off-by: Matt Coster
Co-developed-by: Donald Robson
Signed-off-by: Donald Robson
Signed-off-by: Sarah Walker
Reviewed-by: Maxime Ripard
-off-by: Matt Coster
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/Makefile | 4 +
drivers/gpu/drm/imagination/pvr_debugfs.c | 53 +++
drivers/gpu/drm/imagination/pvr_debugfs.h | 29 ++
drivers/gpu/drm/imagination/pvr_device.c | 9
From: Sarah Walker
Changes since v8:
- Corrected license identifiers
Changes since v5:
- Split up header commit due to size
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
---
.../gpu/drm/imagination/pvr_rogue_fwif_sf.h | 1648 +
1 file changed, 1648 insertions
From: Sarah Walker
Add the device tree binding documentation for the IMG AXE GPU used in
TI AM62 SoCs.
Co-developed-by: Frank Binns
Signed-off-by: Frank Binns
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
Reviewed-by: Maxime Ripard
Reviewed-by: Linus Walleij
Reviewed-by: Conor
vour of direct returning
- Remove specific am62 compatible match string
- Drop MODULE_FIRMWARE()
Co-developed-by: Frank Binns
Signed-off-by: Frank Binns
Co-developed-by: Matt Coster
Signed-off-by: Matt Coster
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
Reviewed-by: Maxime Ri
-developed-by: Matt Coster
Signed-off-by: Matt Coster
Co-developed-by: Donald Robson
Signed-off-by: Donald Robson
Signed-off-by: Sarah Walker
Reviewed-by: Faith Ekstrand
---
MAINTAINERS|1 +
include/uapi/drm/pvr_drm.h | 1297
2 files
- Add job timeout handler
- Split sync handling out of job code
- Use drm_dev_{enter,exit}
Changes since v2:
- Use drm_sched for job scheduling
Co-developed-by: Boris Brezillon
Signed-off-by: Boris Brezillon
Co-developed-by: Donald Robson
Signed-off-by: Donald Robson
Signed-off-by: Sa
- Remove regs resource (not used in this commit)
Co-developed-by: Frank Binns
Signed-off-by: Frank Binns
Co-developed-by: Matt Coster
Signed-off-by: Matt Coster
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
Reviewed-by: Maxime Ripard
---
drivers/gpu/drm/imagination/Makefile | 1
overflow in VM map error path
Changes since v5:
- Use alloc_page() when allocating MIPS pagetable
Changes since v3:
- Get regs resource (removed from GPU resources commit)
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/Makefile | 4 +-
drivers/gpu
From: Matt Coster
sizes.h has a gap in defines between SZ_32G and SZ_64T. Add the missing
defines so they can be used in drivers.
Signed-off-by: Matt Coster
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
Reviewed-by: Linus Walleij
---
include/linux/sizes.h | 9 +
1 file
arah Walker
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/Makefile |4 +
drivers/gpu/drm/imagination/pvr_ccb.c | 635
drivers/gpu/drm/imagination/pvr_ccb.h | 71 +
drivers/gpu/drm/imagination/pvr_device.c | 103 ++
drivers/gpu/drm/imagina
-by: Donald Robson
Signed-off-by: Donald Robson
Signed-off-by: Sarah Walker
---
drivers/gpu/drm/imagination/Makefile| 2 +
drivers/gpu/drm/imagination/pvr_ccb.c | 10 +
drivers/gpu/drm/imagination/pvr_device.h| 24 +
drivers/gpu/drm/imagination/pvr_drv.c | 112
-by: Donald Robson
Signed-off-by: Donald Robson
Signed-off-by: Sarah Walker
---
drivers/gpu/drm/imagination/Makefile | 2 +
drivers/gpu/drm/imagination/pvr_device.c | 323 ++-
drivers/gpu/drm/imagination/pvr_device.h | 220
drivers/gpu/drm/imagination
context release in final error path in pvr_context_create()
Changes since v3:
- Use drm_dev_{enter,exit}
Co-developed-by: Boris Brezillon
Signed-off-by: Boris Brezillon
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
---
drivers/gpu/drm/imagination/Makefile | 4 +
drivers
ter,exit}
Changes since v2:
- Use runtime PM
- Implement watchdog
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
Reviewed-by: Maxime Ripard
---
drivers/gpu/drm/imagination/Kconfig | 1 +
drivers/gpu/drm/imagination/Makefile | 1 +
drivers/gpu/drm/imagination/pvr_device.c |
From: Sarah Walker
Changes since v8:
- Corrected license identifiers
Changes since v5:
- Split up header commit due to size
Signed-off-by: Sarah Walker
Signed-off-by: Donald Robson
Acked-by: Maxime Ripard
---
.../drm/imagination/pvr_rogue_heap_config.h | 113 ++
drivers/gpu/drm
of __always_inline
Signed-off-by: Donald Robson
Signed-off-by: Sarah Walker
Reviewed-by: Danilo Krummrich
---
include/drm/drm_gpuvm.h | 28
1 file changed, 28 insertions(+)
diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
index 8ca10461d8ac..f94fec9a8517
/20230906095542.3280699-1-sarah.wal...@imgtec.com/
v7:
https://lore.kernel.org/dri-devel/20231010133738.35274-1-sarah.wal...@imgtec.com/
v8:
https://lore.kernel.org/dri-devel/20231031151257.90350-1-sarah.wal...@imgtec.com/
Donald Robson (1):
drm/gpuvm: Helper to get range of unmap from a remap
On Tue, 2023-11-14 at 17:42 +0100, Danilo Krummrich wrote:
> *** CAUTION: This email originates from a source not known to Imagination
> Technologies. Think before you click a link or open an attachment ***
>
> On 10/31/23 16:12, Sarah Walker wrote:
> > From: Donald Robson
&g
a link or open an attachment ***
>
> On 10/10/23 15:37, Sarah Walker wrote:
> > From: Donald Robson
> >
> > Determining the start and range of the unmap stage of a remap op is a
> > common piece of code currently implemented by multiple drivers. Add a
> >
On Thu, 2023-09-07 at 15:14 +0300, Jani Nikula wrote:
> On Wed, 06 Sep 2023, Sarah Walker wrote:
> > From: Donald Robson
> >
> > Signed-off-by: Donald Robson
> > ---
> > include/drm/drm_gpuva_mgr.h | 27 +++
> > 1 file change
; > Changes since v3:
> > - Split MMU and VM code
> > - Register page table allocations with kmemleak
> > - Use drm_dev_{enter,exit}
> >
> > Changes since v2:
> > - Use GPU VA manager
> > - Use drm_gem_shmem
> >
> > Co-developed-by: Mat
Hi Danilo,
The below part of the documentation is out of date now.
Thanks,
Donald
On Thu, 2023-07-13 at 19:03 +0200, Danilo Krummrich wrote:
>
> +
> +/**
> + * DOC: Locking
> + *
> + * Generally, the GPU VA manager does not take care of locking itself, it is
> + * the drivers responsibility to
On Fri, 2023-06-30 at 00:25 +0200, Danilo Krummrich wrote:
>
> +#ifdef CONFIG_LOCKDEP
> +typedef struct lockdep_map *lockdep_map_p;
> +#define drm_gpuva_manager_ext_assert_held(mgr) \
> + lockdep_assert(lock_is_held((mgr)->ext_lock) != LOCK_STATE_NOT_HELD)
> +/**
> + *
Hi Danilo,
One comment below, but otherwise it looks great. Thanks for adding the example!
Thanks,
Donald
On Tue, 2023-06-20 at 02:42 +0200, Danilo Krummrich wrote:
>
> +/**
> + * DOC: Overview
> + *
> + * The DRM GPU VA Manager, represented by struct drm_gpuva_manager keeps
> track
> + * of a
On Tue, 2023-06-13 at 16:20 +0200, Danilo Krummrich wrote:
> I'm definitely up improving the existing documentation. Anything in
> particular you think should be described in more detail?
>
> - Danilo
Hi Danilo,
As I said, with inexperience it's possible I missed what I was
looking for in the
gree this
reflects me being a novice on matters DRM, but I did find myself
wishing for more direction, even with Boris's help.
Tested-by: Donald Robson
> drm: debugfs: provide infrastructure to dump a DRM GPU VA space
> drm/nouveau: new VM_BIND uapi interfaces
> drm/nouveau: get vmm
/pvr_queue.c
Thanks,
Donald
On Thu, 2023-06-08 at 14:23 +0100, Donald Robson wrote:
> This patch adds support for 'native' dependencies to DRM scheduler. In
> drivers that use a firmware based scheduler there are performance gains
> to be had by allowing waits to happen in the
for this and we welcome any suggestions for how
best to implement it.
Signed-off-by: Donald Robson
Cc: Luben Tuikov
Cc: David Airlie
Cc: Daniel Vetter
Cc: Sumit Semwal
Cc: "Christian König"
Cc: Boris Brezillon
Cc: Frank Binns
Cc: Sarah Walker
---
drivers/gpu/drm/scheduler/sched_ent
63 matches
Mail list logo
