Re: [PATCH 2/2] dt-bindings: google, cros-ec: drop Enric Balletbo i Serra from maintainers

2022-01-20 Thread Enric Balletbo Serra
Hi, Missatge de Krzysztof Kozlowski del dia dj., 20 de gen. 2022 a les 11:40: > > Enric Balletbo i Serra emails bounce: > > : Recipient address rejected: User unknown in > local recipient table > > so drop him from the maintainers, similarly to commit 3119c28634dd > ("MAINTAINERS: Chrome:

Re: [PATCH 1/2] dt-bindings: display: bridge: drop Enric Balletbo i Serra from maintainers

2022-01-20 Thread Enric Balletbo Serra
Hi, Missatge de Neil Armstrong del dia dj., 20 de gen. 2022 a les 11:52: > > On 20/01/2022 11:40, Krzysztof Kozlowski wrote: > > Enric Balletbo i Serra emails bounce: > > > > : Recipient address rejected: User unknown > > in local recipient table > > > > so drop him from the maintainers,

Re: [PATCH 0/5] Revert series "CMDQ refinement of Mediatek DRM driver"

2021-10-08 Thread Enric Balletbo Serra
Hi Chun-Kuang, Thank you to take time to send this, for full series Tested-by: Enric Balletbo i Serra Display is now working again. Thanks, Enric Missatge de Chun-Kuang Hu del dia dv., 8 d’oct. 2021 a les 1:53: > > Commit c1ec54b7b5af > ("drm/mediatek: Use mailbox rx_callback instead of

Re: [v2 PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-10-06 Thread Enric Balletbo Serra
Hi Chun-Kuang, Missatge de Chun-Kuang Hu del dia dv., 1 d’oct. 2021 a les 17:52: > > Hi, Enric: > > Enric Balletbo Serra 於 2021年9月30日 週四 下午9:48寫道: > > > > Hi Chun-Kuang, > > > > Missatge de Chun-Kuang Hu del dia dj., 30 de > > set. 2021 a les 15:11

Re: [PATCH v9, 2/2] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-10-01 Thread Enric Balletbo Serra
Hi Yongqiang, This patch already have my reviewed tag but I just noticed a small nit Missatge de Yongqiang Niu del dia dj., 30 de set. 2021 a les 16:00: > > mt8192 has different routing registers than mt8183 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Enric Balletbo i Serra > --- >

Re: [v2 PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-09-30 Thread Enric Balletbo Serra
Hi Chun-Kuang, Missatge de Chun-Kuang Hu del dia dj., 30 de set. 2021 a les 15:11: > > Hi, Enric: > > Enric Balletbo Serra 於 2021年9月30日 週四 下午3:12寫道: > > > > Hi Jason, > > > > > > Missatge de jason-jh.lin del dia dj., 30 > > de set. 2021 a les 4

Re: [v2 PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-09-30 Thread Enric Balletbo Serra
Hi Jason, Missatge de jason-jh.lin del dia dj., 30 de set. 2021 a les 4:47: > > Because mtk_drm_crtc_create_pkt didn't assign pkt->cl, it will > crash at using pkt->cl->chan in cmdq_pkt_finalize. > > So add struct cmdq_client and let mtk_drm_crtc instance define > cmdq_client as: > > struct

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-09-23 Thread Enric Balletbo Serra
Hi Chun-Kuang, Missatge de Chun-Kuang Hu del dia dt., 21 de set. 2021 a les 15:15: > > Hi, Enric: > > Enric Balletbo Serra 於 2021年9月21日 週二 下午4:36寫道: > > > > Hi Chun-Kuang, > > > > (again without html format, sorry for the noise) > > > > Missatge

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-09-21 Thread Enric Balletbo Serra
Hi Chun-Kuang, (again without html format, sorry for the noise) Missatge de Chun-Kuang Hu del dia dj., 12 d’ag. 2021 a les 2:13: > > Chun-Kuang Hu 於 2021年8月9日 週一 上午7:47寫道: > > > > These refinements include using standard mailbox callback interface, > > timeout detection, and a fixed

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-09-21 Thread Enric Balletbo Serra
Hi Chun-Kuang, Missatge de Chun-Kuang Hu del dia dj., 12 d’ag. 2021 a les 2:13: > Chun-Kuang Hu 於 2021年8月9日 週一 上午7:47寫道: > > > > These refinements include using standard mailbox callback interface, > > timeout detection, and a fixed cmdq_handle. > > For this series, applied to

Re: [PATCH v8, 2/2] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-08-03 Thread Enric Balletbo Serra
Hi Yongqiang, Thank you for your patch Missatge de Yongqiang Niu del dia dl., 2 d’ag. 2021 a les 11:00: > > mt8192 has different routing registers than mt8183 > ... than mt8183 and other Mediatek SoC's I guess ;-) > Signed-off-by: Yongqiang Niu Reviewed-by: Enric Balletbo i Serra Thanks,

Re: [PATCH v1 1/5] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

2021-07-28 Thread Enric Balletbo Serra
Hi Jason, Missatge de Jason-JH Lin del dia dt., 27 de jul. 2021 a les 4:53: > > Hi Enric, > > On Mon, 2021-07-26 at 12:08 +0200, Enric Balletbo Serra wrote: > > Hi Jason, > > > > Missatge de Jason-JH Lin del dia dl., 26 > > de jul. 2021 a les 9:02: > >

Re: [PATCH v2 09/14] soc: mediatek: mmsys: Add reset controller support for MT8195 vdosys1

2021-07-28 Thread Enric Balletbo Serra
Hi Nancy, Missatge de Nancy.Lin del dia dc., 28 de jul. 2021 a les 8:01: > > Hi Enric, > > Thanks for your review. > > On Fri, 2021-07-23 at 12:57 +0200, Enric Balletbo Serra wrote: > > Hi Nancy, > > > > Thank you for your patch. > > > > M

Re: [PATCH v1 1/5] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

2021-07-26 Thread Enric Balletbo Serra
Hi Jason, Missatge de Jason-JH Lin del dia dl., 26 de jul. 2021 a les 9:02: > > On Fri, 2021-07-23 at 13:13 +0200, Enric Balletbo Serra wrote: > > Hi Jason, > > > > Thank you for your patch. > > > > Missatge de jason-jh.lin del dia dj., 22 > > de jul.

Re: [PATCH v1 1/5] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

2021-07-23 Thread Enric Balletbo Serra
Hi Jason, Thank you for your patch. Missatge de jason-jh.lin del dia dj., 22 de jul. 2021 a les 11:26: > > There are 2 display hardware path in mt8195, namely vdosys0 and > vdosys1, so add their definition in mtk-mmsys documentation. > Just having 2 display hardware paths is not a reason to

Re: [PATCH v2 04/14] dt-bindings: reset: mt8195: Move reset controller constants into common location

2021-07-23 Thread Enric Balletbo Serra
Hi Nancy, Thank you for your patch Missatge de Nancy.Lin del dia dj., 22 de jul. 2021 a les 11:46: > > The DT binding includes for reset controllers are located in > include/dt-bindings/reset/. Move the Mediatek reset constants in there. > I think that the patch that introduces mt8195-resets.h

Re: [PATCH v2 07/14] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1

2021-07-23 Thread Enric Balletbo Serra
Hi Nancy, Thank you for your patch. Missatge de Nancy.Lin del dia dj., 22 de jul. 2021 a les 11:45: > > Add mt8195 vdosys1 clock driver name and routing table to > the driver data of mtk-mmsys. > > Signed-off-by: Nancy.Lin > --- > drivers/soc/mediatek/mt8195-mmsys.h| 83

Re: [PATCH v2 09/14] soc: mediatek: mmsys: Add reset controller support for MT8195 vdosys1

2021-07-23 Thread Enric Balletbo Serra
Hi Nancy, Thank you for your patch. Missatge de Nancy.Lin del dia dj., 22 de jul. 2021 a les 11:46: > > Among other features the mmsys driver should implement a reset > controller to be able to reset different bits from their space. > I'm working on a series that does the same, it should be

Re: [PATCH v4 2/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2021-07-23 Thread Enric Balletbo Serra
Hi Jason, Thank you for your patch. Missatge de jason-jh.lin del dia dv., 23 de jul. 2021 a les 11:02: > > Add mt8195 vdosys0 clock driver name and routing table to > the driver data of mtk-mmsys. > > Signed-off-by: jason-jh.lin > --- > This patch is base on [1] > > [1]add mt8195 SoC DRM

Re: [PATCH v2 1/1] Fix cursor plane didn't update

2021-07-19 Thread Enric Balletbo Serra
Hi Jason-jh, Thank you for your patch. Please prefix this patch with 'drm/mediatek' so it is clear what the changes are. Missatge de jason-jh.lin del dia dl., 19 de jul. 2021 a les 10:24: > > The cursor plane should use the current plane state in atomic_async_update > because it would not be

Re: [PATCH v6 RESEND 3/3] arm64: dts: mt8183: Add panel rotation

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for the patch. Missatge de Hsin-Yi Wang del dia dj., 27 de maig 2021 a les 9:42: > > krane, kakadu, and kodama boards have a default panel rotation. > > Signed-off-by: Hsin-Yi Wang It looks good to me, so Reviewed-by: Enric Balletbo i Serra and, on a Lenovo IdeaPad

Re: [PATCH v6 RESEND 2/3] drm/mediatek: init panel orientation property

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dj., 24 de juny 2021 a les 12:55: > > Init panel orientation property after connector is initialized. Let the > panel driver decides the orientation value later. > > Signed-off-by: Hsin-Yi Wang > Acked-by: Chun-Kuang Hu

Re: [PATCH v6 RESEND 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dj., 24 de juny 2021 a les 12:55: > > drm_dev_register() sets connector->registration_state to > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > drm_connector_set_panel_orientation() is first called after >

Re: Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-09 Thread Enric Balletbo Serra
Hi Frank, Missatge de Frank Wunderlich del dia dv., 9 de jul. 2021 a les 12:02: > > Hi, > > i've found it :) > > hdmi-problem is caused by > > commit 440147639ac79f699a4eb9811d0bc39d3cc815f4 > Author: CK Hu > Date: Wed Mar 17 19:17:10 2021 +0100 > > soc: mediatek: mmsys: Use an array for

Re: [PATCH v5, 2/4] soc: mediatek: mmsys: add component POSTMASK

2021-04-16 Thread Enric Balletbo Serra
Hi Yongqiang, Thank you for your patch. Missatge de Yongqiang Niu del dia dl., 12 d’abr. 2021 a les 16:05: > > This patch add component POSTMASK > > Signed-off-by: Yongqiang Niu Reviewed-by: Enric Balletbo i Serra > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1

Re: [PATCH v5, 1/4] soc: mediatek: mmsys: add component OVL_2L2

2021-04-16 Thread Enric Balletbo Serra
Hi Yongqiang, Thank you for your patch. Missatge de Yongqiang Niu del dia dl., 12 d’abr. 2021 a les 16:04: > > This patch add component OVL_2L2 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu Reviewed-by: Enric Balletbo i Serra > --- > include/linux/soc/mediatek/mtk-mmsys.h

Re: [PATCH v4, 01/10] soc: mediatek: mmsys: create mmsys folder

2021-02-09 Thread Enric Balletbo Serra
Hi Yongqiang Niu, Thank you for your patch. Missatge de Yongqiang Niu del dia dt., 5 de gen. 2021 a les 4:07: > > the mmsys will more and more complicated after support > more and more SoCs, add an independent folder will be > more clear > > Signed-off-by: Yongqiang Niu > --- >

Re: [PATCH v13 7/8] soc: mediatek: add mtk mutex support for MT8183

2021-02-09 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dv., 29 de gen. 2021 a les 10:23: > > From: Yongqiang Niu > > Add mtk mutex support for MT8183 SoC. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > Reviewed-by: CK Hu Reviewed-by: Enric Balletbo i Serra

Re: [PATCH v11 1/9] arm64: dts: mt8183: rename rdma fifo size

2021-01-28 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for the patch. Missatge de Hsin-Yi Wang del dia dj., 28 de gen. 2021 a les 8:28: > > From: Yongqiang Niu > > property name must include only lowercase and '-' > This is a leftover while I forward ported the patch, the rdma_fifo_size only existed on the downstream

Re: [PATCH v11 2/9] arm64: dts: mt8183: refine gamma compatible name

2021-01-28 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dj., 28 de gen. 2021 a les 8:28: > > From: Yongqiang Niu > > mt8183 gamma is different with mt8173 > remove mt8173 compatible name for mt8183 gamma > Should this patch contain? Fixes: 91f9c963ce79 ("arm64: dts: mt8183:

Re: [v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-28 Thread Enric Balletbo Serra
Hi Yongqiang, Missatge de Yongqiang Niu del dia ds., 25 de jul. 2020 a les 5:29: > > On Thu, 2020-07-23 at 11:32 +0200, Enric Balletbo Serra wrote: > > Hi Yongqiang Niu, > > > > Thank you for your patch. > > > > Missatge de Yongqiang Niu del dia

Re: [v7, PATCH 1/7] drm/mediatek: move ddp component defint into mtk_mmsys.h

2020-07-23 Thread Enric Balletbo Serra
Hi Yongqian Niu, Thank you for your patch Missatge de Yongqiang Niu del dia dj., 23 de jul. 2020 a les 4:05: > > move ddp component defint into mtk_mmsys.h > There is a typo, should be "defines". But why you should move these defines to mtk-mmsys? > Signed-off-by: Yongqiang Niu > --- >

Re: [v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-23 Thread Enric Balletbo Serra
Hi Yongqiang Niu, Thank you for your patch. Missatge de Yongqiang Niu del dia dj., 23 de jul. 2020 a les 4:05: > > add mmsys private data > I think this change requires a better explanation of what you are doing. Although I'm really uncomfortable with this change, why you need to create a new

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-18 Thread Enric Balletbo Serra
ang, > > > > > > On 14/5/20 18:44, Chun-Kuang Hu wrote: > > >> Hi, Enric: > > >> > > >> Enric Balletbo i Serra 於 2020年5月14日 週四 > > >> 下午11:42寫道: > > >>> > > >>> Hi Chun-Kuang, > > >>> &g

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-13 Thread Enric Balletbo Serra
Hi Chun-Kuang, Missatge de Enric Balletbo i Serra del dia dv., 1 de maig 2020 a les 17:25: > > Use the drm_bridge_connector helper to create a connector for pipelines > that use drm_bridge. This allows splitting connector operations across > multiple bridges when necessary, instead of having the

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-16 Thread Enric Balletbo Serra
Hi Adrian, [snip] > >> > >> +static void dw_mipi_dsi_get_hw_version(struct dw_mipi_dsi > >> *dsi) +{ + regmap_read(dsi->regs, DSI_VERSION, > >> >hw_version); + dsi->hw_version &= VERSION; + > >> if (!dsi->hw_version) + dev_err(dsi->dev, "Failed > >> to read DSI hw

Re: [PATCH v6 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

2020-04-15 Thread Enric Balletbo Serra
Hi Adrian, Thank you for your patch. Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 host > controller which is embedded in i.MX 6 SoCs. > > Based on following patches, but updated/extended to work with existing

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-15 Thread Enric Balletbo Serra
Hi Adrian, Some few comments/nits below, Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: > > In order to support multiple versions of the Synopsis MIPI DSI host > controller, which have different register layouts but almost identical > HW protocols, we add a regmap

Re: [PATCH v11 3/5] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-03-06 Thread Enric Balletbo Serra
Hi Stephen, Missatge de Stephen Boyd del dia dv., 6 de març 2020 a les 22:37: > > Quoting Enric Balletbo i Serra (2020-03-06 08:30:16) > > Hi Stephen, > > > > On 5/3/20 22:01, Stephen Boyd wrote: > > > Quoting Enric Balletbo i Serra (2020-03-02 03:01:26) > > >> From: Matthias Brugger > > >> > >

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-02-14 Thread Enric Balletbo Serra
Hi Vasily, Missatge de Vasily Khoruzhick del dia dv., 14 de febr. 2020 a les 23:17: > > On Fri, Feb 14, 2020 at 1:53 PM Enric Balletbo Serra > wrote: > > > > Hi Vasily, > > > > Missatge de Vasily Khoruzhick del dia dv., 14 de > > febr. 2020 a les 22:36: &

Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support

2020-02-14 Thread Enric Balletbo Serra
Hi Vasily, Missatge de Vasily Khoruzhick del dia dv., 14 de febr. 2020 a les 22:36: > > On Thu, Feb 13, 2020 at 6:54 AM Enric Balletbo i Serra > wrote: > > > > From: Nicolas Boichat > > > > ANX7688 is a HDMI to DP converter (as well as USB-C port controller), > > that has an internal

Re: [PATCH 2/2] drm/mediatek: add fb swap in async_update

2020-02-13 Thread Enric Balletbo Serra
Hi, Missatge de CK Hu del dia dj., 13 de febr. 2020 a les 5:06: > > Hi, Bibby: > > On Thu, 2020-02-13 at 09:23 +0800, Bibby Hsieh wrote: > > Besides x, y position, width and height, > > fb also need updating in async update. > > > > Reviewed-by: CK Hu > > > Fixes: 920fffcc8912 ("drm/mediatek:

Re: [PATCH] drm/mediatek: reduce the hbp and hfp for phy timing

2019-12-16 Thread Enric Balletbo Serra
Hi all, Missatge de Hsin-Yi Wang del dia dl., 16 de des. 2019 a les 3:42: > > On Fri, Dec 13, 2019 at 9:52 AM Jitao Shi wrote: > > > > There are some extra data transfer in dsi. > > ex. LPX, hs_prepare, hs_zero, hs_exit and the sof/eof of dsi packet. > > This signal will enlarge the line time.

Re: [PATCH v7 7/9] drm/mediatek: change the dsi phytiming calculate method

2019-12-12 Thread Enric Balletbo Serra
Hi, Missatge de CK Hu del dia dj., 26 de set. 2019 a les 10:51: > > Hi, Jitao: > > On Thu, 2019-09-19 at 14:58 +0800, Jitao Shi wrote: > > Change the method of frame rate calc which can get more accurate > > frame rate. > > > > data rate = pixel_clock * bit_per_pixel / lanes > > Adjust hfp_wc to

Re: [PATCH v20 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-11-21 Thread Enric Balletbo Serra
Hi, cc'ing the drm/bridge maintainers which I think are missing (Andrzej Hajda and Neil Armstrong) Missatge de Matthias Brugger del dia dl., 7 d’oct. 2019 a les 13:04: > > > > On 07/10/2019 10:22, Ulrich Hecht wrote: > > From: Jitao Shi > > > > This patch adds drm_bridge driver for parade DSI

Re: [PATCH 2/2 v2] drm/atomic: clear new_state pointers at hw_done

2019-11-12 Thread Enric Balletbo Serra
Hi Rob, Missatge de Rob Clark del dia dl., 4 de nov. 2019 a les 18:42: > > From: Rob Clark > > The new state should not be accessed after this point. Clear the > pointers to make that explicit. > > Signed-off-by: Rob Clark While looking to another issue I applied this patch on top of 5.4-rc7

Re: [PATCH v2 2/3] drm: Measure Self Refresh Entry/Exit times to avoid thrashing

2019-11-04 Thread Enric Balletbo Serra
Missatge de Enric Balletbo Serra del dia dc., 30 d’oct. 2019 a les 17:59: > > Hi Sean, > > Since 5.4-rc1 my Samsung Chromebook Plus (kevin) doesn't > suspend/resume correctly, at least once every ten suspend/resume > cycles the display doesn't turn on, and when this happen

Re: [PATCH v2 2/3] drm: Measure Self Refresh Entry/Exit times to avoid thrashing

2019-10-30 Thread Enric Balletbo Serra
Hi Sean, Since 5.4-rc1 my Samsung Chromebook Plus (kevin) doesn't suspend/resume correctly, at least once every ten suspend/resume cycles the display doesn't turn on, and when this happens the kernel log message reports: [ 60.420230] PM: suspend exit [ 60.463866] rockchip-dp ff97.edp:

Re: [PATCH v3 5/7] drm/bridge: Add Analogix anx6345 support

2019-07-25 Thread Enric Balletbo Serra
Hi, Missatge de Vasily Khoruzhick del dia dl., 22 de jul. 2019 a les 20:50: > > On Mon, Jul 22, 2019 at 8:11 AM Torsten Duwe wrote: > > > > From: Icenowy Zheng > > > > The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed > > for portable devices. This driver adds initial

Re: [PATCH v3] backlight: pwm_bl: Fix brightness levels for non-DT case.

2018-11-30 Thread Enric Balletbo Serra
Hi, Missatge de Enric Balletbo i Serra del dia dc., 7 de nov. 2018 a les 9:56: > > Commit '88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED > linearly to human eye")' allows the possibility to compute a default > brightness table when there isn't the brightness-levels property in the >

Re: [PATCH v2] drm/rockchip: update cursors asynchronously through atomic.

2018-11-19 Thread Enric Balletbo Serra
Hi Tomasz, cc'ing Helen as she will continue the work. Missatge de Tomasz Figa del dia dc., 14 de nov. 2018 a les 9:49: > > Hi Enric, > > On Fri, Sep 28, 2018 at 5:27 PM Enric Balletbo i Serra > wrote: > > > > Add support to async updates of cursors by using the new atomic > > interface for

Re: [PATCH v2] drm/rockchip: fix coding style and incorrect description

2018-08-28 Thread Enric Balletbo Serra
Missatge de Sandy Huang del dia dt., 28 d’ag. 2018 a les 9:45: > > Align with other drivers, tab + 2 space key for description. > and edp/hdmi/dsi can be used on both rk3288 and rk3399. > > Signed-off-by: Sandy Huang > --- > drivers/gpu/drm/rockchip/Kconfig | 14 +++--- > 1 file

Re: [PATCH] drm/rockchip: fix coding style and incorrect description

2018-08-27 Thread Enric Balletbo Serra
Hi Sandy, Just noticed a typo that I think will be good fix also Missatge de Sandy Huang del dia dl., 27 d’ag. 2018 a les 8:31: > > Align with other drivers, tab + 2 space key for description. > and this option should be enabled on both rk3288 and rk3399. > > Signed-off-by: Sandy Huang > --- >

Re: [RFC PATCH 03/10] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2018-06-16 Thread Enric Balletbo Serra
Hi Chanwoo, I'll send a new version soon, just wanted to ask some questions here. See below. Missatge de Chanwoo Choi del dia dt., 15 de maig 2018 a les 0:21: > > Hi, > > On 2018년 05월 15일 06:16, Enric Balletbo i Serra wrote: > > Trusted Firmware-A (TF-A) for rk3399 implements a SiP call to get

Re: [PATCH v7 5/5] drm/rockchip: support dp training outside dp firmware

2018-05-23 Thread Enric Balletbo Serra
2018-05-23 9:42 GMT+02:00 Lin Huang : > DP firmware uses fixed phy config values to do training, but some > boards need to adjust these values to fit for their unique hardware > design. So get phy config values from dts and use software link training > instead of relying on

Re: [PATCH v7 4/5] phy: rockchip-typec: support variable phy config value

2018-05-23 Thread Enric Balletbo Serra
2018-05-23 9:42 GMT+02:00 Lin Huang : > the phy config values used to fix in dp firmware, but some boards > need change these values to do training and get the better eye diagram > result. So support that in phy driver. > > Signed-off-by: Chris Zhong >

Re: [PATCH v7 3/5] soc: rockchip: split rockchip_typec_phy struct to separate header

2018-05-23 Thread Enric Balletbo Serra
2018-05-23 9:42 GMT+02:00 Lin Huang : > we may use rockchip_phy_typec struct in other driver, so split > it to separate header. > > Signed-off-by: Lin Huang > --- > Changes in v2: > - None > Changes in v3: > - None > Changes in v4: > - None > Changes in

Re: [PATCH v6 5/5] drm/rockchip: support dp training outside dp firmware

2018-05-22 Thread Enric Balletbo Serra
Lin, 2018-05-22 9:41 GMT+02:00 Enric Balletbo Serra <eballe...@gmail.com>: > Hi Lin > > 2018-05-22 3:08 GMT+02:00 hl <h...@rock-chips.com>: >> Hi Enric, >> >> >> >> >> On Monday, May 21, 2018 11:22 PM, Enric Balletbo Serra wrote: >&g

Re: [PATCH v4 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-22 Thread Enric Balletbo Serra
Hi Neil, 2018-05-21 16:21 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly

Re: [PATCH v6 5/5] drm/rockchip: support dp training outside dp firmware

2018-05-22 Thread Enric Balletbo Serra
Hi Lin 2018-05-22 3:08 GMT+02:00 hl <h...@rock-chips.com>: > Hi Enric, > > > > > On Monday, May 21, 2018 11:22 PM, Enric Balletbo Serra wrote: >> >> Hi Lin, >> >> 2018-05-21 11:37 GMT+02:00 Lin Huang <h...@rock-chips.com>: >>> >&g

Re: [PATCH v6 5/5] drm/rockchip: support dp training outside dp firmware

2018-05-21 Thread Enric Balletbo Serra
Hi Lin, 2018-05-21 11:37 GMT+02:00 Lin Huang : > DP firmware uses fixed phy config values to do training, but some > boards need to adjust these values to fit for their unique hardware > design. So get phy config values from dts and use software link training > instead of

Re: [PATCH v6 4/5] phy: rockchip-typec: support variable phy config value

2018-05-21 Thread Enric Balletbo Serra
Hi Lin, 2018-05-21 11:37 GMT+02:00 Lin Huang : > the phy config values used to fix in dp firmware, but some boards > need change these values to do training and get the better eye diagram > result. So support that in phy driver. > > Signed-off-by: Chris Zhong

Re: [PATCH v6 3/5] soc: rockchip: split rockchip_typec_phy struct to separate header

2018-05-21 Thread Enric Balletbo Serra
Hi Lin, 2018-05-21 11:37 GMT+02:00 Lin Huang : > we may use rockchip_phy_typec struct in other driver, so split > it to separate header. > That patch does more than just split some structs to a public header, it also introduces new structs and new parameters related to the

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly

Re: [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the A minor nit, there is a "consensus" on tell cros-ec as "ChromeOS Embedded Controller" or "ChromeOS EC". Yes, I know that you can see in the

Re: [PATCH v2 0/5] Add ChromeOS EC CEC Support

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:04 GMT+02:00 Neil Armstrong : > Hi All, > > The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support > through it's Embedded Controller, to enable the Linux CEC Core to communicate > with it and get the CEC Physical Address from the

Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-18 Thread Enric Balletbo Serra
2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong > --- > drivers/mfd/cros_ec_dev.c | 16 >

Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-15 Thread Enric Balletbo Serra
Hi Neil, I suspect that this patch will conflict with some patches that will be queued for 4.18 that also introduces new devices, well, for now I don't see these merged in the Lee's tree. Based on some reviews I got when I send a patch to this file ... 2018-05-15 17:29 GMT+02:00 Hans Verkuil

Re: [PATCH v3 1/4] drm/rockchip: add transfer function for cdn-dp

2018-05-14 Thread Enric Balletbo Serra
Hi Lin, 2018-05-14 11:53 GMT+02:00 Lin Huang : > From: Chris Zhong > > We may support training outside firmware, so we need support > dpcd read/write to get the message or do some setting with > display. > > Signed-off-by: Chris Zhong

Re: [PATCH v2 1/4] drm/rockchip: add transfer function for cdn-dp

2018-05-11 Thread Enric Balletbo Serra
Hi Lin, 2018-05-09 12:22 GMT+02:00 Lin Huang : > From: Chris Zhong > > We may support training outside firmware, so we need support > dpcd read/write to get the message or do some setting with > display. > > Signed-off-by: Chris Zhong

Re: [PATCH v2 3/4] Documentation: bindings: add phy_config for Rockchip USB Type-C PHY

2018-05-11 Thread Enric Balletbo Serra
Hi Lin, 2018-05-11 16:43 GMT+02:00 Sean Paul : > On Wed, May 09, 2018 at 06:22:43PM +0800, Lin Huang wrote: >> If want to do training outside DP Firmware, need phy voltage swing >> and pre_emphasis value. >> >> Signed-off-by: Lin Huang > > Adding Rob

Re: [PATCH 2/4] phy: rockchip-typec: support variable phy config value

2018-05-07 Thread Enric Balletbo Serra
Hi Lin, Thanks for the patch, apart from the new build warnings introduced some more comments below. 2018-05-04 10:08 GMT+02:00 Lin Huang : > the phy config values used to fix in dp firmware, but some boards > need change these values to do training and get the better eye

Re: [PATCH 4/4] drm/rockchip: support dp training outside dp firmware

2018-05-07 Thread Enric Balletbo Serra
Hi Lin, Thanks for the patch. 2018-05-04 10:08 GMT+02:00 Lin Huang : > DP firware use fix phy config value to do training, but some s/fiware/firmware/ > board need to adjust these value to fit for their hardware design, > so we use new phy config to do training outside

Re: [PATCH 1/4] drm/rockchip: add transfer function for cdn-dp

2018-05-07 Thread Enric Balletbo Serra
Hi Lin, I am interested in these patches, could you cc me on newer versions? Thanks. Some comments below. 2018-05-04 10:08 GMT+02:00 Lin Huang : > From: Chris Zhong > > We may support training outside firmware, so we need support > dpcd read/write to

Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier

2018-04-18 Thread Enric Balletbo Serra
Hi Andrzej, Tomasz 2018-04-16 15:12 GMT+02:00 Tomasz Figa : > Hi Andrzej, > > On Mon, Apr 16, 2018 at 6:57 PM Andrzej Hajda wrote: > >> On 05.04.2018 11:49, Enric Balletbo i Serra wrote: >> > From: Tomasz Figa >> > >> > It looks like

Re: [PATCH v3 6/6] arm64: dts: rockchip: Specify override mode for kevin panel

2018-02-19 Thread Enric Balletbo Serra
2018-02-08 18:48 GMT+01:00 Sean Paul : > This patch adds an override mode for kevin devices. The mode increases > both back porches to allow a pixel clock of 2kHz as opposed to the > 'typical' value of 252750kHz. This is needed to avoid interference with > the touch

Re: [PATCH v3 5/6] drm/panel: simple: Use display_timing for lq123p1jx31

2018-02-19 Thread Enric Balletbo Serra
Hi, 2018-02-08 18:48 GMT+01:00 Sean Paul : > Convert the sharp lq123p1jx31 from using a fixed mode to specifying a > display timing with min/typ/max values. This allows us to capture the > timings set forth in the datasheet as well as the additional values that > we've

Re: [PATCH v3 4/6] drm/panel: simple: Add ability to override typical timing

2018-02-19 Thread Enric Balletbo Serra
Hi, 2018-02-08 18:48 GMT+01:00 Sean Paul : > This patch adds the ability to override the typical display timing for a > given panel. This is useful for devices which have timing constraints > that do not apply across the entire display driver (eg: to avoid > crosstalk

Re: [PATCH v3 33/43] drm/panel: simple: Change mode for Sharp lq123p1jx31

2018-02-19 Thread Enric Balletbo Serra
Hi, 2018-02-16 21:54 GMT+01:00 Doug Anderson <diand...@chromium.org>: > Hi, > > On Fri, Feb 16, 2018 at 4:34 AM, Enric Balletbo Serra > <eballe...@gmail.com> wrote: >> Hi, >> >> 2018-01-31 17:52 GMT+01:00 Doug Anderson <diand...@chromium.org>: >

Re: [PATCH v3 33/43] drm/panel: simple: Change mode for Sharp lq123p1jx31

2018-02-16 Thread Enric Balletbo Serra
Hi, 2018-01-31 17:52 GMT+01:00 Doug Anderson : > Hi, > > > On Wed, Jan 31, 2018 at 7:16 AM, Sean Paul wrote: >> On Wed, Jan 31, 2018 at 7:54 AM, Lucas Stach wrote: >>> Am Dienstag, den 30.01.2018, 21:29 +0100 schrieb Thierry

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-11-10 Thread Enric Balletbo Serra
Dear all, 2017-11-01 20:33 GMT+01:00 Sean Paul : > On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote: >> Hi Heiko, >> >> On 10/31/2017 07:01 AM, Heiko Stuebner wrote: >> > As I was just looking at the edp dts change in patch1 again, does this >> > series also

Re: [PATCH 00/41] Chromebook Plus (aka kevin) kernel patches

2017-03-16 Thread Enric Balletbo Serra
2017-03-14 21:43 GMT+01:00 Sean Paul : > On Thu, Mar 09, 2017 at 11:32:15PM -0500, Sean Paul wrote: >> Despite our best intentions (and we did a decent job this time around) of >> submitting >> upstream first for the Chromebook Plus, we had a number of patches slip >>

[v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2016-11-10 Thread Enric Balletbo Serra
Hi Jitao, 2016-08-27 8:44 GMT+02:00 Jitao Shi : > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > --- > Changes since v16: > - Disable ps8640 DSI MCS Function. > - Rename gpios name more clearly. > - Tune the

[v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2016-10-18 Thread Enric Balletbo Serra
Hi Jitao, 2016-08-27 8:44 GMT+02:00 Jitao Shi : > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > --- > Changes since v16: > - Disable ps8640 DSI MCS Function. > - Rename gpios name more clearly. > - Tune the

[PATCH V4 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2016-08-05 Thread Enric Balletbo Serra
Hi Peter, Only one comment below and one nitpick 2016-08-05 0:37 GMT+02:00 Peter Senna Tschudin : > Add a driver that create a drm_bridge and a drm_connector for the LVDS > to DP++ display bridge of the GE B850v3. > > There are two physical bridges on the video signal pipeline: a > STDP4028(LVDS

[PATCH V4 2/4] Documentation/devicetree/bindings: b850v3_lvds_dp

2016-08-05 Thread Enric Balletbo Serra
Hi Peter, 2016-08-05 0:36 GMT+02:00 Peter Senna Tschudin : > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ > display bridge. > > Cc: Javier Martinez Canillas > Cc: Enric Balletbo i Serra > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Fabio Estevam > Signed-off-by: Peter Senna

[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-08-04 Thread Enric Balletbo Serra
2016-07-12 12:13 GMT+02:00 Daniel Vetter : > On Wed, Jun 29, 2016 at 6:31 AM, Daniel Kurtz wrote: >> On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov >> wrote: +static ssize_t ps8640_update_fw_store(struct device *dev, + struct device_attribute *attr,

[PATCH V2 4/5] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2016-06-10 Thread Enric Balletbo Serra
Hi Peter, Only a few comments ;) 2016-06-09 18:25 GMT+02:00 Peter Senna Tschudin : > Add a driver that create a drm_bridge and a drm_connector for the LVDS > to DP++ display bridge of the GE B850v3. > > There are two physical bridges on the video signal pipeline: a > STDP4028(LVDS to DP) and a

[PATCH v5 1/2] drm/bridge: Add sii902x driver

2016-06-03 Thread Enric Balletbo Serra
Hi Boris, A few comments below ... 2016-06-02 17:00 GMT+02:00 Boris Brezillon : > Add basic support for the sii902x RGB -> HDMI bridge. > This driver does not support audio output yet. > > Signed-off-by: Boris Brezillon > Tested-by: Nicolas Ferre > --- > Hello, > > This patch is only adding

[PATCH 4/5] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2016-05-31 Thread Enric Balletbo Serra
Hi Peter, Just some comments that I received when I submitted my bridge patches and that I think can help you ... 2016-05-30 18:39 GMT+02:00 Peter Senna Tschudin : > This driver creates a drm_bridge and a drm_connector for the LVDS to DP++ > display bridge of the GE B850v3(imx6q-b850v3.dts).

[RESEND PATCH v4 4/4] drm: bridge: anx78xx: Add anx78xx driver support.

2016-05-02 Thread Enric Balletbo Serra
Hi Thierry, 2016-05-02 16:22 GMT+02:00 Thierry Reding : > On Mon, May 02, 2016 at 09:54:26AM +0200, Enric Balletbo i Serra wrote: > [...] >> diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c >> b/drivers/gpu/drm/bridge/analogix-anx78xx.c > [...] >> +static int anx78xx_init_pdata(struct

[PATCH] [media] hdmi: added functions for MPEG InfoFrames

2015-12-09 Thread Enric Balletbo Serra
Hello Thierry, 2015-11-19 13:29 GMT+01:00 Enric Balletbo Serra : > Hello Thierry, > > 2015-11-19 12:51 GMT+01:00 Thierry Reding : >> On Tue, Nov 17, 2015 at 11:55:53PM +0100, Enric Balletbo Serra wrote: >>> Hello Thierry, >>> >>> 2015-11-17 13:55 GMT+0

[PATCHv6 5/5] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-12-09 Thread Enric Balletbo Serra
Hi Dan, Many thanks for your comments. 2015-12-07 9:09 GMT+01:00 Dan Carpenter : > On Fri, Dec 04, 2015 at 09:35:07AM +0100, Enric Balletbo i Serra wrote: >> +static int sp_wait_aux_op_finish(struct anx78xx *anx78xx) >> +{ >> + u8 errcnt; >> + u8 val; >> + struct device *dev =

[PATCH] [media] hdmi: added functions for MPEG InfoFrames

2015-11-19 Thread Enric Balletbo Serra
Hello Thierry, 2015-11-19 12:51 GMT+01:00 Thierry Reding : > On Tue, Nov 17, 2015 at 11:55:53PM +0100, Enric Balletbo Serra wrote: >> Hello Thierry, >> >> 2015-11-17 13:55 GMT+01:00 Thierry Reding : >> > On Mon, Nov 16, 2015 at 05:28:24PM +0100, Enric Balletbo Se

[PATCH] [media] hdmi: added functions for MPEG InfoFrames

2015-11-17 Thread Enric Balletbo Serra
Hello Thierry, 2015-11-17 13:55 GMT+01:00 Thierry Reding : > On Mon, Nov 16, 2015 at 05:28:24PM +0100, Enric Balletbo Serra wrote: >> Hello Thierry, >> >> Many thanks for your comments. >> >> 2015-11-16 12:50 GMT+01:00 Thierry Reding : >> > On Sat, Nov 14

[PATCH] [media] hdmi: added functions for MPEG InfoFrames

2015-11-16 Thread Enric Balletbo Serra
Hello Thierry, Many thanks for your comments. 2015-11-16 12:50 GMT+01:00 Thierry Reding : > On Sat, Nov 14, 2015 at 07:38:19PM +0100, Enric Balletbo i Serra wrote: >> The MPEG Source (MS) InfoFrame is in EIA/CEA-861B. It describes aspects of >> the compressed video stream that were used to

[PATCHv5 1/3] of: Add vendor prefix for Analogix Semiconductor, Inc.

2015-11-13 Thread Enric Balletbo Serra
Hi Rob, 2015-11-13 15:38 GMT+01:00 Rob Herring : > On Fri, Nov 13, 2015 at 01:01:02PM +0100, Enric Balletbo i Serra wrote: >> Analogix Semiconductor develops analog and mixed-signal devices for digital >> media and communications interconnect applications. >> >> Signed-off-by: Enric Balletbo i

[PATCHv3 2/3] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-09-10 Thread Enric Balletbo Serra
2015-09-10 18:35 GMT+02:00 Enric Balletbo i Serra : > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portable devices. > > You can add support to your board with current binding. > > Example: > > anx7814: anx7814 at 38 { > compatible

[PATCHv2 2/3] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-09-10 Thread Enric Balletbo Serra
Hi Rob, 2015-09-09 2:40 GMT+02:00 Rob Herring : > On 09/08/2015 02:25 AM, Enric Balletbo i Serra wrote: >> The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter >> designed for portable devices. >> >> You can add support to your board with current binding. >> >> Example: >> >>

[PATCH 3/3] staging: slimport: Add anx7814 driver support by analogix.

2015-09-09 Thread Enric Balletbo Serra
Hi Dan, Many thanks for this first review. 2015-09-09 5:38 GMT+02:00 Daniel Kurtz : > Hi Eric, > > Thanks for starting to upstream this Analogix Slimport driver! > As Greg says, please move this driver to its intended directory, I presume: > /drivers/gpu/drm/bridge > I sent yesterday another

  1   2   >