gt; ---
>
> Changes in v2:
> - Replace kmap() with kmap_local_page().
> - Change commit subject and message.
With the changes that Ira suggested and the minor fix I'm proposing to the
commit message, it looks good to me too, so this patch is...
Reviewed-by: Fabio M. De Francesco
On mercoledì 21 giugno 2023 11:06:51 CEST Thomas Hellström (Intel) wrote:
>
> I think one thing worth mentioning in the context of this patch is that
> IIRC kmap_local_page() will block offlining of the mapping CPU until
> kunmap_local(),
Migration is disabled.
> so while I haven't seen any guid
On martedì 20 giugno 2023 20:01:48 CEST Sumitra Sharma wrote:
> Remove unnecessary calls to kmap{,_atomic}() when acquiring
> pages using GFP_DMA32.
>
> The GFP_DMA32 uses the DMA32 zone to satisfy the allocation
> requests. Therefore, pages allocated with GFP_DMA32 cannot
> come from Highmem.
>
break the above-mentioned constraint, so it should be
preferred to kmap().
Therefore, replace kmap() with kmap_local_page() in i915/gt.
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++--
drivers/gpu/drm/i915/gt/shmem_ut
k the above-mentioned constraint, so it should be
preferred to kmap().
Therefore, replace kmap() with kmap_local_page() in i915/gem and use
memcpy_to_page() where it is possible to avoid the open coding of
mapping + memcpy() + un-mapping.
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Fran
break the above-mentioned constraint, so it should be
preferred to kmap().
Therefore, replace kmap() with kmap_local_page() in i915_gem.c
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/i915_gem.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
: Fabio M. De Francesco
v1->v2: Do some changes in the text of the cover letter and in the
commit messages. There are no changes in the code of any of the three
patches.
Fabio M. De Francesco (3):
drm/i915: Replace kmap() with kmap_local_page()
drm/i915/gt: Replace kmap() with kmap_local_p
t; >>
> >> Convert the calls of kmap_atomic() / kunmap_atomic() to
> >> kmap_local_page() / kunmap_local().
> >>
> >> [1]:
> >> https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
> >>
> >> v2: No code change since v1. Adde
in full.
I don't see things to improve (except all those "kamp_atomic()" typo in the
patches summary; however, typos are only in the cover so I'm sure they won't
hurt anybody).
Each of the nine patches listed above looks good to me, so they are all…
Reviewed-by: Fabio M
message explains clearly and the changes to the code look good. The
necessity to reuse pagefault_disable() / pagefault_enable() from the main
kmap_atomic() side effect is a nice catch.
Reviewed-by: Fabio M. De Francesco
Thanks!
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> b/drivers/gpu/
On giovedì 3 novembre 2022 17:51:23 CET Ira Weiny wrote:
> On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote:
> > On lunedì 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote:
> > > From: Zhao Liu
> > >
> > > The use of kmap_atom
On lunedì 17 ottobre 2022 18:53:24 CET Alex Deucher wrote:
> Applied. Thanks!
>
The same report about which I just wrote in my previous email to you is also
referring to this patch which later changed status to "Not Applicable".
It points to https://patchwork.linuxtv.org/project/linux-media/pa
On lunedì 17 ottobre 2022 18:52:10 CET Alex Deucher wrote:
> Applied. Thanks!
Many thanks to you!
However, about a week ago, I received a report saying that this patch is "Not
Applicable".
That email was also referring to another patch, for which I'll reply in its
own thread.
That report ha
cal_page() / kunmap_local().
>
I have here the same questions as in 1/9.
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
> Suggested-by: Fabio M. De Francesco
> Signed-off-by: Zhao Liu
&g
he redundant variable that stores the address of the mapped
> page since kunmap_local() can accept any pointer within the page.
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
> Suggested-by: Fabio
On lunedì 17 ottobre 2022 11:37:16 CEST Zhao Liu wrote:
> From: Zhao Liu
>
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].
Some words to explain why kmap_atomic was deprecated won't hurt. Many
maintainers and reviewers, and also casual readers might not yet be
+ memcpy + local unmap, use memcpy_to_page() in a
suited call site.
Cc: "Venkataramanan, Anirudh"
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 +
+ memcpy() + local unmappings, use
the memcpy_{from,to}_page() helpers where these are better suited.
Cc: "Venkataramanan, Anirudh"
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++--
drivers/gpu/drm/i915/gt/shm
irudh"
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/i915_gem.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 702e5b89be22..43effce60e1b 100644
--- a/d
e I'm
adding one more recipient (Anirudh) who is helping, along with others, Ira
and me with these conversions / removals of kmap() and kmap_atomic()
Cc: "Venkataramanan, Anirudh"
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
Fabio M. De Francesco (3):
drm/i915:
Acked-by: Christian König
Signed-off-by: Fabio M. De Francesco
---
I'm resending because I suspect that this patch might have been lost. In
the meantime I added an "Acked-by" tag from Christian K.. Obviviously,
there are no further changes in the code.
drivers/gpu/drm/amd/amdg
. Furthermore,
the tasks can be preempted and, when they are scheduled to run again, the
kernel virtual addresses are restored and still valid.
Therefore, replace kmap() with kmap_local_page() in radeon_ttm_gtt_read().
Cc: "Venkataramanan, Anirudh"
Suggested-by: Ira Weiny
Signed-off-b
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 3b4c19412625..c11657b5915f 100644
--- a/drivers
-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++--
drivers/gpu/drm/i915/gt/shmem_utils.c| 11 ---
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c
b/drivers/gpu/drm/i915/gt
32 bits system, booting a kernel
with HIGHMEM enabled. Unfortunately I have no i915 based hardware,
therefore any help with testing would be greatly appreciated.
Suggested-by: Ira Weiny
Signed-off-by: Fabio M. De Francesco
Fabio M. De Francesco (3):
drm/i915: Replace kmap() with kmap_local_page
-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
b/drivers/gpu/drm/i915/gem
-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/i915/i915_gem.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 702e5b89be22..43effce60e1b 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b
On martedì 8 febbraio 2022 08:51:29 CET syzbot wrote:
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit:555f3d7be91a Merge tag '5.17-rc3-ksmbd-server-fixes' of gi..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=130a0c2c70
>
In the documentation of functions, removed excess parameters, described
undocumented ones, and fixed syntax errors.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Cc'ed all the maintainers.
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 12 ++--
drivers/gpu/dr
drm_send_event_helper() has not prototype, it has internal linkage and
therefore it should be defined with storage class 'static'.
Signed-off-by: Fabio M. De Francesco
---
Changes from v2: Removed all the other lines in function comment.
Changes from v1: As suggested by Daniel Vette
drm_modeset_lock_all() is not needed here, so it is replaced with
drm_modeset_lock(). The crtc list around which we are looping never
changes, therefore the only lock we need is to protect access to
crtc->state.
Suggested-by: Daniel Vetter
Suggested-by: Matthew Wilcox
Signed-off-by: Fabio M.
drm_send_event_helper() has not prototype, it has internal linkage and
therefore it should be defined with storage class 'static'.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: As suggested by Daniel Vetter, removed unnecessary
kernel-doc comments.
drivers/gpu/drm/drm_f
drm_modeset_lock_all() is not needed here, so it is replaced with
drm_modeset_lock(). The crtc list around which we are looping never
changes, therefore the only lock we need is to protect access to
crtc->state.
Suggested-by: Daniel Vetter
Suggested-by: Matthew Wilcox
Signed-off-by: Fabio M.
On Monday, April 26, 2021 6:11:11 PM CEST Daniel Vetter wrote:
> On Thu, Apr 22, 2021 at 05:50:34PM +0100, Matthew Wilcox wrote:
> > On Thu, Apr 22, 2021 at 05:59:51PM +0200, Fabio M. De Francesco wrote:
> > > - drm_modese
Fixed kernel-doc syntax errors in documentation of functions.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Reword both the subject and the log message
drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
Fixed a kernel-doc error in the documentation of a function.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
In the documentation of functions, fixed kernel-doc syntax errors.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c
b
In the function documentation, I removed the excess parameters,
described the undocumented ones, and fixed the syntax errors.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 12 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 4
drm_modeset_lock_all() is not needed here, so it is replaced with
drm_modeset_lock(). The crtc list around which we are looping never
changes, therefore the only lock we need is to protect access to
crtc->state.
Suggested-by: Daniel Vetter
Suggested-by: Matthew Wilcox
Signed-off-by: Fabio M.
drm_send_event_helper() has not prototype, it has internal linkage and
therefore it should be defined with storage class 'static'.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/dr
drm_modeset_lock_all() is not needed here, so it is replaced with
drm_modeset_lock(). The crtc list around which we are looping never
changes, therefore the only lock we need is to protect access to
crtc->state.
Suggested-by: Daniel Vetter
Suggested-by: Matthew Wilcox
Signed-off-by: Fabio M.
This second patch makes use of the API that has been introduced with commit
b7ea04d299c7: DRM_MODESET_LOCK_ALL_BEGIN() simplifies grabbing all modeset
locks using a local context and has the advantage of reducing boilerplate.
Signed-off-by: Fabio M. De Francesco
---
Changes from v2: The work is
required for modeset state changes.
Signed-off-by: Fabio M. De Francesco
---
Changes from v2: The work is split in two consecutive logical steps.
Changes from v1: Added further information to the commit message.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 ++---
1 file changed, 10
information to the commit message.
Fabio M. De Francesco (2):
drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_lock_all() with
drm_modeset_lock_all_ctx()
drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_*_all_ctx() with
DRM_MODESET_LOCK_ALL_*()
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6
On Tuesday, April 20, 2021 7:49:35 PM CEST Daniel Vetter wrote:
> On Mon, Apr 19, 2021 at 05:03:40PM +0200, Fabio M. De Francesco wrote:
> > Replace the deprecated API with new helpers, according to the TODO list
> > of the DRM subsystem. The new API has been introdu
-off-by: Fabio M. De Francesco
---
Changes from v1: Added further information to the commit message.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
-off-by: Fabio M. De Francesco
---
Changes from v1: Added further information in the commit message.
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd
.
Changes from v1: Added further information to the commit message.
Fabio M. De Francesco (2):
drm/amd/amdgpu/amdgpu_device.c: Replace drm_modeset_*_all with
DRM_MODESET_LOCK_ALL_*
drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_*_all with
DRM_MODESET_LOCK_ALL_*
drivers/gpu/drm/amd/amdgpu
On Monday, April 19, 2021 3:08:51 PM CEST Julia Lawall wrote:
> On Mon, 19 Apr 2021, Fabio M. De Francesco wrote:
> > Replace the deprecated API with new helpers, according to the TODO list
> > of the DRM subsystem.
>
> The commit message will perhaps not be very meaning
Replace the deprecated API with new helpers, according to the TODO list
of the DRM subsystem.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b
Replace the deprecated API with new helpers, according to the TODO list
of the DRM subsystem.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
According to the TODO list of the DRM subsystem, replace the deprecated
drm_modeset_*_all() with DRM_MODESET_LOCK_ALL_*().
Fabio M. De Francesco (2):
drm/amd/amdgpu/amdgpu_device.c: Replace drm_modeset_*_all with
DRM_MODESET_LOCK_ALL_*
drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_
Replace the deprecated API with DRM_MODESET_LOCK_ALL_* helpers (according
to the TODO list of the DRM subsystem).
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
Added a "break" in the default case of a switch select statement.
GCC complains, although this "break" is not strictly necessary
for the code to work as expected.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Added the reason why of this change in the lo
On Saturday, April 17, 2021 5:45:46 PM CEST Julia Lawall wrote:
> On Sat, 17 Apr 2021, Fabio M. De Francesco wrote:
> > Added a 'break' in the default case of a switch selection statement.
>
> Why?
>
GCC issues a warning, even if it is not strictly necessary for the co
Added a 'break' in the default case of a switch selection statement.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/drm_bufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index e3d77dfefb0a..fc
On Thursday, April 15, 2021 9:57:07 PM CEST Julia Lawall wrote:
> On Thu, 15 Apr 2021, Fabio M. De Francesco wrote:
> > Removed two set but unused variables.
>
> Would it be useful to use the values?
>
It would be useful if one wants to check returns for errors (which ar
Removed two set but unused variables.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index
Removed two variables set but unused.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c
b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 2d5d68fc15c2..d0eac5375533 100644
--- a
Corrected comments format in accordance to the Linux style guides.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Rewrote the "Subject" of the patches in the series
drivers/gpu/drm/drm_atomic_helper.c | 32 +++--
1 file changed, 21 inserti
Replaced "unsigned with "unsigned int" since the latter is preferred.
Signed-off-by: Fabio M. De Francesco
---
Changes from v1: Rewrote the "Subject" of the patches in the series
drivers/gpu/drm/drm_atomic_helper.c | 8
1 file changed, 4 insertions(+), 4 d
Replaced "unsigned" with "unsigned int" and formatted comments according
to the Linux style guidelines. Issues detected by checkpatch.pl.
Changes from v1: Rewrote the "Subject" of the patches in the series.
Fabio M. De Francesco (2):
gpu: drm: Replace "unsig
On Monday, April 12, 2021 2:11:59 PM CEST Daniel Vetter wrote:
> On Mon, Apr 12, 2021 at 12:53:09PM +0200, Fabio M. De Francesco wrote:
> > Replaced the type "unsigned" with "unsigned int" because it is
> > preferred. Issue detected by checkpatch.pl
Corrected comments format in accordance to the Linux style guides.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/drm_atomic_helper.c | 32 +++--
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu
Replaced "unsigned" with "unsigned int" and formatted comments according
to the Linux style guidelines. Issues detected by checkpatch.pl.
Fabio M. De Francesco (2):
gpu: drm: Replace "unsigned" with "unsigned int"
gpu: drm: Correct comments format
Replaced "unsigned with "unsigned int" since the latter is preferred.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/drm_atomic_helper.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/
Replaced the type "unsigned" with "unsigned int" because it is
preferred. Issue detected by checkpatch.pl.
Signed-off-by: Fabio M. De Francesco
---
drivers/gpu/drm/drm_atomic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic
67 matches
Mail list logo
