On Mon, Oct 22, 2018 at 08:31:42AM -0400, Sean Paul wrote:
> On Sun, Oct 21, 2018 at 10:27:01PM -0300, Rodrigo Siqueira wrote:
> > Add maintainers and reviewers for VKMS driver
> >
> > Signed-off-by: Rodrigo Siqueira
>
> Acked-by: Sean Paul
>
On Tue, Sep 11, 2018 at 08:06:31PM +0200, Daniel Vetter wrote:
> On Fri, Sep 07, 2018 at 08:41:36PM +0300, Haneen Mohammed wrote:
> > Add an initial kerneldoc entry for vkms with a todo list.
> >
> > Signed-off-by: Haneen Mohammed
> > ---
> > Doc
Add an initial kerneldoc entry for vkms with a todo list.
Signed-off-by: Haneen Mohammed
---
Documentation/gpu/drivers.rst | 1 +
Documentation/gpu/todo.rst | 12
Documentation/gpu/vkms.rst | 21 +
drivers/gpu/drm/vkms/vkms_drv.c | 9 +
4
.
Signed-off-by: Haneen Mohammed
---
v2:
- clear alpha channel before computing crc for XRGB
drivers/gpu/drm/vkms/vkms_crc.c | 154 +-
drivers/gpu/drm/vkms/vkms_drv.h | 5 +-
drivers/gpu/drm/vkms/vkms_plane.c | 10 +-
3 files changed, 143 insertions(+), 26 deletions
On Wed, Sep 05, 2018 at 04:03:26PM +0200, Daniel Vetter wrote:
> On Tue, Sep 04, 2018 at 12:18:17AM +0300, Haneen Mohammed wrote:
> > crtc_state is accessed by both vblank_handle() and the ordered
> > work_struct handle vkms_crc_work_handle() to retrieve and or update
> >
Add cursor plane support and update vkms_plane_atomic_check to enable
positioning cursor plane.
Signed-off-by: Haneen Mohammed
---
v2:
- nothing
drivers/gpu/drm/vkms/vkms_drv.h| 11 +++---
drivers/gpu/drm/vkms/vkms_output.c | 16 ---
drivers/gpu/drm/vkms/vkms_plane.c | 33
Cursor support is not complete yet. Add module option 'enable_cursor'
to enable/disable cursor support which is used for testing currently.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_drv.c| 4
drivers/gpu/drm/vkms/vkms_drv.h| 2 ++
drivers/gp
This patchset adds cursor plane support and compute CRC for output frame
with cursor and primary plane.
changes in v2:
- clear alpha channel before computing crc for XRGB plane format
- add module option 'enable_cursor' to enable/disable cursor support
Haneen Mohammed (3):
drm/vkms:
between hrtimer callback
and ordered work_struct handle.
This patch passes the following subtests from igt kms_pipe_crc_basic test:
bad-source, read-crc-pipe-A, read-crc-pipe-A-frame-sequence,
nonblocking-crc-pipe-A, nonblocking-crc-pipe-A-frame-sequence
Signed-off-by: Haneen Mohammed
---
v2:
- use u64
On Fri, Aug 31, 2018 at 10:41:40AM +0200, Daniel Vetter wrote:
> On Fri, Aug 24, 2018 at 02:16:34AM +0300, Haneen Mohammed wrote:
> > crtc_state is accessed by both vblank_handle() and the ordered
> > work_struct handle vkms_crc_work_handle() to retrieve and or update
> >
e-sequence,
nonblocking-crc-pipe-A, nonblocking-crc-pipe-A-frame-sequence
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_crc.c | 33 ++--
drivers/gpu/drm/vkms/vkms_crtc.c | 13 +++--
drivers/gpu/drm/vkms/vkms_drv.h | 6 --
3 files c
On Tue, Aug 14, 2018 at 09:52:33PM +0200, Daniel Vetter wrote:
> On Tue, Aug 14, 2018 at 9:03 PM, Haneen Mohammed
> wrote:
> > On Tue, Aug 14, 2018 at 10:21:29AM +0200, Daniel Vetter wrote:
> >> On Mon, Aug 13, 2018 at 11:04:11PM +0300, Haneen Mohammed wrote:
> >> &
On Tue, Aug 14, 2018 at 09:52:33PM +0200, Daniel Vetter wrote:
> On Tue, Aug 14, 2018 at 9:03 PM, Haneen Mohammed
> wrote:
> > On Tue, Aug 14, 2018 at 10:21:29AM +0200, Daniel Vetter wrote:
> >> On Mon, Aug 13, 2018 at 11:04:11PM +0300, Haneen Mohammed wrote:
> >> &
On Tue, Aug 14, 2018 at 10:21:29AM +0200, Daniel Vetter wrote:
> On Mon, Aug 13, 2018 at 11:04:11PM +0300, Haneen Mohammed wrote:
> > On Wed, Aug 08, 2018 at 10:23:27AM +0200, Daniel Vetter wrote:
> > > On Wed, Aug 08, 2018 at 06:53:17AM +0300, Haneen Mohammed wrote:
> >
On Wed, Aug 08, 2018 at 10:23:27AM +0200, Daniel Vetter wrote:
> On Wed, Aug 08, 2018 at 06:53:17AM +0300, Haneen Mohammed wrote:
> > On Tue, Aug 07, 2018 at 06:33:36PM +0200, Daniel Vetter wrote:
> > > On Mon, Aug 06, 2018 at 06:58:29AM +0300, Haneen Mohammed wrote:
> > &g
On Wed, Aug 01, 2018 at 12:08:07PM +0300, Haneen Mohammed wrote:
> Move vmap_count out of the conditional statement since it needs
> to be updated for every successful call to vkms_gem_vmap.
>
> Signed-off-by: Haneen Mohammed
> ---
> drivers/gpu/drm/vkms/vkms_gem.c | 3 +--
&g
On Tue, Aug 07, 2018 at 06:33:36PM +0200, Daniel Vetter wrote:
> On Mon, Aug 06, 2018 at 06:58:29AM +0300, Haneen Mohammed wrote:
> > This patch compute CRC for output frame with cursor and primary plane.
> > Blend cursor with primary plane and compute CRC on the resulted frame.
Release pages_lock before return when vkms_obj->vaddr is NULL.
This patch fixes: 6c234fe37c57 ("drm/vkms: Implement CRC debugfs API").
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_crc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers
This patchset add support for cursor plane and compute CRC for output
frame with cursor and primary planes.
This currently passes cursor-size-change, onscreen, offscreen, sliding,
random, dpms, and rapid-movement igt tests with 64x64 cursor.
Haneen Mohammed (2):
drm/vkms: Add cursor plane
This patch compute CRC for output frame with cursor and primary plane.
Blend cursor with primary plane and compute CRC on the resulted frame.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_crc.c | 149 +-
drivers/gpu/drm/vkms/vkms_drv.h | 5
On Fri, Aug 03, 2018 at 12:53:36PM -0400, Sean Paul wrote:
> On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote:
> > This patch implement the necessary functions to compute and add CRCs
> > entries:
> >
> > - Implement the set_crc_source() callback.
>
Add cursor plane support and update vkms_plane_atomic_check to enable
positioning cursor plane.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_drv.h| 11 +++---
drivers/gpu/drm/vkms/vkms_output.c | 16 ---
drivers/gpu/drm/vkms/vkms_plane.c | 33
This patchset implement CRC debugfs API and add functions needed to compute
and add CRCs entries.
Haneen Mohammed (2):
drm/vkms: Subclass plane state
drm/vkms: Implement CRC debugfs API
drivers/gpu/drm/vkms/Makefile | 2 +-
drivers/gpu/drm/vkms/vkms_crc.c | 95
Subclass plane state struct to enable storing driver's private
state. This patch only adds the base drm_plane_state struct and
the atomic functions that handle it.
Signed-off-by: Haneen Mohammed
Reviewed-by: Sean Paul
---
drivers/gpu/drm/vkms/vkms_drv.h | 11
drivers/gpu/drm
anup_fb ->vunmap vkms_gem_obj->vaddr
2- @crtc_destroy -> flush work struct
3- @plane_destroy -> a) if (fb refcount) remove reference to fb
b) deallocate crc_data
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- remove vkms_crc_data for primary plane from vkms_ou
Move vmap_count out of the conditional statement since it needs
to be updated for every successful call to vkms_gem_vmap.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_gem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b
On Wed, Jul 18, 2018 at 02:44:18PM -0400, Sean Paul wrote:
> On Wed, Jul 18, 2018 at 07:24:34PM +0300, Haneen Mohammed wrote:
> > First, just so you have the complete view, this is the missing part in this
> > patch:
> > -- vkms_crc.c
> > static uint32_t _vkms_g
Subclass plane state struct to enable storing driver's private
state. This patch only adds the base drm_plane_state struct and
the atomic functions that handle it.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_drv.h | 10 +++
drivers/gpu/drm/vkms/vkms_plane.c
anup_fb ->vunmap vkms_gem_obj->vaddr
2- @crtc_destroy -> flush work struct
3- @plane_destroy -> a) if (fb refcount) remove reference to fb
b) deallocate crc_data
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/Makefile
This patchset implement CRC debugfs API and add functions needed to compute
and add CRCs entries.
Haneen Mohammed (2):
drm/vkms: Subclass plane state
drm/vkms: Implement CRC debugfs API
drivers/gpu/drm/vkms/Makefile | 2 +-
drivers/gpu/drm/vkms/vkms_crc.c | 75
Call atomic_helper_check_plane_state to clip plane coordinates.
Signed-off-by: Haneen Mohammed
Reviewed-by: Sean Paul
---
Changes in v2:
- check for plane_state->visible since we can't handle a disabled
primary plane yet.
drivers/gpu/drm/vkms/vkms_plan
Subclass CRTC state struct to enable storing driver's private
state. This patch only adds the base drm_crtc_state struct and
the atomic functions that handle it.
Signed-off-by: Haneen Mohammed
Reviewed-by: Daniel Vetter
Reviewed-by: Sean Paul
---
drivers/gpu/drm/vkms/vkms_crtc.c
This patch map/unmap GEM backing memory to kernel address space
in prepare/cleanup_fb respectively and cache the virtual address
for later use.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- use vkms_gem_vunmap
Changes in v3:
- return error number instead of vkms_obj->vaddr
Changes in
This patch add the necessary functions to map/unmap GEM
backing memory to the kernel's virtual address space.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- add vkms_gem_vunmap
- use vmap_count to guard against multiple prepare_fb calls on the same fb
Changes in v3:
- change vkms_gem
t CRC debugfs API" from this patchset
since it needs further work.
Haneen Mohammed (4):
drm/vkms: Add functions to map/unmap GEM backing storage
drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks
drm/vkms: Add atomic_helper_check_plane_state
drm/vkms: subclass CRTC state
drive
Call atomic_helper_check_plane_state to clip plane coordinates.
Signed-off-by: Haneen Mohammed
Reviewed-by: Sean Paul
---
Changes in v2:
- check for plane_state->visible since we can't handle a disabled
primary plane yet.
drivers/gpu/drm/vkms/vkms_plan
auto") == 0) {
out->crc_enabled = true;
} else {
out->crc_enabled = false;
return -EINVAL;
}
*values_cnt = 1;
return 0;
}
--- end vkms_crc.c
On Tue, Jul 17, 2018 at 05:05:03PM -0400, Sean Paul wrote:
> O
atomic update, by
using spinlock across atomic_begin and atomic_flush to wrap the event
handling code completely and match the flip event with the CRC.
Signed-off-by: Haneen Mohammed
---
Changes in v3:
- flush work item instead of workqueue
- include missing vkms_crc.c file
drivers/gpu/drm/vkms
On Wed, Jul 18, 2018 at 02:44:18PM -0400, Sean Paul wrote:
> On Wed, Jul 18, 2018 at 07:24:34PM +0300, Haneen Mohammed wrote:
> > First, just so you have the complete view, this is the missing part in this
> > patch:
> > -- vkms_crc.c
> > static uint32_t _vkms_g
This patch map/unmap GEM backing memory to kernel address space
in prepare/cleanup_fb respectively and cache the virtual address
for later use.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- use vkms_gem_vunmap
Changes in v3:
- return error number instead of vkms_obj->vaddr
drivers/
Subclass CRTC state struct to enable storing driver's private
state. This patch only adds the base drm_crtc_state struct and
the atomic functions that handle it.
Signed-off-by: Haneen Mohammed
Reviewed-by: Daniel Vetter
Reviewed-by: Sean Paul
---
drivers/gpu/drm/vkms/vkms_crtc.c
of the buffer with
appropriate synchronization methods.
Haneen Mohammed (5):
drm/vkms: Add functions to map/unmap GEM backing storage
drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks
drm/vkms: Add atomic_helper_check_plane_state
drm/vkms: subclass CRTC state
drm/vkms: Implement
This patch add the necessary functions to map/unmap GEM
backing memory to the kernel's virtual address space.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- add vkms_gem_vunmap
- use vmap_count to guard against multiple prepare_fb calls on the same
fb
Changes in v3:
- change vkms_gem
On Mon, Jul 16, 2018 at 02:22:56PM -0400, Sean Paul wrote:
> On Sat, Jul 14, 2018 at 03:23:32PM +0300, Haneen Mohammed wrote:
> > Implement the set_crc_source() callback.
> > Compute CRC using crc32 on the visible part of the framebuffer.
> > Use ordered workqueue to compute a
This patch map/unmap GEM backing memory to kernel address space
in prepare/cleanup_fb respectively and cache the virtual address
for later use.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- use vkms_gem_vunmap
drivers/gpu/drm/vkms/vkms_plane.c | 36 ++-
1 file
of the buffer with
appropriate synchronization methods.
Haneen Mohammed (5):
drm/vkms: Add functions to map/unmap GEM backing storage
drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks
drm/vkms: Add atomic_helper_check_plane_state
drm/vkms: subclass CRTC state
drm/vkms: Implement
atomic update,
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- Include this patch in this patchset.
drivers/gpu/drm/vkms/Makefile | 2 +-
drivers/gpu/drm/vkms/vkms_crtc.c | 60 ++-
drivers/gpu/drm/vkms/vkms_drv.c | 1 +
drivers/gpu/drm/vkms/vkms_drv.h
Call atomic_helper_check_plane_state to clip plane coordinates.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- check for plane_state->visible since we can't handle a disabled
primary plane yet.
drivers/gpu/drm/vkms/vkms_plane.c | 29 +
1 file cha
Subclass CRTC state struct to enable storing driver's private
state. This patch only adds the base drm_crtc_state struct and
the atomic functions that handle it.
Signed-off-by: Haneen Mohammed
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/vkms/vkms_crtc.c
This patch add the necessary functions to map/unmap GEM
backing memory to the kernel's virtual address space.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- add vkms_gem_vunmap
- use vmap_count to guard against multiple prepare_fb calls on the same
fb
drivers/gpu/drm/vkms/vkms_
On Tue, Jul 10, 2018 at 10:10:46AM +0200, Daniel Vetter wrote:
> On Mon, Jul 09, 2018 at 06:48:36PM +0300, Haneen Mohammed wrote:
> > Subclass CRTC state struct to enable storing driver's private
> > state. This patch only adds the base drm_crtc_state struct and
> >
On Tue, Jul 10, 2018 at 09:12:36AM +0100, Chris Wilson wrote:
> Quoting Haneen Mohammed (2018-07-09 16:44:26)
> > +struct page **get_pages(struct vkms_gem_object *vkms_obj)
> > +{
> > + struct drm_gem_object *gem_obj = &vkms_obj->gem;
> > + str
Call atomic_helper_check_plane_state to clip plane coordinates.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_plane.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_plane.c
b/drivers/gpu/drm/vkms/vkms_plane.c
This patch add the necessary functions to map GEM
backing memory into the kernel's virtual address space.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
drivers/gpu/drm/vkms/vkms_drv.h | 5
drivers/gpu/drm/vkms/vkms_gem.c
Subclass CRTC state struct to enable storing driver's private
state. This patch only adds the base drm_crtc_state struct and
the atomic functions that handle it.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_crtc.c | 55 ++--
drivers/gpu/drm
This patch map/unmap GEM backing memory to kernel address space
in prepare/cleanup_fb respectively and cache the virtual address
for later use.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_plane.c | 41 +++
1 file changed, 41 insertions(+)
diff --git
patchset:
subject: [PATCH V2 0/5] drm/vkms: Updates to meet basic kms_flip requirements
link: https://lists.freedesktop.org/archives/dri-devel/2018-June/180823.html
Haneen Mohammed (4):
drm/vkms: Add functions to map GEM backing storage
drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks
On Thu, Jun 21, 2018 at 09:16:13AM -0300, Rodrigo Siqueira wrote:
> VKMS currently does not handle dumb data, and as a consequence, it does
> not provide mechanisms for handling gem. This commit adds the necessary
> support for gem object/handler and the dumb functions.
>
> Signed-off-by: Rodrigo
On Thu, Jun 28, 2018 at 01:40:08PM +0200, Daniel Vetter wrote:
> On Thu, Jun 28, 2018 at 10:07 AM, Daniel Vetter wrote:
> > On Thu, Jun 28, 2018 at 12:24:35AM +0300, Haneen Mohammed wrote:
> >> Implement the .set_crc_source() callback.
> >> Compute CRC using crc32
This patch add the necessary functions to map GEM backing memory
into the kernel's virtual address space.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_drv.c | 1 +
drivers/gpu/drm/vkms/vkms_drv.h | 5
drivers/gpu/drm/vkms/vkms_gem.c
Implement the .set_crc_source() callback.
Compute CRC using crc32 on the visible part of the framebuffer.
Use work_struct to compute and add CRC at the end of a vblank.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_crtc.c | 76
drivers/gpu/drm
This patch checks plane state and use prepare/cleanup_fb
to map/unmap GEM backing memory to kernel address space.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vkms/vkms_drv.h | 1 +
drivers/gpu/drm/vkms/vkms_plane.c | 50 +++
2 files changed, 51 insertions
was built on top of the following patch:
subject: "drm/vkms: Add vblank events simulated by hrtimers"
link: https://lists.freedesktop.org/archives/dri-devel/2018-June/181060.html
Haneen Mohammed (3):
drm/vkms: Add functions to map GEM backing storage
drm/vkms: map/unmap buffers i
a) drm_atomic_helper_check_modeset
a) handle_conflicting_encoders
c) update_connector_routing
Signed-off-by: Haneen Mohammed
---
Changes in v3:
- add checks for drm_connector_helper_funcs only since plane/crtc
helper funcs are necessary for a functional driver
Changes
On Tue, May 29, 2018 at 10:03:53AM +0200, Daniel Vetter wrote:
> On Fri, May 25, 2018 at 05:20:08AM +0300, Haneen Mohammed wrote:
> > This patch add checks for NULL drm_[connector/crtc/plane]_helper_funcs
> > pointers before derefrencing the variable to avoid NULL pointer
> >
ctor_routing -> drm_connectot_helper_funcs
* atomic_commit = drm_atomic_helper_commit
a) drm_atomic_helper_prepare_planes -> drm_plane_helper_funcs
b) drm_atomic_helper_cleanup_planes -> drm_plane_helper_funcs
Signed-off-by: Haneen Mohammed
---
Chanes in v2:
- add the least amount
This patch add checks for NULL drm_[connector/crtc/plane]_helper_funcs
pointers before derefrencing the variable to avoid NULL pointer
dereference and make the helper functions as optional as possible.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/drm_atomic_helper.c | 42
This patch add checks for atomic_[duplicate/destroy]_state of
drm_[connector/crtc/plane]_funcs for atomic drivers in the relevant
drm_*_init functions since these callback are mandatory for atomic drivers.
Update the kerneldoc comments for those callbacks.
Signed-off-by: Haneen Mohammed
On Wed, May 23, 2018 at 10:53:33AM +0200, Daniel Vetter wrote:
> On Sun, May 20, 2018 at 09:22:31AM +0300, Haneen Mohammed wrote:
> > On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote:
> > > This commit adds the essential infrastructure for around CRTCs which
>
On Wed, May 23, 2018 at 11:15:18AM +0200, Daniel Vetter wrote:
> On Mon, May 21, 2018 at 10:04:23PM -0300, Rodrigo Siqueira wrote:
> > This series of patches add a centralized initialization mechanism, a
> > single CRTC with a plane, an encoder, and extra module information.
> >
> > Changes in v2
te mode 100644 drivers/gpu/drm/vkms/vkms_output.c
> create mode 100644 drivers/gpu/drm/vkms/vkms_plane.c
>
> --
> 2.17.0
>
Reviewed-by: Haneen Mohammed
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, May 21, 2018 at 10:06:40PM -0300, Rodrigo Siqueira wrote:
> This commit appends the essential CRTCs infrastructure for VKMS. CRTCs
> demands other elements to work correctly, in this sense, this patch adds
> a new data struct that centralizes the data structures related to the
> output, sim
On Sun, May 20, 2018 at 11:28:37AM -0300, Rodrigo Siqueira wrote:
> Hi Haneen,
>
> Thanks for the feedback :)
>
> On 05/20, Haneen Mohammed wrote:
> > On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote:
> > > This commit adds the essential infrast
On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote:
> This commit adds the essential infrastructure for around CRTCs which
> is composed of: a new data struct for output data information, a
> function for creating planes, and a simple encoder attached to the
> connector. Finally, due
ms_plane.c
>
> --
> 2.17.0
with my limited knowledge on DRM, these looks good to me.
Reviewed-by: Haneen Mohammed
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue, May 15, 2018 at 07:30:52PM +0800, kbuild test robot wrote:
>
> Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver")
> Signed-off-by: Fengguang Wu
> ---
> vkms_drv.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/dri
without the need for hardware display capability.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/Kconfig | 6 ++
drivers/gpu/drm/Makefile| 1 +
drivers/gpu/drm/vkms/Makefile | 3 +
drivers/gpu/drm/vkms/vkms_drv.c | 146
drivers/gpu/drm
This patch matches the sysfs name used in the unlinking with the
linking function. Otherwise, remove_compat_control_link() fails to remove
sysfs created by create_compat_control_link() in drm_dev_register().
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/drm_drv.c | 2 +-
1 file changed, 1
Remove drmP.h as it is not needed anymore since nothing it defines is
used in these files and use drm_print.h instead as these files are using
the debug macros defined there.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/zte/zx_drm_drv.c | 2 +-
drivers/gpu/drm/zte/zx_hdmi.c| 2
This patch remove the compatibility aliases
drm_property_{reference/unreference}_blob of
drm_property_blob_{get/put} since all callers have been converted to the
prefered _{get/put}.
Remove the helpers from the semantic patch drm-get-put-cocci.
Signed-off-by: Haneen Mohammed
---
include/drm
This patch remove the compatibility aliases
drm_mode_object_{reference/unreference} of drm_mode_object_{get/put}
since all callers have been converted to the prefered _{get/put}.
Remove the helpers from the semantic patch drm-get-put-cocci.
Signed-off-by: Haneen Mohammed
---
include/drm
account for the new helpers.
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/drm_global.c | 43 +++-
include/drm/drm_global.h | 2 ++
scripts/coccinelle/api/drm-get-put.cocci | 10
3 files changed, 49 insertions(+), 6 deletions
);
|
-drm_framebuffer_unreference(e);
+drm_framebuffer_put(e);
)
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c| 2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
b/drivers
:
- Move debug macros and print functions into drm_print.[hc] instead of
introducing drm_debug.[hc].
Haneen Mohammed (2):
drm: Move debug macros out of drmP.h
drm/print: Update old comment style
drivers/gpu/drm/drm_drv.c | 47 ---
drivers/gpu/drm/drm_print.c | 47 +++
include
drm_debug.[hc].
Haneen Mohammed (2):
drm: Move debug macros out of drmP.h
drm/print: Update old comment style
drivers/gpu/drm/drm_drv.c | 47 --
drivers/gpu/drm/drm_print.c | 47 ++
include/drm/drmP.h | 150
This patch extract DRM_* debug macros from drmP.h to drm_print.h and
move printing related functions used by these macros from drm_drv.[hc]
to drm_print.[hc].
Signed-off-by: Haneen Mohammed
---
Changes in v4:
- Move DRM_UT_ debug messaging macros from drmP.h to drm_print.h.
drivers/gpu/drm
Remove old comment style used by doxygen.
And remove comment left from commit 99cdb35e787b ("drm/doc: move printf
helpers out of drmP.h") after refactoring drmP.h.
Signed-off-by: Haneen Mohammed
---
Changes in v3:
- nothing
include/drm/drm_print.h | 27 ++---
This patch extract DRM_* debug macros from drmP.h to drm_print.h and
move printing related functions used by these macros from drm_drv.[hc]
to drm_print.[hc].
Signed-off-by: Haneen Mohammed
---
Changes in v3:
- Move debug macros and print functions into drm_print.[hc] instead of
introducing
On Tue, Oct 17, 2017 at 03:54:13PM -0400, Sean Paul wrote:
> On Tue, Oct 17, 2017 at 02:43:38AM -0600, Haneen Mohammed wrote:
> > This patch extract DRM_* debug macros from drmP.h to drm_print.h and
> > move printing related functions used by these macros from drm_drv.[hc]
>
Remove old comment style used by doxygen.
And remove comment left from commit 99cdb35e787b ("drm/doc: move printf
helpers out of drmP.h") after refactoring drmP.h.
Signed-off-by: Haneen Mohammed
---
Changes in v4:
- Nothing.
include/drm/drm_print.h | 27 ++---
On Thu, Oct 12, 2017 at 11:35:12AM +0100, Chris Wilson wrote:
> Quoting Haneen Mohammed (2017-10-12 03:32:53)
> > diff --git a/drivers/gpu/drm/drm_debug.c b/drivers/gpu/drm/drm_debug.c
> > new file mode 100644
> > index 000..a79593f
> > --- /dev/null
> >
Remove old comment style used by doxygen.
And remove comment left from commit 99cdb35e787b ("drm/doc: move printf
helpers out of drmP.h") after refactoring drmP.h.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- Fix kerneldoc comments
include/drm/drm_de
Add missing documentation for exported functions to avoid kerneldoc
warning.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- Include this patch to avoid kerneldoc warning
drivers/gpu/drm/drm_debug.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm
directives in drm-internals.rst
- Fix kerneldoc comments in drm_debug.h
- include patch 3 to add kerneldoc comments to exported functions
Haneen Mohammed (3):
drm: Extract drm_debug.[hc]
drm: Update old comment style
drm/debug: Add missing kerneldoc comments to exported functions
Documentation
On Wed, Oct 11, 2017 at 01:40:47PM +0200, Daniel Vetter wrote:
> On Tue, Oct 10, 2017 at 10:13:36PM -0600, Haneen Mohammed wrote:
> > Extract DRM_* debug macros from drmP.h to drm_debug.h and move printting
> > related functions from drm_drv.[hc] to drm_debug.[hc].
> >
Extract DRM_* debug macros from drmP.h to drm_debug.h and move printting
related functions from drm_drv.[hc] to drm_debug.[hc].
Update kerneldoc include directives accordingly.
Signed-off-by: Haneen Mohammed
---
Changes in v2:
- Place kerneldoc include directives in drm-internals.rst
This patchset move debug macros from drmP.h into drm_debug.h and move
printting related functions from drm_drv.[hc] to drm_debug.[hc].
In addition, it fixes old comment style.
Haneen Mohammed (2):
drm: Extract drm_debug.[hc]
drm: Update old comment style
Documentation/gpu/drm-uapi.rst | 9
Remove old comment style used by doxygen.
And remove comment left from commit 99cdb35e787b ("drm/doc: move printf
helpers out of drmP.h") after refactoring drmP.h.
Signed-off-by: Haneen Mohammed
---
include/drm/drm_debug.h | 26 +-
1 file changed, 9 inserti
Extract DRM_* debug macros from drmP.h to drm_debug.h and move printting
related functions from drm_drv.[hc] to drm_debug.[hc].
Update kerneldoc include directives accordingly.
Signed-off-by: Haneen Mohammed
---
Documentation/gpu/drm-uapi.rst | 9 ++
drivers/gpu/drm/Makefile | 2
Since the driver is relying on the atomic helpers, remove the explicit
.best_encoder assignment and let the core call
drm_atomic_helper_best_encoder().
Signed-off-by: Haneen Mohammed
---
drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu
1 - 100 of 113 matches
Mail list logo
