Re: [PATCH v3] fbdev/simplefb: Fix use after free in simplefb_detach_genpds()

2025-09-20 Thread Hans de Goede
ter free on M2 Mac mini during > aperture_remove_conflicting_devices() using the downstream asahi kernel > with Debian's kernel config. For unknown reasons this started to > consistently dereference an invalid pointer in v6.16.3 based kernels. Thanks, this v3 patch looks good to me: Reviewed-by: Hans de Goe

Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property

2025-09-20 Thread Hans de Goede
Hi, On 8-Sep-25 09:20, Konrad Dybcio wrote: > On 9/8/25 1:18 AM, Aleksandrs Vinarskis wrote: >> A number of existing schemas use 'leds' property to provide >> phandle-array of LED(s) to the consumer. Additionally, with the >> upcoming privacy-led support in device-tree, v4l2 subnode could be a >>

Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property

2025-09-20 Thread Hans de Goede
Hi, On 9-Sep-25 12:22 AM, Rob Herring wrote: > On Mon, Sep 08, 2025 at 09:36:39AM +0200, Konrad Dybcio wrote: >> On 9/8/25 9:33 AM, Hans de Goede wrote: >>> Hi, >>> >>> On 8-Sep-25 09:20, Konrad Dybcio wrote: >>>> On 9/8/25 1:18 AM, Aleksandrs Vin

Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property

2025-09-20 Thread Hans de Goede
Hi All, On 9-Sep-25 12:22 AM, Rob Herring wrote: > On Mon, Sep 08, 2025 at 09:36:39AM +0200, Konrad Dybcio wrote: >> On 9/8/25 9:33 AM, Hans de Goede wrote: >>> Hi, >>> >>> On 8-Sep-25 09:20, Konrad Dybcio wrote: >>>> On 9/8/25 1:18 AM, Aleksa

Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property

2025-09-20 Thread Hans de Goede
Hi, On 9-Sep-25 11:28 AM, Aleksandrs Vinarskis wrote: > > > > > > On Tuesday, September 9th, 2025 at 11:21, Hans de Goede > wrote: > >> >> >> Hi All, >> >> On 9-Sep-25 12:22 AM, Rob Herring wrote: >> >>> On Mon, Sep 08

Re: [PATCH v5 3/4] leds: led-class: Add devicetree support to led_get()

2025-09-11 Thread Hans de Goede
Hi Lee, On 11-Sep-25 10:15 AM, Lee Jones wrote: > On Wed, 10 Sep 2025, Aleksandrs Vinarskis wrote: > >> From: Hans de Goede >> >> Add 'name' argument to of_led_get() such that it can lookup LEDs in >> devicetree by either name or index. >> >&

Re: [PATCH v2] fbdev/simplefb: Fix use after free in simplefb_detach_genpds()

2025-09-10 Thread Hans de Goede
Hi Janne, On 8-Sep-25 11:23 PM, Janne Grunau wrote: > The pm_domain cleanup can not be devres managed as it uses struct > simplefb_par which is allocated within struct fb_info by > framebuffer_alloc(). This allocation is explicitly freed by > unregister_framebuffer() in simplefb_remove(). > Devres

Re: [PATCH v4 1/4] dt-bindings: leds: add generic LED consumer documentation

2025-09-10 Thread Hans de Goede
Hi Aleksandrs, Thank you for your continued work on this. One small remark below. On 10-Sep-25 1:07 PM, Aleksandrs Vinarskis wrote: > Introduce common generic led consumer binding, where consumer defines > led(s) by phandle, as opposed to trigger-source binding where the > trigger source is defi

Re: [PATCH v3 1/4] dt-bindings: leds: add generic LED consumer documentation

2025-09-09 Thread Hans de Goede
Hi, On 9-Sep-25 6:57 PM, Aleksandrs Vinarskis wrote: > > > > > > On Monday, September 8th, 2025 at 01:18, Aleksandrs Vinarskis > wrote: > >> >> >> Introduce common generic led consumer binding, where consumer defines >> led(s) by phandle, as opposed to trigger-source binding where the >> t

Re: [PATCH v2 30/37] drm/vboxvideo: Switch to drm_atomic_get_new_crtc_state()

2025-09-03 Thread Hans de Goede
s points to the new state, and > we can use drm_atomic_get_new_crtc_state() instead. > > Signed-off-by: Maxime Ripard > > --- > To: Hans de Goede > Cc: dri-devel@lists.freedesktop.org Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- &

Re: [PATCH v2] drm: panel-orientation-quirks: Add Chuwi MiniBook X quirk

2025-08-09 Thread Hans de Goede
o > the correct orientation. > > Signed-off-by: Ibrahim Burak Yorulmaz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers

Re: [PATCH resend] drm/i915/bios: Apply vlv_fixup_mipi_sequences() to v2 mipi-sequences too

2025-07-10 Thread Hans de Goede
Hi Rodrigo, On 10-Jul-25 5:34 PM, Rodrigo Vivi wrote: > On Mon, Jul 07, 2025 at 11:10:59PM +0200, Hans de Goede wrote: >> Hi Ville, >> >> On 4-Jul-25 12:31 PM, Ville Syrjälä wrote: >>> On Thu, Jul 03, 2025 at 04:38:24PM +0200, Hans de Goede wrote: >>>> F

Re: [PATCH resend] drm/i915/bios: Apply vlv_fixup_mipi_sequences() to v2 mipi-sequences too

2025-07-07 Thread Hans de Goede
Hi Ville, On 4-Jul-25 12:31 PM, Ville Syrjälä wrote: > On Thu, Jul 03, 2025 at 04:38:24PM +0200, Hans de Goede wrote: >> From: Hans de Goede >> >> It turns out that the fixup from vlv_fixup_mipi_sequences() is necessary >> for some DSI panel's w

[PATCH 2/3] agp/amd64: Change agp_try_unsupported default to 0

2025-07-07 Thread Hans de Goede
things inline with the Kconfig which says that agp_try_unsupported=1 should be passed to try unsupported bridges. Suggested-by: Lukas Wunner Signed-off-by: Hans de Goede --- drivers/char/agp/amd64-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/agp/amd64

[PATCH 3/3] agp/amd64: Remove support for probing unlisted PCI devices

2025-07-07 Thread Hans de Goede
AMD64 boards with AGP support are so old that the agp_amd64_pci_table should be complete and there is no need to probe unlisted PCI devices, so lets completely remove support for probing unlisted PCI devices. Suggested-by: Andi Kleen Signed-off-by: Hans de Goede --- drivers/char/agp/Kconfig

[PATCH 1/3] agp/amd64: Check AGP Capability before binding to unsupported devices

2025-07-07 Thread Hans de Goede
_HOST. However these approaches risk regressing users who depend on the existing behavior. Fixes: 3be5fa236649 (Revert "iommu/amd: Prevent binding other PCI drivers to IOMMU PCI devices") Reported-by: Fedor Pchelkin Closes: https://lore.kernel.org/r/wpoivftgshz5b5aovxbkxl6ivvqu

[PATCH 0/3] agp/amd64: Remove support for probing unlisted PCI devices

2025-07-07 Thread Hans de Goede
regression caused by the probing of unsupported devices I've included this patch so that the series applies cleanly, this means that drm-misc-fixes (once it lands there) will needs to be backmerged for the last patch to apply. Regards, Hans Hans de Goede (2): agp/amd64: Change agp_try_unsuppo

Re: [PATCH v2] agp/amd64: Check AGP Capability before binding to unsupported devices

2025-07-07 Thread Hans de Goede
Hi Andi, On 3-Jul-25 21:29, Andi Kleen wrote: > > I suspect these days it would be also reasonable to drop it this old > hack. > > If any of these old chipsets are still missing I would rather adds its > PCI-ID. > > There will be certainly not any new unknown ones for these old CPUs. Right, I

[PATCH resend] drm/i915/bios: Apply vlv_fixup_mipi_sequences() to v2 mipi-sequences too

2025-07-03 Thread Hans de Goede
From: Hans de Goede It turns out that the fixup from vlv_fixup_mipi_sequences() is necessary for some DSI panel's with version 2 mipi-sequences too. Specifically the Acer Iconia One 8 A1-840 (not to be confused with the A1-840FHD which is different) has the following sequences: BDB blo

Re: [PATCH v2] agp/amd64: Check AGP Capability before binding to unsupported devices

2025-07-03 Thread Hans de Goede
es risk regressing users who depend on the existing behavior. > > Fixes: 3be5fa236649 (Revert "iommu/amd: Prevent binding other PCI drivers to > IOMMU PCI devices") > Reported-by: Fedor Pchelkin > Closes: > https://lore.kernel.org/r/wpoivftgshz5b5aovxbkxl6ivvquinukqfvb5z6yi4

Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-07-03 Thread Hans de Goede
Hi Thomas, On 3-Jul-25 8:47 AM, Thomas Zimmermann wrote: > Hi > > Am 02.07.25 um 22:43 schrieb Krzysztof Kozlowski: >> On 30/06/2025 10:40, Hans de Goede wrote: >>>> No one asks to drop them from the driver. I only want specific front >>>> compatible which

Re: [PATCH] agp/amd64: Bind to unsupported devices only if AGP is present

2025-06-30 Thread Hans de Goede
Hi, On 25-Jun-25 8:43 PM, Hans de Goede wrote: > Hi, > > On 25-Jun-25 4:33 PM, Lukas Wunner wrote: >> On Wed, Jun 25, 2025 at 04:08:38PM +0200, Hans de Goede wrote: >>> Lukas made me aware of this attempt to fix the KERN_CRIT msg, because >>> I wrote a sli

Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-06-30 Thread Hans de Goede
Hi Krzysztof, On 30-Jun-25 11:36 AM, Krzysztof Kozlowski wrote: > On 30/06/2025 10:38, Maxime Ripard wrote: >> On Mon, Jun 30, 2025 at 10:24:06AM +0200, Krzysztof Kozlowski wrote: >>> On 29/06/2025 14:07, Hans de Goede wrote: >>>> Hi Krzysztof, >>>> >

Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-06-30 Thread Hans de Goede
Hi, On 30-Jun-25 10:24 AM, Krzysztof Kozlowski wrote: > On 29/06/2025 14:07, Hans de Goede wrote: >> Hi Krzysztof, >> >> On 28-Jun-25 1:49 PM, Krzysztof Kozlowski wrote: >>> On 27/06/2025 11:48, Luca Weiss wrote: >>>> Hi Krzysztof, >>>>

Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-06-30 Thread Hans de Goede
le", which IMHO really is a non argument for an already existing binding. Certainly it is not a good technical argument. During the last decade, after clocks and regulators were added to the binding. simplefb has been used successfully on millions (billions?) handover the firmware framebuffer to the OS for bootsplash use, replacing various vendor hacks for this. Disallowing the addition of interconnect support to the simplefb binding will only result in various vendor hacks appearing in vendor kernels for this, which I believe is something which we should try to avoid. So as the maintainer of the simplefb kernel driver for over a decade I strongly advice the DT maintainers to accept this bindings patch and from my my side this still is: Reviewed-by: Hans de Goede Regards, Hans

Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property

2025-06-29 Thread Hans de Goede
Hi Krzysztof, On 28-Jun-25 1:49 PM, Krzysztof Kozlowski wrote: > On 27/06/2025 11:48, Luca Weiss wrote: >> Hi Krzysztof, >> >> On Fri Jun 27, 2025 at 10:08 AM CEST, Krzysztof Kozlowski wrote: >>> On Mon, Jun 23, 2025 at 08:44:45AM +0200, Luca Weiss wrote: Document the interconnects property w

Re: [PATCH] agp/amd64: Bind to unsupported devices only if AGP is present

2025-06-25 Thread Hans de Goede
Hi, On 25-Jun-25 4:33 PM, Lukas Wunner wrote: > On Wed, Jun 25, 2025 at 04:08:38PM +0200, Hans de Goede wrote: >> Lukas made me aware of this attempt to fix the KERN_CRIT msg, because >> I wrote a slightly different patch to fix this: >> >> https://lore.kernel.org/dri-

[PATCH] agp/amd64: Only try host-bridges when agp_try_unsupported is set

2025-06-25 Thread Hans de Goede
that the IOMMU will no longer get probed with the agpgart-amd64 driver. This not only fixes the troublesome dev_crit() logging it should also speed up things in general. Signed-off-by: Hans de Goede --- Given how old AGP is I would expect the agp_amd64_pci_table[] to be complete and I wonder if mayb

Re: [PATCH] agp/amd64: Only try host-bridges when agp_try_unsupported is set

2025-06-25 Thread Hans de Goede
Hi, On 25-Jun-25 3:38 PM, Lukas Wunner wrote: > On Wed, Jun 25, 2025 at 01:24:11PM +0200, Hans de Goede wrote: >> On modern AMD Ryzen systems the IOMMU code initializes early on adding >> resources to the "00:00.2 IOMMU" PCI-device without binding a driver to >> it

Re: [PATCH] agp/amd64: Bind to unsupported devices only if AGP is present

2025-06-25 Thread Hans de Goede
Hi, On 24-Jun-25 11:54 PM, Ben Hutchings wrote: > On Sat, 2025-06-21 at 16:05 +0200, Lukas Wunner wrote: >> On Sat, Jun 21, 2025 at 03:51:44PM +0200, Ben Hutchings wrote: >>> On Sat, 2025-06-21 at 14:29 +0200, Lukas Wunner wrote: On Sat, Jun 21, 2025 at 02:07:40PM +0200, Ben Hutchings wrote:

Re: [PATCH] agp/amd64: Only try host-bridges when agp_try_unsupported is set

2025-06-25 Thread Hans de Goede
Hi Alex, On 25-Jun-25 3:11 PM, Alex Deucher wrote: > + Suravee and Vasant > > On Wed, Jun 25, 2025 at 7:24 AM Hans de Goede wrote: >> >> On modern AMD Ryzen systems the IOMMU code initializes early on adding >> resources to the "00:00.2 IOMMU" PCI-dev

Re: [PATCH v2 0/5] Add interconnent support for simpledrm/simplefb

2025-06-23 Thread Hans de Goede
cc-v1-0-d92142e8f...@fairphone.com Thanks, the entire series looks good to me: Reviewed-by: Hans de Goede for the series. Regards, Hans > > --- > Luca Weiss (5): > dt-bindings: display: simple-framebuffer: Add interconnects property > drm/sysfb: simpledrm: Sort he

Re: [PATCH 01/12] platform/x86: dell-uart-backlight: Use blacklight power constant

2025-06-18 Thread Hans de Goede
Hi, On 18-Jun-25 2:16 PM, Thomas Zimmermann wrote: > The backlight subsystem has gotten its own power constants. Replace > FB_BLANK_UNBLANK with BACKLIGHT_POWER_ON. > > Signed-off-by: Thomas Zimmermann Thanks, patch looks good to me: Reviewed-by: Hans de Goede Re

[PATCH v2 1/1] MAINTAINERS: .mailmap: Update Hans de Goede's email address

2025-06-09 Thread Hans de Goede
I'm moving all my kernel work over to using my kernel.org email address. Update .mailmap and MAINTAINER entries still using hdego...@redhat.com. Signed-off-by: Hans de Goede --- .mailmap| 1 + MAINTAINERS | 72 ++--- 2 files change

[PATCH v2 0/1] MAINTAINERS: .mailmap: Update Hans de Goede's email address

2025-06-09 Thread Hans de Goede
ystem maintainers. But when I tried to implement that it became a bit messy. So now this is just one patch updating all entries in one go. Regards, Hans Hans de Goede (1): MAINTAINERS: .mailmap: Update Hans de Goede's email address .mailmap| 1 + MAINTA

Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk

2025-03-17 Thread Hans de Goede
Hi, On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen. > Add the rotation to the panel orientation quirks. > > Signed-off-by: Antheas Kapenekakis > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file chang

Re: [PATCH 3/5] drm: panel-orientation-quirks: Add OneXPlayer F1Pro quirk

2025-03-17 Thread Hans de Goede
> Signed-off-by: Antheas Kapenekakis Thanks, patch looks good to me: Reviewed-by: Hans de Goede drm-misc maintainers, I'm dealing with a huge backlog of patch-review, bugs and other work. So I would appreciate it if one of you can merge patches 1-3 into drm-misc. Regards, Hans &

Re: [PATCH 2/5] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini (AMD) quirk

2025-03-17 Thread Hans de Goede
ooks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c > b/drivers/gpu/drm/drm_panel_orientation_quirks.c &

Re: [PATCH 1/5] drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk

2025-03-17 Thread Hans de Goede
ks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c > b/drivers/gpu/drm/drm_p

Re: [PATCH] drm: panel-orientation-quirks: Add ZOTAC Gaming Zone

2025-03-15 Thread Hans de Goede
Hi, On 13-Mar-25 10:16 PM, Vicki Pfau wrote: > Add a panel orientation quirk for the ZOTAC Gaming Zone handheld gaming > device. > > Signed-off-by: Vicki Pfau Thanks, patch looks good to me: Reviewed-by: Hans de Goede drm-misc maintainers, I'm dealing with a huge backlo

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

2025-02-12 Thread Hans de Goede
Hi, On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote: > Hi > > Am 12.02.25 um 11:51 schrieb Hans de Goede: >> Hi Thomas, >> >> On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 24.01.25 um 21:46 schrieb John Edwards: >>>

Re: [PATCH v2 2/5] drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB

2025-02-12 Thread Hans de Goede
Hi, Thank you for your patches and sorry for being slow to respond. On 24-Jan-25 9:46 PM, John Edwards wrote: > From: Andrew Wyatt > > The AYA NEO Flip DS and KB both use a 1080x1920 portrait LCD panel. The > Flip DS additionally uses a 640x960 portrait LCD panel as a second display. > > Add

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

2025-02-12 Thread Hans de Goede
rk for 3 new entries added in patches 2/5 + 3/5: "Since this '}' is closing the .matches initializer it should be indented 2 tabs" With that fixed, you can add my: Reviewed-by: Hans de Goede to the entire series. > for the series. Let me know if you need assistance fo

Re: [PATCH v2 3/5] drm: panel-orientation-quirks: Add quirk for AYA NEO Slide

2025-02-12 Thread Hans de Goede
Hi, On 24-Jan-25 9:46 PM, John Edwards wrote: > From: Andrew Wyatt > > The AYANEO Slide uses a 1080x1920 portrait LCD panel. This is the same > panel used on the AYANEO Air Plus, but the DMI data is too different to > match both with one entry. > > Add a DMI match to correctly rotate the panel

Re: [PATCH v3] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64

2025-01-07 Thread Hans de Goede
MacBook Pro with the latest Virtualbox 7.1.4 r165100 installed. > > Signed-off-by: Christian Kujau > Reviewed-by: Hans de Goede Thank you for the new version, note that v2 has already been applied to the vfs tree though. This is fine, the missing changelog is really not a big deal a

Re: [PATCH v2] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64

2025-01-06 Thread Hans de Goede
Pro with the latest Virtualbox 7.1.4 r165100 installed. > > Signed-off-by: Christian Kujau Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/virt/vboxguest/Kconfig | 2 +- > fs/vboxsf/Kconfig | 2 +- > 2 files changed

Re: [PATCH] vbox: arm64 support for vboxguest

2025-01-06 Thread Hans de Goede
Hi Christian, Thank you for your patch. On 15-Dec-24 8:52 PM, Christian Kujau wrote: > My last email[0] still had "RFC" in the subject line, but no comments were > received. So, in an attempt of stupi^W boldness, this is the same patch > again, with RFC removed and ready for mainline, maybe? >

Re: [PATCH] drm/vboxvideo: Remove unused hgsmi_cursor_position

2024-12-16 Thread Hans de Goede
Remove it. > > Signed-off-by: Dr. David Alan Gilbert Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/vboxvideo/hgsmi_base.c | 37 - > drivers/gpu/drm/vboxvideo/vboxvideo_guest.h | 2 -- > 2 files chan

[PATCH] drm/i915/bios: Apply vlv_fixup_mipi_sequences() to v2 mipi-sequences too

2024-11-16 Thread Hans de Goede
ng on the Acer Iconia One 8 A1-840. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_bios.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index bed4853

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-22 Thread Hans de Goede
Hi Armin, On 21-Oct-24 10:26 PM, Armin Wolf wrote: > Am 11.10.24 um 17:26 schrieb Pavel Machek: > >> Hi! >> 1. https://lore.kernel.org/all/6b32fb73-0544-4a68-95ba-e82406a4b...@gmx.de/ -> Should be no problem? Because this is not generally exposing wmi calls, just mapping two e

Re: [PATCH] drm/radeon: add late_register for connector

2024-10-03 Thread Hans de Goede
igned-off-by: Wu Hoi Pok Thank you both for the Cc and the patch. I can confirm that this fixes the crash which I was seeing. Also IHMO this should have a fixes tag for the original commit introducing the problem: Fixes: 90985660ba48 ("drm/radeon: remove load callback from kms_driver") Te

[PATCH 6.12 regression fix 2/2] drm/radeon: Revert: "use GEM references instead of TTMs"

2024-10-03 Thread Hans de Goede
29.315381] __fput+0xfc/0x2c0 Revert the change to restore things back to working order. Fixes: fd69ef05029f ("drm/radeon: use GEM references instead of TTMs") Signed-off-by: Hans de Goede --- drivers/gpu/drm/radeon/radeon_gem.c| 2 +- drivers/gpu/drm/radeon/radeon_object.c | 7 +--

[PATCH 6.12 regression fix 1/2] drm/radeon: Revert: "remove load callback from kms_driver"

2024-10-03 Thread Hans de Goede
Revert the change to avoid this crash. Fixes: 90985660ba48 ("drm/radeon: remove load callback from kms_driver") Signed-off-by: Hans de Goede --- Cc: Thomas Zimmermann Cc: Wu Hoi Pok --- drivers/gpu/drm/radeon/radeon_drv.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --g

[PATCH 6.12 regression fix 0/2] drm/radeon regression fixes

2024-10-03 Thread Hans de Goede
cases. Both patches have a stacktrace in their commit message and I'm willing to try other ways of fixing things. Regards, Hans Hans de Goede (2): drm/radeon: Revert: "remove load callback from kms_driver" drm/radeon: Revert: "use GEM references instead of TTMs"

Re: [PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model

2024-09-22 Thread Hans de Goede
x27;t > seem really sorted It is sorted but it is sorted by the Vendor - Model in the comments, not by the DMI strings since sometimes those are e.g. "SYS_VENDOR", "Default String" and stuff like that. The entire series looks good to me: Reviewed-by: Hans de Goede for t

[PATCH resend] drm/vboxvideo: Replace fake VLA at end of vbva_mouse_pointer_shape with real VLA

2024-08-27 Thread Hans de Goede
ote as mentioned in the added comment it seems the original length calculation for the allocated and send hgsmi buffer is 4 bytes too large. Changing this is not the goal of this patch, so this behavior is kept. Signed-off-by: Hans de Goede --- Resend, can I get an ack from someone to push this

[PATCH] drm: panel-orientation-quirks: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-25 Thread Hans de Goede
ct-name check is not necessary. Drop the product-name check so that the existing DMI match for the 4G RAM version also matches the 2G RAM version. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 1 - 1 file changed, 1 deletion(-) diff --g

Re: [PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-24 Thread Hans de Goede
Hi, On 8/23/24 9:41 PM, Rodrigo Vivi wrote: > On Fri, Aug 23, 2024 at 07:34:39PM +0200, Hans de Goede wrote: >> Hi, >> >> On 8/23/24 10:22 AM, Jani Nikula wrote: >>> On Fri, 23 Aug 2024, Hans de Goede wrote: >>>> There are 2G and 4G RAM versions of th

Re: [PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-23 Thread Hans de Goede
Hi, On 8/23/24 10:22 AM, Jani Nikula wrote: > On Fri, 23 Aug 2024, Hans de Goede wrote: >> There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it >> turns out that the 2G version has a DMI product name of >> "CHERRYVIEW D1 PLATFORM" where as the 4

[PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-08-23 Thread Hans de Goede
ct-name check is not necessary. Drop the product-name check so that the existing DMI match for the 4G RAM version also matches the 2G RAM version. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/vlv_dsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/

[PATCH 3/3] ACPI: video: Add backlight=native quirk for Dell OptiPlex 7760 AIO

2024-08-14 Thread Hans de Goede
ess and the GPU's native backlight control method does work. Add a quirk to use the GPU's native backlight control method on this model. Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver") Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2303936 C

[PATCH 0/3] ACPI/video / platform/x86: Add backlight=native quirk for Dell OptiPlex 7760 AIO

2024-08-14 Thread Hans de Goede
any other drivers/apci/video_detect.c DMI quirks show up this cycle. Regards, Hans Hans de Goede (3): ACPI: video: Add Dell UART backlight controller detection platform/x86: dell-uart-backlight: Use acpi_video_get_backlight_type() ACPI: video: Add backlight=native quirk for Dell OptiPlex

[PATCH 2/3] platform/x86: dell-uart-backlight: Use acpi_video_get_backlight_type()

2024-08-14 Thread Hans de Goede
tually be used. This allows reusing the existing ACPI video-detect infra to override the backlight control method on the commandline or with DMI quirks. Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver") Cc: sta...@vger.kernel.org Signed-off-by: Hans de Goede --- dri

[PATCH 1/3] ACPI: video: Add Dell UART backlight controller detection

2024-08-14 Thread Hans de Goede
light control. Add support to acpi_video_get_backlight_type() for a new dell_uart backlight type. So that the existing infra to override the backlight control method on the commandline or with DMI quirks can be used. Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver") Cc: sta...@vger

Re: [PATCH RESEND 0/2] drm: panel-orientation-quirks: Add quirks for AYN loki zero/max

2024-08-12 Thread Hans de Goede
quirk for Ayn Loki Max > > drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 > 1 file changed, 12 insertions(+) Thanks, both patches look good to me: Reviewed-by: Hans de Goede I have pushed this to drm-misc-fixes now, sorry for being a bit slow with picking these up. Regards, Hans

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-08-05 Thread Hans de Goede
Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > is "12". This leads to a fairly bright minimum display backlight. > > Add a generic quirk infrastructure for backlight configuration to > override the settings prov

Re: [PATCH 0/2] Use pcim_request_region() in vboxvideo

2024-08-01 Thread Hans de Goede
ions(-) > > Given an ack from the vboxvideo maintainers, I can apply both of these > via the PCI tree so there's no race during the merge window. I'm the vboxvideo maintainer, merging both through the PCI tree sounds good to me: Acked-by: Hans de Goede Regards, Hans

Re: [PATCH 0/2] Use pcim_request_region() in vboxvideo

2024-08-01 Thread Hans de Goede
region request, so it is a suitable > first user. I have given both patches a test-run on top of 6.11-rc1 in a VirtualBox VM using the vboxsvga virtual vga card: Tested-by: Hans de Goede Also both patches look good to me: Reviewed-by: Hans de Goede for the series. Regards, Hans

Re: [PATCH v3 0/2] drm: minimum backlight overrides and implementation for amdgpu

2024-08-01 Thread Hans de Goede
Hi, On 7/31/24 10:55 PM, Daniel Vetter wrote: > On Wed, Jul 31, 2024 at 08:40:12PM +0300, Jani Nikula wrote: >> On Wed, 31 Jul 2024, Thomas Weißschuh wrote: >>> The value of "min_input_signal" returned from ATIF on a Framework AMD 13 >>> is "12". This leads to a fairly bright minimum display back

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-07-22 Thread Hans de Goede
Hi Thomas, On 7/20/24 9:31 AM, Thomas Weißschuh wrote: > Hi Hans, > > On 2024-07-18 10:25:18+0000, Hans de Goede wrote: >> On 6/24/24 6:15 PM, Thomas Weißschuh wrote: >>> On 2024-06-24 11:11:40+, Hans de Goede wrote: >>>> On 6/23/24 10:51 AM, Thomas

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-07-18 Thread Hans de Goede
Hi Thomas, On 6/24/24 6:15 PM, Thomas Weißschuh wrote: > Hi Hans! > > thanks for your feedback! > > On 2024-06-24 11:11:40+, Hans de Goede wrote: >> On 6/23/24 10:51 AM, Thomas Weißschuh wrote: >>> The value of "min_input_signal" returned from ATIF

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-07-15 Thread Hans de Goede
Hi, On 7/15/24 6:57 AM, Philip Mueller wrote: > This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. > > Signed-off-by: Philip Mueller Thanks, patch looks good to me: Reviewed-by: Hans de Goede I have pushed this to drm-misc-fixes now. Regar

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-06-24 Thread Hans de Goede
Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > is "12". This leads to a fairly bright minimum display backlight. > > Add a generic quirk infrastructure for backlight configuration to > override the settings prov

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-24 Thread Hans de Goede
Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > Panels using a PWM-controlled backlight source without an do not have a > standard way to communicate their valid PWM ranges. > On x86 the ranges are read from ACPI through driver-specific tables. > The built-in ranges are not necessarily c

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-23 Thread Hans de Goede
Hi, On 6/23/24 10:20 PM, Mario Limonciello wrote: > On 6/23/2024 03:51, Thomas Weißschuh wrote: >> Panels using a PWM-controlled backlight source without an do not have a >> standard way to communicate their valid PWM ranges. >> On x86 the ranges are read from ACPI through driver-specific tables.

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-06-10 Thread Hans de Goede
> > Trying yet another ping! Also adding Hans to the list of recipients, as he > committed the last quirk for an Ayaneo device. Someone pick this up, pretty > please! :-) Thank you for Cc-ing me and thank you for your patch. This looks good to me: Reviewed-by: Hans de Goede I&#x

Re: [PATCH] drm/tiny: add missing MODULE_DESCRIPTION() macros

2024-06-10 Thread Hans de Goede
RNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/tiny/gm12u320.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/t

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-04 Thread Hans de Goede
v6.10-rcX, or in Linux Next. > > But if you think differently, tell me. Thanks, the drivers/platform/x86 bits look good to me: Acked-by: Hans de Goede Regards, Hans > arch/powerpc/xmon/xmon.c | 5 ++-- > arch/x86/kernel/cpu/mtrr/if.c | 4 +

Re: [PATCH] arch: Fix name collision with ACPI's video.o

2024-05-17 Thread Hans de Goede
s") > Cc: Arnd Bergmann > Cc: linux-a...@vger.kernel.org > Cc: linux-fb...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > arch/sparc/video/Makefile| 2 +- >

Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Hans de Goede
Hi, On 5/16/24 5:11 PM, Thomas Zimmermann wrote: > Hi > > Am 16.05.24 um 17:03 schrieb Hans de Goede: >> Hi, >> >> On 5/16/24 3:04 PM, Rafael J. Wysocki wrote: >>> CC Hans who has been doing the majority of the ACPI video work. >>> >>

Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Hans de Goede
Hi, On 5/16/24 3:04 PM, Rafael J. Wysocki wrote: > CC Hans who has been doing the majority of the ACPI video work. > > On Thu, May 16, 2024 at 2:43 PM Thomas Zimmermann wrote: >> >> Commit 2fd001cd3600 ("arch: Rename fbdev header and source files") >> renames the video source files under arch/ s

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Hans de Goede
Hi Dmitry, On 5/7/24 3:32 PM, Dmitry Baryshkov wrote: > On Mon, May 06, 2024 at 01:49:17PM +0200, Hans de Goede wrote: >> Hi dma-buf maintainers, et.al., >> >> Various people have been working on making complex/MIPI cameras work OOTB >> with mainline Linux kernels

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-06 Thread Hans de Goede
Hi Sima, On 5/6/24 3:38 PM, Daniel Vetter wrote: > On Mon, May 06, 2024 at 02:05:12PM +0200, Maxime Ripard wrote: >> Hi, >> >> On Mon, May 06, 2024 at 01:49:17PM GMT, Hans de Goede wrote: >>> Hi dma-buf maintainers, et.al., >>> >>> Various people

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-06 Thread Hans de Goede
Hi Maxime, On 5/6/24 2:05 PM, Maxime Ripard wrote: > Hi, > > On Mon, May 06, 2024 at 01:49:17PM GMT, Hans de Goede wrote: >> Hi dma-buf maintainers, et.al., >> >> Various people have been working on making complex/MIPI cameras work OOTB >> with mainline Linux ke

Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-06 Thread Hans de Goede
Hi dma-buf maintainers, et.al., Various people have been working on making complex/MIPI cameras work OOTB with mainline Linux kernels and an opensource userspace stack. The generic solution adds a software ISP (for Debayering and 3A) to libcamera. Libcamera's API guarantees that buffers handed to

Re: [PATCH v2 15/43] drm/tiny/gm12u320: Use fbdev-shmem

2024-04-10 Thread Hans de Goede
Hi, On 4/10/24 3:02 PM, Thomas Zimmermann wrote: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Hans de Goede Thanks, patch looks good

[PATCH] drm/vboxvideo: Replace fake VLA at end of vbva_mouse_pointer_shape with real VLA

2024-04-03 Thread Hans de Goede
ote as mentioned in the added comment it seems the original length calculation for the allocated and send hgsmi buffer is 4 bytes too large. Changing this is not the goal of this patch, so this behavior is kept. Signed-off-by: Hans de Goede --- drivers/gpu/drm/vboxvideo/hgsmi_base.c | 10

Re: [PATCH v4 10/10] drm/vboxvideo: fix mapping leaks

2024-04-02 Thread Hans de Goede
Hi, On 4/2/24 3:50 PM, Philipp Stanner wrote: > On Thu, 2024-03-28 at 12:55 -0500, Bjorn Helgaas wrote: >> On Fri, Mar 01, 2024 at 12:29:58PM +0100, Philipp Stanner wrote: >>> When the PCI devres API was introduced to this driver, it was >>> wrongly >>> assumed that initializing the device with pc

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-27 Thread Hans de Goede
Hi, On 3/26/24 4:39 PM, Benjamin Tissoires wrote: > On Mar 26 2024, Werner Sembach wrote: >> Hi all, >> >> Am 25.03.24 um 19:30 schrieb Hans de Goede: >> >> [snip] >>>>> If the kernel already handles the custom protocol into generic HID, the >&

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Hans de Goede
Hi Werner, On 3/25/24 5:48 PM, Werner Sembach wrote: > Hi Benjamin, > > Am 25.03.24 um 16:56 schrieb Benjamin Tissoires: >> On Mar 25 2024, Hans de Goede wrote: >>> +Cc: Bentiss, Jiri >>> >>> Hi Werner, >>> >>> On 3/20/24 12:16 PM, Wer

In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Hans de Goede
+Cc: Bentiss, Jiri Hi Werner, On 3/20/24 12:16 PM, Werner Sembach wrote: > Hi Hans and the others, > > Am 22.02.24 um 14:14 schrieb Werner Sembach: >> Hi, >> >> Thanks everyone for the exhaustive feedback. And at least this thread is a >> good comprehesive reference for the future ^^. >> >> To

Re: Future handling of complex RGB devices on Linux v3

2024-03-25 Thread Hans de Goede
Hi Werner, On 3/19/24 4:18 PM, Werner Sembach wrote: > Hi Hans, > > Am 18.03.24 um 12:11 schrieb Hans de Goede: >> Hi Werner, >> >> Sorry for the late reply. > np >> >> On 2/22/24 2:14 PM, Werner Sembach wrote: >>> Hi, >>> >>>

Re: Future handling of complex RGB devices on Linux v3

2024-03-18 Thread Hans de Goede
Hi Werner, Sorry for the late reply. On 2/22/24 2:14 PM, Werner Sembach wrote: > Hi, > > Thanks everyone for the exhaustive feedback. And at least this thread is a > good comprehesive reference for the future ^^. > > To recap the hopefully final UAPI for complex RGB lighting devices: > > - By

Re: [PATCH v4 10/10] drm/vboxvideo: fix mapping leaks

2024-03-03 Thread Hans de Goede
; Fixes: 8558de401b5f ("drm/vboxvideo: use managed pci functions") > Signed-off-by: Philipp Stanner Thanks, patch looks good to me: Reviewed-by: Hans de Goede Since this depends on the pcim_iomap_range() function which is new in this series and since the vboxvideo code does not see

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-28 Thread Hans de Goede
Hi Daniel, On 2/28/24 03:00, Daniel van Vugt wrote: > On 27/2/24 21:47, Hans de Goede wrote: > I think some boot failures also take you to the grub menu automatically next > time? In Fedora all boot failures will unhide the grub menu on the next boot. This unfortunately relies on d

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-27 Thread Hans de Goede
Hi, On 2/27/24 02:06, Daniel van Vugt wrote: > On 27/2/24 02:23, Hans de Goede wrote: >> Hi All, >> >> On 2/2/24 09:53, Daniel van Vugt wrote: >>> Until now, deferred console takeover only meant defer until there is >>> output. But that risks stepping

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-26 Thread Hans de Goede
Hi All, On 2/2/24 09:53, Daniel van Vugt wrote: > Until now, deferred console takeover only meant defer until there is > output. But that risks stepping on the toes of userspace splash screens, > as console messages may appear before the splash screen. So check for the > "splash" parameter (as use

Re: [PATCH 1/2] devm-helpers: Add resource managed version of mutex init

2024-02-22 Thread Hans de Goede
Hi, On 2/22/24 17:44, Matthew Auld wrote: > On 22/02/2024 14:58, Marek Behún wrote: >> A few drivers are doing resource-managed mutex initialization by >> implementing ad-hoc one-liner mutex dropping functions and using them >> with devm_add_action_or_reset(). Help drivers avoid these repeated >>

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Hans de Goede
Hi, On 2/22/24 12:38, Gregor Riepl wrote: >> This certainly is the most KISS approach. This proposal >> in essence is just an arbitrary command multiplexer / >> demultiplexer and ioctls already are exactly that. >> >> With the added advantage of being able to directly use >> pass the vendor-cmd-sp

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Hans de Goede
Hi, On 2/21/24 23:17, Pavel Machek wrote: > Hi! > >> so after more feedback from the OpenRGB maintainers I came up with an even >> more generic proposal: >> https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 > >>> evaluate-set-command ioctl taking: >>> { >>>     enum comman

  1   2   3   4   5   6   7   8   9   10   >