Re: [PATCH v1 32/36] crypto: remove nth_page() usage within SG entry

2025-08-30 Thread Herbert Xu
On Thu, Aug 28, 2025 at 12:01:36AM +0200, David Hildenbrand wrote: > It's no longer required to use nth_page() when iterating pages within a > single SG entry, so let's drop the nth_page() usage. > > Cc: Herbert Xu > Cc: "David S. Miller" > Signed-off-

[PATCH] dma-buf: Add forward declaration of struct seq_file in dma-fence.h

2025-05-30 Thread Herbert Xu
Add forward declaration of struct seq_file before using it in function prototype. Fixes: a25efb3863d0 ("dma-buf: add dma_fence_describe and dma_resv_describe v2") Signed-off-by: Herbert Xu diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index e7ad819962e3..b751ae49d

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-19 Thread Herbert Xu
at what's actually needed? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-11 Thread Herbert Xu
ey.c Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-10 Thread Herbert Xu
There is actually a user-space interface for asymmetric crypto through the keyring subsystem. Adding the maintainers of those in case they wish to comment on your driver. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 02/19] crypto: testmgr: Include instead of

2024-09-30 Thread Herbert Xu
On Mon, Sep 30, 2024 at 02:33:13PM +0200, Uros Bizjak wrote: > Substitute the inclusion of header with > to allow the removal of legacy inclusion > of from . > > Signed-off-by: Uros Bizjak > Cc: Herbert Xu > Cc: "David S. Miller" > --- > crypto/

Re: [PATCH RESEND v2 02/19] crypto: testmgr: Include instead of

2024-09-11 Thread Herbert Xu
Uros Bizjak wrote: > Substitute the inclusion of header with > to allow the removal of legacy inclusion > of from . > > Signed-off-by: Uros Bizjak > Cc: Herbert Xu > Cc: "David S. Miller" > --- > crypto/testmgr.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH v7 0/5] Add Tegra Security Engine driver

2024-04-12 Thread Herbert Xu
ngs/crypto/nvidia,tegra234-se-aes.yaml > create mode 100644 > Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-hash.yaml > create mode 100644 drivers/crypto/tegra/Makefile > create mode 100644 drivers/crypto/tegra/tegra-se-aes.c > create mode 100644 drivers/crypto/teg

Re: [PATCH v2 10/25] crypto: virtio - drop owner assignment

2024-04-05 Thread Herbert Xu
| 1 - > 1 file changed, 1 deletion(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver

2024-04-02 Thread Herbert Xu
t tegra_sha_reqctx) + > crypto_ahash_reqsize(ctx->fallback_tfm)); Yes if you places the fallback request at the end of reqctx then this is the correct reqsize. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver

2024-03-28 Thread Herbert Xu
. You should place the fallback_req at the end of the reqctx and set the reqsize based on the fallback reqsize. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver

2024-03-28 Thread Herbert Xu
.cra_alignmask = 0xf, > + .cra_module = THIS_MODULE, > + }, > + } > + }, { OFB no longer exists in the kernel. Please remove all traces of it from your driver. Also please ensure that yuor driver passes the extra fuzz tests. Thanks, -- Email: Herbert Xu

Re: [PATCH v2] crypto: ccp - Allocate TEE ring and cmd buffer using DMA APIs

2022-12-31 Thread Herbert Xu
ce, and the machine address was > returned > in the dma handle (buf->dma). So is this even relevant to the mainstream kernel or is this patch only needed for Xen Dom0? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-15 Thread Herbert Xu
tionally, even on 64-bit architectures where HIGHMEM > is irrelevant. So using kmap_atomic() here means that the bulk of > WireGuard packet encryption runs with preemption disabled, essentially > for legacy reasons. Agreed. We should definitely fix that. Thanks, -- Email: Herbert Xu

[PATCH] crypto: lib/chacha20poly1305 - Set SG_MITER_ATOMIC unconditionally

2020-09-15 Thread Herbert Xu
ed-by: Linus Torvalds Signed-off-by: Herbert Xu diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c index 431e04280332..5850f3b87359 100644 --- a/lib/crypto/chacha20poly1305.c +++ b/lib/crypto/chacha20poly1305.c @@ -251,9 +251,7 @@ bool chacha20poly1305_crypt

Re: [PATCH -next] crypto: ccree - remove set but not used variable 'du_size'

2020-02-14 Thread Herbert Xu
cipher.c | 8 ---- > 1 file changed, 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/5] crypto: nx - Improve debugfs_create_u{32,64}() handling for atomics

2019-10-28 Thread Herbert Xu
d-off-by: Geert Uytterhoeven > --- > drivers/crypto/nx/nx_debugfs.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.or

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-28 Thread Herbert Xu
On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote: > > > On 28/04/17 12:30 AM, Herbert Xu wrote: > > You are right. Indeed the existing code looks buggy as they > > don't take sg->offset into account when doing the kmap. Could > > you send me s

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-28 Thread Herbert Xu
On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote: > > > On 26/04/17 09:56 PM, Herbert Xu wrote: > > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > >> Very straightforward conversion to the new function in the caam driver > >> an

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-27 Thread Herbert Xu
On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > Very straightforward conversion to the new function in the caam driver > and shash library. > > Signed-off-by: Logan Gunthorpe > Cc: Herbert Xu > Cc: "David S. Miller" > --- >

Re: [PATCH v5 0/2] crypto: hw_random - Add new Exynos RNG driver

2017-04-21 Thread Herbert Xu
Add Bartlomiej's reviewed-by. All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 2/2] crypto: hw_random - Add new Exynos RNG driver

2017-04-10 Thread Herbert Xu
, > + .base = { > + .cra_name = "exynos_rng", Please use stdrng. Or is there a reason why this can't be used by the crypto layer itself? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gon

Major 2.6.38 / 2.6.39 / 3.0 regression ignored?

2011-07-22 Thread Herbert Xu
new hardware) so I certainly don't have any objections to reverting this patch. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Major 2.6.38 / 2.6.39 / 3.0 regression ignored?

2011-07-22 Thread Herbert Xu
new hardware) so I certainly don't have any objections to reverting this patch. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ dri-devel mailing list dri-dev