Re: nouveau: DRM: GPU lockup - switching to software fbcon

2019-06-18 Thread Ilia Mirkin
On Wed, Jun 19, 2019 at 1:48 AM Sergey Senozhatsky wrote: > > On (06/19/19 01:20), Ilia Mirkin wrote: > > On Wed, Jun 19, 2019 at 1:08 AM Sergey Senozhatsky > > wrote: > > > > > > On (06/14/19 11:50), Sergey Senozhatsky wrote: > > > > dmesg > &

Re: nouveau: DRM: GPU lockup - switching to software fbcon

2019-06-18 Thread Ilia Mirkin
On Wed, Jun 19, 2019 at 1:08 AM Sergey Senozhatsky wrote: > > On (06/14/19 11:50), Sergey Senozhatsky wrote: > > dmesg > > > > nouveau :01:00.0: DRM: GPU lockup - switching to software fbcon > > nouveau :01:00.0: fifo: SCHED_ERROR 0a [CTXSW_TIMEOUT] > > nouveau :01:00.0: fifo: runli

Re: [PATCH 2/3] drm/rockchip: Add optional support for CRTC gamma LUT

2019-06-18 Thread Ilia Mirkin
On Tue, Jun 18, 2019 at 5:43 PM Ezequiel Garcia wrote: > > Add an optional CRTC gamma LUT support, and enable it on RK3288. > This is currently enabled via a separate address resource, > which needs to be specified in the devicetree. > > The address resource is required because on some SoCs, such

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-18 Thread Ilia Mirkin
On Tue, Jun 18, 2019 at 9:36 AM Ezequiel Garcia wrote: > > On Thu, 2019-06-13 at 15:36 -0400, Ilia Mirkin wrote: > > Note that userspace may provide any size of gamma lut. Have a look at > > i915/intel_color.c:intel_color_check which filters out only the > > allowed

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-13 Thread Ilia Mirkin
Note that userspace may provide any size of gamma lut. Have a look at i915/intel_color.c:intel_color_check which filters out only the allowed sizes. Consider having a special allowance for 256-sized LUTs since that's what most legacy userspace will set, and it seems like a waste to create a 10-bit

[PATCH v2] drm/nouveau/kms/gf119-: add ctm property support

2019-06-11 Thread Ilia Mirkin
This adds support on GF119:GV100 (exclusive) for CTM (aka CSC). Signed-off-by: Ilia Mirkin --- v1 -> v2: - ctm -> csc - mark csc.valid = false when there is no ctm property drivers/gpu/drm/nouveau/dispnv50/atom.h | 6 ++ drivers/gpu/drm/nouveau/dispnv50/base907c.

[PATCH 2/2] drm/nouveau/kms/nv50-: enable modern color management properties

2019-06-10 Thread Ilia Mirkin
For GF119:GV100, we can enable DEGAMMA/CTM/GAMMA. For earlier GPUs, as there is no CTM, having both degamma and gamma is a bit pointless. Later GPUs currently lack an implementation. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/dispnv50/head.c | 5 + 1 file changed, 5 insertions

[PATCH 1/2] drm/nouveau/kms/gf119-: add ctm property support

2019-06-10 Thread Ilia Mirkin
This adds support on GF119:GV100 (exclusive) for CTM (aka CSC). Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/dispnv50/atom.h | 6 ++ drivers/gpu/drm/nouveau/dispnv50/base907c.c | 65 + drivers/gpu/drm/nouveau/dispnv50/wndw.c | 13 + drivers/gpu/drm

Re: [PATCH libdrm 06/10] modetest: don't pretend that atomic mode includes a format

2019-06-06 Thread Ilia Mirkin
On Thu, Jun 6, 2019 at 11:51 AM Emil Velikov wrote: > > On Mon, 3 Jun 2019 at 01:40, Ilia Mirkin wrote: > > > > Signed-off-by: Ilia Mirkin > > --- > > tests/modetest/modetest.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >

Re: [PATCH libdrm 00/10] Add C8, 30bpp and FP16 support to modetest

2019-06-03 Thread Ilia Mirkin
On Sun, Jun 2, 2019 at 8:40 PM Ilia Mirkin wrote: > > This series improves the pattern generation logic to support additional > formats, as well as a new "gradient" pattern (see patch comments on why > I found it useful). > > Furthermore, these formats are piped throug

Re: [PATCH libdrm 00/10] Add C8, 30bpp and FP16 support to modetest

2019-06-03 Thread Ilia Mirkin
On Mon, Jun 3, 2019 at 3:32 AM Daniel Vetter wrote: > > On Sun, Jun 02, 2019 at 08:40:08PM -0400, Ilia Mirkin wrote: > > This series improves the pattern generation logic to support additional > > formats, as well as a new "gradient" pattern (see patch comments

[PATCH libdrm 10/10] modetest: add FP16 format support

2019-06-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/modetest/buffers.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/modetest/buffers.c b/tests/modetest/buffers.c index 5ec4ec8e..8a8d9e01 100644 --- a/tests/modetest/buffers.c +++ b/tests/modetest/buffers.c @@ -194,6 +194,13

[PATCH libdrm 09/10] modetest: add the ability to specify fill patterns on the commandline

2019-06-02 Thread Ilia Mirkin
Instead of hacking the binary every time, we can now specify directly. Signed-off-by: Ilia Mirkin --- tests/modetest/modetest.c | 29 - tests/util/pattern.c | 20 tests/util/pattern.h | 2 ++ 3 files changed, 46 insertions(+), 5

[PATCH libdrm 07/10] modetest: add an add_property_optional variant that does not print errors

2019-06-02 Thread Ilia Mirkin
As new features are added and others are declared to be legacy, it's nice to be able to implement fallbacks. As such, create a property-setting variant that does not generate errors which can very well be entirely expected. Will be used for gamma control in a future change. Signed-off-by:

[PATCH libdrm 06/10] modetest: don't pretend that atomic mode includes a format

2019-06-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/modetest/modetest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 9c85c07b..a1c81f6c 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -1335,8

[PATCH libdrm 04/10] util: add fp16 format support

2019-06-02 Thread Ilia Mirkin
This change adds support for all current patterns. Signed-off-by: Ilia Mirkin --- tests/util/format.c | 5 ++ tests/util/pattern.c | 207 ++- 2 files changed, 209 insertions(+), 3 deletions(-) diff --git a/tests/util/format.c b/tests/util/format.c

[PATCH libdrm 05/10] util: add cairo drawing for 30bpp formats when available

2019-06-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/util/pattern.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/util/pattern.c b/tests/util/pattern.c index 37796dbf..d197c444 100644 --- a/tests/util/pattern.c +++ b/tests/util/pattern.c @@ -788,6 +788,14 @@ static void make_pwetty(void

[PATCH libdrm 08/10] modetest: add C8 support to generate SMPTE pattern

2019-06-02 Thread Ilia Mirkin
This includes logic to configure the LUT accordingly. Signed-off-by: Ilia Mirkin --- tests/modetest/buffers.c | 2 ++ tests/modetest/modetest.c | 47 ++- 2 files changed, 44 insertions(+), 5 deletions(-) diff --git a/tests/modetest/buffers.c b/tests

[PATCH libdrm 00/10] Add C8, 30bpp and FP16 support to modetest

2019-06-02 Thread Ilia Mirkin
for the C8 indexed format. This was tested on nouveau, and used for bring-up of the C8, XB30, and FP16 formats on the NVIDIA hardware that supports these. Ilia Mirkin (10): util: add C8 format, support it with SMPTE pattern util: fix MAKE_RGBA macro for 10bpp modes util: add gradient pattern

[PATCH libdrm 02/10] util: fix MAKE_RGBA macro for 10bpp modes

2019-06-02 Thread Ilia Mirkin
We need to shift the values up, otherwise we'd end up with a negative shift. This works for up-to 16-bit components, which is fine for now. Signed-off-by: Ilia Mirkin --- tests/util/pattern.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/tests

[PATCH libdrm 01/10] util: add C8 format, support it with SMPTE pattern

2019-06-02 Thread Ilia Mirkin
This also adds a helper to generate a color LUT, which has to be used in conjunction with the C8 indexed format. Signed-off-by: Ilia Mirkin --- tests/util/format.c | 2 ++ tests/util/pattern.c | 75 tests/util/pattern.h | 4 +++ 3 files changed

[PATCH libdrm 03/10] util: add gradient pattern

2019-06-02 Thread Ilia Mirkin
). This is really only useful on 10bpc formats, but we also add support for 8bpc formats to ease testing. In the future, this could be applied to 16bpc formats as well. Signed-off-by: Ilia Mirkin --- tests/util/pattern.c | 113 +-- tests/util/pattern.h | 1 + 2

Re: [Nouveau] [PATCH 1/2] drm/nouveau/disp/nv50-: force scaler for any non-default LVDS/eDP modes

2019-05-28 Thread Ilia Mirkin
e, which copies mode into adjusted_mode... Assuming it makes sense to use "mode", Ben, want to just do a fixup locally, or want me to send a revert + new patch? -ilia On Mon, May 27, 2019 at 2:24 AM Ben Skeggs wrote: > > On Sun, 26 May 2019 at 08:41, Ilia Mirkin wrote: > &g

[PATCH 2/2] drm/nouveau/disp/nv50-: fix center/aspect-corrected scaling

2019-05-25 Thread Ilia Mirkin
/show_bug.cgi?id=110660 Signed-off-by: Ilia Mirkin --- Tested on a 1920x1200-native screen with a 640x480 mode (got letter boxes on the side) and 720x400 mode (got letter boxes on top/bottom). drivers/gpu/drm/nouveau/dispnv50/head.c | 28 + 1 file changed, 24 insertions(+), 4

[PATCH 1/2] drm/nouveau/disp/nv50-: force scaler for any non-default LVDS/eDP modes

2019-05-25 Thread Ilia Mirkin
, and i915 already does it this way. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110660 Signed-off-by: Ilia Mirkin --- Untested for now, hoping that the bugzilla filer will test it out. Seems obvious though. drivers/gpu/drm/nouveau/dispnv50/disp.c | 9 +++-- 1 file changed, 7 inser

Re: [Nouveau] [PATCH] drm/nouveau: fix duplication of nv50_head_atom struct

2019-05-15 Thread Ilia Mirkin
On Tue, May 14, 2019 at 3:57 PM Peteris Rudzusiks wrote: > > On Tue, May 14, 2019 at 04:55:05PM +1000, Ben Skeggs wrote: > > On Sun, 12 May 2019 at 04:23, Peteris Rudzusiks > > wrote: > > > > > > nv50_head_atomic_duplicate_state() makes a copy of nv50_head_atom > > > struct. This patch adds copyi

Re: drm/nouveau/bios/ramcfg, setting of RON pull value

2019-02-16 Thread Ilia Mirkin
On Sat, Feb 16, 2019 at 10:02 AM Colin Ian King wrote: > > Hi, > > Static Analysis with CoverityScan as detected an issue with the setting > of the RON pull value in function nvkm_gddr3_calc in > drm/nouveau/bios/ramcfg.c > > This was introduced by commit: c25bf7b6155cb ("drm/nouveau/bios/ramcfg:

Re: [PATCH 02/11] drm/modes: Add DRM_SIMPLE_MODE()

2019-01-20 Thread Ilia Mirkin
You don't appear to set the mm in the new macro. Not sure if it's on purpose. On Sun, Jan 20, 2019, 06:43 Noralf Trønnes This adds a helper macro to specify modes that only contain info about > resolution. > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/tinydrm/hx8357d.c | 2 +- > d

Re: [PATCH v2 0/6] drm: byteorder fixes

2019-01-11 Thread Ilia Mirkin
On Fri, Jan 11, 2019, 05:26 Daniel Vetter On Fri, Jan 11, 2019 at 10:43:42AM +0100, Gerd Hoffmann wrote: > > On Fri, Jan 11, 2019 at 10:11:09AM +0100, Daniel Vetter wrote: > > > On Fri, Jan 11, 2019 at 10:08 AM Gerd Hoffmann > wrote: > > > > > > > > On F

Re: [PATCH v2 0/6] drm: byteorder fixes

2019-01-10 Thread Ilia Mirkin
Hi Gerd, What happened with this series (and the next one)? Semi-relatedly, I wonder if it wouldn't be better to just dump the BIG_ENDIAN flag and just define the "host" format to be the right one for a consistent little-endian interpretation. Cheers, -ilia On Wed, Sep 5, 2018 at 2:04 AM Ge

Re: Nouveau module X server not starting on a NP900X5N Kaby Lake machine

2019-01-01 Thread Ilia Mirkin
On Tue, Jan 1, 2019 at 5:30 PM Jan Vlietland wrote: > > Hi Ilia, many thanks for answering my mail. > > Tonight I tried to see what happens if I generate a xorg.conf file and place > it in /etc/X11/xorg.conf, as described here: > https://askubuntu.com/questions/4662/where-is-the-x-org-config-file

Re: Nouveau module results in total lockups without any dmesg trace on a NP900X5N Kaby Lake machine

2019-01-01 Thread Ilia Mirkin
On Tue, Jan 1, 2019 at 4:06 PM Jan Vlietland wrote: > > Hi Ben, David and Daniel , > > First of all happy new year. Based on advice of Greg K-H herewith a mail > about a number of Nouveau issues with my laptop. > > I installed various Kali linux versions up to Linux 4.20.0-rc7 > (downloaded, compi

Re: [Nouveau] [PATCH] drm/nouveau: Don't disable polling in fallback mode

2018-12-30 Thread Ilia Mirkin
Ben - ping? Just ran into this myself on a NV42. On Wed, Nov 14, 2018 at 11:01 AM Takashi Iwai wrote: > > On Fri, 14 Sep 2018 13:59:25 +0200, > Martin Peres wrote: > > > > On 14/09/2018 10:28, Ben Skeggs wrote: > > > On Wed, 12 Sep 2018 at 20:59, Takashi Iwai wrote: > > >> > > >> When a fan is c

[PATCH] drm/nouveau/volt/gf117: fix speedo readout register

2018-12-13 Thread Ilia Mirkin
GF117 appears to use the same register as GK104 (but still with the general Fermi readout mechanism). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108980 Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/nvkm/subdev/volt/gf100.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] drm/nouveau/falcon: avoid touching registers if engine is off

2018-12-13 Thread Ilia Mirkin
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108980 Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/nvkm/engine/falcon.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/falcon.c b/drivers/gpu/drm/nouveau/nvkm/engine

Re: [PATCH 1/7] gpu: host1x: Resize channel register region on Tegra186 and later

2018-11-26 Thread Ilia Mirkin
On Fri, Nov 23, 2018 at 7:31 AM Thierry Reding wrote: > > From: Thierry Reding > > The register region allocated per channel was decreased from 16384 bytes > to 256 bytes on Tegra186 and later. Resize the region to make sure every > channel (instead of only the first) is properly programmed. > >

Re: [PATCH] drm/nouveau: tegra: Initialize mode configuration

2018-11-07 Thread Ilia Mirkin
On Wed, Nov 7, 2018 at 10:34 AM Thierry Reding wrote: > > On Tue, Nov 06, 2018 at 06:41:22PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 06, 2018 at 05:24:15PM +0100, Thierry Reding wrote: > > > From: Thierry Reding > > > > > > Irrespective of whether or not the device has any usable outputs, the

Re: [PATCH] drm/ast: fixed reading monitor EDID not stable issue

2018-10-30 Thread Ilia Mirkin
On Tue, Oct 30, 2018 at 4:24 AM Y.C. Chen wrote: > > From: "Y.C. Chen" > > over-sample data to increase the stability with some specific monitors > > Signed-off-by: Y.C. Chen > --- > drivers/gpu/drm/ast/ast_mode.c | 32 ++-- > 1 file changed, 26 insertions(+), 6 dele

Re: [PATCH v2 15/29] drm/bridge/synopsys: dw-hdmi: Enable workaround for v2.12a

2018-10-09 Thread Ilia Mirkin
On Tue, Oct 9, 2018 at 1:40 PM Laurent Pinchart wrote: > > Hi Jernej, > > Thank you for the patch. > > On Sunday, 7 October 2018 12:38:51 EEST Jernej Skrabec wrote: > > It turns out that even new DW HDMI controllers exhibits same magenta > > line issues as older versions. > > > > Enable workaround

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-04 Thread Ilia Mirkin
On Tue, Sep 4, 2018 at 11:02 AM, Michel Dänzer wrote: > On 2018-09-04 3:05 p.m., Ilia Mirkin wrote: >> On Tue, Sep 4, 2018 at 4:00 AM, Michel Dänzer wrote: >>> On 2018-09-03 7:07 p.m., Ilia Mirkin wrote: >>>> On Mon, Sep 3, 2018 at 12:45 PM, Daniel Vetter wrote: &g

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-04 Thread Ilia Mirkin
On Tue, Sep 4, 2018 at 4:00 AM, Michel Dänzer wrote: > On 2018-09-03 7:07 p.m., Ilia Mirkin wrote: >> On Mon, Sep 3, 2018 at 12:45 PM, Daniel Vetter wrote: >>> On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: >>>> Userspace on big endian machhines typ

[PATCH 2/5] drm/nouveau/disp/gm200-: add scdc parameter setter

2018-09-03 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/nvkm/engine/disp/Kbuild| 1 + .../gpu/drm/nouveau/nvkm/engine/disp/hdmigm200.c | 34 ++ drivers/gpu/drm/nouveau/nvkm/engine/disp/ior.h | 2 ++ .../gpu/drm/nouveau/nvkm/engine/disp/sorgm200.c| 1 + .../gpu

[PATCH 4/5] drm/nouveau/disp: add support for setting scdc parameters for high modes

2018-09-03 Thread Ilia Mirkin
When SCDC is supported, make sure that we configure the GPU and monitor to the same parameters. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 40 - 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau

[PATCH 0/5] drm/nouveau: add basic HDMI 2.0 support

2018-09-03 Thread Ilia Mirkin
d by one or the other. But at least it works a little bit! Note that I have limited testing equipment, but I did verify that a GM204 trace referred to the same register for controlling scrambling. I may get access to a GM206 later in the week to verify there. Ilia Mirkin (5): drm/nouveau/disp: add

[PATCH 5/5] drm/nouveau/disp: take sink support into account for exposing 594mhz

2018-09-03 Thread Ilia Mirkin
Scrambling is required for supporting any mode over 340MHz. If it's not supported, reject any modes that would require it. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/nouveau_connector.c | 34 +++-- 1 file changed, 22 insertions(+), 12 deletions(-) diff

[PATCH 3/5] drm/nouveau/disp: keep track of high-speed state, program into clock

2018-09-03 Thread Ilia Mirkin
The register programmed by the clock method needs to contain a different setting for the link speed as well as special divider settings. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/nvkm/engine/disp/hdmigm200.c | 2 ++ drivers/gpu/drm/nouveau/nvkm/engine/disp/ior.h | 5

[PATCH 1/5] drm/nouveau/disp: add a way to configure scrambling/tmds for hdmi 2.0

2018-09-03 Thread Ilia Mirkin
High pixel clocks are required to use a 40 TMDS divider instead of 10, and even low ones may optionally use scrambling depending on device support. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/include/nvif/cl5070.h | 5 - drivers/gpu/drm/nouveau/nvkm/engine/disp/ior.h

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-03 Thread Ilia Mirkin
On Mon, Sep 3, 2018 at 12:45 PM, Daniel Vetter wrote: > On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: >> Userspace on big endian machhines typically expects the ADDFB ioctl >> returns a big endian framebuffer. drm_mode_addfb() will call >> drm_mode_addfb2() unconditionally with l

Re: [PATCH v6 3/5] drm/nouveau: Fix deadlock with fb_helper with async RPM requests

2018-08-13 Thread Ilia Mirkin
On Mon, Aug 13, 2018 at 3:07 PM, Lyude Paul wrote: > +bool > +nouveau_fbcon_hotplugged_in_suspend(struct nouveau_fbdev *fbcon) > +{ > + bool hotplug; > + > + if (!fbcon) > + return false; > + > + mutex_lock(&fbcon->hotplug_lock); > + hotplug = fbcon->hotplug_w

Re: [Nouveau] no mouse cursor on nv50

2018-06-17 Thread Ilia Mirkin
Lyude bisected a similar problem on a much newer GPU to this very same change as well. [Sorry, no useful information beyond that, but thought I'd make the connection.] On Sun, Jun 17, 2018 at 5:46 PM, Adam Borowski wrote: > Hi! > On v4.18-rc1, the mouse cursor is missing on my right monitor. > Ca

Re: [Nouveau] [PATCH][next] drm/nouveau/disp: avoid potential overflow on shift of int value

2018-05-27 Thread Ilia Mirkin
On Sun, May 27, 2018 at 5:54 PM, Colin King wrote: > From: Colin Ian King > > The constant values being shifted are 32 bit integers and may potentially > overflow on the shift. Avoid this potential overflow by making them > unsigned long long values before the shift. > > Detected by CoverityScan

Re: [PATCH v2 1/2] drm/ttm: Only allocate huge pages with new flag TTM_PAGE_FLAG_TRANSHUGE

2018-04-28 Thread Ilia Mirkin
On Sat, Apr 28, 2018 at 7:02 PM, Michel Dänzer wrote: > On 2018-04-28 06:30 PM, Ilia Mirkin wrote: >> On Fri, Apr 27, 2018 at 9:08 AM, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> Previously, TTM would always (with CONFIG_TRANSPARENT_HUGEPAGE ena

Re: [PATCH v2 1/2] drm/ttm: Only allocate huge pages with new flag TTM_PAGE_FLAG_TRANSHUGE

2018-04-28 Thread Ilia Mirkin
On Fri, Apr 27, 2018 at 9:08 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Previously, TTM would always (with CONFIG_TRANSPARENT_HUGEPAGE enabled) > try to allocate huge pages. However, not all drivers can take advantage > of huge pages, but they would incur the overhead for allocating and >

[PATCH] drm/nouveau: fix temp/pwm visibility, skip hwmon when no sensors exist

2018-04-22 Thread Ilia Mirkin
A NV34 GPU was seeing temp and pwm entries in hwmon, which would error out when read. These should not have been visible, but also the whole hwmon object should just not have been registered in the first place. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 16

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Ilia Mirkin
On Tue, Apr 3, 2018 at 9:32 AM, Michel Dänzer wrote: > On 2018-04-03 03:26 PM, Ilia Mirkin wrote: >> On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: >>> On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: >>>> Am 01.04.2018 um 20:21 schrieb Taka

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Ilia Mirkin
On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: > On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: >> Am 01.04.2018 um 20:21 schrieb Takashi Iwai: >> > On Sun, 01 Apr 2018 19:58:11 +0200, >> > Christian K6nig wrote: >> > > Am

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-01 Thread Ilia Mirkin
On Sun, Apr 1, 2018 at 1:39 PM, Christian König wrote: > Am 30.03.2018 um 22:45 schrieb Takashi Iwai: >> >> amdgpu driver lacks of modeset module option other drm drivers provide >> for enforcing or disabling the driver load. Interestingly, the >> amdgpu_mode variable declaration is already found

Re: nouveau 30bpp / deep color status

2018-03-08 Thread Ilia Mirkin
On Thu, Mar 8, 2018 at 11:57 AM, Mario Kleiner wrote: > Cc'ing mesa-dev, which was left out. > > > On 03/05/2018 01:40 PM, Ilia Mirkin wrote: >> >> On Mon, Mar 5, 2018 at 2:25 AM, Mario Kleiner >> wrote: >>> Afaics EGL does the right thing wr

Re: [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4

2018-03-07 Thread Ilia Mirkin
On Wed, Mar 7, 2018 at 6:44 PM, wrote: > From: Matt Atwood > > DP_TRAINING_AUX_RD_INTERVAL with DP 1.3 spec changed bit scheeme from 8 > bits to 7 in DPCD 0x000e. The 8th bit is used to identify extended > receiver capabilities. For panels that use this new feature wait interval > would be incre

Re: nouveau 30bpp / deep color status

2018-03-05 Thread Ilia Mirkin
On Mon, Mar 5, 2018 at 2:25 AM, Mario Kleiner wrote: > On 02/05/2018 12:50 AM, Ilia Mirkin wrote: >> >> In case anyone's curious about 30bpp framebuffer support, here's the >> current status: >> >> Kernel: >> >> Ben and I have switched the

Re: [PATCH] drm/nouveau: Replace the iturbt_709 prop with the standarad COLOR_ENCODNIG prop

2018-02-26 Thread Ilia Mirkin
On Tue, Feb 20, 2018 at 9:25 AM, Ilia Mirkin wrote: > On Tue, Feb 20, 2018 at 8:48 AM, Ville Syrjala > wrote: >> From: Ville Syrjälä >> >> Replace the ad-hoc iturbt_709 property with the new standard >> COLOR_ENCODING property. Compiles, but not tested. >&g

Re: [PATCH] drm/nouveau: prefer XBGR2101010 for addfb ioctl

2018-02-21 Thread Ilia Mirkin
On Mon, Feb 19, 2018 at 4:33 AM, Daniel Vetter wrote: > On Mon, Feb 19, 2018 at 10:21:54AM +0100, Daniel Vetter wrote: >> On Mon, Feb 05, 2018 at 09:10:12AM -0500, Ilia Mirkin wrote: >> > On Mon, Feb 5, 2018 at 8:58 AM, Ville Syrjälä >> > wrote: >> > > O

Re: [PATCH] drm/nouveau: Replace the iturbt_709 prop with the standarad COLOR_ENCODNIG prop

2018-02-20 Thread Ilia Mirkin
On Tue, Feb 20, 2018 at 8:48 AM, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the ad-hoc iturbt_709 property with the new standard > COLOR_ENCODING property. Compiles, but not tested. > > Cc: Daniel Vetter > Cc: nouv...@lists.freedesktop.org > Cc: Ben S

Re: [Nouveau] 4.16-rc1: UBSAN warning in nouveau/nvkm/subdev/therm/base.c + oops in nvkm_therm_clkgate_fini

2018-02-14 Thread Ilia Mirkin
On Wed, Feb 14, 2018 at 9:35 AM, Ilia Mirkin wrote: > On Wed, Feb 14, 2018 at 9:29 AM, Meelis Roos wrote: >>> This is 4.16-rc1+todays git on a lowly P4 with NV5, worked fine in 4.15: >> >> NV5 in another PC (secondary card in x86-64) made the systrem crash on >> bo

Re: [Nouveau] 4.16-rc1: UBSAN warning in nouveau/nvkm/subdev/therm/base.c + oops in nvkm_therm_clkgate_fini

2018-02-14 Thread Ilia Mirkin
On Wed, Feb 14, 2018 at 9:29 AM, Meelis Roos wrote: >> This is 4.16-rc1+todays git on a lowly P4 with NV5, worked fine in 4.15: > > NV5 in another PC (secondary card in x86-64) made the systrem crash on > boot, in nvkm_therm_clkgate_fini. Mind booting with nouveau.debug=trace? That should hopeful

Re: nouveau 30bpp / deep color status

2018-02-08 Thread Ilia Mirkin
On Wed, Feb 7, 2018 at 12:01 PM, Ville Syrjälä wrote: > On Wed, Feb 07, 2018 at 06:28:42PM +0200, Ville Syrjälä wrote: >> On Sun, Feb 04, 2018 at 06:50:45PM -0500, Ilia Mirkin wrote: >> > In case anyone's curious about 30bpp framebuffer support, here's the >>

Re: [PATCH] drm/nouveau: prefer XBGR2101010 for addfb ioctl

2018-02-05 Thread Ilia Mirkin
On Mon, Feb 5, 2018 at 8:58 AM, Ville Syrjälä wrote: > On Sat, Feb 03, 2018 at 02:11:23PM -0500, Ilia Mirkin wrote: >> Nouveau only exposes support for XBGR2101010. Prior to the atomic >> conversion, drm would pass in the wrong format in the framebuffer, but >> it was a

nouveau 30bpp / deep color status

2018-02-04 Thread Ilia Mirkin
In case anyone's curious about 30bpp framebuffer support, here's the current status: Kernel: Ben and I have switched the code to using a 256-based LUT for Kepler+, and I've also written a patch to cause the addfb ioctl to use the proper format. You can pick this up at: https://github.com/skeggsb

[PATCH] drm/nouveau: prefer XBGR2101010 for addfb ioctl

2018-02-03 Thread Ilia Mirkin
er to specify that it prefers the XBGR format variant for the addfb ioctl, and makes nouveau's nv50 display driver set it. (Prior gens had no support for 30bpp at all.) Signed-off-by: Ilia Mirkin Cc: sta...@vger.kernel.org # v4.10+ --- Wasn't sure if the nouveau line needs to be split out

Re: [Nouveau] swiotlb buffer is full

2018-01-31 Thread Ilia Mirkin
Yeah, a lot of people were getting that, as a result of some drm/ttm hugepage usage. Christian, did a fix ever end up going out? If so, what kernel was it included in? -ilia On Wed, Jan 31, 2018 at 11:05 AM, Ricardo Nabinger Sanchez wrote: > Hello, > > I've noticed firefox got randomly stuck,

Re: [RFC v2 3/4] drm/nouveau: Add support for BLCG on Kepler2

2018-01-25 Thread Ilia Mirkin
On Thu, Jan 25, 2018 at 10:35 PM, Lyude Paul wrote: > Same as the previous patch, but for Kepler2 now > > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + > drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 8 +-- > drivers/gpu/drm/nouveau/nvkm/engin

Re: nouveau. swiotlb: coherent allocation failed for device 0000:01:00.0 size=2097152

2018-01-01 Thread Ilia Mirkin
On Sun, Dec 31, 2017 at 3:53 PM, Mike Galbraith wrote: > On Sun, 2017-12-31 at 13:27 -0500, Ilia Mirkin wrote: >> On Tue, Dec 19, 2017 at 8:45 AM, Christian König >> wrote: >> > Am 19.12.2017 um 11:39 schrieb Michel Dänzer: >> >> >> >

Re: [RFC PATCH] drm: split up drm_ioctl to allow drivers to hook into "core" functions

2017-12-31 Thread Ilia Mirkin
On Sun, Dec 31, 2017 at 1:15 PM, Ilia Mirkin wrote: > Currently there's no way to allow a driver to reimplement any ioctls > from the drm core. This can be desirable to, e.g., override fixed format > selection logic, without turning to a midlayer-like solution. > > Signed

Re: nouveau. swiotlb: coherent allocation failed for device 0000:01:00.0 size=2097152

2017-12-31 Thread Ilia Mirkin
On Tue, Dec 19, 2017 at 8:45 AM, Christian König wrote: > Am 19.12.2017 um 11:39 schrieb Michel Dänzer: >> >> On 2017-12-19 11:37 AM, Michel Dänzer wrote: >>> >>> On 2017-12-18 08:01 PM, Tobias Klausmann wrote: On 12/18/17 7:06 PM, Mike Galbraith wrote: > > Greetings, > >

[RFC PATCH] drm: split up drm_ioctl to allow drivers to hook into "core" functions

2017-12-31 Thread Ilia Mirkin
Currently there's no way to allow a driver to reimplement any ioctls from the drm core. This can be desirable to, e.g., override fixed format selection logic, without turning to a midlayer-like solution. Signed-off-by: Ilia Mirkin --- I want drm_mode_addfb to pick a different format for

How to map depth=30 fb to XBGR instead of XRGB?

2017-12-30 Thread Ilia Mirkin
NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However drmAddFB with depth = 30 will use the mapping in drm_mode_legacy_fb_format and pick the XRGB version of the format. One solution is to tell userspace "stop using addfb, move to addfb2". However I'm hoping that there's some sort o

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2017-12-20 Thread Ilia Mirkin
On Wed, Dec 20, 2017 at 6:22 PM, Kristian Kristensen wrote: > On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel Vico > wrote: >> On Wed, 20 Dec 2017 11:54:10 -0800 >> Kristian Høgsberg wrote: >> > I'd like to see concrete examples of actual display controllers >> > supporting more format layouts th

Re: [PATCH 25/25] drm/armada: add iturbt_709 plane property to control YUV colorspace

2017-12-13 Thread Ilia Mirkin
On Wed, Dec 13, 2017 at 10:41 AM, Daniel Stone wrote: > Hi Russell, > > On 8 December 2017 at 12:31, Russell King wrote: >> Add the defacto-standard "iturbt_709" property to the overlay plane to >> control the YUV to RGB colorspace conversion. This is mutually >> exclusive with the CSC_YUV CRTC

[PATCH libdrm v2] tests: fix MAKE_RGBA macro for 10bpp modes

2017-11-25 Thread Ilia Mirkin
We need to shift the values up, otherwise we'd end up with a negative shift. This works for up-to 16-bit components, which is fine for now. Signed-off-by: Ilia Mirkin --- v1 -> v2: fill low bits with high bits Fun - this breaks things for GK208. Not sure why. Works on G92 though. Prob

Re: Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-24 Thread Ilia Mirkin
On Fri, Nov 24, 2017 at 2:08 PM, Christian Zigotzky wrote: > On 24.11.2017 17:09, Michel Dänzer wrote: >> >> On 2017-11-24 03:29 PM, Christian Zigotzky wrote: >>> >>> Hi All, >>> >>> I bisected today and the first bad commit is: >>> a4dec819c8bba6365eb893a4ca88db4dd1210110 (drm/ttm: Add helper fun

Re: [PATCH libdrm] tests: fix MAKE_RGBA macro for 10bpp modes

2017-11-24 Thread Ilia Mirkin
On Fri, Nov 24, 2017 at 8:38 AM, Ville Syrjälä wrote: > On Thu, Nov 23, 2017 at 03:14:46PM -0500, Ilia Mirkin wrote: >> On Thu, Nov 23, 2017 at 2:09 PM, Ville Syrjälä >> wrote: >> > On Thu, Nov 23, 2017 at 01:59:28PM -0500, Ilia Mirkin wrote: >> >> We need to

Re: [PATCH libdrm] tests: fix MAKE_RGBA macro for 10bpp modes

2017-11-23 Thread Ilia Mirkin
On Thu, Nov 23, 2017 at 2:09 PM, Ville Syrjälä wrote: > On Thu, Nov 23, 2017 at 01:59:28PM -0500, Ilia Mirkin wrote: >> We need to shift the values up, otherwise we'd end up with a negative >> shift. This works for up-to 16-bit components, which is fine for now. >

[PATCH libdrm] tests: fix MAKE_RGBA macro for 10bpp modes

2017-11-23 Thread Ilia Mirkin
We need to shift the values up, otherwise we'd end up with a negative shift. This works for up-to 16-bit components, which is fine for now. Signed-off-by: Ilia Mirkin --- tests/util/pattern.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests

Re: Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-22 Thread Ilia Mirkin
On Wed, Nov 22, 2017 at 8:40 AM, Christian Zigotzky wrote: > On 22 November 2017 at 2:27PM, Ilia Mirkin wrote: >> >> On Wed, Nov 22, 2017 at 8:20 AM, Christian Zigotzky >> wrote: >>> >>> Hi Alex, >>> >>> I reverted the following files in

Re: Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-22 Thread Ilia Mirkin
On Wed, Nov 22, 2017 at 8:20 AM, Christian Zigotzky wrote: > Hi Alex, > > I reverted the following files in the first bad commit (first DRM updates) Is the merge commit really the first bad commit? i.e. both parents of the merge are good, but the merge commit itself is bad? Or did you do this man

[PATCH libdrm v2] modetest: add C8 support to generate SMPTE pattern

2017-11-20 Thread Ilia Mirkin
Tested on nouveau with the CRTC only (no planes). Signed-off-by: Ilia Mirkin --- v1 -> v2: always set a flat gamma ramp for non-indexed modes tests/modetest/buffers.c | 2 ++ tests/modetest/modetest.c | 24 tests/util/format.c | 2 ++ tests/util/pattern.c |

Re: [PATCH libdrm] modetest: add C8 support to generate SMPTE pattern

2017-11-17 Thread Ilia Mirkin
On Fri, Nov 17, 2017 at 11:56 PM, Ilia Mirkin wrote: > Tested on nouveau with the CRTC only. > > Signed-off-by: Ilia Mirkin > --- > > Please note that I have no clue what the proper way to operate the gamma > interface is. This seemed OK, but the 256 seems awefully hard

[PATCH libdrm] modetest: add C8 support to generate SMPTE pattern

2017-11-17 Thread Ilia Mirkin
Tested on nouveau with the CRTC only. Signed-off-by: Ilia Mirkin --- Please note that I have no clue what the proper way to operate the gamma interface is. This seemed OK, but the 256 seems awefully hardcoded. Perhaps that won't work on other HW? tests/modetest/buffers.c | 2 ++

Re: Dynamically adding a PCI subfunction

2017-10-11 Thread Ilia Mirkin
On Wed, Oct 11, 2017 at 9:46 AM, Bjorn Helgaas wrote: > On Wed, Oct 11, 2017 at 08:54:05AM -0400, Ilia Mirkin wrote: >> On Wed, Oct 11, 2017 at 7:47 AM, Bjorn Helgaas wrote: >> > /* do magic */ >> > nvif_mask(&device->object, 0x088488, (1 <<

Re: Dynamically adding a PCI subfunction

2017-10-11 Thread Ilia Mirkin
On Wed, Oct 11, 2017 at 7:47 AM, Bjorn Helgaas wrote: > On Mon, Oct 09, 2017 at 10:41:38AM -0400, Ilia Mirkin wrote: >> Hello, >> >> As a bit of background, all NVIDIA GPUs since GT215 have an audio >> subfunction for HDMI(/DP) audio to be sent to the sink. This genera

Re: Dynamically adding a PCI subfunction

2017-10-09 Thread Ilia Mirkin
On Mon, Oct 9, 2017 at 11:45 AM, Christian König wrote: > Am 09.10.2017 um 16:41 schrieb Ilia Mirkin: >> >> Hello, >> >> As a bit of background, all NVIDIA GPUs since GT215 have an audio >> subfunction for HDMI(/DP) audio to be sent to the sink. This gener

Dynamically adding a PCI subfunction

2017-10-09 Thread Ilia Mirkin
Hello, As a bit of background, all NVIDIA GPUs since GT215 have an audio subfunction for HDMI(/DP) audio to be sent to the sink. This generally works. However some, especially laptop, devices come up with that function disabled. We have a quirk to enable it when coming back from runpm, but that d

Re: [Nouveau] [RFC PATCH] drm/nouveau/therm: initial implementation of new gp1xx temperature sensor

2017-08-30 Thread Ilia Mirkin
On Wed, Aug 30, 2017 at 10:55 PM, Rhys Kidd wrote: > Signed-off-by: Rhys Kidd > --- > .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 1 + > drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 6 +++ > drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild | 1 + > drivers/gpu/drm/nouveau/n

Re: [PATCH][V2] drm/nouveau: perform null check on msto[i] rathern than msto

2017-08-17 Thread Ilia Mirkin
On Thu, Aug 17, 2017 at 6:03 PM, Colin King wrote: > From: Colin Ian King > > The null check on the array msto is incorrect since msto is never > null. The null check should be instead on msto[i] since this is > being dereferenced in the call to drm_mode_connector_attach_encoder. > > Thanks to Em

[PATCH 4/4] drm/nouveau/dispnv04: fix exposed format list

2017-08-05 Thread Ilia Mirkin
55 however, as tested with modetest. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 36 - 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/cr

[PATCH 2/4] drm/nouveau/overlay: improve error detection, fix pitch setting

2017-08-05 Thread Ilia Mirkin
ction. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/dispnv04/overlay.c | 62 -- 1 file changed, 34 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c b/drivers/gpu/drm/nouveau/dispnv04/overlay.c index e54944d23268..5bd63c2

[PATCH 0/4] Overlay / format improvements

2017-08-05 Thread Ilia Mirkin
some modest modetest testing on NV5, NV17, NV34, and NV4A. I noticed some odd issues on NV5 with certain scaling factors, but I'm somewhat sure that those issues were there before - either the hw can't keep up or we're not twiddling some clocks. Ilia Mirkin (4): drm/nouv

[PATCH 3/4] drm/nouveau/overlay: add NV21 support

2017-08-05 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/dispnv04/overlay.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c b/drivers/gpu/drm/nouveau/dispnv04/overlay.c index 5bd63c2f14a6..c8c2333f24ee 100644 --- a/drivers

[PATCH 1/4] drm/nouveau/display: prevent undisplayable framebuffers from creation

2017-08-05 Thread Ilia Mirkin
Pre-nv50 YUV overlays have stringent requirements for working with the internal machinery. Instead of rejecting these at update_plane time, we should instead prevent the framebuffers from being created in the first place. Signed-off-by: Ilia Mirkin --- drivers/gpu/drm/nouveau/nouveau_display.c

[PATCH] drm/nouveau/mpeg: print more debug info when rejecting dma objects

2017-08-05 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- This was helpful when debugging our earlier mpeg woes. May as well have it upstream. drivers/gpu/drm/nouveau/nvkm/engine/mpeg/nv31.c | 7 ++- drivers/gpu/drm/nouveau/nvkm/engine/mpeg/nv40.c | 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff

<    1   2   3   4   5   6   >