Re: [PATCH v3 00/13] Support for Exynos7870 DSIM bridge

isting patch. - Patch 10 was also merged without modification. Although it includes a behavioral change (removal of the fallback to pll_clk), I don’t foresee any issues. If any problems arise, I’ll revert it. And patch 13 has been merged into the exynos-drm-next branch. Thanks, Inki Dae

Re: [PATCH v3 10/13] drm/bridge: samsung-dsim: add ability to define clock names for every variant

if (ret) { > + dev_err(dev, "failed to get clocks in bulk (%d)\n", ret); > + return ret; Above change modifies the existing behavior. Previously, when devm_clk_get() failed and the clock name was "sclk_mipi", the code included a fall

Re: [PATCH v3 09/13] drm/bridge: samsung-dsim: increase timeout value for PLL_STABLE

d, I’m fine with merging it as-is for now. However, since this patch series likely has sufficient time to mainline, I believe this is a good opportunity to improve the related logic. Would you be open to trying the approach described above? Thanks, Inki Dae > do { > if

Re: [PATCH v3 03/13] drm/bridge: samsung-dsim: add flag to control header FIFO wait

oken_fifoctrl_emptyhdr and wait_for_hdr_fifo flags. If the handling of this behavior changes in newer Exynos SoCs, this approach may become confusing or lead to inconsistencies. Thanks, Inki Dae > > Signed-off-by: Kaustabh Chakraborty > --- > drivers/gpu/drm/bridge/samsung-dsim.c |

Re: [PATCH v4 0/2] Samsung Exynos 7870 DECON driver support

Hi Kaustabh Chakraborty, This patch series has been merged into the exynos-drm-next branch. Thanks, Inki Dae 2025년 7월 7일 (월) 오전 2:30, Kaustabh Chakraborty 님이 작성: > > This patch series aims at adding support for Exynos7870's DECON in the > Exynos7 DECON driver. It introduces

[GIT PULL] drm-misc-next-fixes

Hi Dave and Daniel, Just prevented pointer leakage in printk() of samsung-dsim.c module. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit fd03f82a026cc03cb8051a8c6487c99f96c9029f: drm/bridge: analogix_dp: Fix clk-disable removal

[GIT PULL] exynos-drm-fixes

Hi Dave and Daniel, Prevented pointer leakage in printk(), fixed kernel panic by ensuring DRM driver init and resolved Chromebook lockup with runtime PM guards. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit

Re: [PATCH v3 1/3] dt-bindings: display: samsung,exynos7-decon: add properties for iommus and ports

2025년 6월 27일 (금) 오후 4:51, Krzysztof Kozlowski 님이 작성: > > On Fri, Jun 27, 2025 at 02:02:37PM +0900, Inki Dae wrote: > > 2025년 6월 27일 (금) 오전 4:21, Kaustabh Chakraborty 님이 > > 작성: > > > > > > Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware

Re: [PATCH v2 01/13] drm/bridge: samsung-dsim: separate LINK and DPHY status registers

f (dsi->plat_data->hw_type == DSIM_TYPE_EXYNOS7870) reg = samsung_dsim_read(dsi, DSIM_LINK_STATUS_REG); else reg = samsung_dsim_read(dsi, DSIM_STATUS_REG); [1] [PATCH v2 12/13] drm/bridge: samsung-dsim: add driver support for exynos7870 DSIM bridge Thanks, Inki Dae > + DSIM_LIN

Re: [PATCH] drm/exynos: fimd: Guard display clock control with runtime PM calls

cess the register file without requesting runtime PM resume. As you pointed out, the main problem is that the analogix_dp driver calls exynos_drm_pipe_clk_enable() through exynos_dp_poweron() without requesting runtime PM. Given that the exynos_dp.c driver, which uses the analogix DP module, does re

Re: [PATCH v3 1/3] dt-bindings: display: samsung,exynos7-decon: add properties for iommus and ports

. > > Document these bindings in the devicetree schema. Applied. Thanks, Inki Dae > > Signed-off-by: Kaustabh Chakraborty > --- > .../bindings/display/samsung/samsung,exynos7-decon.yaml | 8 > > 1 file changed, 8 insertions(+) > > diff --git >

Re: [PATCH v3 3/3] drm/exynos: exynos7_drm_decon: add vblank check in IRQ handling

ank interrupt may be triggered before the initialization of drm_dev is complete. This could be the root cause of the issue. Applied. Thanks, Inki Dae > Otherwise, the panics don't happen. This indicates that it's some sort > of race condition. > > Add a check to validate if the drm de

Re: [PATCH v3 2/3] drm/exynos: exynos7_drm_decon: fix call of decon_commit()

led within exynos7_decon_resume() and exynos7_decon_suspend(). Unfortunately, I do not have hardware to test this patch myself. Would it be possible for you to try one of these approaches and verify the behavior? Option 1 would be the best solution if feasible. Thanks, Inki Dae > } > > static void decon_atomic_disable(struct exynos_drm_crtc *crtc) > > -- > 2.49.0 > >

Re: [PATCH 2/3] drm/exynos: Don't use %pK through printk

roved to avoid this issue. > Furthermore, restricted pointers ("%pK") were never meant to be used > through printk(). They can still unintentionally leak raw pointers or > acquire sleeping locks in atomic contexts. > > Switch to the regular pointer formatting which is safer and >

Re: [PATCH 1/3] drm/bridge: samsung-dsim: Don't use %pK through printk

roved to avoid this issue. > Furthermore, restricted pointers ("%pK") were never meant to be used > through printk(). They can still unintentionally leak raw pointers or > acquire sleeping locks in atomic contexts. > > Switch to the regular pointer formatting which is safer and >

Re: [PATCH v5 07/25] drm/exynos: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025년 6월 13일 (금) 오후 6:05, Thomas Zimmermann 님이 작성: > > Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and > buffer size. No alignment required. > Acked-by : Inki Dae Thanks, Inki Dae > Signed-off-by: Thomas Zimmermann > Cc: Inki Dae > Cc: Seung-Woo Kim

Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc()

commit was a mistake, I'm applying the revert by the end of this > week (i.e. on Friday) unless there are better instructions. Really sorry for late. I was made aware of it later through a colleague's remark. There is no need to proceed with the revert. Acked-by : Inki Dae Thanks, I

[GIT PULL] exynos-drm-fixes

Hi Dave and Daniel, Just minor fixups and cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 0467145fab3b3a7a1efd221722310fe32329b3da: Merge tag 'drm-msm-fixes-2025-04-18' of https://gitlab.freedesktop.org/drm/ms

Re: [PATCH] drm/exynos: fixed a spelling error

Hi, Merged. Thanks, Inki Dae 2025년 2월 28일 (금) 오후 11:45, Anindya Sundar Gayen 님이 작성: > Corrected a spelling mistake in the exynos_drm_fimd driver to improve code > readability. No functional changes were made. > > Signed-off-by: Anindya Sundar Gayen > --- > driv

Re: [PATCH] drm/exynos: exynos7_drm_decon: Consstify struct decon_data

Hi Krzysztof, Merged. Thanks, Inki Dae 2025년 3월 18일 (화) 오후 5:19, Krzysztof Kozlowski < krzysztof.kozlow...@linaro.org>님이 작성: > static 'struct decon_data' is only read, so it can be const for code > safety. > > Signed-off-by: Krzysztof Kozlowski >

Re: wait_event_timeout() usage in decon_wait_for_vblank()

ement the TE handler for the i80 interface in the te_handler of exynos_drm_crtc_ops and register it as a callback. Thanks, Inki Dae > Bjorn >

Re: [PATCH] drm/exynos: Remove unnecessary checking

Hi, 2024년 12월 6일 (금) 오후 8:45, Guoqing Jiang 님이 작성: > > It is not needed since drm_atomic_helper_shutdown checks it. Correct. Merged. Thanks, Inki Dae > > Signed-off-by: Guoqing Jiang > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +-- > 1 file changed, 1 inse

[GIT PULL v2] exynos-drm-next

-next tree. Therefore, I have merged the binding patch as well. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 086ed1d51544bfc1123b93eccc2ae88e0fbf3d51: Merge tag 'exynos-drm-next-for-v6.13' of git://git.kernel.org/pub/scm/li

[GIT PULL] exynos-drm-next

Hi Dave and Daniel, Add Decon support for Exynos7870 SoC, several fixups and cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit bcfe43f0ea77c42c2154fb79b99b7d1d82ac3231: drm/imx/dcss: include drm/drm_bridge.h header (2024-11

Re: [PATCH] drm/exynos: remove unused prototype for crtc

2024년 9월 26일 (목) 오후 2:33, Kwanghoon Son 님이 작성: > > exynos_drm_crtc_wait_pending_update, exynos_drm_crtc_finish_update > are not used anymore. Merged. Thanks, Inki Dae > > Signed-off-by: Kwanghoon Son > --- > drivers/gpu/drm/exynos/exynos_drm_crtc.h | 3 --- > 1 f

Re: [PATCH v1] drm/exynos: gsc: Fix typo in comment

obe(struct platform_device *pdev) > return ret; > } > > - /* context initailization */ > + /* context initialization */ Merged. Thanks, Inki Dae > ctx->id = pdev->id; > > platform_set_drvdata(pdev, ctx); > -- > 2.17.1 > >

[RESEND GIT PULL] exynos-drm-next

Hi Dave and Daniel, Just three cleanups and one fixup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit e066e9aa4d9c869c92d1d03647472e4ce96c0919: MAINATINERS: update drm maintainer contacts (2024-09-03 20:07:57 +0200) are available

[GIT PULL] exynos-drm-next

Hi Dave and Daniel, Just three cleanups and one fixup. Please kindly let me know if there is any problem. Thanks, The following changes since commit b1aa0491fad27f030c94ed42c873c3f46f5e7364: drm/xe: Fix merge fails related to display runtime PM (2024-09-02 14:14:07 +0200) are available

Re: [PATCH v1] drivers:drm:exynos_drm_gsc:Fix wrong assignment in gsc_bind()

ev = drm_dev; > - ctx->drm_dev = drm_dev; > + ipp->drm_dev = drm_dev; Correct. drm_dev should be set to ipp->drm_dev like other sub modules of ipp - fimc, scaler and rotator - did. Applied. Thanks, Inki Dae > exynos_drm_register_dma(drm_dev, dev, &ctx->dma_priv); > > exynos_drm_ipp_register(dev, ipp, &ipp_funcs, > -- > 2.34.1 > >

Re: [PATCH] drm/exynos: Remove unnecessary code

Hi Kwanghoon, 2024년 8월 14일 (수) 오후 12:57, Kwanghoon Son 님이 작성: > > Function usage exynos_atomic_commit was removed in > commit 41cbf0fdaa28 ("drm/exynos: use atomic helper commit"). > Remove unnecessary function declare. It's true. Applied. Thanks, Inki Dae >

Re: [PATCH] drm/exynos: Constify struct exynos_drm_ipp_funcs

4461714 16 2217656a0 > drivers/gpu/drm/exynos/exynos_drm_fimc.o > > Signed-off-by: Christophe JAILLET Applied. Thank for contribution, Inki Dae > --- > Compile tested-only. > --- > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 +- > drivers/gpu/drm/exynos/exyno

Re: [PATCH] dt-bindings: MAINTAINERS: drop stale exynos file pattern

tof Kozlowski Applied. Seems that RC7 is already late, so I have merged it into the eynox-drm-next branch. Thanks, Inki Dae > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 028186bb4e8d..c75918994a53 100644 > ---

[GIT PULL] exynos-drm-next

Hi Dave and Daniel, Just three cleanup patches to Exynos Virtual Display driver for improved management. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit fb625bf6187d97c3cd28d680b14bf80f84207e5a: Merge tag 'drm-habanalabs

Re: [PATCH 04/11] drm/exynos: hdmi: convert to struct drm_edid

hysical address gets invalidated > when the EDID could not be read. > > Signed-off-by: Jani Nikula > > --- > > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Krzysztof Kozlowski > Cc: Alim Akhtar > Cc: linux-arm-ker...@lists.infradead.org >

[GIT PULL] exynos-drm-fixes

Hi Dave and Daniel, Two fixups - one for an regeression issue and other for memory leak - and one cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit eb55943aab89be99a26e34fc2175ebb3583a2778: Merge tag 'drm-misc-next-

Re: [PATCH 1/4] drm/exynos/vidi: fix memory leak in .get_modes()

Hi Jani Nikula, The patch(1/4) has been applied to the -fixes branch, and the other three patches(2/4 ~ 4/4) have been applied to the -next branch. Thanks, Inki Dae 2024년 5월 30일 (목) 오후 7:02, Jani Nikula 님이 작성: > > The duplicated EDID is never freed. Fix it. > > Cc: sta...@vge

Re: [PATCH] drm/exynos: hdmi: report safe 640x480 mode as a fallback when no EDID found

; able to drive such mode, so report a safe 640x480 mode instead of nothing > in case of the EDID reading failure. > > This fixes the following issue observed on Trats2 board since commit > 13d5b040363c ("drm/exynos: do not return negative values from .get_modes()"): Applied

Re: [PATCH] gpu: drm: exynos: hdmi: eliminate uses of of_node_put()

Good cleanup. Applied. :) Thanks, Inki Dae 2024년 4월 15일 (월) 오전 9:40, Shivani Gupta 님이 작성: > > Utilize the __free() cleanup handler within the hdmi_get_phy_io function > to automatically release the device node when it is out of scope. > This eliminates the manual invocation of

[GIT PULL] exynos-drm-next

problem. Thanks, Inki Dae The following changes since commit 83221064c28a0f9fdc4f63ab4fce2e51bfe23315: Merge tag 'drm-xe-next-2024-04-23' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-next (2024-04-24 10:51:29 +1000) are available in the Git repository at: git://git.kern

[GIT PULL] drm-misc-fixes

te to the drm-exynos tree. This pull request is based on the latest drm-misc-fixes branch of the drm-misc tree. Please kindly let me know if there is any problem. Thanks, Inki Dae [1] https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/1151 The following changes since c

Inquiry regarding the use of the dim tool

a problem where the command `dim push-branch drm-misc-fixes` doesn't seem to work after I merge a patch using the command `cat 1.mbox | dim apply-branch drm-misc-fixes`. [1] https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/569 [2] https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html I'm still not quite familiar with using the dim tool. I'm sure there must be some aspects I'm missing. Could I please get some help with this? Thanks, Inki Dae

[GIT PULL] exynos-drm-fixes

Hi Dave and Daniel, Just several fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a: Linux 6.7 (2024-01-07 12:18:38 -0800) are available in the Git repository at: git

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

Really sorry for late. Will pick it up. Thanks, Inki Dae 2024년 1월 9일 (화) 오후 9:50, Daniel Vetter 님이 작성: > On Tue, Jan 09, 2024 at 09:47:20AM +0100, Michael Walle wrote: > > Hi, > > > > > > Inki, are you picking this up? Or if not, who will? > > > > > &g

Re: [PATCH] drm/exynos: gsc: minor fix for loop iteration in gsc_runtime_resume

> > Fixes: 8b7d3ec83aba ("drm/exynos: gsc: Convert driver to IPP v2 core > API") > > Signed-off-by: Fedor Pchelkin > Reviewed-by: Marek Szyprowski > Applied. Thanks, Inki Dae > --- > > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- > > 1 file

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

-by: Michael Walle > >> --- > >> Let me know wether this should be two commits each reverting one, but > >> both > >> commits appeared first in kernel 6.5. > > > > Are there any news? > > Inki, are you picking this up? Or if not, who will? > I can pick it up but it would be better to go to the drm-misc tree. If nobody cares about it then I will pick it up. :) acked-by : Inki Dae Thanks, Inki Dae

Re: [PATCH] drm/exynos: fix accidental on-stack copy of exynos_drm_plane

se a pointer instead. > > > > Fixes: 6f8ee5c21722 ("drm/exynos: fimd: Make plane alpha configurable") > > Signed-off-by: Arnd Bergmann > > > Reviewed-by: Marek Szyprowski > Thanks, Inki Dae > > > > --- > > drivers/gpu/drm/exynos/exynos

[PATCH] drm/exynos: fix incorrect type issue

Fix incorrect type issue in fimd_commit() of exynos_drm_fimd.c module. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312140930.me9ywf8f-...@intel.com/ Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] dt-bindings: display: samsung, exynos-mixer: Fix 'regs' typo

2023년 12월 14일 (목) 오전 7:43, Rob Herring 님이 작성: > The correct property name is 'reg' not 'regs'. > Thanks, Inki Dae > Fixes: 68e89bb36d58 ("dt-bindings: display: samsung,exynos-mixer: convert > to dtschema") > Signed-off-by: Rob Herring > --

Re: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

From: Uwe Kleine-König > > > Sent: Wednesday, November 29, 2023 1:55 AM > > > To: Inki Dae > > > Cc: linux-samsung-...@vger.kernel.org; Daniel Vetter ; > > > Jingoo Han ; Seung-Woo Kim ; > > > Kyungmin Park ; DRI mailing list > > de...@lists.freed

[GIT PULL] exynos-drm-next

Hi Dave and Daniel, Just one fixup to shutdown relevant issue and two cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit a2f8994c1001cfa48483a3afa3550016a3ab0a3e: Merge tag 'exynos-drm-next-for-v6.7-rc5

[GIT PULL RESEND] exynos-drm-fixes

Hi Dave and Daniel, Just resending you the previous pull request[1] after resolving the build warning. [1] https://lore.kernel.org/dri-devel/20231120225537.1270358-1-inki@samsung.com/ Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes

[PATCH v2] drm/exynos: fix a wrong error checking

rpenter Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dma.c b/drivers/gpu/drm/exynos/exynos_drm_dma.c index a971590b8132..e2c7373f20c6 100644 --- a/drivers

Re: [GIT PULL] exynos-drm-fixes

Hi Dave, 2023년 11월 24일 (금) 오전 10:14, Dave Airlie 님이 작성: > On Tue, 21 Nov 2023 at 09:00, Inki Dae wrote: > > > > Hi Dave and Daniel, > > > >Two fixups - fixing a potential error pointer dereference and wrong > >error checking. > Hi Inki, > > This

[GIT PULL] exynos-drm-fixes

Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 98b1cc82c4affc16f5598d4fa14b1858671b2263: Linux 6.7-rc2 (2023-11-19 15:02:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos

Re: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

Hi, Sorry for late. There was a merge conflict so I fixed it manually and merged. And seems your patch description is duplicated so dropped duplicated one. Thanks, Inki Dae 2023년 11월 3일 (금) 오전 1:57, Uwe Kleine-König 님이 작성: > The .remove() callback for a platform driver returns an int wh

[PATCH] drm/exynos: fix a wrong error checking

)), which doesn't provide a suitable error value. So check if 'mapping' is NULL, and if it is, return ERR_PTR(-ENODEV). This issue[1] was reported by Dan. [1] https://www.spinics.net/lists/dri-devel/msg418271.html Reported-by : Dan Carpenter Signed-off-by: Inki Dae --- drivers

Re: [RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

Hi, 2023년 10월 6일 (금) 오후 10:51, Doug Anderson 님이 작성: > > Hi, > > On Thu, Oct 5, 2023 at 7:20 PM Inki Dae wrote: > > > > Thanks for testing. :) > > > > Acked-by : Inki Dae > > Inki: does that mean you'd like this to go through drm-misc? I'm ha

[GIT PULL] exynos-drm-fixes

Hi Dave and Daniel, Just one fixup to a potential error pointer dereference. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa: Linux 6.6-rc4 (2023-10-01 14:15:13 -0700) are available in

Re: [PATCH] drm: exynos: dsi: Convert to platform remove callback returning void

are converted, .remove_new() is renamed to .remove(). > > samsung_dsim_remove() returned 0 unconditionally. Make it return void > instead to convert the two related platform drivers to use > .remove_new(). > > Signed-off-by: Uwe Kleine-König It'd be better to go to drm-misc. R

Re: [RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

Thanks for testing. :) Acked-by : Inki Dae 2023년 9월 22일 (금) 오후 3:00, Marek Szyprowski 님이 작성: > > > On 21.09.2023 21:26, Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

ulating the PLL > configuration parameters. > > Signed-off-by: Michael Tretter > Reviewed-by: Inki Dae Acked-by: Inki Dae Thanks, Inki Dae --- > drivers/gpu/drm/bridge/samsung-dsim.c | 16 +--- > include/drm/bridge/samsung-dsim.h | 1 + > 2 files ch

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023년 9월 4일 (월) 오후 8:05, Michael Tretter 님이 작성: > On Mon, 04 Sep 2023 13:38:33 +0900, Inki Dae wrote: > > 2023년 8월 29일 (화) 오전 12:59, Michael Tretter 님이 > 작성: > > > > > > > > The PLL reference clock may change at runtime. Thus, reading the clock > >

Re: [PATCH 3/5] drm/bridge: samsung-dsim: update PLL reference clock

be between 2MHz and 30MHz? To other I.MX and Exynos engineers, please do not merge this patch until two SoC platforms are tested correctly. Thanks, Inki Dae > > Signed-off-by: Michael Tretter > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 15 +-- > 1 file changed, 1

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

samsung,mipi-dsim.yaml It says, "DISM oscillator clock frequency. If absent, the clock frequency of sclk_mipi will be used instead." However, this patch makes the sclk_mipi to be used first. Thanks, Inki Dae > fout = samsung_dsim_pll_find_pms(dsi, fin, freq, &p, &m, &am

Re: [PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

MIPI device attach step. > > > > Signed-off-by: Marco Felsch > > Signed-off-by: Michael Tretter > > Reviewed-by: Adam Ford #imx8mm-beacon > Tested-by: Adam Ford #imx8mm-beacon Reviewed-by: Inki Dae Acked-by: Inki Dae > > > --- > > drivers/gpu/drm

Re: [PATCH -next] drm/exynos: fix a potential error pointer dereference

e ERR_PTR(-ENODEV), > which can not be used directly. Fix this by checking the return value > before using it. > Applied. Thanks, Inki Dae > > Signed-off-by: Xiang Yang > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --g

[GIT PULL] exynos-drm-next

Hi Dave and Daniel, Just one fixup and cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit d9aa1da9a8cfb0387eb5703c15bd1f54421460ac: Merge tag 'drm-intel-gt-next-2023-08-04' of git://anongit.freedesktop.org/drm/drm-

Re: [PATCH -next] drm/exynos: remove redundant of_match_ptr

on CONFIG_OF, it's almost always > > better to leave out the of_match_ptr(), since the only thing it can > > possibly do is to save a few bytes of .text if a driver can be used both > > with and without it. Hence we remove of_match_ptr. > > > > Signed-off-by: Zhu Wa

[GIT PULL] exynos-drm-fixes

Hi Dave and Daniel, Just two fixups to Exynos vidi and g2d drivers. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 9561de3a55bed6bdd44a12820ba81ec416e705a7: Linux 6.4-rc5 (2023-06-04 14:04:27 -0400) are available in the Git

Re: [PATCH] drm/exynos: vidi: fix a wrong error return

user > through > > the ictl system call - vidi_connection_ioctl - is used instead of fake > one - > > face_edid_info. > > In this case, ctx->raw_edid object needs to be released because > ctx->raw_edid > > object is allocated and the edid object sent by user is copied to the > ctx- > > >raw_edid by kmemdup(). :) > > yes... yes... I sent you another e-mail after this :) > I didn't check the second email you sent. :) Thanks, Inki Dae > Thanks, > Andi >

[PATCH] drm/exynos: vidi: fix a wrong error return

Fix a wrong error return by dropping an error return. When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info then only what we have to is to free ctx->raw_edid so that driver removing can work correctly - it's not an error case. Signed-off-by: Inki Dae ---

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

ial thing but how about renaming it? I think the postfix, 'new', is a very generic word. I think you could introduce another patch for it if you think it's reasonable. Thanks, Inki Dae > the driver core doesn't (and cannot) cope for errors during remove. The > only effect o

[GIT PULL] exynos-drm-fixes

Hi Dave and Daniel, Just one fixup to graphics 2d module for exynos. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit d8843eebbbd15b78c6a7745717b3705eca923b0f: Merge tag 'amd-drm-fixes-6.4-2023-05-11'

Re: [PATCH 18/53] drm/exynos: Convert to platform remove callback returning void

ways returning zero in > the remove callback to the void returning variant. Could you please update exynos_drm_vidi.c also? Seems you missed. Thanks, Inki Dae > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 6 ++ > drivers/gpu/dr

Re: [PATCH] drm/exynos: g2d: staticize stubs in header

2023년 5월 15일 (월) 오후 1:13, Inki Dae 님이 작성: > > Hi Krzysztof, > > 2023년 5월 7일 (일) 오후 11:48, Krzysztof Kozlowski > 님이 작성: > > > > Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static > > inline: > > Same patch[1] was posted before so I picked u

Re: [PATCH] drm/exynos: g2d: staticize stubs in header

finitions (kernel.org) Thanks, Inki Dae > > drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous > prototype for ‘g2d_open’ [-Wmissing-prototypes] > drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous > prototype for ‘g2d_close’ [-Wmissing-prototypes] >

[GIT PULL v2] exynos-drm-next

Hi Dave and Daniel, Sorry for late. Just one patch series which converts Exynos's fbdev code to struct drm_client. Please let me know if there is any problem. Thanks, Inki Dae The following changes since commit e82c98f2ca439356d5595ba8c9cd782f993f6f8c: Merge tag 'amd-drm-nex

Re: [GIT PULL] exynos-drm-next

Hi Daniel, 2023년 3월 29일 (수) 오후 2:39, 대인기 님이 작성: > > > > > -Original Message- > > From: Daniel Vetter > > Sent: Wednesday, March 29, 2023 2:31 AM > > To: Inki Dae > > Cc: airl...@linux.ie; dan...@ffwll.ch; dri-devel@lists.freedesktop.org; > >

[GIT PULL] exynos-drm-next

well. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 46f28427f6f824b6cff06fa025a55350b7de454a: Merge tag 'drm-rcar-next-20230325' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into drm-next (2023-03-2

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

Hi, 2023년 3월 27일 (월) 오후 11:08, Neil Armstrong 님이 작성: > On 23/03/2023 16:34, Fabio Estevam wrote: > > Hi Inki, > > > > On Mon, Mar 13, 2023 at 9:51 PM Inki Dae wrote: > > > >>> Could you please apply v16? > >> > >> > >> I am

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

bridge maintainers. However, if there are no further comments until next week, I will proceed with the pull-request. Thanks, Inki Dae > Thanks >

[GIT PULL] exynos-drm-next

review yet. [1] https://lore.kernel.org/linux-arm-kernel/d4267645-448c-f702-fcc3-6c534d9ec...@denx.de/T/ Please let me know if there is any problem. Thanks, Inki Dae The following changes since commit 68de345e101ce9a24e5c8849e69dd0dba2e8c9b2: Merge tag 'drm-misc-next-2023-01-24

Re: [PATCH 09/26] drm: exynos: Remove #ifdef guards for PM related functions

ch. > > Signed-off-by: Paul Cercueil Acked-by : Inki Dae Thanks for cleanup, Inki Dae > --- > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Krzysztof Kozlowski > Cc: Alim Akhtar > Cc: Jingoo Han > Cc: linux-arm-ker...@lists.infradead.org >

[GIT PULL] exynos-drm-next

Hi Dave and Daniel, Sorry for late. Just one cleanup and fixup which corrects return type. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 320305923c88258ce50c75bf721e9bf2e420ab27: Merge tag 'du-next-20220907' of git://l

Re: [PATCH] drm/exynos: fix repeated words in comments

rect. > "next next" is correct. :) As you said, "next next" could be reworded more clearly. As of now, the original sentence could make it confusing. Thanks, Inki Dae > Robin. > > > Signed-off-by: Jilin Yuan > > --- > > drivers/gpu/drm/e

[GIT PULL] exynos-drm-next

Hi Dave and Daniel, Just two cleanups which remove invalid maintainer info and one fixup for releasing resouce. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit c6a3d73592ae20f2f6306f823aa5121c83c88223: Merge tag 'drm-intel-gt

Re: [PATCH] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

m_detect_hdmi_monitor() and use drm_display_info.is_hdmi > instead. > Applied. Thanks, Inki Dae > Signed-off-by: hongao > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exy

Re: Exynos vblank timeout issue

Hi Martin, 2022년 6월 4일 (토) 오후 8:05, Martin Jücker 님이 작성: > > On Sat, Jun 04, 2022 at 01:05:39PM +0900, Inki Dae wrote: > > Hi Martin, > > > > Hi Inki, > > > What kind of panel does Galaxy Note 10.1 use? I guess it uses I80 > > panel which needs CPU-tr

[GIT PULL] exynos-drm-fixes

Hi Dave and Daniel, Just two regression fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3: Linux 5.19-rc2 (2022-06-12 16:11:37 -0700) are available in the Git repository at: git

Re: Exynos vblank timeout issue

ignal works or not in exynos_dsi_te_irq_handler function of exynos_drm_dsi.c Thanks, Inki Dae 2022년 5월 27일 (금) 오전 8:34, Martin Jücker 님이 작성: > > Hello again, > > I tried to dig around a bit to unearth some more information. What I'm > seeing is that it works just fine in the begi

Re: [PATCH] drm/exynos: mic: Rework initialization

misc-next together with the > rest of Exynos DSI to drm bridge rework patches. The commit-id, dd8b6803bc49, has already been merged to drm-next. Seems no need to go drm-misc-next. So I will merge it as a regression fix after the review, which will be merged to 5.19-rc series. Please let me kn

Re: [PATCH] drm/exynos: fix IS_ERR() vs NULL check in probe

Hi, 22. 4. 12. 13:19에 Dan Carpenter 이(가) 쓴 글: > On Tue, Apr 12, 2022 at 10:01:20AM +0900, Inki Dae wrote: >> Hi Dan Carpenter. >> >> Same patch[1] was posted so I will pick it up. >> >> [1] >> https://protect2.fireeye.com/v1/url?k=94e9d569-f562c05f-94e85

Re: [PATCH] drm/exynos: fix IS_ERR() vs NULL check in probe

Hi Dan Carpenter. Same patch[1] was posted so I will pick it up. [1] https://www.spinics.net/lists/arm-kernel/msg967488.html Thanks, Inki Dae 22. 4. 8. 19:21에 Dan Carpenter 이(가) 쓴 글: > The of_drm_find_bridge() does not return error pointers, it returns > NULL on error. >

[GIT PULL] exynos-drm-next for v5.18

Hi Dave and Daniel, Just adding BGR pixel format support per a plane. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit fedc89821990013608bc210c9aef5bb33a1345a7: drm/exynos: Search for TE-gpio in DSI panel's node (2022-03-04

Re: [PATCH v3 RESEND 21/24] drm/exynos/decon5433: add local path support

s DT schema checks. Let me know if other approach > (revert of DTS change) should be taken. > Sorry for late response. As of now, "dsd" is a dead property not used anywhere. This patch series makes real user not to work correctly due to ABI change. How about reverting it until this patch series is merged after fixing the real user problem? Thanks, Inki Dae > Best regards, > Krzysztof >

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

Hi Martin, 22. 2. 25. 18:33에 Martin Jücker 이(가) 쓴 글: > Hello Inki, > > On Fri, Feb 25, 2022 at 12:52:56PM +0900, Inki Dae wrote: >> Hi Martin, >> >> 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: >>> Hello Inki, >>> >>> On Thu, Feb 24, 20

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

Hi Martin, 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: > Hello Inki, > > On Thu, Feb 24, 2022 at 10:41:04AM +0900, Inki Dae wrote: >> Hi Martin. >> >> I found that exynos4 and 5 data sheet include documented same register. >> RGB_ORDER_E field of VIDCONx regist

[GIT PULL] exynos-drm-fixes for rc6

Hi Dave and Daniel, Just fixups series. Ps. my previous git-pull request[1] isn't merged so I'm sending it again after rebasing on top of drm-fixes. Please kindly let me know if there is any problem. Thanks, Inki Dae [1] https://www.spinics.net/lists/dri-devel/msg3

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

documented register only. Sorry for late and thanks, Inki Dae 22. 1. 30. 07:01에 Martin Jücker 이(가) 쓴 글: > In the downstream kernels for exynos4 and exynos5 devices, there is an > undocumented register that controls the order of the RGB output. It can > be set to either normal order or reve

Re: [GIT PULL] exynos-drm-fixes

Hi Dave, Seems you missed. Is there any issue? Thanks, Inki Dae 22. 2. 10. 20:07에 Inki Dae 이(가) 쓴 글: > Hi Dave and Daniel, > >Just two fixup series - one is to fix irq chaining issue and other is >regressions to TE-gpio handling. > > Please let me know if th

  1   2   3   4   5   6   7   8   9   10   >