Re: [PATCH 09/10] drm/exynos: add G2D driver

2013-01-21 Thread Inki Dae
ted. Joonyoung, let it post. And I will post other things except g2dtest. Thanks, Inki Dae > BR, > -R > > On Fri, Mar 16, 2012 at 1:28 AM, Joonyoung Shim > wrote: >> On 03/15/2012 07:50 PM, Dave Airlie wrote: >>>> >>>> G2D is a 2D graphic accelerato

Re: [Linaro-mm-sig] [PATCH 5/7] seqno-fence: Hardware dma-buf implementation of fencing (v4)

2013-01-24 Thread Inki Dae
2013/1/16 Maarten Lankhorst : > Op 16-01-13 07:28, Inki Dae schreef: >> 2013/1/15 Maarten Lankhorst : >>> This type of fence can be used with hardware synchronization for simple >>> hardware that can block execution until the condition >>> (dma_buf[offset] -

[GIT PULL] exynos-drm-fixes

2013-01-24 Thread Inki Dae
Hi Dave, This pull request includes some bug fixes, code cleanups and exception codes. If there is any problem, please kindly let me know. Thanks, Inki Dae The following changes since commit 4af6924b8adce0c408ec3f366c42a61e0c304b28: Merge branch 'drm-fixes-3.8&#x

[PATCH] drm/exynos: fix iommu address allocation order

2013-01-28 Thread Inki Dae
This patch modifies iommu address allocation order from 64k to 4k. 64k order causes waste of the io space and this was our mistakes. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_iommu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH] drm/exynos: consider exception case to fb handle creation

2013-01-29 Thread Inki Dae
GETFB ioctl request creates a new handle to only one gem object so it should check if the given fb has one gem object. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fb.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a

Re: [PATCH v2] drm/exynos: Get HDMI version from device tree

2013-01-29 Thread Inki Dae
the version info register so we could support all mixer controllers of Exynos SoC checking that register. So if you are planning on such thing for Mixer also then I'd recommend you to consider checking that register. Thanks, Inki Dae > > Sean > _

Re: [PATCH 1/2] drm/exynos: add support for dt based search to exynos4 hdmi

2013-01-29 Thread Inki Dae
Hi Rahul, Could you add descriptions to dt document file? For this, you can refer to the below link, https://patchwork.kernel.org/patch/1948061/ Thanks, Inki Dae 2013/1/25 Rahul Sharma : > Signed-off-by: Rahul Sharma > --- > drivers/gpu/drm/exynos/exynos_ddc.c | 2 ++ &

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Inki Dae
2013/1/25 Sachin Kamat : > From: Ajay Kumar > > This patch adds device tree match table for Exynos G2D controller. > > Signed-off-by: Ajay Kumar > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) >

Re: [PATCH v2] drm/exynos: Get HDMI version from device tree

2013-01-30 Thread Inki Dae
2013/1/30 Sylwester Nawrocki : > Hi, > > > On 01/08/2013 11:56 PM, Stephen Warren wrote: >> >> On 01/08/2013 01:16 PM, Sean Paul wrote: >>> >>> Add a property to the hdmi node so we can specify the HDMI version in >>> the device tree instead of just defaulting to v1.4 with the existence of >>> the

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Inki Dae
> -Original Message- > From: Sylwester Nawrocki [mailto:sylvester.nawro...@gmail.com] > Sent: Thursday, January 31, 2013 5:51 AM > To: Inki Dae > Cc: Sachin Kamat; linux-me...@vger.kernel.org; dri- > de...@lists.freedesktop.org; devicetree-disc...@lists.ozlabs.org; &g

Re: [PATCH v2] drm/exynos: Get HDMI version from device tree

2013-01-30 Thread Inki Dae
2013/1/31 Stephen Warren : > On 01/30/2013 06:16 PM, Inki Dae wrote: >> 2013/1/30 Sylwester Nawrocki : >>> Hi, >>> >>> >>> On 01/08/2013 11:56 PM, Stephen Warren wrote: >>>> >>>> On 01/08/2013 01:16 PM, Sean Paul wrote: >>&

Re: [Linaro-mm-sig] [PATCH 4/7] fence: dma-buf cross-device synchronization (v11)

2013-01-31 Thread Inki Dae
;flags has FENCE_FLAG_ACCESS_WRITE_BIT as write operation and then other sides(read or write operation) would wait for the write operation completion. And also consumer calls that function with FENCE_FLAG_ACCESS_READ_BIT so that other consumers could ignore the fence-wait to any read operations

Re: [Linaro-mm-sig] [PATCH 4/7] fence: dma-buf cross-device synchronization (v11)

2013-01-31 Thread Inki Dae
2013/1/31 Daniel Vetter : > On Thu, Jan 31, 2013 at 06:32:15PM +0900, Inki Dae wrote: >> Hi, >> >> below is my opinion. >> >> > +struct fence; >> > +struct fence_ops; >> > +struct fence_cb; >> > + >> > +/** >> > + * s

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-31 Thread Inki Dae
Hi Kukjin, > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Kukjin Kim > Sent: Friday, February 01, 2013 9:15 AM > To: 'Sylwester Nawrocki'; 'Inki Dae' > Cc: 'Sachin Kam

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Inki Dae
> -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sachin Kamat > Sent: Friday, February 01, 2013 8:13 PM > To: Sylwester Nawrocki > Cc: Inki Dae; Kukjin Kim; Sylwester Nawrocki; linux-me...@vger

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Inki Dae
> -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sachin Kamat > Sent: Friday, February 01, 2013 8:40 PM > To: Inki Dae > Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- > me...

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Inki Dae
2013. 2. 1. 오후 8:52 Inki Dae 작성: > > >> -Original Message- >> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> ow...@vger.kernel.org] On Behalf Of Sachin Kamat >> Sent: Friday, February 01, 2013 8:40 PM >> To: Inki Dae >> Cc:

Re: [Linaro-mm-sig] [PATCH 6/7] reservation: cross-device reservation support

2013-02-03 Thread Inki Dae
f could be accessed by two more devices. So I guess that the fence_excl could be used for write access(may need buffer sync like blocking) and read access for the fence_shared(may not need buffer sync). I'm not sure that I understand these two things correctly so could you please give me

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-04 Thread Inki Dae
2013/2/4 Sachin Kamat : > On 1 February 2013 18:28, Inki Dae wrote: >> >> >> >> >> 2013. 2. 1. 오후 8:52 Inki Dae 작성: >> >>> >>> >>>> -Original Message- >>>> From: linux-media-ow...@vger.kernel.org [mailto:lin

RE: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-05 Thread Inki Dae
Looks good to me but please add document for it. To other guys, And is there anyone who know where this document should be added to? I'm not sure that the g2d document should be placed in Documentation/devicetree/bindings/gpu, media, drm/exynos or arm/exynos. At least, this document should be

RE: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-06 Thread Inki Dae
> -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Wednesday, February 06, 2013 5:03 PM > To: Inki Dae > Cc: linux-me...@vger.kernel.org; dri-devel@lists.freedesktop.org; > devicetree-disc...@lists.ozlabs.org; k.deb...@samsung.com; > s

RE: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-06 Thread Inki Dae
> -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sylwester Nawrocki > Sent: Wednesday, February 06, 2013 8:24 PM > To: Inki Dae > Cc: 'Sachin Kamat'; linux-me...@vger.kernel.org; dri- &

[PATCH] drm/exynos: fix wrong pointer access at vm close.

2013-02-12 Thread Inki Dae
between the changing and the restoring so wrong pointer access to filp->f_op and filp->private_data was induced by vm close callback. So this patch uses mutex lock properly to resolve this issue. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- driv

[PATCH] drm/exynos: release resources properly when fb creation is failed.

2013-02-12 Thread Inki Dae
From: YoungJun Cho This patch releases allocated resources properly when exynos_user_fb_create() is failed. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fb.c | 51 +--- 1 files changed

Re: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-12 Thread Inki Dae
Applied and will go to -next. And please post the document(in Documentation/devicetree/bindings/gpu/) for it later. Thanks, Inki Dae 2013/2/6 Sachin Kamat : > From: Ajay Kumar > > This patch adds device tree match table for Exynos G2D controller. > > Signed-off-by: Ajay Kumar

Re: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-12 Thread Inki Dae
2013/2/12 Sylwester Nawrocki : > On 02/12/2013 02:17 PM, Inki Dae wrote: >> Applied and will go to -next. >> And please post the document(in >> Documentation/devicetree/bindings/gpu/) for it later. > > There is already some old patch applied in the devicetree/next tree:

Re: [PATCH v5 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-14 Thread Inki Dae
2013/2/6 Vikas Sajjan : > Add support for parsing the display-timing node using video helper > function. > > The DT node parsing and pinctrl selection is done only if 'dev.of_node' > exists and the NON-DT logic is still maintained under the 'else' part. > > Signed-off-by: Leela Krishna Amudala > S

[GIT PULL] exynos-drm-next

2013-02-14 Thread Inki Dae
supports one more time. If there is any problem, please kindly let me know. Thanks, Inki Dae The following changes since commit 3314fdf8b44bd4914050614fa2c56b7c587fabc2: Merge branch 'drm-fb-helper' of git://people.freedesktop.org/~danvet/drm into drm-next (2013-02-15 10:22:01 +

[PATCH] libdrm/exynos: add test application for 2d gpu.

2013-02-18 Thread Inki Dae
, "#exynos_fimg2d_test -s connector_id@crtc_id:mode" With this above simple command, four primitive drawing operations would be called step by step and also rendered on the output device to the given connector and crtc id. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- co

RE: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-20 Thread Inki Dae
; + OF_USE_NATIVE_MODE); > + if (ret) { > + DRM_ERROR("failed: of_get_fb_videomode()\n" > + "with return value: %d\n", ret); > + return ret; >

[GIT PULL v2] exynos-drm-next

2013-02-20 Thread Inki Dae
parsing to exynos drm fimd [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree So these aren't merged this time. Please pull it. If there is any problem, please kindly let me know. Thanks, Inki Dae. The following changes since commit ca18e1426bb2db987b67030256477c9571a

Re: [PATCH] libdrm/exynos: add test application for 2d gpu.

2013-03-05 Thread Inki Dae
2013/3/3 Rob Clark : > On Sat, Mar 2, 2013 at 2:28 AM, Inki Dae wrote: >> Actually, we have already implemented the EXA part of X server and >> that has being used on our linux platform. But I think we could more >> improvement this. So are you writting user side g2d drive

Re: [PATCH v10 1/2] video: drm: exynos: Add display-timing node parsing using video helper function

2013-03-06 Thread Inki Dae
or pdata failed\n"); > + return -ENOMEM; > + } > + > + ret = of_get_fb_videomode(dev->of_node, &pdata->panel.timing, > + OF_USE_NATIVE_MODE); Add "select OF_VIDEOMODE" and "select FB_MODE_HELPERS" to drivers/gpu/drm/exyn

Re: [PATCH RFC] drm/exynos: hdmi: move hdmiphy related code to hdmiphy driver

2013-03-06 Thread Inki Dae
nd it > seems that already existing hdmiphy i2c device is just reused and > hdmiphy_power_on is reorganized to hdmiphy dpms operation: even calling > flow of power operations is reordered. > > But I'm not sure exynos_hdmiphy_driver_register() really need to be > called from

RE: [PATCH] drm/exynos: modify the compatible string for exynos fimd

2013-03-06 Thread Inki Dae
Already merged. :) > -Original Message- > From: Vikas Sajjan [mailto:vikas.saj...@linaro.org] > Sent: Thursday, March 07, 2013 4:09 PM > To: InKi Dae > Cc: dri-devel@lists.freedesktop.org; linux-me...@vger.kernel.org; > kgene@samsung.com; Joonyoung Shim; sunil j

RE: [PATCH v12 2/2] drm/exynos: enable OF_VIDEOMODE and FB_MODE_HELPERS for exynos drm fimd

2013-03-07 Thread Inki Dae
..bb25130 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -25,6 +25,8 @@ config DRM_EXYNOS_DMABUF > config DRM_EXYNOS_FIMD > bool "Exynos DRM FIMD" > depends on DRM_EXYNOS && !FB_S3C && !AR

RE: [PATCH RFC] drm/exynos: hdmi: move hdmiphy related code to hdmiphy driver

2013-03-07 Thread Inki Dae
> -Original Message- > From: 김승우 [mailto:sw0312@samsung.com] > Sent: Thursday, March 07, 2013 4:04 PM > To: Rahul Sharma > Cc: Inki Dae; linux-samsung-...@vger.kernel.org; Sean Paul; sunil joshi; > dri-devel@lists.freedesktop.org; Rahul Sharma; sw0312@samsung

Re: [PATCH] drivers: gpu: drm: exynos: Replaced kzalloc & memcpy with kmemdup

2013-03-11 Thread Inki Dae
Applied. Thanks, Inki Dae 2013/3/12 Alexandru Gheorghiu : > Replaced calls to kzalloc followed by memcpy with call to kmemdup. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu > --- > drivers/gpu/drm/exynos/exynos_drm_vidi.c |6 ++ > 1 file

[PATCH 0/7] Consider G2D hardware restrictions.

2013-03-13 Thread Inki Dae
e gem to be accessed by G2D dma. Inki Dae (1): drm/exynos: Add a new function to get gem buffer size YoungJun Cho (6): drm/exynos: Fix error routine to getting dma addr. drm/exynos: clear node object type at gem unmap drm/exynos: Fix G2D core mulfunctioning issue drm/exynos: Clean up som

[PATCH 1/7] drm/exynos: Fix error routine to getting dma addr.

2013-03-13 Thread Inki Dae
From: YoungJun Cho This patch fixes error routine when g2d_userptr_get_dma_add is failed. When sg_alloc_table_from_pages() is failed, it doesn't call sg_free_table() anymore. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/e

[PATCH 2/7] drm/exynos: clear node object type at gem unmap

2013-03-13 Thread Inki Dae
From: YoungJun Cho This patch clears node object type in G2D unmap cmdlist. The obj_type of cmdlist node has to be cleared in g2d_unmap_cmdlist_gem() so that the node can be reused in g2d_map_cmdlist_gem(). Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park

[PATCH 3/7] drm/exynos: Fix G2D core mulfunctioning issue

2013-03-13 Thread Inki Dae
OLD' command to the register so that command execution interrupt can be occured whenever each command list execution is finished. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 13 - 1 files changed

[PATCH 4/7] drm/exynos: Clean up some G2D codes for readability

2013-03-13 Thread Inki Dae
From: YoungJun Cho This patch just cleans up G2D codes for readability. For this, it changes the member of g2d_cmdlist_node, obj_type into buf_type and gathers relevant variables together. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm

[PATCH 6/7] drm/exynos: Add a new function to get gem buffer size

2013-03-13 Thread Inki Dae
This patch adds a new function to get gem buffer size. And this funtion could be used for g2d driver or others can get gem buffer size to check if the buffer is valid or not. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 21

[PATCH 5/7] drm/exynos: Deal with g2d buffer info more efficiently

2013-03-13 Thread Inki Dae
From: YoungJun Cho This patch adds g2d_buf_info structure and buffer relevant variables moves into the g2d_buf_info to manage g2d buffer information more efficiently. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_g2d.c

[PATCH 7/7] drm/exynos: Check g2d cmd list for g2d restrictions

2013-03-13 Thread Inki Dae
list has to be in valid range (1 to 8000 pixels) - The requested area should be less than buffer size. - right has to be bigger than left. - bottom has to be bigger than top. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/e

RE: [PATCH 3/7] drm/exynos: Fix G2D core mulfunctioning issue

2013-03-13 Thread Inki Dae
> -Original Message- > From: Joonyoung Shim [mailto:jy0922.s...@samsung.com] > Sent: Wednesday, March 13, 2013 6:53 PM > To: Inki Dae > Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org; > kyungmin.p...@samsung.com; sw0312@samsung.com; YoungJun Cho > Subject

RE: [PATCH 3/7] drm/exynos: Fix G2D core mulfunctioning issue

2013-03-13 Thread Inki Dae
> -Original Message- > From: Joonyoung Shim [mailto:jy0922.s...@samsung.com] > Sent: Wednesday, March 13, 2013 7:28 PM > To: Inki Dae > Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org; > kyungmin.p...@samsung.com; sw0312@samsung.com; 'YoungJun Cho

RE: [PATCH 3/7] drm/exynos: Fix G2D core mulfunctioning issue

2013-03-13 Thread Inki Dae
> -Original Message- > From: Joonyoung Shim [mailto:jy0922.s...@samsung.com] > Sent: Thursday, March 14, 2013 11:30 AM > To: Inki Dae > Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org; > kyungmin.p...@samsung.com; sw0312@samsung.com; 'YoungJun Cho

[PATCH v2 0/7] Consider G2D hardware restrictions.

2013-03-14 Thread Inki Dae
e gem to be accessed by G2D dma. Changelog v2: - Consider for interrupt setup to each command list and all command lists. - Revert irrelevant codes. - Fix merge conflict. Inki Dae (1): drm/exynos: Add a new function to get gem buffer size YoungJun Cho (6): drm/exynos: Fix error routine to ge

[PATCH v2 3/7] drm/exynos: Fix G2D core malfunctioning issue

2013-03-14 Thread Inki Dae
OLD' command to the register so that command execution interrupt can be occured whenever each command list execution is finished. Changelog v2: - Consider for interrupt setup to each command list and all command lists And correct typo. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Sig

[PATCH v2 4/7] drm/exynos: Clean up some G2D codes for readability

2013-03-14 Thread Inki Dae
From: YoungJun Cho This patch just cleans up G2D codes for readability. For this, it changes the member of g2d_cmdlist_node, obj_type into buf_type. Changelog v2: - Revert irrelevant codes. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu

[PATCH v2 5/7] drm/exynos: Deal with g2d buffer info more efficiently

2013-03-14 Thread Inki Dae
From: YoungJun Cho This patch adds g2d_buf_info structure and buffer relevant variables moves into the g2d_buf_info to manage g2d buffer information more efficiently. Changelog v2: - Fix merge conflict. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park

[PATCH v2 7/7] drm/exynos: Check g2d cmd list for g2d restrictions

2013-03-14 Thread Inki Dae
list has to be in valid range (1 to 8000 pixels) - The requested area should be less than buffer size. - right has to be bigger than left. - bottom has to be bigger than top. Changelog v2: - Fix merge conflict. Signed-off-by: YoungJun Cho Signed-off-by: Inki Dae Signed-off-by: Kyungmin

Re: [PATCH 0/7] Consider G2D hardware restrictions.

2013-03-18 Thread Inki Dae
rhead(maybe so much little??). Anyway now g2d driver needs its own page fault handler to recover g2d core on the unpredictable situation(not by invalid commands) and this is a TODO work. And I know that the unrecoverable issue is not because of invalid commands and that is a pair issue to HOLD CMD and

[GIT PULL] exynos-drm-fixes

2013-03-20 Thread Inki Dae
Hi Dave, This pull request includes bug fixes and code cleanups. And it considers some restrictions to G2D hardware. With this, the malfunction and page fault issues to g2d driver would be fixed. If there is any problem, please kindly let me know. Thanks, Inki Dae The following changes since

Re: [PATCH v2] drm/exynos: enable FIMD clocks

2013-03-27 Thread Inki Dae
if (ret) { > + clk_disable_unprepare(ctx->lcd_clk); > + dev_err(dev, "failed to enable 'fimd' clock\n"); > + return ret; > + } > + Please remove the above two clk_prepare_enable function calls and use them in fimd_clock() instea

Re: [PATCH 1/1] drm/exynos: drm_connector: Fix error check condition

2013-03-27 Thread Inki Dae
2013/3/21 Sachin Kamat : > drm_add_edid_modes() returns 0 upon failure to find any modes. > Hence check for 0 and not less than 0. > > Signed-off-by: Sachin Kamat > Cc: Rahul Sharma > --- > drivers/gpu/drm/exynos/exynos_drm_connector.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-

Re: [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD

2013-04-02 Thread Inki Dae
Applied. :) Thanks, Inki Dae 2013/4/2 Vikas Sajjan > Hi Mr. Inki Dae, > > Can you please review this patch.? > > On Wed, Mar 13, 2013 at 4:22 PM, Vikas Sajjan > wrote: > > Replaces the "platform_get_resource() for IORESOURCE_IRQ" with > > platform_ge

Re: [PATCH Resend 1/1] Revert "of/exynos_g2d: Add Bindings for exynos G2D driver"

2013-04-12 Thread Inki Dae
Applied. Thanks, Inki Dae 2013/4/12 Sachin Kamat > This reverts commit 09495dda6a62c74b13412a63528093910ef80edd. > The description is incomplete and the location of this file > is incorrect. Based on discussion with the Samsung media and DRM subsystem > maintainers, the doc

[GIT PULL] exynos-drm-fixes

2013-04-14 Thread Inki Dae
/kernel/git/kgene/linux-samsung.git If there is any problem, please kindly let me know. Thanks, Inki Dae The following changes since commit 89ced125472b8551c65526934b7f6c733a6864fa: drm/fb-helper: Fix locking in drm_fb_helper_hotplug_event (2013-04-12 14:21:12 +1000) are available in the git

Re: [GIT PULL] exynos-drm-fixes

2013-04-15 Thread Inki Dae
want to send to Linus right now. > > Understood. I thought not only bug fixes but also code cleanups would be -fixes and I missed that now is late stage. will re-send it without code cleanups. The code cleanups will go to -next. Sorry for my late pull request. Thanks, Inki Dae > Dave. &

Re: [GIT PULL] exynos-drm-fixes

2013-04-15 Thread Inki Dae
2013/4/16 Inki Dae > Hi Dave, > > > 2013/4/16 Dave Airlie > >> > >> > This pull request includes bug fixes, code cleanups and >> > one revert that removes the wrong bindings file for exynos >> > fimg2d device for code cleanup becasue correct on

[GIT PULL] exynos-drm-next

2013-04-16 Thread Inki Dae
pull one more time after reviewed. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 62c8ba7c58e4163f975c5f8b5a3dd5f306a2deda: drm/qxl: fix smatch warnings (2013-04-16 13:36:00 +1000) are available in the git repository at: git

Re: abuse of dumb ioctls in exynos

2013-04-17 Thread Inki Dae
river. > > Got it. I will post one patch to it soon. Thanks for your pointing out. Inki Dae > I was going to add one new flag to the interface for SCANOUT vs CURSOR > for some drivers. > > Dave. > ___ > dri-devel mailing list &

[PATCH] drm/exynos: do not use generic flags to dumb

2013-04-17 Thread Inki Dae
This patch removes the use of dumb flags from driver. As Dave pointed out, the dumb flags are not driver specific so this should be removed from driver. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_gem.c |3 ++- 1 files changed, 2 insertions

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-20 Thread Inki Dae
2013/4/19 Vikas Sajjan > Hi Inki Dae and Viresh, > > On 8 April 2013 16:41, Viresh Kumar wrote: > >> On 8 April 2013 16:37, Vikas Sajjan wrote: >> > While migrating to common clock framework (CCF), I found that the FIMD >> clocks >> > were pulled down

Re: [PATCH v2 0/3] drm/exynos: Add device tree support for IPP driver

2013-04-20 Thread Inki Dae
set looks good to me but I'd like to take more opinions from others. And you can find my comments at the third patch. Thanks, Inki Dae 2013/4/17 Sylwester Nawrocki > Hi Inki, > > This small patch series adds device tree support for the DRM FIMC driver. > The binding d

Re: [PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-20 Thread Inki Dae
2013/4/17 Sylwester Nawrocki > This patch adds OF initialization support for the FIMC driver. > The binding documentation can be found at Documentation/devicetree/ > bindings/media/samsung-fimc.txt. > > The syscon regmap interface is used to serialize access to the > shared CAMBLK registers from

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Inki Dae
gt; > > > Changes since v3: > > > - added clk_prepare() in fimd_probe() and clk_unprepare() in > > > fimd_remove()> > > > as suggested by Viresh Kumar > > > > > > Changes since v2: > > > - moved clk_p

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Inki Dae
2013/4/21 Tomasz Figa > On Sunday 21 of April 2013 13:23:10 Viresh Kumar wrote: > > On 20 April 2013 20:56, Inki Dae wrote: > > > Sorry for being late. I think clk_prepare/unprepare are nothing to do > > > yet in case of Exynos but those might be used for in the futur

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Inki Dae
Hi Tomasz, CCing Mr. Ham 2013/4/21 Tomasz Figa > Hi Inki, > > On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > > 2013/4/21 Tomasz Figa > > > > > Hi, > > > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > >

RE: [PATCH v3] drm/exynos: enable FIMD clocks

2013-04-21 Thread Inki Dae
't say what you are doing. You are just adding > relevant calls to clk_prepare/unprepare() before calling > clk_enable/disable. > > > Signed-off-by: Vikas Sajjan > > --- > > Changes since v2: > > - moved clk_prepare_enable() and clk_disable_unprepare()

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Inki Dae
2013/4/22 Tomasz Figa > On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: > > > > 2013/4/21 Tomasz Figa > > > > > > > > > Hi, > > > > > > > > > > On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: > > > >

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Inki Dae
2013/4/22 Sylwester Nawrocki > On 04/22/2013 12:03 PM, Inki Dae wrote: > > > Also looks good to me. But what if power domain was disabled > without pm > > > runtime? In this case, you must enable the power domain at machine > code or > > > boot

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Inki Dae
2013/4/22 Tomasz Figa > On Monday 22 of April 2013 12:17:39 Sylwester Nawrocki wrote: > > On 04/22/2013 12:03 PM, Inki Dae wrote: > > > > Also looks good to me. But what if power domain was disabled > without > > > > pm > > > > runtime

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Inki Dae
2013/4/22 Rafael J. Wysocki > On Monday, April 22, 2013 12:37:36 PM Tomasz Figa wrote: > > On Monday 22 of April 2013 12:17:39 Sylwester Nawrocki wrote: > > > On 04/22/2013 12:03 PM, Inki Dae wrote: > > > > > Also looks good to me. But what if po

Re: [PATCH v3] drm/exynos: enable FIMD clocks

2013-04-22 Thread Inki Dae
2013/4/22 Vikas Sajjan > > Hi Mr Dae, > > On 22 April 2013 11:19, Inki Dae wrote: > >> Hi, Mr. Vikas >> >> Please fix the below typos Viresh pointed out and my comments. >> >> > -Original Message- >> > From: Viresh Kumar [mailto:v

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-23 Thread Inki Dae
2013/4/23 myungjoo.ham > 2013/4/22 Inki Dae > > 2013/4/22 Rafael J. Wysocki > > > On Monday, April 22, 2013 12:37:36 PM Tomasz Figa wrote: > > > > On Monday 22 of April 2013 12:17:39 Sylwester Nawrocki wrote: > > > > > On 04/22/2013 12:03 PM, Inki Da

RE: [PATCH Resend] drm/exynos: Select VIDEOMODE_HELPERS for FIMD

2013-04-25 Thread Inki Dae
/drivers/gpu/drm/exynos/Kconfig > @@ -27,6 +27,7 @@ config DRM_EXYNOS_FIMD > depends on OF && DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM > select OF_VIDEOMODE The above line isn't needed anymore. I just removed and merged it. And I can't

Re: [PATCH 09/21] drm: export drm_vm_open_locked

2013-04-25 Thread Inki Dae
u/drm/exynos/exynosdrm.ko] > undefined! > > Signed-off-by: Arnd Bergmann > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > --- > drivers/gpu/drm/drm_vm.c | 1 + > 1 file changed, 1 ins

[PATCH] drm/exynos: fix multiple definition build error

2013-04-25 Thread Inki Dae
drm/exynos/exynos_drm_fimd.o:exynos_drm_fimd.c:(.rodata+0x144): first defined here Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

Re: [PATCH] drm/exynos: fix multiple definition build error

2013-04-26 Thread Inki Dae
Hi Tomasz, 2013/4/26 Tomasz Figa > Hi Inki, > > On Friday 26 of April 2013 14:03:10 Inki Dae wrote: > > This patch fixes multiple definition error like below when building it > > as moudle with device tree support. > > > > drivers/gpu/drm/exynos/exynos_

Re: [PATCH] drm/exynos: fix multiple definition build error

2013-04-28 Thread Inki Dae
2013/4/27 Tomasz Figa > On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote: > > On 04/26/2013 10:20 AM, Inki Dae wrote: > > > Exactly right. it's my mistake. But now it seems that > > > __mode_of_device_table is multi defined at fimd and g2d side so t

Re: [PATCH] drm/exynos: fix multiple definition build error

2013-04-28 Thread Inki Dae
2013/4/27 Sylwester Nawrocki > On 04/26/2013 09:42 PM, Tomasz Figa wrote: > >> On Friday 26 of April 2013 11:48:50 Sylwester Nawrocki wrote: >> >>> On 04/26/2013 10:20 AM, Inki Dae wrote: >>> >>>> Exactly right. it's my mistake. But now it se

[PATCH] module: fix mutiple defined issue

2013-04-28 Thread Inki Dae
e determined by type argument because the definition of 'of_device_id' should be fixed. So this patch makes 'of_devce_id' definition to be fixed and only its instance name to be defined by type. Signed-off-by: Inki Dae --- include/linux/module.h |2 +- 1 files changed, 1

[GIT PULL] exynos-drm-next

2013-04-28 Thread Inki Dae
, Inki Dae The following changes since commit 36d9b1541cedecd59e9d8fff0bbf9b7e9dd9704e: Merge branch 'drm-nouveau-next' of git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-next (2013-04-26 15:42:02 +1000) are available in the git repository at: git://git.kernel.org/pub

RE: [PATCH] module: fix mutiple defined issue

2013-04-29 Thread Inki Dae
Hi, > -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Uwe Kleine-Konig > Sent: Monday, April 29, 2013 4:35 PM > To: Inki Dae > Cc: gre...@linuxfoundation.org; linux-ker...@vger.ker

RE: [PATCH] module: fix mutiple defined issue

2013-04-29 Thread Inki Dae
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Russell King - ARM Linux > Sent: Monday, April 29, 2013 6:52 PM > To: Inki Dae > Cc: gre...@linuxfoundation.org; linux-ker...@vger.ker

Re: DMA mapping API abuse in exynos-drm

2013-05-05 Thread Inki Dae
below attribute says like below, DMA_ATTR_NO_KERNEL_MAPPING -- ... Since it is optional for platforms to implement DMA_ATTR_NO_KERNEL_MAPPING, those that do not will simply ignore the attribute and exhibit default behavior. In case of ARM SoC, it seems like that it just ig

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format

2011-11-09 Thread InKi Dae
y mapped to the user space address. this way makes different applications to be possible to share the memory between v4l2 based driver and drm based driver. and also this feature is considered for IOMMU so it would support non continuous memory also. I will introduce this feature soon. Thank you,

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format

2011-11-10 Thread InKi Dae
2011/11/9 Rob Clark : > On Wed, Nov 9, 2011 at 7:25 AM, InKi Dae wrote: >> Hello, all. >> >> I am trying to implement multi planer using your plane patch and I >> think it's good but I am still warried about that drm_mode_fb_cmd2 >> structure has only one

[PATCH 00/14] update exynos drm driver.

2011-11-12 Thread Inki Dae
org/~airlied/linux.git branch name: drm-fixes commit-id: 8f3f1c9a22a6420e28c2d3eff59b832893bc8efc Inki Dae (7): drm/exynos: added manager object to connector drm/exynos: changed exynos_drm_display to exynos_drm_display_ops drm/exynos: use gem create function generically drm/exynos: remo

[PATCH 01/14] drm/exynos: added kms poll for handling hpd event

2011-11-12 Thread Inki Dae
From: Seung-Woo Kim this patch adds kms poll infrastructure to handle hotplug detection event Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_drv.c |5 + drivers/gpu/drm/exynos/exynos_drm_fb.c | 12

[PATCH 02/14] drm/exynos: fixed connector flag with hpd and interlace scan for hdmi

2011-11-12 Thread Inki Dae
From: Seung-Woo Kim hdmi display in exynos supports hotplug event and interlace scan mode Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_connector.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[PATCH 03/14] drm/exynos: fixed converting between display mode and timing

2011-11-12 Thread Inki Dae
From: Seung-Woo Kim missing members are added into converting function between timing and display mode and refresh rate of display mode is calculated by drm mode function. Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos

[PATCH 04/14] drm/exynos: added manager object to connector

2011-11-12 Thread Inki Dae
connector contains some contents for display controller so the connector also should be able to access controller through manager. Signed-off-by: Inki Dae Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 38

[PATCH 05/14] drm/exynos: changed exynos_drm_display to exynos_drm_display_ops

2011-11-12 Thread Inki Dae
exynos_drm_display has function pointes so exynos_drm_display_ops is better to describe. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 29 + drivers/gpu/drm/exynos/exynos_drm_drv.h |4 +- drivers/gpu

[PATCH 06/14] drm/exynos: restored kernel_fb_list when reiniting fb_helper

2011-11-12 Thread Inki Dae
From: Joonyoung Shim during recreating exynos_drm_fbdev as a new display device probes, fb_helper is reinitialized but kernel fb is not changed so kernel_fb_list should be restored after fb_helper is reinitialized. Signed-off-by: Joonyoung Shim Signed-off-by: Inki Dae Signed-off-by: Kyungmin

[PATCH 07/14] drm/exynos: removed meaningless parameter from fbdev update

2011-11-12 Thread Inki Dae
From: Seung-Woo Kim drm_framebuffer already has width and height so they are meaningless as parameters when updating fb_info. Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 14 +- 1 files

<    10   11   12   13   14   15   16   17   18   19   >