Re: [PATCH v3 2/2] drm/panel: Add panel for Samsung Galaxy S5

2021-07-26 Thread Iskren Chernev
On 7/26/21 10:34 AM, Linus Walleij wrote: > Hi Iskren, > > thanks for your patch! Thanks a lot for reviewing this. Alexey wrote a new version of the patch [1] that was recently reviewed by Sam, and it also includes support for brightness and another panel found on the S5. My patch is pretty mu

[PATCH v3 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel

2021-02-02 Thread Iskren Chernev
The Samsung S6E3FA2 AMOLED cmd LCD panel is used on the Samsung Galaxy S5 (klte). Signed-off-by: Iskren Chernev --- Add a simple generated panel driver that supports on/off and the corresponding binding documentation. Changes in v3: - fix dt_binding_check issue with missing include - fix panel

[PATCH v3 2/2] drm/panel: Add panel for Samsung Galaxy S5

2021-02-02 Thread Iskren Chernev
The Samsung Galaxy S5 uses the samsung s6e3fa2 AMOLED cmd LCD panel. This driver was generated with [1], with the addition of mipi_dsi_dcs_set_display_on at the end of the on method. [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator Signed-off-by: Iskren Chernev

[PATCH v2 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel

2021-02-02 Thread Iskren Chernev
The Samsung S6E3FA2 AMOLED cmd LCD panel is used on the Samsung Galaxy S5 (klte). Signed-off-by: Iskren Chernev --- OK, miraculously the panel turns on and off now, so the simple-panel can graduate into its own driver. v1: https://lkml.org/lkml/2020/12/30/293 Changes in v2: - move bindings to

[PATCH v2 2/2] drm/panel: Add panel for Samsung Galaxy S5

2021-02-02 Thread Iskren Chernev
The Samsung Galaxy S5 uses the samsung s6e3fa2 AMOLED cmd LCD panel. This driver was generated with [1], with the addition of mipi_dsi_dcs_set_display_on at the end of the on method. [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator Signed-off-by: Iskren Chernev

Re: [PATCH 2/2] drm/panel: simple: add samsung,s6e3fa2 panel

2021-01-28 Thread Iskren Chernev
On 12/30/20 5:17 PM, Iskren Chernev wrote: > From: Samuel Pascua > > This panel is used on the Samsung Galaxy S5 (klte). > > Signed-off-by: Samuel Pascua > --- > drivers/gpu/drm/panel/panel-simple.c | 30 > 1 file changed, 30 inserti

[PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels

2021-01-28 Thread Iskren Chernev
notifying a completion. The completion needs to be notified with complete_all so multiple waiting parties (new async committers) can proceed. Signed-off-by: Iskren Chernev Suggested-by: Rob Clark Fixes: 2d99ced787e3d ("drm/msm: async commit support") --- drivers/gpu/drm/msm/disp/mdp5/mdp5_

Re: [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-09 Thread Iskren Chernev
On 1/8/21 12:36 AM, Rob Clark wrote: > On Thu, Jan 7, 2021 at 9:20 AM Rob Clark wrote: >> >> On Sat, Jan 2, 2021 at 12:26 PM Iskren Chernev >> wrote: >>> >>> The msm_gem_get_iova should be guarded with gpu != NULL and not aspace >>> != NULL,

[PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-04 Thread Iskren Chernev
The msm_gem_get_iova should be guarded with gpu != NULL and not aspace != NULL, because aspace is NULL when using vram carveout. Fixes: 933415e24bd0d ("drm/msm: Add support for private address space instances") Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/msm_drv.c | 3 +

[PATCH 2/2] drm/msm: Add modparam to allow vram carveout

2020-12-31 Thread Iskren Chernev
Using the GPU with a VRAM Carveout is a security vulnerability. Nevertheless it is sometimes required, especially when no IOMMU implementation is available for a certain platform. Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 6 -- drivers/gpu/drm/msm/adreno

[PATCH 1/2] dt-bindings: panel-simple: add samsung,s6e3fa2 panel

2020-12-31 Thread Iskren Chernev
Add samsung,s6e3fa2 in the allowed simple-panel compat strings. Signed-off-by: Iskren Chernev --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b

[PATCH 1/2] drm/msm: Call msm_init_vram before binding the gpu

2020-12-31 Thread Iskren Chernev
From: Craig Tatlor vram.size is needed when binding a gpu without an iommu and is defined in msm_init_vram(), so run that before binding it. Signed-off-by: Craig Tatlor --- drivers/gpu/drm/msm/msm_drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 2/2] drm/panel: simple: add samsung,s6e3fa2 panel

2020-12-31 Thread Iskren Chernev
From: Samuel Pascua This panel is used on the Samsung Galaxy S5 (klte). Signed-off-by: Samuel Pascua --- drivers/gpu/drm/panel/panel-simple.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-si

[PATCH 2/2] drm/msm: Ensure get_pages is called when locked

2020-12-29 Thread Iskren Chernev
get_pages is only called in a locked context. Add a WARN_ON to make sure it stays that way. Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/msm_gem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index

[PATCH 1/2] drm/msm: Fix null dereference in _msm_gem_new

2020-12-29 Thread Iskren Chernev
03f e593300c e1a04000 f590f000 (e1940f9f) ---[ end trace 277e2a3da40bbb76 ]--- Fixes: 6c0e3ea250476 ("drm/msm/gem: Switch over to obj->resv for locking") Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/msm_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH] drm/msm: Fix WARN_ON() splat in _free_object()

2020-12-11 Thread Iskren Chernev
ree_object(struct drm_gem_object *obj) >      } else { >          msm_gem_vunmap(obj); >          put_pages(obj); > +        put_iova_vmas(obj); >          msm_gem_unlock(obj); >      } > > -    put_iova_vmas(obj); > - >      drm_gem_object_release(obj); > >      kfree(msm_obj

[PATCH] drm/msm: Fix use-after-free in msm_gem with carveout

2020-11-27 Thread Iskren Chernev
ist, so delaying the deletion should be harmless. This patch splits put_iova in put_iova_spaces and put_iova_vmas, so the vma can be freed after the mm_node has been deallocated with the mm. Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/msm_gem.c | 27 ++- 1 file ch

[PATCH v2] drm/msm: Fix use-after-free in msm_gem with carveout

2020-11-27 Thread Iskren Chernev
em_object allocation, and freeing order was therefore overlooked. Fixes: 4b85f7f5cf7 ("drm/msm: support for an arbitrary number of address spaces") Signed-off-by: Iskren Chernev --- v1: https://lkml.org/lkml/2020/11/26/130 Changes in v2: - patch now compiles (oops) - improve commit mes