Hi,
On 21.05.2024 17:10, Jeffrey Hugo wrote:
> On 5/21/2024 8:41 AM, Tomeu Vizoso wrote:
>> On Tue, May 21, 2024 at 2:12 PM Daniel Vetter wrote:
>>>
>>> On Sat, May 18, 2024 at 10:46:01AM +0200, Tomeu Vizoso wrote:
Hi,
I would like to use the chance at the next Plumbers to discuss
Hi,
On 21.05.2024 14:58, Daniel Vetter wrote:
> On Tue, 21 May 2024 at 14:38, Daniel Vetter wrote:
>>
>> On Mon, May 20, 2024 at 12:05:14PM +0200, Jacek Lawrynowicz wrote:
>>> From: "Wachowski, Karol"
>>>
>>> Lack of check for copy-on-write
rary for shmem backed GEM objects")
Cc: Noralf Trønnes
Cc: Eric Anholt
Cc: Rob Herring
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
Cc: # v5.2+
Signed-off-by: Wachowski, Karol
Signed-off-by: J
Applied to drm-misc-next
On 15.05.2024 13:30, Jacek Lawrynowicz wrote:
> The NPU device consists of two parts: NPU buttress and NPU IP.
> Buttress is a platform specific part that integrates the NPU IP with
> the CPU.
> NPU IP is the platform agnostic part that does t
Use kfifo to pass IRQ sources to IRQ thread so it will be possible to
use IRQ thread by multiple IRQ types.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Wachowski, Karol
---
drivers/accel/ivpu/ivpu_drv.c | 19 +--
drivers/accel/ivpu/ivpu_hw.c| 9 ++---
drivers/accel
From: "Wachowski, Karol"
Move buttress registers to ivpu_hw_btrs_*_reg.h headers.
This is an intermediate step before HW layer refactor.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 153
drivers/
IP 37XX could be integrated into
MTL and LNL platforms.
Jacek Lawrynowicz (1):
accel/ivpu: Replace wake_thread with kfifo
Wachowski, Karol (2):
accel/ivpu: Split IP and buttress headers
accel/ivpu: Split IP and buttress code
drivers/accel/ivpu/Makefile |5 +-
drivers
Applied to drm-misc-next
On 13.05.2024 14:04, Jacek Lawrynowicz wrote:
> There are couple of major new features in this patchset:
> * Hardware scheduler support (disabled by default)
> * Profiling support
> * Expose NPU busy time in sysfs
>
> Other then that, there ar
Failed warm boot causes a cold boot that looses FW state and is
equivalent to a recovery or reset, so reset_counter should be
incremented in order for this failure to be detected by tests.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
---
drivers/accel/ivpu/ivpu_pm.c | 1 +
1 file
when there is no more jobs pending/executing.
Signed-off-by: Tomasz Rusinowicz
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/Makefile | 3 +-
drivers/accel/ivpu/ivpu_drv.c | 2 ++
drivers/accel/ivpu/ivpu_drv.h | 3 ++
drivers/accel/ivpu/ivpu_job.c | 23
From: Tomasz Rusinowicz
Add fw_dyndbg file that can be used to control FW logging.
Signed-off-by: Tomasz Rusinowicz
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_debugfs.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/accel/ivpu
DRM_IVPU_CAP_METRIC_STREAMER driver capability.
Signed-off-by: Tomasz Rusinowicz
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/Makefile | 3 +-
drivers/accel/ivpu/ivpu_drv.c | 14 +-
drivers/accel/ivpu/ivpu_drv.h | 3 +
drivers/accel/ivpu/ivpu_jsm_msg.c | 98 ++
drivers/accel
From: "Wachowski, Karol"
Add module parameter that enforces snooping for all NPU accesses,
both through MMU PTEs mappings and through TCU page table walk
override register bits for MMU page walks / configuration access.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
From: "Wachowski, Karol"
Create multiple command queues per engine with different priorities.
The cmdqs are created on-demand and they support 4 priority levels.
These priorities will later be used by the HWS (hardware scheduler).
Signed-off-by: Wachowski, Karol
Signed-off
From: "Wachowski, Karol"
Create debugfs interface that triggers sending resume engine IPC
command to VPU. It is used to test engine resume functionality in
driver user space tests.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_debu
ver in HWS mode has to send a couple additional messages to
initialize HWS and describe command queue priorities.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.c | 20 -
drivers/accel/ivpu/ivpu_fw.c | 7 ++
drivers/accel/ivpu/ivpu_j
From: "Wachowski, Karol"
Allocate per-context preemption buffers that are required by HWS.
There are two preemption buffers:
* primary - allocated in user memory range (PIOVA accessible)
* secondary - allocated in shave memory range
Signed-off-by: Wachowski, Karol
Signed-off
From: "Wachowski, Karol"
Add JSM messages that will be used to implement hardware scheduler.
Most of these messages are used to create and manage HWS specific
command queues.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
---
drivers/
From: "Wachowski, Karol"
This param will be used to enable/disable HWS (hardware scheduler).
The HWS is a FW side feature and may not be available on all
HW generations and FW versions.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv
Update JSM API to 3.16.0.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
---
drivers/accel/ivpu/vpu_jsm_api.h | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/accel/ivpu/vpu_jsm_api.h b/drivers/accel/ivpu/vpu_jsm_api.h
index e46f3531211a
/20240508132106.2387464-1-jacek.lawrynow...@linux.intel.com
Jacek Lawrynowicz (2):
accel/ivpu: Update VPU FW API headers
accel/ivpu: Increase reset counter when warm boot fails
Tomasz Rusinowicz (3):
accel/ivpu: Add NPU profiling support
accel/ivpu: Configure fw logging using debugfs
accel
Hi,
On 13.05.2024 12:45, Tvrtko Ursulin wrote:
>
> On 13/05/2024 11:22, Jacek Lawrynowicz wrote:
>> Hi,
>>
>> On 10.05.2024 18:55, Jeffrey Hugo wrote:
>>> On 5/8/2024 7:29 AM, Jacek Lawrynowicz wrote:
>>>> From: Tomasz Rusinowicz
>>>>
&g
Hi,
On 10.05.2024 18:55, Jeffrey Hugo wrote:
> On 5/8/2024 7:29 AM, Jacek Lawrynowicz wrote:
>> From: Tomasz Rusinowicz
>>
>> The driver tracks the time spent by NPU executing jobs
>> and shares it through sysfs `npu_busy_time_us` file.
>> It can be the
Hi,
On 10.05.2024 18:46, Jeffrey Hugo wrote:
> On 5/8/2024 7:21 AM, Jacek Lawrynowicz wrote:
>> From: Tomasz Rusinowicz
>>
>> Implement time based Metric Streamer profiling UAPI.
>>
>> This is a generic mechanism allowing user mode tools to sample
>>
Hi,
On 10.05.2024 18:42, Jeffrey Hugo wrote:
> On 5/8/2024 7:21 AM, Jacek Lawrynowicz wrote:
>> From: "Wachowski, Karol"
>>
>> Create debugfs interface that triggers sending resume engine IPC
>> command to VPU.
>
> Why? Who would use this and for w
Hi,
On 10.05.2024 18:41, Jeffrey Hugo wrote:
> On 5/8/2024 7:21 AM, Jacek Lawrynowicz wrote:
>> +#define IVPU_FOCUS_PRESENT_TIMER_MS 1000
>> +
>> static char *ivpu_firmware;
>> module_param_named_unsafe(firmware, ivpu_firmware, charp, 0644);
>> MODULE_
Hi,
On 10.05.2024 18:30, Jeffrey Hugo wrote:
> On 5/8/2024 7:20 AM, Jacek Lawrynowicz wrote:
>> From: "Wachowski, Karol"
>>
>> This param will be used to enable/disable HWS (hardware scheduler).
>> The HWS is a FW side feature and may not be available on
Hi,
Please ignore this patch. It got here by mistake.
There is another one sent as a part of a patchset.
On 08.05.2024 15:25, Jacek Lawrynowicz wrote:
> From: Tomasz Rusinowicz
>
> Add fw_dyndbg file that can be used to control FW logging.
>
> Signed-off-by: Tomasz Rusinowic
when there is no more jobs pending/executing.
Signed-off-by: Tomasz Rusinowicz
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/Makefile | 3 +-
drivers/accel/ivpu/ivpu_drv.c | 2 ++
drivers/accel/ivpu/ivpu_drv.h | 3 ++
drivers/accel/ivpu/ivpu_job.c | 23
Failed warm boot causes a cold boot that looses FW state and is
equivalent to a recovery or reset, so reset_counter should be
incremented in order for this failure to be detected by tests.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_pm.c | 1 +
1 file changed, 1 insertion
From: Tomasz Rusinowicz
Add fw_dyndbg file that can be used to control FW logging.
Signed-off-by: Tomasz Rusinowicz
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_debugfs.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/accel/ivpu
From: Tomasz Rusinowicz
Add fw_dyndbg file that can be used to control FW logging.
Signed-off-by: Tomasz Rusinowicz
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_debugfs.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/accel/ivpu
From: "Wachowski, Karol"
Create multiple command queues per engine with different priorities.
The cmdqs are created on-demand and they support 4 priority levels.
These priorities will later be used by the HWS (hardware scheduler).
Signed-off-by: Wachowski, Karol
Signed-off
From: "Wachowski, Karol"
Add module parameter that enforces snooping for all NPU accesses,
both through MMU PTEs mappings and through TCU page table walk
override register bits for MMU page walks / configuration access.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek L
ver in HWS mode has to send a couple additional messages to
initialize HWS and describe command queue priorities.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.c | 20 -
drivers/accel/ivpu/ivpu_fw.c | 9 ++
drivers/accel/ivpu/ivpu_j
From: "Wachowski, Karol"
Add JSM messages that will be used to implement hardware scheduler.
Most of these messages are used to create and manage HWS specific
command queues.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.h
From: "Wachowski, Karol"
This param will be used to enable/disable HWS (hardware scheduler).
The HWS is a FW side feature and may not be available on all
HW generations and FW versions.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv
From: "Wachowski, Karol"
Allocate per-context preemption buffers that are required by HWS.
There are two preemption buffers:
* primary - allocated in user memory range (PIOVA accessible)
* secondary - allocated in shave memory range
Signed-off-by: Wachowski, Karol
Signed-off
DRM_IVPU_CAP_METRIC_STREAMER driver capability.
Signed-off-by: Tomasz Rusinowicz
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/Makefile | 3 +-
drivers/accel/ivpu/ivpu_drv.c | 14 +-
drivers/accel/ivpu/ivpu_drv.h | 3 +
drivers/accel/ivpu/ivpu_jsm_msg.c | 98 ++
drivers/accel
From: "Wachowski, Karol"
Create debugfs interface that triggers sending resume engine IPC
command to VPU.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_debugfs.c | 24
1 file changed, 24 insertions(+)
There are couple of major new features in this patchset:
* Hardware scheduler support (disabled by default)
* Profiling support
* Expose NPU busy time in sysfs
Other then that, there are two small random fixes.
Jacek Lawrynowicz (2):
accel/ivpu: Update VPU FW API headers
accel/ivpu
Update JSM API to 3.16.0.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/vpu_jsm_api.h | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/accel/ivpu/vpu_jsm_api.h b/drivers/accel/ivpu/vpu_jsm_api.h
index e46f3531211a..33f462b1a25d 100644
Applied to drm-misc-fixes
On 02.04.2024 12:49, Jacek Lawrynowicz wrote:
> A couple of small stability fixes, one UAPI fix and some error message fixes.
>
> Jacek Lawrynowicz (5):
> accel/ivpu: Remove d3hot_after_power_off WA
> accel/ivpu: Put NPU back to D3hot after failed r
On 05.04.2024 17:26, Jeffrey Hugo wrote:
> On 4/2/2024 4:49 AM, Jacek Lawrynowicz wrote:
>> DRM_IVPU_PARAM_CORE_CLOCK_RATE returned current NPU frequency which
>
> Commit text should be present tense, so returned->returns
OK
>> could be 0 if device was sleeping.
Reviewed-by: Jacek Lawrynowicz
On 22.03.2024 04:49, Jeffrey Hugo wrote:
> The AIC100 secondary bootloader uses the Sahara protocol for two
> purposes - loading the runtime firmware images from the host, and
> offloading crashdumps to the host. The crashdump functionality is only
>
ock was reported by lockdep and observed in internal tests.
Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU")
Cc: # v6.3+
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
Change "VPU" to "NPU" in ivpu_suspend() so it matches all other error
messages.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.
evice is up")
Cc: # v6.7
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.c | 18 +-
drivers/accel/ivpu/ivpu_hw.h | 6 ++
drivers/accel/ivpu/ivpu_hw_37xx.c | 7 ---
drivers/accel/ivpu/ivpu_hw_40xx.c | 6 ++
4 files changed, 17 inserti
From: "Wachowski, Karol"
This patch improves readability and clarity of MMU error messages.
Previously, the error strings were somewhat confusing and could lead to
ambiguous interpretations, making it difficult to diagnose issues.
Signed-off-by: Wachowski, Karol
Signed-off
ery")
Cc: # v6.8+
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_pm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c
index 325b82f8d971..ba51781b5896 100644
--- a/drivers/accel/ivpu/ivpu_pm.c
+++ b/drivers/accel/i
recovery")
Cc: # v6.8+
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c
index 9cbd7af6576b..325b82f8d971
Always enter D3hot after entering D0i3 an all platforms.
This minimizes power usage.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.c | 20 ++--
drivers/accel/ivpu/ivpu_drv.h | 3 +--
drivers/accel/ivpu/ivpu_hw_37xx.c | 4 +---
drivers/accel/ivpu
From: "Wachowski, Karol"
Return value of drmm_mutex_init(ipc->lock) was unchecked.
Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
Cc: # v6.3+
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_ipc.c | 8 +
A couple of small stability fixes, one UAPI fix and some error message fixes.
Jacek Lawrynowicz (5):
accel/ivpu: Remove d3hot_after_power_off WA
accel/ivpu: Put NPU back to D3hot after failed resume
accel/ivpu: Return max freq for DRM_IVPU_PARAM_CORE_CLOCK_RATE
accel/ivpu: Fix missed
On 15.03.2024 16:39, Jeffrey Hugo wrote:
> On 3/14/2024 5:41 AM, Jacek Lawrynowicz wrote:
>> Hi,
>>
>> On 11.03.2024 17:58, Jeffrey Hugo wrote:
>>> During the boot process of AIC100, the bootloaders (PBL and SBL) log
>>> messages to device RAM. During
Reviewed-by: Jacek Lawrynowicz
On 11.03.2024 17:58, Jeffrey Hugo wrote:
> When debugging functional issues with workload input processing, it is
> useful to know if requests are backing up in the fifo, or perhaps
> getting stuck elsewhere. To answer the question of how many
Reviewed-by: Jacek Lawrynowicz
On 11.03.2024 17:58, Jeffrey Hugo wrote:
> Each DMA Bridge Channel (dbc) has a unique configured fifo size which is
> specified by the userspace client of that dbc. Since the fifo is
> circular, it is useful to know the configured size when debugging
Hi,
On 11.03.2024 17:58, Jeffrey Hugo wrote:
> During the boot process of AIC100, the bootloaders (PBL and SBL) log
> messages to device RAM. During SBL, if the host opens the QAIC_LOGGING
> channel, SBL will offload the contents of the log buffer to the host,
> and stream any new messages that
Applied to drm-misc-fixes
On 20.02.2024 14:16, Jacek Lawrynowicz wrote:
> From: Andrzej Kacprowski
>
> There is no point in requesting 1 tile on VPU40xx as the FW will
> probably need more tiles to run workloads, so it will have to
> reconfigure PLL anyway. Don't enable any
as the tiles are always enabled only
by the FW from the same initial state.
Fixes: 79cdc56c4a54 ("accel/ivpu: Add initial support for VPU 4")
Cc: sta...@vger.kernel.org
Signed-off-by: Andrzej Kacprowski
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_40xx.c | 2 +-
1 file
as the tiles are always enabled only
by the FW from the same initial state.
Fixes: 79cdc56c4a54 ("accel/ivpu: Add initial support for VPU 4")
Signed-off-by: Andrzej Kacprowski
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_40xx.c | 2 +-
1 file changed, 1 insertion(+),
Added missing SOB and applied to drm-misc-next
On 14.02.2024 09:12, Jacek Lawrynowicz wrote:
> Mostly code refactoring and cleanup.
>
> Please note that FW API headers are maintained by a separate team
> and I would prefer not to modify them.
>
> Jacek Lawrynowicz (5):
>
VPU was renamed to NPU but due to large overhead of renaming
all the sources only user visible messages are being updated.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.c | 8
drivers/accel/ivpu/ivpu_drv.h | 2 +-
drivers/accel/ivpu/ivpu_fw.c | 2
From: "Wachowski, Karol"
Rename BO allocate/create functions, so the code is more consistent.
There are now two matching buffer creation functions:
- ivpu_bo_create_ioctl() - create a BO from user space
- ivpu_bo_create() - create a BO from kernel space
ivpu_bo_alloc() is now only used to
From: Krystian Pradzynski
Add support for FW boot API param system_time_us.
According to the API description this field should
be set to system time in microseconds starting from 1970.
Signed-off-by: Krystian Pradzynski
---
drivers/accel/ivpu/ivpu_fw.c | 6 ++
1 file changed, 6
Remove legacy postfix from TILE_SKU_BOTH macro.
This was missed when renaming MTL to VPU37XX.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_hw_37xx.c
b/drivers/accel/ivpu
ivpu_reset_engine_fn and ivpu_reset_engine_fops were separated during
merge so move them back together to keep the file consistent.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_debugfs.c | 32 +++
1 file changed, 16 insertions(+), 16 deletions
Update Boot API to 3.22.0 and JSM API to 3.15.6
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/vpu_boot_api.h | 46 ++-
drivers/accel/ivpu/vpu_jsm_api.h | 32 ++---
2 files changed, 55 insertions(+), 23 deletions(-)
diff --git a/drivers
From: "Wachowski, Karol"
Reserve/allocate and free doorbells for command queues when needed
using xarray. This allows to avoid reserving a doorbell for
a contexts that never issues a job.
Signed-off-by: Wachowski, Karol
---
drivers/accel/ivpu/ivpu_drv.c | 4
We are now using NPU IP generation based FW names instead of platform
code names, so mtl_vpu.bin can be removed.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ivpu_fw.c
Mostly code refactoring and cleanup.
Please note that FW API headers are maintained by a separate team
and I would prefer not to modify them.
Jacek Lawrynowicz (5):
accel/ivpu: Rename TILE_SKU_BOTH_MTL to TILE_SKU_BOTH
accel/ivpu: Remove legacy firmware name
accel/ivpu: Update FW API
Applied to drm-misc-fixes
On 06.02.2024 16:19, Jacek Lawrynowicz wrote:
> Issue IP reset before shutdown in order to
> complete all upstream requests to the SOC.
> Without this DevTLB is complaining about
> incomplete transactions and NPU cannot resume from
> suspend.
> Th
Hi,
On 09.02.2024 16:39, Jeffrey Hugo wrote:
> On 2/7/2024 3:24 AM, Jacek Lawrynowicz wrote:
>> Issue IP reset before shutdown in order to
>> complete all upstream requests to the SOC.
>> Without this DevTLB is complaining about
>> incomplete transactions and NPU ca
reset and FLR cannot.
Fixes: 3f7c0634926d ("accel/ivpu/37xx: Fix hangs related to MMIO reset")
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 44 ++-
drivers/accel/ivpu/ivpu_pm.c | 39 +++
2 files change
MMIO reset")
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 44 ++-
drivers/accel/ivpu/ivpu_pm.c | 12 -
2 files changed, 38 insertions(+), 18 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_hw_37xx.c
b/drivers/accel/ivp
Applied to drm-misc-fixes (except patch 4)
On 26.01.2024 13:27, Jacek Lawrynowicz wrote:
> A couple of small patches focused on improving driver stability.
> In addition d3hot_delay patch improves LNL inference latency.
>
> Grzegorz Trzebiatowski (1):
> accel/ivpu: Add job
On 05.02.2024 09:39, Jacek Lawrynowicz wrote:
> On 26.01.2024 19:23, Jeffrey Hugo wrote:
>> On 1/26/2024 5:28 AM, Jacek Lawrynowicz wrote:
>>> From: "Wachowski, Karol"
>>>
>>> Replace forceful disable of power domains with requests to disable
>>
On 26.01.2024 19:23, Jeffrey Hugo wrote:
> On 1/26/2024 5:28 AM, Jacek Lawrynowicz wrote:
>> From: "Wachowski, Karol"
>>
>> Replace forceful disable of power domains with requests to disable
>> TOP NOC CPU_CTRL and HOSTIF_L2CACHE through QREQN.
>>
On 26.01.2024 19:24, Jeffrey Hugo wrote:
> On 1/26/2024 5:28 AM, Jacek Lawrynowicz wrote:
>> From: Krystian Pradzynski
>>
>> All recent 40xx firmware already supports D0i3 entry message and this
>> WA is no longer needed.
>
> Can I assume that the workarou
-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_job.c | 4 ++--
include/uapi/drm/ivpu_accel.h | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_job.c b/drivers/accel/ivpu/ivpu_job.c
index 0440bee3ecaf..e70cfb859339 100644
--- a/drivers/accel/ivpu
From: Krystian Pradzynski
This parameter was never used by the 40xx FW.
Signed-off-by: Krystian Pradzynski
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_40xx.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_hw_40xx.c
b/drivers/accel/ivpu
From: Krystian Pradzynski
All recent 40xx firmware already supports D0i3 entry message and this
WA is no longer needed.
Signed-off-by: Krystian Pradzynski
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_fw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/accel/ivpu
e was full.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_mmu.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_mmu.c b/drivers/accel/ivpu/ivpu_mmu.c
index 8d
NPU does not require this delay regardless of the generation.
All generations are integrated into the SOC.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel
E released in January 2024 onwards.
Fixes: 3f7c0634926d ("accel/ivpu/37xx: Fix hangs related to MMIO reset")
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 122 +++---
1 file changed, 60 insertions(+), 6
A couple of small patches focused on improving driver stability.
In addition d3hot_delay patch improves LNL inference latency.
Grzegorz Trzebiatowski (1):
accel/ivpu: Add job status for jobs aborted by the driver
Jacek Lawrynowicz (1):
accel/ivpu: Disable d3hot_delay on all NPU generations
orce write
transactions to be snooped solving the problem.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 2 +-
drivers/accel/ivpu/ivpu_hw_40xx.c | 2 +-
drivers/accel/ivpu/ivpu_mmu.c | 3 ---
3 files changed, 2 insertions(+), 5 deletions(-)
Applied to drm-misc-fixes
On 22.01.2024 13:09, Jacek Lawrynowicz wrote:
> Stability fixes for reset, recovery and unbind.
>
> Jacek Lawrynowicz (3):
> accel/ivpu: Fix dev open/close races with unbind
> accel/ivpu: Improve stability of ivpu_submit_ioctl()
> accel/ivpu
Applied to drm-misc-fixes
On 24.10.2023 18:53, Stanislaw Gruszka wrote:
> From: Jacek Lawrynowicz
>
> IP reset has to followed by ivpu_pll_disable() to properly enter
> reset state.
>
> Fixes: 828d63042aec ("accel/ivpu: Don't enter d0i3 during FLR")
> Cc: sta.
- Wake up the device as late as possible
- Remove job reference counting in order to simplify the code
- Don't put jobs that are not fully submitted on submitted_jobs_xa in
order to avoid potential races with reset/recovery
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_job.c
- Reset VPU instead triggering recovery after changing debugfs params
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_debugfs.c | 20 ++---
drivers/accel/ivpu/ivpu_hw_37xx.c | 14 +++--
drivers/accel/ivpu/ivpu_hw_40xx.c | 8 +++---
drivers/accel/ivpu/ivpu_ipc.c
Stability fixes for reset, recovery and unbind.
Jacek Lawrynowicz (3):
accel/ivpu: Fix dev open/close races with unbind
accel/ivpu: Improve stability of ivpu_submit_ioctl()
accel/ivpu: Improve recovery and reset support
drivers/accel/ivpu/ivpu_debugfs.c | 20 +++-
drivers/accel/ivpu
- Add context_list_lock to synchronize user context addition/removal
- Use drm_dev_enter() to prevent unbinding the device during ivpu_open()
and vpu address allocation
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_drv.c | 110 +-
drivers
Applied to drm-misc-fixes
On 15.01.2024 14:44, Jacek Lawrynowicz wrote:
> Various driver fixes:
> - Fixes for infinite loops, missing locks and DMA-API debug warnings
> - Deprecate DRM_IVPU_PARAM_CONTEXT_PRIORITY
> - Improve diagnostic messages
>
> v2 includes changes from
Make debug logs more readable and consistent:
- don't print handle as it is not always available for all buffers
- use hashed ivpu_bo ptr as main buffer identifier
- remove unused fields from ivpu_bo_print_info()
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_gem.c | 63
From: "Wachowski, Karol"
DRM_IVPU_PARAM_CONTEXT_PRIORITY has been deprecated because it
has been replaced with DRM_IVPU_JOB_PRIORITY levels set with
submit IOCTL and was unused anyway.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_
and it will be implemented in future if required.
Signed-off-by: Jacek Lawrynowicz
---
drivers/accel/ivpu/ivpu_gem.c | 44 +--
1 file changed, 6 insertions(+), 38 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
index 4de454bfbf91..95e731e13941
Call dma_unmap() on all buffers before the VPU is unbinded to avoid
"device driver has pending DMA allocations while released from device"
warning when DMA-API debug is enabled.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
---
drivers/accel/ivpu/ivpu_gem.c | 14 +++
drm_gem_shmem_vmap/vunmap requires dma resv lock to be held.
This was missed during conversion to shmem helper.
Fixes: 8d88e4cdce4f ("accel/ivpu: Use GEM shmem helper for all buffers")
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
---
drivers/accel/ivpu/ivpu_gem.c |
From: "Wachowski, Karol"
Make boot/suspend failure debugging easier by dumping FW logs and error
registers.
Signed-off-by: Wachowski, Karol
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
---
drivers/accel/ivpu/ivpu_drv.c | 5 +++--
drivers/accel/ivpu/ivpu_pm.c | 4 +++
1 - 100 of 293 matches
Mail list logo
