Re: flush_icache_range in the sticore driver

2022-07-05 Thread James Bottomley
On Tue, 2022-07-05 at 18:46 +0200, Christoph Hellwig wrote: > Hi all, > > flush_icache_range is supposed to flush the instruction cache, which > is something no driver should be doing. It was added in commit > 03b18f1b2afe ("[PARISC] Clean up sti_flush") but the explanation in > there looks odd.

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread James Bottomley
On Mon, 2022-02-28 at 23:59 +0200, Mike Rapoport wrote: > > On February 28, 2022 10:42:53 PM GMT+02:00, James Bottomley < > james.bottom...@hansenpartnership.com> wrote: > > On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: [...] > > > > I do wish we coul

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread James Bottomley
On Mon, 2022-02-28 at 21:56 +0100, Christian König wrote: > > Am 28.02.22 um 21:42 schrieb James Bottomley: > > On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: > > > Am 28.02.22 um 20:56 schrieb Linus Torvalds: > > > > On Mon, Feb 28, 2022 at 4:19

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread James Bottomley
On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: > Am 28.02.22 um 20:56 schrieb Linus Torvalds: > > On Mon, Feb 28, 2022 at 4:19 AM Christian König > > wrote: > > > I don't think that using the extra variable makes the code in any > > > way > > > more reliable or easier to read. > > So I

Re: [PATCH v3 3/4] tpm_tis: Disable interrupts if interrupt storm detected

2020-12-07 Thread James Bottomley
On Mon, 2020-12-07 at 15:28 -0400, Jason Gunthorpe wrote: > On Sun, Dec 06, 2020 at 08:26:16PM +0100, Thomas Gleixner wrote: > > Just as a side note. I was looking at tpm_tis_probe_irq_single() > > and that function is leaking the interrupt request if any of the > > checks afterwards fails, except

Re: [PATCH v3 1/4] irq: export kstat_irqs

2020-12-06 Thread James Bottomley
On Sun, 2020-12-06 at 17:40 +0100, Thomas Gleixner wrote: > On Sat, Dec 05 2020 at 12:39, Jarkko Sakkinen wrote: > > On Fri, Dec 04, 2020 at 06:43:37PM -0700, Jerry Snitselaar wrote: > > > To try and detect potential interrupt storms that > > > have been occurring with tpm_tis devices it was

Re: [RFC PATCH v1 00/12] Replace strstarts() by str_has_prefix()

2020-12-04 Thread James Bottomley
On Fri, 2020-12-04 at 18:03 +0100, laniel_fran...@privacyrequired.com wrote: > In this patch set, I replaced all calls to strstarts() by calls to > str_has_prefix(). Indeed, the kernel has two functions to test if a > string begins with an other: > 1. strstarts() which returns a bool, so 1 if the

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread James Bottomley
On Tue, 2020-11-24 at 13:32 -0800, Kees Cook wrote: > On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote: > > Really, no ... something which produces no improvement has no value > > at all ... we really shouldn't be wasting maintainer time with it > > because i

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread James Bottomley
On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote: > On Mon, Nov 23, 2020 at 4:58 PM James Bottomley > wrote: > > Well, I used git. It says that as of today in Linus' tree we have > > 889 patches related to fall throughs and the first series went in > > in october 20

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread James Bottomley
On Mon, 2020-11-23 at 07:03 -0600, Gustavo A. R. Silva wrote: > On Sun, Nov 22, 2020 at 11:53:55AM -0800, James Bottomley wrote: > > On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote: > > > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote: > > > > On Sun,

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread James Bottomley
On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > wrote: > > Well, it seems to be three years of someone's time plus the > > maintainer review time and series disruption of nearly a thousand > > patches. Let's be

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-22 Thread James Bottomley
On Mon, 2020-11-23 at 09:54 +1100, Finn Thain wrote: > But is anyone keeping score of the regressions? If unreported bugs > count, what about unreported regressions? Well, I was curious about the former (obviously no tool will tell me about the latter), so I asked git what patches had a

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-22 Thread James Bottomley
On Sun, 2020-11-22 at 21:35 +0100, Miguel Ojeda wrote: > On Sun, Nov 22, 2020 at 7:22 PM James Bottomley > wrote: > > Well, it's a problem in an error leg, sure, but it's not a really > > compelling reason for a 141 patch series, is it? All that fixing > > this error w

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-22 Thread James Bottomley
On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote: > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote: > > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote: > > > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > > > > Please tell me our re

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-22 Thread James Bottomley
On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote: > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > > Please tell me our reward for all this effort isn't a single > > missing error print. > > There were quite literally dozens of logical defects found > by t

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-22 Thread James Bottomley
On Sun, 2020-11-22 at 08:17 -0800, Kees Cook wrote: > On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote: > > > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote: > > > > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A.

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-22 Thread James Bottomley
On Sun, 2020-11-22 at 08:10 -0800, Tom Rix wrote: > On 11/22/20 6:56 AM, Matthew Wilcox wrote: > > On Sun, Nov 22, 2020 at 06:46:46AM -0800, Tom Rix wrote: > > > On 11/21/20 7:23 PM, Matthew Wilcox wrote: > > > > On Sat, Nov 21, 2020 at 08:50:58AM -0800, t...@redhat.com > > > > wrote: > > > > >

Re: [RFC] MAINTAINERS tag for cleanup robot

2020-11-21 Thread James Bottomley
On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote: > A difficult part of automating commits is composing the subsystem > preamble in the commit log. For the ongoing effort of a fixer > producing > one or two fixes a release the use of 'treewide:' does not seem > appropriate. > > It would

Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

2020-10-18 Thread James Bottomley
On Sun, 2020-10-18 at 20:16 +0100, Matthew Wilcox wrote: > On Sun, Oct 18, 2020 at 12:13:35PM -0700, James Bottomley wrote: > > On Sun, 2020-10-18 at 19:59 +0100, Matthew Wilcox wrote: > > > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > > > cla

Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

2020-10-18 Thread James Bottomley
On Sun, 2020-10-18 at 19:59 +0100, Matthew Wilcox wrote: > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > clang has a number of useful, new warnings see > >

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-09 Thread James Bottomley
On Fri, 2020-10-09 at 14:34 -0700, Eric Biggers wrote: > On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The kmap() calls in this FS are localized to a single thread. To > > avoid the over head of global PKRS updates use the new > > kmap_thread()

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread James Bottomley
On Wed, 2020-08-19 at 21:54 +0530, Allen wrote: > > [...] > > > > Since both threads seem to have petered out, let me suggest in > > > > kernel.h: > > > > > > > > #define cast_out(ptr, container, member) \ > > > > container_of(ptr, typeof(*container), member) > > > > > > > > It does what you

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread James Bottomley
On Wed, 2020-08-19 at 07:00 -0600, Jens Axboe wrote: > On 8/18/20 1:00 PM, James Bottomley wrote: [...] > > Since both threads seem to have petered out, let me suggest in > > kernel.h: > > > > #define cast_out(ptr, container, member) \ > > container_o

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread James Bottomley
On Tue, 2020-08-18 at 13:10 -0700, Kees Cook wrote: > On Tue, Aug 18, 2020 at 01:00:33PM -0700, James Bottomley wrote: > > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > > > On 8/17/20 12:48 PM, Kees Cook wrote: > > > > On Mon, Aug 17, 2020 at 12:4

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread James Bottomley
On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > On 8/17/20 12:48 PM, Kees Cook wrote: > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > > > On 8/17/20 12:29 PM, Kees Cook wrote: > > > > On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote: > > > > > On 8/17/20 2:15 AM,

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread James Bottomley
On Fri, 2018-11-30 at 14:26 -0800, Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 03:14:59PM -0700, Jonathan Corbet wrote: [...] > > Have you read Documentation/process/code-of-conduct- > > interpretation.rst? > > As has been pointed out, it contains a clear answer to how things > > should be

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread James Bottomley
On Fri, 2018-11-30 at 14:12 -0800, Jarkko Sakkinen wrote: [...] > I pasted this already to another response and this was probably the > part that ignited me to send the patch set (was a few days ago, so > had to revisit to find the exact paragraph): I replied in to the other thread. >

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread James Bottomley
On Fri, 2018-11-30 at 13:54 -0800, Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 01:48:08PM -0800, David Miller wrote: > > From: Jarkko Sakkinen > > Date: Fri, 30 Nov 2018 13:44:05 -0800 > > > > > On Fri, Nov 30, 2018 at 01:01:02PM -0800, James Bottomley wrote:

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread James Bottomley
On Fri, 2018-11-30 at 13:44 -0800, Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 01:01:02PM -0800, James Bottomley wrote: > > No because use of what some people consider to be bad language > > isn't necessarily abusive, offensive or degrading. Our most > > heavily

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread James Bottomley
On Fri, 2018-11-30 at 12:55 -0800, Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 11:56:52AM -0800, Davidlohr Bueso wrote: > > On Fri, 30 Nov 2018, Kees Cook wrote: > > > > > On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen > > > wrote: > > > > > > > > In order to comply with the CoC, replace

[Intel-gfx] Skylake graphics regression: projector failure with 4.8-rc3

2016-09-19 Thread James Bottomley
On Mon, 2016-09-19 at 08:09 -0700, James Bottomley wrote: > On Sun, 2016-09-18 at 13:35 +0200, Thorsten Leemhuis wrote: > > Hi! James & Paulo: What's the current status of this? > > No, the only interaction has been the suggestion below for a revert, > which

[Intel-gfx] Skylake graphics regression: projector failure with 4.8-rc3

2016-09-19 Thread James Bottomley
> asking, because this issue is on the list of regressions for 4.8. I'm just about to try out -rc7, but it's not fixed so far. James > Ciao, Thorsten > > On 01.09.2016 00:25, James Bottomley wrote: > > On Wed, 2016-08-31 at 21:51 +, Zanoni, Paulo R wrote: > > &g

[Intel-gfx] Skylake graphics regression: projector failure with 4.8-rc3

2016-08-31 Thread James Bottomley
On Wed, 2016-08-31 at 21:51 +, Zanoni, Paulo R wrote: > Hi > > Em Qua, 2016-08-31 às 14:43 -0700, James Bottomley escreveu: > > On Wed, 2016-08-31 at 11:23 -0700, James Bottomley wrote: > > > > > > On Fri, 2016-08-26 at 09:10 -0400, James Bottomley wrote:

Skylake graphics regression: projector failure with 4.8-rc3

2016-08-31 Thread James Bottomley
On Wed, 2016-08-31 at 11:23 -0700, James Bottomley wrote: > On Fri, 2016-08-26 at 09:10 -0400, James Bottomley wrote: > > We seem to have an xrandr regression with skylake now. What's > > happening is that I can get output on to a projector, but the > > system is losin

Skylake graphics regression: projector failure with 4.8-rc3

2016-08-31 Thread James Bottomley
On Fri, 2016-08-26 at 09:10 -0400, James Bottomley wrote: > We seem to have an xrandr regression with skylake now. What's > happening is that I can get output on to a projector, but the system > is losing video when I change the xrandr sessions (like going from a > --above b to a

Skylake graphics regression: projector failure with 4.8-rc3

2016-08-26 Thread James Bottomley
On Fri, 2016-08-26 at 09:10 -0400, James Bottomley wrote: > We seem to have an xrandr regression with skylake now. What's > happening is that I can get output on to a projector, but the system > is losing video when I change the xrandr sessions (like going from a > --above b to a

Skylake graphics regression: projector failure with 4.8-rc3

2016-08-26 Thread James Bottomley
We seem to have an xrandr regression with skylake now. What's happening is that I can get output on to a projector, but the system is losing video when I change the xrandr sessions (like going from a - -above b to a --same-as b). The main screen goes blank, which is basically a reboot situation.

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-07-08 Thread James Bottomley
On Fri, 2016-07-08 at 13:19 +0300, Ville Syrjälä wrote: > On Thu, Jul 07, 2016 at 12:19:36PM -0700, James Bottomley wrote: > > On Thu, 2016-07-07 at 09:55 -0700, James Bottomley wrote: > > > On Thu, 2016-07-07 at 19:14 +0300, Ville Syrjälä wrote: > > > > On T

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-07-07 Thread James Bottomley
On Thu, 2016-07-07 at 09:55 -0700, James Bottomley wrote: > On Thu, 2016-07-07 at 19:14 +0300, Ville Syrjälä wrote: > > On Tue, Jun 21, 2016 at 06:44:34PM +0300, Ville Syrjälä wrote: > > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > > &g

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-07-07 Thread James Bottomley
On Thu, 2016-07-07 at 19:14 +0300, Ville Syrjälä wrote: > On Tue, Jun 21, 2016 at 06:44:34PM +0300, Ville Syrjälä wrote: > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > > Cc:

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-23 Thread James Bottomley
On Tue, 2016-06-21 at 17:00 -0400, James Bottomley wrote: > On Tue, 2016-06-21 at 18:44 +0300, Ville Syrjälä wrote: > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > > Cc: Ville &

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-21 Thread James Bottomley
On Tue, 2016-06-21 at 18:44 +0300, Ville Syrjälä wrote: > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > Cc: Ville > > > > > > On Mon, 20 Jun 2016, James Bottomley < > &g

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-21 Thread James Bottomley
On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > Cc: Ville > > On Mon, 20 Jun 2016, James Bottomley < > James.Bottomley at HansenPartnership.com> wrote: > > OK, my candidate bad commit is this one: > > > > commit a05628195a0d9f3173dd9aa76f482ae

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-19 Thread James Bottomley
On Fri, 2016-06-17 at 16:06 -0700, James Bottomley wrote: > On Fri, 2016-06-17 at 16:34 +0300, Jani Nikula wrote: > > On Fri, 17 Jun 2016, Daniel Vetter wrote: > > > On Thu, Jun 16, 2016 at 03:42:12PM -0700, James Bottomley wrote: > > > > On Thu, 2016-06-16 at 14:2

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-17 Thread James Bottomley
On Fri, 2016-06-17 at 16:34 +0300, Jani Nikula wrote: > On Fri, 17 Jun 2016, Daniel Vetter wrote: > > On Thu, Jun 16, 2016 at 03:42:12PM -0700, James Bottomley wrote: > > > On Thu, 2016-06-16 at 14:29 -0700, James Bottomley wrote: > > > > On Thu, 2016-06-16 at 23

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-17 Thread James Bottomley
On Fri, 2016-06-17 at 16:34 +0300, Jani Nikula wrote: > On Fri, 17 Jun 2016, Daniel Vetter wrote: > > On Thu, Jun 16, 2016 at 03:42:12PM -0700, James Bottomley wrote: > > > On Thu, 2016-06-16 at 14:29 -0700, James Bottomley wrote: > > > > On Thu, 2016-06-16 at 23

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-16 Thread James Bottomley
On Thu, 2016-06-16 at 14:29 -0700, James Bottomley wrote: > On Thu, 2016-06-16 at 23:24 +0200, Daniel Vetter wrote: > > I guess we'll need the bisect on this one to make progress. > > Sigh, I was afraid that might be the next step. OK, I have a curious data point. I assumed th

[Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-16 Thread James Bottomley
On Thu, 2016-06-16 at 23:24 +0200, Daniel Vetter wrote: > On Thu, Jun 16, 2016 at 11:15 PM, James Bottomley > wrote: > > On Mon, 2016-06-13 at 13:14 +0300, Jani Nikula wrote: > > > On Tue, 31 May 2016, James Bottomley < > > > James.Bottomley at HansenPartnership

Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-06-16 Thread James Bottomley
On Mon, 2016-06-13 at 13:14 +0300, Jani Nikula wrote: > On Tue, 31 May 2016, James Bottomley < > James.Bottomley at HansenPartnership.com> wrote: > > On Tue, 2016-05-31 at 10:51 +0300, Jani Nikula wrote: > > > On Mon, 30 May 2016, James Bottomley < > > > J

Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-05-31 Thread James Bottomley
On Tue, 2016-05-31 at 10:51 +0300, Jani Nikula wrote: > On Mon, 30 May 2016, James Bottomley < > James.Bottomley at HansenPartnership.com> wrote: > > I've tested a pristine 4.6.0 system, so it's definitely something > > that > > went in during the merge window.

Bad flicker on skylake HQD due to code in the 4.7 merge window

2016-05-30 Thread James Bottomley
I've tested a pristine 4.6.0 system, so it's definitely something that went in during the merge window. The flicker isn't continuous, it's periodic, with an interval of something like 2-5 seconds. It looks like an old analogue TV going out of sync and then resyncing. I've attached the dmesg and

[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote: > On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: > > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > > > On Fri, Ju

[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > We should prefer `const struct pci_device_id` over > > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding

[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote: > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. What kernel coding style? checkpatch isn't the arbiter of style, if that's the

[REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-19 Thread James Bottomley
On Thu, 2014-06-19 at 15:39 -0700, H. Peter Anvin wrote: > On 06/19/2014 01:01 PM, Greg KH wrote: > > On Thu, Jun 19, 2014 at 09:15:36PM +0200, Daniel Vetter wrote: > >> On Thu, Jun 19, 2014 at 7:00 PM, Greg KH > >> wrote: > >> + BUG_ON(f1->context != f2->context); > > > > Nice,

[REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-19 Thread James Bottomley
On Thu, 2014-06-19 at 11:19 -0700, Greg KH wrote: > On Thu, Jun 19, 2014 at 01:45:30PM -0400, Rob Clark wrote: > > On Thu, Jun 19, 2014 at 1:00 PM, Greg KH > > wrote: > > > On Thu, Jun 19, 2014 at 10:00:18AM -0400, Rob Clark wrote: > > >> On Wed, Jun 18, 2014 at 9:13 PM, Greg KH > > >> wrote:

Massive power regression going 3.4->3.5

2012-08-07 Thread James Bottomley
On Sun, 2012-08-05 at 22:36 +0200, Daniel Vetter wrote: > On Wed, Aug 01, 2012 at 11:08:19AM +0100, James Bottomley wrote: > > On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: > > > On Wed, 01 Aug 2012 09:45:04 +0100, James Bottomley > > HansenPartnership.com> wro

Re: Massive power regression going 3.4-3.5

2012-08-07 Thread James Bottomley
On Sun, 2012-08-05 at 22:36 +0200, Daniel Vetter wrote: On Wed, Aug 01, 2012 at 11:08:19AM +0100, James Bottomley wrote: On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:45:04 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed

Massive power regression going 3.4->3.5

2012-08-02 Thread James Bottomley
On Wed, 2012-08-01 at 22:08 -0700, bwidawsk wrote: > On 2012-08-01 03:06, Chris Wilson wrote: > > On Wed, 01 Aug 2012 10:38:36 +0100, James Bottomley > > wrote: > >> On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: > >> > On Wed, 01 Aug 2012 09:45:04

Re: Massive power regression going 3.4-3.5

2012-08-02 Thread James Bottomley
On Wed, 2012-08-01 at 22:08 -0700, bwidawsk wrote: On 2012-08-01 03:06, Chris Wilson wrote: On Wed, 01 Aug 2012 10:38:36 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:45:04 +0100, James

Massive power regression going 3.4->3.5

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: > On Wed, 01 Aug 2012 09:45:04 +0100, James Bottomley HansenPartnership.com> wrote: > > On Wed, 2012-08-01 at 09:16 +0100, Chris Wilson wrote: > > > On Wed, 01 Aug 2012 09:06:12 +0100, James Bottomley > > H

Massive power regression going 3.4->3.5

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: > On Wed, 01 Aug 2012 09:45:04 +0100, James Bottomley HansenPartnership.com> wrote: > > On Wed, 2012-08-01 at 09:16 +0100, Chris Wilson wrote: > > > On Wed, 01 Aug 2012 09:06:12 +0100, James Bottomley > > H

Massive power regression going 3.4->3.5

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: > On Wed, 01 Aug 2012 09:45:04 +0100, James Bottomley HansenPartnership.com> wrote: > > On Wed, 2012-08-01 at 09:16 +0100, Chris Wilson wrote: > > > On Wed, 01 Aug 2012 09:06:12 +0100, James Bottomley > > H

Massive power regression going 3.4->3.5

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 09:16 +0100, Chris Wilson wrote: > On Wed, 01 Aug 2012 09:06:12 +0100, James Bottomley HansenPartnership.com> wrote: > > I got the attached to apply and it doesn't really improve the idle power > > much (12.5W). > > That's good to know. Next step i

Massive power regression going 3.4->3.5

2012-08-01 Thread James Bottomley
On Tue, 2012-07-31 at 20:24 +0100, Chris Wilson wrote: > On Tue, 31 Jul 2012 11:14:17 +0100, Chris Wilson chris-wilson.co.uk> wrote: > > On Tue, 31 Jul 2012 10:57:10 +0100, James Bottomley > HansenPartnership.com> wrote: > > > > When did you inspect the debug f

Re: Massive power regression going 3.4-3.5

2012-08-01 Thread James Bottomley
On Tue, 2012-07-31 at 20:24 +0100, Chris Wilson wrote: On Tue, 31 Jul 2012 11:14:17 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 10:57:10 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: When did you inspect the debug files? One effect I

Re: Massive power regression going 3.4-3.5

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 09:16 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:06:12 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: I got the attached to apply and it doesn't really improve the idle power much (12.5W). That's good to know. Next step is to try

Re: Massive power regression going 3.4-3.5

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:45:04 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2012-08-01 at 09:16 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:06:12 +0100, James Bottomley james.bottom

Re: Massive power regression going 3.4-3.5

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:45:04 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2012-08-01 at 09:16 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:06:12 +0100, James Bottomley james.bottom

Re: Massive power regression going 3.4-3.5

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:45:04 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2012-08-01 at 09:16 +0100, Chris Wilson wrote: On Wed, 01 Aug 2012 09:06:12 +0100, James Bottomley james.bottom

Massive power regression going 3.4->3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 16:09 +0100, James Bottomley wrote: > On Tue, 2012-07-31 at 07:27 -0700, Keith Packard wrote: > > James Bottomley writes: > > > > > on 3.5 killing X causes idle power to go 14W -> 5.9W > > > on 3.4.6 killing X causes idle power to go 6

Massive power regression going 3.4->3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 07:27 -0700, Keith Packard wrote: > James Bottomley writes: > > > on 3.5 killing X causes idle power to go 14W -> 5.9W > > on 3.4.6 killing X causes idle power to go 6.8W -> 5.7W > > That's actually pretty good news -- you're just not gett

Massive power regression going 3.4->3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 10:54 +0100, Chris Wilson wrote: > On Tue, 31 Jul 2012 10:37:35 +0100, James Bottomley HansenPartnership.com> wrote: > > On Tue, 2012-07-31 at 09:28 +0100, Chris Wilson wrote: > > > On Tue, 31 Jul 2012 09:06:42 +0100, James Bottomley > > H

Massive power regression going 3.4->3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 09:28 +0100, Chris Wilson wrote: > On Tue, 31 Jul 2012 09:06:42 +0100, James Bottomley HansenPartnership.com> wrote: > > Actually, bad news: it looks like the problem is drm: > > > > on 3.5 killing X causes idle power to go 14W -> 5.9W > &g

Massive power regression going 3.4->3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 08:31 +0100, James Bottomley wrote: > On Mon, 2012-07-30 at 11:23 -0700, Keith Packard wrote: > > James Bottomley writes: > > > > > On Mon, 2012-07-30 at 09:33 -0700, Keith Packard wrote: > > >> James Bottomley writes: > > >&g

Massive power regression going 3.4->3.5

2012-07-31 Thread James Bottomley
On Mon, 2012-07-30 at 11:23 -0700, Keith Packard wrote: > James Bottomley writes: > > > On Mon, 2012-07-30 at 09:33 -0700, Keith Packard wrote: > >> James Bottomley writes: > >> > >> > OK, I've run the bisect as far as I can. It looks to be in the

Re: Massive power regression going 3.4-3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 08:31 +0100, James Bottomley wrote: On Mon, 2012-07-30 at 11:23 -0700, Keith Packard wrote: James Bottomley james.bottom...@hansenpartnership.com writes: On Mon, 2012-07-30 at 09:33 -0700, Keith Packard wrote: James Bottomley james.bottom...@hansenpartnership.com

Re: Massive power regression going 3.4-3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 09:28 +0100, Chris Wilson wrote: On Tue, 31 Jul 2012 09:06:42 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: Actually, bad news: it looks like the problem is drm: on 3.5 killing X causes idle power to go 14W - 5.9W on 3.4.6 killing X causes

Re: Massive power regression going 3.4-3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 10:54 +0100, Chris Wilson wrote: On Tue, 31 Jul 2012 10:37:35 +0100, James Bottomley james.bottom...@hansenpartnership.com wrote: On Tue, 2012-07-31 at 09:28 +0100, Chris Wilson wrote: On Tue, 31 Jul 2012 09:06:42 +0100, James Bottomley james.bottom

Re: Massive power regression going 3.4-3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 07:27 -0700, Keith Packard wrote: James Bottomley james.bottom...@hansenpartnership.com writes: on 3.5 killing X causes idle power to go 14W - 5.9W on 3.4.6 killing X causes idle power to go 6.8W - 5.7W That's actually pretty good news -- you're just not getting

Re: Massive power regression going 3.4-3.5

2012-07-31 Thread James Bottomley
On Tue, 2012-07-31 at 16:09 +0100, James Bottomley wrote: On Tue, 2012-07-31 at 07:27 -0700, Keith Packard wrote: James Bottomley james.bottom...@hansenpartnership.com writes: on 3.5 killing X causes idle power to go 14W - 5.9W on 3.4.6 killing X causes idle power to go 6.8W - 5.7W

Massive power regression going 3.4->3.5

2012-07-30 Thread James Bottomley
On Mon, 2012-07-30 at 09:33 -0700, Keith Packard wrote: > James Bottomley writes: > > > OK, I've run the bisect as far as I can. It looks to be in the drm > > tree. Unfortunately, this tree has several merge points, some of which > > go further back than v3.4. Unfort

Massive power regression going 3.4->3.5

2012-07-30 Thread James Bottomley
On Mon, 2012-07-30 at 10:46 +0100, James Bottomley wrote: > On Sun, 2012-07-29 at 21:25 +0200, Rafael J. Wysocki wrote: > > On Sunday, July 29, 2012, Rafael J. Wysocki wrote: > > > On Sunday, July 29, 2012, James Bottomley wrote: > > > > On Sat, 2012-07-28 at 22:29

Re: Massive power regression going 3.4-3.5

2012-07-30 Thread James Bottomley
On Mon, 2012-07-30 at 10:46 +0100, James Bottomley wrote: On Sun, 2012-07-29 at 21:25 +0200, Rafael J. Wysocki wrote: On Sunday, July 29, 2012, Rafael J. Wysocki wrote: On Sunday, July 29, 2012, James Bottomley wrote: On Sat, 2012-07-28 at 22:29 +0200, Rafael J. Wysocki wrote

Re: Massive power regression going 3.4-3.5

2012-07-30 Thread James Bottomley
On Mon, 2012-07-30 at 09:33 -0700, Keith Packard wrote: James Bottomley james.bottom...@hansenpartnership.com writes: OK, I've run the bisect as far as I can. It looks to be in the drm tree. Unfortunately, this tree has several merge points, some of which go further back than v3.4

[PATCH 00/12] Fix various section mismatches and build errors.

2011-06-29 Thread James Bottomley
On Wed, 2011-06-29 at 17:19 +0100, Ralf Baechle wrote: > On Wed, Jun 29, 2011 at 08:14:24AM -0700, Greg KH wrote: > > > > > On Wed, Jun 29, 2011 at 08:58:19AM -0500, James Bottomley wrote: > > > I think we should simply concentrate on __init and __exit; that's wher

[PATCH 00/12] Fix various section mismatches and build errors.

2011-06-29 Thread James Bottomley
Revert "net: fix section mismatches" > > > > This reverts commit e5cb966c0838e4da43a3b0751bdcac7fe719f7b4. > > > > It causes new build regressions with gcc-4.2 which is > > pretty common on non-x86 platforms. > > > > Rep

Re: [PATCH 00/12] Fix various section mismatches and build errors.

2011-06-29 Thread James Bottomley
mismatches This reverts commit e5cb966c0838e4da43a3b0751bdcac7fe719f7b4. It causes new build regressions with gcc-4.2 which is pretty common on non-x86 platforms. Reported-by: James Bottomley james.bottom...@hansenpartnership.com Signed-off-by: David S

(Short?) merge window reminder

2011-05-24 Thread James Bottomley
On Mon, 2011-05-23 at 12:22 -0700, Greg KH wrote: > On Mon, May 23, 2011 at 12:13:29PM -0700, Linus Torvalds wrote: > > PS. The voices in my head also tell me that the numbers are getting > > too big. I may just call the thing 2.8.0. And I almost guarantee that > > this PS is going to result in

Re: (Short?) merge window reminder

2011-05-24 Thread James Bottomley
On Mon, 2011-05-23 at 12:22 -0700, Greg KH wrote: On Mon, May 23, 2011 at 12:13:29PM -0700, Linus Torvalds wrote: PS. The voices in my head also tell me that the numbers are getting too big. I may just call the thing 2.8.0. And I almost guarantee that this PS is going to result in more