[PATCH v5 5/8] drm/omap: remove OMAP_BO_TILED define

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK instead. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques

[PATCH v5 8/8] drm/omap: add OMAP_BO flags to affect buffer allocation

2019-10-10 Thread Jean-Jacques Hiblot
one of the flags are given, the behavior is the same as currently. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 54 -- include/uapi/drm/omap_drm.h| 9 + 2 files changed, 61 insertions(+), 2 deletion

[PATCH v5 0/8] drm/omap: OMAP_BO flags

2019-10-10 Thread Jean-Jacques Hiblot
e refcount part a bit. Jean-Jacques Hiblot (1): drm/omap: use refcount API to track the number of users of dma_addr Tomi Valkeinen (7): drm/omap: add omap_gem_unpin_locked() drm/omap: accept NULL for dma_addr in omap_gem_pin drm/omap: cleanup OMAP_BO flags drm/omap: remove OMAP_BO_TI

[PATCH v5 6/8] drm/omap: cleanup OMAP_BO_SCANOUT use

2019-10-10 Thread Jean-Jacques Hiblot
g that can be consumed by DSS", this patch cleans up the above issues. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/

[PATCH v5 1/8] drm/omap: use refcount API to track the number of users of dma_addr

2019-10-10 Thread Jean-Jacques Hiblot
This would give us a WARN_ON() if the pin/unpin calls are unbalanced. Proposed-by: Laurent Pinchart Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 44 +++--- 1 file changed, 22 insertions(+), 22 deletions

[PATCH v5 2/8] drm/omap: add omap_gem_unpin_locked()

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that expects the caller to hold the omap_obj lock. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 25 ++--- 1 file changed, 18

[PATCH v5 4/8] drm/omap: cleanup OMAP_BO flags

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Reorder OMAP_BO flags and improve the comments. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- include/uapi/drm/omap_drm.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/drm/omap_drm.h b/include/uapi

[PATCH v5 7/8] drm/omap: add omap_gem_validate_flags()

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add a helper function omap_gem_validate_flags() which validates the omap_bo flags passed from the userspace. Also drop the dev_err() message, as the userspace can cause that at will. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm

[PATCH v5 3/8] drm/omap: accept NULL for dma_addr in omap_gem_pin

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the caller does not need the dma_addr. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH v4 0/8] drm/omap: OMAP_BO flags

2019-10-10 Thread Jean-Jacques Hiblot
On 10/10/2019 11:45, Tomi Valkeinen wrote: Hi JJ, On 10/10/2019 12:34, Jean-Jacques Hiblot wrote: A first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few new OMAP_BO flags to help the userspace

Re: [PATCH v10 4/6] dts-bindings: leds: Document the naming requirement for LED properties

2019-10-10 Thread Jean-Jacques Hiblot
On 09/10/2019 21:26, Rob Herring wrote: On Wed, Oct 09, 2019 at 10:51:25AM +0200, Jean-Jacques Hiblot wrote: LED properties must be named "leds" in the same way that PWM, clocks or PHY properties are names respectively "pwms", "clocks" and "phys". Cc:

[PATCH v4 6/8] drm/omap: cleanup OMAP_BO_SCANOUT use

2019-10-10 Thread Jean-Jacques Hiblot
g that can be consumed by DSS", this patch cleans up the above issues. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/

[PATCH v4 1/8] drm/omap: use refcount API to track the number of users of dma_addr

2019-10-10 Thread Jean-Jacques Hiblot
This would give us a WARN_ON() if the pin/unpin calls are unbalanced. Proposed-by: Laurent Pinchart Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 44 +++--- 1 file changed, 22 insertions(+), 22 deletions

[PATCH v4 3/8] drm/omap: accept NULL for dma_addr in omap_gem_pin

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the caller does not need the dma_addr. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH v4 8/8] drm/omap: add OMAP_BO flags to affect buffer allocation

2019-10-10 Thread Jean-Jacques Hiblot
one of the flags are given, the behavior is the same as currently. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 54 -- include/uapi/drm/omap_drm.h| 9 + 2 files changed, 61 insertions(+), 2 deletion

[PATCH v4 2/8] drm/omap: add omap_gem_unpin_locked()

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that expects the caller to hold the omap_obj lock. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 25 ++--- 1 file changed, 18

[PATCH v4 7/8] drm/omap: add omap_gem_validate_flags()

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add a helper function omap_gem_validate_flags() which validates the omap_bo flags passed from the userspace. Also drop the dev_err() message, as the userspace can cause that at will. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- drivers/gpu/drm

[PATCH v4 4/8] drm/omap: cleanup OMAP_BO flags

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Reorder OMAP_BO flags and improve the comments. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques Hiblot --- include/uapi/drm/omap_drm.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/drm/omap_drm.h b/include/uapi

[PATCH v4 5/8] drm/omap: remove OMAP_BO_TILED define

2019-10-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK instead. Signed-off-by: Tomi Valkeinen Reviewed-by: Jean-Jacques

[PATCH v4 0/8] drm/omap: OMAP_BO flags

2019-10-10 Thread Jean-Jacques Hiblot
- Document omap_gem_new() and the new flags using the kernel-doc format changes in v2: - fixed build error that crept in during rebase before sending (sorry about that) - rework the refcount part a bit. Jean-Jacques Hiblot (1): drm/omap: use refcount API to track the number of users of dma_addr Tomi

[PATCH v10 6/6] backlight: add led-backlight driver

2019-10-09 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot

[PATCH v10 5/6] dt-bindings: backlight: Add led-backlight binding

2019-10-09 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Cc: devicet...@vger.kernel.org Signed-off-by: Jean-Jacques Hiblot --- .../leds/backlight/led-backlight.yaml | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led

[PATCH v10 3/6] leds: Add managed API to get a LED from a device driver

2019-10-09 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 49 include/linux/leds.h | 2 ++ 2

[PATCH v10 4/6] dts-bindings: leds: Document the naming requirement for LED properties

2019-10-09 Thread Jean-Jacques Hiblot
LED properties must be named "leds" in the same way that PWM, clocks or PHY properties are names respectively "pwms", "clocks" and "phys". Cc: devicet...@vger.kernel.org Signed-off-by: Jean-Jacques Hiblot --- .../devicetree/bindings/leds/common.txt

[PATCH v10 0/6] Add a generic driver for LED-based backlight

2019-10-09 Thread Jean-Jacques Hiblot
ls and default-brightness-level optional - removed the option to use a GPIO enable. - removed the option to use a regulator. It should be handled by the LED core - don't make any change to the LED core (not needed anymore) Jean-Jacques Hiblot (4): leds: populate the device's of_node leds:

[PATCH v10 1/6] leds: populate the device's of_node

2019-10-09 Thread Jean-Jacques Hiblot
If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allow the device to use or provide OF-based API such (devm_xxx). Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 4 +++- 1 file chang

[PATCH v10 2/6] leds: Add of_led_get() and led_put()

2019-10-09 Thread Jean-Jacques Hiblot
Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 50 include/linux/leds.h | 4 2 files changed, 54 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index bfa1b1033274..1d1f1d546dc7 100644

Re: [PATCH v3 0/8] drm/omap: OMAP_BO flags

2019-10-08 Thread Jean-Jacques Hiblot
On 07/10/2019 14:16, Tomi Valkeinen wrote: On 07/10/2019 14:25, Jean-Jacques Hiblot wrote: A first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few new OMAP_BO flags to help the userspace manage

Re: [v3,8/8] drm/omap: add OMAP_BO flags to affect buffer allocation

2019-10-08 Thread Jean-Jacques Hiblot
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen On SoCs with DMM/TILER, we have two ways to allocate buffers: normal dma_alloc or via DMM (which basically functions as an IOMMU). DMM can map 128MB at a time, and we only map the DMM buffers when they are used (i.e. not at

Re: [v3,7/8] drm/omap: add omap_gem_validate_flags()

2019-10-08 Thread Jean-Jacques Hiblot
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen Add a helper function omap_gem_validate_flags() which validates the omap_bo flags passed from the userspace. Also drop the dev_err() message, as the userspace can cause that at will. Signed-off-by: Tomi Valkeinen

Re: [v3,6/8] drm/omap: cleanup OMAP_BO_SCANOUT use

2019-10-08 Thread Jean-Jacques Hiblot
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some reason. It's not clear what the original purpose of OMAP_BO_SCANOUT is

Re: [v3,5/8] drm/omap: remove OMAP_BO_TILED define

2019-10-08 Thread Jean-Jacques Hiblot
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK instead. Signed-off

Re: [v3,4/8] drm/omap: cleanup OMAP_BO flags

2019-10-08 Thread Jean-Jacques Hiblot
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen Reorder OMAP_BO flags and improve the comments. Signed-off-by: Tomi Valkeinen --- include/uapi/drm/omap_drm.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/drm

Re: [v3,3/8] drm/omap: accept NULL for dma_addr in omap_gem_pin

2019-10-08 Thread Jean-Jacques Hiblot
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the caller does not need the dma_addr. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 -- 1 file changed, 4

Re: [v3,2/8] drm/omap: add omap_gem_unpin_locked()

2019-10-08 Thread Jean-Jacques Hiblot
On 07/10/2019 13:25, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that expects the caller to hold the omap_obj lock. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 24 +--- 1

Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-08 Thread Jean-Jacques Hiblot
Rob, On 08/10/2019 14:51, Jean-Jacques Hiblot wrote: Hi Rob, On 07/10/2019 18:15, Rob Herring wrote: Please send DT bindings to DT list or it's never in my queue. IOW, send patches to the lists that get_maintainers.pl tells you to. On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot

Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-08 Thread Jean-Jacques Hiblot
Hi Rob, On 07/10/2019 18:15, Rob Herring wrote: Please send DT bindings to DT list or it's never in my queue. IOW, send patches to the lists that get_maintainers.pl tells you to. On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot wrote: Add DT binding for led-backlight. Signed-off-by:

[PATCH v9 0/5] Add a generic driver for LED-based backlight

2019-10-07 Thread Jean-Jacques Hiblot
nable. - removed the option to use a regulator. It should be handled by the LED core - don't make any change to the LED core (not needed anymore) Jean-Jacques Hiblot (3): leds: populate the device's of_node leds: Add managed API to get a LED from a device driver dt-bindings: backli

[PATCH v9 1/5] leds: populate the device's of_node

2019-10-07 Thread Jean-Jacques Hiblot
If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allow the device to use or provide OF-based API such (devm_xxx). Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 4 +++- 1 file chang

[PATCH v9 3/5] leds: Add managed API to get a LED from a device driver

2019-10-07 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 49 include/linux/leds.h | 2 ++ 2

[PATCH v9 2/5] leds: Add of_led_get() and led_put()

2019-10-07 Thread Jean-Jacques Hiblot
Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 50 include/linux/leds.h | 4 2 files changed, 54 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index bfa1b1033274..1d1f1d546dc7 100644

[PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-07 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Daniel Thompson Reviewed-by: Sebastian Reichel --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v9 5/5] backlight: add led-backlight driver

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot

[PATCH v3 4/8] drm/omap: cleanup OMAP_BO flags

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Reorder OMAP_BO flags and improve the comments. Signed-off-by: Tomi Valkeinen --- include/uapi/drm/omap_drm.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/drm/omap_drm.h b/include/uapi/drm/omap_drm.h index 1fccffef9e27.

[PATCH v3 1/8] drm/omap: use refcount API to track the number of users of dma_addr

2019-10-07 Thread Jean-Jacques Hiblot
This would give us a WARN_ON() if the pin/unpin calls are unbalanced. Proposed-by: Laurent Pinchart Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 45 +++--- 1 file changed, 23 insertions(+), 22 deletions

[PATCH v3 6/8] drm/omap: cleanup OMAP_BO_SCANOUT use

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some reason. It's not clear what the original purpose of OMAP_BO_SCANOUT is, but presuming it means "scanout buffer, something that can be

[PATCH v3 2/8] drm/omap: add omap_gem_unpin_locked()

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that expects the caller to hold the omap_obj lock. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff

[PATCH v3 8/8] drm/omap: add OMAP_BO flags to affect buffer allocation

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen On SoCs with DMM/TILER, we have two ways to allocate buffers: normal dma_alloc or via DMM (which basically functions as an IOMMU). DMM can map 128MB at a time, and we only map the DMM buffers when they are used (i.e. not at alloc time). If DMM is present, omapdrm always uses

[PATCH v3 3/8] drm/omap: accept NULL for dma_addr in omap_gem_pin

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the caller does not need the dma_addr. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/o

[PATCH v3 7/8] drm/omap: add omap_gem_validate_flags()

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add a helper function omap_gem_validate_flags() which validates the omap_bo flags passed from the userspace. Also drop the dev_err() message, as the userspace can cause that at will. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 40 +++

[PATCH v3 5/8] drm/omap: remove OMAP_BO_TILED define

2019-10-07 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK instead. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/om

[PATCH v3 0/8] drm/omap: OMAP_BO flags

2019-10-07 Thread Jean-Jacques Hiblot
sorry about that) - rework the refcount part a bit. Jean-Jacques Hiblot (1): drm/omap: use refcount API to track the number of users of dma_addr Tomi Valkeinen (7): drm/omap: add omap_gem_unpin_locked() drm/omap: accept NULL for dma_addr in omap_gem_pin drm/omap: cleanup OMAP_BO flags drm

Re: Should regulator core support parsing OF based fwnode?

2019-10-04 Thread Jean-Jacques Hiblot
On 04/10/2019 17:58, Mark Brown wrote: On Fri, Oct 04, 2019 at 05:13:13PM +0200, Jean-Jacques Hiblot wrote: On 04/10/2019 16:40, Mark Brown wrote: Why is the LED core populating anything? Is the LED core copying bits out of the struct device for the actual device into a synthetic device

Re: [PATCH v7 5/5] backlight: add led-backlight driver

2019-10-04 Thread Jean-Jacques Hiblot
Hi Lee, On 04/10/2019 16:39, Lee Jones wrote: On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be

Re: Should regulator core support parsing OF based fwnode?

2019-10-04 Thread Jean-Jacques Hiblot
On 04/10/2019 16:40, Mark Brown wrote: On Fri, Oct 04, 2019 at 03:33:13PM +0200, Jean-Jacques Hiblot wrote: On 04/10/2019 13:39, Mark Brown wrote: Consumers should just be able to request a regulator without having to worry about how that's being provided - they should have no knowled

Re: Should regulator core support parsing OF based fwnode?

2019-10-04 Thread Jean-Jacques Hiblot
On 04/10/2019 13:39, Mark Brown wrote: On Thu, Oct 03, 2019 at 10:27:26PM +0200, Jacek Anaszewski wrote: On 10/3/19 9:41 PM, Mark Brown wrote: Why would we want to do that? We'd continue to support only DT systems, just with code that's less obviously DT only and would need to put checks in.

Re: Should regulator core support parsing OF based fwnode?

2019-10-04 Thread Jean-Jacques Hiblot
Hiblot wrote: On 03/10/2019 12:42, Sebastian Reichel wrote: On Thu, Oct 03, 2019 at 10:28:09AM +0200, Jean-Jacques Hiblot wrote: This mail has nothing relevant in the subject line and pages of quotes before the question for me, it's kind of lucky I noticed it Isn't it all about creat

Re: [PATCH v8 5/5] backlight: add led-backlight driver

2019-10-03 Thread Jean-Jacques Hiblot
Sebastian, On 03/10/2019 13:47, Sebastian Reichel wrote: Hi, On Thu, Oct 03, 2019 at 10:28:12AM +0200, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the

Re: [PATCH v8 2/5] leds: Add of_led_get() and led_put()

2019-10-03 Thread Jean-Jacques Hiblot
Hi Sebastian, On 03/10/2019 12:42, Sebastian Reichel wrote: Hi, On Thu, Oct 03, 2019 at 10:28:09AM +0200, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen This patch adds basic support for a kernel driver to get a LED device. This will be used by the led-backlight driver. Only OF version is

[PATCH v8 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-03 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Daniel Thompson --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt

[PATCH v8 3/5] leds: Add managed API to get a LED from a device driver

2019-10-03 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 49 include/linux/leds.h | 2 ++ 2

[PATCH v8 2/5] leds: Add of_led_get() and led_put()

2019-10-03 Thread Jean-Jacques Hiblot
Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 44 include/linux/leds.h | 4 2 files changed, 48 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index c2167b66b61f..455545f5d663 100644

[PATCH v8 0/5] Add a generic driver for LED-based backlight

2019-10-03 Thread Jean-Jacques Hiblot
ed by the LED core - don't make any change to the LED core (not needed anymore) Jean-Jacques Hiblot (3): leds: populate the device's of_node when possible leds: Add managed API to get a LED from a device driver dt-bindings: backlight: Add led-backlight binding Tomi Valkeinen (2)

[PATCH v8 5/5] backlight: add led-backlight driver

2019-10-03 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot

[PATCH v8 1/5] leds: populate the device's of_node when possible

2019-10-03 Thread Jean-Jacques Hiblot
If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allow the device to use or provide OF-based API such (devm_xxx). Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 5 - 1 file chang

Re: [PATCH v7 1/5] leds: populate the device's of_node when possible

2019-10-02 Thread Jean-Jacques Hiblot
Hi Jacek, On 24/09/2019 23:03, Jacek Anaszewski wrote: Hi Jean, Thank you for rebasing the set On 9/18/19 4:57 PM, Jean-Jacques Hiblot wrote: If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allo

status of the " CRTC background color" series

2019-09-20 Thread Jean-Jacques Hiblot
Hi all, Any update on this series ? Last time I looked, everything looked ready and waiting to be merged. JJ ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v7 0/5] Add a generic driver for LED-based backlight

2019-09-18 Thread Jean-Jacques Hiblot
r. - make brightness-levels and default-brightness-level optional - removed the option to use a GPIO enable. - removed the option to use a regulator. It should be handled by the LED core - don't make any change to the LED core (not needed anymore) Jean-Jacques Hiblot (3): leds: populate

[PATCH v7 3/5] leds: Add managed API to get a LED from a device driver

2019-09-18 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 51 include/linux/leds.h | 2 ++ 2

[PATCH v7 2/5] leds: Add of_led_get() and led_put()

2019-09-18 Thread Jean-Jacques Hiblot
Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 50 include/linux/leds.h | 4 2 files changed, 54 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index c2167b66b61f..2b8f20f94128 100644

[PATCH v7 5/5] backlight: add led-backlight driver

2019-09-18 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot

[PATCH v7 1/5] leds: populate the device's of_node when possible

2019-09-18 Thread Jean-Jacques Hiblot
If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allow the device to use or provide OF-based API such (devm_xxx). Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 5 - 1 file chang

[PATCH v7 4/5] dt-bindings: backlight: Add led-backlight binding

2019-09-18 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Daniel Thompson --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt

[PATCH v6 1/4] leds: Add of_led_get() and led_put()

2019-09-10 Thread Jean-Jacques Hiblot
Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 50 include/linux/leds.h | 4 2 files changed, 54 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 159c6caa374b..d4d22f4b5052 100644

[PATCH v6 2/4] leds: Add managed API to get a LED from a device driver

2019-09-10 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 42 include/linux/leds.h | 2 ++ 2

[PATCH v6 4/4] backlight: add led-backlight driver

2019-09-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot

[PATCH v6 0/4] Add a generic driver for LED-based backlight

2019-09-10 Thread Jean-Jacques Hiblot
e a child of the LED controller. - make brightness-levels and default-brightness-level optional - removed the option to use a GPIO enable. - removed the option to use a regulator. It should be handled by the LED core - don't make any change to the LED core (not needed anymore) Jean-Jacque

[PATCH v6 3/4] dt-bindings: backlight: Add led-backlight binding

2019-09-10 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Daniel Thompson --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt

Re: [PATCH v2 0/8] drm/omap: OMAP_BO flags

2019-08-02 Thread Jean-Jacques Hiblot
On 01/08/2019 11:02, Tomi Valkeinen wrote: Hi JJ, On 08/07/2019 13:45, Jean-Jacques Hiblot wrote: A first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few new OMAP_BO flags to help the userspace

Re: [PATCH v2 0/8] drm/omap: OMAP_BO flags

2019-08-02 Thread Jean-Jacques Hiblot
On 01/08/2019 11:02, Tomi Valkeinen wrote: Hi JJ, On 08/07/2019 13:45, Jean-Jacques Hiblot wrote: A first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few new OMAP_BO flags to help the userspace

[PATCH v4 1/4] leds: Add of_led_get() and led_put()

2019-07-17 Thread Jean-Jacques Hiblot
Jean-Jacques Hiblot --- drivers/leds/led-class.c | 50 include/linux/leds.h | 4 2 files changed, 54 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index cadd43c30d50..9f48798a713d 100644 --- a/drivers/leds/led-cl

[PATCH v4 3/4] dt-bindings: backlight: Add led-backlight binding

2019-07-17 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt diff --git a/Documentation

[PATCH v4 2/4] leds: Add managed API to get a LED from a device driver

2019-07-17 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 42 include/linux/leds.h | 2 ++ 2

[PATCH v4 4/4] backlight: add led-backlight driver

2019-07-17 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot

[PATCH v4 0/4] Add a generic driver for LED-based backlight

2019-07-17 Thread Jean-Jacques Hiblot
#x27;t make any change to the LED core (not needed anymore) Jean-Jacques Hiblot (2): leds: Add managed API to get a LED from a device driver dt-bindings: backlight: Add led-backlight binding Tomi Valkeinen (2): leds: Add of_led_get() and led_put() backlight: add led-backlight driver .../bi

Re: [PATCH v3 3/4] dt-bindings: backlight: Add led-backlight binding

2019-07-12 Thread Jean-Jacques Hiblot
Pavel, On 10/07/2019 21:13, Pavel Machek wrote: On Wed 2019-07-10 14:39:31, Jean-Jacques Hiblot wrote: Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create

Re: [PATCH v3 1/4] leds: Add of_led_get() and led_put()

2019-07-12 Thread Jean-Jacques Hiblot
hi Pavel On 10/07/2019 21:09, Pavel Machek wrote: On Wed 2019-07-10 14:39:29, Jean-Jacques Hiblot wrote: From: Tomi Valkeinen This patch adds basic support for a kernel driver to get a LED device. This will be used by the led-backlight driver. Only OF version is implemented for now, and the

[PATCH] drm/omap: Add 'alpha' and 'pixel blend mode' plane properties

2019-07-11 Thread Jean-Jacques Hiblot
Add the following properties for planes: * alpha * pixel blend mode. Only "Pre-multiplied" and "Coverage" are supported Signed-off-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_plane.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/dri

[PATCH v3 2/4] leds: Add managed API to get a LED from a device driver

2019-07-10 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically release when the device is detach. Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 42 include/linux/leds.h | 2 ++ 2 files changed, 44 insertions

[PATCH v3 4/4] backlight: add led-backlight driver

2019-07-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot

[PATCH v3 3/4] dt-bindings: backlight: Add led-backlight binding

2019-07-10 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt diff --git a/Documentation

[PATCH v3 1/4] leds: Add of_led_get() and led_put()

2019-07-10 Thread Jean-Jacques Hiblot
Jean-Jacques Hiblot --- drivers/leds/led-class.c | 50 include/linux/leds.h | 4 2 files changed, 54 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index e01b2d982564..0f67b13b0f1f 100644 --- a/drivers/leds/led-cl

[PATCH v3 0/4] Add a generic driver for LED-based backlight

2019-07-10 Thread Jean-Jacques Hiblot
the option to use a GPIO enable. - removed the option to use a regulator. It should be handled by the LED core - don't make any change to the LED core (not needed anymore) Jean-Jacques Hiblot (2): leds: Add managed API to get a LED from a device driver dt-bindings: backlight: Add led-ba

[PATCH v2 8/8] drm/omap: add OMAP_BO flags to affect buffer allocation

2019-07-08 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen On SoCs with DMM/TILER, we have two ways to allocate buffers: normal dma_alloc or via DMM (which basically functions as an IOMMU). DMM can map 128MB at a time, and we only map the DMM buffers when they are used (i.e. not at alloc time). If DMM is present, omapdrm always uses

[PATCH v2 4/8] drm/omap: cleanup OMAP_BO flags

2019-07-08 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Reorder OMAP_BO flags and improve the comments. Signed-off-by: Tomi Valkeinen --- include/uapi/drm/omap_drm.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/drm/omap_drm.h b/include/uapi/drm/omap_drm.h index 1fccffef9e27.

[PATCH v2 2/8] drm/omap: add omap_gem_unpin_locked()

2019-07-08 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that expects the caller to hold the omap_obj lock. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff

[PATCH v2 5/8] drm/omap: remove OMAP_BO_TILED define

2019-07-08 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK instead. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/om

[PATCH v2 6/8] drm/omap: cleanup OMAP_BO_SCANOUT use

2019-07-08 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some reason. It's not clear what the original purpose of OMAP_BO_SCANOUT is, but presuming it means "scanout buffer, something that can be

[PATCH v2 3/8] drm/omap: accept NULL for dma_addr in omap_gem_pin

2019-07-08 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the caller does not need the dma_addr. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/o

[PATCH v2 0/8] drm/omap: OMAP_BO flags

2019-07-08 Thread Jean-Jacques Hiblot
be be done when this series have been discussed and hopefully in the process of getting merged. JJ changes in v2: - fixed build error that crept in during rebase before sending (sorry about that) - rework the refcount part a bit. Jean-Jacques Hiblot (1): drm/omap: use refcount API to trac

  1   2   >