[PATCH 01/12] drm: remove unused connector_count field from drm_display_mode

2011-11-07 Thread Jesse Barnes
Doesn't really belong here anyway. Signed-off-by: Jesse Barnes --- include/drm/drm_crtc.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8020798..b0df23a 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm

Misc. cleanups

2011-11-07 Thread Jesse Barnes
Just some cleanups for unused fields in drm_crtc.h and some comment corrections. I also removed a few DRM_ERRORs from drm_crtc.c (things actually weren't as bad as I feared). Next step is to remove a whole slew of DRM_DEBUG calls unless people are really attached to them. I find them to just

[PATCH 1/4] drm: try to restore previous CRTC config if mode set fails

2011-11-07 Thread Jesse Barnes
We restore the CRTC, encoder, and connector configurations, but if the mode set failed, the attached display may have been turned off, so we need to try set_config again to restore things to the way they were. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc_helper.c | 13

[PATCH 5/5] drm/i915: track sprite coverage and disable primary plane if possible

2011-11-07 Thread Jesse Barnes
To save power when the sprite is full screen, we can disable the primary plane on the same pipe. Track the sprite status and enable/disable the primary opportunistically. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_drv.h|1 + drivers/gpu/drm/i915/intel_sprite.c | 19

[PATCH 4/5] drm/i915: add destination color key support

2011-11-07 Thread Jesse Barnes
Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_dma.c |2 + drivers

[PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-07 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core sprite support functions. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/i915_reg.h | 123

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-07 Thread Jesse Barnes
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c

[PATCH 1/5] drm: add plane support

2011-11-07 Thread Jesse Barnes
Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c | 251 +++- drivers/gpu/drm/drm_drv.c

[PATCH] DRM planes

2011-11-07 Thread Jesse Barnes
Ok this one includes all the minor feedback from last week, and should satisfy Daniel and Jakob enough to get their Reviewed-bys. You can ignore the final patch in the series; it's a WIP power saving feature, but the other ones are working well here. Thanks, Jesse

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-07 Thread Jesse Barnes
ld you please tell me about why do you need > them.? Daniel seemed to think that some of the formats might have ambiguous pitches or offsets, so being able to specify one for each possible component seems like a good idea. Also, for planar formats packed into a single buffer object handle (th

Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-07 Thread Jesse Barnes
component seems like a good idea. Also, for planar formats packed into a single buffer object handle (through driver specific multiplexing or non-zero offsets), individual pitches and offsets may be required. -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

[PATCH] DRM planes

2011-11-07 Thread Jesse Barnes
Ok this one includes all the minor feedback from last week, and should satisfy Daniel and Jakob enough to get their Reviewed-bys. You can ignore the final patch in the series; it's a WIP power saving feature, but the other ones are working well here. Thanks, Jesse

[PATCH 1/5] drm: add plane support

2011-11-07 Thread Jesse Barnes
Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c | 251 +++- drivers

[PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-07 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core sprite support functions. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915

[PATCH 5/5] drm/i915: track sprite coverage and disable primary plane if possible

2011-11-07 Thread Jesse Barnes
To save power when the sprite is full screen, we can disable the primary plane on the same pipe. Track the sprite status and enable/disable the primary opportunistically. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_drv.h|1 + drivers/gpu/drm/i915/intel_sprite.c | 19

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-07 Thread Jesse Barnes
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[PATCH 4/5] drm/i915: add destination color key support

2011-11-07 Thread Jesse Barnes
Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915

[PATCH 1/4] drm: try to restore previous CRTC config if mode set fails

2011-11-07 Thread Jesse Barnes
We restore the CRTC, encoder, and connector configurations, but if the mode set failed, the attached display may have been turned off, so we need to try set_config again to restore things to the way they were. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm

Misc. cleanups

2011-11-07 Thread Jesse Barnes
Just some cleanups for unused fields in drm_crtc.h and some comment corrections. I also removed a few DRM_ERRORs from drm_crtc.c (things actually weren't as bad as I feared). Next step is to remove a whole slew of DRM_DEBUG calls unless people are really attached to them. I find them to just

[PATCH 01/12] drm: remove unused connector_count field from drm_display_mode

2011-11-07 Thread Jesse Barnes
Doesn't really belong here anyway. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8020798..b0df23a 100644 --- a/include/drm/drm_crtc.h

[PATCH 02/12] drm: remove unused save/restore functions from drm_crtc_funcs fix comments

2011-11-07 Thread Jesse Barnes
Remove two unused fields from this struct and cleanup/correct the comments. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 18 -- 1 files changed, 4 insertions(+), 14 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h

[PATCH 03/12] drm: fix comments for drm_crtc struct

2011-11-07 Thread Jesse Barnes
Remove stale entries and update with the latest stuff. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index a960020..ad2a605 100644

[PATCH 04/12] drm: remove unused save/restore fields from drm_connector fix comments

2011-11-07 Thread Jesse Barnes
Also fix up the wrapping to 80 columns. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 20 +++- 1 files changed, 7 insertions(+), 13 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index ad2a605..6ab20f8 100644

[PATCH 06/12] drm: add drm_encoder comments

2011-11-07 Thread Jesse Barnes
Just some basic comments about the place and function of the structure and fields. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h

[PATCH 05/12] drm: add comments for drm_encoder_funcs

2011-11-07 Thread Jesse Barnes
Just basic verbiage. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 6ab20f8..a1583d8 100644 --- a/include/drm/drm_crtc.h +++ b

[PATCH 07/12] drm: remove unused fields in drm_connector and document the rest

2011-11-07 Thread Jesse Barnes
We never used initial_x/y or the force_encoder_id, so drop those fields and proide a basic description of the others. Really, the ELD bits belong in drm_display_info rather than directly in the connector, but that's a separate cleanup. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[PATCH 09/12] drm: document and cleanup drm_mode_config_funcs

2011-11-07 Thread Jesse Barnes
Just fix the wrapping mostly. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index b33713b..a0c7dc6 100644 --- a/include/drm

[PATCH 10/12] drm: document the drm_mode_group structure

2011-11-07 Thread Jesse Barnes
This is actually a core structure with a big future ahead of it. Make it a little less mysterious. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b

[PATCH 11/12] drm: document the drm_mode_config structure

2011-11-07 Thread Jesse Barnes
Including a comment about what the locks are for. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 003cba2

Re: [PATCH 04/12] drm: remove unused save/restore fields from drm_connector fix comments

2011-11-07 Thread Jesse Barnes
On Mon, 07 Nov 2011 20:26:59 + Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, 7 Nov 2011 12:03:15 -0800, Jesse Barnes jbar...@virtuousgeek.org wrote: Also fix up the wrapping to 80 columns. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-04 Thread Jesse Barnes
but above function cannot detect it. Oh that's a mistake on my part. RGB24 is generally bpp=32. I'll fix that. This is just a compatibility function, so it only needs to handle cases used by current code. I expect future code to use the fourcc values directly. Thanks, -- Jesse Barnes, In

[PATCH 1/5] drm: add plane support

2011-11-04 Thread Jesse Barnes
in device specific update_plane, but can do in > drm_mode_setplane? Yeah it should probably be done in setplane if there's no error. Fixed. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- next part -- A non-text attachment was scrubbed... Nam

Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-04 Thread Jesse Barnes
detect it. Oh that's a mistake on my part. RGB24 is generally bpp=32. I'll fix that. This is just a compatibility function, so it only needs to handle cases used by current code. I expect future code to use the fourcc values directly. Thanks, -- Jesse Barnes, Intel Open Source Technology

[PATCH 1/5] drm: add plane support

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 11:21:18 -0700 Jesse Barnes wrote: > On Wed, 2 Nov 2011 15:33:04 -0700 > Jesse Barnes wrote: > > > On Wed, 2 Nov 2011 13:03:19 -0700 > > Jesse Barnes wrote: > > > > > Planes are a bit like half-CRTCs. They have a location and fb, bu

[PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
, have you been beaten down enough to acquiesce to that? Alan, does this look usable for your stuff? -- Jesse Barnes, Intel Open Source Technology Center -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes D

[Intel-gfx] [PATCH 7/7] drm/i915: Remove trailing white space

2011-11-03 Thread Jesse Barnes
,7 @@ intel_dp_init(struct drm_device *dev, int output_reg) > > cur.t8 = (pp_on & PANEL_LIGHT_ON_DELAY_MASK) >> > PANEL_LIGHT_ON_DELAY_SHIFT; > - > + > cur.t9 = (pp_off & PANEL_LIGHT_OFF_DELAY_MASK) >> >

[Intel-gfx] [PATCH 6/7] drm/i915: Try harder during dp pattern 1 link training

2011-11-03 Thread Jesse Barnes
} > + } else > + voltage_tries = 0; > + voltage = intel_dp->train_set[0] & > DP_TRAIN_VOLTAGE_SWING_MASK; > + } > > /* Compute new intel_dp->train_set as requ

[Intel-gfx] [PATCH 5/7] drm/i915: Make DP prepare/commit consistent with DP dpms

2011-11-03 Thread Jesse Barnes
is_edp(intel_dp) && !is_pch_edp(intel_dp)) > - ironlake_edp_pll_off(encoder); > ironlake_edp_panel_vdd_off(intel_dp, false); > + > + if (is_cpu_edp(intel_dp)) > + ironlake_edp_pll_off(encoder); But here it looks like you're shu

[Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-03 Thread Jesse Barnes
gister until it shows the correct values. Modulo what we already discussed on irc about the PP_READY bit, and the CodingStyle nitpicks (newlines before {? come on, this isn't X :), Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- next part

[PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 13:55:50 -0500 Rob Clark wrote: > On Thu, Nov 3, 2011 at 12:36 PM, Jesse Barnes > wrote: > > On Thu, 3 Nov 2011 18:29:14 +0100 > > Daniel Vetter wrote: > > > >> Hi all, > >> > >> I've discussed this a bit on irc and consens

[Intel-gfx] [PATCH] drm/i915: add SNB video sprite support

2011-11-03 Thread Jesse Barnes
the latest code; I clamp things in the top level function now. But take a look and see if I'm missing one of the cases you cover here. -- Jesse Barnes, Intel Open Source Technology Center -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: applicatio

[PATCH 5/5] drm/i915: add destination color key support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:23 -0700 Jesse Barnes wrote: > Add new ioctls for getting and setting the current destination color > key. This allows for simple overlay display control by matching a color > key value in the primary plane before blending the overlay on top. > > Signe

[PATCH 4/5] drm/i915: add SNB and IVB video sprite support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:22 -0700 Jesse Barnes wrote: > The video sprites support various video surface formats natively and can > handle scaling as well. So add support for them using the new DRM core > overlay support functions. > > Signed-off-by: Jesse Barnes > --- Upda

[PATCH 3/5] drm/i915: rename existing overlay support to "legacy"

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:21 -0700 Jesse Barnes wrote: > The old overlay block has all sorts of quirks and is very different than > ILK+ video sprites. So rename it to legacy to make that clear and clash > less with core overlay support. This one has been dropped. I'm calling thing

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:20 -0700 Jesse Barnes wrote: > To properly support the various plane formats supported by different > hardware, the kernel must know the pixel format of a framebuffer object. > So add a new ioctl taking a format argument corresponding to a fourcc > name from

[PATCH 1/5] drm: add plane support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 15:33:04 -0700 Jesse Barnes wrote: > On Wed, 2 Nov 2011 13:03:19 -0700 > Jesse Barnes wrote: > > > Planes are a bit like half-CRTCs. They have a location and fb, but > > don't drive outputs directly. Add support for handling them to

[PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
g, Inkie, any comment on using fourcc vs rolling our own surface definitions? Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836

[PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 15:11:55 +0100 Daniel Vetter wrote: > On Wed, Nov 02, 2011 at 01:03:18PM -0700, Jesse Barnes wrote: > > In response to feedback, I've adjusted the new addfb2 ioctl to take per > > component pitch and offset args. Generally, the offset[0] field will be

Re: [PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 15:11:55 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Wed, Nov 02, 2011 at 01:03:18PM -0700, Jesse Barnes wrote: In response to feedback, I've adjusted the new addfb2 ioctl to take per component pitch and offset args. Generally, the offset[0] field will be 0, but it's

Re: [PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
fourcc vs rolling our own surface definitions? Thanks, -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [PATCH 1/5] drm: add plane support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 15:33:04 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 2 Nov 2011 13:03:19 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them

Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:20 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc

Re: [PATCH 3/5] drm/i915: rename existing overlay support to legacy

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:21 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: The old overlay block has all sorts of quirks and is very different than ILK+ video sprites. So rename it to legacy to make that clear and clash less with core overlay support. This one has been dropped. I'm

Re: [PATCH 4/5] drm/i915: add SNB and IVB video sprite support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:22 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. Signed-off-by: Jesse Barnes jbar

Re: [PATCH 5/5] drm/i915: add destination color key support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:23 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top

Re: [Intel-gfx] [PATCH] drm/i915: add SNB video sprite support

2011-11-03 Thread Jesse Barnes
in the top level function now. But take a look and see if I'm missing one of the cases you cover here. -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel

Re: [PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 13:55:50 -0500 Rob Clark rob.cl...@linaro.org wrote: On Thu, Nov 3, 2011 at 12:36 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 3 Nov 2011 18:29:14 +0100 Daniel Vetter dan...@ffwll.ch wrote: Hi all, I've discussed this a bit on irc and consensus seems

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-03 Thread Jesse Barnes
register until it shows the correct values. Modulo what we already discussed on irc about the PP_READY bit, and the CodingStyle nitpicks (newlines before {? come on, this isn't X :), Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Make DP prepare/commit consistent with DP dpms

2011-11-03 Thread Jesse Barnes
)) + ironlake_edp_pll_off(encoder); But here it looks like you're shutting it off, then downing the link? Should this be reordered? -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Try harder during dp pattern 1 link training

2011-11-03 Thread Jesse Barnes
, and the DP compliance test should catch any grievous errors, so aside from the bug fix hunk which should be split out: Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Remove trailing white space

2011-11-03 Thread Jesse Barnes
PANEL_LIGHT_ON_DELAY_MASK) PANEL_LIGHT_ON_DELAY_SHIFT; - + cur.t9 = (pp_off PANEL_LIGHT_OFF_DELAY_MASK) PANEL_LIGHT_OFF_DELAY_SHIFT; Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology

Re: [PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
stuff? -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Make DP prepare/commit consistent with DP dpms

2011-11-03 Thread Jesse Barnes
On Thu, 03 Nov 2011 15:30:57 -0700 Keith Packard kei...@keithp.com wrote: On Thu, 3 Nov 2011 13:00:11 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: A few comments on this one (also, is it strictly required to fix your bug)? I think so; the panel definitely was not happy when I

Re: [PATCH 1/5] drm: add plane support

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 11:21:18 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 2 Nov 2011 15:33:04 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 2 Nov 2011 13:03:19 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: Planes are a bit like half-CRTCs. They have

[PATCH 1/5] drm: add plane support

2011-11-02 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:19 -0700 Jesse Barnes wrote: > Planes are a bit like half-CRTCs. They have a location and fb, but > don't drive outputs directly. Add support for handling them to the core > KMS code. Accidentally left out the ->destroy hook in this one. The drm-ove

[PATCH 5/5] drm/i915: add destination color key support

2011-11-02 Thread Jesse Barnes
Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_dma.c |2

[PATCH 4/5] drm/i915: add SNB and IVB video sprite support

2011-11-02 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/i915_reg.h

[PATCH 3/5] drm/i915: rename existing overlay support to "legacy"

2011-11-02 Thread Jesse Barnes
The old overlay block has all sorts of quirks and is very different than ILK+ video sprites. So rename it to legacy to make that clear and clash less with core overlay support. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_debugfs.c |2 +- drivers/gpu/drm/i915/i915_drv.h

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-02 Thread Jesse Barnes
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c

[PATCH 1/5] drm: add plane support

2011-11-02 Thread Jesse Barnes
Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c | 236 +++- drivers/gpu/drm/drm_drv.c

[PATCH] DRM planes

2011-11-02 Thread Jesse Barnes
In response to feedback, I've adjusted the new addfb2 ioctl to take per component pitch and offset args. Generally, the offset[0] field will be 0, but it's conceivable that some metadata could be stored at the start of a given buffer, and an offset[0] allows the client to skip past that.

[Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-02 Thread Jesse Barnes
SEQUENCE_STATE_MASK) > +#define IDLE_ON_VALUE(PP_ON | 0 | PP_SEQUENCE_NONE | 0 >| PP_SEQUENCE_STATE_ON_IDLE) Note that PP_READY will incorrectly depend on some other register values, so in some configs the panel will happily power up even if PP_READY is

[Intel-gfx] [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places

2011-11-02 Thread Jesse Barnes
licated code than fragile code... Reviewed-by: Jesse Barnes But I was curious about this hunk: @@ -766,10 +766,10 @@ intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode, continue; intel_dp = enc_to_intel_dp(encoder); -

[Intel-gfx] [PATCH 2/7] drm/i915: Remove link_status field from intel_dp structure

2011-11-02 Thread Jesse Barnes
On Tue, 1 Nov 2011 23:20:25 -0700 Keith Packard wrote: > No persistent data was ever stored here, so link_status is instead > allocated on the stack as needed. > > Signed-off-by: Keith Packard > --- I like this cleanup. Reviewed-by: Jesse Barnes -- Jesse Barnes, In

[Intel-gfx] [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control

2011-11-02 Thread Jesse Barnes
off-by: Keith Packard > --- > drivers/gpu/drm/i915/intel_dp.c | 37 +++-- > 1 files changed, 19 insertions(+), 18 deletions(-) Can't we just set UNLOCK_REGS at load time and have asserts sprinkled here and there? -- Jesse Barnes, Intel Open Source Technology C

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control

2011-11-02 Thread Jesse Barnes
kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c | 37 +++-- 1 files changed, 19 insertions(+), 18 deletions(-) Can't we just set UNLOCK_REGS at load time and have asserts sprinkled here and there? -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places

2011-11-02 Thread Jesse Barnes
code than fragile code... Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org But I was curious about this hunk: @@ -766,10 +766,10 @@ intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode, continue; intel_dp = enc_to_intel_dp(encoder

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-02 Thread Jesse Barnes
(PP_ON | 0 | PP_SEQUENCE_NONE | 0 | PP_SEQUENCE_STATE_ON_IDLE) Note that PP_READY will incorrectly depend on some other register values, so in some configs the panel will happily power up even if PP_READY isn't set yet... -- Jesse Barnes, Intel Open Source Technology

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Remove link_status field from intel_dp structure

2011-11-02 Thread Jesse Barnes
On Tue, 1 Nov 2011 23:20:25 -0700 Keith Packard kei...@keithp.com wrote: No persistent data was ever stored here, so link_status is instead allocated on the stack as needed. Signed-off-by: Keith Packard kei...@keithp.com --- I like this cleanup. Reviewed-by: Jesse Barnes jbar

[PATCH] DRM planes

2011-11-02 Thread Jesse Barnes
In response to feedback, I've adjusted the new addfb2 ioctl to take per component pitch and offset args. Generally, the offset[0] field will be 0, but it's conceivable that some metadata could be stored at the start of a given buffer, and an offset[0] allows the client to skip past that.

[PATCH 3/5] drm/i915: rename existing overlay support to legacy

2011-11-02 Thread Jesse Barnes
The old overlay block has all sorts of quirks and is very different than ILK+ video sprites. So rename it to legacy to make that clear and clash less with core overlay support. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_debugfs.c |2 +- drivers/gpu

[PATCH 5/5] drm/i915: add destination color key support

2011-11-02 Thread Jesse Barnes
Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915

[PATCH 4/5] drm/i915: add SNB and IVB video sprite support

2011-11-02 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-02 Thread Jesse Barnes
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[PATCH 1/5] drm: add plane support

2011-11-02 Thread Jesse Barnes
Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c | 236 +++- drivers

Re: [PATCH 1/5] drm: add plane support

2011-11-02 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:19 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Accidentally left out the -destroy hook in this one. The drm

[PATCH 4/4] drm/i915: add destination color key support

2011-11-01 Thread Jesse Barnes
Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_dma.c |2 + drivers

Proposal for a low-level Linux display framework

2011-10-31 Thread Jesse Barnes
like the DRM layer, with authentication for rendering clients, an command submission ioctl for acceleration, and memory management, so I expect most of the driver growth to be in DRM in the near future. And I totally agree with Dave about having a kmscon. I really wish someone would imp

Re: Proposal for a low-level Linux display framework

2011-10-31 Thread Jesse Barnes
management, so I expect most of the driver growth to be in DRM in the near future. And I totally agree with Dave about having a kmscon. I really wish someone would implement it so I could have my VTs spinning on a cube. -- Jesse Barnes, Intel Open Source Technology Center signature.asc

[PATCH 01/11] drm: add plane support

2011-10-27 Thread Jesse Barnes
On Wed, 26 Oct 2011 14:40:07 +0900 Joonyoung Shim wrote: > 10/25/2011 06:46 PM, Jesse Barnes ? ?: > > [snip] > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > index 8020798..d7f03aa 100644 > > --- a/include/drm/drm_crtc.h > > +++ b/include/

Re: [PATCH 01/11] drm: add plane support

2011-10-27 Thread Jesse Barnes
On Wed, 26 Oct 2011 14:40:07 +0900 Joonyoung Shim jy0922.s...@samsung.com wrote: 10/25/2011 06:46 PM, Jesse Barnes 쓴 글: [snip] diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8020798..d7f03aa 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h

[PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
Here's a diff I can roll in if it looks ok. It adds the ability to specify multiple handles for a single fb to better accommodate planar configs. I think Rob has convinced me that this is a good idea... comments appreciated. Thanks, Jesse diff --git a/drivers/gpu/drm/drm_crtc.c

[PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 14:26:07 +0100 Alan Cox wrote: > > As discussed with Jesse on irc, drm fb handling is fragile. Current > > rules: > > - fbs are not reference counted, hence when destroying we need to > > disable all crtcs (and now also planes) that use them. > > drm_framebuffer_cleanup does

[PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 13:58:55 +0200 Daniel Vetter wrote: > On Tue, Oct 25, 2011 at 11:46:56AM +0200, Jesse Barnes wrote: > > Planes are a bit like half-CRTCs. They have a location and fb, but > > don't drive outputs directly. Add support for handling them to the &g

[PATCH] drm/i915: add SNB video sprite support

2011-10-25 Thread Jesse Barnes

[PATCH] drm/i915: add SNB video sprite support

2011-10-25 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. v2: collapse patches and fix plane disable vs unpin ordering bug Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915

[Intel-gfx] DRM planes and new fb creation ioctl

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 11:46:55 +0200 Jesse Barnes wrote: > I've given up waiting for someone to implement support for these > ioctls on another platform before they're merged, but I have received > a lot of feedback on the interfaces, and it sounds like they're ok. > I've al

[PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 19:53:02 +0900 Joonyoung Shim wrote: > > +/** > > + * drm_plane - central DRM plane control structure > > + * @dev: DRM device this plane belongs to > > + * @kdev: kernel device > > + * @attr: kdev attributes > > + * @head: for list management > > + * @base: base mode object >

DRM planes and new fb creation ioctl

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 19:47:13 +0900 Joonyoung Shim wrote: > 10/25/2011 06:46 PM, Jesse Barnes ? ?: > > I've given up waiting for someone to implement support for these > > ioctls on another platform before they're merged, but I have > > received a lot of feedback on the inte

[PATCH 11/11] drm/i915: add sprite scaling support

2011-10-25 Thread Jesse Barnes
If the source and destination size are different, try to scale the sprite on the corresponding CRTC. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h |5 + drivers/gpu/drm/i915/intel_overlay2.c | 14 -- 2 files changed, 17 insertions(+), 2 deletions

<    1   2   3   4   5   6   7   8   9   >