Re: [PATCH v2 2/2] drm: panel: nv3052c: Add WL-355608-A8 panel

2024-05-31 Thread Jessica Zhang
igned-off-by: Hironori KIKUCHI Reviewed-by: John Watts Hi Ryan, Acked-by: Jessica Zhang Thanks, Jessica Zhang --- Changelog v1..v2: - Update .compatible string to match dt-binding - Add co-developer sign-off and review tags --- .../gpu/drm/panel/panel-newvision-nv3052c.c

Re: [PATCH v6 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC

2024-05-31 Thread Jessica Zhang
-by: Dmitry Baryshkov Hi Jun, LGTM Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 3 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 3 ++- 3 files

Re: [PATCH v3 6/6] drm/ci: update xfails for the new testlist

2024-05-29 Thread Jessica Zhang
-by: Jessica Zhang # msm test list --- v2: - Set the timeout of all i915 jobs to 1h30m and updated expectations file. v3: - Add a link to the email reporting the flaky tests to the maintainers. --- drivers/gpu/drm/ci/test.yml | 6 +- .../gpu/drm/ci/xfails/amdgpu

Re: [PATCH v3 5/6] drm/ci: skip driver specific tests

2024-05-29 Thread Jessica Zhang
On 5/28/2024 7:40 PM, Vignesh Raman wrote: Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Reviewed-by: Dmitry Baryshkov Signed-off-by: Vignesh Raman Reviewed-by: Jessica Zhang --- v2: - Skip xe tests for amdgpu and virtio. v3

Re: [PATCH v3 2/6] drm/ci: add farm variable

2024-05-29 Thread Jessica Zhang
jobs. Signed-off-by: Vignesh Raman Reviewed-by: Jessica Zhang --- v3: - New commit to add farm variable and update device type variable. --- drivers/gpu/drm/ci/test.yml | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ci/test.yml b/drivers

Re: [PATCH v3 1/6] drm/ci: uprev mesa version

2024-05-29 Thread Jessica Zhang
these scripts for logging. Signed-off-by: Vignesh Raman Hi Vignesh, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- v2: - Uprev to recent version and use id_tokens for JWT authentication v3: - Move adding farm variable and updating device type variable to seperate commit --- drivers

Re: [PATCH 2/2] drm: panel: nv3052c: Add WL-355608-A8 panel

2024-05-29 Thread Jessica Zhang
loped-by: Hironori KIKUCHI Hi Ryan, Thanks for the patch. It LGTM -- will give it another look when you release the v2 with updated compatible string. Thanks, Jessica Zhang --- .../gpu/drm/panel/panel-newvision-nv3052c.c | 225 ++ 1 file changed, 225 insertions(+) diff

Re: [PATCH v2 3/3] drm/panel: sitronix-st7789v: fix display size for jt240mhqs_hwt_ek_e3 panel

2024-05-29 Thread Jessica Zhang
On 5/29/2024 7:42 AM, Gerald Loacker wrote: This is a portrait mode display. Change the dimensions accordingly. Fixes: 0fbbe96bfa08 ("drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support") Signed-off-by: Gerald Loacker Acked-by: Jessica Zhang --- drive

Re: [PATCH v2 2/3] drm/panel: sitronix-st7789v: tweak timing for jt240mhqs_hwt_ek_e3 panel

2024-05-29 Thread Jessica Zhang
ld, Acked-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index 32e5c0348038..c7e3f1280

Re: [PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-28 Thread Jessica Zhang
On 5/27/2024 7:21 AM, Jun Nie wrote: data is valid for only half the active window if widebus is enabled Signed-off-by: Jun Nie Hi Jun, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 9 + 1 file changed, 9 insertions

Re: [PATCH v5 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC

2024-05-28 Thread Jessica Zhang
e only moved to INTF in DPU 7.x and later. We should probably add some MDSS version check similar to what command mode INTF does here [1] Thanks, Jessica Zhang + hsync_data_start_x = hsync_start_x; hsync_data_end_x = hsync_start_x + data_width - 1; -- 2.34.1

Re: [PATCH v5 6/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-05-28 Thread Jessica Zhang
On 5/27/2024 7:21 AM, Jun Nie wrote: From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie Hi Jun, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang ---

Re: [PATCH v5 5/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC

2024-05-28 Thread Jessica Zhang
than Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie Hi Jun, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_ho

Re: [PATCH v5 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-05-28 Thread Jessica Zhang
On 5/27/2024 7:21 AM, Jun Nie wrote: From: Jonathan Marek Add width change in DPU timing for DSC compression case to work with DSI video mode. Hi Jun, LGTM Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm

Re: [PATCH v3 1/3] drm/display: split DSC helpers from DP helpers

2024-05-28 Thread Jessica Zhang
by the separate DRM_DISPLAY_DSC_HELPER Kconfig symbol. Signed-off-by: Dmitry Baryshkov Hi Dmitry, LGTM Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + drivers/gpu/drm/display/Kconfig| 6 ++ drivers/gpu/drm/display/Makefile | 3

Re: [PATCH RESEND 1/3] drm/panel: sitronix-st7789v: fix timing for jt240mhqs_hwt_ek_e3 panel

2024-05-28 Thread Jessica Zhang
taken from the panel specs? If the timing in the original patch was wrong, maybe we need a fixes tag. Acked-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/panel: sitronix-st7789v: Add check for of_drm_get_panel_orientation

2024-05-28 Thread Jessica Zhang
Ni, Acked-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index 88e80fe98112..8b

Re: [PATCH] drm/panel: ili9341: Remove a superfluous else after return

2024-04-29 Thread Jessica Zhang
On 4/29/2024 10:12 AM, Sui Jingfeng wrote: The else clause after the ruturn clause is not useful. Hi Sui, Spelling nit: ruturn --> return Besides that, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/panel/panel-ilitek-ili934

Re: [PATCH 4/6] drm/panel: novatek-nt36672e: stop calling regulator_set_load manually

2024-04-17 Thread Jessica Zhang
On 4/4/2024 3:08 AM, Dmitry Baryshkov wrote: Use .init_load_uA part of the bulk regulator API instead of calling register_set_load() manually. Hi Dmitry, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-novatek

Re: [PATCH v4 2/2] drm/panel: Add driver for EDO RM69380 OLED panel

2024-04-17 Thread Jessica Zhang
On 4/17/2024 9:29 AM, David Wronek wrote: Add support for the 2560x1600@90Hz OLED panel by EDO bundled with a Raydium RM69380 controller, as found on the Lenovo Xiaoxin Pad Pro 2021. Reviewed-by: Dmitry Baryshkov Signed-off-by: David Wronek Hi David, Acked-by: Jessica Zhang Thanks

Re: [PATCH v2 2/2] drm/panel: Add driver for EDO RM69380 OLED panel

2024-04-15 Thread Jessica Zhang
t_gpio; + bool prepared; Hi David, IIRC there's no need for a driver-specific panel::prepared after commit d2aacaf0. Thanks, Jessica Zhang +}; + +static inline +struct rm69380_panel *to_rm69380_panel(struct drm_panel *panel) +{ + return container_of(panel, struct rm69380_panel,

Re: [PATCH v5 2/4] drm/mipi-dsi: use correct return type for the DSC functions

2024-04-09 Thread Jessica Zhang
-by: Jessica Zhang Thanks, Jessica Zhang Fixes: f4dea1aaa9a1 ("drm/dsi: add helpers for DSI compression mode and PPS packets") Reviewed-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_mipi_dsi.c | 6 +++--- include/drm/drm_mipi_dsi.h | 6 +++--- 2 files

Re: [PATCH 2/6] drm/panel: novatek-nt36682e: don't unregister DSI device

2024-04-05 Thread Jessica Zhang
river") Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c index cb

Re: [PATCH 1/6] drm/panel: visionox-rm69299: don't unregister DSI device

2024-04-05 Thread Jessica Zhang
On 4/4/2024 3:07 AM, Dmitry Baryshkov wrote: The DSI device for the panel was registered by the DSI host, so it is an error to unregister it from the panel driver. Drop the call to mipi_dsi_device_unregister(). Hi Dmitry, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Fixes

Re: [PATCH 4/4] drm/panel: simple: Add Innolux G121XCE-L01 LVDS display support

2024-03-29 Thread Jessica Zhang
/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf [2] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121XCE-L01_Datasheet.pdf Hi Marek, Acked-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter

Re: [PATCH 3/4] drm/panel: simple: Convert Innolux G121X1-L03 to display_timing

2024-03-29 Thread Jessica Zhang
documentation [1] section 6.1 INPUT SIGNAL TIMING SPECIFICATIONS. [1] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf Hi Marek, Acked-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc

Re: [PATCH 2/4] drm/panel: simple: Add missing Innolux G121X1-L03 format, flags, connector

2024-03-29 Thread Jessica Zhang
://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf Hi Marek, Acked-by: Jessica Zhang Thanks, Jessica Zhang Fixes: f8fa17ba812b ("drm/panel: simple: Add support for Innolux G121X1-L03") Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter

Re: [PATCH 3/5] drm/panel: st7703: Add GameForce Chi Panel Support

2024-03-27 Thread Jessica Zhang
On 3/25/2024 6:49 AM, Chris Morgan wrote: From: Chris Morgan The GameForce Chi is a handheld device with a 3.5" 640x480 ST7703 based display panel. Hi Chris, Acked-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-sitronix-s

Re: [PATCH] drm/panel: replace utf multiply with an ascii x

2024-03-25 Thread Jessica Zhang
On 3/23/2024 12:40 AM, Prasad Pandit wrote: On Fri, 22 Mar 2024 at 20:54, Jessica Zhang wrote: Seems that this also happens in 2 other Kconfig entries. Can you replace those as well? * Yes, I've sent a revised patch. Acked, thanks! Thank you. --- - Prasad

Re: [PATCH v1] drm/panel: replace utf multiply with an ascii x

2024-03-25 Thread Jessica Zhang
On 3/23/2024 12:39 AM, Prasad Pandit wrote: From: Prasad Pandit Replace unicode multiplication character with an ascii x. It helps Kconfig parsers to read file without error. Hi Prasad, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Fixes: 25205087df1f ("drm/panel: Add d

Re: [PATCH] drm/panel: replace utf multiply with an ascii x

2024-03-22 Thread Jessica Zhang
, Jessica Zhang Fixes: 25205087df1f ("drm/panel: Add driver for JDI LPM102A188A") Signed-off-by: Prasad Pandit --- drivers/gpu/drm/panel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 8f

Re: [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags

2024-03-20 Thread Jessica Zhang
. Other DSI drivers might handle this differently, so add the flag. Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant") Signed-off-by: Heiko Stuebner Hi Heiko, Acked-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/p

Re: [PATCH 2/2] drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry

2024-03-18 Thread Jessica Zhang
On 3/18/2024 9:17 AM, Nathan Morrisson wrote: Add support for the POWERTIP PH128800T006-ZHC01 10.1" (1280x800) LCD-TFT panel. Signed-off-by: Nathan Morrisson Hi Nathan, Acked-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-simple.c

Re: [PATCH] drm/panel: atna33xc20: Fix unbalanced regulator in the case HPD doesn't assert

2024-03-14 Thread Jessica Zhang
} + } else if (p->aux->wait_hpd_asserted) { Hi Doug, Acked-by: Jessica Zhang Thanks, Jessica Zhang ret = p->aux->wait_hpd_asserted(p->aux, HPD_MAX_US); - if (ret) + if (ret) { dev_warn(dev, "Controller error waiting fo

Re: [PATCH 2/8] drm/panel: do not return negative error codes from drm_panel_get_modes()

2024-03-08 Thread Jessica Zhang
it to other counts leading to bogus values. On the other hand, many of the struct drm_panel_funcs .get_modes() hooks do return negative error codes, so handle them gracefully instead of propagating further. Return 0 for no modes, whatever the reason. Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam

Re: [PATCH v2 1/2] drm: panel: st7701: Add Hardkernel ODROID-GO Ultra panel support

2024-02-29 Thread Jessica Zhang
On 2/29/2024 9:23 AM, Adam Green wrote: On 26/02/2024 21:29, Jessica Zhang wrote: > Got it. Was the shorter sleep time breaking the display and is it > required for the new panel to work? > > Thanks, > > Jessica Zhang Hi Jessica, I will be submitting a v3 s

Re: [PATCH 2/3] drm/panel: add samsung s6e3fa7 panel driver

2024-02-28 Thread Jessica Zhang
On 2/9/2024 3:17 PM, Richard Acayan wrote: On Thu, Feb 08, 2024 at 05:34:57PM -0800, Jessica Zhang wrote: On 2/8/2024 4:16 PM, Richard Acayan wrote: The S6E3FA7 display controller is enabled in every Pixel 3a (non-XL) variant. Add the driver for it, generated by linux-mdss-dsi-panel-driver

Re: [PATCH RFC 0/4] Support for Simulated Panels

2024-02-28 Thread Jessica Zhang
ward. Hi Maxime and Daniel, For our current sim panel requirements, we can go with implementing the configfs first then add ebpf if requirements get more complex. Thanks, Jessica Zhang Maxime

Re: [PATCH 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support

2024-02-26 Thread Jessica Zhang
On 2/23/2024 5:45 AM, Jérémie Dautheribes wrote: Add support for Crystal Clear Technology CMT430B19N00 4.3" 480x272 TFT-LCD panel. Signed-off-by: Jérémie Dautheribes Hi Jérémie, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-simple.c

Re: [PATCH v2 1/2] drm: panel: st7701: Add Hardkernel ODROID-GO Ultra panel support

2024-02-26 Thread Jessica Zhang
On 2/22/2024 9:47 AM, Adam Green wrote: On 22/02/2024 17:14, Jessica Zhang wrote: Hi Adam, Just wondering, why the change to 120 here? Thanks, Jessica Zhang Hi, The 120ms is taken from the datasheet specification for the controller as maximum time it takes for the display to reset

Re: [PATCH v2 1/2] drm: panel: st7701: Add Hardkernel ODROID-GO Ultra panel support

2024-02-22 Thread Jessica Zhang
ies); if (ret < 0) return ret; - msleep(20); + msleep(120); Hi Adam, Just wondering, why the change to 120 here? Thanks, Jessica Zhang gpiod_set_value(st7701->reset, 1); msleep(150); @@ -875,6 +931,105 @@ static const struct st7701_panel_desc kd50t

Re: [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first

2024-02-16 Thread Jessica Zhang
ot; as has been done for many other DSI panels. Fixes: 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset") Signed-off-by: Douglas Anderson Hi Doug, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- This of course gets into debates about getting

Re: [PATCH 3/3] drm/panel: ltk500hd1829: add panel type for ltk101b4029w

2024-02-15 Thread Jessica Zhang
Stuebner Hi Heiko, Acked-by: Jessica Zhang Thanks, Jessica Zhang --- .../drm/panel/panel-leadtek-ltk500hd1829.c| 196 ++ 1 file changed, 196 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829

Re: [PATCH 1/3] drm/panel: ltk500hd1829: make room for more similar panels

2024-02-15 Thread Jessica Zhang
panel. Signed-off-by: Heiko Stuebner Hi Heiko, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- .../drm/panel/panel-leadtek-ltk500hd1829.c| 73 --- 1 file changed, 47 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c b

Re: [PATCH 2/7] drm/panel: st7703: Add Powkiddy RGB10MAX3 Panel Support

2024-02-12 Thread Jessica Zhang
-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 91 +++ 1 file changed, 91 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c index b55bafd1a8be..939ba05c9b58 100644

Re: [PATCH 2/3] drm/panel: add samsung s6e3fa7 panel driver

2024-02-08 Thread Jessica Zhang
iver for the Samsung S6E3FA7 panel. + * + * Copyright (c) 2022-2024, The Linux Foundation. All rights reserved. Hi Richard, Not really sure about the copyright dates -- since this is a completely new file to this tree, wouldn't the year be just 2024? The rest LGTM. Thanks, Jessica Z

Re: [PATCH 5/5] drm/panel: simple: push blanking limit on RK32FN48H

2024-02-06 Thread Jessica Zhang
On 2/5/2024 1:26 AM, Raphael Gallais-Pou wrote: Push horizontal front porch and vertical back porch blanking limit. This allows to get a 60 fps sharp. Signed-off-by: Raphael Gallais-Pou Hi Raphael, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel

Re: [PATCH 4/5] drm/panel: simple: fix flags on RK043FN48H

2024-02-06 Thread Jessica Zhang
by the positive edge it makes sense to add it here. Signed-off-by: Raphael Gallais-Pou Hi Raphael, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-simple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH] drm/panel: visionox-r66451: Set prepare_prev_first flag

2024-02-02 Thread Jessica Zhang
The DSI host needs to be enabled for the panel to be initialized in prepare(). Ensure this happens by setting prepare_prev_first. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-r66451.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel

[PATCH] dt-bindings: visionox-rm69299: Update maintainers

2024-02-02 Thread Jessica Zhang
The current maintainer (Harigovindan P) is no longer reachable through the listed email. Update maintainers list to be Abhinav and I. Signed-off-by: Jessica Zhang --- Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

2024-02-01 Thread Jessica Zhang
The DSI host must be enabled for the panel to be initialized in prepare(). Set the prepare_prev_first flag to guarantee this. Signed-off-by: Jessica Zhang --- To: Neil Armstrong To: Sam Ravnborg To: David Airlie To: Daniel Vetter To: Jessica Zhang To: Maarten Lankhorst To: Maxime Ripard

Re: [PATCH] drm/panel: novatek-nt36523: Set prepare_prev_first

2024-02-01 Thread Jessica Zhang
On 2/1/2024 2:17 PM, Konrad Dybcio wrote: The .prepare callback contains the init sequence, so the DSI host *must* be enabled at that point. Set the prepare_prev_first flag to ensure that. Signed-off-by: Konrad Dybcio Hi Konrad, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang

Re: [PATCH RFC for upstream 2/4] drm/panel: simple: Add EDT ETML1010G3DRA panel

2024-01-26 Thread Jessica Zhang
S.pdf Signed-off-by: Primoz Fiser Signed-off-by: Yannic Moog Hi Yannic, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-simple.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/driver

[PATCH RFC 2/4] drm/dsi: Add API to register simulated DSI panel

2024-01-16 Thread Jessica Zhang
Add new APIs to register a simulated panel. For drivers that want to support a simulated panel, they must call mipi_dsi_host_register_sim_panel(). Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_mipi_dsi.c | 30 ++ include/drm/drm_mipi_dsi.h | 1 + 2 files

[PATCH RFC 4/4] drm/msm/dsi: Add simulated panel support

2024-01-16 Thread Jessica Zhang
Introduce the sim_panel_enabled module parameter. When set, this parameter will force DSI to select the simulated panel instead of the physical panel. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi.c | 4 drivers/gpu/drm/msm/dsi/dsi_host.c| 9 - drivers

[PATCH RFC 1/4] drm/panel: add driver for simulated panel

2024-01-16 Thread Jessica Zhang
Add a driver for simulating panels. This module also supports a mode parameter for users to specify a custom mode. If no custom mode is set, it will fall back to a custom, hard-coded mode. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/panel/Kconfig| 9 ++ drivers/gpu/drm/panel

[PATCH RFC 3/4] drm/panel: Introduce simulated panel bridge API

2024-01-16 Thread Jessica Zhang
Add separate bridge and drm_panel API for getting the simulated panel. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/bridge/panel.c | 24 drivers/gpu/drm/drm_panel.c| 33 + include/drm/drm_bridge.h | 1 + include/drm

[PATCH RFC 0/4] Support for Simulated Panels

2024-01-16 Thread Jessica Zhang
(such as configuring DSC, dual DSI, etc.). --- Jessica Zhang (4): drm/panel: add driver for simulated panel drm/dsi: Add API to register simulated DSI panel drm/panel: Introduce simulated panel bridge API drm/msm/dsi: Add simulated panel support drivers/gpu/drm/bridge/panel.c

Re: [PATCH] drm/panel: nt36523: Set 120Hz fps for xiaomi, elish panels

2024-01-12 Thread Jessica Zhang
On 1/12/2024 6:00 AM, Jianhua Lu wrote: After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock limits") merged, 120Hz is working on xiaomi,elish panels, so feature it. Signed-off-by: Jianhua Lu Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/pan

Re: [v2 2/2] drm/panel: Add support for Novatek NT36672E panel driver

2024-01-11 Thread Jessica Zhang
On 1/8/2024 1:59 AM, Ritesh Kumar wrote: Add support for the 1080x2408 Novatek NT36672E video mode DSI panel driver. Signed-off-by: Ritesh Kumar Reviewed-by: Jessica Zhang --- v2: Fixed review comments from Krzysztof - renamed the panel driver file to reflect

Re: [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode for waveshare 7inch touchscreen panel

2024-01-09 Thread Jessica Zhang
tself LGTM, but in case you have to put out a new revision, can you please use the "drm/panel: :" prefix format that other drm/panel commits use? Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: Keith Zhao Signed-off-by: Shengyang Chen --- drivers/gpu/drm/panel

Re: [PATCH v3 2/4] drm/panel: Add driver for BOE TH101MB31IG002-28A panel

2024-01-08 Thread Jessica Zhang
mipi_dsi_dcs_write_seq(dsi, 0x00, 0xFF, 0x87, 0x12, 0x34, 0x44, 0x44, + 0x44, 0x44, 0x98, 0x04, 0x98, 0x04, 0x0F, + 0x00, 0x00, 0xC1); Hi Manuel, (I'm assuming the `0x00` here is not MIPI_DCS_NOP) Reviewed-by: Jes

Re: [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe()

2024-01-03 Thread Jessica Zhang
On 1/3/2024 6:17 AM, chenguanxi11...@163.com wrote: From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan Reviewed-by: Jessica Zhang --- drivers/gpu

Re: [PATCH linux-next v2] drm/panel: Simplify with dev_err_probe()

2024-01-03 Thread Jessica Zhang
On 12/25/2023 6:26 AM, chenguanxi11...@163.com wrote: From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan Reviewed-by: Jessica Zhang --- drivers/gpu

Re: [PATCH 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02

2024-01-02 Thread Jessica Zhang
. Signed-off-by: Artur Weber Hi Artur, With Henrik's suggestion to add the Fixes tag, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung

Re: [PATCH v2 2/4] drm/panel: Add driver for BOE TH101MB31IG002-28A panel

2023-12-26 Thread Jessica Zhang
er correctly, commit d2aacaf07395bd798373cbec6af05fff4147aff3 should have introduced prepared/enabled do the drm_panel struct. Thanks, Jessica Zhang + + struct mipi_dsi_device *dsi; + + struct regulator *power; + struct gpio_desc *enable; + struct gpio_desc *reset; + + enum d

Re: [PATCH 2/6] drm/panel: Add driver for BOE TH101MB31IG002-28A panel

2023-12-26 Thread Jessica Zhang
+#include + +struct boe_th101mb31ig002 { + struct drm_panel panel; + bool enabled; + bool prepared; Hi Manuel, If I remember correctly, commit d2aacaf07395bd798373cbec6af05fff4147aff3 should have introduced prepared/enabled do the drm_panel struct. Thanks, Jessica Zhan

Re: [PATCH linux-next] drm/panel: Simplify with dev_err_probe()

2023-12-20 Thread Jessica Zhang
On 12/19/2023 6:48 PM, yang.gua...@zte.com.cn wrote: From: Yang Guang dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan Reviewed-by: Jessica Zhang Thanks, Jessica

[PATCH v4 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Jessica Zhang
_util") Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 4 ++-- d

[PATCH v4 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface") Signed-off-by: Jessica Zhang --- drivers/g

[PATCH v4 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-13 Thread Jessica Zhang
-fixup-v1-0-585c54cd0...@quicinc.com --- Jessica Zhang (2): drm/msm/dpu: Set input_sel bit for INTF drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr() drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4

Re: [PATCH v2 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
On 12/13/2023 1:20 PM, Dmitry Baryshkov wrote: On Wed, 13 Dec 2023 at 22:51, Jessica Zhang wrote: Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d (&quo

[PATCH v3 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface") Signed-off-by: Jessica Zhang --- drivers/g

[PATCH v3 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-13 Thread Jessica Zhang
: - Switched patch order - Changed input_sel parameter from bool to u8 - Link to v1: https://lore.kernel.org/r/20231130-encoder-fixup-v1-0-585c54cd0...@quicinc.com --- Jessica Zhang (2): drm/msm/dpu: Set input_sel bit for INTF drm/msm/dpu: Drop enable and frame_count parameters from

[PATCH v3 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Jessica Zhang
_util") Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 4 ++-- d

Re: [PATCH v2 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Jessica Zhang
On 12/13/2023 1:00 PM, Abhinav Kumar wrote: On 12/13/2023 12:51 PM, Jessica Zhang wrote: Drop the enable and frame_count parameters from dpu_hw_setup_misr() as they are always set to the same values. In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as frame_count

[PATCH v2 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Jessica Zhang
_util") Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 4 ++-- d

[PATCH v2 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface") Signed-off-by: Jessica Zhang --- drivers/g

[PATCH v2 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-13 Thread Jessica Zhang
-585c54cd0...@quicinc.com --- Jessica Zhang (2): drm/msm/dpu: Set input_sel bit for INTF drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr() drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- drivers/gpu

Re: [PATCH 2/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
On 12/2/2023 11:54 AM, Dmitry Baryshkov wrote: On 01/12/2023 23:29, Abhinav Kumar wrote: On 11/30/2023 11:36 PM, Dmitry Baryshkov wrote: On Fri, 1 Dec 2023 at 03:31, Jessica Zhang wrote: Set the input_sel bit for encoders as it was missed in the initial implementation. Reported

Re: [PATCH] drm/panel: ltk050h3146w: Set burst mode for ltk050h3148w

2023-12-13 Thread Jessica Zhang
DSI_MODE_VIDEO_BURST as part of the mode_flags for the dsi host. Fixes: 93e82bb4de01 ("drm/bridge: synopsys: dw-mipi-dsi: Fix hcomponent lbcc for burst mode") Signed-off-by: Farouk Bouabid Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-leadtek-

Re: [Freedreno] [PATCH 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-12 Thread Jessica Zhang
On 11/30/2023 11:39 PM, Dmitry Baryshkov wrote: On Fri, 1 Dec 2023 at 03:31, Jessica Zhang wrote: This series drops the frame_count and enable parameters (as they're always set to the same value). It also sets input_sel=0x1 for INTF. Signed-off-by: Jessica Zhang --- Jessica Zhang (2

Re: [PATCH v2] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread Jessica Zhang
any of the regexes: 'pinctrl-[0-9]+' From schema: Documentation/devicetree/bindings/display/panel/panel-simple.yaml ``` Fixes: 310abcea76e9 ("dt-bindings: display: convert simple lg panels to DT Schema") Signed-off-by: David Heidelberg Acked-by: Jessica Zhang --- v2: added

Re: [PATCH] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread Jessica Zhang
: 'pinctrl-[0-9]+' From schema: Documentation/devicetree/bindings/display/panel/panel-simple.yaml ``` Hi David, Would "Fixes: 310abcea76e9 ("dt-bindings: display: convert simple lg panels to DT Schema")" be appropriate here? Thanks, Jessica Zhang Signed-off-

Re: [PATCH v2 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2023-12-07 Thread Jessica Zhang
G0_DATABUS_WIDEN; Hi Jonathan, Now that widebus is enabled for video mode, I think you can also drop the TODO here [1]. Other than that, this LGTM. Reviewed-by: Jessica Zhang Thanks, Jessica Zhang [1] https://elixir.bootlin.com/linux/v6.7-rc3/source/drivers/gpu/drm/msm/dsi

Re: [PATCH v2 5/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2023-12-07 Thread Jessica Zhang
_dsi.h index c9df0407980c..3e32fa52d94b 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -193,6 +193,7 @@ struct mipi_dsi_device { unsigned long hs_rate; unsigned long lp_rate; struct drm_dsc_config *dsc; Any reason for not putting thi

Re: [PATCH v3 08/13] drm/msm/dpu: remove QoS teardown on plane destruction

2023-12-01 Thread Jessica Zhang
On 7/29/2023 6:19 PM, Dmitry Baryshkov wrote: There is little point in disabling QoS on plane destruction: it happens during DPU device destruction process, after which there will be no running planes. Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm

Re: [PATCH v3 13/13] drm/msm/dpu: use drmm-managed allocation for dpu_encoder_virt

2023-12-01 Thread Jessica Zhang
on encoder destruction. Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 50 + 1 file changed, 10 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm

Re: [Freedreno] [PATCH v3 01/13] drm/msm/dpu: cleanup dpu_kms_hw_init error path

2023-12-01 Thread Jessica Zhang
On 7/29/2023 6:19 PM, Dmitry Baryshkov wrote: It was noticed that dpu_kms_hw_init()'s error path contains several labels which point to the same code path. Replace all of them with a single label. Suggested-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang

Re: [PATCH v3 05/13] drm/msm/dpu: use devres-managed allocation for MDP TOP

2023-12-01 Thread Jessica Zhang
On 8/16/2023 12:27 AM, Dmitry Baryshkov wrote: Hi Jessica, On Tue, 15 Aug 2023 at 23:17, Jessica Zhang wrote: On 7/29/2023 6:19 PM, Dmitry Baryshkov wrote: Use devm_kzalloc to create MDP TOP structure. This allows us to remove corresponding kfree and drop dpu_hw_mdp_destroy() function

[PATCH 2/2] drm/msm/dpu: Set input_sel bit for INTF

2023-11-30 Thread Jessica Zhang
Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface") Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Signed-off-by: Jessica Zhang --- drivers/g

[PATCH 1/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-11-30 Thread Jessica Zhang
_util") Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/d

[PATCH 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-11-30 Thread Jessica Zhang
This series drops the frame_count and enable parameters (as they're always set to the same value). It also sets input_sel=0x1 for INTF. Signed-off-by: Jessica Zhang --- Jessica Zhang (2): drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr() drm/msm/dpu: Set

Re: [PATCH V2 2/5] drm/panel-elida-kd35t133: hold panel in reset for unprepare

2023-11-17 Thread Jessica Zhang
the panel in reset status after it is unprepared, this does not happen. Fixes: 5b6603360c12 ("drm/panel: add panel driver for Elida KD35T133 panels") Signed-off-by: Chris Morgan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 ++ 1 file changed, 2

Re: [PATCH 2/4] drm/panel-elida-kd35t133: hold panel in reset for unprepare

2023-11-16 Thread Jessica Zhang
On 11/16/2023 7:17 AM, Chris Morgan wrote: On Wed, Nov 15, 2023 at 01:38:11PM -0800, Jessica Zhang wrote: On 11/15/2023 7:26 AM, Chris Morgan wrote: From: Chris Morgan For devices like the Anbernic RG351M and RG351P the panel is wired to an always on regulator. When the device suspends

Re: [PATCH V3 3/6] nv3051d: Add Powkiddy RK2023 Panel Support

2023-11-15 Thread Jessica Zhang
of these panels are identical in size (70x57) it is possible future panels may not be. Tested on my RG351V, RG353P, RG353V, and RK2023. Signed-off-by: Chris Morgan Reviewed-by: Jessica Zhang --- .../gpu/drm/panel/panel-newvision-nv3051d.c | 55 +++ 1 file changed, 44

Re: [PATCH V3 2/6] drm/panel: nv3051d: Hold panel in reset for unprepare

2023-11-15 Thread Jessica Zhang
Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c index 79de6c886292..c44c6945662f 100644 --- a/drivers/gpu/drm/p

Re: [PATCH V2 2/4] nv3051d: Add Powkiddy RK2023 Panel Support

2023-11-15 Thread Jessica Zhang
->reset_gpio, 1); + Hi Chris, Is this to address a suspend/resume issue similar to what was done here [1]? If so, I think maybe this can go as a separate Fixes patch. Thanks, Jessica Zhang [1] https://patchwork.freedesktop.org/patch/567670/?series=126479=1 regulator_disable(ctx-&

Re: [PATCH 4/4] drm/panel-elida-kd35t133: Drop prepare/unprepare logic

2023-11-15 Thread Jessica Zhang
to drop shutdown(). Thanks, Jessica Zhang [1] d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel") Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 28 1 file changed, 28 deletions(-) diff --git a/d

Re: [PATCH 3/4] drm/panel-elida-kd35t133: drop drm_connector_set_orientation_from_panel

2023-11-15 Thread Jessica Zhang
On 11/15/2023 7:26 AM, Chris Morgan wrote: From: Chris Morgan Stop calling drm_connector_set_orientation_from_panel() as its now called by the panel bridge directly when it is initialized. Signed-off-by: Chris Morgan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-elida

  1   2   3   4   5   6   7   >