WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() - evildoer found and neutralized

2015-10-06 Thread Jiang Liu
On 2015/10/5 18:03, Joerg Roedel wrote: > Hi Jiang, > > On Sat, Oct 03, 2015 at 03:36:35PM +0800, Jiang Liu wrote: >> So to summary, I think we only need following change to fix the >> regression: >> int pcibios_alloc_irq(struct pci_dev *dev) >> { &g

WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() - evildoer found and neutralized

2015-10-03 Thread Jiang Liu
On 2015/10/1 1:36, Borislav Petkov wrote: > On Thu, Oct 01, 2015 at 01:00:44AM +0800, Jiang Liu wrote: >> Thanks Joerg, that makes sense. If some driver tries to binding to >> the IOMMU device, it will trigger the scenario as you described. For >> example, Xen backend dri

WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() - evildoer found and neutralized

2015-10-01 Thread Jiang Liu
On 2015/9/30 20:44, Joerg Roedel wrote: > On Wed, Sep 30, 2015 at 03:45:39PM +0800, Jiang Liu wrote: >> So we need to figure out why we got irq number 0 after enabling >> MSI for AMD IOMMU device. The only hint I got is that iommu driver just >> grabbing the PCI device wi

WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() - evildoer found and neutralized

2015-09-30 Thread Jiang Liu
n 2015/9/29 18:51, Borislav Petkov wrote: > On Tue, Sep 29, 2015 at 04:50:36PM +0800, Jiang Liu wrote: >> So could you please help to apply the attached debug patch to gather >> more information about the regression? > > Sure, just did. > > I'm sending you a full s/

WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() - evildoer found and neutralized

2015-09-29 Thread Jiang Liu
f f*cking up the box much earlier. Once I reverted > the bad commit by hand (it wouldn't revert cleanly) the resume splats > showed. > > And in talking about the bad commit, it is this one: > > 991de2e59090e55c65a7f59a049142e3c480f7bd is the first bad commit > commit 991de2e59090e55c65a

[PATCH] nouveau, ACPI: fix regression caused by b072e53

2014-02-21 Thread Jiang Liu
Thanks, Rafael. Will cc ACPI maillist next time. On 2014/2/21 4:27, Rafael J. Wysocki wrote: > On 2/20/2014 10:23 AM, Jiang Liu wrote: >> Fix regression caused by commit b072e53, which breaks loading nouveau >> driver on optimus laptops. >> >> On some

[PATCH] nouveau, ACPI: fix regression caused by b072e53

2014-02-20 Thread Jiang Liu
implementation to check availability of _DSM functions instead of using common acpi_check_dsm() interface. Reported-and-Tested-by: Maarten Lankhorst Signed-off-by: Jiang Liu --- drivers/gpu/drm/nouveau/nouveau_acpi.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff

[PATCH] nouveau, ACPI: fix regression caused by b072e53

2014-02-19 Thread Jiang Liu
On 2014/2/19 18:12, Maarten Lankhorst wrote: > op 19-02-14 05:53, Jiang Liu schreef: >> On some platforms, ACPI _DSM method (nouveau_op_dsm_muid, function 0) >> has special requirements on the fourth parameter, which is different >> from ACPI specifications. So

[PATCH] nouveau, ACPI: fix regression caused by b072e53

2014-02-19 Thread Jiang Liu
in it */ - if (nouveau_optimus_dsm(handle, 0, 0, ) + if (nouveau_optimus_dsm(handle, 0, 0, )) return 0; On 2014/2/19 12:53, Jiang Liu wrote: > On some platforms, ACPI _DSM method (nouveau_op_dsm_muid, function 0) > has special requirements on the fourth parameter, which is different >

[PATCH] nouveau, ACPI: fix regression caused by b072e53

2014-02-19 Thread Jiang Liu
. Signed-off-by: Jiang Liu --- Hi Maarten, Thanks for bisecting. Could you please help to verify whether this patch fixes the regression? Thanks! Gerry --- drivers/gpu/drm/nouveau/nouveau_acpi.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git

[Patch v2 13/13] ACPI, nouveau: replace open-coded _DSM specific code with helper functions

2013-12-19 Thread Jiang Liu
Use helper functions to simplify _DSM related code in nouveau driver. After analyzing the ACPI _DSM related code, I changed nouveau_optimus_dsm() to expect a buffer and nouveau_dsm() to expect an integer only. Signed-off-by: Jiang Liu --- drivers/gpu/drm/nouveau/core/subdev/mxm/base.c | 48

[Patch v2 12/13] nouveau: fix memory leak in ACPI _DSM related code

2013-12-19 Thread Jiang Liu
Fix memory leak in function nouveau_optimus_dsm() and nouveau_dsm(). Signed-off-by: Jiang Liu --- drivers/gpu/drm/nouveau/nouveau_acpi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c b/drivers/gpu/drm/nouveau/nouveau_acpi.c

[Patch v2 11/13] ACPI, i915: replace open-coded _DSM specific code with helper functions

2013-12-19 Thread Jiang Liu
and is useless for i915 driver, so remove it. Acked-by: Daniel Vetter Signed-off-by: Jiang Liu --- drivers/gpu/drm/i915/intel_acpi.c | 144 - 1 file changed, 30 insertions(+), 114 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_acpi.c b/drivers/gpu/drm/i915

[RFC Patch v1 13/13] ACPI, nouveau: replace open-coded _DSM specific code with helper functions

2013-12-18 Thread Jiang Liu
Use helper functions to simplify _DSM related code in nouveau driver. After analyzing the ACPI _DSM related code, I changed nouveau_optimus_dsm() to expect a buffer and nouveau_dsm() to expect an integer only. Signed-off-by: Jiang Liu --- drivers/gpu/drm/nouveau/core/subdev/mxm/base.c | 48

[RFC Patch v1 12/13] nouveau: fix memory leak in ACPI _DSM related code

2013-12-18 Thread Jiang Liu
Fix memory leak in function nouveau_optimus_dsm() and nouveau_dsm(). Signed-off-by: Jiang Liu --- drivers/gpu/drm/nouveau/nouveau_acpi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c b/drivers/gpu/drm/nouveau/nouveau_acpi.c

[RFC Patch v1 11/13] ACPI, i915: replace open-coded _DSM specific code with helper functions

2013-12-18 Thread Jiang Liu
and is useless for i915 driver, so remove it. Signed-off-by: Jiang Liu --- drivers/gpu/drm/i915/intel_acpi.c | 144 - 1 file changed, 30 insertions(+), 114 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_acpi.c b/drivers/gpu/drm/i915/intel_acpi.c index dfff090

[PATCH v3, part2 14/20] PCI, DRM: use hotplug-safe iterators to walk PCI buses

2013-05-27 Thread Jiang Liu
Enhance DRM drvier to use hotplug-safe iterators to walk PCI buses. Signed-off-by: Jiang Liu Cc: David Airlie Cc: dri-devel at lists.freedesktop.org Cc: linux-kernel at vger.kernel.org --- drivers/gpu/drm/drm_fops.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v3, part2 14/20] PCI, DRM: use hotplug-safe iterators to walk PCI buses

2013-05-26 Thread Jiang Liu
Enhance DRM drvier to use hotplug-safe iterators to walk PCI buses. Signed-off-by: Jiang Liu jiang@huawei.com Cc: David Airlie airl...@linux.ie Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org --- drivers/gpu/drm/drm_fops.c | 6 -- 1 file changed, 4 insertions(+), 2

[RFC PATCH v2, part 2 13/18] PCI, DRM: use hotplug-safe iterators to walk PCI buses

2013-05-15 Thread Jiang Liu
Enhance DRM drvier to use hotplug-safe iterators to walk PCI buses. Signed-off-by: Jiang Liu Cc: David Airlie Cc: dri-devel at lists.freedesktop.org Cc: linux-kernel at vger.kernel.org --- drivers/gpu/drm/drm_fops.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[RFC PATCH v2, part 2 13/18] PCI, DRM: use hotplug-safe iterators to walk PCI buses

2013-05-15 Thread Jiang Liu
Enhance DRM drvier to use hotplug-safe iterators to walk PCI buses. Signed-off-by: Jiang Liu jiang@huawei.com Cc: David Airlie airl...@linux.ie Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org --- drivers/gpu/drm/drm_fops.c | 6 -- 1 file changed, 4 insertions(+), 2