Re: [PATCH v6 0/7] Adds support for ConfigFS to VKMS!

Sima--thanks SO MUCH for going through with everything leaving a detailed review. I am excited to go through your feedback. It makes me extremely happy to see these patches get people excited. They've bounced between a few people, and I recently asked to take them over again from the folks who we

Re: [PATCH] drm/vkms Add hotplug support via configfs to VKMS.

Yay! Glad to see the configfs stuff being extended! Overall I don't see anything of major concern. Great stuff! I'd be curious about how the IGT tests would look for this. Creating before and after registration would be sufficient until removal is added. On Thu, Jul 6, 2023 at 1:08 AM Brandon Po

[PATCH v2 6/6] drm/vkms: Add a module param to enable/disable the default device

backwards compatibility. Signed-off-by: Jim Shargo --- drivers/gpu/drm/vkms/vkms_drv.c | 44 ++--- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 314a04659c5f..1cb56c090a65 100644

[PATCH v2 5/6] drm/vkms: Support enabling ConfigFS devices

VKMS now supports creating and using virtual devices! In addition to the enabling logic, this commit also prevents users from adding new objects once a card is registered. Signed-off-by: Jim Shargo --- drivers/gpu/drm/vkms/vkms_configfs.c | 37 +++-- drivers/gpu/drm/vkms/vkms_crtc.c | 4

[PATCH v2 3/6] drm/vkms: Provide platform data when creating VKMS devices

This is a small refactor to make ConfigFS support easier. This should be a no-op refactor. Signed-off-by: Jim Shargo --- drivers/gpu/drm/vkms/vkms_drv.c| 13 +++-- drivers/gpu/drm/vkms/vkms_drv.h| 9 ++--- drivers/gpu/drm/vkms/vkms_output.c | 2 +- 3 files changed, 18

[PATCH v2 4/6] drm/vkms: Add ConfigFS scaffolding to VKMS

according to your configuration. For now, this will fail, but the next change will add support for it. Signed-off-by: Jim Shargo --- Documentation/gpu/vkms.rst | 17 +- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/vkms/Makefile| 1 + drivers/gpu/drm/vkms/vkm

[PATCH v2 2/6] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

ever one CRTC, this should be a no-op refactor. Signed-off-by: Jim Shargo --- drivers/gpu/drm/vkms/vkms_composer.c | 28 +++--- drivers/gpu/drm/vkms/vkms_crtc.c | 95 +++- drivers/gpu/drm/vkms/vkms_drv.c | 14 +-- drivers/gpu/drm/vkms/vkms_drv.h | 65 +++

[PATCH v2 1/6] drm/vkms: Back VKMS with DRM memory management instead of static objects

This is a small refactor to make ConfigFS support easier. Once we support ConfigFS, there can be multiple devices instantiated by the driver, and so moving everything into managed memory makes things much easier. This should be a no-op refactor. Signed-off-by: Jim Shargo --- drivers/gpu/drm

[PATCH v2 0/6] Adds support for ConfigFS to VKMS!

jshargo/igt-gpu-tools/-/merge_requests/1) - Existing IGT tests (excluding .*suspend.*, including .*kms_flip.* .*kms_writeback.* .*kms_cursor_crc.*, .*kms_plane.*) Outro = I'm excited to share these changes, it's my still my first kernel patch and I've been putting a lot of love

Re: [PATCH v3 0/3] drm/vkms: Add support for multiple pipes

Hey, all! I am so excited to see other folks excited about extending VKMS. I think it's a great project and has outstanding potential! Life stuff made me AFK for the last few months, but I'm back now and I've been wrapping up the work on the patchset Brandon linked. The current WIP patches are h

[PATCH 2/5] drm/vkms: VKMS now supports more than one "card"

s is because, due to limitations on what we can do with the configfs API, the default card won't be reflected in configfs and is initialized in a unique way. Since we're only managing a single card, this should be a no-op. Signed-off-by: Jim Shargo --- drivers/gpu/drm/vkms/vkms_crtc.c

[PATCH 1/5] drm/vkms: Merge default_config and device

This is a small refactor to make ConfigFS support easier. vkms_config is now a member of vkms_device and we now store a top-level reference to vkms_device. This should be a no-op refactor. Signed-off-by: Jim Shargo --- drivers/gpu/drm/vkms/vkms_drv.c| 58

[PATCH 5/5] drm/vkms: Support registering configfs devices

VKMS now supports creating virtual cards and registering them to create real drm devices. In addition to the registration logic, this commit also prevents users from adding new objects once a card is registered. Signed-off-by: Jim Shargo --- drivers/gpu/drm/vkms/vkms_configfs.c | 27

[PATCH 0/5] drm/vkms: Add ConfigFS Support

s my first kernel patchset, and though I've had it reviewed by my team (with a lot of of kernel/drm expertise), I recommend reading it with a bit of extra scrutiny. As you can tell by the fact this didn't get mailed with the other patches :P. Thanks! Jim Shargo (5): drm/vkms: Merge default

[PATCH 3/5] drm/vkms: Support multiple objects (crtcs, etc.) per card

only ever one CRTC, this should be a no-op refactor. Signed-off-by: Jim Shargo --- drivers/gpu/drm/vkms/vkms_composer.c | 28 +++ drivers/gpu/drm/vkms/vkms_crtc.c | 91 +++-- drivers/gpu/drm/vkms/vkms_drv.c | 3 +- drivers/gpu/drm/vkms/vkms_drv.h

[PATCH 4/5] drm/vkms: Add ConfigFS scaffolding to VKMS

reate a new device according to your configuration. For now, this will fail, but the next change will add support for it. Signed-off-by: Jim Shargo --- Documentation/gpu/vkms.rst | 76 drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/vkms/Makefile| 1 + dr

[RFC PATCH 0/1] drm/vkms: ConfigFS support

like /config/vkms/card/s//. 3. Should I split out the documention into a separate change? 4. Any other style / design thoughts? Thanks! I am excited to be reaching out and contributing. Jim Shargo (1): drm/vkms: Add basic support for ConfigFS to VKMS Documentation/gpu/vkms.rst

[RFC PATCH 1/1] drm/vkms: Add basic support for ConfigFS to VKMS

This change adds boilerplate setup for ConfigFS, resulting in a config directory that looks like this (assuming it's mounted under /config/): /config `-- vkms |-- connectors | `-- 52 |-- crtcs | `-- 51 |-- encoders