Re: [PATCH v7 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-07-24 Thread Krzysztof Kozlowski
; Also, add the audio power supply property which is dedicated for > the audio codec sub-device. > > Signed-off-by: Alexandre Mergnat Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: display: panel: Document Densitron DMT028VGHMCMI-1D TFT on ILI9806E DSI TCON

2024-07-24 Thread Krzysztof Kozlowski
On 24/07/2024 02:55, Marek Vasut wrote: > Document Densitron DMT028VGHMCMI-1D 480x640 TFT matrix 2.83 inch panel > attached to Ilitek ILI9806E DSI TCON in the ILI9806E bindings. > > Signed-off-by: Marek Vasut Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 3/4] dt-bindings: display: ti,am65x-dss: Add OLDI properties for AM625 DSS

2024-07-21 Thread Krzysztof Kozlowski
On 16/07/2024 10:42, Aradhya Bhatia wrote: > The DSS in AM625 SoC has 2 OLDI TXes. Refer the OLDI schema to add the > support for the OLDI TXes. > > The AM625 DSS VP1 (port@0) can connect and control 2 OLDI TXes, to use > them in dual-link or cloned single-link OLDI modes. Add support for an >

Re: [PATCH v3 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

2024-07-21 Thread Krzysztof Kozlowski
On 16/07/2024 10:42, Aradhya Bhatia wrote: > The OLDI (transmitters) TXes do not have registers of their own, and are > dependent on the source video-ports from the DSS to provide > configuration data. This hardware doesn't directly sit on the internal > bus of the SoC, but does so via the DSS.

Re: [PATCH v2 1/2] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02

2024-07-21 Thread Krzysztof Kozlowski
On 19/07/2024 20:52, Rob Clark wrote: > From: Rob Clark > > The Samsung ATNA45DC02 panel is an AMOLED eDP panel, similar to the > existing ATNA45AF01 and ATNA33XC20 panel but with a higher resolution. > > Signed-off-by: Rob Clark > --- >

Re: [PATCH RFC 1/3] firmware: qcom: implement object invoke support

2024-07-18 Thread Krzysztof Kozlowski
On 03/07/2024 07:57, Amirreza Zarrabi wrote: > Qualcomm TEE hosts Trusted Applications and Services that run in the > secure world. Access to these resources is provided using object > capabilities. A TEE client with access to the capability can invoke > the object and request a service.

Re: [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-18 Thread Krzysztof Kozlowski
On 18/07/2024 02:21, Doug Anderson wrote: > Conor (and/or) Krzysztof and Rob, > > On Mon, Jul 15, 2024 at 8:31 AM Conor Dooley wrote: >> >> On Mon, Jul 15, 2024 at 02:15:37PM +0200, Stephan Gerhold wrote: >>> The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight >>> control over

Re: [PATCH] dt-bindings: display: st,stm32-ltdc: Document stm32mp25 compatible

2024-07-12 Thread Krzysztof Kozlowski
On 12/07/2024 15:16, Yannick Fertre wrote: > Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduces > new clocks (bus, ref & lvds). Bus clock was separated from lcd clock. > New sources are possible for lcd clock (lvds / ref). > > Signed-off-by: Yannick Fertre > --- >

Re: [PATCH 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series

2024-07-11 Thread Krzysztof Kozlowski
On 11/07/2024 10:30, manikanda...@microchip.com wrote: > Hi Krzysztof, > > On 04/07/24 4:27 pm, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 04/07/2024 10:48, Manik

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-11 Thread Krzysztof Kozlowski
rrectly. It is similar to the existing ATNA33XC20 panel, just with > a larger resolution and size. > > Add a new "samsung,atna45af01" compatible to describe this panel in the DT. > > Signed-off-by: Stephan Gerhold > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-11 Thread Krzysztof Kozlowski
On 10/07/2024 19:35, Doug Anderson wrote: > Hi, > > On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold > wrote: >> >> The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight >> control over the DP AUX channel. While it works almost correctly with the >> generic "edp-panel"

Re: [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-07-09 Thread Krzysztof Kozlowski
On 08/07/2024 16:52, Maxime Ripard wrote: > On Mon, Jul 08, 2024 at 04:04:21PM GMT, Krzysztof Kozlowski wrote: >> On 08/07/2024 08:40, Liu Ying wrote: >>>>> + >>>>> + "^framegen@[0-9a-f]+$": >>>>> +type: object >

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add Non-Burst mode property

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 17:18, stefano.radaell...@gmail.com wrote: > From: Stefano Radaelli > > The video mode can be divided into two methods for sending packet data: > burst mode and non-burst mode. > In burst mode, pixel data is compressed to save time for the interface > to return to low power. >

Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 17:18, stefano.radaell...@gmail.com wrote: > From: Stefano Radaelli > > It allows to disable Burst video mode > > Co-developed-by: Noah J. Rosa > Signed-off-by: Noah J. Rosa > Signed-off-by: Stefano Radaelli > --- > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml

Re: [PATCH 04/10] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 08:51, Liu Ying wrote: > On 07/07/2024, Krzysztof Kozlowski wrote: >> On 05/07/2024 11:09, Liu Ying wrote: >>> i.MX8qxp Display Controller has a built-in interrupt controller to support >>> Enable/Status/Preset/Clear interrupt bit. >

Re: [PATCH 03/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 08:47, Liu Ying wrote: > On 07/07/2024, Krzysztof Kozlowski wrote: >> On 05/07/2024 11:09, Liu Ying wrote: >>> i.MX8qxp Display Controller pixel engine consists of all processing units >>> that operate in the AXI bus clock domain. Command sequencer a

Re: [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 08:40, Liu Ying wrote: >>> + >>> + "^framegen@[0-9a-f]+$": >>> +type: object >>> +additionalProperties: true >>> + >>> +properties: >>> + compatible: >>> +const: fsl,imx8qxp-dc-framegen >>> + >>> + "^gammacor@[0-9a-f]+$": >> >> This looks like you are

Re: [09/10] drm/imx: Add i.MX8qxp Display Controller KMS

2024-07-08 Thread Krzysztof Kozlowski
On 08/07/2024 09:09, Markus Elfring wrote: >>> Under which circumstances would you become interested to apply a statement >>> like “guard(spinlock_irqsave)(>dev->event_lock);”? >> >> I just follow the kerneldoc of drm_crtc_send_vblank_event() to >> hold event lock like many other drivers do. > >

Re: [PATCH 05/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller

2024-07-07 Thread Krzysztof Kozlowski
On 05/07/2024 11:09, Liu Ying wrote: > i.MX8qxp Display Controller(DC) is comprised of three main components that > include a blit engine for 2D graphics accelerations, display controller for > display output processing, as well as a command sequencer. > > Signed-off-by: Liu Ying > --- >

Re: [PATCH 03/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine

2024-07-07 Thread Krzysztof Kozlowski
On 05/07/2024 11:09, Liu Ying wrote: > i.MX8qxp Display Controller pixel engine consists of all processing units > that operate in the AXI bus clock domain. Command sequencer and interrupt > controller of the Display Controller work with AXI bus clock, but they are > not in pixel engine. > >

Re: [PATCH 04/10] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller

2024-07-07 Thread Krzysztof Kozlowski
On 05/07/2024 11:09, Liu Ying wrote: > i.MX8qxp Display Controller has a built-in interrupt controller to support > Enable/Status/Preset/Clear interrupt bit. > > Signed-off-by: Liu Ying > --- > .../fsl,imx8qxp-dc-intc.yaml | 321 ++ > 1 file changed, 321

Re: [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-07-07 Thread Krzysztof Kozlowski
On 05/07/2024 11:09, Liu Ying wrote: > i.MX8qxp Display Controller display engine consists of all processing units > that operate in a display clock domain. > > Signed-off-by: Liu Ying > --- > .../imx/fsl,imx8qxp-dc-display-engine.yaml| 166 ++ > 1 file changed, 166

Re: [PATCH 01/10] dt-bindings: display: imx: Add some i.MX8qxp Display Controller processing units

2024-07-07 Thread Krzysztof Kozlowski
On 05/07/2024 11:09, Liu Ying wrote: > Freescale i.MX8qxp Display Controller is implemented as construction set of > building blocks with unified concept and standardized interfaces. > > Document some processing units to support two display outputs. > +maintainers: > + - Liu Ying > + >

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

2024-07-05 Thread Krzysztof Kozlowski
On 05/07/2024 13:14, Maxime Ripard wrote: > +Alain > > On Tue, Jun 04, 2024 at 03:18:55PM GMT, Krzysztof Kozlowski wrote: >> On 27/05/2024 16:47, Alain Volmat wrote: >>> Hi Krzysztof, >>> >>> thanks for your patch, sorry for the delay. >>> .

Re: [PATCH] MAINTAINERS: drm/sti: mark it as Odd Fixes

2024-07-05 Thread Krzysztof Kozlowski
On 05/07/2024 13:22, Maxime Ripard wrote: > On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: >> On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: >>> Patches to STI DRM are not being picked up, so even though there is >>> ma

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

2024-07-05 Thread Krzysztof Kozlowski
On 05/07/2024 12:37, Dmitry Baryshkov wrote: > Acked-by: Alain Volmat What does this ack mean? You are the maintainer, so what is supposed to happen now? If maintainer does not take patches, then the DRM STI looks orphaned. >>> >>> +Cc Neil, Dmitry, >>> >>> I pinged and

[PATCH] MAINTAINERS: drm/sti: mark it as Odd Fixes

2024-07-05 Thread Krzysztof Kozlowski
://lore.kernel.org/all/f207b481-f530-4f54-a482-218908869...@linaro.org/ Signed-off-by: Krzysztof Kozlowski --- Cc: Dmitry Baryshkov Cc: Neil Armstrong --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c8e16a649a0e..f284cb8db544 100644

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

2024-07-05 Thread Krzysztof Kozlowski
On 04/06/2024 15:18, Krzysztof Kozlowski wrote: > On 27/05/2024 16:47, Alain Volmat wrote: >> Hi Krzysztof, >> >> thanks for your patch, sorry for the delay. >> >> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: >>> Core in platform

Re: [PATCH 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series

2024-07-04 Thread Krzysztof Kozlowski
On 04/07/2024 10:48, Manikandan Muralidharan wrote: > Add the Microchip's DSI controller wrapper driver that uses > the Synopsys DesignWare MIPI DSI host controller bridge. > > Signed-off-by: Manikandan Muralidharan > --- ... > + > +#define HSTT(_maxfreq, _c_lp2hs, _c_hs2lp, _d_lp2hs,

Re: [PATCH 1/4] dt-bindings: display: bridge: add sam9x75-mipi-dsi binding

2024-07-04 Thread Krzysztof Kozlowski
On 04/07/2024 10:48, Manikandan Muralidharan wrote: > Add the 'sam9x75-mipi-dsi' compatible binding, which describes the > Microchip's specific wrapper for the Synopsys DesignWare MIPI DSI HOST > Controller for the sam9x75 series System-on-Chip (SoC) devices. > > Signed-off-by: Manikandan

Re: [PATCH 3/4] MAINTAINERS: add SAM9X7 SoC's Microchip's MIPI DSI host wrapper driver

2024-07-04 Thread Krzysztof Kozlowski
On 04/07/2024 10:48, Manikandan Muralidharan wrote: > Add the Microchip's DSI controller wrapper driver that uses the > Synopsys DesignWare MIPI DSI host controller bridge for the SAM9X7 > SoC series to the MAINTAINERS entry. > > Signed-off-by: Manikandan Muralidharan > --- > MAINTAINERS | 8

Re: [PATCH v2 2/8] dt-bindings: input: touchscreen: document synaptics TCM oncell

2024-07-01 Thread Krzysztof Kozlowski
On 30/06/2024 20:36, Caleb Connolly wrote: > > diff --git > a/Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.yaml > b/Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.yaml > new file mode 100644 > index ..6e366c9446f8 > --- /dev/null > +++

Re: [PATCH 1/1] dt-bindings: display/msm: dsi-controller-main: Add SM7150

2024-06-28 Thread Krzysztof Kozlowski
On 28/06/2024 10:23, Danila Tikhonov wrote: > Add the DSI host found on SM7150. > > Signed-off-by: Danila Tikhonov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-06-28 Thread Krzysztof Kozlowski
On 27/06/2024 18:45, Marc Gonzalez wrote: > On 27/06/2024 18:25, Conor Dooley wrote: > >> On Thu, Jun 27, 2024 at 01:13:03PM +0200, Marc Gonzalez wrote: >> >>> TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. >>> It supports DVI 1.0, HDMI 1.4b and 2.0b. >>> It supports 4 TMDS

Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-06-26 Thread Krzysztof Kozlowski
On 21/06/2024 17:00, Krzysztof Kozlowski wrote: >> + >> + audio-codec: >> +type: object > > Still not much improved. You do not have any resources there, so these > should go to the parent node. Just to clarify: comment is about audio-codec. I meant what's insid

Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-06-26 Thread Krzysztof Kozlowski
On 26/06/2024 10:30, Alexandre Mergnat wrote: > > > On 25/06/2024 15:44, Krzysztof Kozlowski wrote: >> On 25/06/2024 11:23, Alexandre Mergnat wrote: >>> >>> >>> On 21/06/2024 17:00, Krzysztof Kozlowski wrote: >>>> On 19/06/2024 16:46, Alexand

Re: [PATCH 1/2] dt-bindings: display: simple: Add AUO G104STN01 panel

2024-06-26 Thread Krzysztof Kozlowski
On 26/06/2024 06:36, Paul Gerber wrote: > Add AUO G104STN01 10.4" LCD-TFT LVDS panel compatible string. > > Signed-off-by: Paul Gerber Acked-by: Krzysztof Kozlowski --- This is an automated instruction, just in case, because many review tags are being ignored. If you know th

Re: [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-26 Thread Krzysztof Kozlowski
On 26/06/2024 06:31, Dmitry Baryshkov wrote: > On Tue, Jun 25, 2024 at 04:51:27PM GMT, Rob Herring wrote: >> On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote: >>> dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for >> >

Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-06-25 Thread Krzysztof Kozlowski
On 25/06/2024 11:23, Alexandre Mergnat wrote: > > > On 21/06/2024 17:00, Krzysztof Kozlowski wrote: >> On 19/06/2024 16:46, Alexandre Mergnat wrote: >>> Add the audio codec sub-device. This sub-device is used to set the >>> optional voltage values according to

Re: [PATCH 1/2] drm/msm/adreno: allow headless setup on SM8150 MTP

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 16:06, Konrad Dybcio wrote: > > > On 6/23/24 21:34, Krzysztof Kozlowski wrote: >> Commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") re-used >> amd,imageon compatible for the SM8150 just to enable headless mode due >> to missing

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 08:21, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 01:11:48PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 13:06, Akhil P Oommen wrote: >>> This series adds support for the Adreno X1-85 GPU found in Qualcomm's >>> compute series chipset, Sn

Re: [PATCH 3/7] dt-bindings: arm: qcom: add OnePlus 8 series

2024-06-23 Thread Krzysztof Kozlowski
On 24/06/2024 03:30, Caleb Connolly wrote: > Add bindings for the OnePlus 8, 8 Pro, and 8T devices. > > Signed-off-by: Caleb Connolly Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 17:16, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 14:28, Akhil P Oommen wrote: >>> On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: >>>> On 23/06/2024 13:06, A

[PATCH v2 1/4] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Krzysztof Kozlowski
We expect each schema with variable number of clocks, to have the widest constrains in top-level "properties:". This is more readable and also makes binding stricter, if there is no "if:then:" block for given variant. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski

[PATCH v2 4/4] dt-bindings: display/msm/gpu: fix the schema being not applied

2024-06-23 Thread Krzysztof Kozlowski
a work-around do the binding can be used against DTS validation. Signed-off-by: Krzysztof Kozlowski --- This will uncover issues with DTS, which is expected and fixed in: 1. Incorrect AMD compatible: https://lore.kernel.org/linux-arm-msm/20240623193420.333735-1-krzysztof.kozlow...@linaro.org/T

[PATCH v2 3/4] dt-bindings: display/msm/gpu: simplify compatible regex

2024-06-23 Thread Krzysztof Kozlowski
Regex for newer Adreno compatibles can be simpler. Suggested-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml

[PATCH v2 2/4] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Krzysztof Kozlowski
All devices should (and actually do) have same order of entries, if possible. That's the case for reg/reg-names, so define the reg-names in top-level to enforce that. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 5

[PATCH v2 0/4] dt-bindings: display/msm/gpu: few cleanups

2024-06-23 Thread Krzysztof Kozlowski
devicetree/bindings/display/msm/gpu.yaml | 27 ++ 1 file changed, 23 insertions(+), 4 deletions(-) --- base-commit: d47fa80a484f97ea51991c9547636a799c264652 change-id: 20240623-qcom-adreno-dts-bindings-driver-87521a145260 Best regards, -- Krzysztof Kozlowski

[PATCH 2/2] arm64: dts: qcom: sm8150-mtp: drop incorrect amd,imageon

2024-06-23 Thread Krzysztof Kozlowski
the SM8150 and later moved to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts: qcom: sm8150: Don't start Adreno in headless mode") with an intention to allow headless mode. This should be solved via proper driver quirks, not fake compatibles. Signed-off-by: Krzysztof Kozlowsk

[PATCH 1/2] drm/msm/adreno: allow headless setup on SM8150 MTP

2024-06-23 Thread Krzysztof Kozlowski
ect way. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index c3703a51287b..a8afe0b6429b 100644 --- a/driver

Re: [PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 16:13, Conor Dooley wrote: > On Sun, Jun 23, 2024 at 02:00:26PM +0200, Krzysztof Kozlowski wrote: >> MMIO address space is known per each variant of Adreno GPU, so we can >> constrain the reg/reg-names entries for each variant. There is no DTS >> f

[PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-23 Thread Krzysztof Kozlowski
a work-around do the binding can be used against DTS validation. Signed-off-by: Krzysztof Kozlowski --- Cc: Akhil P Oommen --- .../devicetree/bindings/display/msm/gmu.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 14:28, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 13:06, Akhil P Oommen wrote: >>> Add the necessary dt nodes for gpu support in X1E80100. >>> >>> Signed-off-by: Akhil P Oomm

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 > 1 file changed, 4 insertions(+) > > diff --git

[PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Krzysztof Kozlowski
MMIO address space is known per each variant of Adreno GPU, so we can constrain the reg/reg-names entries for each variant. There is no DTS for A619, so that part is not accurate but could be corrected later. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/gpu.yaml

[PATCH 2/3] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Krzysztof Kozlowski
All devices should (and actually do) have same order of entries, if possible. That's the case for reg/reg-names, so define the reg-names in top-level to enforce that. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 5 - 1 file changed, 4

[PATCH 1/3] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Krzysztof Kozlowski
We expect each schema with variable number of clocks, to have the widest constrains in top-level "properties:". This is more readable and also makes binding stricter, if there is no "if:then:" block for given variant. Signed-off-by: Krzysztof Kozlowski --- Documentation

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Add the necessary dt nodes for gpu support in X1E80100. > > Signed-off-by: Akhil P Oommen > --- > + gmu: gmu@3d6a000 { > + compatible = "qcom,adreno-gmu-x185.1", > "qcom,adreno-gmu"; > + reg = <0x0

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 ++++ Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > This series adds support for the Adreno X1-85 GPU found in Qualcomm's > compute series chipset, Snapdragon X1 Elite (x1e80100). In this new > naming scheme for Adreno GPU, 'X' stands for compute series, '1' denotes > 1st generation and '8' & '5' denotes

Re: [PATCH 3/4] dt-bindings: msm: dsi-phy-28nm: Document msm8937 compatible

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 01:25, Barnabás Czémán wrote: > The MSM8937 SoC uses a slightly different 28nm dsi phy. Add a new > compatible for it. > > Signed-off-by: Barnabás Czémán > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: display/msm: qcom, mdp5: Add msm8937 compatible

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 01:25, Barnabás Czémán wrote: > Add the compatible for the MDP5 found on MSM8937. > > Signed-off-by: Barnabás Czémán > --- Reviewed-by: Krzysztof Kozlowski --- This is an automated instruction, just in case, because many review tags are being ignored. If you know

Re: [PATCH v1 1/3] dt-bindings: display: st7701: Add Anbernic RG28XX panel

2024-06-21 Thread Krzysztof Kozlowski
On 21/06/2024 12:59, Hironori KIKUCHI wrote: > Hello Krzysztof, > > Thank you for your reply! > > On Tue, Jun 18, 2024 at 6:17 PM Krzysztof Kozlowski wrote: >> >> On 18/06/2024 10:15, Hironori KIKUCHI wrote: >>> The RG28XX panel is a panel specific to the A

Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-06-21 Thread Krzysztof Kozlowski
On 19/06/2024 16:46, Alexandre Mergnat wrote: > Add the audio codec sub-device. This sub-device is used to set the > optional voltage values according to the hardware. > The properties are: > - Setup of microphone bias voltage. > - Setup of the speaker pin pull-down. > > Also, add the audio

Re: [PATCH v3 16/23] leds: max77705: Add LEDs support

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > This adds basic support for LEDs for the max77705 PMIC. > > Signed-off-by: Dzmitry Sankouski > --- > MAINTAINERS | 1 + > drivers/leds/Kconfig | 6 ++ > drivers/leds/Makefile| 1 + >

Re: [PATCH v3 07/23] dt-bindings: power: supply: add maxim,max77705

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add maxim,max77705 fuel gauge binding part > > Signed-off-by: Dzmitry Sankouski > --- > .../bindings/power/supply/maxim,max77705-fg.yaml | 35 > ++ > 1 file changed, 35 insertions(+) > > diff --git >

Re: [PATCH v3 19/23] power: supply: s2dos05: Add fuel gauge driver for s2dos05

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add fuel gauge driver for s2dos05 PMIC. It uses adc to measure power > on each power output s2dos05 provides, including regulator outputs > and AVDD, ELVSS, ELVDD lines. Driver registers power supply for each > corresponding power line. > > Adc can

Re: [PATCH v3 18/23] regulator: add s2dos05 regulator support

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > S2dos05 has 1 buck and 4 LDO regulators, used for powering > panel/touchscreen. > > Signed-off-by: Dzmitry Sankouski > diff --git a/drivers/regulator/s2dos05-regulator.c > b/drivers/regulator/s2dos05-regulator.c > new file mode 100644 > index

Re: [PATCH v3 17/23] mfd: add s2dos series core driver

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > S2DOS05 is a panel/touchscreen PMIC, often found in > Samsung phones. We define 2 sub-devices for which drivers will > be added in subsequent patches. > > Signed-off-by: Dzmitry Sankouski > --- > MAINTAINERS| 1 + >

Re: [PATCH v3 14/23] power: supply: max77705: Add charger driver for Maxim 77705

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add driver for Maxim 77705 switch-mode charger (part of max77705 > MFD driver) providing power supply class information to userspace. > > The driver is configured through DTS (battery and system related > settings). Also,

Re: [PATCH v3 13/23] input: add max77705 haptic driver

2024-06-20 Thread Krzysztof Kozlowski
ptic_pm_ops, > + max77705_haptic_suspend, > + max77705_haptic_resume); > + > +static const struct of_device_id of_max77705_haptic_dt_match[] = { > + { .compatible = "maxim,max77705-haptic", }, > + { /* se

Re: [PATCH v3 12/23] mfd: Add new driver for MAX77705 PMIC

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add the core MFD driver for max77705 PMIC. We define five sub-devices > for which the drivers will be added in subsequent patches. > > Signed-off-by: Dzmitry Sankouski > Co-authored-by: Rose Hudson > --- > MAINTAINERS |

Re: [PATCH v3 10/23] dt-bindings: regulator: add samsung,s2dos05

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add samsung,s2dos05 regulator binding part Make it a proper sentence. > > Signed-off-by: Dzmitry Sankouski > --- > .../bindings/regulator/samsung,s2dos05.yaml| 36 > ++ > MAINTAINERS

Re: [PATCH v3 09/23] dt-bindings: mfd: add samsung,s2dos05

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add samsung,s2dos05 core MFD module binding > > Signed-off-by: Dzmitry Sankouski > --- > .../devicetree/bindings/mfd/samsung,s2dos05.yaml | 89 > ++ > MAINTAINERS| 1 + > 2 files

Re: [PATCH v3 06/23] dt-bindings: power: supply: add maxim,max77705 charger

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add maxim,max77705 charger binding part Make it a proper sentence. > > Signed-off-by: Dzmitry Sankouski > --- > .../power/supply/maxim,max77705-charger.yaml | 30 > ++ > 1 file changed, 30 insertions(+) > > diff --git

Re: [PATCH v3 05/23] dt-bindings: input: add maxim,max77705-haptic

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > maxim,max77705-haptic is MAX77705 pmic binding part > > + > +maintainers: > + - Dzmitry Sankouski > + > +description: | > + This is a part of device tree bindings for Maxim MAX77705 multi functional > device. Wrap according to Linux coding

Re: [PATCH v3 04/23] dt-bindings: mfd: add maxim,max77705

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > maxim,max77705 is MAX77705 pmic binding part > > Signed-off-by: Dzmitry Sankouski > --- > .../devicetree/bindings/mfd/maxim,max77705.yaml| 112 > + Your patch order is totally messed. Not tested by automation. Only limited

Re: [PATCH v3 03/23] dt-bindings: panel: add Samsung s6e3ha8

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add binding for the Samsung s6e3ha8 panel found in the Samsung S9. > > Signed-off-by: Dzmitry Sankouski > --- > .../bindings/display/panel/samsung,s6e3ha8.yaml| 76 > ++ > MAINTAINERS

Re: [PATCH 3/4] drm: rcar-mipi-dsi: Add support for R8A779H0

2024-06-19 Thread Krzysztof Kozlowski
On 19/06/2024 14:00, Jacopo Mondi wrote: > Hi Krzysztof > > On Wed, Jun 19, 2024 at 01:07:24PM GMT, Krzysztof Kozlowski wrote: >> On 19/06/2024 12:22, Jacopo Mondi wrote: >>> Add support for R-Car R8A779H0 V4M which has the same characteristics >>> of the alr

Re: [PATCH 3/4] drm: rcar-mipi-dsi: Add support for R8A779H0

2024-06-19 Thread Krzysztof Kozlowski
On 19/06/2024 12:22, Jacopo Mondi wrote: > Add support for R-Car R8A779H0 V4M which has the same characteristics > of the already supported R-Car V4H R8A779G0. > > Signed-off-by: Jacopo Mondi > Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl

Re: [PATCH v1 2/3] drm/panel: st7701: Add support for SPI for configuration

2024-06-18 Thread Krzysztof Kozlowski
On 18/06/2024 10:15, Hironori KIKUCHI wrote: > The ST7701 supports not only MIPI DSI, but also SPI as an interface > for configuration. To support a panel connected via RGB parallel > interface, add support for SPI using MIPI DBI helpers. > > Signed-off-by: Hironori KIKUCHI ... > + > +static

Re: [PATCH v1 1/3] dt-bindings: display: st7701: Add Anbernic RG28XX panel

2024-06-18 Thread Krzysztof Kozlowski
On 18/06/2024 10:15, Hironori KIKUCHI wrote: > The RG28XX panel is a panel specific to the Anbernic RG28XX. > It is 2.8 inches in size (diagonally) with a resolution of 480x640. > > Signed-off-by: Hironori KIKUCHI > --- > .../display/panel/sitronix,st7701.yaml| 36 +-- >

Re: [PATCH v3 2/4] dt-bindings: display: panel: Add compatible for kingdisplay-kd101ne3

2024-06-15 Thread Krzysztof Kozlowski
On 14/06/2024 16:55, Zhaoxiong Lv wrote: > The kingdisplay-kd101ne3 is a 10.1" WXGA TFT-LCD panel with > jadard-jd9365da controller. Hence, we add a new compatible > with panel specific config. > > Signed-off-by: Zhaoxiong Lv > --- > Chage since V3: > > - 1. Abandon the V2 patch and add

Re: [PATCH v3 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings

2024-06-15 Thread Krzysztof Kozlowski
On 14/06/2024 16:56, Zhaoxiong Lv wrote: > This add the bindings for the 1280x800 TFT LCD Starry-er88577 DSI panel A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also:

Re: [PATCH v4 2/3] dt-bindings: display: panel-edp-legacy: drop several eDP panels

2024-06-14 Thread Krzysztof Kozlowski
our of using a generic "edp-panel" device on the > AUX bus. > > Reviewed-by: Douglas Anderson > Signed-off-by: Dmitry Baryshkov Please reverse the order of patches - you cannot have undocumented compatible, so first you remove driver support, then bindings. Acked-by:

Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-13 Thread Krzysztof Kozlowski
On 13/06/2024 12:13, Dmitry Baryshkov wrote: > On Thu, Jun 13, 2024 at 11:23:50AM +0200, Krzysztof Kozlowski wrote: >> On 12/06/2024 20:43, Danila Tikhonov wrote: >>> Document the DPU hardware found on the Qualcomm SM7150 platform. >> >> In general, this should be b

Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-13 Thread Krzysztof Kozlowski
lcomm SM7150 Display DPU What is DPU? Such acronyms should be explained in description or expanded here, if there is space. Reviewed-by: Krzysztof Kozlowski > + > +maintainers: > + - Danila Tikhonov > + > +$ref: /schemas/display/msm/dpu-common.yaml# > + > +properties: > + compatible: > +const: qcom,sm7150-dpu > + Best regards, Krzysztof

Re: [PATCH v2 1/4] dt-bindings: display/msm: Add SM7150 MDSS

2024-06-13 Thread Krzysztof Kozlowski
On 12/06/2024 20:43, Danila Tikhonov wrote: > Document the MDSS hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08

2024-06-10 Thread Krzysztof Kozlowski
gt; + > + reset-gpios: true > + port: true > + > +additionalProperties: false This goes after "required:" block. > + > +required: > + - compatible > + - reg > + - vdd3p3-supply > + - vddio-supply > + - vsn-supply > + - vsp-supply > + - reset-gpios > + - port > + Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: display: simple: Add PrimeView PM070WL4 panel

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 09:28, Primoz Fiser wrote: > Add PrimeView PM070WL4 7.0" 800x480 TFT LCD panel compatible string. > > Signed-off-by: Primoz Fiser > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git >

Re: [PATCH 1/3] dt-bindings: Add vendor prefix for PrimeView

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 09:28, Primoz Fiser wrote: > The Prime View International (PVI) is a LCD panel manufacturer. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the

[PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two)

2024-06-05 Thread Krzysztof Kozlowski
channel number). Few bindings missed previous fixup: LG SW43408 and Raydium RM69380. Signed-off-by: Krzysztof Kozlowski --- This should apply on any tree. --- .../devicetree/bindings/display/panel/lg,sw43408.yaml| 4 +++- .../devicetree/bindings/display/panel/raydium,rm69380.yaml | 5

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-05 Thread Krzysztof Kozlowski
On 04/06/2024 19:52, Abhinav Kumar wrote: > > > On 6/4/2024 8:36 AM, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:32, Dmitry Baryshkov wrote: >>> On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >>>> On 04/06/2024 17:14, Dmitry Baryshkov

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
the default. In such case the property can > be skipped. > > Signed-off-by: Dmitry Baryshkov Maybe we need third DT maintainer review/ack... Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 17:32, Dmitry Baryshkov wrote: > On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:14, Dmitry Baryshkov wrote: >>>>>>>> >>>>>>>> I didnt follow why this is a link

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 17:14, Dmitry Baryshkov wrote: >> >> I didnt follow why this is a link property. Sorry , I didnt follow the >> split part. > > There is a link between the DSI host and the panel. I don't want to > end up in a situation when the properties of the link are split

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

2024-06-04 Thread Krzysztof Kozlowski
On 27/05/2024 16:47, Alain Volmat wrote: > Hi Krzysztof, > > thanks for your patch, sorry for the delay. > > On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: >> Core in platform_driver_register() already sets the .owner, so driver >> does not nee

[RESEND PATCH] drm/exynos: dp: drop driver owner initialization

2024-06-04 Thread Krzysztof Kozlowski
Core in platform_driver_register() already sets the .owner, so driver does not need to. Whatever is set here will be anyway overwritten by main driver calling platform_driver_register(). Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/exynos/exynos_dp.c | 1 - 1 file changed, 1 deletion

Re: [PATCH v2 3/4] dt-bindings: display: panel: Add compatible for Starry-er88577

2024-06-01 Thread Krzysztof Kozlowski
On 01/06/2024 10:45, Zhaoxiong Lv wrote: > The Starry-er88577 is a 10.1" WXGA TFT-LCD panel, which fits > in nicely with the existing panel-kingdisplay-kd101ne3 driver. > Hence, we add a new compatible with panel specific config. > > Signed-off-by: Zhaoxiong Lv > --- > > Chage since V2: >

Re: [PATCH v2 1/4] dt-bindings: display: panel: Add KD101NE3-40TI support

2024-06-01 Thread Krzysztof Kozlowski
On 01/06/2024 10:45, Zhaoxiong Lv wrote: > Create a new dt-scheam for the kd101ne3-40ti. > The bias IC of this kindisplay-kd101ne3 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver. > + > + reg: > +description: the

  1   2   3   4   5   6   7   8   9   10   >