t now I leave it to Lee and Johan to decide
> the destiny of the drivers.
Let's not rush into it. Take your time.
--
Lee Jones [李琼斯]
> 11 files changed, 2865 deletions(-)
> delete mode 100644 drivers/iio/light/lm3533-als.c
> delete mode 100644 drivers/leds/leds-lm3533.c
> delete mode 100644 drivers/mfd/lm3533-core.c
> delete mode 100644 drivers/video/backlight/lm3533_bl.c
> delete mode 100644 include/linux/mfd/lm3533.h
>
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
--
Lee Jones [李琼斯]
river
commit: b72755f5b577357cac661cbf9048cad704eb4ad8
--
Lee Jones [李琼斯]
t;, 17, 1, "active-low", "active-high"),
> + fld("ii", 16, 1, "normal", "inverted"),
> + fld("pll", 15, 1, "disable", "enable"),
> + fld("gap", 13, 2, "0"),
> + fld("dac", 12, 1, "enable", "disable"),
> + fld("mc", 11, 1, "cpu", "8051"),
> + fld("bl", 10, 8, "1"),
> + fld("usb", 9, 1, "master", "slave"),
> + fld("vr", 4, 1, "0x1e0", "0x3e0"),
> + { .name = NULL },
> +};
I've been avoiding this set for a while now!
I appreciate the amount of work that you've put into this, but this is a
bit of a disaster. It's a hell of lot of over-complex infrastructure
just to pull out some values from DT.
Forgive me if I have this wrong, but it looks like you're defining
various structs then populating static versions with hard-coded offsets
into DT arrays! Then you have a bunch of hoop-jumpy functions to
firstly parse the offset-structs, then conduct look-ups to pull the
final value which in turn gets shifted into an encoded variable ready
for to write out to the registers. Bonkers.
What does 'timing' even mean in this context? Clocks?
What other devices require this kind of handling? Why is this device so
different from all other supported devices to date? Instead of
attempting to shoehorn this into a 20 year old driver, why not reshape
it to bring it into alignment with how we do things today?
E.g. handle all clocking from the clock driver, all display settings
(including timing?) from the display driver, etc.
--
Lee Jones [李琼斯]
/lcd.h | 6 +++---
scripts/const_structs.checkpatch | 1 +
20 files changed, 23 insertions(+), 22 deletions(-)
--
Lee Jones [李琼斯]
On Fri, 03 May 2024, Lee Jones wrote:
> On Fri, 03 May 2024, Lee Jones wrote:
>
> > On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > > Changes in v2:
> > > - Collect tags, including wrongly places Thomas' tag (which requires me
> > > to
On Fri, 03 May 2024, Lee Jones wrote:
> On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > Changes in v2:
> > - Collect tags, including wrongly places Thomas' tag (which requires me
> > to manually edit 15 other patches to drop it).
> > - Co
8d768f54d31e7cb48b06c0e3814
--
Lee Jones [李琼斯]
On Fri, 03 May 2024, FLAVIO SULIGOI wrote:
> Hi Lee,
>
> ...
>
> > Subject: EXTERNAL: Re: (subset) [PATCH v1 1/1] backlight: mp3309c: fix
> > leds flickering in pwm mode
> >
> > [Use caution with links & attachments]
> >
> >
> >
&
-backlight: Remove unnecessary call to of_node_get
commit: 4da294108e38bf9cd5c62c2caa47611e5dbb7fb1
--
Lee Jones [李琼斯]
On Thu, 02 May 2024, Lee Jones wrote:
> On Wed, 17 Apr 2024 17:31:05 +0200, Flavio Suligoi wrote:
> > The mp3309 has two configuration registers, named according to their
> > address (0x00 and 0x01).
> > In the second register (0x01), the bit DIMS (Dimming Mode Select) must
t; flickering on the LEDs powered by the mp3309c.
>
> [...]
Applied, thanks!
[1/1] backlight: mp3309c: fix leds flickering in pwm mode
commit: ce60cddc2abf61902dfca71d630624db95315124
--
Lee Jones [李琼斯]
id = kmemdup(p_edid, EDID_LENGTH, GFP_KERNEL);
> + if (edid) {
> + specs = kzalloc(sizeof(*specs), GFP_KERNEL);
> + if (specs) {
> + fb_edid_to_monspecs(edid, specs);
> + def_mode = specs->modedb;
> + }
> + }
> + kfree(edid);
> + }
> +
> + of_property_read_u32(child, "bpp", );
> +
> + /* If flags property is obtained, fbsub is returned. */
> + flags = read_display_flags(child);
> + if (flags) {
> + fbsub = devm_kzalloc(dev, sizeof(*fbsub), GFP_KERNEL);
> + if (fbsub) {
> + fbsub->def_mode = def_mode;
> + fbsub->def_bpp = bpp;
> + fbsub->flags = flags;
> + }
> + }
> + return fbsub;
> +}
> +
> +/* Build platform_data from OF property */
> +static struct sm501_platdata_fb *pdata_from_dt(struct device *dev, struct
> device_node *np)
> +{
> + enum sm501_fb_routing fb_route = SM501_FB_OWN;
> + struct sm501_platdata_fb *pdata = NULL;
> + struct sm501_platdata_fbsub *fb_crt;
> + struct sm501_platdata_fbsub *fb_pnl;
> + unsigned int flags = 0;
> +
> + if (of_property_read_bool(np, "route-crt-panel"))
> + fb_route = SM501_FB_CRT_PANEL;
> + if (of_property_read_bool(np, "swap-fb-endian"))
> + flags = SM501_FBPD_SWAP_FB_ENDIAN;
> + fb_crt = dt_fbsub(dev, np, "crt");
> + fb_pnl = dt_fbsub(dev, np, "panel");
> + if (fb_crt || fb_pnl) {
> + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> + if (pdata) {
> + pdata->fb_route = fb_route;
> + pdata->flags = flags;
> + pdata->fb_crt = fb_crt;
> + pdata->fb_pnl = fb_pnl;
> + }
> + }
> + return pdata;
> +}
> +#endif
> +
> static int sm501fb_probe(struct platform_device *pdev)
> {
> struct sm501fb_info *info;
> @@ -1974,6 +2074,12 @@ static int sm501fb_probe(struct platform_device *pdev)
> if (info->edid_data)
> found = 1;
> }
> + /* Get platform data compatible configuration */
> + if (!found) {
> + info->pdata = pdata_from_dt(dev, np);
> + if (info->pdata)
> + found = 1;
> + }
> }
> #endif
> if (!found) {
> --
> 2.39.2
>
--
Lee Jones [李琼斯]
On Thu, 02 May 2024, Lee Jones wrote:
> On Thu, 02 May 2024, Shresth Prasad wrote:
>
> > On Thu, May 2, 2024 at 3:06 PM Lee Jones wrote:
> > >
> > > On Thu, 02 May 2024, Shresth Prasad wrote:
> > >
> > > > `dev->of_node` already has a refere
On Thu, 02 May 2024, Shresth Prasad wrote:
> On Thu, May 2, 2024 at 3:06 PM Lee Jones wrote:
> >
> > On Thu, 02 May 2024, Shresth Prasad wrote:
> >
> > > `dev->of_node` already has a reference to the device_node and calling
> > > of_node_get on
//lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
--
Lee Jones [李琼斯]
omap/lcd_ams_delta.c | 2 +-
> include/linux/lcd.h | 6 +++---
> scripts/const_structs.checkpatch | 1 +
> 20 files changed, 23 insertions(+), 22 deletions(-)
> ---
> base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8
> change-id: 20240414-video-backlight-lcd-ops-276d8439ffb8
>
> Best regards,
> --
> Krzysztof Kozlowski
>
--
Lee Jones [李琼斯]
ideo-backlight-lcd-ops-v1-0-9b37fcbf5...@kernel.org
>
> Cc: Lee Jones
> Cc: Daniel Thompson
> Cc: Jingoo Han
> Cc: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> ---
> scripts/const_structs.checkpatch | 1 +
> 1 file changed, 1 insertion(+)
>
>
gt; EVERYTHING. You must provide tag under each individual patch.
And for that to not happen now, you have to resubmit the set. :)
--
Lee Jones [李琼斯]
b99886057a85
--
Lee Jones [李琼斯]
8_BL_REGISTER_ONLY.
>
>
Applied, thanks!
[1/1] backlight: lp8788: Drop support for platform data
commit: 150476e60a80ebb93d49aae7b636934eb04b83d2
--
Lee Jones [李琼斯]
8_BL_REGISTER_ONLY.
>
>
Applied, thanks!
[1/1] backlight: lp8788: Drop support for platform data
commit: 150476e60a80ebb93d49aae7b636934eb04b83d2
--
Lee Jones [李琼斯]
On Thu, 28 Mar 2024, Lee Jones wrote:
> On Thu, 28 Mar 2024 12:59:06 +0100, Greg Kroah-Hartman wrote:
> > Since commit 43a7206b0963 ("driver core: class: make class_register() take
> > a const *"), the driver core allows for struct class to be in read-only
> > memo
ke lcd_class constant
commit: d51564f749fe4e4efd570b0591f2d23696c90cc7
--
Lee Jones [李琼斯]
drivers/video/backlight/lcd.c | 23 +--
> 2 files changed, 29 insertions(+), 23 deletions(-)
No longer apply.
Please rebase on top of v6.9-rc1 or for-backlight-next.
--
Lee Jones [李琼斯]
| 1 -
11 files changed, 26 insertions(+), 84 deletions(-)
--
Lee Jones [李琼斯]
+++
include/linux/backlight.h| 16
include/linux/fb.h | 9 +
include/linux/pwm_backlight.h| 1 -
16 files changed, 71 insertions(+), 97 deletions(-)
--
Lee Jones [李琼斯]
didn't fail to compile ...
>
> Best regards
> Uwe
>
> drivers/video/backlight/lp8788_bl.c | 151 ++--
> include/linux/mfd/lp8788.h | 36 ---
> 2 files changed, 8 insertions(+), 179 deletions(-)
Does not apply.
Please rebase onto v6.9-rc1 or for-backlight-next.
--
Lee Jones [李琼斯]
On Wed, 27 Mar 2024, Lee Jones wrote:
> On Tue, 19 Mar 2024 10:37:19 +0100, Thomas Zimmermann wrote:
> > The field fb_blank in struct backlight_properties has been marked for
> > removal. Remove it in favor of the power and state fields.
> >
> > Patches 1 to 5 prepar
klight_properties
commit: 95342cdb3f438d378f48e4db188aa217b9b0a66e
--
Lee Jones [李琼斯]
On Thu, 21 Mar 2024, Lee Jones wrote:
> On Thu, 21 Mar 2024, Lee Jones wrote:
>
> > On Tue, 05 Mar 2024 17:22:33 +0100, Thomas Zimmermann wrote:
> > > Backlight drivers implement struct backlight_ops.check_fb, which
> > > uses struct fb_info in its interface.
> .../omapfb/displays/panel-sony-acx565akm.c| 10 +---
> include/linux/backlight.h | 25 +-
> include/linux/platform_data/omap1_bl.h| 1 -
> 11 files changed, 26 insertions(+), 84 deletions(-)
Is everyone okay with this being pushed through Backlight?
I can send out a PR to an immutable branch for others to pull from.
--
Lee Jones [李琼斯]
. However, it's still worth fixing.
>
>
Applied, thanks!
[1/1] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()
commit: 84a053e072c8aacff8074ac5d6f7a4e7ff745209
--
Lee Jones [李琼斯]
On Thu, 21 Mar 2024, Lee Jones wrote:
> On Tue, 05 Mar 2024 17:22:33 +0100, Thomas Zimmermann wrote:
> > Backlight drivers implement struct backlight_ops.check_fb, which
> > uses struct fb_info in its interface. Replace the callback with one
> > that does not use fb_info.
>
fbdev/ssd1307fb: Remove struct backlight_ops.check_fb
commit: ec5925ef4a2dfd7ee060f4fd2a2e8036f8a94e8e
[10/10] backlight: Add controls_device callback to struct backlight_ops
commit: 2e427743de015c1ac047036ef495c3f004105439
--
Lee Jones [李琼斯]
truct backlight_device *bl_dev;
> > - struct lp8788_backlight_platform_data *pdata;
> > - enum lp8788_bl_ctrl_mode mode;
> > struct pwm_device *pwm;
>
> Actually this pwm_device member should be dropped, too. I wonder why
> this even passes a W=1 build without a warning ...
>
> @Lee: Feel free to fix this up while applying, or tell me if you prefer
> an incremental fixup or a complete v2.
Either of the last 2 options would be fine.
--
Lee Jones [李琼斯]
-
> include/linux/platform_data/omap1_bl.h | 1 -
> 2 files changed, 4 deletions(-)
Just a quick one - I'm sure Daniel will be here soon to conduct a proper
review.
Could you attempt to use the subject line format expected by a given
subsystem please?
`git log --oneline -- ` is your friend.
Thanks.
--
Lee Jones [李琼斯]
ers and remove unnecessary implementations of check_fb. Finally,
> > patch 10 replaces the check_fb hook with controls_device, which
> > uses the framebuffer's Linux device instead of the framebuffer.
>
> I assume the merge plan for this series is via drm-misc in one go?
Backlight in one go. This will be the second attempt at applying it.
--
Lee Jones [李琼斯]
On Tue, 05 Mar 2024, Lee Jones wrote:
> On Mon, 04 Mar 2024, Thomas Zimmermann wrote:
>
> > Backlight drivers implement struct backlight_ops.check_fb, which
> > uses struct fb_info in its interface. Replace the callback with one
> > that does not use fb_info.
> >
-
> include/linux/backlight.h| 16 ++--
> include/linux/fb.h | 9 +++
> include/linux/pwm_backlight.h | 1 -
> 16 files changed, 70 insertions(+), 97 deletions(-)
All applied. Submitted for build testing.
Will follow-up with a PR once that's passed.
--
Lee Jones [李琼斯]
fbdev/ssd1307fb: Remove struct backlight_ops.check_fb
commit: d1b82cc44fd8be4013538992814c45f0e55c02b4
[10/10] backlight: Add controls_device callback to struct backlight_ops
commit: 7e508af663e20e9e40003bb30e06b926c754159b
--
Lee Jones [李琼斯]
49
[6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error
commit: dedd6eb26bbb37139d0a0122e4b4ad94f06edaa1
[7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message
commit: 07dbc9e6e2433fe312423096efc037bf47298ed1
--
Lee Jones [李琼斯]
-
> include/linux/backlight.h| 16 ++--
> include/linux/fb.h | 9 +++
> include/linux/pwm_backlight.h| 1 -
> 16 files changed, 70 insertions(+), 97 deletions(-)
Which Acks are you missing for us to merge this?
--
Lee Jones [李琼斯]
ckam KR
> [manikanda...@microchip.com: Remove unused macro definitions]
> Signed-off-by: Manikandan Muralidharan
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 42
> include/linux/mfd/atmel-hlcdc.h | 10 +
Acked-by: Lee Jones
> 2 files c
On Mon, 26 Feb 2024 15:01:51 +0100, amerg...@baylibre.com wrote:
> Add MT6357 codec entry in the MFD driver.
>
>
Applied, thanks!
[13/18] mfd: mt6397-core: register mt6357 sound codec
commit: 79d98102a31ab777b4a6632d799ab2bc63654cf8
--
Lee Jones [李琼斯]
_properties during probe
commit: aeb7ab878e90041776eae839faa117570dbcce93
[3/4] backlight: lp8788: Fully initialize backlight_properties during probe
commit: cd1995b6ac7384149ad755b74e3c3eb25195ab81
--
Lee Jones [李琼斯]
On Mon, 26 Feb 2024, Thomas Zimmermann wrote:
> Hi
>
> Am 26.02.24 um 13:33 schrieb Lee Jones:
> > On Mon, 26 Feb 2024, Jani Nikula wrote:
> >
> > > On Fri, 23 Feb 2024, Lee Jones wrote:
> > > > On Wed, 21 Feb 2024, Thomas Zimmermann wrote:
>
On Mon, 26 Feb 2024, Jani Nikula wrote:
> On Fri, 23 Feb 2024, Lee Jones wrote:
> > On Wed, 21 Feb 2024, Thomas Zimmermann wrote:
> >
> >> cc'ing backlight maintainers
> >
> > I cannot review/accept patches like this.
> >
> > Please submit a
ckam KR
> [manikanda...@microchip.com: Remove unused macro definitions]
> Signed-off-by: Manikandan Muralidharan
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 42
> include/linux/mfd/atmel-hlcdc.h | 10 +
Acked-by: Lee Jones
--
Lee Jones [李琼斯]
get_brightness
commit: ebb3b9a65b56e9b21841ab9a15b946407cd6b104
[3/4] backlight: lm3630a: Use backlight_get_brightness helper in update_status
commit: 3c40590fafd4cc2447fb482a640c450e1a58ffa1
--
Lee Jones [李琼斯]
1 +
> drivers/video/backlight/mp3309c.c | 1 +
> 4 files changed, 4 insertions(+)
>
>
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
a2f17a9d4d9bbcbfdb90b49adac71d
--
Lee Jones [李琼斯]
nge.
>
>
Applied, thanks!
[4/4] backlight: mp3309c: Fully initialize backlight_properties during probe
commit: 50a2c0aee92699ed47076636b652f9d27a20fbef
--
Lee Jones [李琼斯]
leds directory when CONFIG_NEW_LEDS is
set"
commit: 7a28f9cf6b7c8cad760b4d4ee7f53231cd76d8e4
[2/2] leds: expresswire: don't depend on NEW_LEDS
commit: 8cd0da0634222ceb434281f3034ad773ddfe0f4f
--
Lee Jones [李琼斯]
g struct static
commit: ed2ac75acf99d33444a5d440fcad4261ad6f0d5c
--
Lee Jones [李琼斯]
On Fri, 23 Feb 2024, Lee Jones wrote:
> On Thu, 08 Feb 2024, Andy Shevchenko wrote:
>
> > Allow to use driver on non-OF platforms and other cleanups.
> >
> > Changelog v3:
> > - rebased on top of the last changes against this driver (Lee)
> > - a
65c7fc4a7755d7
[2/3] backlight: mp3309c: use dev_err_probe() instead of dev_err()
commit: 73e209b9ef8743071e8a04aad48db6644f3c8ce0
[3/3] backlight: mp3309c: Utilise temporary variable for struct device
commit: 2a93258e20bb03016347a2e27e5d21ead3bfd2e4
--
Lee Jones [李琼斯]
..]
Applied, thanks!
[1/3] backlight: mp3309c: Make use of device properties
commit: b6fc7e62a7afc3709b31f6779665c7fc4a7755d7
[2/3] backlight: mp3309c: use dev_err_probe() instead of dev_err()
(no commit info)
[3/3] backlight: mp3309c: Utilise temporary variable for struct device
(no co
of dev_err()
> backlight: mp3309c: Utilise temporary variable for struct device
>
> drivers/video/backlight/mp3309c.c | 88 ---
> 1 file changed, 35 insertions(+), 53 deletions(-)
Sorry for the delay, I was on vacation and I've been fighting fires this
week.
This set still doesn't apply?
--
Lee Jones [李琼斯]
de
> > #include
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
>
--
Lee Jones [李琼斯]
p; !bd->ops->check_fb(bd, info))
> goto out;
> +#if IS_ENABLED(CONFIG_FB_BACKLIGHT)
I don't want #ifery in C files.
Please find another way.
> + else if (info->bl_dev && info->bl_dev != bd)
> + goto out;
> +#endif
>
> fb_blank = *(int *)evdata->data;
> if (fb_blank == FB_BLANK_UNBLANK && !bd->fb_bl_on[node]) {
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
On Thu, 22 Feb 2024, Rob Herring wrote:
> On Tue, Feb 20, 2024 at 08:30:38AM +, dharm...@microchip.com wrote:
> > Hi Lee,
> >
> > On 20/02/24 1:50 pm, Lee Jones wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > >
On Tue, 20 Feb 2024, dharm...@microchip.com wrote:
> Hi Lee,
>
> On 20/02/24 1:50 pm, Lee Jones wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> > content is safe
> >
> > On Tue, 20 Feb 2024, dharm...@microchip.
On Tue, 20 Feb 2024, dharm...@microchip.com wrote:
> Hi Krzysztof,
>
> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> > content is safe
> >
> > On 08/02/2024 11:43, Lee Jones wrot
klight and fbdev almost completely, but
> most of these changes are in the actual graphics drivers rather than the
> backlight core code. So hopefully everything can go through the DRM tree; or
> maybe the fbdev tree.
This is only acceptable if the maintainers of those trees can provide me
with a pull-request to a succinct (_only_ these patches) immutable
branch. If this is not possible, then I should like to merge the set
through the Backlight tree and I can provide everyone else with said PR.
--
Lee Jones [李琼斯]
On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> On Thu, Feb 08, 2024 at 06:14:55PM +0000, Lee Jones wrote:
> > On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > > On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote:
> > > > On Thu, 08 Feb 2024, Andy Shevchenko w
On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> On Thu, Feb 08, 2024 at 05:39:46PM +0000, Lee Jones wrote:
> > On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote:
> > > > On Thu, 01 F
On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> On Thu, Feb 08, 2024 at 11:34:25AM +0000, Lee Jones wrote:
> > On Thu, 01 Feb 2024, Andy Shevchenko wrote:
>
> ...
>
> > > backlight: mp3309c: Utilise temporary variable for struct device
>
> (1)
>
>
On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> On Thu, Feb 08, 2024 at 10:53:04AM +0000, Lee Jones wrote:
> > On Thu, 01 Feb 2024, Andy Shevchenko wrote:
>
> ...
>
> > Someone may wish to address this:
> >
> > WARNING: DT compatible string "him
- Bjorn Andersson
> + - Kiran Gunda
>
> description: |
>WLED (White Light Emitting Diode) driver is used for controlling display
Applied, thanks
--
Lee Jones [李琼斯]
variable for struct device
(no commit info)
--
Lee Jones [李琼斯]
anged, 35 insertions(+), 53 deletions(-)
Set no longer applies. Please rebase, thanks.
--
Lee Jones [李琼斯]
--
> 1 file changed, 27 insertions(+), 30 deletions(-)
Someone may wish to address this:
WARNING: DT compatible string "himax,hx8369" appears un-documented -- check
./Documentation/devicetree/bindings/
#58: FILE: drivers/video/backlight/hx8357.c:636:
+ .compatible = "himax,hx8369",
--
Lee Jones [李琼斯]
b0324d
[4/4] backlight: hx8357: Utilise temporary variable for struct device
commit: 27a4701c92250ae0aecb2edea1109f89cf344ba1
--
Lee Jones [李琼斯]
On Thu, 08 Feb 2024, Lee Jones wrote:
> On Wed, 31 Jan 2024 09:05:23 +0530, Dharma Balasubiramani wrote:
> > Convert the atmel,hlcdc binding to DT schema format.
> >
> > Align clocks and clock-names properties to clearly indicate that the LCD
> > controller expects l
> alignment with the specific hardware requirements ensures accurate device tree
> configuration for systems utilizing the HLCDC IP.
>
> [...]
Applied, thanks!
[3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
commit: cb946db1335b599ece363d33966bf653ed0fa58a
--
Lee Jones [李琼斯]
> alignment with the specific hardware requirements ensures accurate device tree
> configuration for systems utilizing the HLCDC IP.
>
> [...]
Applied, thanks!
[3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
commit: 7dd93269787781869d3dbb23138ec1455d26b047
--
Lee Jones [李琼斯]
Use pwm_apply_might_sleep()
commit: 7feb4ec8ec900daf29602bcdf7c04178c63205ac
--
Lee Jones [李琼斯]
commit: 7c0ff4ae24bf4589b5bb460e4b31817c61fa2bef
--
Lee Jones [李琼斯]
ire library
commit: e59a15af7aa690fa0997758df23069a9f0756c49
[3/4] dt-bindings: backlight: add Kinetic KTD2801 binding
commit: 4ac621a418ce8f4c562b50ea6f676196bd5262da
[4/4] backlight: Add Kinetic KTD2801 backlight support
commit: 66c76c1cd984c14660453dfa2118014817924375
--
Lee Jones [李琼斯]
ckam KR
> [manikanda...@microchip.com: Remove unused macro definitions]
> Signed-off-by: Manikandan Muralidharan
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 42
> include/linux/mfd/atmel-hlcdc.h | 10 +
Acked-by: Lee Jones
> 2 files c
---
> drivers/leds/leds-expresswire.c | 68 ++
> include/linux/leds-expresswire.h | 36
Please can you separate the Expresswire addition into its own patch?
> 7 files changed, 146 insertions(+), 90 deletions(-)
--
Lee Jones [李琼斯]
On Sun, 14 Jan 2024 16:39:21 +0200, Andy Shevchenko wrote:
> The "im" pins are optional. Add missing check in the hx8357_probe().
>
>
Applied, thanks!
[1/1] backlight: hx8357: Fix potential NULL pointer dereference
commit: 3b75d271e161e22aff8171940a77510d2fb2ad6f
--
Lee Jones [李琼斯]
evant to a single device (display for instance). Please move all
non-generic handling out to the relevant subsystems.
> drivers/video/fbdev/sm501fb.c | 106 +
> 2 files changed, 542 insertions(+)
--
Lee Jones [李琼斯]
t;
> > > On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote:
> > > > On Thu, Dec 21, 2023 at 12:58:01PM +, Lee Jones wrote:
> > > > > On Thu, 21 Dec 2023, Lee Jones wrote:
> > > > >
> > > > > > On Thu, 21 Dec
cb1d586379b4
--
Lee Jones [李琼斯]
s/video/fbdev/vermilion/cr_pll.c
> > delete mode 100644 drivers/video/fbdev/vermilion/vermilion.c
> > delete mode 100644 drivers/video/fbdev/vermilion/vermilion.h
>
> I've applied this patch to the fbdev git tree.
> It touches the backlight tree, so I hope it's ok for backlight people?
Better to ask for forgiveness than permission it seems! :)
--
Lee Jones [李琼斯]
bsub(dev, np, "crt");
> + fb_pnl = dt_fbsub(dev, np, "panel");
> + if (fb_crt || fb_pnl) {
> + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> + if (pdata) {
> + pdata->fb_route = fb_route;
> + pdata->flags = flags;
> + pdata->fb_crt = fb_crt;
> + pdata->fb_pnl = fb_pnl;
> + }
> + }
> + return pdata;
> +}
> +#endif
> +
> static int sm501fb_probe(struct platform_device *pdev)
> {
> struct sm501fb_info *info;
> @@ -1974,6 +2050,12 @@ static int sm501fb_probe(struct platform_device *pdev)
> if (info->edid_data)
> found = 1;
> }
> + /* Get platform data compatible configuration */
> + if (!found) {
> + info->pdata = pdata_from_dt(dev, np);
> + if (info->pdata)
> + found = 1;
> + }
> }
> #endif
> if (!found) {
> --
> 2.39.2
>
--
Lee Jones [李琼斯]
commit: 769ff5283f0d7edc819743f183d51af077411107
--
Lee Jones [李琼斯]
s for CHECK_FREQ_REG() instead
>
> [...]
Applied, thanks!
[1/1] backlight: ili922x: drop kernel-doc for local macros
commit: 64d9799d6dd04601227f602ae961e3f3d2f1f02b
--
Lee Jones [李琼斯]
e
> > s, spi_transfer x)(). Prototype was for CHECK_FREQ_REG() instead
> >
> > Signed-off-by: Randy Dunlap
> > Cc: Lee Jones
> > Cc: Daniel Thompson
> > Cc: Jingoo Han
> > Cc: Helge Deller
> > Cc: linux-fb...@vger.kernel.org
> > ---
> &
he following smatch
> warning:
>
> drivers/video/backlight/mp3309c.c:279 pm3309c_parse_dt_node() error:
> uninitialized symbol 'prop_levels'.
>
> [...]
Applied, thanks!
[1/1] backlight: mp3309c: fix uninitialized local variable
commit: ab47505ce45b869ab649024dc932e981fcdd6e5f
--
Lee Jones [李琼斯]
e dev_err_probe
commit: 58793f263abc8e5233fabf7466219202db09d048
--
Lee Jones [李琼斯]
pwm-beeper.c | 4 +--
> drivers/input/misc/pwm-vibra.c| 8 +++---
> drivers/leds/leds-pwm.c | 2 +-
> drivers/leds/rgb/leds-pwm-multicolor.c| 4 +--
Acked-by: Lee Jones
> drivers/media/rc/pwm-ir-tx.c
acklight: mp3309c: Add support for MPS MP3309C
commit: 2e914516a58cf86bd0e42c7d3e25c81d44ec2ab8
--
Lee Jones [李琼斯]
t; ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter
> for explanation.
> ---
> .../mfd/samsung,exynos5433-lpass.yaml | 2 +-
> .../bindings/sound/samsung-i2s.yaml | 19 ---
> 2 files changed, 13 insertions(+), 8 deletions(-)
Acked-by: Lee Jones
--
Lee Jones [李琼斯]
ies can then be moved to backlight/common.yaml.
>
> [...]
Applied, thanks!
[1/1] dt-bindings: backlight: add brightness-levels related common properties
commit: d5272d39995f4150062a67e6f2cef556edece740
--
Lee Jones [李琼斯]
M
> drivers usually refuse to suspend if they are still enabled.
>
> Also adapt shutdown and remove callbacks to disable the PWM for similar
> reasons.
>
> [...]
Applied, thanks!
[1/1] backlight: pwm_bl: Disable PWM on shutdown, suspend and remove
commit: 40da4737717b252fd01d
ode) or by a PWM input signal (PWM mode).
> This driver supports both modes.
>
> For device driver details, please refer to:
> - drivers/video/backlight/mp3309c_bl.c
>
> [...]
Applied, thanks!
[1/2] dt-bindings: backlight: Add MPS MP3309C
commit: 02c4e661658f73d3c266c68f89f0b14bd8ba6bd8
--
Lee Jones [李琼斯]
477d4bbf1b31035789da08680...@db9pr04mb8477.eurprd04.prod.outlook.com
> and picked up by b4.) Lee, can you fixup or should I resend?
I'll probably forget by the time Daniel gets around to review.
Your call, but probably safer to turn it around yourself.
--
Lee Jones [李琼斯]
1 - 100 of 1663 matches
Mail list logo
