In amdgpu_get_xgmi_hive(), we should not call kfree() after
kobject_put() as the PUT will call kfree().
In amdgpu_device_ip_init(), we need to check the returned *hive*
which can be NULL before we dereference it.
Signed-off-by: Liang He
---
v1->v2: we need the extra GET to keep *hive* al
*hive*
which can be NULL before we dereference it.
Signed-off-by: Liang He
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 4
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b
c5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
Signed-off-by: Liang He
Acked-by: Martin Blumenstingl
---
drivers/gpu/drm/meson/meson_drv.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/meson_drv.c
b/drivers/gpu/drm/mes
At 2022-07-26 03:39:17, "Martin Blumenstingl"
wrote:
>Hello,
>
>On Fri, Jul 15, 2022 at 3:22 PM Liang He wrote:
>>
>> In this function, there are two refcount leak bugs:
>> (1) when breaking out of for_each_endpoint_of_node(), we need call
>> the o
In dss_init_ports() and __dss_uninit_ports(), we should call
of_node_put() for the reference returned by of_graph_get_port_by_id()
in fail path or when it is not used anymore.
Fixes: 09bffa6e5192 ("drm: omap: use common OF graph helpers")
Signed-off-by: Liang He
---
drivers/gpu/drm/o
We should call of_node_put() for the reference returned by
of_graph_get_remote_endpoint() when it is not used anymore.
Fixes: e8d5bbf7f4c4 ("drm/sun4i: tcon: get TCON ID and matching engine with
remote endpoint ID")
Signed-off-by: Liang He
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 1
In ipu_add_client_devices(), we need to call of_node_put() for
reference returned by of_graph_get_port_by_id() in fail path.
Fixes: 17e052175039 ("gpu: ipu-v3: Do not bail out on missing optional port
nodes")
Signed-off-by: Liang He
---
In fact, there may be another problem in foll
Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
Signed-off-by: Liang He
---
changelog:
v2: (1) rebase with drm-misc-next advised by Robert Foss
(2) use proper title
(3) remove the v1's second bug ('ep0'), fixed recently
v1: https://lor
In tc_probe_bridge_endpoint(), we should call of_node_put() when
breaking out of the for_each_endpoint_of_node() which will automatically
increase and decrease the refcount.
Fixes: 71f7d9c03118 ("drm/bridge: tc358767: Detect bridge mode from connected
endpoints in DT")
Signed-off-by
At 2022-07-18 19:56:09, "Liang He" wrote:
>
>At 2022-07-18 19:54:18, "Robert Foss" wrote:
>>Hey Liang,
>>
>>
>>On Thu, 7 Jul 2022 at 03:25, Liang He wrote:
>>>
>>> There are two refcount bugs in this funcion:
>>
At 2022-07-18 19:55:16, "Robert Foss" wrote:
>On Mon, 18 Jul 2022 at 13:54, Robert Foss wrote:
>>
>> Hey Liang,
>>
>>
>> On Thu, 7 Jul 2022 at 03:25, Liang He wrote:
>> >
>> > There are two refcount bugs in this funcion:
>> >
At 2022-07-18 19:54:18, "Robert Foss" wrote:
>Hey Liang,
>
>
>On Thu, 7 Jul 2022 at 03:25, Liang He wrote:
>>
>> There are two refcount bugs in this funcion:
>>
>> BUG-1: 'pdata->mipi_host_node' will be assigned a new reference with
>
c5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
Signed-off-by: Liang He
---
drivers/gpu/drm/meson/meson_drv.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/meson_drv.c
b/drivers/gpu/drm/meson/meson_drv.c
index 1b70938cfd2c.
In dcss_dev_create() and dcss_dev_destroy(), we should call of_node_put()
in fail path or before the dcss's destroy as of_graph_get_port_by_id() has
increased the refcount.
Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
Signed-off-by: Liang He
---
chang
gt;laurentiu
>
>On Thu, Jul 07, 2022 at 10:32:14AM +0800, Liang He wrote:
>> In dcss_dev_create(), we should call of_node_put() in fail path for
>> of_graph_get_port_by_id() which will increase the refcount.
>>
>> Fixes: 9021c317b770 ("drm/imx: Add initial suppor
d decrease the refcount.
Fixes: ca454bd42dc2 ("drm/pl111: Support the Versatile Express")
Signed-off-by: Liang He
---
As 'Check-after-Put' has been widely accepted in kernel source, we just
use it. If the maintainer thinks it is harmful, I'd like also to use
'Check-a
i_dsi_device_register_full() for DSI
device creation")
Signed-off-by: Liang He
---
I have noticed that the of_node_get() is moved into
of_mipi_dsi_device_add() which then call above register func in
commit-c63ae8a9686b.
However, as there are different ways to directly call the register, I t
As the new reference created in 'dpu->base.port' will be escaped out,
we need not to call of_node_put() again.
Fixes: b07bcf34b6c9 ("drm/sprd: add Unisoc's drm display controller driver")
Signed-off-by: Liang He
---
drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
1 file
In tc_probe_bridge_endpoint(), we should call of_node_put() when
breaking out of the for_each_endpoint_of_node() which will automatically
increase and decrease the refcount.
Fixes: 71f7d9c03118 ("drm/bridge: tc358767: Detect bridge mode from connected
endpoints in DT")
Signed-off-by
In dcss_dev_create(), we should call of_node_put() in fail path for
of_graph_get_port_by_id() which will increase the refcount.
Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
Signed-off-by: Liang He
---
drivers/gpu/drm/imx/dcss/dcss-dev.c | 1 +
1 file
ge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
Signed-off-by: Liang He
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625
In valkyriefb_init(), of_find_node_by_name() will return a node pointer
with refcount incremented. We should use of_node_put() in fail path or
when it is not used anymore.
Signed-off-by: Liang He
---
drivers/video/fbdev/valkyriefb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
At 2022-06-16 17:20:24, conor.doo...@microchip.com wrote:
>On 16/06/2022 09:52, Liang He wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>> content is safe
>>
>> At 2022-06-16 16:43:43, "Greg KH" wrote:
>>> On
At 2022-06-16 16:43:43, "Greg KH" wrote:
>On Wed, Jun 15, 2022 at 10:30:47PM +0200, Daniel Vetter wrote:
>> On Wed, 15 Jun 2022 at 22:23, Dave Airlie wrote:
>> >
>> > On Wed, 15 Jun 2022 at 20:53, Greg KH wrote:
>> > >
>> > > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote:
>> > > > In
In tegra_uart_init(), of_find_matching_node() will return a node
pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.
Signed-off-by: Liang He
---
drivers/tty/serial/serial-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial
25 matches
Mail list logo
