Re: [bug report] drm/mcde: Add new driver for ST-Ericsson MCDE

2020-09-12 Thread Linus Walleij
On Mon, Aug 31, 2020 at 1:39 PM Dan Carpenter wrote: > Hello Linus Walleij, > > The patch 5fc537bfd000: "drm/mcde: Add new driver for ST-Ericsson > MCDE" from May 24, 2019, leads to the following static checker > warning: > > drivers/gpu/drm/mcde/mcde_displ

Re: [PATCH v2 3/6] drm: Add SPI DBI host driver

2020-09-09 Thread Linus Walleij
d be handled by the SPI core and set as cs-gpios in the device tree instead. It is certainly used exactly like a chip select as far as I can tell. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 1/6] dt-bindings: display: Document NewVision NV3052C DT node

2020-09-09 Thread Linus Walleij
ther they must all be present, or 'power-supply' must be > present. > - Reword description to avoid confusion about 'driver' > - Use 4-space indent in example > > Signed-off-by: Paul Cercueil Reviewed-by: Linus Walleij > +reset-gpios = < 2 GPIO_AC

Re: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-09-09 Thread Linus Walleij
thing else works and data sheets are incomplete I just take out a ruler and measure on the actual device. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/panel: s6e63m0: Fix up DRM_DEV* regression

2020-09-06 Thread Linus Walleij
Ooops the panel drivers stopped to use DRM_DEV* messages and we predictably create errors by merging code that still use it. Signed-off-by: Linus Walleij --- .../gpu/drm/panel/panel-samsung-s6e63m0-dsi.c | 28 +-- .../gpu/drm/panel/panel-samsung-s6e63m0-spi.c | 8

Re: [PATCH 0/4] drm/panel: s6e63m0: Add DSI transport

2020-09-01 Thread Linus Walleij
On Thu, Aug 27, 2020 at 11:04 AM Linus Walleij wrote: > On Tue, Aug 18, 2020 at 7:10 PM Sam Ravnborg wrote: > > > How does this patchset relate to the patchset posted by Paul? > > https://lore.kernel.org/dri-devel/20200727164613.19744-1-p...@crapouillou.net/ > > Not

Re: [PATCH] drm/tve200: Stabilize enable/disable

2020-09-01 Thread Linus Walleij
On Thu, Aug 20, 2020 at 10:32 PM Linus Walleij wrote: > The TVE200 will occasionally print a bunch of lost interrupts > and similar dmesg messages, sometimes during boot and sometimes > after disabling and coming back to enablement. This is probably > because the hardware is left i

Re: [PATCH 2/2] drm/tve200: Fix handling of platform_get_irq() error

2020-08-28 Thread Linus Walleij
On Thu, Aug 27, 2020 at 9:11 AM Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: 179c02fe90a4 ("drm/tve200: Add new driver for TVE200") > Signed-off-by: Krzysztof Kozlowski Acked-

Re: [PATCH 1/2] drm/mcde: Fix handling of platform_get_irq() error

2020-08-28 Thread Linus Walleij
On Thu, Aug 27, 2020 at 9:11 AM Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") > Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v2 0/24] backlight: add init macros and accessors

2020-08-28 Thread Linus Walleij
patchset to show how the > new functions are used. > > Diffstat for the drm bits alone looks nice: > 25 files changed, 243 insertions(+), 460 deletions(-) > > Feedback welcome! Thank you for trying to make backlight easier for developers. I am a big supporter of this type of si

Re: [PATCH v2 10/24] drm/panel: novatek-nt35510: Backlight update

2020-08-27 Thread Linus Walleij
On Sun, Aug 23, 2020 at 12:46 PM Sam Ravnborg wrote: > - Replace direct access to backlight_properties with > backlight_get_brightness(). > - Drop debug printout > - Use macro for initialization > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Re

Re: [PATCH 0/4] drm/panel: s6e63m0: Add DSI transport

2020-08-27 Thread Linus Walleij
ework it into Paul's framework when that arrives. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] backlight: tosa_lcd: Include the right header

2020-08-26 Thread Linus Walleij
The Tosa backlight LCDE driver was converted to use GPIO descriptors in 0b0cb52bd80eda76c4b9921f5cf9c1b709d44e83 ("video: backlight: tosa: Use GPIO lookup table") but still includes rather than . Fix it. Cc: Arnd Bergmann Cc: Robert Jarzmik Signed-off-by: Linus Walleij --- dri

[PATCH] backlight: tosa_bl: Include the right header

2020-08-26 Thread Linus Walleij
The Tosa backlight driver was converted to use GPIO descriptors in 0b0cb52bd80eda76c4b9921f5cf9c1b709d44e83 ("video: backlight: tosa: Use GPIO lookup table") but still includes rather than . Fix it. Cc: Arnd Bergmann Cc: Robert Jarzmik Signed-off-by: Linus Walleij --- drivers/video

[PATCH v6] backlight: lms283gf05: Convert to GPIO descriptors

2020-08-26 Thread Linus Walleij
in the board file GPIO descriptor table (active low) and assert the reset line by bringing it to "1" (asserted). Cc: Marek Vasut Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Reviewed-by: Daniel Thompson Signed-off-by: Linus Walleij --- ChangeLog v5->v6: - Rebase

Re: [PATCH v2 5/6] drm/panel: Add panel driver for NewVision NV3052C based LCDs

2020-08-24 Thread Linus Walleij
lingo. https://www.iacr.org/workshops/ches/ches2002/presentations/Huang.pdf What about naming it nv3052c_jam_table[] or nv3052c_jam[]? Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/tve200: Stabilize enable/disable

2020-08-20 Thread Linus Walleij
/enable cycle rock solid on the D-Link DIR-685. Tested extensively. Cc: sta...@vger.kernel.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/tve200/tve200_display.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tve200/tve200_display.c

[PATCH 3/3 v3] backlight: Add Kinetic KTD253 backlight driver

2020-08-19 Thread Linus Walleij
-off-by: Linus Walleij --- ChangeLog v2->v3: - Collect Daniel's review tag. ChangeLog v1->v2: - Expose the 32 actual hardware levels of brightness directly instead of using an interpolated "brightness" table. - Use the new backlight_get_brightness() helper. - Call backlig

[PATCH 1/3 v3] dt-bindings: backlight: Add some common backlight properties

2020-08-19 Thread Linus Walleij
Let's use a common.yaml include for the backlight like we do with the LEDs. The LEDs are inherently incompatible so their bindings cannot be reused for backlight. Cc: devicet...@vger.kernel.org Suggested-by: Sam Ravnborg Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - D

[PATCH 2/3 v3] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-19 Thread Linus Walleij
This adds device tree bindings for the Kinetic KTD253 white LED backlight driver. Cc: devicet...@vger.kernel.org Cc: Sam Ravnborg Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Drop the pointless cargo-culted "default-on" property that we were not using - Correct t

Re: [PATCH 1/3 v2] dt-bindings: backlight: Add some common backlight properties

2020-08-19 Thread Linus Walleij
On Wed, Aug 12, 2020 at 5:46 PM Rob Herring wrote: > On Wed, Aug 12, 2020 at 2:58 AM Linus Walleij > wrote: > > > > Let's use a common.yaml include for the backlight like we do with > > the LEDs. The LEDs are inherently incompatible so their bindings > >

[PATCH] drm/panel: s6e63m0: Order enable/disable sequence

2020-08-17 Thread Linus Walleij
display on like the vendor driver does. Also use the timings from the vendor driver in the sequence. Doing all of these things makes the display much more stable on the Samsung GT-I8190 when enabling/disabling the display pipeline. Cc: Paweł Chmiel Cc: Stephan Gerhold Signed-off-by: Linus Walleij

Re: [PATCH v1 1/5] drm/panel: samsung: Use dev_ based logging

2020-08-15 Thread Linus Walleij
g > Cc: Guido Günther > Cc: Linus Walleij > Cc: Laurent Pinchart At one point I was told to not use dev_* but use DRM_DEV* macros instead. "OK the DRM people want it this way, no big deal." But I'd rather do it like this so: Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH v2] drm/mcde: Retry DSI read/write transactions

2020-08-14 Thread Linus Walleij
. Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Retry three times. - Only retry the actual command transmission like the vendor driver does, no need to set up all registers and do checks all over. Break out a part of the mcde_dsi_host_transfer() funct

Re: [PATCH] drm/panel-notatek-nt35510: Fix MTP read init

2020-08-12 Thread Linus Walleij
should do this, least to avoid surprises and stuff > when they do the next pull request. And yeah a quick ping on irc > should be enough to make it happen. It's vacation time on the northern hemisphere so we can cut them some slack. Thanks! Linus Walleij ___

Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-12 Thread Linus Walleij
acklight bindings to DT > schema") > > Rob did not see the need for a common binding - but that may change as > we add more backlight bindings. It can't hurt. The proposal is out there, there are some drivers in backlight that can readily be converted to use it

[PATCH 1/3 v2] dt-bindings: backlight: Add some common backlight properties

2020-08-12 Thread Linus Walleij
Let's use a common.yaml include for the backlight like we do with the LEDs. The LEDs are inherently incompatible so their bindings cannot be reused for backlight. Cc: devicet...@vger.kernel.org Suggested-by: Sam Ravnborg Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - New pa

[PATCH 2/3 v2] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-12 Thread Linus Walleij
This adds device tree bindings for the Kinetic KTD253 white LED backlight driver. Cc: devicet...@vger.kernel.org Cc: Sam Ravnborg Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Create common.yaml for backlight as suggested by Sam and use that. - Rename the GPIO line "enab

[PATCH 3/3 v2] backlight: Add Kinetic KTD253 backlight driver

2020-08-12 Thread Linus Walleij
The Kinetic KTD253 backlight driver is controlled with a single GPIO line, but still supports a range of brightness settings by sending fast pulses on the line. This is based off the source code release for the Samsung GT-S7710 mobile phone. Cc: Sam Ravnborg Signed-off-by: Linus Walleij

Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-12 Thread Linus Walleij
ss = 24 if the top 8 values cannot be distinguished >visually). I think I will opt for this. It makes most sense given how we use the device tree to restrict maximum brightness, and that is definitely related to the hardware max brightness. Thanks Daniel! Linus Walleij _

Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-12 Thread Linus Walleij
sed for backlight. Backlight doesn't have "triggers", patterns, flash properties, the function is also pretty much evident. So I will look into creating a new common for backlight. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists

Re: [PATCH] drm/panel-notatek-nt35510: Fix MTP read init

2020-08-11 Thread Linus Walleij
On Mon, Aug 10, 2020 at 3:04 PM Daniel Vetter wrote: > On Sun, Aug 09, 2020 at 12:43:22AM +0200, Linus Walleij wrote: > > In order to successfully read ID of the MTP panel the > > panel MTP control page must be unlocked. Previously > > this wasn't encountered

[PATCH 2/4] drm/panel: s6e63m0: Add DSI transport

2020-08-09 Thread Linus Walleij
This makes it possible to use the s6e63m0 panel with a DSI host, such as in the Samsung GT-I8190 (Golden) mobile phone. Cc: Stephan Gerhold Cc: Paweł Chmiel Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/Kconfig | 8 ++ drivers/gpu/drm/panel/Makefile

[PATCH 4/4] drm/panel: s6e63m0: Add code to identify panel

2020-08-09 Thread Linus Walleij
We add code to identify a few different panels mounted on the s6e63m0 controller. This is necessary to achieve the proper biasing with DSI versions of the panel. Cc: Stephan Gerhold Cc: Paweł Chmiel Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 61

[PATCH 3/4] drm/panel: s6e63m0: Add reading functionality

2020-08-09 Thread Linus Walleij
This adds code to send read commands to read a single byte from the display, in order to perform MTP ID look-up of the mounted panel on the s6e63m0 controller. This is needed for proper biasing on the DSI variants. Cc: Stephan Gerhold Cc: Paweł Chmiel Signed-off-by: Linus Walleij --- .../gpu

[PATCH 0/4] drm/panel: s6e63m0: Add DSI transport

2020-08-09 Thread Linus Walleij
on different display types and handling of the ESD IRQ. But let's begin with this. Linus Walleij (4): drm/panel: s6e63m0: Break out SPI transport drm/panel: s6e63m0: Add DSI transport drm/panel: s6e63m0: Add reading functionality drm/panel: s6e63m0: Add code to identify panel drivers/gpu

[PATCH 1/4] drm/panel: s6e63m0: Break out SPI transport

2020-08-09 Thread Linus Walleij
. We make the Kconfig entry for SPI mode default so all current users will continue to work. Cc: Stephan Gerhold Cc: Paweł Chmiel Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/Kconfig | 15 +++- drivers/gpu/drm/panel/Makefile| 1 + .../gpu/drm/panel

[PATCH] drm/panel-notatek-nt35510: Fix MTP read init

2020-08-08 Thread Linus Walleij
...@protonmail.com Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35510.c b/drivers/gpu/drm/panel/panel-novatek-nt35510.c index 4a8fa908a2cf

[PATCH 4/4 v2] drm/mcde: Enable the DSI link with display

2020-08-08 Thread Linus Walleij
, this gives working display on the Samsung GT-I8190 (Golden) phone. It has also been tested working on the Samsung GT-S7710 (Skomer) phone. Cc: newby...@protonmail.com Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_display.c | 36 +-- drivers/gpu/drm

[PATCH 3/4 v2] drm/mcde: Fix display pipeline restart

2020-08-08 Thread Linus Walleij
its display, cutting all power while disabled and re-initializing the hardware when coming back up. Cc: newby...@protonmail.com Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Put the EPOD regulator disable call after registering the subcompontents (the DSI po

[PATCH 1/4 v2] drm/mcde: Improve pixel fetcher FIFO depth setting

2020-08-08 Thread Linus Walleij
BPP framebuffers. Cc: newby...@protonmail.com Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_display.c | 34 + 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde

[PATCH 2/4 v2] drm/mcde: Support using DSI in LP mode

2020-08-08 Thread Linus Walleij
It is possible to set a flag in the struct mipi_dsi_device so the panel is handled in low power (LP) mode. Some displays only support this mode and it is also good for testing. Cc: newby...@protonmail.com Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_dsi.c | 10

Re: [PATCH] drm/panel-notatek-nt35510: Fix enable/disable sequence

2020-08-08 Thread Linus Walleij
On Wed, Aug 5, 2020 at 4:28 PM Linus Walleij wrote: > The driver was relying on only prepare()/unprepare() to > enable/disable the display. > > This does not work because prepare() will be called > before the DSI host/bridge is ready to send any DSI > commands and disable() wi

[PATCH] drm/mcde: Fix display pipeline restart

2020-08-05 Thread Linus Walleij
Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_display.c | 16 ++ drivers/gpu/drm/mcde/mcde_drv.c | 14 + drivers/gpu/drm/mcde/mcde_dsi.c | 48 + 3 files changed, 59 insertions(+), 19 deletions(-) diff --git a/drivers/gpu

[PATCH] drm/panel-notatek-nt35510: Fix enable/disable sequence

2020-08-05 Thread Linus Walleij
sequence. Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 107 +++--- 1 file changed, 68 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35510.c b/drivers/gpu/drm/panel/panel-novatek-nt35510.c index

Re: [PATCH v1 14/22] drm/panel: sony-acx424akp: Backlight update

2020-08-04 Thread Linus Walleij
ted comments > that are no longer valid. The only correct way to enable/disable > backlight is using the backlight enable/disable helpers. > - Use macro for backlight initialization > > Signed-off-by: Sam Ravnborg > Linus Walleij > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Sam Rav

Re: [PATCH v1 08/22] drm/panel: novatek-nt35510: Backlight update

2020-08-04 Thread Linus Walleij
On Sun, Aug 2, 2020 at 1:07 PM Sam Ravnborg wrote: > - Replace direct access to backlight_properties with > backlight_get_brightness(). > - Drop debug printout > - Use macro for initialization > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Re

Re: [PATCH] drm/panel: remove return value of function drm_panel_add

2020-08-01 Thread Linus Walleij
e will never run. > > Signed-off-by: Bernard Zhao Makes sense. Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/mcde: Retry DSI read/write transactions

2020-07-30 Thread Linus Walleij
. Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_dsi.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c index 337c4c5e3947..76fecd7ab658 100644 --- a/drivers

[PATCH 1/2 v2] drm/mcde: Rename flow function

2020-07-29 Thread Linus Walleij
The function mcde_display_send_one_frame() has a historical name that stems from being implemented when the driver only supported single frame updates. Rename it mcde_start_flow() so that it reflects the current usage. Reviewed-by: Stephan Gerhold Signed-off-by: Linus Walleij --- ChangeLog v1

[PATCH 2/2 v2] drm/mcde: Fix display data flow control

2020-07-29 Thread Linus Walleij
to the vendor driver. This has been tested and works fine with the command mode displays I have. (All that are supported upstream.) Reported-by: Stephan Gerhold Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Select the formatter as synchronization source for the video f

[PATCH 2/2] drm/mcde: Fix display data flow control

2020-07-28 Thread Linus Walleij
-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_display.c | 107 +--- drivers/gpu/drm/mcde/mcde_drm.h | 26 ++- drivers/gpu/drm/mcde/mcde_drv.c | 3 - drivers/gpu/drm/mcde/mcde_dsi.c | 18 - 4 files changed, 104 insertions(+), 50 deletions(-) diff --git

[PATCH 1/2] drm/mcde: Rename flow function

2020-07-28 Thread Linus Walleij
The function mcde_display_send_one_frame() has a historical name that stems from being implemented when the driver only supported single frame updates. Rename it mcde_start_flow() so that it reflects the current usage. Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde

[PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-07-20 Thread Linus Walleij
This adds device tree bindings for the Kinetic KTD253 white LED backlight driver. Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- .../leds/backlight/kinetic,ktd253.yaml| 48 +++ 1 file changed, 48 insertions(+) create mode 100644 Documentation

[PATCH 2/2 v1] backlight: Add Kinetic KTD253 backlight driver

2020-07-20 Thread Linus Walleij
The Kinetic KTD253 backlight driver is controlled with a single GPIO line, but still supports a range of brightness settings by sending fast pulses on the line. This is based off the source code release for the Samsung GT-S7710 mobile phone. Signed-off-by: Linus Walleij --- MAINTAINERS

[PATCH v2] drm: pl111: Update documentation

2020-07-20 Thread Linus Walleij
Remove notes about migrating from the old driver which is retired as all users are now migrated. Update the text to reflect that we support PL110 and PL111 alike. Drop the bullet on memory bandwidth scaling: this has been implemented. Cc: Russell King Signed-off-by: Linus Walleij

[PATCH] drm/mcde: Fix stability issue

2020-07-18 Thread Linus Walleij
...@vger.kernel.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_display.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde/mcde_display.c index 212aee60cf61..1d8ea8830a17 100644 --- a/drivers/gpu/drm/mcde

Re: [PATCH 1/2] drm/msm: sync generated headers

2020-07-11 Thread Linus Walleij
On Tue, Jul 7, 2020 at 10:36 PM Rob Clark wrote: > From: Rob Clark > > We haven't sync'd for a while.. pull in updates to get definitions for > some fields in pkt7 payloads. > > Signed-off-by: Rob Clark Out of curiosity : where are the syncs coming from? Mesa? Yo

[PATCH] omapfb/dss: Include the right header

2020-07-06 Thread Linus Walleij
The hdmi4.c and hdmi5.c files include the legacy GPIO header but does not use any of the symbols from this file. What it does use is the implicit inclusion of leading to compile errors if we just drop this include. Include the right header. Cc: Tony Lindgren Signed-off-by: Linus Walleij

[PATCH v3] drm: gma500: Convert to GPIO descriptors

2020-07-03 Thread Linus Walleij
. Apparently GPIOs 128 and 34 are used on all of these so just go ahead and register those for resetting the DSI pipes. Acked-by: Patrik Jakobsson Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Actually commit the last comment fix. --- drivers/gpu/drm/gma500/mdfld_device.c |

[PATCH v2] drm: gma500: Convert to GPIO descriptors

2020-07-03 Thread Linus Walleij
. Apparently GPIOs 128 and 34 are used on all of these so just go ahead and register those for resetting the DSI pipes. Acked-by: Patrik Jakobsson Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Fix comments --- drivers/gpu/drm/gma500/mdfld_device.c | 20 + drivers/gpu/drm/gma

Re: [PATCH v6 00/13] Add support for PinePhone LCD panel

2020-07-01 Thread Linus Walleij
ply clean on top of drm-misc-next - due to > > vrefresh removal. > > Please re-spin. > > Sorry for that. Rebased and retested. Sam will you apply it? I was in the middle of applying and ran into the same issue :D Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > Pinephone has a Goodix GT917S capacitive touchscreen controller on > I2C0 bus. Add support for it. > > Signed-off-by: Ondrej Jirman Acked-by: Linus Walleij Yours, Linus Walleij _

Re: [PATCH v5 12/13] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone

2020-07-01 Thread Linus Walleij
> Signed-off-by: Icenowy Zheng > Signed-off-by: Martijn Braam > Signed-off-by: Ondrej Jirman Acked-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > The reset pin is inverted, so if we don't assert reset, the actual gpio > will be high and may keep driving the IO port of the panel. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, L

Re: [PATCH v5 10/13] drm/panel: st7703: Enter sleep after display off

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > The datasheet suggests to issue sleep in after display off > as a part of the panel's shutdown sequence. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij ___

Re: [PATCH v5 08/13] drm/panel: st7703: Move generic part of init sequence to enable callback

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > Calling sleep out and display on is a controller specific part > of the initialization process. Move it out of the panel specific > initialization function to the enable callback. > > Signed-off-by: Ondrej Jirman Reviewed-by

Re: [PATCH v5 09/13] drm/panel: st7703: Add support for Xingbangda XBD599

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in > PinePhone. Add support for it. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij

Re: [PATCH v5 07/13] drm/panel: st7703: Move code specific to jh057n closer together

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > It's better than having it spread around the driver. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freede

Re: [PATCH v5 06/13] drm/panel: st7703: Prepare for supporting multiple panels

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > Parametrize the driver so that it can support more panels based > on st7703 controller. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-d

Re: [PATCH v5 05/13] drm/panel: st7703: Rename functions from jh057n prefix to st7703

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > This is done so that code that's not specific to a particular > jh057n panel is named after the controller. Functions specific > to the panel are kept named after the panel. > > Signed-off-by: Ondrej Jirman Reviewed-by

Re: [PATCH v5 04/13] drm/panel: rocktech-jh057n00900: Rename the driver to st7703

2020-07-01 Thread Linus Walleij
Signed-off-by: Ondrej Jirman This is the right thing to do. Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: gma500: Convert to GPIO descriptors

2020-06-27 Thread Linus Walleij
. Apparently GPIOs 88 and 34 are used on all of these so just go ahead and register those for resetting the DSI pipes. Cc: Patrik Jakobsson Signed-off-by: Linus Walleij --- drivers/gpu/drm/gma500/mdfld_device.c | 20 + drivers/gpu/drm/gma500/mdfld_dsi_dpi.c| 2 +- drivers/gpu/drm/gma500

Re: [PATCH] drm: gma500: Drop surplus include

2020-06-27 Thread Linus Walleij
On Sat, Jun 27, 2020 at 10:07 PM Patrik Jakobsson wrote: > On Sat, Jun 27, 2020 at 12:01 AM Linus Walleij > wrote: > > > > This file includes but does not use any > > symbols from it, drop the include. > > Hi Linus, > Seems the include should be moved to mdf

[PATCH] drm: omapdrm: Delete surplus GPIO includes

2020-06-26 Thread Linus Walleij
The OMAP DRM driver includes into the two hdmi4.c and hdmi5.c files but does not use any symbols from these files. Drop the includes. Cc: Tomi Valkeinen Cc: Tony Lindgren Cc: Jyri Sarha Signed-off-by: Linus Walleij --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - drivers/gpu/drm/omapdrm/dss

[PATCH] drm: gma500: Drop surplus include

2020-06-26 Thread Linus Walleij
This file includes but does not use any symbols from it, drop the include. Cc: Patrik Jakobsson Signed-off-by: Linus Walleij --- drivers/gpu/drm/gma500/psb_intel_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500

[PATCH 1/2] backlight: sky81452: Convert to GPIO descriptors

2020-06-26 Thread Linus Walleij
The SKY81452 backlight driver just obtains a GPIO (named "gpios" in the device tree) drives it high and leaves it high until the driver is removed. Switch to use GPIO descriptors for this, simple and straight-forward. Cc: Gyungoh Yoo Signed-off-by: Linus Walleij --- drivers/video

[PATCH 2/2] backlight: sky81452: Privatize platform data

2020-06-26 Thread Linus Walleij
The only way the platform data for the SKY81452 ever gets populated is through the device tree. The MFD device is bothered with this for no reason at all. Just allocate the platform data in the driver and be happy. Cc: Gyungoh Yoo Signed-off-by: Linus Walleij --- drivers/mfd/sky81452.c

[PATCH] backlight: Delete the OT200 backlight driver

2020-06-26 Thread Linus Walleij
IO drivers. Delete this unused driver. Cc: Christian Gmeiner Signed-off-by: Linus Walleij --- drivers/video/backlight/Kconfig| 7 -- drivers/video/backlight/Makefile | 1 - drivers/video/backlight/ot200_bl.c | 162 - 3 files changed, 170 deletions(-) delete m

[PATCH] backlight: lms501kf03: Drop unused include

2020-06-25 Thread Linus Walleij
This driver includes but does not use any symbols from that file, drop the include. Signed-off-by: Linus Walleij --- drivers/video/backlight/lms501kf03.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/backlight/lms501kf03.c b/drivers/video/backlight/lms501kf03.c index

[PATCH v5] backlight: lms283gf05: Convert to GPIO descriptors

2020-06-25 Thread Linus Walleij
in the board file GPIO descriptor table (active low) and assert the reset line by bringing it to "1" (asserted). Cc: Marek Vasut Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Reviewed-by: Daniel Thompson Signed-off-by: Linus Walleij --- ChangeLog v4->v5: - Rebas

Re: [PATCH 1/4] drm/bridge: ti-sn65dsi86: Don't compile GPIO bits if not CONFIG_OF_GPIO

2020-06-20 Thread Linus Walleij
t; Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux") > Reported-by: kernel test robot > Signed-off-by: Douglas Anderson Fair enough, Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: mcde: Fix display initialization problem

2020-06-14 Thread Linus Walleij
On Sun, Jun 14, 2020 at 9:44 AM Sam Ravnborg wrote: > Hi Linus. > > On Sun, Jun 14, 2020 at 12:30:26AM +0200, Linus Walleij wrote: > > The following bug appeared in the MCDE driver/display > > initialization during the recent merge window. > > > > First the plac

[PATCH 1/2] drm: mcde: Fix display initialization problem

2020-06-13 Thread Linus Walleij
[] (try_to_bring_up_master+0x15c/0x1a4) (...) Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 84f3e2dbd77b..80082d6dce3a 100644 --- a/drivers/gpu/drm

[PATCH 2/2] drm: mcde: Fix forgotten user of drm->dev_private

2020-06-13 Thread Linus Walleij
5cfe7b ("drm/mcde: Don't use drm_device->dev_private") Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde/mcde_display.c index b319a47

Re: [PATCH 4/4] drm: pl111: Update documentation

2020-06-12 Thread Linus Walleij
erflow.com/a/37406982] > > url: > https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-pl111-Credit-where-credit-is-due/20200610-041025 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git > exynos-drm-next > reproduce: make htmldocs

Re: [PATCH 4/4] drm: pl111: Update documentation

2020-06-09 Thread Linus Walleij
tor which is running a full Android stack using this driver. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 4/4] drm: pl111: Update documentation

2020-06-09 Thread Linus Walleij
Remove notes about migrating from the old driver which is retired as all users are now migrated. Update the text to reflect that we support PL110 and PL111 alike. Drop the bullet on memory bandwidth scaling: this has been implemented. Cc: Russell King Signed-off-by: Linus Walleij --- drivers

[PATCH 2/4] video: fbdev: amba-clcd: Retire elder CLCD driver

2020-06-09 Thread Linus Walleij
and it took a little more than 3 years to do this properly without leaving any platforms behind. Cc: Russell King Signed-off-by: Linus Walleij --- As the framebuffer subsystem is orphaned I expect this to go in through the drm-misc tree. --- MAINTAINERS | 5 - drivers/video

[PATCH 3/4] drm: pl111: Absorb the external register header

2020-06-09 Thread Linus Walleij
The PL111 DRM driver is now the sole user of the external CLCD registers header file, so let's absorb that into the pl111_drm.h file and save the external include. Cc: Russell King Signed-off-by: Linus Walleij --- drivers/gpu/drm/pl111/pl111_debugfs.c | 1 - drivers/gpu/drm/pl111

[PATCH 1/4] drm: pl111: Credit where credit is due

2020-06-09 Thread Linus Walleij
This moves over some of the credit for the development of this driver from the old fbdev driver that I used as reference when getting this in place. Cc: Russell King Signed-off-by: Linus Walleij --- drivers/gpu/drm/pl111/pl111_versatile.c | 9 + 1 file changed, 9 insertions(+) diff

Re: [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

2020-06-09 Thread Linus Walleij
On Tue, Jun 9, 2020 at 4:04 PM Rob Clark wrote: > On Tue, Jun 9, 2020 at 5:48 AM Linus Walleij wrote: > > On Tue, May 5, 2020 at 10:27 AM Linus Walleij > > wrote: > > > On Wed, Apr 8, 2020 at 9:15 PM Arnd Bergmann wrote: > > > > > > > I ran into

Re: [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

2020-06-09 Thread Linus Walleij
On Tue, May 5, 2020 at 10:27 AM Linus Walleij wrote: > On Wed, Apr 8, 2020 at 9:15 PM Arnd Bergmann wrote: > > > I ran into a randconfig link error with debugfs disabled: > > > > arm-linux-gnueabi-ld: > > drivers/gpu/drm/msm/msm_gpu.o: in function `should_dump

Re: [PATCH] drm: pl111: add CONFIG_VEXPRESS_CONFIG dependency

2020-05-27 Thread Linus Walleij
; Add a dependency that links to this only if the dependency is there, > and prevent the configuration where the drm driver is built-in but > the config is a loadable module. > > Fixes: 826fc86b5903 ("drm: pl111: Move VExpress setup into versatile init") > Signed-off-by: Arnd

Re: [PATCH v3 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller)

2020-05-26 Thread Linus Walleij
. Further I wrote: You should definately insert code to read the MTP bytes: 0xDA manufacturer 0xDB driver version 0xDC LCD module/driver And print these, se e.g. my newly added NT35510 driver or the Sony ACX424AKP driver. So please do that. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 2/5] dt-bindings: panel: Add binding for Xingbangda XBD599 panel

2020-05-26 Thread Linus Walleij
off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/21] drm/mcde: Use GEM CMA object functions

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 2:51 PM Thomas Zimmermann wrote: > Am 25.05.20 um 13:36 schrieb Linus Walleij: > > On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann > > wrote: > > > >> The mcde driver uses the default implementation for CMA functions. The > >>

Re: [PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

2020-05-25 Thread Linus Walleij
; Signed-off-by: dillon min This looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 4/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 5:46 AM wrote: > From: dillon min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: dillon min This looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-dev

Re: [PATCH 20/21] drm/tv200: Use GEM CMA object functions

2020-05-25 Thread Linus Walleij
> Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

<    1   2   3   4   5   6   7   8   9   10   >