Re: [PATCH 12/21] drm/mcde: Use GEM CMA object functions

2020-05-25 Thread Linus Walleij
> Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight

2020-05-25 Thread Linus Walleij
On Mon, May 18, 2020 at 12:16 PM Sam Ravnborg wrote: > Hi Linus. > > On Mon, May 18, 2020 at 10:10:12AM +0200, Linus Walleij wrote: > > On Sun, May 17, 2020 at 9:01 PM Sam Ravnborg wrote: > > > > > Look up backlight device using devm_of_find_backlight().

Re: [PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight

2020-05-18 Thread Linus Walleij
borg > Cc: Russell King > Cc: Sam Ravnborg > Cc: Bartlomiej Zolnierkiewicz > Cc: Peter Ujfalusi > Cc: Daniel Vetter > Cc: Linus Walleij > Cc: Jani Nikula > Cc: Douglas Anderson Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-14 Thread Linus Walleij
iver in one SPI part and one DSI part: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git/commit/?h=ux500-skomer-v5.7-rc1=6c0e1fb5df5fa8fa857dee65f6c0f54d06d158a7 https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git/commit/?h=ux500-skomer-v5.7-rc1

Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board

2020-05-14 Thread Linus Walleij
"tx"; These DMA assignments seem to be SoC things and should rather be in the DTS(I) file where is defined, right? stm32f429.dtsi I suppose? It is likely the same no matter which device is using spi5. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 2/5] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-14 Thread Linus Walleij
On Tue, May 12, 2020 at 9:03 AM wrote: > From: dillon min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: dillon min This looks good to me. Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-dev

Re: [PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-14 Thread Linus Walleij
gt; + case 180: > + addr_mode = ILI9341_MADCTL_MY; > + break; > + case 270: > + addr_mode = ILI9341_MADCTL_MV | ILI9341_MADCTL_MY | > + ILI9341_MADCTL_MX; > + break; > + } > + addr

Re: [PATCH v5 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-05-12 Thread Linus Walleij
functions are things that the > bridge chip driver itself would care about and it can just configure > the pins as needed. > > Signed-off-by: Douglas Anderson > Cc: Linus Walleij > Cc: Bartosz Golaszewski Looks good mostly! > + pdata->gchip.label = dev_name(p

Re: [PATCH v4 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-05-12 Thread Linus Walleij
designers are like programmers and start on 0. Never the twain shall meet... Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

2020-05-12 Thread Linus Walleij
ongjun > --- > v1 - > v2: add fixes and fix the subject Already applied v1, no big deal anyways, its a nonurgent fix. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] drm/mcde: dsi: Fix return value check in dev_err()

2020-05-12 Thread Linus Walleij
anks Wei, sorry for the long delay. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4] backlight: lms283gf05: Convert to GPIO descriptors

2020-05-11 Thread Linus Walleij
in the board file GPIO descriptor table (active low) and assert the reset line by bringing it to "1" (asserted). Cc: Marek Vasut Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Linus Walleij --- ChangeLog v3->v4: - Check IS_ERR() on the returned GP

Re: [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

2020-05-05 Thread Linus Walleij
e helper to only look at this variable if debugfs is present. > > Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP > buffers") > Signed-off-by: Arnd Bergmann This fixes a compilation error for me on the APQ8060. Test

[PATCH v3] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Linus Walleij
in the board file GPIO descriptor table (active low) and assert the reset line by bringing it to "1" (asserted). Cc: Marek Vasut Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Fix a use-before-allocated bug discovered by

[PATCH v2] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Linus Walleij
in the board file GPIO descriptor table (active low) and assert the reset line by bringing it to "1" (asserted). Cc: Marek Vasut Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Bring up the GPIO de-asserted in probe()

Re: [PATCH] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Linus Walleij
On Wed, Apr 29, 2020 at 1:33 PM Daniel Thompson wrote: > On Wed, Apr 29, 2020 at 10:26:31AM +0200, Linus Walleij wrote: > > - if (pdata != NULL) { > > - ret = devm_gpio_request_one(>dev, pdata->reset_gpio, > > - GPIOF_DIR_OU

[PATCH] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Linus Walleij
in the board file GPIO descriptor table (active low) and assert the reset line by bringing it to "1" (asserted). Cc: Marek Vasut Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Linus Walleij --- Marek: I saw this was written by you, are you regularly testing the

Re: [PATCH v3 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-04-28 Thread Linus Walleij
functions are things that the > bridge chip driver itself would care about and it can just configure > the pins as needed. > > Signed-off-by: Douglas Anderson > Cc: Linus Walleij > Cc: Bartosz Golaszewski Pretty cool. I wonder if this chip could use the generic regmap GPIO hel

Re: [PATCH v3 5/6] dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd

2020-04-28 Thread Linus Walleij
uot; at the bridge chip level and > specify "hpd-gpios" at the panel level. That would mean HPD is > hooked up to some other GPIO in the system, just not the hardware > HPD pin on the bridge chip. > > [1] https://lore.kernel.org/r/20200417180819.ge5...@pendragon.ideasonbo

Re: [PATCH v3 3/6] drm/panel-simple: Support hpd-gpios for delaying prepare()

2020-04-28 Thread Linus Walleij
_DEFER during probe. NOTE: since the > gpio_get_optional() is used, if the "hpd-gpios" isn't there our > variable will just be NULL and we won't do anything in prepare(). > > Signed-off-by: Douglas Anderson > Reviewed-by: Stephen Boyd > --- > > Changes in v3: > -

Re: [PATCH v3 2/6] dt-bindings: display: Add hpd-gpios to panel-common bindings

2020-04-28 Thread Linus Walleij
https://lore.kernel.org/r/20200417180819.ge5...@pendragon.ideasonboard.com > > Signed-off-by: Douglas Anderson > Reviewed-by: Stephen Boyd Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop

Re: [PATCH] drm/tegra: Clean up GPIO includes

2020-04-22 Thread Linus Walleij
On Wed, Apr 22, 2020 at 12:15 AM Thierry Reding wrote: > On Wed, Apr 15, 2020 at 02:24:27PM +0200, Linus Walleij wrote: > > The Tegra DRM drivers includes the legacy GPIO headers > > and but what it really > > uses is since only gpio_desc > > structs are ever

Re: [PATCH 3/3] drm: pl111: Move VExpress setup into versatile init

2020-04-17 Thread Linus Walleij
rds init code. Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/3] drm: pl111: Simplify vexpress init

2020-04-17 Thread Linus Walleij
_find_device_by_node(np); So this finds the platform device for compatible "arm,vexpress-muxfpga", ha! > + map = devm_regmap_init_vexpress_config(>dev); > + platform_device_put(pdev); So then you can just do it like that. Clever! H

Re: [PATCH 1/3] drm: pl111: Fix module autoloading

2020-04-17 Thread Linus Walleij
On Thu, Apr 9, 2020 at 3:39 AM Rob Herring wrote: > Add a missing MODULE_DEVICE_TABLE entry to fix module autoloading. > > Cc: Eric Anholt > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Rob Herring Reviewed-by: Linus Walleij Yours

Re: [PATCH v2 05/36] dt-bindings: display: convert arm,versatile-tft-panel to DT Schema

2020-04-16 Thread Linus Walleij
On Wed, Apr 8, 2020 at 9:51 PM Sam Ravnborg wrote: > v2: > - Fix entry in MAINTAINERS > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Sam Ravnborg Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller

2020-04-16 Thread Linus Walleij
911@bogus/ > > Fix it. > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Rob Herring I think I was instructed to use dsi-controller@ at some point but I suppose it was a misunderstanding. Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-16 Thread Linus Walleij
e copies the simpler syntax. > > Signed-off-by: Rob Herring Reviewed-by: Linus Walleij Thanks for fixing this! Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/tegra: Clean up GPIO includes

2020-04-15 Thread Linus Walleij
The Tegra DRM drivers includes the legacy GPIO headers and but what it really uses is since only gpio_desc structs are ever referenced. Include the right header on the top level tegra/drm.h file and drop all the surplus includes. Signed-off-by: Linus Walleij --- drivers/gpu/drm/tegra

Re: [PATCH 28/59] drm/mcde: Use devm_drm_dev_alloc

2020-04-15 Thread Linus Walleij
On Wed, Apr 15, 2020 at 9:41 AM Daniel Vetter wrote: > Already using devm_drm_dev_init, so very simple replacment. > > v2: Move misplaced double-assignement to next patch (Sam) > > Acked-by: Sam Ravnborg > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Reviewed-by:

[PATCH] backlight: l4f00242t03: Convert to GPIO descriptors

2020-04-15 Thread Linus Walleij
s. This saves a lot of code in the driver and makes it possible to get rid of the platform data header altogether. Cc: Sascha Hauer Cc: Anson Huang Cc: Shawn Guo Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Alberto Panizzo Signed-off-by: Linus Walleij --- i.MX folks: pl

Re: [PATCH 33/44] drm/mcde: Don't use drm_device->dev_private

2020-04-11 Thread Linus Walleij
On Fri, Apr 3, 2020 at 3:59 PM Daniel Vetter wrote: > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Nice, thanks! Reviewed-by: Linus Walleij Yours

Re: [PATCH v2 12/17] drm/mcde: Use mode->clock instead of reverse calculating it from the vrefresh

2020-04-11 Thread Linus Walleij
On Fri, Apr 3, 2020 at 10:41 PM Ville Syrjala wrote: > From: Ville Syrjälä > > htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it. > > Cc: Linus Walleij > Cc: Sam Ravnborg > Signed-off-by: Ville Syrjälä Indeed :) Reviewed-by: Linus

Re: [PATCH 3/4] dt-bindings: Clean-up schema errors due to missing 'addtionalProperties: false'

2020-03-27 Thread Linus Walleij
l > those occurrences. > > Cc: Stephen Boyd > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: Masahiro Yamada > Cc: Jonathan Cameron > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: Peter Meerwald-Stadler > Cc: Neil Armstrong > Cc: Mauro Carvalho Chehab >

Re: [PATCH v2 3/5] drm: panel: add Xingbangda XBD599 panel

2020-03-20 Thread Linus Walleij
So following up on this: We should state in the commit message that this driver is for all displays using the Sitronix ST770x display controllers. The driver should be named panel-sitronix-st770x.c. On Thu, Mar 19, 2020 at 3:08 PM Linus Walleij wrote: > > +/* Manufacturer specific Co

Re: [PATCH v2 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel

2020-03-20 Thread Linus Walleij
On Fri, Mar 20, 2020 at 9:07 AM Icenowy Zheng wrote: > 于 2020年3月19日 GMT+08:00 下午10:14:27, Linus Walleij > 写到: > >On Mon, Mar 16, 2020 at 2:37 PM Icenowy Zheng wrote: > >As noticed in the review of the driver, this display is very close to > >himax,hx8363.

Re: [GIT PULL] Immutable branch between Backlight, Arm, Unicore32 and PWM due for the v5.7 merge window

2020-03-19 Thread Linus Walleij
On Wed, Mar 18, 2020 at 4:16 PM Lee Jones wrote: > git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git > ib-backlight-arm-unicore-pwm-v5.7 Thanks a lot for queueing this up and creating an immutable branch and all! Much appreciated. Yours, Linus W

Re: [PATCH v2 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel

2020-03-19 Thread Linus Walleij
bindings ilitek-ili9342.yaml and then: properties: compatible: items: - const: xingbangda,xbd599 - const: ilitek,ili9342 Possibly use oneOf and add support for the himax,hx8363 already while you're at it. Yours, Linus Walleij ___ dri

Re: [PATCH v2 3/5] drm: panel: add Xingbangda XBD599 panel

2020-03-19 Thread Linus Walleij
ink this vrefresh is going away soon. > + .clock = 69000, > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > + > + .width_mm= 68, > + .height_mm = 136, > + .type= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > +}; All of this as well as some of the initialization sequences should be per-variant data. (Switched by the compatible). Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 21/36] dt-bindings: display: convert samsung, s6d16d0 to DT Schema

2020-03-15 Thread Linus Walleij
On Sun, Mar 15, 2020 at 2:45 PM Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Sam Ravnborg Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing li

Re: [PATCH v1 06/36] dt-bindings: display: convert ilitek, ili9322 to DT Schema

2020-03-15 Thread Linus Walleij
is is a follow-up patch. > > The properties in question are: > - pixelclk-active > - de-active > - hsync-active > - vsync-active Sorry about that. They should be dropped, but certainly it is fine to do with a follow up patch. > > Signed-off-by: Sam Ravnborg > Cc: Li

Re: [PATCH v1 04/36] dt-bindings: display: convert arm,versatile-tft-panel to DT Schema

2020-03-15 Thread Linus Walleij
On Sun, Mar 15, 2020 at 2:44 PM Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Sam Ravnborg Thanks! :D Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing li

Re: [PATCH v1 02/36] dt-bindings: spi: support non-spi bindings as SPI slaves

2020-03-15 Thread Linus Walleij
n > duplicating the properties. To me it seems like you are creating the common SPI slave bindings? Maybe the commit message should be about that. > + reg: > +minimum: 0 > +maximum: 256 255? Or am I wrong? Apart from that it looks good t

Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings

2020-03-12 Thread Linus Walleij
node has a unit name, > but no reg property > > Removing the "@xxx" from the node name fixed first warning. > Adding a missing reg property fixed the second warning > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Linus Walleij > Cc: Rob Herring >

Re: [PATCH v2 04/33] drm/panel-ilitek-ili9322: Fix dotclocks

2020-03-09 Thread Linus Walleij
On Mon, Mar 9, 2020 at 2:38 PM Ville Syrjala wrote: > From: Ville Syrjälä > > The listed dotclocks are two orders of mangnitude out. > Fix them. > > v2: Just divide everything by 100 (Linus) > > Cc: Linus Walleij > Cc: Thierry Reding > Signed-off-by: Ville Syrjäl

Re: [PATCH v2 01/33] drm/panel-novatek-nt35510: Fix dotclock

2020-03-09 Thread Linus Walleij
On Mon, Mar 9, 2020 at 2:36 PM Ville Syrjala wrote: > From: Ville Syrjälä > > The dotclock is three orders of magnitude out. Fix it. > > v2: Just set it to 20MHz (Linus) > > Cc: Linus Walleij > Cc: Sam Ravnborg > Signed-off-by: Ville Syrjälä Reviewed-by: Linus Wal

Re: [PATCH 08/33] drm/panel-sony-acx424akp: Fix dotclocks

2020-03-07 Thread Linus Walleij
> correct? > > Cc: Linus Walleij > Cc: Sam Ravnborg > Signed-off-by: Ville Syrjälä These are better than what is currently in the driver at least, we don't know the real dotclocks. (No datasheet.) Reviewed-by: Linus Walleij Yours, Linus Walleij _

Re: [PATCH 04/33] drm/panel-ilitek-ili9322: Fix dotclocks

2020-03-07 Thread Linus Walleij
eresh is > correct? > > Cc: Linus Walleij > Cc: Thierry Reding > Signed-off-by: Ville Syrjälä This display is particularly peculiar since it uses the ITU-T packed streams and like DSI those have a different clocking than whatever is clocked out to the actual display by the pixel

Re: [PATCH 01/33] drm/panel-novatek-nt35510: Fix dotclock

2020-03-07 Thread Linus Walleij
and mode DSI panel with a DSI link clocked from the host. (hs_rate or lp_rate). The internal formula shows how the actual vrefresh can be calculated for the display in respone to setting of the internal registers, see page 34: https://dflund.se/~triad/NT35510-appnote.pdf Yours, L

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-04 Thread Linus Walleij
datasheet of the panel. If you don't have the datasheet, whatever you use in the vendor tree is fine, I suppose what is currently in .clock is fine. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-04 Thread Linus Walleij
d mode panel, and the panel driver should define them. These two clocks are/can be/should be completely orthogonal to the dotclock/pixelclock inside the panel, which is likely driven from its own crystal directly from the panel-internal framebuffer. Yours, Linus Walleij ___

Re: [PATCH 02/33] drm/panel-arm-versatile: Fix dotclock

2020-03-03 Thread Linus Walleij
h is > correct? I actually answered this in the mail thread where refresh was deleted: These dotclocks are correct. Delete the incorrect vrefresh instead. So please drop this patch. Thanks, Linus Walleij ___ dri-devel mailing list dri-devel@lists.

Re: [RFC v2 5/8] pinctrl: ingenic: add hdmi-ddc pin control group

2020-03-02 Thread Linus Walleij
compile-time dependencies. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC v2 5/8] pinctrl: ingenic: add hdmi-ddc pin control group

2020-02-28 Thread Linus Walleij
On Fri, Feb 28, 2020 at 7:19 PM H. Nikolaus Schaller wrote: > From: Paul Boddie > > Signed-off-by: Paul Boddie > Signed-off-by: H. Nikolaus Schaller This looks good, can I just apply this to the pinctrl tree? Yours, Linus Walleij _

Re:

2020-02-26 Thread Linus Walleij
On Wed, Feb 26, 2020 at 3:34 PM Ville Syrjälä wrote: > On Wed, Feb 26, 2020 at 01:08:06PM +0100, Linus Walleij wrote: > > On Wed, Feb 26, 2020 at 12:57 PM Ville Syrjälä > > wrote: > > > On Tue, Feb 25, 2020 at 10:52:25PM +0100, Linus Walleij wrote: > > > > &g

Re:

2020-02-26 Thread Linus Walleij
On Wed, Feb 26, 2020 at 12:57 PM Ville Syrjälä wrote: > On Tue, Feb 25, 2020 at 10:52:25PM +0100, Linus Walleij wrote: > > I have long suspected that a whole bunch of the "simple" displays > > are not simple but contains a display controller and memory. > >

Re: [PATCH 04/12] drm: Nuke mode->vrefresh

2020-02-25 Thread Linus Walleij
; panel-arm-versatile.c:184/versatile_panels[]: 390 vs. 1523 (.clock=62500 > .htotal=176 + 2 + 3 + 3 .vtotal=220 + 0 + 2 + 1) The only driver drivers/gpu/drm/pl111/pl111_display.c Uses mode->clock so just drop vrefresh. Yours, Linus Walleij ___ d

[PATCH 3/3 v2] drm/panel: Add driver for Novatek NT35510-based panels

2020-02-23 Thread Linus Walleij
register a subdriver for the internal backlight. Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebase onto v5.6-rc1 - Account for changes in the panel struct and get_modes() passing the connector as argument. - Use specific full filename for the panel driver. - Upd

[PATCH 2/3 v2] drm/panel: Add DT bindings for Novatek NT35510-based panels

2020-02-23 Thread Linus Walleij
compatibles to the binding using oneOf constructions. Cc: Stephan Gerhold Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rename file to novatek,nt35510,yaml to match the first compatible. - Require both the specific display manufacturer compati

[PATCH 1/3 v2] dt-bindings: Add vendor prefix for Hydis technologies

2020-02-23 Thread Linus Walleij
This vendor has produced a number of display panels, including HVA40WV1. Cc: devicet...@vger.kernel.org Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - New patch adding this vendor. --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed

Re: [PATCH 00/12] drm: Put drm_display_mode on diet

2020-02-21 Thread Linus Walleij
On Wed, Feb 19, 2020 at 9:35 PM Ville Syrjala wrote: > drm/exynos: Use mode->clock instead of reverse calculating it from the > vrefresh > drm: Nuke mode->vrefresh I'm sure this is fine. Acked-by: Linus Walleij We need one: either clock or refresh settings, so it

[PATCH v3] backlight: corgi: Convert to use GPIO descriptors

2020-02-20 Thread Linus Walleij
and drop the custom inversion semantics from the driver. All in-tree users are converted in this patch. Cc: Andrea Adami Acked-by: Robert Jarzmik Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Switch the SPI bus name to "spi1.1" rather than "spi0.1" for Corgi a

Re: [PATCH 34/52] drm/mcde: More devm_drm_dev_init

2020-02-19 Thread Linus Walleij
tright > losing their ->remove hook. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 13/52] drm/mcde: Use drmm_add_final_kfree

2020-02-19 Thread Linus Walleij
On Wed, Feb 19, 2020 at 11:21 AM Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-d

Re: [PATCH 33/52] drm/mcde: Drop explicit drm_mode_config_cleanup call

2020-02-19 Thread Linus Walleij
On Wed, Feb 19, 2020 at 11:22 AM Daniel Vetter wrote: > Allows us to drop the drm_driver.release callback. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing li

Re: [PATCH] drm/pl111: Support Integrator IM-PD1 module

2020-02-14 Thread Linus Walleij
rator/PP2) and it is trivial to support using the existing code, one can just define the panel in the device tree. It might need some new define in panel-simple.c as well. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.

[PATCH] drm/pl111: Support Integrator IM-PD1 module

2020-02-13 Thread Linus Walleij
the common Integrator system controller so make sure to do a special lookup for the IM-PD1 syscon and make it take precedence if found. Tested on the Integrator/AP with the IM-PD1 mounted. Signed-off-by: Linus Walleij --- drivers/gpu/drm/pl111/pl111_versatile.c | 73 + 1 file

[PATCH v2] backlight: corgi: Convert to use GPIO descriptors

2020-02-10 Thread Linus Walleij
and drop the custom inversion semantics from the driver. All in-tree users are converted in this patch. Cc: Andrea Adami Acked-by: Robert Jarzmik Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Collect Robert's ACK. --- arch/arm/mach-pxa/corgi.c | 12 - arch/arm/mach-pxa/spit

[PATCH v3] backlight: pwm_bl: Switch to full GPIO descriptor

2020-02-10 Thread Linus Walleij
Reviewed-by: Bartosz Golaszewski Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Collect Robert's ACK. ChangeLog v1->v2: - Located a missing removal of .enable_gpio in the Palm TC board file, pointed out by Daniel. - Grepped to ascertain there is not a single instance of the str

Re: [PATCH v8] drm/panel: Add driver for Sony ACX424AKP panel

2020-01-09 Thread Linus Walleij
On Thu, Jan 9, 2020 at 3:17 PM Sam Ravnborg wrote: > Applied to drm-misc-next. Thanks! Much appreciated. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v8] drm/panel: Add driver for Sony ACX424AKP panel

2020-01-08 Thread Linus Walleij
Signed-off-by: Linus Walleij --- ChangeLog v7->v8: - Fix some compilation problems due to the connector refactoring that went in recently so all builds fine now. - Add a MAINTAINERS entry for the driver. - Convert some msleep() to usleep_range(): it's fine to sleep some more so make

[PATCH v7] drm/panel: Add driver for Sony ACX424AKP panel

2020-01-03 Thread Linus Walleij
Signed-off-by: Linus Walleij --- ChangeLog v6->v7: - Add some Kconfig help text. - Sort includes alphabetically. - Move the struct drm_panel first in the state container struct since we are subclassing the panel class. - Put an explicit /* sentinel */ text in the NULL entry for compatible.

Re: [PATCH 2/2 v6] drm/panel: Add driver for Sony ACX424AKP panel

2020-01-03 Thread Linus Walleij
On Wed, Nov 20, 2019 at 12:53 PM Stephan Gerhold wrote: > On Thu, Nov 14, 2019 at 02:15:25PM +0100, Linus Walleij wrote: > > + /* Calculate the PWM duty cycle in n/256's */ > > + pwm_ratio = max(((duty_ns * 256) / period_ns) - 1, 1); > >

Re: [PATCH v2 1/5] pinctrl: Allow modules to use pinctrl_[un]register_mappings

2019-12-30 Thread Linus Walleij
.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-pinctrl-unreg-mappings And pulled that into the pinctrl "devel" branch for v5.6. Please pull this immutable branch into the Intel DRM tree and apply the rest of the stuff on top! Yours, Linus Walleij

[PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels

2019-12-25 Thread Linus Walleij
compatibles to the binding. Cc: Stephan Gerhold Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- .../display/panel/novatek-nt35510.yaml| 53 +++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek

[PATCH 2/2] drm/panel: Add driver for Novatek NT35510-based panels

2019-12-25 Thread Linus Walleij
register a subdriver for the internal backlight. Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- MAINTAINERS |7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile|1 + drivers/gpu/drm/panel/panel

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-17 Thread Linus Walleij
On Mon, Dec 16, 2019 at 5:27 PM Lee Jones wrote: > On Tue, 03 Dec 2019, Linus Walleij wrote: > > > The code in the Corgi backlight driver can be considerably > > simplified by moving to GPIO descriptors and lookup tables > > from the board files instead of passing GPIO n

[PATCH v6] drm/mcde: Some fixes to handling video mode

2019-12-17 Thread Linus Walleij
to blkeol_duration - 6 as in the vendor driver. Cc: Stephan Gerhold Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") Signed-off-by: Linus Walleij --- ChangeLog v5->v6: - DSI_VID_VCA_SETTING1_MAX_BURST_LIMIT should be blkeol_pck - 6 not blkeol_duration - 6. - Pare

Re: [PATCH v5] drm/mcde: Some fixes to handling video mode

2019-12-17 Thread Linus Walleij
s. > Also: It does not make a functional difference here but for clarity we > should shift the value by DSI_VID_VCA_SETTING1_MAX_BURST_LIMIT_SHIFT (= 0), > i.e. > > val |= blkeol_pck - 6 << DSI_VID_VCA_SETTING1_MAX_BURST_LIMIT_SHIFT; OK I fix! Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3] drm/mcde: Some fixes to handling video mode

2019-12-16 Thread Linus Walleij
the time. However, this does not have anything to do with this patch > - just an idea that could be discussed separately. Yeah I can take a stab at simply converting the whole thing to regmap-mmio, I thinkt it'd be pretty quick and we can see how it looks. Maybe easier to debug as well. Yours, L

[PATCH v5] drm/mcde: Some fixes to handling video mode

2019-12-16 Thread Linus Walleij
t;) Signed-off-by: Linus Walleij --- ChangeLog v4->v5: - Restore log order, last verstion of the changelog inadvertedly merged v3 and v4 into v3 since I thought I didn't send out v3... - Parens in blkeol_pck = bpl - (mode->htotal * cpp) - 6 for explicit priority. - Use mask-and-set for

Re: [PATCH 0/5] drm/i915/dsi: Control panel and backlight enable GPIOs from VBT

2019-12-16 Thread Linus Walleij
nctrl/cirrus/pinctrl-madera-core.c: ret = pinctrl_register_mappings(pdata->gpio_configs, Delete __initdata from the u300 table, the other one seems safe. Fold this into your patch. Go with the original idea. Yours, Linus Walleij ___ dri-deve

Re: [PATCH 4/5] drm/i915/dsi: Move Crystal Cove PMIC panel GPIO lookup from mfd to the i915 driver

2019-12-16 Thread Linus Walleij
le. > > Since the lookup-table is attached to the i915 PCI device it really > should be part of the i915 driver, this will also allow us to extend > it with GPIOs from other sources when necessary. > > Signed-off-by: Hans de Goede Looks OK to me Acked-by: Linus Walleij But Lee

Re: [PATCH 5/5] drm/i915/dsi: Control panel and backlight enable GPIOs on BYT

2019-12-16 Thread Linus Walleij
s devices when booted > with a HDMI monitor connected. This has been tested to fix this on the > following devices: > > Peaq C1010 > Point of View MOBII TAB-P800W > Point of View MOBII TAB-P1005W > Terra Pad 1061 > Yours Y8W81 > > Signe

Re: [PATCH 3/5] drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off

2019-12-16 Thread Linus Walleij
ue accordingly. > > This fixes the panel not lighting up on a Thundersoft TST168 tablet when > booted with an external monitor connected over HDMI. > > Signed-off-by: Hans de Goede Reviewed-by: Linus Walleij Yours, Linus Walleij ___

Re: [PATCH 2/5] drm/i915/dsi: Move poking of panel-enable GPIO to intel_dsi_vbt.c

2019-12-16 Thread Linus Walleij
where instead of the PMIC the SoC is used > for backlight control. > > Signed-off-by: Hans de Goede The kernel looks prettier after than before and it seems correct so: Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing

Re: [PATCH 0/5] drm/i915/dsi: Control panel and backlight enable GPIOs from VBT

2019-12-16 Thread Linus Walleij
e pull this in and put the other patches on top of that. I had a bit of mess in my subsystems last kernel cycle so I want to avoid that by strictly including all larger commits in my trees. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists

Re: [PATCH] backlight: pwm_bl: Switch to full GPIO descriptor

2019-12-13 Thread Linus Walleij
scream if the compilation is broken, and the kernel CI should > certainly protect us. I actually push my patches to the zeroday but it has reliability issues... Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-13 Thread Linus Walleij
On Fri, Dec 13, 2019 at 6:24 PM Robert Jarzmik wrote: > Linus Walleij writes: > > On Sun, Dec 8, 2019 at 9:06 PM Robert Jarzmik > > wrote: > >> Linus Walleij writes: > > So it will theoretically "spi0.1" > > > > Beware about bugs in t

Re: [PATCH v2 02/25] drm/panel: add backlight support

2019-12-13 Thread Linus Walleij
afe to call > the backlight_(enable|disable) several times. > > v3: v3 looks good to me +/- Laurent's comments: Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2] backlight: pwm_bl: Switch to full GPIO descriptor

2019-12-13 Thread Linus Walleij
Reviewed-by: Bartosz Golaszewski Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Located a missing removal of .enable_gpio in the Palm TC board file, pointed out by Daniel. - Grepped to ascertain there is not a single instance of the string "enable_gpio" in the affected board fi

Re: [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-10 Thread Linus Walleij
. So this is easy, but I wonder if we cannot > get rid of the dupping all together ? Maybe ... I don't know. What do you think? I suppose you could make u300 crash if you do that. Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-10 Thread Linus Walleij
On Sun, Dec 8, 2019 at 9:06 PM Robert Jarzmik wrote: > Linus Walleij writes: > > @@ -525,13 +525,33 @@ static void spitz_bl_kick_battery(void) > > } > > } > > > > +static struct gpiod_lookup_table spitz_lcdcon_gpio_table = { > > + .dev_id =

[PATCH v3] drm/mcde: Some fixes to handling video mode

2019-12-10 Thread Linus Walleij
to the documentation where the code is hard to understand. Cc: Stephan Gerhold Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Calculate toward actual HS rate of the clock rather than the idealized rate provided

Re: [PATCH v1 07/26] drm/panel: remove get_timings

2019-12-10 Thread Linus Walleij
On Wed, Dec 4, 2019 at 9:16 AM Maxime Ripard wrote: > On Tue, Dec 03, 2019 at 04:20:24PM +0100, Linus Walleij wrote: > > On the DSI displays in video mode there is also this EOL area > > which seems to be where the logic is normally just idling for a > > while, that ca

Re: [PATCH] drm/drm_panel: fix EXPORT of drm_panel_of_backlight

2019-12-10 Thread Linus Walleij
Ravnborg Looks like the right fix to me: Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/gma500: Pass GPIO for Intel MID using descriptors

2019-12-06 Thread Linus Walleij
of the GMA500 driver can work on top of this, I can't solve much more since I don't have access to the hardware, I can only attempt to tidy up my GPIO corner. Cc: Patrik Jakobsson Cc: Daniel Stone Cc: Daniel Vetter Cc: Andy Shevchenko Signed-off-by: Linus Walleij --- If someone can test

[PATCH] backlight: pwm_bl: Switch to full GPIO descriptor

2019-12-05 Thread Linus Walleij
c: Bartosz Golaszewski Signed-off-by: Linus Walleij --- arch/arm/mach-pxa/cm-x300.c | 1 - arch/arm/mach-pxa/colibri-pxa270-income.c | 1 - arch/arm/mach-pxa/ezx.c | 1 - arch/arm/mach-pxa/hx4700.c| 1 - arch/arm/mach-pxa/lpd270.c|

[PATCH] drm/panel: rpi: Drop unused GPIO includes

2019-12-03 Thread Linus Walleij
The Rpi panel driver doesn't use any symbols from these GPIO includes so just drop them. Cc: Eric Anholt Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-raspberrypi

Re: [PATCH v1 07/26] drm/panel: remove get_timings

2019-12-03 Thread Linus Walleij
e the logic is normally just idling for a while, that can be adjusted on some hardware as well, but I don't quite understand it admittedly. Sometimes I wonder if anyone really understands DSI... :/ Yours, Linus Walleij ___ dri-devel mailing list dri-devel@li

<    2   3   4   5   6   7   8   9   10   11   >