On Mon, 2023-02-20 at 11:16 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> Am Montag, 20. Februar 2023, 09:55:19 CET schrieb Alexander Stein:
> > Hi Liu,
> >
> > Am Freitag, 17. Februar 2023, 09:59:14 CET schrieb Liu Ying:
> > > On Fri, 2023-0
On Fri, 2023-02-17 at 09:18 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying:
> > Hi,
> >
> > This patch set aims to add i.MX93 LCDIF display controller support
> > in the existing LCDIF D
With all previous preparations done to make it possible for the
single LCDIF embedded in i.MX93 SoC to drive multiple displays
simultaneously, add i.MX93 LCDIF compatible string as the last
step of adding i.MX93 LCDIF support.
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v3->
pport.
Signed-off-by: Liu Ying
---
v3->v4:
* Improve warning message when ignoring invalid LCDIF OF endpoint ids.
(Alexander)
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Drop '!remote ||' from lcdif_attach_bridge(). (Lothar)
* Drop unneed
The single LCDIF embedded in i.MX93 SoC may drive multiple displays
simultaneously. Check bus format and flags across first bridges in
->atomic_check() to ensure they are consistent. This is a preparation
for adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
v3->v4:
* No change.
ucture is introduced to cache bus format
and bus flags states in ->atomic_check() so that they can be read
in ->atomic_enable().
Signed-off-by: Liu Ying
---
v3->v4:
* Use 'new_{c,p}state' instead of 'new_{crtc,plane}_state'. (Alexander)
* Simplify lcdif_crtc_reset() by c
A valid bridge is already found in lcdif_attach_bridge() and set
to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
the unnecessary NULL pointer check in KMS stage.
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v3->v4:
* Add Alexander's R-b tag.
v2-&g
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Acked-by: Krzysztof Kozlowski
Reviewed-by: Marek Vasut
Reviewed-by: Alexander Stein
Signed-off-by: Liu Ying
---
v3->v4:
* Add Alexander's R-b tag.
v2->v3:
* No change.
v1
it should always be the first member. (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
* Drop a comment about bridge input bus format from lcdif_crtc_atomic_check().
Liu Ying (6):
dt-bindings: lcdif: Add i.MX93 LCDIF support
drm: lcdif: Drop unnecessary NUL
On Wed, 2023-02-15 at 08:54 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> thanks for the update.
Thanks for the review.
>
> Am Montag, 13. Februar 2023, 09:56:11 CET schrieb Liu Ying:
> > The single LCDIF embedded in i.MX93 SoC may drive multiple displa
On Wed, 2023-02-15 at 08:55 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> thanks for the update.
Thanks for the review.
>
> Am Montag, 13. Februar 2023, 09:56:10 CET schrieb Liu Ying:
> > The single LCDIF embedded in i.MX93 SoC may drive multiple displa
On Wed, 2023-02-15 at 08:26 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> thanks for the update.
Thanks for the review.
>
> Am Montag, 13. Februar 2023, 09:56:07 CET schrieb Liu Ying:
> > There is one LCDIF embedded in i.MX93 SoC to connect with
> >
On Tue, 2023-02-14 at 15:12 +0100, Alexander Stein wrote:
> Hi Liu,
Hi Alexander,
>
> thanks for the update.
Thanks for your review.
>
> Am Montag, 13. Februar 2023, 09:56:09 CET schrieb Liu Ying:
> > Instead of determining LCDIF output bus format and bus flags in
>
With all previous preparations done to make it possible for the
single LCDIF embedded in i.MX93 SoC to drive multiple displays
simultaneously, add i.MX93 LCDIF compatible string as the last
step of adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
v2->v3:
* Fix a trivial typo in com
pport.
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Drop '!remote ||' from lcdif_attach_bridge(). (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
drivers
The single LCDIF embedded in i.MX93 SoC may drive multiple displays
simultaneously. Check bus format and flags across first bridges in
->atomic_check() to ensure they are consistent. This is a preparation
for adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
ucture is introduced to cache bus format
and bus flags states in ->atomic_check() so that they can be read
in ->atomic_enable().
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Add comment on the 'base' member of lcdif
A valid bridge is already found in lcdif_attach_bridge() and set
to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
the unnecessary NULL pointer check in KMS stage.
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexande
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Acked-by: Krzysztof Kozlowski
Reviewed-by: Marek Vasut
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Add Krzysztof's A-b and Marek's R-b tags on patch 1/6.
if_attach_bridge(). (Lothar)
* Add comment on the 'base' member of lcdif_crtc_state structure to
note it should always be the first member. (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
* Drop a comment about bridge input bus format from lcdif_crtc_at
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel support.
The panel has a LVDS display interface.
The panel's product specification can be found at:
http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
Signed-off-by: Liu Ying
---
drivers/gpu
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel
compatible string. The panel has a LVDS display interface.
The panel's product specification can be found at:
http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf
Signed-off-by
Hi,
This patch series aims to add BOE EV121WXM-N10-1850 panel support
in the DRM simple panel driver.
Patch 1/2 adds dt-bindings support for the panel.
Patch 2/2 adds the panel support in the DRM simple panel driver.
Liu Ying (2):
dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel
On Mon, 2023-01-30 at 15:39 -0600, Rob Herring wrote:
> On Mon, Jan 30, 2023 at 04:39:05PM +0800, Liu Ying wrote:
> > On Sun, 2023-01-29 at 12:46 +0100, Krzysztof Kozlowski wrote:
> > > On 28/01/2023 04:47, Liu Ying wrote:
> > > > NXP i.MX93 mediamix blk-ctrl con
On Sun, 2023-01-29 at 12:46 +0100, Krzysztof Kozlowski wrote:
> On 28/01/2023 04:47, Liu Ying wrote:
> > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register
> > which
> > configures parallel display format by using the
> > "PARALLEL_DISP_FORMAT"
&g
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Add a DRM bridge driver to support the display format configuration.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/imx/Kconfig
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Add device tree bindings for the display format configuration.
Signed-off-by: Liu Ying
---
.../display/bridge/nxp,imx93-pdfc.yaml
parallel output connects with this piece of small logic to configure
parallel display format.
Patch 1/2 adds NXP i.MX93 parallel display format configuration dt-bindings.
Patch 2/2 adds NXP i.MX93 parallel display format configuration DRM bridge
driver support.
Liu Ying (2):
dt-bindings: displ
On Wed, 2023-01-25 at 14:56 +0100, Marek Vasut wrote:
> On 1/25/23 07:40, Liu Ying wrote:
> > A valid bridge is already found in lcdif_attach_bridge() and set
> > to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
> > the unnecessary NULL pointer che
pport.
Signed-off-by: Liu Ying
---
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Drop '!remote ||' from lcdif_attach_bridge(). (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
drivers/gpu/drm/mxsfb/lcdif_drv.c | 68
With all previous preparations done to make it possible for the
single LCDIF embedded in i.MX93 SoC to drive multipledisplays
simultaneously, add i.MX93 LCDIF compatible string as the last
step of adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/mxsfb/lcdif_drv.c | 1
The single LCDIF embedded in i.MX93 SoC may drive multiple displays
simultaneously. Check bus format and flags across first bridges in
->atomic_check() to ensure they are consistent. This is a preparation
for adding i.MX93 LCDIF support.
Signed-off-by: Liu Ying
---
v1->v2:
* Split from p
ucture is introduced to cache bus format
and bus flags states in ->atomic_check() so that they can be read
in ->atomic_enable().
Signed-off-by: Liu Ying
---
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
* Add comment on the 'base' member of lcdif_crtc_state structure to
A valid bridge is already found in lcdif_attach_bridge() and set
to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
the unnecessary NULL pointer check in KMS stage.
Signed-off-by: Liu Ying
---
v1->v2:
* Split from patch 2/2 in v1. (Marek, Alexander)
drivers/gpu/
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Acked-by: Krzysztof Kozlowski
Reviewed-by: Marek Vasut
Signed-off-by: Liu Ying
---
v1->v2:
* Add Krzysztof's A-b and Marek's R-b tags on patch 1/6.
Documentation/device
ber of lcdif_crtc_state structure to
note it should always be the first member. (Lothar)
* Drop unneeded 'bridges' member from lcdif_drm_private structure.
* Drop a comment about bridge input bus format from lcdif_crtc_atomic_check().
Liu Ying (6):
dt-bindings: lcdif: Add i.MX93 LCD
On Tue, 2023-01-24 at 12:15 +0100, Alexander Stein wrote:
> Hi,
Hi,
>
> Am Dienstag, 24. Januar 2023, 08:59:39 CET schrieb Liu Ying:
> > On Mon, 2023-01-23 at 16:57 +0100, Marek Vasut wrote:
> > > On 1/23/23 08:23, Liu Ying wrote:
> > > > The LCDIF embedded i
On Mon, 2023-01-23 at 16:57 +0100, Marek Vasut wrote:
> On 1/23/23 08:23, Liu Ying wrote:
> > The LCDIF embedded in i.MX93 SoC is essentially the same to those
> > in i.MX8mp SoC. However, i.MX93 LCDIF may connect with MIPI DSI
> > controller through LCDIF cross line
On Mon, 2023-01-23 at 09:13 +0100, Lothar Waßmann wrote:
> Hi,
Hi,
>
> On Mon, 23 Jan 2023 15:23:58 +0800 Liu Ying wrote:
> > The LCDIF embedded in i.MX93 SoC is essentially the same to those
> > in i.MX8mp SoC. However, i.MX93 LCDIF may connect with MIPI DSI
> > con
display.
Patch 1/2 adds device tree binding support for i.MX93 LCDIF in the
existing fsl,lcdif.yaml.
Patch 2/2 adds i.MX93 LCDIF support in the existing LCDIF DRM driver.
Liu Ying (2):
dt-bindings: lcdif: Add i.MX93 LCDIF support
drm: lcdif: Add i.MX93 LCDIF support
.../bindings/display
). i.MX93
LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device
tree binding for i.MX93 LCDIF.
Signed-off-by: Liu Ying
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree
flags
states so that the next downstream bridges may use consistent bus
format and bus flags.
Signed-off-by: Liu Ying
---
drivers/gpu/drm/mxsfb/lcdif_drv.c | 73 +--
drivers/gpu/drm/mxsfb/lcdif_drv.h | 6 +-
drivers/gpu/drm/mxsfb/lcdif_kms.c | 206 --
3
ridge driver by adding i.MX93 LDB compatible string and
device data(to reflect different register offsets and LVDS_CTRL register
bit1 definition).
Reviewed-by: Marek Vasut
Signed-off-by: Liu Ying
---
v2->v3:
* Provide comment on LVDS_CTRL_LVDS_EN bit when defining it's macro. (Marek)
* Add Ma
while
i.MX8mp LDB supports at most two. Add i.MX93 LDB device tree binding
in the existing i.MX8mp LDB device tree binding documentation.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Liu Ying
---
v2->v3:
* No change.
v1->v2:
* Drop redundant "device tree binding" from patch
on patch 2/2.
v1->v2:
* Drop redundant "device tree binding" from patch 1/2's subject. (Krzysztof)
* Add Krzysztof's A-b tag on patch 1/2.
Liu Ying (2):
dt-bindings: display: bridge: ldb: Add i.MX93 LDB
drm/bridge: fsl-ldb: Add i.MX93 LDB support
.../bindings/d
ridge driver by adding i.MX93 LDB compatible string and
device data(to reflect different register offsets and LVDS_CTRL register
bit1 definition).
Signed-off-by: Liu Ying
---
v1->v2:
* No change.
drivers/gpu/drm/bridge/fsl-ldb.c | 53 ++--
1 file changed, 44 insertio
while
i.MX8mp LDB supports at most two. Add i.MX93 LDB device tree binding
in the existing i.MX8mp LDB device tree binding documentation.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Liu Ying
---
v1->v2:
* Drop redundant "device tree binding" from patch subject. (Krzysztof)
* Add
.
Patch 1/2 adds device tree binding for i.MX93 LDB in the existing
fsl,ldb.yaml.
Patch 2/2 adds i.MX93 LDB support in the existing i.MX8mp LDB DRM bridge
driver.
v1->v2:
* Drop redundant "device tree binding" from patch 1/2's subject. (Krzysztof)
* Add Krzysztof's A-b tag
ridge driver by adding i.MX93 LDB compatible string and
device data(to reflect different register offsets and LVDS_CTRL register
bit1 definition).
Signed-off-by: Liu Ying
---
drivers/gpu/drm/bridge/fsl-ldb.c | 53 ++--
1 file changed, 44 insertions(+), 9 deletions(-)
diff
while
i.MX8mp LDB supports at most two. Add i.MX93 LDB device tree binding
in the existing i.MX8mp LDB device tree binding documentation.
Signed-off-by: Liu Ying
---
.../bindings/display/bridge/fsl,ldb.yaml | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --
.
Patch 1/2 adds device tree binding for i.MX93 LDB in the existing
fsl,ldb.yaml.
Patch 2/2 adds i.MX93 LDB support in the existing i.MX8mp LDB DRM bridge
driver.
Liu Ying (2):
dt-bindings: display: bridge: ldb: Add i.MX93 LDB device tree binding
drm/bridge: fsl-ldb: Add i.MX93 LDB support
Hi Marcel,
On Wed, 2023-01-04 at 10:01 +, Marcel Ziswiler wrote:
> Hi Liu
>
> Thank you very much!
>
> On Wed, 2022-10-19 at 10:02 +0800, Liu Ying wrote:
> > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM
> > support.
> >
> > DPU i
Add myself as the maintainer of the i.MX8qxp DPU DRM driver.
Acked-by: Laurentiu Palcu
Signed-off-by: Liu Ying
---
v11->v14:
* No change.
v10->v11:
* Rebase upon v6.0-rc1.
v9->v10:
* Add Laurentiu's A-b tag.
v1->v9:
* No change.
MAINTAINERS | 9 +
1 file chan
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning.
The precedent has already been set by other macros in the same file.
Acked-by: Daniel Vetter
Signed-off-by: Liu Ying
---
v6->v14:
* No change.
v5->v6:
* Fix commit message typo -
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v4->v14:
* No change.
v3->v4:
* Improve compatible property by using enum instead of oneOf+const. (Rob)
* Add Rob's R-b tag.
v2->v3:
* No change.
v1-
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v14:
* No change.
v9->v10:
* Add Rob's R-b tag.
v8->v9:
* Reference 'interrupts-extended' schema instead of 'interrupts' to
This patch adds bindings for i.MX8qxp/qm Display Processing Unit.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v7->v14:
* No change.
v6->v7:
* Add Rob's R-b tag back.
v5->v6:
* Use graph schema. So, drop Rob's R-b tag as review is needed.
v4->v5:
* No chan
27;ll use new dt binding way to
support i.MX8qm/qxp clocks. This depends on a not-yet-landed patch set
to do basic conversions for the platforms.
* Fix dt binding yamllint warnings.
* Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's
dt binding documentation.
* Us
(!remote)
> + return -EINVAL;
> +
> + pvi->next_bridge = of_drm_find_bridge(remote);
> + of_node_put(remote);
> +
> + if (!pvi->next_bridge)
> + return dev_err_probe(&pdev->dev, -EPROBE_DEFER,
> +
list it as an 'interrupts' property?
> +
> +required:
> + - compatible
> + - reg
> + - power-domains
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +#include
This is not needed if the example node doe
+ plat_data->priv_data = hdmi;
Need to set plat_data->phy_force_vendor to be true? Or, you rely on
reading the HDMI_CONFIG2_ID register to determine the phy type?
> +
> + hdmi->dw_hdmi = dw_hdmi_probe(pdev, plat_data);
> + if (IS_ERR(hdmi->dw_hdmi))
> +
+items:
> + - const: iahb
> + - const: isfr
> + - const: fdcc
> + - const: cec
> + - const: pix
> +
> + power-domains:
> +maxItems: 1
Missing 'ports' property?
> +
> +required:
> + - compatible
> + - reg
> + - clocks
&
rm: lcdif: Add support for i.MX8MP LCDIF
> variant")
> Signed-off-by: Marek Vasut
> ---
> Cc: Kieran Bingham
> Cc: Laurent Pinchart
> Cc: Liu Ying
> Cc: Lucas Stach
> Cc: Marco Felsch
> Cc: Martyn Welch
> Cc: Peng Fan
> Cc: Sam Ravnborg
> ---
> V2: -
On Tue, 2022-11-01 at 15:04 +0100, Marco Felsch wrote:
> Hi Marek, Liu,
Hi,
>
> On 22-10-28, Liu Ying wrote:
> > On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote:
> > > On 10/27/22 19:47, Marco Felsch wrote:
> > > > On 22-10-27, Liu Ying wrote:
> &g
On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote:
> On 10/27/22 19:47, Marco Felsch wrote:
> > On 22-10-27, Liu Ying wrote:
> > > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote:
> > > > On 10/27/22 07:45, Liu Y
On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote:
> On 10/27/22 07:45, Liu Ying wrote:
>
> Hi,
>
> [...]
>
> > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > > index a5302006c02cd..aee7babb5
ort for i.MX8MP LCDIF variant")
> Signed-off-by: Marek Vasut
> ---
> Cc: Kieran Bingham
> Cc: Laurent Pinchart
> Cc: Liu Ying
> Cc: Lucas Stach
> Cc: Marco Felsch
> Cc: Martyn Welch
> Cc: Peng Fan
> Cc: Sam Ravnborg
> ---
> drivers/gpu/drm/mxsfb/l
Hi Philipp,
On Sun, 2022-10-09 at 10:35 +0800, Liu Ying wrote:
> A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig
> file
> by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER
> option"),
> so remove it.
>
> Fixes: 09717af7d13
rm_device' has no member named 'irq_enabled'
>
> 67 | drm->irq_enabled = true;
> |^~
I've sent v13 to fix the potential build break by removing this line
since drm->irq_enabled should only be used by legacy drm drivers with
userspace modesetting but not imx-dpu drm driver.
Thanks for reporting the issue.
Liu Ying
[...]
Add myself as the maintainer of the i.MX8qxp DPU DRM driver.
Acked-by: Laurentiu Palcu
Signed-off-by: Liu Ying
---
v11->v13:
* No change.
v10->v11:
* Rebase upon v6.0-rc1.
v9->v10:
* Add Laurentiu's A-b tag.
v1->v9:
* No change.
MAINTAINERS | 9 +
1 file chan
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning.
The precedent has already been set by other macros in the same file.
Acked-by: Daniel Vetter
Signed-off-by: Liu Ying
---
v6->v13:
* No change.
v5->v6:
* Fix commit message typo -
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v13:
* No change.
v9->v10:
* Add Rob's R-b tag.
v8->v9:
* Reference 'interrupts-extended' schema instead of 'interrupts' to
This patch adds bindings for i.MX8qxp/qm Display Processing Unit.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v7->v13:
* No change.
v6->v7:
* Add Rob's R-b tag back.
v5->v6:
* Use graph schema. So, drop Rob's R-b tag as review is needed.
v4->v5:
* No chan
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v4->v13:
* No change.
v3->v4:
* Improve compatible property by using enum instead of oneOf+const. (Rob)
* Add Rob's R-b tag.
v2->v3:
* No change.
v1-
ds on a not-yet-landed patch set
to do basic conversions for the platforms.
* Fix dt binding yamllint warnings.
* Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's
dt binding documentation.
* Use new dt binding way to add clocks in the dt binding examples.
* Address sev
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning.
The precedent has already been set by other macros in the same file.
Acked-by: Daniel Vetter
Signed-off-by: Liu Ying
---
v6->v12:
* No change.
v5->v6:
* Fix commit message typo -
Add myself as the maintainer of the i.MX8qxp DPU DRM driver.
Acked-by: Laurentiu Palcu
Signed-off-by: Liu Ying
---
v11->v12:
* No change.
v10->v11:
* Rebase upon v6.0-rc1.
v9->v10:
* Add Laurentiu's A-b tag.
v1->v9:
* No change.
MAINTAINERS | 9 +
1 file chan
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v12:
* No change.
v9->v10:
* Add Rob's R-b tag.
v8->v9:
* Reference 'interrupts-extended' schema instead of 'interrupts' to
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v4->v12:
* No change.
v3->v4:
* Improve compatible property by using enum instead of oneOf+const. (Rob)
* Add Rob's R-b tag.
v2->v3:
* No change.
v1-
This patch adds bindings for i.MX8qxp/qm Display Processing Unit.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v7->v12:
* No change.
v6->v7:
* Add Rob's R-b tag back.
v5->v6:
* Use graph schema. So, drop Rob's R-b tag as review is needed.
v4->v5:
* No chan
xp clocks. This depends on a not-yet-landed patch set
to do basic conversions for the platforms.
* Fix dt binding yamllint warnings.
* Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's
dt binding documentation.
* Use new dt binding way to add clocks in the dt bin
A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig file
by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"),
so remove it.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Liu Ying
---
driver
display image for YUV framebuffers due to
the pre-existing bug that Laurent claims, I choose to trust Laurent,
so:
Reviewed-by: Liu Ying
Thanks Laurent and Kieran for the work.
lity better and tell which coefficient is which.
Also for RGB to YCbCr conversion if you want to do that with this
series. Sorry for not pointing this out in v2 review cycle.
> + */
> +static const u32 lcdif_yuv2rgb_coeffs[3][2][6] = {
[...]
> + /* YUYV Formats */
'YUV Formats&#x
with YUV
fb. Looks like something with wrong stride. XR24 fb is ok, but RG16 fb
has similar issue. Anything I missed?
The command I'm using to test YUV fb:
modetest -M imx-lcdif -P 31@35:1920x1200@YUYV
Liu Ying
quot;)
> Signed-off-by: Laurent Pinchart
> ---
> Changes since v1:
>
> - Use coefficients from imx-pxp.c
> ---
> drivers/gpu/drm/mxsfb/lcdif_kms.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
With the typo in commit message fixed:
Reviewed-by: Liu Ying
field values
> ---
> drivers/gpu/drm/mxsfb/lcdif_regs.h | 28 ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
One option is to use FIELD_RPEP() macro for register field values.
But I think this patch is ok without using it, so:
Reviewed-by: Liu Ying
nged, 2 insertions(+), 2 deletions(-)
Reviewed-by: Liu Ying
didn't check other coefficients closely though.
[...]
> @@ -456,6 +574,12 @@ static const u32 lcdif_primary_plane_formats[] = {
> DRM_FORMAT_XRGB1555,
> DRM_FORMAT_XRGB,
> DRM_FORMAT_XRGB,
> +
> + /* packed YCbCr */
Nitpick: Add a similar comment for above RGB pixel formats?
Regards,
Liu Ying
> + DRM_FORMAT_YUYV,
> + DRM_FORMAT_YVYU,
> + DRM_FORMAT_UYVY,
> + DRM_FORMAT_VYUY,
> };
On Mon, 2022-09-26 at 11:47 +0200, Ulf Hansson wrote:
> On Fri, 23 Sept 2022 at 17:23, Liu Ying wrote:
> > On Fri, 2022-09-23 at 15:48 +0200, Ulf Hansson wrote:
> > > On Fri, 23 Sept 2022 at 14:47, Liu Ying wrote:
> > > > After a device transitions to s
On Fri, 2022-09-23 at 15:48 +0200, Ulf Hansson wrote:
> On Fri, 23 Sept 2022 at 14:47, Liu Ying wrote:
> >
> > After a device transitions to sleep state through it's system
> > suspend
> > callback pm_runtime_force_suspend(), the device's driver may still
. Then, device
usage count will be 1 after pm_runtime_put() is called at dpm_complete
stage.
Also, update the documentation to change the description of
pm_runtime_resume() to reflect the new behavior of rpm_resume().
Cc: Rafael J. Wysocki
Cc: Len Brown
Cc: Pavel Machek
Cc: Greg Kroah-Hartma
tion to change the description of
pm_runtime_resume() to reflect the new behavior of rpm_resume().
Cc: Rafael J. Wysocki
Cc: Len Brown
Cc: Pavel Machek
Cc: Greg Kroah-Hartman
Cc: Ulf Hansson
Cc: Douglas Anderson
Signed-off-by: Liu Ying
---
Documentation/power/runtime_pm.rst | 14 +++---
drivers/base
Add myself as the maintainer of the i.MX8qxp DPU DRM driver.
Acked-by: Laurentiu Palcu
Signed-off-by: Liu Ying
---
v10->v11:
* Rebase upon v6.0-rc1.
v9->v10:
* Add Laurentiu's A-b tag.
v8->v9:
* No change.
v7->v8:
* No change.
v6->v7:
* No change.
v5->v6:
* No chang
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning.
The precedent has already been set by other macros in the same file.
Acked-by: Daniel Vetter
Signed-off-by: Liu Ying
---
v10->v11:
* No change.
v9->v10:
* No change.
v8->v9:
* N
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v11:
* No change.
v9->v10:
* Add Rob's R-b tag.
v8->v9:
* Reference 'interrupts-extended' schema instead of 'interrupts' to
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v11:
* No change.
v9->v10:
* No change.
v8->v9:
* No change.
v7->v8:
* No change.
v6->v7:
* No change.
v5->v6:
* No change.
v4->v5:
This patch adds bindings for i.MX8qxp/qm Display Processing Unit.
Reviewed-by: Rob Herring
Signed-off-by: Liu Ying
---
v10->v11:
* No change.
v9->v10:
* No change.
v8->v9:
* No change.
v7->v8:
* No change.
v6->v7:
* Add Rob's R-b tag back.
v5->v6:
* Use graph schema.
ire bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's
dt binding documentation.
* Use new dt binding way to add clocks in the dt binding examples.
* Address several comments from Laurentiu on the DPU DRM patch.
Liu Ying (6):
dt-bindings: display: imx: Add i.MX
+*/
> > + ctrl = CTRLDESCL0_3_P_SIZE(2) | CTRLDESCL0_3_T_SIZE(2) |
> > + CTRLDESCL0_3_PITCH(lcdif->crtc.primary->state->fb-
> > >pitches[0]);
> > + writel(ctrl, lcdif->base + LCDC_V8_CTRLDESCL0_3);
Nit: I would write the register directly, i
201 - 300 of 1017 matches
Mail list logo
