On Mon, Jul 22, 2024 at 9:55 AM Imre Deak wrote:
>
> In the
> if (old_ddps != port->ddps || !created)
> if (port->ddps && !port->input)
> ret = drm_dp_send_enum_path_resources();
>
> sequence the first if's condition is true if the port exists alread
Reviewed-by: Manasi Navare
Manasi
On Tue, Mar 26, 2024 at 5:54 AM Nautiyal, Ankit K
wrote:
>
>
> On 3/21/2024 1:41 AM, Imre Deak wrote:
> > Factor out a function to check for UHBR channel coding support used by a
> > follow-up patch in the patchset.
> >
> > Cc
change makes sense, just want to confirm if this applies to
all platforms or any particular?
With that clarification:
Reviewed-by: Manasi Navare
Regards
Manasi
On Tue, Mar 26, 2024 at 3:01 AM Nautiyal, Ankit K
wrote:
>
>
> On 3/21/2024 1:41 AM, Imre Deak wrote:
> > Fix the calcula
Thanks Lukasz for the patch, looks like it is reviewed by.
@dan...@ffwll.ch or @airl...@gmail.com
, could any of you ack this as well, so I can go ahead
and push this to drm-misc-fixes branch?
Regards
Manasi
On Thu, Oct 5, 2023 at 6:35 AM Lukasz Majczak wrote:
> wt., 26 wrz 2023 o 16:01 Rado
_event
instead of the earlier generic drm_kms_helper_connector_hotplug_event.
This will need some changes in other userspaces that parse this else it will
cause failures for other userspace once this lands.
With all the above changes,
Acked-by: Manasi Navare
Regards
Manasi
>
> Signe
y are marked as connected.
>
> Cc: Jani Nikula
> Cc: Manasi Navare
> Cc: Sean Paul
> Signed-off-by: Gil Dekel
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 18 --
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/
Hi Won,
Thanks for the patch, I have now merged to drm-misc-next
Regards
Manasi
On Mon, Apr 17, 2023 at 3:52 PM Manasi Navare wrote:
>
> On Tue, Mar 28, 2023 at 6:45 PM Won Chung wrote:
> >
> > Expose DRM connector id in device sysfs so that we can map the connector
>
i.kroge...@linux.intel.com/
> USB4:
> https://lore.kernel.org/all/20220418175932.1809770-3-wonch...@google.com/
> So, we follow the same pattern in this patch.
>
> Signed-off-by: Won Chung
> Acked-by: Heikki Krogerus
> Reviewed-by: Manasi Navare
> ---
> Changes fro
,
> +};
> +
> static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810");
>
> /**
> @@ -353,9 +383,16 @@ int drm_sysfs_connector_add(struct drm_connector
> *connector)
>
> connector->kdev = kdev;
>
> + if (dev_fwnode(kdev)) {
&
tell which port is deriving which displays even with
> a MST hub. Chromium patch for parsing DRM connector id from the kernel
> is at http://crrev.com/c/4317207.
>
> Signed-off-by: Won Chung
Exposing connector id in device sysfs looks good to me.
Reviewed-by: Manasi Navare
Manasi
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connector.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index a50c82bc2b2f..76a8c707c34b 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
lle)
Cc: Ville Syrjälä
Cc: Simon Ser
Cc: Pekka Paalanen
Cc: Daniel Stone
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/
review comments because the crtc gets stolen only after the atomic_check
call.
Cc: Ville Syrjälä
Cc: Simon Ser
Cc: Pekka Paalanen
Cc: Daniel Stone
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic.c | 6 --
1 file changed, 4
: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 5b4547e0f775..d7acd6bbd97e 100644
--- a/drivers
.
Cc: Ville Syrjala
Cc: Daniel Vetter
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic.c | 29 -
1 file changed, 29 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index b1efa9322be2..48b2262d69f6 100644
--- a/drivers
On Mon, Jul 20, 2020 at 05:40:10PM -0700, Almahallawy, Khaled wrote:
> On Mon, 2020-07-20 at 17:07 -0700, Manasi Navare wrote:
> > On Mon, Jul 20, 2020 at 04:41:25PM -0700, Khaled Almahallawy wrote:
> > > Add the missing CP2520 pattern 2 and 3 phy compliance patterns
> &g
On Mon, Jul 20, 2020 at 04:41:26PM -0700, Khaled Almahallawy wrote:
> Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests.
>
> Signed-off-by: Khaled Almahallawy
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 14 --
> drivers/gpu/drm/i915/i915_reg.h | 4 +++
On Mon, Jul 20, 2020 at 04:41:25PM -0700, Khaled Almahallawy wrote:
> Add the missing CP2520 pattern 2 and 3 phy compliance patterns
>
> Signed-off-by: Khaled Almahallawy
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 +-
> include/drm/drm_dp_helper.h | 4 +++-
> 2 files changed, 4 insertions(+
-off-by: Bhanuprakash Modem
Cc: Nicholas Kazlauskas
Cc: Harry Wentland
Cc: Alex Deucher
Cc: Manasi Navare
Cc: AMD gfx
Reviewed-by: Nicholas Kazlauskas
---
.../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 ---
1 file changed, 20 deletions(-)
diff --git a/drivers/gpu/drm/amd
to rebase
> v8:
> * Move debugfs node creation logic to DRM (Emil)
> * Remove AMD specific logic (Emil)
> v9:
> * Seperate patch for removal of AMD specific logic (Manasi)
>
> Signed-off-by: Bhanuprakash Modem
> Signed-off-by: Manasi Navare
> Cc: Ja
Modem
Cc: Nicholas Kazlauskas
Cc: Harry Wentland
Cc: Alex Deucher
Cc: Manasi Navare
Cc: AMD gfx
Reviewed-by: Nicholas Kazlauskas
---
.../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 ---
1 file changed, 20 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm
c to DRM (Emil)
> * Remove AMD specific logic (Emil)
> v9:
> * Seperate patch for removal of AMD specific logic (Manasi)
>
> Signed-off-by: Bhanuprakash Modem
> Signed-off-by: Manasi Navare
> Cc: Jani Nikula
> Cc: Ville Syrjälä
> Cc: Harry Wentlan
gic should move to core DRM.
> >
> >This reverts commit 727962f030c23422a01e8b22d0f463815fb15ec4.
> >
> >Signed-off-by: Bhanuprakash Modem
> >Cc: Nicholas Kazlauskas
> >Cc: Harry Wentland
> >Cc: Alex Deucher
> >Cc: Manasi Navare
> >Cc: AMD gfx
>
Thanks for the review, pushed to drm-misc
Manasi
On Sat, Jun 20, 2020 at 02:53:54AM +0530, Bhanuprakash Modem wrote:
> From: Manasi Navare
>
> DP sink device sets the Ignore MSA bit in its
> DP_DOWNSTREAM_PORT_COUNT register to indicate its ability to
> ignore the MSA video ti
base
> v5:
> * Rename to vrr_range to match AMD debugfs
> v6:
> * Rebase (manasi)
> v7:
> * Fix cmpilation due to rebase
> v8:
> * Move debugfs node creation logic to DRM (Emil)
> * Remove AMD specific logic (Emil)
>
> Signed-off-by: Bhanuprakash Modem
> Signed-o
@Jani N, could you give an ACK on this if this looks okay, addressed
your review comments regarding the name of the function.
Else I have a r-b functionality wise so good to get merged?
Regards
Manasi
On Fri, Jun 12, 2020 at 04:04:42PM -0700, Manasi Navare wrote:
> DP sink device sets the Ign
On Tue, Jun 16, 2020 at 04:34:07PM +0100, Emil Velikov wrote:
> On Mon, 15 Jun 2020 at 22:47, Manasi Navare wrote:
> >
> > On Mon, Jun 15, 2020 at 10:36:28PM +0100, Emil Velikov wrote:
> > > Hi Manasi,
> > >
> > > On Sat, 13 Jun 2020 at 00:55, Manasi
On Mon, Jun 15, 2020 at 10:36:28PM +0100, Emil Velikov wrote:
> Hi Manasi,
>
> On Sat, 13 Jun 2020 at 00:55, Manasi Navare wrote:
> >
> > From: Bhanuprakash Modem
> >
> > [Why]
> > It's useful to know the min and max vrr range for IGT testing.
> &
VRR capable to display Yes or No (Manasi)
* Fix indentation checkpatch errors (Manasi)
Signed-off-by: Bhanuprakash Modem
Signed-off-by: Manasi Navare
Cc: Jani Nikula
Cc: Ville Syrjälä
Tested-by: Manasi Navare
---
.../drm/i915/display/intel_display_debugfs.c | 22 ++-
1 f
rough debugfs
Aditya Swarup (1):
drm/i915/dp: Attach and set drm connector VRR property
Bhanuprakash Modem (1):
drm/i915/dp: Expose connector VRR monitor range via debugfs
Manasi Navare (1):
drm/dp: DRM DP helper for reading Ignore MSA from DPCD
.../drm/i915/display/intel_display_debugfs.c
that it is Adaptive sync
capable.
v3:
* Fi the typo in commit message (Manasi)
v2:
* Rename to describe what the function does (Jani Nikula)
Cc: Jani Nikula
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Signed-off-by: Manasi Navare
Reviewed-by: Harry Wentland
---
include/drm
(Manasi)
v4:
* Rebase (Mansi)
v3:
* intel_dp_is_vrr_capable can be used for debugfs, make it
non static (Manasi)
v2:
* Just set this in intel_dp_get_modes instead of new hook (Jani)
Cc: Ville Syrjälä
Cc: Jani Nikula
Signed-off-by: Aditya Swarup
Signed-off-by: Manasi Navare
---
drivers/gpu/drm
(Manasi)
* Fix indentation checkpatch errors (Manasi)
Signed-off-by: Bhanuprakash Modem
Signed-off-by: Manasi Navare
Cc: Jani Nikula
Cc: Ville Syrjälä
Tested-by: Manasi Navare
---
.../drm/i915/display/intel_display_debugfs.c | 20 +++
1 file changed, 20 insertions(+)
diff --gi
On Fri, Jun 12, 2020 at 10:21:31PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 12, 2020 at 12:12:25PM -0700, Manasi Navare wrote:
> > On Fri, Jun 12, 2020 at 10:01:19PM +0300, Ville Syrjälä wrote:
> > > On Fri, Jun 12, 2020 at 11:44:13AM -0700, Manasi Navare wrote:
> > > &
On Fri, Jun 12, 2020 at 10:01:19PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 12, 2020 at 11:44:13AM -0700, Manasi Navare wrote:
> > On Fri, Jun 12, 2020 at 09:36:37PM +0300, Ville Syrjälä wrote:
> > > On Fri, Jun 12, 2020 at 11:25:42AM -0700, Manasi Navare wrote:
> > > &
On Fri, Jun 12, 2020 at 09:36:37PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 12, 2020 at 11:25:42AM -0700, Manasi Navare wrote:
> > On Fri, Jun 05, 2020 at 12:03:19AM +0300, Ville Syrjälä wrote:
> > > On Thu, Jun 04, 2020 at 08:01:03PM +, Almahallawy, Khaled wrote:
> >
On Thu, Jun 04, 2020 at 08:01:03PM +, Almahallawy, Khaled wrote:
> On Thu, 2020-06-04 at 22:06 +0300, Ville Syrjälä wrote:
> > On Thu, Jun 04, 2020 at 10:33:48AM +0530, Vidya Srinivas wrote:
> > > Signed-off-by: Khaled Almahallawy
> > > Signed-off-by: Vidya Srinivas
> > > ---
> > > drivers/g
On Fri, Jun 05, 2020 at 12:03:19AM +0300, Ville Syrjälä wrote:
> On Thu, Jun 04, 2020 at 08:01:03PM +, Almahallawy, Khaled wrote:
> > On Thu, 2020-06-04 at 22:06 +0300, Ville Syrjälä wrote:
> > > On Thu, Jun 04, 2020 at 10:33:48AM +0530, Vidya Srinivas wrote:
> > > > Signed-off-by: Khaled Almah
e and how it should
> > > handle it. The logic described has been implemented in igt [1].
> > >
> > > [1]:
> > > https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/fbe61f529737191d0920521946a575bd55f00fbe
> > >
> > > Signed
o display Yes or No (Manasi)
> * Fix indentation checkpatch errors (Manasi)
>
> Signed-off-by: Bhanuprakash Modem
> Signed-off-by: Manasi Navare
> Cc: Jani Nikula
> Cc: Ville Syrjälä
> Tested-by: Manasi Navare
> ---
> .../drm/i915/display/intel_display_debugfs.c
Fix indentation checkpatch errors (Manasi)
Signed-off-by: Bhanuprakash Modem
Signed-off-by: Manasi Navare
Cc: Jani Nikula
Cc: Ville Syrjälä
Tested-by: Manasi Navare
---
.../drm/i915/display/intel_display_debugfs.c | 22 ++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --gi
that it is Adaptive sync
capable.
v3:
* Fi the typo in commit message (Manasi)
v2:
* Rename to describe what the function does (Jani Nikula)
Cc: Jani Nikula
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Signed-off-by: Manasi Navare
Reviewed-by: Harry Wentland
---
include/drm
(Manasi)
v4:
* Rebase (Mansi)
v3:
* intel_dp_is_vrr_capable can be used for debugfs, make it
non static (Manasi)
v2:
* Just set this in intel_dp_get_modes instead of new hook (Jani)
Cc: Ville Syrjälä
Cc: Jani Nikula
Signed-off-by: Aditya Swarup
Signed-off-by: Manasi Navare
---
drivers/gpu/drm
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/27
> Signed-off-by: Ville Syrjälä
Makes total sense,
Reviewed-by: Manasi Navare
Manasi
> ---
> drivers/gpu/drm/drm_edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/driver
(Manasi)
v2:
* Just set this in intel_dp_get_modes instead of new hook (Jani)
Cc: Ville Syrjälä
Cc: Jani Nikula
Signed-off-by: Aditya Swarup
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/display/intel_dp.c | 24
drivers/gpu/drm/i915/display/intel_dp.h | 2 ++
2
that it is Adaptive sync
capable.
v3:
* Fi the typo in commit message (Manasi)
v2:
* Rename to describe what the function does (Jani Nikula)
Cc: Jani Nikula
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Signed-off-by: Manasi Navare
Reviewed-by: Harry Wentland
---
include/drm
nuprakash Modem
Signed-off-by: Manasi Navare
Cc: Jani Nikula
Cc: Ville Syrjälä
Tested-by: Manasi Navare
---
.../drm/i915/display/intel_display_debugfs.c | 22 ++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
b/
Fix the typo in max_vfreq (Manasi)
* Change the name of node to i915_vrr_info so we can add
other vrr info for more debug info (Manasi)
* Change the VRR capable to display Yes or No (Manasi)
* Fix indentation checkpatch errors (Manasi)
Signed-off-by: Bhanuprakash Modem
Signed-off-by: Manasi Navare
Cc:
that it is Adaptive sync
capable.
v3:
* Fi the typo in commit message (Manasi)
v2:
* Rename to describe what the function does (Jani Nikula)
Cc: Jani Nikula
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Signed-off-by: Manasi Navare
Reviewed-by: Harry Wentland
---
include/drm
set this in intel_dp_get_modes instead of new hook (Jani)
Cc: Ville Syrjälä
Cc: Jani Nikula
Signed-off-by: Aditya Swarup
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/display/intel_dp.c | 24
drivers/gpu/drm/i915/display/intel_dp.h | 2 ++
2 files changed, 26
@Jani @Ville, this is the one we had discussed on IRC, could you
take a look at this patch?
Manasi
On Tue, Mar 24, 2020 at 06:22:01PM -0700, Manasi Navare wrote:
> From: Aditya Swarup
>
> This function sets the VRR property for connector based
> on the platform support, EDID monit
On Tue, Mar 17, 2020 at 09:25:33AM -0400, Harry Wentland wrote:
>
>
> On 2020-03-17 5:08 a.m., Simon Ser wrote:
> > On Thursday, March 12, 2020 3:43 PM, Harry Wentland
> > wrote:
> >
> >> Not the main VRR expert and we're still discussing this internally but I
> >> think it'll very much depend
: Jani Nikula
Signed-off-by: Aditya Swarup
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/display/intel_dp.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index ef2e06e292d5
that it is Adaptive sync
capable.
v2:
* Rename to describe what the function does (Jani Nikula)
Cc: Jani Nikula
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Signed-off-by: Manasi Navare
Reviewed-by: Harry Wentland
---
include/drm/drm_dp_helper.h | 8
1 file changed
On Thu, Mar 19, 2020 at 11:59:38AM +0200, Jani Nikula wrote:
> On Tue, 17 Mar 2020, Manasi Navare wrote:
> > DP sink device sets the Ignore MSA bit in its
> > DP_DOWNSTREAM_PORT_COUNT register to indicate its ability to
> > ignore the MSA video timing paramaters and i
On Thu, Mar 19, 2020 at 12:07:37PM +0200, Jani Nikula wrote:
> On Tue, 17 Mar 2020, Manasi Navare wrote:
> > This patch adds a hook in drm_connector_helper_funcs to get the
> > support of the driver for adaptive sync functionality.
> >
> > This can be called in the conn
On Thu, Mar 19, 2020 at 12:14:28PM +0200, Jani Nikula wrote:
> On Tue, 17 Mar 2020, Manasi Navare wrote:
> > This defines the get_vrr_support hook for intel DP connector
> > VRR support is set to true based on the DPCD ignore MSA and
> > EDID monitor range
>
> Yeah...
Nikula
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_probe_helper.c | 4
include/drm/drm_modeset_helper_vtables.h | 16
2 files changed, 20 insertions(+)
diff --git a/drivers/gpu/drm
that it is Adaptive sync
capable.
Cc: Jani Nikula
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Signed-off-by: Manasi Navare
---
include/drm/drm_dp_helper.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
This defines the get_vrr_support hook for intel DP connector
VRR support is set to true based on the DPCD ignore MSA and
EDID monitor range
Cc: Jani Nikula
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Cc: Aditya Swarup
Signed-off-by: Manasi Navare
---
.../drm/i915/display
Taylor
Cc: Kazlauskas Nicholas
Signed-off-by: Manasi Navare
Reviewed-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_edid.c | 44 +
include/drm/drm_connector.h | 22 +++
2 files changed, 66 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c
This patch adds defines for the detailed monitor
range flags as per the EDID specification.
v2:
* Rename the flags with DRM_EDID_ (Jani N)
Suggested-by: Ville Syrjälä
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Clinton A Taylor
Cc: Kazlauskas Nicholas
Cc: Jani Nikula
Signed-off-by: Manasi
On Tue, Mar 10, 2020 at 09:13:30PM +0200, Ville Syrjälä wrote:
> On Tue, Mar 10, 2020 at 12:08:33PM -0700, Manasi Navare wrote:
> > Hi Ville,
> >
> > Please find answers to your concerns below:
> >
> > On Mon, Mar 09, 2020 at 02:39:40PM -0700, Manasi Navare wro
On Tue, Mar 10, 2020 at 06:20:27PM +0200, Ville Syrjälä wrote:
> On Mon, Mar 09, 2020 at 02:39:39PM -0700, Manasi Navare wrote:
> > This patch adds defines for the detailed monitor
> > range flags as per the EDID specification.
> >
> > v2:
> > * Rename
Hi Ville,
Please find answers to your concerns below:
On Mon, Mar 09, 2020 at 02:39:40PM -0700, Manasi Navare wrote:
> Adaptive Sync is a VESA feature so add a DRM core helper to parse
> the EDID's detailed descritors to obtain the adaptive sync monitor range.
> Store this i
This patch adds defines for the detailed monitor
range flags as per the EDID specification.
v2:
* Rename the flags with DRM_EDID_ (Jani N)
Suggested-by: Ville Syrjälä
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Clinton A Taylor
Cc: Kazlauskas Nicholas
Cc: Jani Nikula
Signed-off-by: Manasi
ned-off-by: Manasi Navare
Reviewed-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_edid.c | 44 +
include/drm/drm_connector.h | 22 +++
2 files changed, 66 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_ed
On Mon, Mar 09, 2020 at 10:35:52AM +0200, Jani Nikula wrote:
> On Fri, 06 Mar 2020, Manasi Navare wrote:
> > On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote:
> >> On Thu, 05 Mar 2020, Manasi Navare wrote:
> >> > This patch adds defines for the detailed
On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote:
> On Thu, 05 Mar 2020, Manasi Navare wrote:
> > This patch adds defines for the detailed monitor
> > range flags as per the EDID specification.
> >
> > Suggested-by: Ville Syrjälä
> > Cc: Ville Syrjäl
This patch adds defines for the detailed monitor
range flags as per the EDID specification.
Suggested-by: Ville Syrjälä
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Clinton A Taylor
Cc: Kazlauskas Nicholas
Signed-off-by: Manasi Navare
---
include/drm/drm_edid.h | 5 +
1 file changed, 5
sync_range function static (Harry, Jani)
v2:
* Change vmin and vmax to use u8 (Ville)
* Dont store pixel clock since that is just a max dotclock
and not related to VRR mode (Manasi)
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Clinton A Taylor
Cc: Kazlauskas Nicholas
Signed-off-by: Manasi Navare
--
On Tue, Mar 03, 2020 at 03:42:12PM +0200, Ville Syrjälä wrote:
> On Mon, Mar 02, 2020 at 04:08:59PM -0800, Manasi Navare wrote:
> > Adaptive Sync is a VESA feature so add a DRM core helper to parse
> > the EDID's detailed descritors to obtain the adaptive sync monitor range.
&g
le)
* Dont store pixel clock since that is just a max dotclock
and not related to VRR mode (Manasi)
Cc: Ville Syrjälä
Cc: Harry Wentland
Cc: Clinton A Taylor
Cc: Kazlauskas, Nicholas
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_edid.c | 44 +
i
On Mon, Mar 02, 2020 at 09:15:27AM -0500, Kazlauskas, Nicholas wrote:
> On 2020-02-28 9:38 p.m., Manasi Navare wrote:
> >On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote:
> >>On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote:
> >>>On Tue, Ja
On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote:
> On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote:
> > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote:
> > > Adaptive Sync is a VESA feature so add a DRM core helper to parse
> &g
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote:
> > Adaptive Sync is a VESA feature so add a DRM core helper to parse
> > the EDID's detailed descritors to obtain the adaptive sync monitor range.
&g
On Tue, Jan 14, 2020 at 08:31:22AM -0500, Harry Wentland wrote:
> Fixing Nick's email.
>
> On 2020-01-10 5:43 p.m., Manasi Navare wrote:
> > On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote:
> >> On Tue, 07 Jan 2020, Manasi Navare wrote:
> >>>
On Tue, Jan 14, 2020 at 03:07:56PM +0200, Ville Syrjälä wrote:
> On Mon, Jan 13, 2020 at 04:39:00PM -0800, Manasi Navare wrote:
> > Hi Ville,
> >
> > So the two major changes you would like to see here are:
> >
> > use version_greate(ed
?
Manasi
On Fri, Jan 10, 2020 at 03:17:43PM -0800, Manasi Navare wrote:
> On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote:
> > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote:
> > > Adaptive Sync is a VESA feature so add a DRM core helper to pars
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote:
> > Adaptive Sync is a VESA feature so add a DRM core helper to parse
> > the EDID's detailed descritors to obtain the adaptive sync monitor range.
&g
On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote:
> On Tue, 07 Jan 2020, Manasi Navare wrote:
> > Adaptive Sync is a VESA feature so add a DRM core helper to parse
> > the EDID's detailed descritors to obtain the adaptive sync monitor range.
> >
so I would
leave the usage of this to you and Nicholas depending on what works better in
your driver.
Regards
Manasi
On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote:
> Adaptive Sync is a VESA feature so add a DRM core helper to parse
> the EDID's detailed descritors
Kazlauskas
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_edid.c | 51 +
include/drm/drm_connector.h | 22
include/drm/drm_edid.h | 2 ++
3 files changed, 75 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/
Harry, Jani - Since this also updates the AMD driver file, should this be
merged through
AMD tree and then backmerged to drm-misc ?
Manasi
On Mon, Dec 30, 2019 at 09:45:15PM +0530, Animesh Manna wrote:
> [Why]:
> Aligh with DP spec wanted to follow same naming convention.
>
> [How]:
> Changed t
On Thu, Jan 02, 2020 at 11:23:14AM +0200, Jani Nikula wrote:
> On Mon, 30 Dec 2019, Animesh Manna wrote:
> > As per request from DP phy compliance test few special
> > test pattern need to set by source. Added function
> > to set pattern in DP_COMP_CTL register. It will be
> > called along with ot
On Thu, Jan 02, 2020 at 03:56:09PM +0530, Manna, Animesh wrote:
> On 02-01-2020 14:48, Jani Nikula wrote:
> >On Mon, 30 Dec 2019, Animesh Manna wrote:
> >>vswing/pre-emphasis adjustment calculation is needed in processing
> >>of auto phy compliance request other than link training, so moved
> >>th
On Wed, Dec 18, 2019 at 09:43:49PM +0530, Manna, Animesh wrote:
>
> On 18-12-2019 21:12, Harry Wentland wrote:
> >On 2019-12-18 10:13 a.m., Animesh Manna wrote:
> >>[Why]:
> >>Aligh with DP spec wanted to follow same naming convention.
> >>
> >>[How]:
> >>Changed the macro name of the dpcd address
On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote:
> DRM Fb driver expects multiple CRTCs if it sees connector->has_tile
> is set, but we need to handle tile support and look for multiple CRTCs
> only for the modes that match the tile size. The other modes should
>
Did you look at the build failure here?
The build fails for amdgpu that uses the old #define of DP_TEST_PHY_PATTERN
So you will have to send a patch for the amdgpu wherever they are using the
older #define
along with this with correct explanation that name changed to match the spec.
Manasi
On Mo
On Mon, Nov 18, 2019 at 11:55:55PM +0530, Animesh Manna wrote:
> During phy compliance auto test mode source need to read
> requested test pattern from sink through DPCD. After processing
> the request source need to set the pattern. So set/get method
> added in drm layer as it is DP protocol.
You
the check to match the tile size with requested mode
to handle the tile support.
Cc: Ville Syrjälä
Cc: Maarten Lankhorst
Cc: Jani Nikula
Cc: Dave Airlie
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_fb_helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/
is pruned (Dave)
v1:
* Just handle the 1st connector hotplug case
* v1 Reviewed-by: Dave Airlie
Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5
Suggested-by: Ville Syrjälä
Suggested-by: Dave Airlie
Cc: Ville Syrjälä
Cc: Dave Airlie
Signed-off-by: Manasi Navare
Reviewed-by: Dave
: Unplug master/slave:
It does a full modeset and displays next lower mode
Case5: Hotplug second port back in:
It now does a full modeset again to display full 8K
Manasi Navare (5):
drm: Handle connector tile support only for modes that match tile size
drm/fbdev: Fallback to non tiled mode if all
("drm/i915/display/icl: Disable transcoder port sync as
part of crtc_disable() sequence")
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drive
://gitlab.freedesktop.org/drm/intel/issues/5
Cc: Ville Syrjälä
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/display/intel_display.c | 28 ++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display
the check to match the tile size with requested mode
to handle the tile support.
Cc: Ville Syrjälä
Cc: Maarten Lankhorst
Cc: Jani Nikula
Cc: Dave Airlie
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_fb_helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/
Syrjälä
Cc: Ville Syrjälä
Cc: José Roberto de Souza
Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/display/intel_display.c | 78
1 file changed, 78 insertions(+)
diff --git a/drivers/gpu/drm/i915/display
is pruned (Dave)
v1:
* Just handle the 1st connector hotplug case
* v1 Reviewed-by: Dave Airlie
Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5
Suggested-by: Ville Syrjälä
Suggested-by: Dave Airlie
Cc: Ville Syrjälä
Cc: Dave Airlie
Signed-off-by: Manasi Navare
Reviewed-by: Dave
Pushed tod rm-misc-next, thanks a lot Dave all the feedback and reviews.
Regards
Manasi
On Wed, Nov 13, 2019 at 02:29:52PM -0800, Manasi Navare wrote:
> In case of tiled displays, if we hotplug just one connector,
> fbcon currently just selects the preferred mode and if it is
> tiled
hotplug case
* v1 Reviewed-by: Dave Airlie
Suggested-by: Ville Syrjälä
Suggested-by: Dave Airlie
Cc: Ville Syrjälä
Cc: Dave Airlie
Signed-off-by: Manasi Navare
Reviewed-by: Dave Airlie
---
drivers/gpu/drm/drm_client_modeset.c | 70
1 file changed, 70 insertions
1 - 100 of 685 matches
Mail list logo