Re: [PATCH v4] drm: atmel-hlcdc: replace dev_* print functions with drm_* variants

On 14/08/25 4:09 am, Eslam Khafagy wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Update the Atmel HLCDC code to use DRM print macros drm_*() instead of > dev_warn() and dev_err(). This change ensures consistency with DRM > subsystem logg

Re: [PATCH v3] drm: atmel-hlcdc: replace dev_* print funtions with drm_* variants

Hi Eslam Khafagy, On 12/08/25 2:38 am, Eslam Khafagy wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know > the content is safe > > On 8/11/25 11:54, manikanda...@microchip.com wrote: >> Hi Eslam Khafagy, > Hi Manikandan, >> >> The patch appears to have been sent with sp

Re: [PATCH v3] drm: atmel-hlcdc: replace dev_* print funtions with drm_* variants

Hi Eslam Khafagy, The patch appears to have been sent with spaces in place of tabs in the diff, which breaks kernel coding style [1] and makes it fail to apply. Please ensure your editor is configured to use tabs for indentation and use `git send-email` or b4 directly, not via an email client th

Re: [PATCH v2 1/1] drm: atmel-hlcdc: replace dev_* print funtions with drm_* variants

Hi Eslam Khafagy, On 07/08/25 12:00 am, Eslam Khafagy wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > According to documentation[1] drm_* variants are preferred over dev_* > print functions. > > [1] > https://docs.kernel.org/gpu/todo.ht

Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

On 30/04/25 4:06 pm, Luca Ceresoli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hello Manikandan, > > On Wed, 30 Apr 2025 09:42:16 + > wrote: > > [...] > >>> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c >>> b/drivers/gp

Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

On 25/04/25 12:29 am, Luca Ceresoli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > devm_drm_bridge_alloc() is the new API to be used for allocating (and > partially initializing) a private driver struct embedding a struct > drm_bridge. >

Re: [PATCH] drm/bridge: convert to use devm_platform_ioremap_resource()

On 06/02/25 8:15 pm, Maxime Ripard wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, 6 Feb 2025 15:17:13 +0800, oushixiong1...@163.com wrote: >> From: Shixiong Ou >> >> convert to use devm_platform_ioremap_resource(). >> >> Signed-o

Re: [PATCH 1/3] drm: atmel-hlcdc: add support for LVDS encoder type

Hi, A gentle reminder to review this series. On 21/11/24 2:53 pm, Manikandan Muralidharan wrote: > From: Dharma Balasubiramani > > Add support for encoder type "DRM_MODE_ENCODER_LVDS" with the following > bus formats: > - RGB888_1X7X4_SPWG > - RGB888_1X7X4_JEIDA > - RGB666_1X7

Re: [PATCH] drm: atmel-hlcdc: fix atmel_xlcdc_plane_setup_scaler()

Hi, A gentle reminder to merge this patch. On 21/10/24 1:26 pm, Nicolas Ferre wrote: > On 14/10/2024 at 11:49, Manikandan Muralidharan wrote: >> From: Cyrille Pitchen >> >> On SoCs, like the SAM9X75, which embed the XLCDC ip, the registers that >> configure the unified scaling engine were not fi

Re: [PATCH] drm: atmel-hlcdc: update the LCDC_ATTRE register in plane atomic_disable

Hi, A gentle reminder to merge this patch. Let me know if any further changes are needed. On 14/10/24 3:14 pm, Nicolas Ferre wrote: > On 14/10/2024 at 08:46, Manikandan Muralidharan wrote: >> update the LCDC_ATTRE register in drm plane atomic_disable to handle >> the configuration changes of eac

Re: [PATCH v2] drm/atmel_hlcdc: Fix uninitialized variable

On 07/10/24 8:39 pm, Advait Dhamorikar wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > atmel_hlcdc_plane_update_buffers: may use an uninitialized > sr variable when the if condition remains unsatisfied. > The variable may contain an arbitr

Re: [PATCH] drm/atmel_hlcdc: Fix uninitialized variable

Hi Shuah and Advait, On 05/10/24 12:41 am, Shuah Khan wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know > the content is safe > > On 10/4/24 09:08, Advait Dhamorikar wrote: >> atmel_hlcdc_plane_update_buffers: may use an uninitialized >> sr variable when the if cond

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

On 27/09/24 4:51 am, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, Sep 26, 2024 at 03:58:11PM GMT, Maxime Ripard wrote: >> On Thu, Sep 26, 2024 at 04:32:59PM GMT, Dmitry Baryshkov wrote: >>> On Thu, Sep 26, 2024

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

On 23/09/24 11:37 am, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, Sep 23, 2024 at 05:50:22AM GMT, manikanda...@microchip.com wrote: >> On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: >>> EXTERNAL EMAIL: Do not cli

Re: [PATCH v4 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series

Hi Dmitry, On 20/09/24 9:45 pm, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Wed, Sep 18, 2024 at 04:01:17PM GMT, Manikandan Muralidharan wrote: >> Add the Microchip's DSI controller wrapper driver that uses >> the

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

On 20/09/24 9:13 pm, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: >> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 >> Display module wit

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

Hi Krzysztof, On 17/09/24 4:07 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 17/09/2024 11:53, Manikandan Muralidharan wrote: >> Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel >> compatible s

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-mipi-dsi binding

On 17/09/24 6:08 pm, Conor Dooley wrote: > On Tue, Sep 17, 2024 at 03:16:53AM +,manikanda...@microchip.com wrote: >> Hi Conor, >> >> On 14/08/24 7:29 pm, Conor Dooley wrote: >>> On Wed, Aug 14, 2024 at 04:22:53PM +0530, Manikandan Muralidharan wrote: Add the 'sam9x75-mipi-dsi' compatible

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-mipi-dsi binding

Hi Conor, On 14/08/24 7:29 pm, Conor Dooley wrote: > On Wed, Aug 14, 2024 at 04:22:53PM +0530, Manikandan Muralidharan wrote: >> Add the 'sam9x75-mipi-dsi' compatible binding, which describes the >> Microchip's specific wrapper for the Synopsys DesignWare MIPI DSI HOST >> Controller for the sam9x7

Re: [PATCH 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series

On 11/07/24 3:28 pm, Conor Dooley wrote: > On Thu, Jul 11, 2024 at 11:05:37AM +0200, Krzysztof Kozlowski wrote: >> On 11/07/2024 10:30,manikanda...@microchip.com wrote: >>> Hi Krzysztof, >>> >>> On 04/07/24 4:27 pm, Krzysztof Kozlowski wrote: EXTERNAL EMAIL: Do not click links or open attachm

Re: [PATCH 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series

Hi Krzysztof, On 04/07/24 4:27 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 04/07/2024 10:48, Manikandan Muralidharan wrote: >> Add the Microchip's DSI controller wrapper driver that uses >> the Synopsys Desi

Re: [PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip AC40T08A MIPI Display panel

Hi Conor, On 01/07/24 3:33 pm, Conor Dooley wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > ForwardedMessage.eml > > Subject: > Re: [PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip > AC40T08A MIPI Display panel > From

Re: [bug report] drm: atmel-hlcdc: add driver ops to differentiate HLCDC and XLCDC IP

Hi Dan, Thank you for reporting the bug.I will prepare and send a fix-up patch soon. On 20/06/24 2:20 pm, Dan Carpenter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hello Manikandan Muralidharan, > > Commit aa71584b323a ("drm: atmel-

Re: [PATCH v7 0/7] Add support for XLCDC to sam9x7 SoC family.

On 05/10/23 2:59 pm, Manikandan Muralidharan wrote: > This patch series aims to add support for XLCDC IP of sam9x7 SoC family > to the DRM subsystem.XLCDC IP has additional registers and new > configuration bits compared to the existing register set of HLCDC IP. > The new compatible string "microch

Re: [PATCH v6 1/7] drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and HLCDC IP

On 03/10/23 5:46 pm, claudiu beznea wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 03.10.2023 07:18, manikanda...@microchip.com wrote: >> On 28/09/23 11:31 am, claudiu beznea wrote: >>> EXTERNAL EMAIL: Do not click links or open attach

Re: [PATCH v6 1/7] drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and HLCDC IP

On 28/09/23 11:31 am, claudiu beznea wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi, Manikandan, > > On 27.09.2023 12:47, Manikandan Muralidharan wrote: >> +void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, >> +

Re: [PATCH v4 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

On 09/09/23 9:50 pm, claudiu beznea wrote: > [You don't often get email from claudiu.bez...@tuxon.dev. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi, Manika

Re: [PATCH v2 0/9] Add support for XLCDC to sam9x7 SoC family.

On 12/07/23 8:10 am, Manikandan Muralidharan wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > This patch series aims to add support for XLCDC IP of sam9x7 SoC family > to the DRM subsystem.XLCDC IP has additional registers and new > configu

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

On 21/06/23 13:17, Nicolas Ferre wrote: > On 16/06/2023 at 08:44, Manikandan M - I67131 wrote: >> On 14/06/23 20:10, Nicolas Ferre wrote: >>> On 13/06/2023 at 20:21, Conor Dooley wrote: On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: > On 13/06/2023 09:04, Manikandan M

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

On 14/06/23 20:10, Nicolas Ferre wrote: > On 13/06/2023 at 20:21, Conor Dooley wrote: >> On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: >>> On 13/06/2023 09:04, Manikandan Muralidharan wrote: Add new compatible string for the XLCD controller on SAM9X7 SoC. Signe

Re: [PATCH 6/9] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

On 14/06/23 12:40, Claudiu Beznea - M18063 wrote: > On 13.06.2023 10:04, Manikandan Muralidharan wrote: >> - XLCDC in SAM9X7 has different sets of registers and additional >> configuration bits when compared to previous HLCDC IP. Read/write >> operation on the controller registers is now separated

Re: [PATCH 6/9] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

On 13/06/23 23:47, Conor Dooley wrote: > On Tue, Jun 13, 2023 at 12:34:23PM +0530, Manikandan Muralidharan wrote: >> - XLCDC in SAM9X7 has different sets of registers and additional >> configuration bits when compared to previous HLCDC IP. Read/write >> operation on the controller registers is now

Re: [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC

On 14/06/23 12:19, Claudiu Beznea - M18063 wrote: > On 13.06.2023 10:04, Manikandan Muralidharan wrote: >> From: Durai Manickam KR >> >> Add compatible string check to differentiate XLCDC and HLCDC code >> within the atmel-hlcdc driver files. >> >> Signed-off-by: Durai Manickam KR >> Signed-off-b

Re: [PATCH 4/9] drm: atmel-hlcdc: Define SAM9X7 XLCDC specific registers

On 14/06/23 12:17, Claudiu Beznea - M18063 wrote: > Hi, Manikandan, > > On 13.06.2023 10:04, Manikandan Muralidharan wrote: >> From: Durai Manickam KR >> >> The register address of the XLCDC IP used in SAM9X7 are different from >> the previous HLCDC.Defining those address space with valid macros.